From patchwork Fri Nov 17 07:03:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?U3RhbmxleSBDaGFuZ1vmmIzogrLlvrdd?= X-Patchwork-Id: 165997 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp346391vqn; Thu, 16 Nov 2023 23:03:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFeg7XXnYqnjT4XE6DEvoJnxsFyeRREuIzKF1rxcSGqangZrrrppKzQLvk/Tc4kTq/7tmSN X-Received: by 2002:a17:90b:4b03:b0:280:4829:52cc with SMTP id lx3-20020a17090b4b0300b00280482952ccmr16583744pjb.37.1700204623550; Thu, 16 Nov 2023 23:03:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700204623; cv=none; d=google.com; s=arc-20160816; b=iy8jx10d4ufvzS5h6C4q4nT71031w7Dm9VXZGm/kDvZTdB2fzZ+JHQqgBHw53xOIAY CcT8lv5jzCeG+o6EEdi5NzckEHt0vQwH672QQkqeVkniNA18r+oQM9487Zd3f9New7g+ 1cxETo5NJtPsVYSpB+umFZudX+qrou5RTOPwkQMcdXGAQVqw8KXVf6U1y2SUXpLHswHW yR3Fnq2p9P9Z6s3GtQpdonbx8DmCesXyqFM+ZLcEq3RveyuTdIRIlRNiK/NKRpRJNMSa A/pBSYRVeoLfUOzx0oRKz91EsAHmDWIwZGh8ItYB3hc7q7AMyhK6LyXl8Nm3S55LhdtN uhpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Z5Yh8voG7g5iVpQS7Iyj1ZAIFJM/JZRCqtwZmDIgE0I=; fh=kcQjMKul7xY+IjIpSZq48ayPICfL75TOdtZhrwm4LQU=; b=oS6xrT4BmjZjAHK3Vsw7PWL49tatH9EhtKTX9z0TCHvLxg3dhWQGwdo1/ndq8XACrm ltQIsNt22hSbbEcBzI8SgrLrtDa9Phb336JwLNkwG2lyf+w+6lc7Ugk1wXx+H4Y0cM2a MvsIL6eDdLktR8PX7elWs62R3YyeUqjT3jwLjIdIbUyK5xVv6nHWEgB/swQvyILnDz3c wZP6z5JRtoHo6pTYFnrZ//Sbwd3eFf0FBznCrLkq4VDLXZCXvgR8RO6FZ+BfKo4TbAC/ /YHplAyN8B1uhvVn0I81TA5/EkuhABtxK5YmtF6UKb4en0VF8Nid+254Ax7wQqVQmGWk An3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id pw14-20020a17090b278e00b0027756e1f0c2si1401426pjb.7.2023.11.16.23.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 23:03:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 87F3C81B4AE1; Thu, 16 Nov 2023 23:03:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbjKQHD3 (ORCPT + 30 others); Fri, 17 Nov 2023 02:03:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjKQHD1 (ORCPT ); Fri, 17 Nov 2023 02:03:27 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84BB2129; Thu, 16 Nov 2023 23:03:21 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AH73BYb82943171, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AH73BYb82943171 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Nov 2023 15:03:12 +0800 Received: from RTEXMBS02.realtek.com.tw (172.21.6.95) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Fri, 17 Nov 2023 15:03:12 +0800 Received: from RTEXH36505.realtek.com.tw (172.21.6.25) by RTEXMBS02.realtek.com.tw (172.21.6.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Fri, 17 Nov 2023 15:03:11 +0800 Received: from localhost.localdomain (172.21.252.101) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server id 15.1.2375.32 via Frontend Transport; Fri, 17 Nov 2023 15:03:11 +0800 From: Stanley Chang To: Thinh Nguyen CC: Stanley Chang , Christophe JAILLET , Greg Kroah-Hartman , , Subject: [PATCH v3] usb: dwc3: add missing of_node_put and platform_device_put Date: Fri, 17 Nov 2023 15:03:05 +0800 Message-ID: <20231117070311.32502-1-stanley_chang@realtek.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-KSE-ServerInfo: RTEXMBS02.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 16 Nov 2023 23:03:41 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782793763385468880 X-GMAIL-MSGID: 1782793763385468880 of_get_compatible_child performs an of_node_get, so an of_node_put is required. Add platform_device_put to match with of_find_device_by_node. Fixes: 34c200483569 ("usb: dwc3: add Realtek DHC RTD SoC dwc3 glue layer driver") Signed-off-by: Stanley Chang Acked-by: Thinh Nguyen --- v1 to v2 change: 1. Modify the commit message. 2. Add of_node_get in the of_property_read_string() error path. v2 to v3 change: Fix the typo in commit message. --- drivers/usb/dwc3/dwc3-rtk.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-rtk.c b/drivers/usb/dwc3/dwc3-rtk.c index 590028e8fdcb..3cd6b184551c 100644 --- a/drivers/usb/dwc3/dwc3-rtk.c +++ b/drivers/usb/dwc3/dwc3-rtk.c @@ -183,10 +183,13 @@ static enum usb_device_speed __get_dwc3_maximum_speed(struct device_node *np) ret = of_property_read_string(dwc3_np, "maximum-speed", &maximum_speed); if (ret < 0) - return USB_SPEED_UNKNOWN; + goto out; ret = match_string(speed_names, ARRAY_SIZE(speed_names), maximum_speed); +out: + of_node_put(dwc3_np); + return (ret < 0) ? USB_SPEED_UNKNOWN : ret; } @@ -339,6 +342,9 @@ static int dwc3_rtk_probe_dwc3_core(struct dwc3_rtk *rtk) switch_usb2_role(rtk, rtk->cur_role); + platform_device_put(dwc3_pdev); + of_node_put(dwc3_node); + return 0; err_pdev_put: