From patchwork Thu Nov 16 18:07:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 165913 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:6513:b0:164:83eb:24d7 with SMTP id sk19csp42363rwb; Thu, 16 Nov 2023 10:08:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlVgV5K6UZA4vvMbnQg5OzlYonY3ZZE4sn0IlbS84AbL30SCojXEvau20030pfUixoqEJf X-Received: by 2002:a05:6808:a08:b0:3a8:6a40:7dc0 with SMTP id n8-20020a0568080a0800b003a86a407dc0mr1083081oij.18.1700158104907; Thu, 16 Nov 2023 10:08:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700158104; cv=none; d=google.com; s=arc-20160816; b=ZnERG+pzvdP++9cgAp0/petl72/lBfvxEnBxh74537nenbi+GwcHzYNOFBWrA6zTHF lvOZ76fuA8nGdPLGQ1UmaKsVDqYUT5tUjWe/wkwunVrFzcR72mDSVjE7mYjf6po3PLOF n81I9+9VlNSv2uz94q+rwf/SnHsv9GarqnRXpd/4OIu+DAFuCBQpIRkYhpYPlkbSi8LZ UCPVITtqKtuN1X6nTJaPacrWNHErvUiaTmupLBrPsGlgJnaXhLEDAsgNkrrLoMf6VwjP dQS+IHzIutZQhB8aetytR3nLDxisvYhyMVQ9w071VToTRiuX+oBDC/kU39PIF66UkBc9 6dMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hPxzOncy5HIGVOblAN4i/IW7KR+JFRLvP+iQR6fOxe0=; fh=IQmJCxPvp1ZuEZ4xmMZzdl9jXmWmBntiQu4cA2IR9EY=; b=EtqaA4yJ34JFiZuCaKlCV4iYsT0jNWji12nJFmpMRNSmEFYCqkE+iIXwMM0urLHI6B 1Xo1UPCV7Zbng1HNexybWNOOud2mXJ+3m3DnN9GGGdki+FBHIs8wisO4BwZg+86tgM0A nMMmXy9lNVaPS2KSnkNwSkkAuWUgM0CSdONktZOhOsM96lzi6PUqXaRp5dxYKMqdxqcK uSOpA2+jmRpgItt1037kBpEbjEFJxCzKH8aaBpQfzIiORQnbKFxHoQkOhQDfFJ2unkie /OD5Cg7sCWCrm+CWDOduff48lFqLMNzy+HRsQeKdL98V0PwSr0YB1L6C5xfx9sdWlEbZ wtYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g3NlFgy2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id u3-20020a056808114300b003a86423b91fsi2687245oiu.166.2023.11.16.10.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 10:08:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g3NlFgy2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C20F381CDE2A; Thu, 16 Nov 2023 10:08:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345368AbjKPSID (ORCPT + 30 others); Thu, 16 Nov 2023 13:08:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231284AbjKPSIC (ORCPT ); Thu, 16 Nov 2023 13:08:02 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03C33D49 for ; Thu, 16 Nov 2023 10:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700158077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hPxzOncy5HIGVOblAN4i/IW7KR+JFRLvP+iQR6fOxe0=; b=g3NlFgy2WNFABIQMSA6+FYULD1hl+ZrQ1uavutzgH//ayBV2OksIxEsj1m2x+pyAyEwbOr 33+CrX6aFlcczFmd6wIwCEYOMSxwVpERHOvyVAc+UYKW8lRJjKbXXJtuYiUnTMG9O1baUX nGkCOz8963FLWx73omQYqudv52rEIyw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-hduKsP3VO6eiiLkjePYDqg-1; Thu, 16 Nov 2023 13:07:56 -0500 X-MC-Unique: hduKsP3VO6eiiLkjePYDqg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40a3efec9a7so6964435e9.1 for ; Thu, 16 Nov 2023 10:07:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700158073; x=1700762873; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hPxzOncy5HIGVOblAN4i/IW7KR+JFRLvP+iQR6fOxe0=; b=mNCCezryEw07UYd3kQKZeeSTVMXtuwBhOhEFYr1qIqwitIqgI2dTHneQrOxtqcYGHU FLHT+eIaKW82YSw5Ziv7ZzriM07bg9cuoZKGd28HWBD05vTwXWVUcD89bbZBfq+zha6u nOMp95DfmGKpBH329BFT7OjmqmDZ2ve7j3qT77q4k4/SLguf+H69W8YGFpoCIkk59z0W JFCj1FOId4mfyYGiRDHuHqW9qFmACrCvsnkqhzLXkm1AbQRk+Gzno6FsYm0hCbF1d+ta etO+KtwPaidcA6idcITjhDVxhMZM8nFLgPeI5mww39EIhmjG3n4EYRZVi/bAvgmShy+I iMPg== X-Gm-Message-State: AOJu0Yxup4L1PTK7KyQt4ZJa+iMvZ0AJ3np64vFetdy1krep1HmuWhg7 QTx3K29Cbxto3Ee8yc7ItBtaKvk8YRIM1m+RkpgSbFdGH1B51/a7i4K41pcaNdUrClYRfFTc+BO elXFKXu/ZtEpozZmgdSS+RygUC4PmeClNI1WtFP9ztjOfYKZ0WGs5qQghIN6ia7VeWu7wgoaUFK ESDIpjraA= X-Received: by 2002:a05:600c:c0f:b0:402:e68f:8896 with SMTP id fm15-20020a05600c0c0f00b00402e68f8896mr14609083wmb.0.1700158073656; Thu, 16 Nov 2023 10:07:53 -0800 (PST) X-Received: by 2002:a05:600c:c0f:b0:402:e68f:8896 with SMTP id fm15-20020a05600c0c0f00b00402e68f8896mr14609042wmb.0.1700158073266; Thu, 16 Nov 2023 10:07:53 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id w8-20020a05600c474800b0040836519dd9sm61664wmo.25.2023.11.16.10.07.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 10:07:52 -0800 (PST) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Sahaj Sarup , Javier Martinez Canillas , Conor Dooley , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Rob Herring , Thomas Zimmermann , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 1/3] dt-bindings: display: ssd1307fb: Change "solomon,page-offset" default value Date: Thu, 16 Nov 2023 19:07:37 +0100 Message-ID: <20231116180743.2763021-1-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 10:08:22 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782744984878541053 X-GMAIL-MSGID: 1782744984878541053 This is used to specify the page start address offset of the display RAM. The value is used as offset when setting the page start address with the SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to 1 if the property is not present in the Device Tree. But the datasheet mentions that the value on reset for the page start is a 0, so it makes more sense to also have 0 as the default value for the page offset if the property is not present. In fact, using a default value of 1 leads to the display not working when the fbdev is attached to the framebuffer console. Reported-by: Sahaj Sarup Signed-off-by: Javier Martinez Canillas --- .../devicetree/bindings/display/solomon,ssd1307fb.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml index 3afbb52d1b7f..badd81459aaa 100644 --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml @@ -35,7 +35,7 @@ properties: solomon,page-offset: $ref: /schemas/types.yaml#/definitions/uint32 - default: 1 + default: 0 description: Offset of pages (band of 8 pixels) that the screen is mapped to From patchwork Thu Nov 16 18:07:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 165912 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:6513:b0:164:83eb:24d7 with SMTP id sk19csp42197rwb; Thu, 16 Nov 2023 10:08:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFudsqQ0L1Sj5CHwOI81n81FthGO20I/nautoPptonKgQTuHZSEGIqD7uJz+/LjWjIn4y9I X-Received: by 2002:a17:902:ced1:b0:1cc:6597:f421 with SMTP id d17-20020a170902ced100b001cc6597f421mr11137136plg.48.1700158091366; Thu, 16 Nov 2023 10:08:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700158091; cv=none; d=google.com; s=arc-20160816; b=Pt72WihY5ggNflTGC03jIsAIxPxUAlvz8zlVZNdYAcIk1O01SYzDI/hlphl81obWeK Uoylv54kGDIC5kd3nsePP12QTvpwhT55ac2wXAvKdTrhL8A9o+Wz7FeynDmhpGj+RMv7 kvOqn7fiWKi2hv30oWucRTJifwhXj9qq+7OmwFd4IFpFPhuUz2BrrvwwmTSA12JPV82b 1MqbvBJRM1vGBeOsM6//GAkW/Nuwi/MKxVt0iGtoKNsxfxJU/pAPTn3hMxrp5KEZ6X1B 3ghdMPAkIvMO3YywxrKPCE9Y3IbOMdaNEIAHShwN67FMi038bLoFsuNdppxCkAS7LO6/ OPTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=W54lS/jbyFmKQJpxN3dQRiCf/ft7R1Q+OyFPgBZkh2k=; fh=ClnT/DlgPYyrvRTTio8EwcEWTwAS3w1eaPYjvGFKkX8=; b=0JpqRfvokN7XkXe/IDg1JyerhPqoc/6kI0QauWSZvbOFFJFrSwHgE9IHDIHHjOKR56 R1sMIDHmNyD/8rlVIEydMWPJhc6aLkGZq/Xd39iOuymatYHv7x3kSzX/WegoeXJgcgV7 yPWUaKFLCrfEuRA4NRKoZdpQOoKW2CIrIl3SzXbUko3u2UYycjU9GWpzy3yOrcP96Nvv Kfa2rRN9ENivvOz3JrdGlU4pgBFm85abIf+ctkphTRNtwEiPB/h+Cf8s91I4Dmr2fiDP Rf+kZbFY/mHCzF8sBGHcXJ902aAlTK7uOqJ4aLczv3h2LtwPhqEr1E9f9Rger96PpQJz UcCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eqhIonDB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id 12-20020a170902ee4c00b001cc76bea4fesi1338209plo.163.2023.11.16.10.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 10:08:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eqhIonDB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E888C815D7CE; Thu, 16 Nov 2023 10:08:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345401AbjKPSIF (ORCPT + 30 others); Thu, 16 Nov 2023 13:08:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231307AbjKPSIC (ORCPT ); Thu, 16 Nov 2023 13:08:02 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA3D519B for ; Thu, 16 Nov 2023 10:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700158079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W54lS/jbyFmKQJpxN3dQRiCf/ft7R1Q+OyFPgBZkh2k=; b=eqhIonDBpjIEJ90ik6n6HuCFFP4r/1TIzsOcrIBXYU+DBoECfeHQvs4aKBkP1atpX17y6h 67oMU+8dfWzgVAIZJwSvQwPk0Fo66RgSTI1AmRCbcsuwc2bjXIxy2Ww9yPhASHLuUOxnxo n4DcT7Seg5W/6Hu8DXi4wiDU1yRDL0M= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-31z9j3-ePwWdQuw9uwWvfA-1; Thu, 16 Nov 2023 13:07:57 -0500 X-MC-Unique: 31z9j3-ePwWdQuw9uwWvfA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-32db43129c6so544068f8f.1 for ; Thu, 16 Nov 2023 10:07:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700158076; x=1700762876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W54lS/jbyFmKQJpxN3dQRiCf/ft7R1Q+OyFPgBZkh2k=; b=WiquvTOARCvosNP4DimOwKaOHc4kzc8uN+GJ37VZ/p0GtthOUjcxDvUMxquABLtSzh K5SFu3mU7+Mmk/TPKai3P43dqi59ABnHzp/RwfTOsFaZoUUcm2eqq4pZ8uAK9/+1K6xv WP0E4Dqur721SSZ/sBPX+Tmil/VClDJmvW3BaK6vnpgCM+1FIZK+ilnmsK99Ic3bywvs Shzj3c0vnsgQaRAviH6KyX9DkQhQZCDvIyv+QcJAKOEjFr9l/2KFk+Li6E85BiOjcP2B hNEsK1/n0ck86RuWB+nG/QTztin8gsIlpJpOw8DAFHTIfcC/38RkNLNCiFkfF7cBKTyw XvSA== X-Gm-Message-State: AOJu0YxRiJ7FBh9CHww1ls5CFGA+oTxSYF8DhtZfZEA8CKAgxQGfyoSF WhmWbEEPPFhdhj6waK9hkFbvmuAGyhsaAtGc2HJemZf01+GcL9cdRj7zpOFayK9/1s6T2lcrKqK DUosLG/9V7DT7i8asjUW9Zjh73fJClso8SUaT7Zn1DWzEWaPhTedHb40egLc6v3o/k0hD1obwQq boOF8L0/I= X-Received: by 2002:a5d:4441:0:b0:32d:a688:8813 with SMTP id x1-20020a5d4441000000b0032da6888813mr11709933wrr.32.1700158076015; Thu, 16 Nov 2023 10:07:56 -0800 (PST) X-Received: by 2002:a5d:4441:0:b0:32d:a688:8813 with SMTP id x1-20020a5d4441000000b0032da6888813mr11709913wrr.32.1700158075741; Thu, 16 Nov 2023 10:07:55 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id p6-20020a5d48c6000000b0032db8cccd3asm32812wrs.114.2023.11.16.10.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 10:07:54 -0800 (PST) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Sahaj Sarup , Javier Martinez Canillas , Andy Shevchenko , Geert Uytterhoeven , Helge Deller , Sam Ravnborg , Thomas Zimmermann , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 2/3] fbdev: ssd1307fb: Change "solomon,page-offset" property default value Date: Thu, 16 Nov 2023 19:07:38 +0100 Message-ID: <20231116180743.2763021-2-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231116180743.2763021-1-javierm@redhat.com> References: <20231116180743.2763021-1-javierm@redhat.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 16 Nov 2023 10:08:10 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782744970970235787 X-GMAIL-MSGID: 1782744970970235787 This is used to specify the page start address offset of the display RAM. The value is used as offset when setting the page start address with the SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to 1 if the property is not present in the Device Tree. But the datasheet mentions that the value on reset for the page start is a 0, so it makes more sense to also have 0 as the default value for the page offset if the property is not present. In fact, using a default value of 1 leads to the display not working when the fbdev is attached to the framebuffer console. Reported-by: Sahaj Sarup Signed-off-by: Javier Martinez Canillas --- drivers/video/fbdev/ssd1307fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index 5ae48e36fccb..34f014bf4994 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -637,7 +637,7 @@ static int ssd1307fb_probe(struct i2c_client *client) par->height = 16; if (device_property_read_u32(dev, "solomon,page-offset", &par->page_offset)) - par->page_offset = 1; + par->page_offset = 0; if (device_property_read_u32(dev, "solomon,col-offset", &par->col_offset)) par->col_offset = 0; From patchwork Thu Nov 16 18:07:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 165914 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:6513:b0:164:83eb:24d7 with SMTP id sk19csp42486rwb; Thu, 16 Nov 2023 10:08:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IHcvdhw2BYR59HVt+p9KItClgRpPxxXhSN47qnuNZ4X20DWtKN+9cfLDTPO5dGGnPuB87nd X-Received: by 2002:a17:902:f54e:b0:1c9:f780:8070 with SMTP id h14-20020a170902f54e00b001c9f7808070mr12771231plf.19.1700158113447; Thu, 16 Nov 2023 10:08:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700158113; cv=none; d=google.com; s=arc-20160816; b=xQEA3lCmQyjc1XW29qsYs+woIThBDS6H+BaguGcl6aQoorw0H5rAG7/Z+nep6ibr0d WNMIunYRziw6AxYg/8jp/lGmveY+kSE7zbMGeitC9/xoMV8TjJLhxuZhsrq9M5+TPRMh q7/lQoy9GvK0p7yeizEx+ft0BUeobWfpoXjcMGeWwrvShjcsqGqc9ksVYpJKonQgSVk5 XRBkGOheyt7LtYPchkOVXRzcmBDb+oWpnqPtgntJqoevPjPzNO1N2uCsog+HnNtmC3rQ Ihclv+nb8rl/GhUlgTd8W0DIZ5q0XQ9moSz/HC4TTEr26Qq3wEUaDTNC9fTgmcMVSWrf BBqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=abMypBf5ucI4kN1b2IUT7QxG30gkYzFxCp5z4V1rKYE=; fh=3Zv55Ewp3pb2z3n4lYcg3b7V9G+WJAfUlIwwYEoRBtU=; b=NkmXXjVA9LR3i2YhMni2GT2s/1Cxy4xWS/JJhQWomB0dkjohPn+u2VTQH0ZW01rWKd k+gDo0rVKWrFJzHBuS8S6yWZD5do/d6dDgO+T+i31t6C2PelOirdHm8UtjEuMpf2roK8 vju//vc0rSOGevWBA9Clr9Fm+Ly4M3pFURRQ7wa6RxFWkgeESuPWB5pBxVtIAWP8lehe 6+LRzIV6zbl5Z9rcWvM7nkRlo8Qg2PTLB8vr0/WE2vT/PRa0c8lbwoWYj1IZXkf93YrQ lZ8bigguwkAQB1dZio4Miw0muYSYTZh0Q/w2DFIjoD30OOUr8SPDS1XbOhdOMlsrraAM ktOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DptkUAYX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id q9-20020a170902dac900b001c0c86a541asi13916632plx.375.2023.11.16.10.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 10:08:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DptkUAYX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 3841A81CEB07; Thu, 16 Nov 2023 10:08:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345436AbjKPSIJ (ORCPT + 30 others); Thu, 16 Nov 2023 13:08:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345421AbjKPSIH (ORCPT ); Thu, 16 Nov 2023 13:08:07 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BCCF195 for ; Thu, 16 Nov 2023 10:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700158083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=abMypBf5ucI4kN1b2IUT7QxG30gkYzFxCp5z4V1rKYE=; b=DptkUAYX9+gBJwotIhbneBWTZmUUrwZCqOk0YwhjYrBPLBYir0f8BeUnJ2AvaEX0SAY+JB tzu+b8QlW7z0TYhFdWVH60jgcAo6ywsPAeHOqVnZ4LgVNUoZSjYplvlsemOnudUPH/ySNx 3YMQv7eud3OwNbrBEeZnBeoKUYMkRxY= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-gfzvP2BAPL-AeZgb0sH-VA-1; Thu, 16 Nov 2023 13:08:00 -0500 X-MC-Unique: gfzvP2BAPL-AeZgb0sH-VA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c6ed315cc3so10312111fa.2 for ; Thu, 16 Nov 2023 10:08:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700158077; x=1700762877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=abMypBf5ucI4kN1b2IUT7QxG30gkYzFxCp5z4V1rKYE=; b=QJTfPq0+zw61imxxayzG+kFdu3pRKYwUyg1qvXJGWlLIuUCr8681x7OSzWyPG/iijQ mUDGfZAi99VdT0MZIE0bPQwJqpD3oF89lcmJAPvydVBcvj+hkPyk/T8/l4cl9L8vBCZl sLifro/FPB8TwuC3dNViTbo46EcKQa6n+zbzxtgE/5FiJcHLQZKe7BfSlanzHWdg4gnt w6zQbDHS8Zxbnx8oTXb2WQCzGHy+t0VoeI/o+46t4XrWsUioJHuKdshBa7CkJpXaLS8J dN20aAG/3jFOw9X9k2KT9ay8JvAgZHDTczSpVPLiFp3VM6SqTtkdyFG4dfvsZHEe9kLE 1/Dw== X-Gm-Message-State: AOJu0Ywvo8mDgLlIArsYumqn/mmlLknOXUc1ZOXgqEZlhoq2acqBAiaT DK8sM20bMomGN9O13QfHzq6LpaGcafum2G1tcHOf8Kudh2Vfg0qvKhhwKQQiDkWV6Co4nzAXlW+ O2hScNgh2NGlAjVmA2lWlYdmVsUmXcjh3qzjJlq3nq82QUFxiayiGG+qpG64X87GF46sPHP8wtS OMSrOM8C4= X-Received: by 2002:a2e:9b13:0:b0:2c5:2813:5534 with SMTP id u19-20020a2e9b13000000b002c528135534mr7628264lji.51.1700158077746; Thu, 16 Nov 2023 10:07:57 -0800 (PST) X-Received: by 2002:a2e:9b13:0:b0:2c5:2813:5534 with SMTP id u19-20020a2e9b13000000b002c528135534mr7628244lji.51.1700158077374; Thu, 16 Nov 2023 10:07:57 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id q9-20020a05600c330900b0040a3f9862e3sm3216257wmp.1.2023.11.16.10.07.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 10:07:56 -0800 (PST) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Sahaj Sarup , Javier Martinez Canillas , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH 3/3] drm/ssd130x: Change "solomon,page-offset" property default value Date: Thu, 16 Nov 2023 19:07:39 +0100 Message-ID: <20231116180743.2763021-3-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231116180743.2763021-1-javierm@redhat.com> References: <20231116180743.2763021-1-javierm@redhat.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 10:08:31 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782744994161666073 X-GMAIL-MSGID: 1782744994161666073 This is used to specify the page start address offset of the display RAM. The value is used as offset when setting the page start address with the SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to 1 if the property is not present in the Device Tree. But the datasheet mentions that the value on reset for the page start is a 0, so it makes more sense to also have 0 as the default value for the page offset if the property is not present. In fact, using a default value of 1 leads to the display not working when the emulated fbdev is attached to the framebuffer console. Reported-by: Sahaj Sarup Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c index bef293922b98..8944129a8e0b 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -1453,7 +1453,7 @@ static void ssd130x_parse_properties(struct ssd130x_device *ssd130x) ssd130x->height = ssd130x->device_info->default_height; if (device_property_read_u32(dev, "solomon,page-offset", &ssd130x->page_offset)) - ssd130x->page_offset = 1; + ssd130x->page_offset = 0; if (device_property_read_u32(dev, "solomon,col-offset", &ssd130x->col_offset)) ssd130x->col_offset = 0;