From patchwork Thu Nov 16 15:53:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suman Ghosh X-Patchwork-Id: 165889 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp3303451vqg; Thu, 16 Nov 2023 07:54:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpxVWvyrqdfAce806qYh667Tw27J/j1rM8Rnq9bRZRUtmnGQDU1nAaP48Qr5HTOy0vPd4C X-Received: by 2002:a9d:6202:0:b0:6b8:6f94:d3a2 with SMTP id g2-20020a9d6202000000b006b86f94d3a2mr8547905otj.25.1700150066654; Thu, 16 Nov 2023 07:54:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700150066; cv=none; d=google.com; s=arc-20160816; b=WXWsV0VvXYeT6d463zQTivi+IhkQH87tIoAVtekoDYL/3gzm5gjv9PB/Wu2//yJFiK dw3u/7QvNN9ZEGENm5rtMU79uYBHm7GUVjjojlmP/vjGTse3Le9TgYQ+lgSLyRqS0/Lu W6fVvHUjcUP9CkgSAqaOEUXr8G/m3dXdrS/PfbWfABBSGRdcAGS7Ny9XZuGfb9SR0wqH 6BaMYV6bmcYQUgaW1x2wCqSp5zbsIvMQsjsBd5ldHzKq8CcJbJXp/RmnfHup6NoW7/1T XKYTZO/Sn2KvAupYE7kuKMeYu2+/hNyw8ogQ/eDsy4QcR9LYFbl2f9KaQW2ZGNd4eoiT rgVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=JeKDzoMiZqT1iDVG+sGjuWO4Gjc5/5UniKLk0NXFhQE=; fh=LB7eT8vw2+vB8s433diJLOtRSPEOTPRz4ia3xZipBH0=; b=G7O0+8cJRtoItr5mi1FHiLaichhAC9vO6hwC7Yh8FkVw+jekuZp1vXNva0C73jXbe5 PLzILVdezwCRdc2LNwQE2BUEMZHI4B6K0E6/pp1x42VIWeQ0RqrYp9gYSBsz1jFgqUox X/Ihqx/OXXpAFs/BzTk/DK1zlGpHmVFw5xFW+PY5CqpRuDfxhIqXxhz27QpxhQWgZDzg hf0lSQXmPeus3FN7Q24R+SVbCN19sw5SgtUtr/hoBodeC0hlkU5quXQGgX9TBbTWOPZD iRBHO/x3abBec+VSEozRwpxaP/GPsGJqbGHULmLNlbfpWAeFI2iHkSq/8PXuDpnHVLxI NYJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=f8VsnTiO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id bx12-20020a056a02050c00b005be0fa3c159si12925527pgb.457.2023.11.16.07.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 07:54:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=f8VsnTiO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 5F63D80F648E; Thu, 16 Nov 2023 07:54:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345400AbjKPPyO (ORCPT + 30 others); Thu, 16 Nov 2023 10:54:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345449AbjKPPx7 (ORCPT ); Thu, 16 Nov 2023 10:53:59 -0500 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2BF61730; Thu, 16 Nov 2023 07:53:49 -0800 (PST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AGFYo1n026432; Thu, 16 Nov 2023 07:53:43 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=JeKDzoMiZqT1iDVG+sGjuWO4Gjc5/5UniKLk0NXFhQE=; b=f8VsnTiOUOozfhawlZm7Oxbp8pN9fAdVdYehLpR1QiRtWohvyvLeFCur+eWLPljmj191 s42NMMqCLhbdCb+nhFmXObEv+evGq7LTRSb+beTl93+2pLDlwGH4WABOdlmqb4021Wzm /fsLy9cj+mvhnEB5VtwFLbypPoVRwPxjEqw2JyPb1luzNkCq5Kfa0BG7h/Lwz9qerolG pI5CDd+RYlTqzkElBpOD85+PggApccAGDO7IABiWSuzT3/zg/7+aw9ko2VDagXXGnYEl d79Iol6hAEUNLGpWFOfISRMqGl8h+oz4iEk4g1K2ykmhA/l4PdHN3s/yw+b51By/j7SY Ig== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3udgkah705-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 16 Nov 2023 07:53:42 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 16 Nov 2023 07:53:41 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Thu, 16 Nov 2023 07:53:41 -0800 Received: from localhost.localdomain (unknown [10.28.36.166]) by maili.marvell.com (Postfix) with ESMTP id 03F733F705C; Thu, 16 Nov 2023 07:53:36 -0800 (PST) From: Suman Ghosh To: , , , , , , , , , , , , CC: Suman Ghosh Subject: [net PATCH] octeontx2-pf: Fix memory leak during interface down Date: Thu, 16 Nov 2023 21:23:34 +0530 Message-ID: <20231116155334.3277905-1-sumang@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: lP9ZmLzL8t5JUo74U3Vd9m-hrpj7uFkq X-Proofpoint-GUID: lP9ZmLzL8t5JUo74U3Vd9m-hrpj7uFkq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-16_16,2023-11-16_01,2023-05-22_02 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 16 Nov 2023 07:54:24 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782736555920979265 X-GMAIL-MSGID: 1782736555920979265 During 'ifconfig down' one RSS memory was not getting freed. This patch fixes the same. Fixes: f12098ce9b43 ("octeontx2-pf: Clear RSS enable flag on interace down") Signed-off-by: Suman Ghosh --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c index 91b99fd70361..ba95ac913274 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c @@ -1934,6 +1934,8 @@ int otx2_stop(struct net_device *netdev) /* Clear RSS enable flag */ rss = &pf->hw.rss_info; rss->enable = false; + if (!netif_is_rxfh_configured(netdev)) + kfree(rss->rss_ctx[DEFAULT_RSS_CONTEXT_GROUP]); /* Cleanup Queue IRQ */ vec = pci_irq_vector(pf->pdev,