From patchwork Thu Nov 16 13:16:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 165802 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp3202753vqg; Thu, 16 Nov 2023 05:17:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4ovpO3OTRJuFqAu1anextpMdLJUXpYSlaR9gBozsw1W0YdoGggtdhQX+FrZ4SJU/+AHuW X-Received: by 2002:a05:6808:19a:b0:3a6:fbe3:45cf with SMTP id w26-20020a056808019a00b003a6fbe345cfmr16310561oic.35.1700140646381; Thu, 16 Nov 2023 05:17:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700140646; cv=none; d=google.com; s=arc-20160816; b=TcDi61GxIktVmeUM86/ed25QEE/9crpMSYKZCKWbZEE9ijL2oABuTpNnoMDrIkj4pg wK7Lg6TCaCV0Op1zoiOl4ZtjQAGvxoBY+0izLFjW/kehIxLZ5JhsqGTaNzbn4bzR0Goy mWllxCyzSU8fL0lzCffw7M4wjsG2+YUID9XK95DpZwohcFkjuU7WQLjEz1abhOVWCwZR s4uc6kBgfhBVF5kihw+493CRWXEM9WA31+Ladb6iHezAPwfnJmhByJbhSRD1sGVQ+l1a se3FuHOQaDVowhDbKNWkt/jYiCo4+unzZD5V5EGs86s17Z89NOC+ToQMERC+sTKCLqGR YuDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=cCxtbjLzmBgwX8FNkL9oM+RCaWMdTXaxsYvF0v01y9A=; fh=zLstxgNMMh1B6h8MhYLJ9DtRg0Iqm+iFBlJBHyeyoAY=; b=THV0w0g12K5BemRCCT+aYM5BU3LAgdL5x8+BhU4GG+G0oDbq6gorX/FytMnKZhUGAq S5S2dhTd/AOssCBHdQZ3BnwEYkVEnGVzFVf72VefhPSFX2qc9J8T+kbfphQn5umrlx3q 4vRW6FOPhd8FItMq3kzDszik98wylRFRmwARbT4PmWNz4g7PQeJXQ0mBsmNXHjDs5IM/ isyTpdBaVASk10Oh+zxoDfraWFpnRYjJQeKMJBUU4/fYyofrTpDGiO7rFLJYcMtColeQ Mu1M9WO4aGlUJirX0P1aUWzuWFIkShvxk1IeP/VZAY4YagZsOu57ONcGTdHVKMR4emGx obXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id i126-20020a636d84000000b005b96c4292basi12020157pgc.29.2023.11.16.05.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 05:17:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 0C03481972DA; Thu, 16 Nov 2023 05:17:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345125AbjKPNRI (ORCPT + 29 others); Thu, 16 Nov 2023 08:17:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230371AbjKPNRG (ORCPT ); Thu, 16 Nov 2023 08:17:06 -0500 Received: from albert.telenet-ops.be (albert.telenet-ops.be [IPv6:2a02:1800:110:4::f00:1a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD548182 for ; Thu, 16 Nov 2023 05:17:02 -0800 (PST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:1f07:ca72:c5f4:4244]) by albert.telenet-ops.be with bizsmtp id B1Gv2B00S4CbZ7h061Gvkt; Thu, 16 Nov 2023 14:17:01 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1r3cEe-009Qwb-9o; Thu, 16 Nov 2023 14:16:55 +0100 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1r3cEp-007jda-GC; Thu, 16 Nov 2023 14:16:55 +0100 From: Geert Uytterhoeven To: Christian Zigotzky , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Thomas Zimmermann , Laurent Vivier , Javier Martinez Canillas , Hamza Mahfooz , linux-m68k@lists.linux-m68k.org Cc: dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2] drm/virtio: Add suppport for non-native buffer formats Date: Thu, 16 Nov 2023 14:16:54 +0100 Message-Id: <47a81d2e0e47b1715718779b6978a8b595cc7c5d.1700140609.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 05:17:24 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782726678060056713 X-GMAIL-MSGID: 1782726678060056713 When using virtgpu on a big-endian machine, e.g. powerpc QEMU: virtio-pci 0000:00:02.0: [drm] *ERROR* fbdev: Failed to setup generic emulation (ret=-2) or m68k/virt: virtio-mmio virtio-mmio.125: [drm] *ERROR* fbdev: Failed to setup generic emulation (ret=-2) and the graphical display fails to come up. Before, the call to drm_mode_addfb() caused a translation from a fourcc format (XR24) to a bpp/depth pair (32/24) to a potentially different fourcc format (BX24 on big-endian), due to the quirk processing in drm_driver_legacy_fb_format(). After, the original fourcc format (XR24) is passed unmodified. However, the virtgpu DRM driver supports only a single format for its main plane: DRM_FORMAT_HOST_XRGB8888, which is XR24 on little-endian, and BX24 on big-endian. I.e. on big-endian, virtgpu does not support XR24, which is the default DRM format, and must be supported by all drivers. Before, this was reported, but didn't lead to a failure: virtio-mmio virtio-mmio.125: [drm] bpp/depth value of 32/24 not supported virtio-mmio virtio-mmio.125: [drm] No compatible format found As the core virtgpu driver and device support both XR24 and BX24 on both little-endian and big-endian just fine, fix this extending the list of supported formats for main plane and cursor plane to XR24/BX24 resp. AR24/BA24. Fixes: 6ae2ff23aa43a0c4 ("drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()") Reported-by: Christian Zigotzky Closes: https://lore.kernel.org/r/c47fba21-3ae9-4021-9f4a-09c2670ebdbc@xenosoft.de Suggested-by: Gerd Hoffmann Signed-off-by: Geert Uytterhoeven Reviewed-by: Javier Martinez Canillas Reviewed-by: Gerd Hoffmann --- v2: - Fix truncated one-line summary. --- drivers/gpu/drm/virtio/virtgpu_display.c | 11 +++++++++-- drivers/gpu/drm/virtio/virtgpu_plane.c | 6 ++++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index ad924a8502e9025c..49c89000aec33f23 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -301,9 +301,16 @@ virtio_gpu_user_framebuffer_create(struct drm_device *dev, struct virtio_gpu_framebuffer *virtio_gpu_fb; int ret; - if (mode_cmd->pixel_format != DRM_FORMAT_HOST_XRGB8888 && - mode_cmd->pixel_format != DRM_FORMAT_HOST_ARGB8888) + switch (mode_cmd->pixel_format) { + case DRM_FORMAT_XRGB8888: + case DRM_FORMAT_ARGB8888: + case DRM_FORMAT_BGRX8888: + case DRM_FORMAT_BGRA8888: + break; + + default: return ERR_PTR(-ENOENT); + } /* lookup object associated with res handle */ obj = drm_gem_object_lookup(file_priv, mode_cmd->handles[0]); diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index a2e045f3a0004a1b..a547d76b8fb0a77d 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c @@ -30,11 +30,13 @@ #include "virtgpu_drv.h" static const uint32_t virtio_gpu_formats[] = { - DRM_FORMAT_HOST_XRGB8888, + DRM_FORMAT_XRGB8888, + DRM_FORMAT_BGRX8888, }; static const uint32_t virtio_gpu_cursor_formats[] = { - DRM_FORMAT_HOST_ARGB8888, + DRM_FORMAT_ARGB8888, + DRM_FORMAT_BGRA8888, }; uint32_t virtio_gpu_translate_format(uint32_t drm_fourcc)