From patchwork Thu Nov 16 07:05:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Shumilin X-Patchwork-Id: 165713 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp3033452vqg; Wed, 15 Nov 2023 23:06:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEywT6yywEz7dUFdtIavlWNilsvYEJkwB5CyzlqSCQmjrcRgZwqyIgVtwIu6cx7nSpwYnHz X-Received: by 2002:a05:6870:4f8a:b0:1e9:beae:947d with SMTP id xj10-20020a0568704f8a00b001e9beae947dmr16756677oab.19.1700118374772; Wed, 15 Nov 2023 23:06:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700118374; cv=none; d=google.com; s=arc-20160816; b=zNmiy9ADRwH+Ut4cDWtB+bv7eBlTgxjK+LWVkcDbBnemkg3zY6sZiRFacsEJB6HFmC xsYRqR/KtPyUnzofEJU3t7JJJAiy9UwS7dCmkSx2j7yhBMBCDng7FpZ54dRRstdVYXkk wJ1dcXWxvYk/GbScFwDJsoiV09Ix/ZfQppio0GLBHlOJ5bPx5bAGvePys8jQYxvxTL0a bBY5YlJ4tytQO0TSesvpbnuG3qV+zF80NTOOwuwVB/j9H7ylLRUpqhaMQWT7YExethxa NkOsYwgcI6CZn1tWM2hSL20Zpv0EKJTENlgXAjPBgw0Sp5A0qEchO9+RDlvpyjSee6vU bfGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+ITr5h0WAqoW20lMgfV8LyXNgDZJ1Jjv93AqRqwvhXM=; fh=uIOHnKD7rONksjcHI345MkFnhQDq6hPW87o4/zyrCT0=; b=Dnx7roBbivdsA6gCI5mWKU/S4eIpcvqZDc4gKVAVjF3UnkzwWhzHtNSLLBgojYzg+3 ti3Q5NdAjccsC+eIBN3+otUkNEx3NyArSNdO58JUOKKtB1SC1k3kRZiO8l/2eTHJvSjM 8YRRzvjvAttTu/TZkyvh19pUb15Z+r91VpQ/3/pXfNG1Ocp93nHXPghe3YVQyUvorfu3 +fWbwiaF1Fkp22vS+XDpo31gCdJmd8jB7BNp4ty/H0D/UFnwdHXLRZ4GmBN0/ckyQdN6 T+78o/zA1sWeZdG5i3W83F7LIAL2Nc6t4SW6/tPcKorAv3MUSDdUa7oUZxFcxd7IGOgF vpFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nppct.ru header.s=dkim header.b="rzZJHm/u"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id e3-20020aa78c43000000b0068e3f55075esi11324781pfd.134.2023.11.15.23.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 23:06:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@nppct.ru header.s=dkim header.b="rzZJHm/u"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id A2368810F672; Wed, 15 Nov 2023 23:06:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344129AbjKPHFx (ORCPT + 29 others); Thu, 16 Nov 2023 02:05:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbjKPHFw (ORCPT ); Thu, 16 Nov 2023 02:05:52 -0500 Received: from mail.nppct.ru (mail.nppct.ru [195.133.245.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11AB21B8 for ; Wed, 15 Nov 2023 23:05:46 -0800 (PST) Received: from mail.nppct.ru (localhost [127.0.0.1]) by mail.nppct.ru (Postfix) with ESMTP id 73F881C0D6D for ; Thu, 16 Nov 2023 10:05:43 +0300 (MSK) Authentication-Results: mail.nppct.ru (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=nppct.ru DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nppct.ru; h= content-transfer-encoding:mime-version:x-mailer:message-id:date :date:subject:subject:to:from:from; s=dkim; t=1700118342; x= 1700982343; bh=r+9tuCaKj8z7l88YvQQmxGoZqfy8tYSwR5OFdGbttls=; b=r zZJHm/uSBj9GVJhFwEh0tY9SoO0Y0j3hpO+zfrWwlsXquFDANT3yd+MAW9dqc6xP GSDVKSW0st0qXuqrTo70wP9+FoZ/fXY6mTc9FYRpdHwwqha0cmDc/lFvcB52jw2O nx6RvGsN2h/CXbxMtiQJY8lx7ZyIi2go4R4wVG8Hpo= X-Virus-Scanned: Debian amavisd-new at mail.nppct.ru Received: from mail.nppct.ru ([127.0.0.1]) by mail.nppct.ru (mail.nppct.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ltcwhwVN0syL for ; Thu, 16 Nov 2023 10:05:42 +0300 (MSK) Received: from localhost.localdomain (mail.dev-ai-melanoma.ru [185.130.227.204]) by mail.nppct.ru (Postfix) with ESMTPSA id 09FCF1C0883; Thu, 16 Nov 2023 10:05:41 +0300 (MSK) From: Andrey Shumilin To: Sudip Mukherjee Cc: Andrey Shumilin , linux-kernel@vger.kernel.org, khoroshilov@ispras.ru, ykarpov@ispras.ru, vmerzlyakov@ispras.ru, vefanov@ispras.ru Subject: [PATCH 2/2] procfs.c: Increasing array size Date: Thu, 16 Nov 2023 10:05:36 +0300 Message-Id: <20231116070536.38122-1-shum.sdl@nppct.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 15 Nov 2023 23:06:12 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782703324750548154 X-GMAIL-MSGID: 1782703324750548154 The maximum size in bytes of the port->base and port->base_hi variables is 20 bytes per variable, since they are copied in decimal notation. Two more characters are \t and \n. A maximum of 42 bytes can be written to a buffer variable. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Andrey Shumilin Reviewed-by: Alexey Khoroshilov --- drivers/parport/procfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c index bd388560ed59..9b894f7cb581 100644 --- a/drivers/parport/procfs.c +++ b/drivers/parport/procfs.c @@ -117,7 +117,7 @@ static int do_hardware_base_addr(struct ctl_table *table, int write, void *result, size_t *lenp, loff_t *ppos) { struct parport *port = (struct parport *)table->extra1; - char buffer[20]; + char buffer[44]; int len = 0; if (*ppos) {