From patchwork Thu Nov 16 02:23:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xing Tong Wu X-Patchwork-Id: 165662 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp2944216vqg; Wed, 15 Nov 2023 18:26:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9vea9CyyD6KiKg4si+gugMcxDOcpkeszIbFWJUAMgr1xy5Rl/j2i+OqTDR2NWx172FMeS X-Received: by 2002:a05:6358:e4a1:b0:16b:c810:667b with SMTP id by33-20020a056358e4a100b0016bc810667bmr7266086rwb.2.1700101580860; Wed, 15 Nov 2023 18:26:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700101580; cv=none; d=google.com; s=arc-20160816; b=cxS2bVsHslAQoEKtTMREGbSLbpqRbMOFi5xJa+AD8ilkcqTIRllysHO1TNeEf4wH+w goPgBqmoL1WqoFrwmpA3sLJVQl1em+DNIMphiMiaIXJ2l887Ls5y3orPp9FLj7CLswjz +L6Df5fQ3baBSisH2OUhAduq768BVeNf4ZFuULyVWBmIXJf3dSfsPpSuBVYyT3CUddhV nlKjq1jEXnqRKmrAJtZz3pytAdPkW7iIlzrRMQW1C8PaBj1ggmwBauPXYPkaQGkhBk4U kLq9vTrgdxqbZeJmhFt6e/iLMfZ3s5IepDTCv1gNl3hASCyp8k+rFwgYX8ahAvjrbHTP bfQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hijftSCcjG/9boz0oEYP+nVxe7rLA+Dx/w2RlM3IhcM=; fh=brTD9uWwHSBEuDMsNSIyrWZVEeJXt4Ae/wkRCvfJiZk=; b=eQEQ/IxbpsNwQOpa0aOy/7pT/QEKdHfp8PdQHw8bnENS72QYDdOUBXfy5efs57vVlb vyG8vDk7Q5KHJAm43NQpoH+ET2mYQwuevS27UF1O0oO7bOdsDDGUM3Avg/25VptGvAP/ C26Z56xbMkibPrdeL0zDh2X9YeEKa5qpCimSgK0JQZzcVe4vv/ePkOoN3GzZcVARgVrg Gy3tB4cVmczxFJd3/aM4Lez+tFuHotGrfcHcSgO3EiTKCo3lwGTUHQitstxtRapwiMj6 0bjszvq5W6csrHWhkXSH9eBmsBYt3gQZd6UTPUPOTlCCdIkuMjcii6o4JotTu7DCyxbG JgHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=QgdDwbXn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id c14-20020a63ea0e000000b0056da0ae25d1si10534381pgi.831.2023.11.15.18.26.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 18:26:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=QgdDwbXn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id EA338809B6E6; Wed, 15 Nov 2023 18:26:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344578AbjKPCZE (ORCPT + 28 others); Wed, 15 Nov 2023 21:25:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235725AbjKPCYx (ORCPT ); Wed, 15 Nov 2023 21:24:53 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DDA841B2; Wed, 15 Nov 2023 18:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=hijft SCcjG/9boz0oEYP+nVxe7rLA+Dx/w2RlM3IhcM=; b=QgdDwbXnbs69uyuHTiUNJ 9QLs+wt31XmvrnsGpX600Qy2/SACwcUHp3oPVFnAu8ZnVns2jlP/ldoe4VqxnAgt Oo2oW+GOOWmr2GsYzZPUy+jtC0zn0OoVTcqalz/geFI44Uli0IQKu7MBUvBRLely hFfmysW/EC8bqBShNZUv9Q= Received: from localhost.localdomain (unknown [39.144.137.125]) by zwqz-smtp-mta-g4-4 (Coremail) with SMTP id _____wD3H2U+fVVl5bnXDA--.19779S3; Thu, 16 Nov 2023 10:24:07 +0800 (CST) From: Xing Tong Wu To: Guenter Roeck , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Cc: xingtong.wu@siemens.com, tobias.schaffner@siemens.com, gerd.haeussler.ext@siemens.com Subject: [PATCH 1/3] hwmon: (nct6775) Fix incomplete register array Date: Thu, 16 Nov 2023 10:23:28 +0800 Message-Id: <20231116022330.2696-2-xingtong_wu@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231116022330.2696-1-xingtong_wu@163.com> References: <20231116022330.2696-1-xingtong_wu@163.com> MIME-Version: 1.0 X-CM-TRANSID: _____wD3H2U+fVVl5bnXDA--.19779S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur1fXr1Dtry8uF1xur4xXrb_yoW8Gr1kpF ykXrWSy3Wrt3WavF43Ga1ru3W3Cwn7ArWIyw1UCw4SkFn5tFyxXF43KFyqywn0yFWfJa42 9FykJFWYg3Z8CF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jqxRhUUUUU= X-Originating-IP: [39.144.137.125] X-CM-SenderInfo: p0lqw35rqjs4rx6rljoofrz/1tbiEAsq0F8YMgZlaQAAse X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 15 Nov 2023 18:26:01 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782685715670273977 X-GMAIL-MSGID: 1782685715670273977 From: Xing Tong Wu The nct6116 specification actually includes 5 PWMs, but only 3 PWMs are present in the array. To address this, the missing 2 PWMs have been added to the array. Signed-off-by: Xing Tong Wu --- drivers/hwmon/nct6775-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c index d928eb8ae5a3..2111f0cd9787 100644 --- a/drivers/hwmon/nct6775-core.c +++ b/drivers/hwmon/nct6775-core.c @@ -769,7 +769,7 @@ static const u16 NCT6106_FAN_PULSE_SHIFT[] = { 0, 2, 4 }; static const u8 NCT6106_REG_PWM_MODE[] = { 0xf3, 0xf3, 0xf3 }; static const u8 NCT6106_PWM_MODE_MASK[] = { 0x01, 0x02, 0x04 }; -static const u16 NCT6106_REG_PWM_READ[] = { 0x4a, 0x4b, 0x4c }; +static const u16 NCT6106_REG_PWM_READ[] = { 0x4a, 0x4b, 0x4c, 0xd8, 0xd9 }; static const u16 NCT6106_REG_FAN_MODE[] = { 0x113, 0x123, 0x133 }; static const u16 NCT6106_REG_TEMP_SOURCE[] = { 0xb0, 0xb1, 0xb2, 0xb3, 0xb4, 0xb5 }; @@ -3595,7 +3595,7 @@ int nct6775_probe(struct device *dev, struct nct6775_data *data, break; case nct6116: data->in_num = 9; - data->pwm_num = 3; + data->pwm_num = 5; data->auto_pwm_num = 4; data->temp_fixed_num = 3; data->num_temp_alarms = 3; From patchwork Thu Nov 16 02:23:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xing Tong Wu X-Patchwork-Id: 165667 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp2948680vqg; Wed, 15 Nov 2023 18:39:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGR2wJ161zSQc+j+68cG9HNKwBQWMggO5jhZfNZ0Uov3PBgEyyg95ZcACqDlrSii1sJY1nz X-Received: by 2002:a05:6a20:7fa2:b0:186:cbf2:d99e with SMTP id d34-20020a056a207fa200b00186cbf2d99emr11023195pzj.18.1700102386383; Wed, 15 Nov 2023 18:39:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700102386; cv=none; d=google.com; s=arc-20160816; b=g9QrCHskxc/ArH+lIgl9lJZpFLJtyRkYkTOjOPc8zoDFH67bqUZlE7UWCBdqUn+6TA bEp1Bny8/maCWxh+E64DsY4RfMmaDqJ5NHVe702yxBdeAxV1uIoqaf1IL45IO/xlllAA hzFRi3myPpZZj8zHALOD603WEPgf52yk3/3cru+zmRCGy+W/5Eh3J+4LFG7pT260ULKm vTYe0SEpnio7sPq5oxi14HN0vNTC0E/vJI+Ymrmm6icLh71IR9nwy69jj4qLgE+vHn2s 8KSKrWEQ2sY3+DklS2trVbz/1r6iDnBD5vyZVgIrdFGgZ+OdRgYuu66os7bDAYi66jf8 PYCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cHgkt6wFw4yulka3yAnNtGtv/ycgWvgfCPluWVrqKrA=; fh=brTD9uWwHSBEuDMsNSIyrWZVEeJXt4Ae/wkRCvfJiZk=; b=qnLfIt5w6++6Rn5KL2pzKM+CvMeBnZiP9Wf9Gk5hj3BJbRcx0I9z3Fcw/Ev8I7ZKK0 7bcMNPpEHjYOIed6KJdQQ3clYTYTfSQdVhnevjIH2UpD9KYrhDEFPwpcz4NzVjEKvEhP UnbFXitCE7y/DZLqsrNhfaiZPnxb4F/l8gMTXGuzNU/W6WBeqeCVrD7AzHu39XgciNVO iDkybUpVjWM6yH8w/8+4B9Hle+Cq+P6wxwhzA0sB8Yz2urRFFTp0AlBZPkxjy/2vm7n0 kRjeug1qJzWmPxGv37014NMAGKi/Cr3JzBtcCIuhWJ8NATBaY+BKWfsVsTYtcIGmKC1U ZsnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=kzXMORIJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id e4-20020a170902d38400b001ca96a6eefesi11243233pld.577.2023.11.15.18.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 18:39:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=kzXMORIJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6E3398127F5E; Wed, 15 Nov 2023 18:39:45 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344462AbjKPCjo (ORCPT + 28 others); Wed, 15 Nov 2023 21:39:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235571AbjKPCjm (ORCPT ); Wed, 15 Nov 2023 21:39:42 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.216]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 02F6C19F; Wed, 15 Nov 2023 18:39:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=cHgkt 6wFw4yulka3yAnNtGtv/ycgWvgfCPluWVrqKrA=; b=kzXMORIJgWIWLtVcRBc6+ CHeJZmWclLrJHzUWHTD+48VXG07e45AXH1BXU+NO/pGWL7xLsEDaknuskHNX+f/W KOgLW4dXiv7qJfKdb+CRmIIygvCNbOEOhVNFbHJzS9ZrAIwaxMUXUIHczM5GU0Me CJcOEsJLJOxemzngAD7zUc= Received: from localhost.localdomain (unknown [39.144.137.125]) by zwqz-smtp-mta-g4-4 (Coremail) with SMTP id _____wD3H2U+fVVl5bnXDA--.19779S4; Thu, 16 Nov 2023 10:24:09 +0800 (CST) From: Xing Tong Wu To: Guenter Roeck , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Cc: xingtong.wu@siemens.com, tobias.schaffner@siemens.com, gerd.haeussler.ext@siemens.com Subject: [PATCH 2/3] hwmon: (nct6775) Fix logic error for PWM enable Date: Thu, 16 Nov 2023 10:23:29 +0800 Message-Id: <20231116022330.2696-3-xingtong_wu@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231116022330.2696-1-xingtong_wu@163.com> References: <20231116022330.2696-1-xingtong_wu@163.com> MIME-Version: 1.0 X-CM-TRANSID: _____wD3H2U+fVVl5bnXDA--.19779S4 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wry8Kr4xXw17trWfGF4Uurg_yoWkKFX_Ww 4rGrZ7Zw1Y9r13CF4jgF4rtFW2ka1UWr17Jw1xKa98J347AFn5Cr1kXrZxZrnru3yDZF93 Xa1DAr4Iy342vjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUeo7K5UUUUU== X-Originating-IP: [39.144.137.125] X-CM-SenderInfo: p0lqw35rqjs4rx6rljoofrz/1tbiTA4q0GI0cSnRZAAAsD X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_BL,RCVD_IN_MSPIKE_L4, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 18:39:45 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782686559855889467 X-GMAIL-MSGID: 1782686559855889467 From: Xing Tong Wu The determination of the "pwm_enable" should be based solely on the mode, regardless of the pwm value. According to the specification, the default values for pwm and pwm_enable are 255 and 0 respectively. However, there is a bug in the code where the fan control is actually enabled, but the file "pwm_enable" incorrectly displays "off", indicating that fan control is disabled. This contradiction needs to be addressed and resolved. Solution: Update the logic so that "pwm_enable" is determined by mode + 1, remove the "off" value for "pwm_enable" since it is not specified in the documentation. Signed-off-by: Xing Tong Wu --- drivers/hwmon/nct6775-core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c index 2111f0cd9787..575db6cb96e9 100644 --- a/drivers/hwmon/nct6775-core.c +++ b/drivers/hwmon/nct6775-core.c @@ -900,8 +900,6 @@ static const u16 NCT6116_REG_TSI_TEMP[] = { 0x59, 0x5b }; static enum pwm_enable reg_to_pwm_enable(int pwm, int mode) { - if (mode == 0 && pwm == 255) - return off; return mode + 1; } From patchwork Thu Nov 16 02:23:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xing Tong Wu X-Patchwork-Id: 165661 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp2944121vqg; Wed, 15 Nov 2023 18:26:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlnZH6C+l9Q7B7g1aJ9B8csx480ajyWDFvlfJX0/9KKsi7MW3w63J7cE+yIqJbfnw/3FZV X-Received: by 2002:a05:6a21:7748:b0:180:132:e078 with SMTP id bc8-20020a056a21774800b001800132e078mr14660141pzc.31.1700101564223; Wed, 15 Nov 2023 18:26:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700101564; cv=none; d=google.com; s=arc-20160816; b=jpLkGFixQMeSuikQ+EbOtYeLTZPiwMpsXn1mgkOiTwgK3XC9s5cvs2g5x8ULlgMdk7 WOXBXiPrkGUrEiIN7ySDkPtxNZzksb7qvLWgCzYi7aZOQkKDi/aJiqorKCs4tsPpbpP2 I/oLZRF79o2L+a5c+oHygmxuRRBBEXVrY7BoGFLbmRNZVSWJmkDyskK1wR1QBNiaP2z6 9XgKme0Wap1IKgrEg2wzZOVPNVYlSPxLDjg5bJQNg/LJUBXdes3t+1on00xxq49kKgm/ t/F86kLKtKufkTEmbj1S3uuw/nuWzO2ndgvUxLprImj5L33MWaTCx1A5n8Rvvr0UpUYU oyjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=S3N+UnTP8NAOW5Vw5F6SLjig+wZLk03Ej/o8rB18V/A=; fh=brTD9uWwHSBEuDMsNSIyrWZVEeJXt4Ae/wkRCvfJiZk=; b=gp6NABXt2zmdF1F7kigNJgVCjMyfy7JLrhIZpQGCSrp+tg4cchmAbzwBwV8oI5wBMv jpxsFVDE9Er7IUNQ5FhEeFMYqIQZAS1My1222ReCga7Y0uAb2amD4SNJ4WfghyQNlBpE RrEE3HU/YP8Eqe+zMQVF1ZkwCXQdBAh3ThrpP5xlqJlRKRjjr2nedUUTn44JMaNwqzGO K2SB3Ag01t1fX/il4zhsN0MWvzCnMuw15VaGOeA8pvO/UBVCF2oij/70TDyTnk32iWC1 dlEP9KAmrhyLUykJq60AZydi6oTvXekyTUmZFYmYeqsCBNyZ2BULpGhQPJqXzpJjil/G mkwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=LYczdvfh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id sh16-20020a17090b525000b002804fe98045si1049144pjb.33.2023.11.15.18.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 18:26:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=LYczdvfh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 38F878077519; Wed, 15 Nov 2023 18:25:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344863AbjKPCZ2 (ORCPT + 28 others); Wed, 15 Nov 2023 21:25:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344893AbjKPCZO (ORCPT ); Wed, 15 Nov 2023 21:25:14 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.215]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EDC391BFC; Wed, 15 Nov 2023 18:24:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=S3N+U nTP8NAOW5Vw5F6SLjig+wZLk03Ej/o8rB18V/A=; b=LYczdvfh/HrdJWsUUPgi/ FcdQ/VKr6Vd9UcLGnCFuTmCQfcr9nJV4RHMV7hqaICCvNrrKUBNP8/XvKSLLK1jA 5Gy1FDlsgY8IxHVffbhGWMV0ltJJIjNCYPXnKG6VZQ9ND1tzq9kWN5l8pHVzZEvX VF1DoCeQlfXDtMOf/MHC4M= Received: from localhost.localdomain (unknown [39.144.137.125]) by zwqz-smtp-mta-g4-4 (Coremail) with SMTP id _____wD3H2U+fVVl5bnXDA--.19779S5; Thu, 16 Nov 2023 10:24:13 +0800 (CST) From: Xing Tong Wu To: Guenter Roeck , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Cc: xingtong.wu@siemens.com, tobias.schaffner@siemens.com, gerd.haeussler.ext@siemens.com Subject: [PATCH 3/3] hwmon: (nct6775) Fix fan speed set failure in automatic mode Date: Thu, 16 Nov 2023 10:23:30 +0800 Message-Id: <20231116022330.2696-4-xingtong_wu@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231116022330.2696-1-xingtong_wu@163.com> References: <20231116022330.2696-1-xingtong_wu@163.com> MIME-Version: 1.0 X-CM-TRANSID: _____wD3H2U+fVVl5bnXDA--.19779S5 X-Coremail-Antispam: 1Uf129KBjvdXoWrtFWDWr4UWryUtFy5Ar4UXFb_yoWDZrb_uw 4F939rAwnYqF43Aa4DCFWSqFyUtF48WF48XFn2ga98ta4UZw1DXF1kXryaqw12vrWIvFyD Xw4UWrWI9ry7CjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUet8nUUUUUU== X-Originating-IP: [39.144.137.125] X-CM-SenderInfo: p0lqw35rqjs4rx6rljoofrz/xtbBnBMq0FghlXwhQwAAsH X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 15 Nov 2023 18:25:43 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782685697629238923 X-GMAIL-MSGID: 1782685697629238923 From: Xing Tong Wu Setting the fan speed is only valid in manual mode; it is not possible to set the fan's speed in automatic mode. Return error and show error message when attempting to set the fan speed in automatic mode. Signed-off-by: Xing Tong Wu --- drivers/hwmon/nct6775-core.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c index 575db6cb96e9..3fb9896c61ce 100644 --- a/drivers/hwmon/nct6775-core.c +++ b/drivers/hwmon/nct6775-core.c @@ -2551,6 +2551,14 @@ store_pwm(struct device *dev, struct device_attribute *attr, const char *buf, int err; u16 reg; + if (index == 0 && data->pwm_enable[nr] != manual) { + dev_err(dev, + "The pwm%d doesn't support manual fan speed control in automatic mode.\n", + nr + 1); + dev_err(dev, "Please set pwm%d_enable to manual mode.\n", nr + 1); + return -EOPNOTSUPP; + } + err = kstrtoul(buf, 10, &val); if (err < 0) return err;