From patchwork Wed Nov 15 22:44:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 165628 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp2854439vqg; Wed, 15 Nov 2023 14:44:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHRrH/+CYUTlwichjjSDZGuuThsvMjW4sKImGu9lhxseynwQNhTcBTCMSWTQbjfKsYfQLGx X-Received: by 2002:a17:90b:3841:b0:283:784:f8ed with SMTP id nl1-20020a17090b384100b002830784f8edmr12532238pjb.38.1700088278686; Wed, 15 Nov 2023 14:44:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700088278; cv=none; d=google.com; s=arc-20160816; b=sdmMnvAMK0N0m059Dy5VaUBRyJbeIeVsm01baswjxr9cz7+Ds3CXKtWKqx65vGmi/i NQ2tMBRIkEQ9PXV+bTc50zFaDl0rAxjK9RraYPb8OmiI47WR6XB+CFmoWTCd3nmwqODO lXJ0vAH8XJ8lbuZa0iDnAo1d/MfjLIM0obXLn6pPeAnT3JvlMwHWdhd9gMySrWQ598D1 j548sI5JaZoJ8EmGLg66fcKAgo2ojRyo0PoIRJTAPYlO50p5qlkGOgxffZRLx92TFLK7 TpPr6hW0fWuw8A5S28NN7eyUr6Q/HmeNeO3bqBuwLZa6rvs6pti0wrRQL3syfOVg5doj auYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=x+9rvLvdX2lnfyBf2vZqm86qvEOYTf/3b77ELh1X624=; fh=9atKuf829lAg0tkIKo07XINzPVtuPagGNz81nd3QBps=; b=Pwm5oLWl1Jj/W4g7o0DDnDB/4xzsMj/IUrMJ2d/PY3d7QhKgXAKO4oPkepx+TRfVZu 2Kj6tWLipD6vLvym+lFTgPb9vdhn74GdyrizkYQNs9f0awih4LL+KO9i7RYm3rMFufuz 93ky2HgvTD7hKKGMMHPBLHAxJDXSIZHr5eNY4Vt6Nx+lr8/pJ84uI++AyUyBxwxPSl9Y X5XRusqNzOaC1vKXVjYPwiMwiPvTUOHmFo+KevgAkTkotaoVHdNJfKfRlBFUzuXNR4kD 9zAu54Nrx98GdJ0+vnWTn7YucfTvJwAtDsH9S6pNs/csPVxB75qwivGdmIV3RIExj+WH fvWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=bvr6X1ZY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id y5-20020a17090aa40500b0027d1ce4ce41si1686408pjp.0.2023.11.15.14.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 14:44:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=bvr6X1ZY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E2D4480E65A3; Wed, 15 Nov 2023 14:44:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344425AbjKOWo1 (ORCPT + 28 others); Wed, 15 Nov 2023 17:44:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235621AbjKOWoX (ORCPT ); Wed, 15 Nov 2023 17:44:23 -0500 Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01DF01B1; Wed, 15 Nov 2023 14:44:19 -0800 (PST) Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-1eb7a8e9dd0so71178fac.3; Wed, 15 Nov 2023 14:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700088258; x=1700693058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=x+9rvLvdX2lnfyBf2vZqm86qvEOYTf/3b77ELh1X624=; b=bvr6X1ZYQtDjBvoOu7MgKyONeMF6dWAxg3AJaO0jTNF6GPTJV1ff+k82O9u3jXIOqk 6bI/7q94cHJwqICOtxIMAoHHr5JJ7ea1jPRDEIjZh6pMM2Pta6q6nzZLSNgcJDrqV3n4 nMs2iEWM7EPIwexaZG9tv7Tk5aq6fTx2RErH3N52Et9WnohImnj8X0eCrMMohQjGqez4 qFDOQbYBAHQlUi7MQf75c490SYYgdKwEwbNf8uLjNbl3TVrtXUPfFmfs1zDnPwQEM/nw SvHyeDLZ9UMJW9b7rdSu2ULkmsauvbtNVDfNIGlgnMuOgCy5taKoQxVcBy1EdYA6A57n eRKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700088258; x=1700693058; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x+9rvLvdX2lnfyBf2vZqm86qvEOYTf/3b77ELh1X624=; b=s4kJUBi4wiwIBamx8ZVI8a7gPjm/r0oD8iItTAXSrquWOSJK+49FG7FolSgA/7O5mD 4wi5+qSKnH0PXy7MTVRqHNZoRktpVrWASbhl4QUyCdJde6/KjYwptcv676DgquchIP/K CJPLEvMvo8whLcvDq0TqAkSBLSXdvHWhw964jz4UwKleuNKB6yWDjhjGbanW9pJ0tWem EN6U7pH8fovh5iLcrHcGXsJw4HOWO+iy15Q8aX2u2c1Hl1M02M5n9CTaztnGBO1xCz81 d0PT1qPf7pwzlcMW2M1McbAu6/mgJJ10lvvw0YPXtutzfBxKOg+MtRqAI6SSuV6qfO+Y tsdA== X-Gm-Message-State: AOJu0Yz1GGsS7KG5MuWiYxV0cniO7XFSikxXNZ147+75o/A4Sn0fiZy2 IkoMDDEsH8QmS2M4+W4dvlk= X-Received: by 2002:a05:6870:b48e:b0:1e9:8182:a29d with SMTP id y14-20020a056870b48e00b001e98182a29dmr18474426oap.41.1700088258174; Wed, 15 Nov 2023 14:44:18 -0800 (PST) Received: from localhost ([2a00:79e1:2e00:1301:e1c5:6354:b45d:8ffc]) by smtp.gmail.com with ESMTPSA id r4-20020aa78b84000000b006870ed427b2sm3358092pfd.94.2023.11.15.14.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 14:44:17 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device Date: Wed, 15 Nov 2023 14:44:09 -0800 Message-ID: <20231115224409.240935-1-robdclark@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 14:44:37 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782671767271794703 X-GMAIL-MSGID: 1782671767271794703 From: Rob Clark The dpu devcore's are already associated with the dpu device. So we should associate the gpu devcore's with the gpu device, for easier classification. Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_gpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index cfcb4317afdb..3fad5d58262f 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -292,8 +292,7 @@ static void msm_gpu_crashstate_capture(struct msm_gpu *gpu, /* Set the active crash state to be dumped on failure */ gpu->crashstate = state; - /* FIXME: Release the crashstate if this errors out? */ - dev_coredumpm(gpu->dev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL, + dev_coredumpm(&gpu->pdev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL, msm_gpu_devcoredump_read, msm_gpu_devcoredump_free); } #else