From patchwork Wed Nov 15 16:49:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 165496 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp2667999vqg; Wed, 15 Nov 2023 08:51:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHN+aYoolDSn0SfikhlBGBhe/efKlvx7rAs5UaQ4AddkDJ7mSStz3auYPTKzVzMB/IGJ6hk X-Received: by 2002:a17:902:d485:b0:1ce:1603:f50e with SMTP id c5-20020a170902d48500b001ce1603f50emr5652118plg.42.1700067068561; Wed, 15 Nov 2023 08:51:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700067068; cv=none; d=google.com; s=arc-20160816; b=cU2sLnNZw+LzbJ1IqtUcs5jgkfACnV6esWj8KBLVKxI/9DtBMCVbKwKoUVW3nFYwyr BdAEaSYV0WsdchKh3tZpU897dJKuGRh6QhWosIrfpXrdogr2HE9G3IMtrpUFDJBBLklL nYBi4s/3v0cwisNpZqfZC4WoQ+m3MQ2DAKZxtVwRQ3h79OCDdN4UPQAerxMwJbicA7Cr uwOYn4uJx2dIXzeWIfk0ctVW3eJYPFa6x4Zqf9BWdk/GYNLEae0srgzsBaxZAxYYB+tH TAAH4akqpcTQG3r1slqegm2bR0I+w8XdgSg0vwrOQL4gj5CeGG7Z5bZll6ATK8QV0AxX X2Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vc2uuTZzlGTGKEpxHmVUvwPiBGhZ61eMxIga50Is5Fw=; fh=kOxmq+prcfKKX/dgMaMxTb6TRjzyc//QKXZBiaS/a94=; b=N7EIF+DbQ5hPxrJo3NNlL9luh62DHxpbQnkWpoNXiGy56f68a3uLTmqZ0ybROG3tJQ 2FvyH6YwBA20cAG6YnGDP8MeJs9ZzwF6qd0qS4nDd3g6EBIxg/C2+fH9Cy51pzEokGfu cY45+Q437Rs6qEocPk9ADQkf0vY+M8y/nj4aKU4PqKYsWHNyJETRIIF1+0tbaeeFU09X ayvex+HDK4PwGCWR6weNP3x4xnZ305KSnD8zhkD7c7o6FSFiW9A6cmcsxL4XD1raDX3p Nb8KO4EmAF5VwrYlFj1idM+fQAd39SsxiCfHHQ6QfbYUIOdPqepp4B+6/wySOdzKY3gH n5Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=XkuusTBH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id c9-20020a170902c1c900b001bda57935fasi10129116plc.64.2023.11.15.08.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 08:51:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=XkuusTBH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 52A9D808E54C; Wed, 15 Nov 2023 08:50:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232296AbjKOQuL (ORCPT + 29 others); Wed, 15 Nov 2023 11:50:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231659AbjKOQuJ (ORCPT ); Wed, 15 Nov 2023 11:50:09 -0500 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAB0519F for ; Wed, 15 Nov 2023 08:50:05 -0800 (PST) Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-77bcbc14899so338490785a.1 for ; Wed, 15 Nov 2023 08:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1700067005; x=1700671805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vc2uuTZzlGTGKEpxHmVUvwPiBGhZ61eMxIga50Is5Fw=; b=XkuusTBHn8B2hnTOerw4/6xlZ9ZWIUFmQ1oKhS1SW9ZDRGpHrhhn4uZ0uNT8qqIPYe oDSFpAQTP9qlq4NXMxzXHCUC9gvHVbUSW9hBAO/SkvdAAFi/5fF8gk9tM+E9knrT9Nd4 ju62hBBll4lyXxs+13o1+IOUQTA8tuGVrXKXm2W3whWF2OdyxSUMCLahGnB5CfyqgdbB Q+T20NGEuVBEsbihPPsjIJhHLg82orZiEDlFmuL6BD7ZMdOqjGU6/6zSdo3+wfgnrAJM o9v4y211rCxztIA0vD4qSHw2k1iRciUrkp5OQRv28H25pfn+rq4lnLqepo5lPC/Btfmx mvLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700067005; x=1700671805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vc2uuTZzlGTGKEpxHmVUvwPiBGhZ61eMxIga50Is5Fw=; b=kk8WjCXljgtRs9atKItZzvCwJqvrJbAC8ner4Z/RvVS7YihsCbmz1XAIz9OUmN+Vo2 4qVGN/MBWqd8mPNZcE7dA4dT00duZCfIzsXbB8QPF2F311gi2x0jeT1cm/gyrd4J21SV VjlqGbBEy32nYeEQjFAqvUphJkZRjolJRybQCg6JkViT2uy2lvdjvHAEEtGIY6wK+0t/ c4TpmrLpOBH5UwF3iWYAJsmqH+OXUY8EpB+fXsMavYZv08hxkjp6HaCWcmBOuqd/UkU5 iYs58oeiV++EPXmiqpRahEsUsIzFx7F9Me3sFHkzOBaxqXz33+9m7OyO3eMZQRIM279J UhRA== X-Gm-Message-State: AOJu0Yzk6WOcr1lQrAX7hsWqKrxJhwwEQgG8hArwfIhariA5XMrGSgTo LeeYA5iZAJqRDefg996EnAjinQ== X-Received: by 2002:a05:6214:4104:b0:65d:4840:6eb4 with SMTP id kc4-20020a056214410400b0065d48406eb4mr7154624qvb.6.1700067004848; Wed, 15 Nov 2023 08:50:04 -0800 (PST) Received: from brgl-uxlite.. ([12.186.190.1]) by smtp.gmail.com with ESMTPSA id mn16-20020a0562145ed000b00670a8921170sm658781qvb.112.2023.11.15.08.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 08:50:04 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Andy Shevchenko Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 1/3] gpiolib: provide gpio_devie_get_label() Date: Wed, 15 Nov 2023 17:49:59 +0100 Message-Id: <20231115165001.2932350-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231115165001.2932350-1-brgl@bgdev.pl> References: <20231115165001.2932350-1-brgl@bgdev.pl> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 15 Nov 2023 08:50:31 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782649526585705571 X-GMAIL-MSGID: 1782649526585705571 From: Bartosz Golaszewski Provide a getter for the GPIO device label string so that users don't have to dereference struct gpio_chip directly. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpiolib.c | 14 ++++++++++++++ include/linux/gpio/driver.h | 1 + 2 files changed, 15 insertions(+) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 95d2a7b2ea3e..a5faaea6915d 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -254,6 +254,20 @@ int gpio_device_get_base(struct gpio_device *gdev) } EXPORT_SYMBOL_GPL(gpio_device_get_base); +/** + * gpio_device_get_label() - Get the label of this GPIO device + * @gdev: GPIO device + * + * Returns: + * Pointer to the string containing the GPIO device label. The string's + * lifetime is tied to that of the underlying GPIO device. + */ +const char *gpio_device_get_label(struct gpio_device *gdev) +{ + return gdev->label; +} +EXPORT_SYMBOL(gpio_device_get_label); + /** * gpio_device_get_chip() - Get the gpio_chip implementation of this GPIO device * @gdev: GPIO device diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 0aed62f0c633..100c329dc986 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -786,6 +786,7 @@ struct gpio_device *gpiod_to_gpio_device(struct gpio_desc *desc); /* struct gpio_device getters */ int gpio_device_get_base(struct gpio_device *gdev); +const char *gpio_device_get_label(struct gpio_device *gdev); #else /* CONFIG_GPIOLIB */ From patchwork Wed Nov 15 16:50:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 165495 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp2667927vqg; Wed, 15 Nov 2023 08:50:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHMZORzVDCEXhNfovdDNLl9UZKLS5vA51GdNeOF3RRd9Wyh/AJaVXaOrHqvn6ZWb9Gw/IW9 X-Received: by 2002:a05:6e02:1d0a:b0:359:7d0:256a with SMTP id i10-20020a056e021d0a00b0035907d0256amr17842672ila.7.1700067058942; Wed, 15 Nov 2023 08:50:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700067058; cv=none; d=google.com; s=arc-20160816; b=AzbqelusQEITzIEvGO5FGp//S/Gy3Pl9bhfu91rlM5GVEqHqa2YVFyzfG5vcvtYWWK mgSBlsCDb9zvl/1XmCBSw0UGjfFTOnKRwMqsD4TZWS+mxnI77K1pUwYWa4UsR7CysuBo VDXC31lZ84AFGhEhKlf3foCTGzsp4vzH+TTKyaSS5+TSkODT6VG7LYtcj6SKMdQUAAXJ sq/EGwdIu/Gz/7iepu7jXfSix2KD3WUpCLVs/xhue/J4pyzR/FkFpsV04ApYRUApVkTg 3wSoCfxvGumgqLh07h7UWy5kId6YRkomuxk8gge24TsJiAeD9GwaIygg/XAA4QWb7Ebd mISw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6/+c2VO8PV1RqLkhAzMdFyQNC3apc5LK2X9ZNQJCpQY=; fh=kOxmq+prcfKKX/dgMaMxTb6TRjzyc//QKXZBiaS/a94=; b=ozohpkMOhkSVa5X0qbbjUTohuPeI5vlPff7Bazc6Y9R9QoCGCapp1fZjxvHhZSVoxb w6KckTh7j8yuHg5bqOLVW63wnZbXxlgPn1be9c77xeNHjVBEO2a+7uLsuXOYiWNy4BHG jim58rX5fi2xIJv36IyYN5uWjJjvusKuUoc9CsAnhYSFYgmxVWKPbSk6wTvyjHXQrBcP VNTRpDAnHlSSn3tC1V8kEIlYOTY6riw89M0yRE750Umc3BhNK+8InmCBTpf8ZeL7PNAf elMEIL0t0yiFGq1Ul4h8xEAw2YqVMqskT0CCQ0MyeWIGglDA/DQlKRWyJexyDfZwxB0U 8vBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=pZ3F0WMx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id w184-20020a6382c1000000b00577fc59373fsi9734197pgd.296.2023.11.15.08.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 08:50:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=pZ3F0WMx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7ED1E807D998; Wed, 15 Nov 2023 08:50:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232405AbjKOQuO (ORCPT + 29 others); Wed, 15 Nov 2023 11:50:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232210AbjKOQuK (ORCPT ); Wed, 15 Nov 2023 11:50:10 -0500 Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 981051A4 for ; Wed, 15 Nov 2023 08:50:06 -0800 (PST) Received: by mail-ua1-x92e.google.com with SMTP id a1e0cc1a2514c-7b9bd9f8bfaso2637069241.0 for ; Wed, 15 Nov 2023 08:50:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1700067005; x=1700671805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6/+c2VO8PV1RqLkhAzMdFyQNC3apc5LK2X9ZNQJCpQY=; b=pZ3F0WMxzknwX8Erg7N0MyTRtZdHeP/CSYxMYlbTW9KCnXX/GG6t7wT44v649yh3B6 CMQBbFLPqEV6iQL/wmkHytQ6SjG98W1iUIL+E86SPT528c0JIdWPVXPQtl0tiHKQw+v2 qrBWrgAxJ63rLPqpV55Orzog3Hl8cwF8EE+GjXl2lpoBxTjHKuHzZlh2ah0Pk8iaCV7r BNIyI4JsZ6SJbg2p/DxA2n+2d90tZSzeC8qO+UIpb6Wrnw24bo3ri1EQJrTSO03NYWPz By2gFNxqwrPgPk61wzqB5iY9LwKXeJqMIeSWIA2HSxxWIucZHfRmW80uF/Yz62vSc7nQ cv2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700067005; x=1700671805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6/+c2VO8PV1RqLkhAzMdFyQNC3apc5LK2X9ZNQJCpQY=; b=SP3xwfAIZCq/Hkj7hN0RFFC7/YKzl1wZtN+86Z4fyB3OwCTdoBp8S4nGUyYZb+uprM dr0L+69mB3/RbToB9X5UON8MQ8nFb/3IfeIFUpDbGl0hXKDSbqySSFKlWM4Poiir86Ze TAVe/DY2C/UU4Eac+tYTP6j8R7rhHKFxKCtrOrBS+YHbM8uuRT40fQMu3NqszUki+Jm0 BeEVIXFnjiWgW9x9qoL+w9iT0DNojItOowYnspGI9bcVxvSw5hZRleDkMU3JZBJtCrzI +qg9nLE0V/oQ1KpNTuLS0mw98MonXBDX2YZqkpEE7udFFOHayOe/KPBPYOvPjxHOlYKg qhlg== X-Gm-Message-State: AOJu0YyDody6E0vLNEb03bzQHQostaeCz7nnDwwMdNBWm8+2t3u4rMdE OsGNrveeKN69AJHgtPlkFIDCcw== X-Received: by 2002:a67:c218:0:b0:45d:9224:a898 with SMTP id i24-20020a67c218000000b0045d9224a898mr13122998vsj.16.1700067005671; Wed, 15 Nov 2023 08:50:05 -0800 (PST) Received: from brgl-uxlite.. ([12.186.190.1]) by smtp.gmail.com with ESMTPSA id mn16-20020a0562145ed000b00670a8921170sm658781qvb.112.2023.11.15.08.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 08:50:05 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Andy Shevchenko Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 2/3] pinctrl: stop using gpiod_to_chip() Date: Wed, 15 Nov 2023 17:50:00 +0100 Message-Id: <20231115165001.2932350-3-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231115165001.2932350-1-brgl@bgdev.pl> References: <20231115165001.2932350-1-brgl@bgdev.pl> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 15 Nov 2023 08:50:36 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782649516256257166 X-GMAIL-MSGID: 1782649516256257166 From: Bartosz Golaszewski Don't dereference struct gpio_chip directly, use dedicated gpio_device getters instead. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/core.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 1fa89be29b8f..0b4d07aea387 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -13,6 +13,7 @@ #define pr_fmt(fmt) "pinctrl core: " fmt #include +#include #include #include #include @@ -1649,8 +1650,8 @@ static int pinctrl_pins_show(struct seq_file *s, void *what) const struct pinctrl_ops *ops = pctldev->desc->pctlops; unsigned i, pin; #ifdef CONFIG_GPIOLIB + struct gpio_device *gdev __free(gpio_device_put) = NULL; struct pinctrl_gpio_range *range; - struct gpio_chip *chip; int gpio_num; #endif @@ -1685,11 +1686,11 @@ static int pinctrl_pins_show(struct seq_file *s, void *what) * we need to get rid of the range->base eventually and * get the descriptor directly from the gpio_chip. */ - chip = gpiod_to_chip(gpio_to_desc(gpio_num)); - else - chip = NULL; - if (chip) - seq_printf(s, "%u:%s ", gpio_num - chip->gpiodev->base, chip->label); + gdev = gpiod_to_gpio_device(gpio_to_desc(gpio_num)); + if (gdev) + seq_printf(s, "%u:%s ", + gpio_num - gpio_device_get_base(gdev), + gpio_device_get_label(gdev)); else seq_puts(s, "0:? "); #endif From patchwork Wed Nov 15 16:50:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 165494 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp2667672vqg; Wed, 15 Nov 2023 08:50:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBfQTslg8KScoUcCZj7BQgddGP36GCdwz2iBykv7M+TmYLc7RQDJxPmrE+w9nyadewBXX2 X-Received: by 2002:a05:6e02:152a:b0:357:4ebc:aa69 with SMTP id i10-20020a056e02152a00b003574ebcaa69mr14842498ilu.23.1700067029108; Wed, 15 Nov 2023 08:50:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700067029; cv=none; d=google.com; s=arc-20160816; b=rewPIGW27btrRyJ8OG4i2qfS38Smup2Oh07m8myqavkxzfXiRRvyZ8cBZjqXrHsFdB mMPdRb0p8hMuQjE/s7YhyKLj/ZIVn0cBSZxlBHyET3UmR75MIVZKZMa8nGb5o2943Pjg Wptpdtw1QMgGeQ240TUBiB/UKKKEa1/DIPSVIwTeMTiDJ27LM+FdqAVz8+R7+GUvv8n1 neUds4mvzSghCoox2/CwcxSoBNkDBU0AhY4y4M5pDDQHmYrfxwhLWtLmufpUxt23E2CI CIS2q0W3CNrognDjBM84p6Z1FCUjn6hxb9rlEqZSQWA26YxHqOhDkoQtNLSTzhelsU0E D/Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cBzGno4D43Ros4hSmP6lFXf2RSbEodgJworHzjxav/U=; fh=kOxmq+prcfKKX/dgMaMxTb6TRjzyc//QKXZBiaS/a94=; b=D6GM3W6d3yz147wMMN1na/EOx1pggtZe67Uz6s8gtKCyFPmxJvWS1Rt1YSYK2LlJVi yOc6528Axvbfm4KY/pVts4ZFmpjY2zpZ+46PrSIlv5+JkqvhskqTFrC8HezWHFl2WnV8 o8fO2OrIzZXb9tnDnWxFuK5yhd33JL6xxW92z01NwOr9ko3XOV5QeedBgI0R1ykxFue/ 0PGQQWM7oxtmaoG5Ky4Sve5b48uqUf8wIpCfSTgobSDOcQDV1iSJ1lmuAdhNB4qFfuVj 5DWQ9oA6zNVfGJck1bp0Lyd92yBWPmUFL1qkL/JKdsh6q1vwHZ7GMN1xVTfzwb6YIss/ f1Vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=vPjtHPlX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b187-20020a6334c4000000b005c1b2f397cfsi4213686pga.525.2023.11.15.08.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 08:50:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=vPjtHPlX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id CD28E8216920; Wed, 15 Nov 2023 08:50:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232459AbjKOQuT (ORCPT + 29 others); Wed, 15 Nov 2023 11:50:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232262AbjKOQuK (ORCPT ); Wed, 15 Nov 2023 11:50:10 -0500 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F3C71AE for ; Wed, 15 Nov 2023 08:50:07 -0800 (PST) Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-66d264e67d8so39424766d6.1 for ; Wed, 15 Nov 2023 08:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1700067006; x=1700671806; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cBzGno4D43Ros4hSmP6lFXf2RSbEodgJworHzjxav/U=; b=vPjtHPlX9qo45SMY2An0s5cvFgsnc/DPWwwA2fJ1H699LAhLmFqvN9ZREOmfxJEvD6 lIYshiSUIIGnk4L4x+OoukIqcMQPcet+NYQCIdEmvY2mMeiQVEFiV0+97QEJ4x9lhwUH G3vKgtovD8Zz9P6M4GmiQXbsdA/e+ypyxY5Zb1Nb0TLmEtB9W1GFf9qYF4ZpnVFq/epP fXxi3XogmlqY3hkw3QB8Gx+hdQan9R96g1hlPcWC5r456nDMlEweg3a0cOm6KAHO6GZ0 XENGoI0ms6MXbfB9H1LFfCisZfY2vq1y/n3rJLwOQXP8B54VDgsGIOX7gfgG3Ngub1uP l3lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700067006; x=1700671806; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cBzGno4D43Ros4hSmP6lFXf2RSbEodgJworHzjxav/U=; b=B40A+I1pLmkgGEAezhDmpS0atEgN2tWwfo+5h1xOOZLIbsL0xR0FS/PNsH4TuSQPI/ 6AYr7c+nBguuFXVLx47Tg39dGBCG2Iwf8xIWkIE3OesAoazjkeH3IL9yAuPvS/1LcU9E fqB5NY5Uxr5MhHN1CfLUzLQ1SN+HveA/84z7TKD60rQrwuvNcegkfaiYX5OKHRt8pFBt 8XTb3p9C7M+7TKrBL5fzVYbLjZDZwN6TSwG1xNnscn9mMKku1vepIYOy3a7Lu2CmAsYv HT3lln1VtcJeGnmSubmeA2kCm29saUJiP8uiPpzYzaz4R2FUE/2K201woPiOxSAYRLGk BkBQ== X-Gm-Message-State: AOJu0YyjnHYulnFcwtQeU4J8OekG564JgzS8dP/RRi4mFzow/TuiIwi+ 1MXw2Abo4nZm+Gn5/BSTyBB+2g== X-Received: by 2002:a05:6214:5497:b0:677:a1d5:4331 with SMTP id lg23-20020a056214549700b00677a1d54331mr6464857qvb.33.1700067006554; Wed, 15 Nov 2023 08:50:06 -0800 (PST) Received: from brgl-uxlite.. ([12.186.190.1]) by smtp.gmail.com with ESMTPSA id mn16-20020a0562145ed000b00670a8921170sm658781qvb.112.2023.11.15.08.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 08:50:06 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Andy Shevchenko Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 3/3] pinctrl: don't include GPIOLIB private header Date: Wed, 15 Nov 2023 17:50:01 +0100 Message-Id: <20231115165001.2932350-4-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231115165001.2932350-1-brgl@bgdev.pl> References: <20231115165001.2932350-1-brgl@bgdev.pl> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 08:50:27 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782649485197615765 X-GMAIL-MSGID: 1782649485197615765 From: Bartosz Golaszewski gpio_to_desc() is declared in linux/gpio.h so there's no need to include gpiolib.h directly. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 0b4d07aea387..e55959e1af5a 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -24,6 +24,7 @@ #include #include +#include #include #include @@ -31,10 +32,6 @@ #include #include -#ifdef CONFIG_GPIOLIB -#include "../gpio/gpiolib.h" -#endif - #include "core.h" #include "devicetree.h" #include "pinconf.h"