From patchwork Wed Nov 9 10:45:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sherry Sun X-Patchwork-Id: 17461 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp265863wru; Wed, 9 Nov 2022 02:56:11 -0800 (PST) X-Google-Smtp-Source: AMsMyM7CAUHXcwhRaeDo3iTXCen7w/Rn10/mXJ9clieBUlTQ5ZEfRYTuH/A0irziV6BJRRnyJova X-Received: by 2002:a17:906:db0d:b0:77b:a7cd:8396 with SMTP id xj13-20020a170906db0d00b0077ba7cd8396mr59535428ejb.264.1667991371412; Wed, 09 Nov 2022 02:56:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1667991371; cv=pass; d=google.com; s=arc-20160816; b=bf0SXeVNAK9f3Y/FhKHOE/kPD6mm+efnPB66gM+N+oHyxoi7c/iQTtT6/4A31y2KS2 YhWxRsH6O8Ka4r0++7SxC1hUB5/hMsncmaz0MzOAMtVhD6gDhgpWt9szAowGVcmTNvjY S6pt5yAnPR+1rIQuCNMJeFFmzW7C6XHsAmGgB3S7Blr/CJ0G6Lt/RckaFSDmLh8mtwjN 6jMenKM/0lzn2aj43fXCMYDyI8SslpDZ5w79TRDTPSHMklEd/1i/3947LxhduUxRuDfw 0IiTNbWMjj7b6zBc9btnUBrVFcHeLIljJW0HgIxqGpkkLMXJRcppCcUHh2MoXUIWLTk9 qdng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=a75+bEwNy1nTGQmnjrn2PlnFepRP7Rt9WT0OsQZt+ew=; b=yIsMp+FcPKw0xo7JpXtWpc7aWNiojA7DCmAfgAtdfvS8+0E6bebyiQEzFJu8oxqAoU JGxJ0lS3KcUAXo4DMqe+ynAzhKLXzvO6WnIKtKbl79IwiRe8U4LICS5AcgEB19PJPP3d nlEDMnFu8v0fjSzUK6+kfoovVR9CsIJloEGazQgEypZMLiNKng52MZCDkCVqI41y/kqc TS1fEZpdV/bM6um4shGltqaDkVWKmLHey/JQ3hGTIwQaADVdOu/P0P1y/fn9as9PNShY akDNbA2ApwQGy1Lbte/85utenAkE6EjbK8/Ia6/CpejEpWpS/sdAwphFu4dclTUXIobg YqhQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=FuZSmpGk; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o21-20020a170906975500b007ad8bd5a3b2si16669418ejy.263.2022.11.09.02.55.47; Wed, 09 Nov 2022 02:56:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=FuZSmpGk; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231216AbiKIKrR (ORCPT + 99 others); Wed, 9 Nov 2022 05:47:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231199AbiKIKrM (ORCPT ); Wed, 9 Nov 2022 05:47:12 -0500 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80052.outbound.protection.outlook.com [40.107.8.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0785824099; Wed, 9 Nov 2022 02:47:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b4t67VVuRFeUDY6FfzVJo/OgFiNerdcMxbmqyRsBEI/ixBQeuvrDMlEYB2OEQ6NmOIbrxufCtzDSl0TF6zEkcC/4fWpNaWGM3hGM1pUXO9oCGJxGnwOqc/tACdHXmvGeUIIq/brtMNuS5Io6rr7yErNGzVdMA1SFtqqZtln4XmhXWHBISIeuxHK9VQ8y/GFtMz5FOwTi7G66qwjT11w4qls6KYaxOclYsvn2aSaF6K1QJFu5usWx47zp6rHlpp0hJKsJSRdqTkQdZXOZOysKA2Ppd6Qk+5v82GqjCc+zzQCEIVO1rawenctJuwaimG/xYaCNE42YMqIMJ4ANT1kPrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a75+bEwNy1nTGQmnjrn2PlnFepRP7Rt9WT0OsQZt+ew=; b=P7FqeI46gnncWKlKFu3c7nS7bqBGIWrQJKZzYRm9Ded5otfL3NDOUL/bGqwYpb/wwIBCq5p2SfMKL3AC6RyBkn4w5Luz7kZXoRrVbbi47cvjxbwZBDrTbzMmH/2Lst/8fdPK+h5UCJq3zIyfd1tKzVIasPvlGNrqLnFHNpBRoCzsyezDJLjrrFg30+nGV/DBQoZCveD5RtISylCPGJ183bbznucbWs/ns/jvD9Gy6l8Mr38aiPVuZDImtXwpI0tfqIlMIs5ohrhGaRCi83gA4PtelVf08X5okyofBmTwpM7C1w9tuOYBWaBWOaT74eX7dw6gYAH4eaPKxx492QuDxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a75+bEwNy1nTGQmnjrn2PlnFepRP7Rt9WT0OsQZt+ew=; b=FuZSmpGk9cwA4FImuRzygFKpgH3ZCNzhO4yQBk+HyORfv/vjanNi3sDsOZqGu6FgAtCzD0iDAmVK91NSk/XKRCWXb+qA0uclAL8zYIMEwglbYzMFmBtUt2FykZTiZMuY2KQ3ENNAQkj3MMYJDMrwTFV0O3wWU+RtmlT7lJ8i7i0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by PAXPR04MB8974.eurprd04.prod.outlook.com (2603:10a6:102:20d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 9 Nov 2022 10:47:03 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::71f1:f7bb:5039:e55d]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::71f1:f7bb:5039:e55d%3]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 10:47:03 +0000 From: Sherry Sun To: gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH 1/2] tty: serial: fsl_lpuart: only enable Idle Line Interrupt for non-dma case Date: Wed, 9 Nov 2022 18:45:14 +0800 Message-Id: <20221109104515.17266-2-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221109104515.17266-1-sherry.sun@nxp.com> References: <20221109104515.17266-1-sherry.sun@nxp.com> X-ClientProxiedBy: SI2PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:194::11) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8404:EE_|PAXPR04MB8974:EE_ X-MS-Office365-Filtering-Correlation-Id: 16cd4161-2c8a-402a-e928-08dac23fbd08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7BuzLHnUEDzxnhBAweJhsVGHabn7Naje3smdaxfnh2f0oUYwxjn39tuvWajx8pAslzynUMcnwLv7H+XccrDURlrLv73NYd69nbzu4nRJrsgAiZAw3hcOPvZmg9q+przrd7j4g0szcjGAKNAyXmRRG35pXYwk0t/fbokE1nFwtR8WmcCn3caWc/jweElrmVUaIjN/DAetby6rxhOHM8n74daimjiyXr52U5v87cq4qS79hCwByMXVy5W83H+PbyYmVi//wlWb8YjzeIkUSWveHptYO4JFB0j0XGVmhAFobf4BsHq45TQwZm3lbzyxFhgb2gdU8Rg2yRjiPyO37VWvTd6fwlOC7ZF9h1lqfn3EF+BaIWlWe2QgFhsW2AOR9ZNsDlgxkRSRfRU+vT2Z2+n3Tn5Q1181tv+rx1mSVAiNOtTTXB4ru6faoQ7vsCXHfKshVvv8j5XZBllyD3GUkP+eoJba40c5Gq5h+0F2XHHbQlRWKXjO0ur5JoeIpvqfU9iuM4GS1hwmJRMVtUFc7ys37JqOrUuYxIBr38v3mrqqv2MPejPdKoWsVLZxFW6my1tzKgzCY6UkBES05MOQ+jmz42wI+439RF/xvmVYEVeKRkMaTa5r9mwExqJYEdXbTbF6c17ZKFycYJmzrQ14QafvcAgMTYeOQ6MkkpdV/qMYX16WDxPQujOsWXTZdQiad9MvHDwSTb5s+GEgtmHmr/Vg8g5QpjEpc7OQHGSukPvMsthOk3WcKNbyVRVnCVSs9S+mWnruKJujHl3++Lpx7R9QYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8404.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(396003)(376002)(136003)(39860400002)(451199015)(186003)(86362001)(38100700002)(38350700002)(316002)(66476007)(66556008)(66946007)(8936002)(8676002)(2906002)(44832011)(41300700001)(6666004)(4326008)(26005)(52116002)(1076003)(2616005)(6506007)(83380400001)(5660300002)(6512007)(6486002)(478600001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: IIqyeZr7oQ6qIgZUUf9NEbEw10rElc2AZWeJnUPy6/KYg0C10usMs2is/vSaIaVef5E6zgIOQGjpyGGJOKa7NKdsv2DVPk1JLHkh15ZjpHhkv1vaY5lZPxzGGz/LAa4SMVbflxcJjmsj/3NxaGf+oTZGL5afsJopm1YpyoUUhX4umoGcRfZoLJ5ZIZV3z67hrMAjsOpCrK5skNMwpxymj8CD4IDDcjIksNSutZzPGEgA4DyyZvfyQqxzmFMsVUklXtibjZlABhIQ2IstHJzgyZUaAVyttQr5l1P6LjECnsqMx7y1epAmDuc2Yl68z1KPoJhb+0gEOibnM/kiwEZG+hsUqdbpiorwkAQMN+oG2uWkLuIP//J5qltzPla6zGcKW5GxXtI0pAgFk3KpeOWZruZmMxFCPOjFH+hG+u8JtDVGHssOhlR4KUB5LhgkauuMeKZCLjzUKT4AN37MwOubHMZnAC/fgRYYVcCaYmYPoEOZGd3+6sS+YUIYPcwnLunzS7htCfoG2K7vI+7HDdqEfvMqnpzxcKTx0aPqh6GSF8H9cLswX31KKr4+1DmHUavPj1Lt+gnOsm2333CNIBG34FCFH7acsb6dmongXZJOdjkGptYuf2800nRadszRbENTKdS+hRVmqtMPmhaGE1cPSa0lkRki3K/wZHGTCZ4dZi3JfEohX+DE0r5IKmNAww23RY7VP18SG++DCQV/58Hn1UsdKsZgRNium3J8z020lw448uSmM0ST+jUftcrRRPELpw4Boe66d+wxyfdVOHEe2YVhfO7WDZ/VCAgsuCc5G0sU2ZC0giAps5O32aFqCE/E/KaE1MsAt4SCbi/BqbJiZ2oHyaYac9Mb2dx9Ph91RouYL3i3dJ/45LF+/5cUxhGk5MAaCsJyA+aODO3K4GIw3M/VVh2lppIBNsQQZ5Gk2mwaf8qQVtwZ1Y2lE+aUYzACkoaMAub7SU2rxX9lG4+9aTgbajPCU4xgeMmk64Hrb2pWr8YE10Ck7CsryjawnNLmJ0wBvUkbHuPhdiCFvfW1/ThcVA0Q0xN1t2EePlRPkes41j7RhFsv/r8wDSGA8czrRqiG5gVFHYmHcjCd2+d/SKSWt5fqOeEa8xZtlJxgOZL4znfMKPjeFQX3E9zD6g2ofFORbDrHY06OIiBTRjRGdP6TJVkEVD2uDqkYMO/+CGheEVoqQjf9Z4J/DhjatzeiJaSJgwpGMgvdwRz3ms0iIPkoVBk+3nmObyO1xkFg8LgU+KN+Sd63Hz1+YsIX10JMtvCVQ4wfDniNkhF29ARAhDak23zi0jQdiyfYj2SApmmDD/vw2KTOGnEPQL44DcfdXjnCEK3J/X8ovATFXaOqZ385D47T1EZ6lzMjzRzDDCJ5zs6+9rmnDv29yRkRsKmyTPH/hZ8CQXv8oNA0+JQjeQRejEJm2T9ha98CyO0NpH/6TpwvgAukkyd+ZFRokehvuKdrRFeDPiz73DIKl9MzjBHfxoyRngrq+WKFqcaris3/jdeIVMh3NXcaIjU5pjssjieklSP86GCqsc4Qcq+/dfqH/D0s4iDFoFK3C5JAYPVfVKx7TxV6OXYy2fWUiLBM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16cd4161-2c8a-402a-e928-08dac23fbd08 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:47:03.8583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XSH5PoonnVg4wWEg6mNs+ALfSm+dUCtJwWLIS4D9ilSEwBjRKhOgeiKfNgGc0LF+5KAEDY2z/9yczNSz/AdVIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8974 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749015720176746795?= X-GMAIL-MSGID: =?utf-8?q?1749015720176746795?= For the lpuart driver, the Idle Line Interrupt Enable now is only needed for the CPU mode, so enable the UARTCTRL_ILIE at the correct place, and clear it when shutdown. Also need to configure the suitable UARTCTRL_IDLECFG, now the value is 0x7, represent 128 idle characters will trigger the Idle Line Interrupt. Signed-off-by: Sherry Sun --- drivers/tty/serial/fsl_lpuart.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index bd685491eead..f5a0a14fa366 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -179,7 +179,7 @@ #define UARTCTRL_SBK 0x00010000 #define UARTCTRL_MA1IE 0x00008000 #define UARTCTRL_MA2IE 0x00004000 -#define UARTCTRL_IDLECFG 0x00000100 +#define UARTCTRL_IDLECFG_OFF 8 #define UARTCTRL_LOOPS 0x00000080 #define UARTCTRL_DOZEEN 0x00000040 #define UARTCTRL_RSRC 0x00000020 @@ -230,6 +230,8 @@ #define GLOBAL_RST_MIN_US 20 #define GLOBAL_RST_MAX_US 40 +#define UARTCTRL_IDLECFG 0x7 + /* Rx DMA timeout in ms, which is used to calculate Rx ring buffer size */ #define DMA_RX_TIMEOUT (10) @@ -1506,7 +1508,7 @@ static void lpuart32_setup_watermark(struct lpuart_port *sport) ctrl = lpuart32_read(&sport->port, UARTCTRL); ctrl_saved = ctrl; ctrl &= ~(UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_TE | - UARTCTRL_RIE | UARTCTRL_RE); + UARTCTRL_RIE | UARTCTRL_RE | UARTCTRL_ILIE); lpuart32_write(&sport->port, ctrl, UARTCTRL); /* enable FIFO mode */ @@ -1530,7 +1532,8 @@ static void lpuart32_setup_watermark_enable(struct lpuart_port *sport) lpuart32_setup_watermark(sport); temp = lpuart32_read(&sport->port, UARTCTRL); - temp |= UARTCTRL_RE | UARTCTRL_TE | UARTCTRL_ILIE; + temp |= UARTCTRL_RE | UARTCTRL_TE; + temp |= UARTCTRL_IDLECFG << UARTCTRL_IDLECFG_OFF; lpuart32_write(&sport->port, temp, UARTCTRL); } @@ -1669,7 +1672,7 @@ static void lpuart32_configure(struct lpuart_port *sport) } temp = lpuart32_read(&sport->port, UARTCTRL); if (!sport->lpuart_dma_rx_use) - temp |= UARTCTRL_RIE; + temp |= UARTCTRL_RIE | UARTCTRL_ILIE; if (!sport->lpuart_dma_tx_use) temp |= UARTCTRL_TIE; lpuart32_write(&sport->port, temp, UARTCTRL); @@ -1770,7 +1773,7 @@ static void lpuart32_shutdown(struct uart_port *port) /* disable Rx/Tx and interrupts */ temp = lpuart32_read(port, UARTCTRL); - temp &= ~(UARTCTRL_TE | UARTCTRL_RE | + temp &= ~(UARTCTRL_TE | UARTCTRL_RE | UARTCTRL_ILIE | UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_RIE); lpuart32_write(port, temp, UARTCTRL); From patchwork Wed Nov 9 10:45:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sherry Sun X-Patchwork-Id: 17462 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp265886wru; Wed, 9 Nov 2022 02:56:16 -0800 (PST) X-Google-Smtp-Source: AMsMyM6tncNzT7wDJJSIE0b7Ed/kiK6j81XPnBmlX8eF8tox+K2u4zHGUnU1rHD5USGyWSZgqVlD X-Received: by 2002:a17:907:1c9e:b0:79e:6d97:5e0 with SMTP id nb30-20020a1709071c9e00b0079e6d9705e0mr55297833ejc.534.1667991376600; Wed, 09 Nov 2022 02:56:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1667991376; cv=pass; d=google.com; s=arc-20160816; b=C4I/dMWoVMRKdo1BUxS6/5EgEVnwpNlh0CEK/mui1bICJ49HxUGrEPNeyKdIKlrwBB HmksauBU1B+ylwDT9/cXPi30HgOYj0tSp4Lw2c7zz5+vkWpbzkxChKLlFq5gqp59UPsK QfhRWpYPRR25dw+DJ0YcIobUy/Q9THwCQDRuHO+UiWDoLaWfPL5+cFqgEoVRoj9h3TzT KpNj/hfZ++Emjw1h/++Q4hDq+dBX8zxAFksAnT/f0MrHFdpQbPB3+YtKj7MG0Y5JiHi3 QWVE5v8GKELb1HjYK2PZUbpFVTj90tu+7NDlKKxL+VY8/YiSd3U07kPvoKzIqNcRIadf nxiA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=0FEg+nizusv6kMfkTW84XxIFo0C3VygwiekzqdTNfks=; b=P840cY5XfEfPr+BWYfRy5F2wdr3IdvsA2vqHGiU9MJLlcOsZrrzKY8JEZzg7fR/TSn 98cEvbT0EYc3+dar8msLkWasFO+B2sXRpWXCdVe5WGrvnrLWMXzH+CymdmKxO5WdaQ58 6s8SrwvnvVs/IeWdLiHSIgoFK1KQUH3i/DpBeGtpysHAkNpp+NTJZRF5032Fw8rpPIvW BgD6vaHjrMBpm7hi3/k3tx/ojvxo9x1dJ0nU0f6oUqOnzVue2NX0hXbdvPo6jA3/VOZT NL++pK6vkcdrt+KSMZJviYIr9tvgcMj78tJPLKjlnf8iK4vwa0Dx16qysPq/LdS20p+5 +9/A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=BXNL9TJF; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020a056402520c00b0045cca8f9a1fsi17232937edd.558.2022.11.09.02.55.52; Wed, 09 Nov 2022 02:56:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=BXNL9TJF; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231289AbiKIKrb (ORCPT + 99 others); Wed, 9 Nov 2022 05:47:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231251AbiKIKrP (ORCPT ); Wed, 9 Nov 2022 05:47:15 -0500 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2044.outbound.protection.outlook.com [40.107.104.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 512B526540; Wed, 9 Nov 2022 02:47:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bZ388bEBMKSK0GqVCbdY2dQFdhLFGY/4uZKETx7RJ0yAcUzhZ8nN9iV2zAl/zyB2xuevbXDOAl2xsUUhNCXZNguf/PbDhgzpcQNG7Kz4odB6thQQv2wuccw52IxOihNjlgjZyq5GhkY7ZxKpL6NbvtphZanin8RMTAKTkMgyN2VEwQTCVk41cuMMiPWxTAqTxR7wmMWcrlCP7OBsWNUJL1naLwEjtW+mJS8zpaBH5PgwgVttOHCAXRTA+SrTaVjVh+BrZ1cIos0ZPYvTzeN0Vp/HuPHqgen7KUUjAsIK5cAGRUZ+uJKIjGv8112B0A99UhdwrefVfvQUqRBXdTHGag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0FEg+nizusv6kMfkTW84XxIFo0C3VygwiekzqdTNfks=; b=VpodK/V8MuUblwuTCyMIceIbhYljx5Yc03Y0PRPGr4txoh1AibCa4Fh6HpNwoRz4pa4MiGtxsBpCEllnTcDIh2LpyZJ2FhNkgablHA5gO5QQgqdp2vm0rcQGCGlLOzZQwx17+1FquFecNbkeS1Xi6FTdFS95LIS50+aVBwZCrmIkcxeFpnalX75JXNTznKHboTyY1kVZjEA3q4rDNpknbOkPZVy6sUiX8aAFN2afLGLxNVzFMp7KRCTWInqxIBz6H7QNxvIm09jhX0cqTcOvRzTvrQ3FWkYZUhFmLj+raqzClUaA0k5WHBuczVVdhMjiB4GnVZCDA6KcdP06Hg9JYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0FEg+nizusv6kMfkTW84XxIFo0C3VygwiekzqdTNfks=; b=BXNL9TJFe9ooz84ev0qBIRVCdKpp24N1dUO3A5X5lkO6ohyaTxJAtfeNjg1dV5Z/eBJ1BXGmDYjeBKfc6BXsPaaAZFAS5eGm6aztMB2Qv1wg51VHbzJrEzHtDgvTj6M9ftE/nRQpHH2dKVWvMs14mc5Mnear61EX2f2vcVDmHtQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by PAXPR04MB8406.eurprd04.prod.outlook.com (2603:10a6:102:1c4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 9 Nov 2022 10:47:08 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::71f1:f7bb:5039:e55d]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::71f1:f7bb:5039:e55d%3]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 10:47:08 +0000 From: Sherry Sun To: gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH 2/2] tty: serial: fsl_lpuart: improve lpuart32 registers clearing when shutdown Date: Wed, 9 Nov 2022 18:45:15 +0800 Message-Id: <20221109104515.17266-3-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221109104515.17266-1-sherry.sun@nxp.com> References: <20221109104515.17266-1-sherry.sun@nxp.com> X-ClientProxiedBy: SI2PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:194::11) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8404:EE_|PAXPR04MB8406:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ed131cf-7e55-4c40-e517-08dac23fbfe9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JrtNDyt0DjLgx6E9gbvFDmXRMlWwsrYSEzZyLVHfPfrYPQjnuhcbHrBO7DC0rzN9sLeIpnzml1mGKrTnRE42LgWMeHl9SRqidNYox7aNfkMt0BEYK84LOxYUh8t3yaQmCMSMkn0uec3zaHhR/1pJmz34NmRNbxD5pE+MOD1yz8usQAG25uVDPFq1qdOr37fktdp7bZkdMFYmzGyTCyJakgAhIz4p5g4vGto72W5oEBdG1qZlKSNeY64iXs8NNG3vIDTdAjzsDAELAcNKKyvXEOwGMk8wN3cq8zuH76hlPJ8XsVUjmCReQPXZwMaOb+fZ/zJL1YQ2K7XObD+9WiVlkWpjb/bZlAT3ryDd2FUiBwQNX22FzosKSI1UdKJ6QvGSvo4fVz+AqIxFEvB/haGdcW18HLCRNsyA1VyoGhgBwqEjrgGzA3sYBXhgD0CK9VPtlpjN+CoSF58f/rwhH0Sa1/9i0O4XnoKgkPF5Jj5UL1QA4yBInKffZTo5RscngM5XQBuTx/oMgOlJuocnVMr7rVYTEkMKXwZM63PUFS/qF/H2yQCwtXQG+Fgu3EhfUY80/vaU34hOwyrxrGPyX5luF30XIhyiutFn/gryebwziWBnIyahYrv/H2yOZmphj9/hx57MpiJp7Zg5j1TOfU5z0iE2uXBi6MAsvcJjxhf+Ouj8kw5S2WnSfcmzW6+DMcGfgL4guXz/eNxLWabSwhOZA1tAYiZz3xNOLpEuhBMO6+N3DGU47UfWYihYToiSCX6hHAiDimPEFIfZcvufYPQQBA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8404.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(451199015)(86362001)(36756003)(38100700002)(1076003)(5660300002)(44832011)(2906002)(6506007)(52116002)(6512007)(83380400001)(38350700002)(2616005)(26005)(186003)(66476007)(66946007)(66556008)(316002)(8676002)(4326008)(478600001)(41300700001)(8936002)(6666004)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5iJq7dLIgpCj2OuFoQ3CJltJO7Z3zE0cRlTinwguGqSjenU58EnB7nrR/2dMwv/Zo8KXwa6n4ZAm9jb6pJ1ESCa9QWhMpxKikiInRYCcjrxW2g9n6S0YxiKNANUF08+65kDmqKrSEsHfcR/WAv2VyJ3ZVwInynQZZgxwkQYwC0HOmH598PGHOqxNNFHjK3Cb1/59b8AuzOK4+T1VfFeY8+YJ+KRFP2G1YNuKciFwm8xQ5T6CzeTtqClnTE4iSDpuZoKvzKlrT9C9zZQX9pLyzp5qSLbZ1402NMn81oCW19ptUTtTyAwju3E7DmqdoxiSsiwTHFmI9TvanFJbWpnx/dAkPnHbGPP9NjunN6a4nG2rgW4gTDn+a/m9TAORaeeyC3peVtnRm67Kkg/9RGmjD4QJVIYtVinaz1u9bi13IUxZvvcmE4Y09jXyVylRurdHFP9zQnsLnKu5Fyaqyu/32SB/yJY7qTtnhVgMRcmHnyMF8fM4igy6t2kBruIUqWml6wn8D1kFC047zWgMEMKvIfcjQiotkYtoU8cqQK5/F7Z8XHtINHzekpAYKqx92fgzOnqwX0olDD3aecsgDI4pD5JAKG9vuht5UcSWXILnG6Q8fdOXSpz+xPPOhfD/sYJeI35R6eAk5S6pQKa4zyDdga3VDrsVcUdWqgT+wty5S8MBOjOtKQ8FZK6PZfrgyoLY0XX4MVgBP10Ynwx/dU1R2krgxUMqRUAZXjSC1QkMRChjpTfGibDybDbcqqu5MqMYPBSAEXjWg1mzRTj7PtFR7bDPosoaenepgpaTzfbqFTP1921bWrmbd9vm8zM8nud1NMhcBp22eLUjyS+/JOAOI7aTJqYDPFgkDi9i3BOWReB4cBEN4QCkuN0BeboLgk7cRlJHSWn4gIyDbHeHaiQZpfP+h3zu9YvJRkg+vzoIasvPALIzmE02188ViDCbDzCEmADLcFBwFPUrgqv7uyJNCaE6lfjhgZsYP7spQZJGiq4B3Ld6WoX5/1stQARQCt/LXkjfPu48TPCYiabfyhDIsKRXCAa7QFyPBmaQqKj06dzJIqdwS58I1mzLWiFnN2Sds6VoGq/s509CVWJflaPQOWHHGGDMD9V9t+4SQBFqBSrsZ3ELEB7VfAJ89krQUWiH04T94etMucHwnvtzYMWGFVviHaWhySbIoPMmcp0ISZ0PU8szNSNBG/WxQyKuizQMKqL1RDvWFOlZ4kgEu3zhRthZwW/UVzOa3gSmGuhoQ70fbDkIeVqw7lgx045YqVC3snrNvC5n5cHcqqdD03dLeaPxnznBPQQV7kxgKJdPeymK3YUpt2FbjFU65PF182x5H9DU8MgQcWJjW31ZdhA2yFko4c8heBGXx+2zqBz0Wx5tcCvBxvCc1YHekq+pY/p8vTzWWPGpS1A52JKzomIjs0roUWpV8fknfXLug7pr06YYcVN1KvfkVdiBZjvDpD8YuzyhBRMIAEZtPFxMZrfoJgBuVoTTvHbE6zZQjIp3iE2wfnb41cRAZHUeRM3le8Rqeuc0WY03LKRJzLhUgWcOUffJh7ZQxQDTqGZeOK44BUcO6NPiBhrcGA4bjjI0SCjC X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ed131cf-7e55-4c40-e517-08dac23fbfe9 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:47:08.8132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d7RICl7Mmt9+1p/H4OUEAujuQjcO8zEQIxobtzsgwiVkMLpq8oXcKzE8B1bXrjevgZ4zq9PnjOwBbIXlM1tc9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8406 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749015725697716366?= X-GMAIL-MSGID: =?utf-8?q?1749015725697716366?= Need to clear the UARTSTAT and UARTMODIR registers when shutdown the uart port, also clear the Rx/Tx DMA enable bits and loopback configuration bit. Signed-off-by: Sherry Sun --- drivers/tty/serial/fsl_lpuart.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index f5a0a14fa366..43d9d6a6e94a 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1771,11 +1771,22 @@ static void lpuart32_shutdown(struct uart_port *port) spin_lock_irqsave(&port->lock, flags); + /* clear statue */ + temp = lpuart32_read(&sport->port, UARTSTAT); + lpuart32_write(&sport->port, temp, UARTSTAT); + + /* disable Rx/Tx DMA */ + temp = lpuart32_read(port, UARTBAUD); + temp &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE); + lpuart32_write(port, temp, UARTBAUD); + /* disable Rx/Tx and interrupts */ temp = lpuart32_read(port, UARTCTRL); temp &= ~(UARTCTRL_TE | UARTCTRL_RE | UARTCTRL_ILIE | - UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_RIE); + UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_RIE | + UARTCTRL_LOOPS); lpuart32_write(port, temp, UARTCTRL); + lpuart32_write(port, 0, UARTMODIR); spin_unlock_irqrestore(&port->lock, flags);