From patchwork Tue Nov 14 10:16:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?U3RhbmxleSBDaGFuZ1vmmIzogrLlvrdd?= X-Patchwork-Id: 164815 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp1762044vqg; Tue, 14 Nov 2023 02:17:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IEm+49inHFomJ3M0zBy0a11BJe4LQxVTpF8PYIZlKQlwq7P/IVmSmVmXrivugNNsqYidOS8 X-Received: by 2002:a05:6830:1d61:b0:6b9:924e:b43b with SMTP id l1-20020a0568301d6100b006b9924eb43bmr1693261oti.6.1699957037564; Tue, 14 Nov 2023 02:17:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699957037; cv=none; d=google.com; s=arc-20160816; b=CpIjn9GLYbXlHNSZ1RdHkaWtTCNSiHoFGUxfO8D9nJ7/LpyOJlkHe/XFZU0ik4d+wP pxGb8y+sHL82kyw/ollMkQcwSYVS/QJ59uUVQfN1trLRdOBBpGn3egJvehiHOtPMXUO9 yDg/heYOSw6Iv2qgakRbzl6llWyWNs6QbNAECw/4W4UHaIcBsYVeRgYfQD1gEf9B7LdJ 1tTOEbCcRHQuU/1o9dOa336Ei6vMlu3Wq+c/v3Y2s6Pm7XcrrY8kmsHtfIVGFhNFTi/v 1JEMfyiVEb4p24EnmF3vctRawHufmlKNykU8RIOgEDhkaYCQUPm8ApX66omUBdD767jB +/WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/NOVVN8iIa3nCjIpRm9znEilCwICAwYM2XuVmzYMG8Y=; fh=kcQjMKul7xY+IjIpSZq48ayPICfL75TOdtZhrwm4LQU=; b=MhD45n3BhThxDY7HdlVvZdtkahe2Ce6LXGwfE8vLVrFNNb10xc7GkmgkI8YJWHrJnD tuBMIaS29YQY9P1CmbLAbGnZ8rPRkuxzeWBzNvEc/EFQPtIcOsQi+jggHp5OHzoiN5lj /fOswmYNIx+nXkUfQur9nJP+ewnNia/mqSOIE65bfnnCDpLVlnPhkFH1QRgIYmGCki9R RmYq6tzxwBEhaHh17OOx8EirKm6RP8FOGBli1clHGEVsmGMWRhnaerATvXK3aFJIxZ0M IGEVjr7BUjT3336990CL5KJ3jv4AnwzMiY39V/weReEPA2sX4TxZoYryxy3yjOLd8quh alvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id j65-20020a638b44000000b005bd85b2f231si7410637pge.298.2023.11.14.02.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 02:17:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id ED6388077A7A; Tue, 14 Nov 2023 02:17:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231517AbjKNKRF (ORCPT + 30 others); Tue, 14 Nov 2023 05:17:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbjKNKRD (ORCPT ); Tue, 14 Nov 2023 05:17:03 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4006783; Tue, 14 Nov 2023 02:16:56 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AEAGkayE842045, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AEAGkayE842045 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Nov 2023 18:16:46 +0800 Received: from RTEXMBS02.realtek.com.tw (172.21.6.95) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Tue, 14 Nov 2023 18:16:47 +0800 Received: from RTEXH36506.realtek.com.tw (172.21.6.27) by RTEXMBS02.realtek.com.tw (172.21.6.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Tue, 14 Nov 2023 18:16:45 +0800 Received: from localhost.localdomain (172.21.252.101) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server id 15.1.2507.17 via Frontend Transport; Tue, 14 Nov 2023 18:16:45 +0800 From: Stanley Chang To: Thinh Nguyen CC: Stanley Chang , Christophe JAILLET , Greg Kroah-Hartman , , Subject: [PATCH v2] usb: dwc3: add missing of_node_put and platform_device_put Date: Tue, 14 Nov 2023 18:16:45 +0800 Message-ID: <20231114101645.20065-1-stanley_chang@realtek.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-KSE-ServerInfo: RTEXMBS02.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 14 Nov 2023 02:17:15 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782534150500029119 X-GMAIL-MSGID: 1782534150500029119 of_get_compatible_child performs an of_node_get, so an of_node_get is required. Add platform_device_put to match with of_find_device_by_node. Fixes: 34c200483569 ("usb: dwc3: add Realtek DHC RTD SoC dwc3 glue layer driver") Signed-off-by: Stanley Chang Acked-by: Thinh Nguyen --- v1 to v2 change: 1. Modify the commit message. 2. Add of_node_get in the of_property_read_string() error path. --- drivers/usb/dwc3/dwc3-rtk.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-rtk.c b/drivers/usb/dwc3/dwc3-rtk.c index 590028e8fdcb..3cd6b184551c 100644 --- a/drivers/usb/dwc3/dwc3-rtk.c +++ b/drivers/usb/dwc3/dwc3-rtk.c @@ -183,10 +183,13 @@ static enum usb_device_speed __get_dwc3_maximum_speed(struct device_node *np) ret = of_property_read_string(dwc3_np, "maximum-speed", &maximum_speed); if (ret < 0) - return USB_SPEED_UNKNOWN; + goto out; ret = match_string(speed_names, ARRAY_SIZE(speed_names), maximum_speed); +out: + of_node_put(dwc3_np); + return (ret < 0) ? USB_SPEED_UNKNOWN : ret; } @@ -339,6 +342,9 @@ static int dwc3_rtk_probe_dwc3_core(struct dwc3_rtk *rtk) switch_usb2_role(rtk, rtk->cur_role); + platform_device_put(dwc3_pdev); + of_node_put(dwc3_node); + return 0; err_pdev_put: