From patchwork Mon Nov 13 16:40:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 164563 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp1327796vqg; Mon, 13 Nov 2023 08:41:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IH34XGYX9cUH9/WcR1RYX5WwvlRjNkDWxLqPCGiiKK6gx3xkVyzXAt2jZwO+52k3/6LEKeK X-Received: by 2002:a05:6a21:670f:b0:181:99d4:8fe9 with SMTP id wh15-20020a056a21670f00b0018199d48fe9mr5418353pzb.58.1699893710590; Mon, 13 Nov 2023 08:41:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699893710; cv=none; d=google.com; s=arc-20160816; b=SOGbZ+/juxzqQYB80U/BmpAk7TqvqzCTL13hl8kdpLDOaYjpQ6U31kVshbLL0gdpMb nM3Ht9tZFYMRJNSu7+72k0Gu+r5t4ufs+4S7gb3ldIWFAIARQhakDQbmmBn8ikh/SoD+ 6FKjRRvU/YAi/33P4jBoeRuDHZwNnmVcV9goQgJ1wje5DZsto1T9YJe+qgmXA+P38zNO HaEZkrrV1jo1E8gpiR4hiqF46KBPywKomvKWzOkv4BdRfahBC2V+lK0KFLyf9sJoEcKI j0dpw2X9aujj0sM5j04xxTHb2aXVoGCBmquU7nrdu7vie8XdhI2E5qVlf2gMprUPObwH oNnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=b77U65NzPhkgOKHWlwkTamYPj/TOXrDCPIuZPvkXAr8=; fh=mPJ8m1NLUD659EOKVw1ViXiKIlFH7GJo2nZQo7s5D1Q=; b=tZH0FeE/yXmsp7bSJLkQLal2cgoWKpnhg4aF3jR42mbcpFA4J711uwgW/Xitqo5l3K yaZIbLNVBlnQvlbwSGMfV8TCKjsUVYcf2Gag2rzgR3YnTiBTrlU/ACos9z0uu93Kf/fq QIJXodyFuYv9M3nUwls8HV4zOIRr7IjOI0eE4nBz5C0GPQhIrwznohAOWHC0jm2CWOtO Cf5sw0zd0F64I5ZCSdfDBJ5OEnUXIvktkY5fN3FHZv+QKw/KQmwJbE34p+I6WmuRjGnV Q4+zYxv9EJc07PHdxRblBzTrzzI3YSAZd3N0rkGBRU3DKYajSK7cxkzl87CP/jwq0NXv 0Qfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=jLartDMU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id t15-20020a056a0021cf00b006b9c3f8b912si6036314pfj.52.2023.11.13.08.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 08:41:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=jLartDMU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 47BD9807C861; Mon, 13 Nov 2023 08:40:53 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230523AbjKMQku (ORCPT + 29 others); Mon, 13 Nov 2023 11:40:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230192AbjKMQks (ORCPT ); Mon, 13 Nov 2023 11:40:48 -0500 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27316D73; Mon, 13 Nov 2023 08:40:45 -0800 (PST) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 3ADFOIcM019092; Mon, 13 Nov 2023 10:40:36 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=b 77U65NzPhkgOKHWlwkTamYPj/TOXrDCPIuZPvkXAr8=; b=jLartDMUDTXTK7sS6 fm93omS1OhekimiXA5nCpAISjucg604mgvCK7ZUyEgE+px2ai6Isel7PrisQD8pt kMil41eUS964EUu3Tpc9H+qjiv4yBawG+A6/8qkHnB/MQ87FX6N2ua9kHmu/dj6D aqS18dGmHS4KRoJIFuR5/h6DUMUcczU26kkoobzUTxTZ1wiurGUxGqNg2XG0eMQ9 5DqHlTNyOzO7qgv4P7hblv0wKTIho5RUlpBcQR8TExESMPJLeZ2m27WgLadx3Vbu M9lABrTWY8nrma+MFsslZe/gn5681QUrMiZ6sk8WJ5u3mmJagtvhXHRLsDz+zz8y gswyg== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3ua7w2j53c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Nov 2023 10:40:36 -0600 (CST) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Mon, 13 Nov 2023 16:40:29 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.39 via Frontend Transport; Mon, 13 Nov 2023 16:40:29 +0000 Received: from edi-sw-dsktp-006.ad.cirrus.com (edi-sw-dsktp-006.ad.cirrus.com [198.90.251.82]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 4F98811A8; Mon, 13 Nov 2023 16:40:29 +0000 (UTC) From: Richard Fitzgerald To: CC: , , , , "Simon Trimmer" , Richard Fitzgerald Subject: [PATCH RESEND] ALSA: hda: cs35l56: Enable low-power hibernation mode on i2c Date: Mon, 13 Nov 2023 16:40:29 +0000 Message-ID: <20231113164029.1156669-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: xPkX2Qqns_D4KVv73hnt8y1Hn9SBru9- X-Proofpoint-GUID: xPkX2Qqns_D4KVv73hnt8y1Hn9SBru9- X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 13 Nov 2023 08:40:53 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782467747236241181 X-GMAIL-MSGID: 1782467747236241181 From: Simon Trimmer This can now be re-enabled as the sequence to reliably wake the device has been implemented in the shared ASoC code. This has a functional dependency on commit 3df761bdbc8b ("ASoC: cs35l56: Wake transactions need to be issued twice") To protect against this, enabling hibernation is conditional on CS35L56_WAKE_HOLD_TIME_US being defined, which indicates that the new hibernation sequences are available. Signed-off-by: Simon Trimmer Signed-off-by: Richard Fitzgerald --- sound/pci/hda/cs35l56_hda_i2c.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda/cs35l56_hda_i2c.c b/sound/pci/hda/cs35l56_hda_i2c.c index 757a4d193e0f..a9ef6d86de83 100644 --- a/sound/pci/hda/cs35l56_hda_i2c.c +++ b/sound/pci/hda/cs35l56_hda_i2c.c @@ -21,6 +21,10 @@ static int cs35l56_hda_i2c_probe(struct i2c_client *clt) return -ENOMEM; cs35l56->base.dev = &clt->dev; + +#ifdef CS35L56_WAKE_HOLD_TIME_US + cs35l56->base.can_hibernate = true; +#endif cs35l56->base.regmap = devm_regmap_init_i2c(clt, &cs35l56_regmap_i2c); if (IS_ERR(cs35l56->base.regmap)) { ret = PTR_ERR(cs35l56->base.regmap);