From patchwork Sat Nov 11 03:54:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mrinmay Sarkar X-Patchwork-Id: 164097 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp32056vqg; Fri, 10 Nov 2023 19:55:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAuszBJldB5t6RsURo4bwceBTn5eGxcTX2eYta+ClydBLPaJmbysQBgSI1IqOlD1NwloaM X-Received: by 2002:a25:da51:0:b0:d9a:b48c:7d96 with SMTP id n78-20020a25da51000000b00d9ab48c7d96mr1029050ybf.1.1699674949827; Fri, 10 Nov 2023 19:55:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699674949; cv=none; d=google.com; s=arc-20160816; b=UwJVeuPz4XkT0QTtX073KZ30T2w0cOlQDHstbZXfM8w7mp+/zW7vwkXyq7hSn5F6UI ZSqPeSONjpodQtKyHAo6IFJPdH4XSG0J9z20i7i+lS+sRLxNQzmAQPpeLCw+aQ9uiKc+ IN3WzUVP2T2MRsHb/yzqnIohf4DnxbALT1HHSEwZtLFQcYJuvX2ea7mMDc6DgA3z/W+K 48r9W7HLJfVBaK1INaLsCKTuHyzciC/bnaE1va+/zl2HqGElEF4wqN79FAvJ6WjIF0fJ eV8sE4VhZ5JITocdAbGHJh/Zaysg66ZncxLuE5SLWetgZGwbrQTEylxfpMS4Ex2ikx80 5aaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=M90MSGY/wJATgFRIPXY3ZfmksoCWpqDaG8IP3rvYuAI=; fh=Pk1D+TX8j7yMhBoMDvb6Z0dI8+uPCwWwrh/XHSBJc1k=; b=eeiZuSwfnwFVpEv+nQmt/Q8gi0XwtWDBEtMb3V2HizOyT5jeFC55iXqIeC80vD3qdt NuTnxk2YjHqGRp0MpsC1YR2vd/wae6WB5WNmq2Jgu7tZPU9pj55kecFQlg4j1CFqoBa6 iVXllEQ7flwhOB57gnQ4CciuEM87B1HWe7oUNAUxpyAO03VM8k3edEfGh3MWF0y7UQFW m4rm5NgolgKZVq//ES95Zv1EPUm1BZYO3UJgUQ+Hobvv9xTmPkIoz5MjOI/QeNxSa4MI Xbclrh1SvRSa3rSXBohmchvEcTgB0j8XzYcqSdaUkGkm17QcMC7cq1cOavvYihOpjZ2a jk+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cugIsk7O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id z18-20020a170902ccd200b001cc4770b98asi892764ple.357.2023.11.10.19.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 19:55:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cugIsk7O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 10BF382F8070; Fri, 10 Nov 2023 19:55:44 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345876AbjKKDzA (ORCPT + 29 others); Fri, 10 Nov 2023 22:55:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345748AbjKKDy4 (ORCPT ); Fri, 10 Nov 2023 22:54:56 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB0713868; Fri, 10 Nov 2023 19:54:53 -0800 (PST) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AB3iTlD020494; Sat, 11 Nov 2023 03:54:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=M90MSGY/wJATgFRIPXY3ZfmksoCWpqDaG8IP3rvYuAI=; b=cugIsk7O/X66nG2mznOSOI9AkVhSGXQVE9ncobf6pBz5E/m6JuOZjvxvsYLIJj+15WAi EpOOdTIsSS4MtS7pMWQOk53qMD+YQcCqbjMsNAGn8ceBRxS1M56jNRW8wq4TT0XmcphG Qd4FsxliNs8Cx8dXd6SeRykaYs1PqJ2sqwQ4tdJ8/GxTP+DgQFwjhlMbFAZlkWHxZgeQ f4mwzOPRzVzApSzgEZMxX9acuEk67XAg1VrvFdV1NEJNlBUbCc+K0F06UgckNVLKyC/a Lwg14zRwroQ3E7Gxn8VN9ep5RZ+zX1Ifu1hdrsxHsSefRo3TzRCjUu5/jgxq87CNZuNC 1Q== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u93r0kxtr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 11 Nov 2023 03:54:45 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 3AB3sf4T021480; Sat, 11 Nov 2023 03:54:41 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 3u5f1mn8gr-1; Sat, 11 Nov 2023 03:54:41 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AB3nrq4017345; Sat, 11 Nov 2023 03:54:41 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-msarkar-hyd.qualcomm.com [10.213.111.194]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 3AB3seWR021469; Sat, 11 Nov 2023 03:54:41 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3891782) id D20912D3D; Sat, 11 Nov 2023 09:24:39 +0530 (+0530) From: Mrinmay Sarkar To: agross@kernel.org, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, konrad.dybcio@linaro.org, mani@kernel.org, robh+dt@kernel.org Cc: quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, dmitry.baryshkov@linaro.org, robh@kernel.org, quic_krichai@quicinc.com, quic_vbadigan@quicinc.com, quic_parass@quicinc.com, quic_schintav@quicinc.com, quic_shijjose@quicinc.com, Mrinmay Sarkar , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Bjorn Helgaas , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH v2 1/3] PCI: qcom: Enable cache coherency for SA8775P RC Date: Sat, 11 Nov 2023 09:24:33 +0530 Message-Id: <1699674876-4982-2-git-send-email-quic_msarkar@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1699674876-4982-1-git-send-email-quic_msarkar@quicinc.com> References: <1699674876-4982-1-git-send-email-quic_msarkar@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: t7oNNaCkED8DxE3M_zKh_4mr3gZoAJHS X-Proofpoint-ORIG-GUID: t7oNNaCkED8DxE3M_zKh_4mr3gZoAJHS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-11_01,2023-11-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 mlxscore=0 suspectscore=0 malwarescore=0 bulkscore=0 mlxlogscore=637 adultscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311110030 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 10 Nov 2023 19:55:45 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782238360175061259 X-GMAIL-MSGID: 1782238360175061259 This change will enable cache snooping logic to support cache coherency for 8755 RC platform. Signed-off-by: Mrinmay Sarkar --- drivers/pci/controller/dwc/pcie-qcom.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 6902e97..b82ccd1 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -51,6 +51,7 @@ #define PARF_SID_OFFSET 0x234 #define PARF_BDF_TRANSLATE_CFG 0x24c #define PARF_SLV_ADDR_SPACE_SIZE 0x358 +#define PCIE_PARF_NO_SNOOP_OVERIDE 0x3d4 #define PARF_DEVICE_TYPE 0x1000 #define PARF_BDF_TO_SID_TABLE_N 0x2000 @@ -117,6 +118,10 @@ /* PARF_LTSSM register fields */ #define LTSSM_EN BIT(8) +/* PARF_NO_SNOOP_OVERIDE register fields */ +#define WR_NO_SNOOP_OVERIDE_EN BIT(1) +#define RD_NO_SNOOP_OVERIDE_EN BIT(3) + /* PARF_DEVICE_TYPE register fields */ #define DEVICE_TYPE_RC 0x4 @@ -961,6 +966,14 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie *pcie) static int qcom_pcie_post_init_2_7_0(struct qcom_pcie *pcie) { + struct dw_pcie *pci = pcie->pci; + struct device *dev = pci->dev; + + /* Enable cache snooping for SA8775P */ + if (of_device_is_compatible(dev->of_node, "qcom,pcie-sa8775p")) + writel(WR_NO_SNOOP_OVERIDE_EN | RD_NO_SNOOP_OVERIDE_EN, + pcie->parf + PCIE_PARF_NO_SNOOP_OVERIDE); + qcom_pcie_clear_hpc(pcie->pci); return 0; From patchwork Sat Nov 11 03:54:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mrinmay Sarkar X-Patchwork-Id: 164096 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp31982vqg; Fri, 10 Nov 2023 19:55:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGSgbPdMZY0u/mK7S7DC9md5+JzNmvo/oRJ5ydj8y1gZwKisAhusChdlicFa+PocpnvsXZS X-Received: by 2002:a54:4603:0:b0:3ae:1b21:fab1 with SMTP id p3-20020a544603000000b003ae1b21fab1mr1386519oip.31.1699674931791; Fri, 10 Nov 2023 19:55:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699674931; cv=none; d=google.com; s=arc-20160816; b=XFo8OuhjtNMa9ujN6bgC2H8ky9mWIj2hYeuC7R6i9+dwmW725+CIWFOUoK0YAUeSTp EpRGMX8ircPB+Fq0+s6kxUBmB+agsKt6fBXQM0GLS5swil4lC1eNVJiQdCqDtUPjEwEI ZKssXFnjZHhVctJXP2c3Ir43B6R3iiFXFyOi3GmFQiRoEls1zG6SCDRq+SQP5Q/nXtWF /sdudpVKlV3smFltFkbV4poTa6CC38PVkT5OQeQEui4V4me6xqeqAZLqPRAa8hwF/wCR bSfTQc2p8U42OKBzox5UJA9ignplvmTgmGaTx8U4SkgGeNuOyPbwnVqsBDN9/6NiDCby OQ8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=rP1zgu4S+NT2+jUOJK9w43JCWehHtyL1HXwXsWTuzaY=; fh=Pk1D+TX8j7yMhBoMDvb6Z0dI8+uPCwWwrh/XHSBJc1k=; b=eD9phKR9WDUdNmu093q/A77cVz8xQ57ET3tQCdvWQwBqEFNhCRbBpTzrdI3zYKT6ng 5V5bqbEGm+kKwggVzn56L77iQ/3GHgDWmoSEuDP+1bd93zXobluaMAAdUg6NVVq2gkYK K5gg2BYuRtjAsRcKXpmc10HfzmKqBPMlLis8wr11sOys9y6au4Du8We7Y/AwtiLUxQGs Rh/RddYtM7NO25tIF768ZP7ewxgb9+v0WqX/SIkvmM0ob63in+aVTwfdRF5attTpGrzx /lags6NtvExiSP8FijEaPgM270ZZ/t8nkXZrKiw4NLhKVhv/ppZjtC7d6kXRrmsbVdTU SQaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Eg7niFMP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id k123-20020a628481000000b006b6119c4695si921833pfd.380.2023.11.10.19.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 19:55:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Eg7niFMP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 3858B82F805B; Fri, 10 Nov 2023 19:55:29 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345815AbjKKDy6 (ORCPT + 29 others); Fri, 10 Nov 2023 22:54:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230249AbjKKDy4 (ORCPT ); Fri, 10 Nov 2023 22:54:56 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B25E42591; Fri, 10 Nov 2023 19:54:53 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AB3qRlg027956; Sat, 11 Nov 2023 03:54:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=rP1zgu4S+NT2+jUOJK9w43JCWehHtyL1HXwXsWTuzaY=; b=Eg7niFMPWouR5heJhDWDkwhhHyM0N0TxqAL2ghf5v27bovMWFoaZ82r/lxHbeKXuZrSM xYFtjdRg44OrSsTGELXAcHi7uNzuajoe8w74g0C8zxprrScNLuAsJPNlGE0YCExV1VWI /Y0HrUhN8f360eEX5B5EHW9SjSYMc93EzCAQR1IOQiZUpOYYp4mgIQUYkxmFJQLlc9Hu enqksaqREmgvwvRda+EabjApJXdAfcFR20bjS1cLE2d3pjtkNXJsQbhwyKh/BJsW7rvP gbVwCwHbJQas7LGy8KvwlPSA+l0jAO5MpqfD1Fhpb8LtOxBi4R7gtA7WLU861y1J58yO iw== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u9q0w1fh8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 11 Nov 2023 03:54:45 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 3AB3sget021496; Sat, 11 Nov 2023 03:54:42 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 3u5f1mn8gx-1; Sat, 11 Nov 2023 03:54:42 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AB3sgQa021490; Sat, 11 Nov 2023 03:54:42 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-msarkar-hyd.qualcomm.com [10.213.111.194]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 3AB3sfV7021489; Sat, 11 Nov 2023 03:54:42 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3891782) id E9E3A2D2B; Sat, 11 Nov 2023 09:24:40 +0530 (+0530) From: Mrinmay Sarkar To: agross@kernel.org, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, konrad.dybcio@linaro.org, mani@kernel.org, robh+dt@kernel.org Cc: quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, dmitry.baryshkov@linaro.org, robh@kernel.org, quic_krichai@quicinc.com, quic_vbadigan@quicinc.com, quic_parass@quicinc.com, quic_schintav@quicinc.com, quic_shijjose@quicinc.com, Mrinmay Sarkar , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Bjorn Helgaas , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH v2 2/3] PCI: qcom-ep: Enable cache coherency for SA8775P EP Date: Sat, 11 Nov 2023 09:24:34 +0530 Message-Id: <1699674876-4982-3-git-send-email-quic_msarkar@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1699674876-4982-1-git-send-email-quic_msarkar@quicinc.com> References: <1699674876-4982-1-git-send-email-quic_msarkar@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: t0UujxnC9riW9Op45rp_pF1p7w2hlZTK X-Proofpoint-ORIG-GUID: t0UujxnC9riW9Op45rp_pF1p7w2hlZTK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-11_01,2023-11-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 spamscore=0 mlxlogscore=491 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 mlxscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311110030 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 10 Nov 2023 19:55:29 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782238341533415903 X-GMAIL-MSGID: 1782238341533415903 This change will enable cache snooping logic to support cache coherency for 8755 EP platform. Signed-off-by: Mrinmay Sarkar --- drivers/pci/controller/dwc/pcie-qcom-ep.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c index 3a53d97..ee99fb1 100644 --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c @@ -47,6 +47,7 @@ #define PARF_DBI_BASE_ADDR_HI 0x354 #define PARF_SLV_ADDR_SPACE_SIZE 0x358 #define PARF_SLV_ADDR_SPACE_SIZE_HI 0x35c +#define PCIE_PARF_NO_SNOOP_OVERIDE 0x3d4 #define PARF_ATU_BASE_ADDR 0x634 #define PARF_ATU_BASE_ADDR_HI 0x638 #define PARF_SRIS_MODE 0x644 @@ -86,6 +87,10 @@ #define PARF_DEBUG_INT_CFG_BUS_MASTER_EN BIT(2) #define PARF_DEBUG_INT_RADM_PM_TURNOFF BIT(3) +/* PARF_NO_SNOOP_OVERIDE register fields */ +#define WR_NO_SNOOP_OVERIDE_EN BIT(1) +#define RD_NO_SNOOP_OVERIDE_EN BIT(3) + /* PARF_DEVICE_TYPE register fields */ #define PARF_DEVICE_TYPE_EP 0x0 @@ -489,6 +494,11 @@ static int qcom_pcie_perst_deassert(struct dw_pcie *pci) val |= BIT(8); writel_relaxed(val, pcie_ep->parf + PARF_LTSSM); + /* Enable cache snooping for SA8775P */ + if (of_device_is_compatible(dev->of_node, "qcom,sa8775p-pcie-ep")) + writel_relaxed(WR_NO_SNOOP_OVERIDE_EN | RD_NO_SNOOP_OVERIDE_EN, + pcie_ep->parf + PCIE_PARF_NO_SNOOP_OVERIDE); + return 0; err_disable_resources: From patchwork Sat Nov 11 03:54:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mrinmay Sarkar X-Patchwork-Id: 164098 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp32057vqg; Fri, 10 Nov 2023 19:55:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFeLkjzMQlGpsnV8VNimtWV3Im1Vxq3bqJ/jefV3hUECpLEjT4AZYaHSZv5erdE/tUbTsTN X-Received: by 2002:a05:6808:2005:b0:3af:a107:cf68 with SMTP id q5-20020a056808200500b003afa107cf68mr1735951oiw.40.1699674949820; Fri, 10 Nov 2023 19:55:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699674949; cv=none; d=google.com; s=arc-20160816; b=TOhjP+jr9LuQH3jBD8yCXyeWXFQzNQQHN8D3xGRg/oYUgbvm4wHPizX7HoWeYAeoUA 6sI0cueIej3gvRbW/qbfW/lix01+UBU/JmXhAuuuPkaVelvjRu1H76HygT9bxhywMYSB whge8mGm3mOQQAFsp6VRB2pSKjzUHdZ7D4Fs7f22z6dGy259tkWZwPC4VEIwi80sp+9i JtBc2jxjcaBtpYYc16x4b+3ZL9hkhH7RMr3TSShpUHWvdNsYGYkUKPNpSMzra2+xIzTU DazocdYN/CdT6cJT3Od3XTVfgNJSAnPcj7hzFRDzU9tRX7FVqJWnPijgQ5NeNcQzF+9J t78Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=VX5cdFkUABtpgIlBfG/AFZCJkrbrkFBSAjs6uj+kJjs=; fh=Pk1D+TX8j7yMhBoMDvb6Z0dI8+uPCwWwrh/XHSBJc1k=; b=LxB3nznNgbPZsTCu60We1/QC3nytkaLPoWw7j6V08zN+JcwxTN9OCe6bhAen9flzgi Lti1E/FVOR9bNuTUzINsPm8h+hRs71CMj8kouctUNV10ffu4MYPnYEycXhGK/nNOdnTq Vr3me/mXi9P6MYDsAtNyhjDUUBh8GMCriWSNCfqSccex5R9ACUa71anW6TNMxwyjPgia iD1A1GZl+YcsUGLlJm59skfEeMD5b9vZwO2wFVLn1OLV4QAln7nTkxBbNRVpl+i1YDK3 4Sfg25/gqh3a8yV8XY7eGeFc//cOHoJvNsr2XO8ubLaUDTNhstV2Bk3Q5exFAH1g+Zhs lrfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=kV399Qim; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id d19-20020a631d13000000b005b7c45b1f95si874443pgd.555.2023.11.10.19.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 19:55:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=kV399Qim; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 5659F82F8076; Fri, 10 Nov 2023 19:55:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345934AbjKKDzC (ORCPT + 29 others); Fri, 10 Nov 2023 22:55:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230172AbjKKDy5 (ORCPT ); Fri, 10 Nov 2023 22:54:57 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D69A13A98; Fri, 10 Nov 2023 19:54:54 -0800 (PST) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AB3iqc4031064; Sat, 11 Nov 2023 03:54:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=VX5cdFkUABtpgIlBfG/AFZCJkrbrkFBSAjs6uj+kJjs=; b=kV399QimRkIQceljXu50gfpaOM9DXKCAjGLM9coshqvAQEBiaeT7aqfpkUfPY1RhFIo9 ZCUI0T9Kx5ammY8BiD4J19g5erjj8gDEX7It7t58tvisoj8U7il9/GrsCBpZTVpFZ7d0 FQA2tXMytMWmsZ0QTNXsy4l/28cJ5l0hZxUN/vKpZ9FzE1yMPbYJQpvDZqdZQzG9EWQ0 e7Aviw7vObuuamEnV0P84Xfi/jz+NwUnCuOTgxjQ0ROQXvIUKW3K4ApxotNWWfoObO8G Uf/GARwJeg+ibGGq01DiZFMhm4OWoxcHIHs89l+qjxvDhqE7VWs6WHF8ui0s8Vpp/LhG sg== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u9yan87n5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 11 Nov 2023 03:54:49 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 3AB3secS021468; Sat, 11 Nov 2023 03:54:44 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 3u5f1mn8h7-1; Sat, 11 Nov 2023 03:54:44 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AB3si69021510; Sat, 11 Nov 2023 03:54:44 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-msarkar-hyd.qualcomm.com [10.213.111.194]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 3AB3sinA021509; Sat, 11 Nov 2023 03:54:44 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3891782) id 5F5972D2B; Sat, 11 Nov 2023 09:24:43 +0530 (+0530) From: Mrinmay Sarkar To: agross@kernel.org, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, konrad.dybcio@linaro.org, mani@kernel.org, robh+dt@kernel.org Cc: quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, dmitry.baryshkov@linaro.org, robh@kernel.org, quic_krichai@quicinc.com, quic_vbadigan@quicinc.com, quic_parass@quicinc.com, quic_schintav@quicinc.com, quic_shijjose@quicinc.com, Mrinmay Sarkar , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Bjorn Helgaas , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH v2 3/3] arm64: dts: qcom: sa8775p: Mark PCIe controller as cache coherent Date: Sat, 11 Nov 2023 09:24:35 +0530 Message-Id: <1699674876-4982-4-git-send-email-quic_msarkar@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1699674876-4982-1-git-send-email-quic_msarkar@quicinc.com> References: <1699674876-4982-1-git-send-email-quic_msarkar@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: ytzhTwBd-sw85k-XNJbeXTUezyny4nul X-Proofpoint-GUID: ytzhTwBd-sw85k-XNJbeXTUezyny4nul X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-10_21,2023-11-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=945 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311110030 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 10 Nov 2023 19:55:43 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782238360316263759 X-GMAIL-MSGID: 1782238360316263759 The PCIe controller on SA8775P supports cache coherency, hence add the "dma-coherent" property to mark it as such. Signed-off-by: Mrinmay Sarkar --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 7eab458..ab01efe 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -3620,6 +3620,7 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_0 0>; interconnect-names = "pcie-mem", "cpu-pcie"; + dma-coherent; iommus = <&pcie_smmu 0x0000 0x7f>; resets = <&gcc GCC_PCIE_0_BCR>; reset-names = "core";