From patchwork Sat Nov 11 00:28:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 164038 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp1470234vqs; Fri, 10 Nov 2023 16:31:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5YwyxLT3aGHK8LpvWJTutTjSMHwJ3/f5K6SLhYDlOdGf9pm4qAvQvJXUkcVY8+ivE66dV X-Received: by 2002:a05:6a21:6d9c:b0:181:98d6:6b01 with SMTP id wl28-20020a056a216d9c00b0018198d66b01mr846263pzb.5.1699662662701; Fri, 10 Nov 2023 16:31:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699662662; cv=none; d=google.com; s=arc-20160816; b=QTnRin3+VTnoPeHcmzvlPCVZ3qnAPSr1cGJNe/owwgJh36n5FeAmn2hz/IZjjskEKU cy+zPEcFzx7HXRIRXaY051MHhvVf3zxvMMkOdoKbsTu7s/mDMfUdLFLvrMYY21jA60fX HKkMK1gAYIUbCROSdEzn6TKaK9HwKZZeTPBZUCs9NrOY2Q574xG0cVOGYKhdQmHJyEXG PO6KzBk8FZU9troWoHO7UnHrxeMR+OBlcBThOIMZu2pwAa0pxk4rZYkvGVR8WTnQqmIl 0Lcd5mHWmsH51WGgBXeML50Avu6wcJWGgDNc8UYLcEeTDYr21hOUMeFx2233SgJGz4bQ lT8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=et5CNEbbpEZc7/GZDGct9Q6Ku2JLjZggspOXrOUtq84=; fh=1dpCrHNHPJLPh5axRIT28UW8AM4DHfrtIqq5vR0E1s8=; b=RM9ZJeVJfXCc15SkPTAuRr8fJ3VNhm6P5G7d14TBE4W8cFlY2mVdkSCgnnt133L7Fd e3kejek9kH9CGJbmmtKjMjHqFML4DzY/VH2XUhUIKRbuAUAn2hejSGJByMgcf9CY03I3 qTgRcoabrnBvWCsHJeSuR1OG+krW7VWzS6zP5WtS1ARGtrco1vyeKBC/c8SrXDqc/zKn 6R9pMiLZcAm9VXdiS9wx3NVK+NXfaV9HNQsVhPkUI4HK9YZtG3XmKNR6EtgEZc5lE6aC meyMeBcA8zv10fDuXCl9sCjB4wzwvRdZTcuH+Jpu0v0Pp6Sy1mf6MA3QOqbp3VErH9pR pl2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jCJRr3OK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id cl23-20020a056a02099700b0055fd1bfb109si600577pgb.679.2023.11.10.16.31.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 16:31:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jCJRr3OK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 94B2F83B7BE8; Fri, 10 Nov 2023 16:29:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345006AbjKKA3i (ORCPT + 29 others); Fri, 10 Nov 2023 19:29:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229667AbjKKA3h (ORCPT ); Fri, 10 Nov 2023 19:29:37 -0500 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCE9B3C39 for ; Fri, 10 Nov 2023 16:29:33 -0800 (PST) Received: by mail-qv1-xf2b.google.com with SMTP id 6a1803df08f44-66d0ceba445so15109686d6.0 for ; Fri, 10 Nov 2023 16:29:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699662573; x=1700267373; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=et5CNEbbpEZc7/GZDGct9Q6Ku2JLjZggspOXrOUtq84=; b=jCJRr3OKUZEcYzMNJOYm1t2coSht7aLjNgoGjN0LaN5whas+IGLRWasNAF0WsD17Eg bz3z4SrNAKkLMo+cg300sH0YUaE4Pns8Kg4JtWcTB6RZ2V2AKcK1MeJyylfLFPKG9VzP 2sORn4m1q+Zv2RckZpFBv164xVJ52KhQeUsjY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699662573; x=1700267373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=et5CNEbbpEZc7/GZDGct9Q6Ku2JLjZggspOXrOUtq84=; b=YYGzQRgNh0oCa5RFO7CtZkSDJODvHIBy+h0A6RVjJQZHRv6IWx7iS+zsB8+AbD5292 hkfAiZwZPl5W0NpUT5dkY6vcDIaP3Vg9hJHrvgI4tRuzwkB8DzehlVn/vqHH0f5AJP3w 5129Z7WQA+GWNZHv0SOJ3LqxONfeYR1WYfDi8u9lRQSR4PHoFpiQkraD8FdkZBoFQEdG lPUDTFmomnYLBLMrWWwmqslGrnAlvWXQVk32BBS91IiqEDHfOC6Ow0dWzN9ZUCwTU3n5 NOEFtGxXlUWr+YoqTquS0YkOtmwE18Ut7jAKNxU5Zm8rUthbXXTFoSxOw6VyC+HxOVA5 qEHg== X-Gm-Message-State: AOJu0YytERyY/CmSuYmJfwkes0tc+gYmcv/DiGmTGzyoTW+02jSKQ95o PAO8GSwFEjGoyN+4onEeoY5VBA== X-Received: by 2002:ad4:45b4:0:b0:658:1eec:408a with SMTP id y20-20020ad445b4000000b006581eec408amr734218qvu.40.1699662573056; Fri, 10 Nov 2023 16:29:33 -0800 (PST) Received: from kea.bld.corp.google.com ([2620:15c:183:200:5104:5a27:f95d:21d1]) by smtp.gmail.com with ESMTPSA id l16-20020a056214029000b00677adcfd261sm55898qvv.89.2023.11.10.16.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 16:29:32 -0800 (PST) From: Simon Glass To: linux-arm-kernel@lists.infradead.org Cc: lkml , Tom Rini , Masahiro Yamada , U-Boot Mailing List , Simon Glass , Catalin Marinas , Will Deacon Subject: [PATCH v5 1/3] kbuild: arm64: Add BOOT_TARGETS variable Date: Fri, 10 Nov 2023 17:28:00 -0700 Message-ID: <20231111002851.1293891-2-sjg@chromium.org> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231111002851.1293891-1-sjg@chromium.org> References: <20231111002851.1293891-1-sjg@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 10 Nov 2023 16:29:57 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782225476338560348 X-GMAIL-MSGID: 1782225476338560348 Add a new variable containing a list of possible targets. Mark them as phony. This matches the approach taken for arch/arm Signed-off-by: Simon Glass --- (no changes since v1) arch/arm64/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 2d49aea0ff67..cd9bca2358d2 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -150,6 +150,10 @@ libs-$(CONFIG_EFI_STUB) += $(objtree)/drivers/firmware/efi/libstub/lib.a # Default target when executing plain make boot := arch/arm64/boot +BOOT_TARGETS := Image.gz vmlinuz.efi + +PHONY += $(BOOT_TARGETS) + ifeq ($(CONFIG_EFI_ZBOOT),) KBUILD_IMAGE := $(boot)/Image.gz else @@ -159,7 +163,7 @@ endif all: $(notdir $(KBUILD_IMAGE)) -Image vmlinuz.efi: vmlinux +$(BOOT_TARGETS): vmlinux $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@ Image.%: Image From patchwork Sat Nov 11 00:28:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 164037 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp1469810vqs; Fri, 10 Nov 2023 16:30:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IGK49MOV0XIWZciEDz71UhK8g10o3TKBohrUysDvRE345hdlrkQ5luiQ4cCImjIpd3Jv/Lt X-Received: by 2002:a05:6a20:4418:b0:159:c07d:66f0 with SMTP id ce24-20020a056a20441800b00159c07d66f0mr977648pzb.6.1699662601260; Fri, 10 Nov 2023 16:30:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699662601; cv=none; d=google.com; s=arc-20160816; b=X2t7NtXY8mS5P+fXDFWJP8hx21Q32uO1cKo7zv/ab++NkECU9rpjjz5wpOwglNmtgT BL9rLMWV/1LPyvkmcVZmTRAro/szwNXs9rLkWCjuw/y68NFUIOLrLEkFD/d7SPFX6mI3 zrOglQNka8RJSP1+E7puUcHjxt96dSdJlxZhVfGFjJcBPuLs66+wD0DxLbtfvK9FYMFM /nJAPGg10MQ8uSIIYB2ST4bJGyFBu4ipRgoht2tyEqoYrT87shDeO8JvM1Pd4FIgc1a/ xlv+RG3QBYCJSDyCi3lG/jSq4ZnRefmDc3J7tO4yqzWuIrLWAknwnZUtVHTRRFnWKNfm 0Xtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dMe27PCpSGrpKy6akin6UXrBQxmCtSQz/w0mkm8+aO0=; fh=76YcXYkwCkrrOmEqPlOzLjAKFfXhY9Nad2p8cdg93+w=; b=kByjlIGRSBmq+wp0rSb2hEtqFV7CSo40G4JgoUCT5pXsrmXJ/FmHTFdHN1DzFjNIul b3qoeGUCcrSVAqgshTcXQvikl8QmJcG+BqNaYvIkWRkEAlJ1d1VItYRYZY9obMFJdGHM CaxGQHloyeziHBkhyOnlNUb5Li3r/GhA3/dPhkYPmmrmJGiJwVuJQDP3Q/VF7H0usQml PxLCDSx2uLEbJBlzEFhFT9TUpYJ4YjelhAIUCu8gupmcaOGV4bOLdVKiS3tgQ1vXagyh ykf4HP2ISS3vHSmH8R5QBnU9NauXJiVcQxidLYxKfDqd+gR3yetpUdOxAafughfFQpE+ RpRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ByWIc5KZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id 11-20020a056a00070b00b006c21aeb4041si591155pfl.125.2023.11.10.16.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 16:30:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ByWIc5KZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 04F1383D0FF3; Fri, 10 Nov 2023 16:29:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345037AbjKKA3k (ORCPT + 29 others); Fri, 10 Nov 2023 19:29:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345003AbjKKA3i (ORCPT ); Fri, 10 Nov 2023 19:29:38 -0500 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3A893C39 for ; Fri, 10 Nov 2023 16:29:35 -0800 (PST) Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-66d0f945893so22003046d6.1 for ; Fri, 10 Nov 2023 16:29:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699662575; x=1700267375; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dMe27PCpSGrpKy6akin6UXrBQxmCtSQz/w0mkm8+aO0=; b=ByWIc5KZlNlmBIPWwJcgT983Yq9tWUr/KFSiBxanH4vHTBB4WGPQMvsSgrgFr4s1WK CPkuT5sAeDsk6xRLNjHENt5wN1pxV7Zudq1O93U3MbiVyiKE/E7CRZzjAqXYAPcmGZ2D wQnHuSe4VbJhXZfJvPRAsKl8iSIQcbO9nKVhc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699662575; x=1700267375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dMe27PCpSGrpKy6akin6UXrBQxmCtSQz/w0mkm8+aO0=; b=TF+TLrxP16IRojHMvOmJssjYWFUECQPBb1LPav/UZPEe3J2fXAYLHxqOtIeDBXKEP3 hQ0RtAVF8/9hHXbcz0iQ6s/6yoYQ9fPlxhuYI8QIuHaokA7moQlNg1m9OD5PNrsTPja7 ImMflijbk/PXrbOl9zU91HEwtaVgcC3XRpFM81jlHWS7vRHQm2IM60DLdbtCuC899+Hm Kg438I4M4hCDCs9WjcibSArdl3mjnsHnc7j/RPtLj/QFSppxvV7VQU5qK8Fz4CkS0Qv4 PWlzI22d9gxXRd1862VEPA7HVs4aLBtHDDFJf76sXCIquYbtsrHPztu+ydV59aTaHtAG IUCg== X-Gm-Message-State: AOJu0YzLtG7uYPfFmhB+urnVd/i3gCii/GoYDlyRBFT0NqLxThxCqAtN cXbupdAEbC0rcVopfAx0VRHtYQ== X-Received: by 2002:ad4:4e6d:0:b0:670:ba7c:938d with SMTP id ec13-20020ad44e6d000000b00670ba7c938dmr1203791qvb.25.1699662575054; Fri, 10 Nov 2023 16:29:35 -0800 (PST) Received: from kea.bld.corp.google.com ([2620:15c:183:200:5104:5a27:f95d:21d1]) by smtp.gmail.com with ESMTPSA id l16-20020a056214029000b00677adcfd261sm55898qvv.89.2023.11.10.16.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 16:29:34 -0800 (PST) From: Simon Glass To: linux-arm-kernel@lists.infradead.org Cc: lkml , Tom Rini , Masahiro Yamada , U-Boot Mailing List , Simon Glass , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , linux-kbuild@vger.kernel.org Subject: [PATCH v5 2/3] arm: boot: Move the single quotes for image name Date: Fri, 10 Nov 2023 17:28:01 -0700 Message-ID: <20231111002851.1293891-3-sjg@chromium.org> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231111002851.1293891-1-sjg@chromium.org> References: <20231111002851.1293891-1-sjg@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 10 Nov 2023 16:29:48 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782225412020986017 X-GMAIL-MSGID: 1782225412020986017 Add quotes where UIMAGE_NAME is used, rather than where it is defined. This allows the UIMAGE_NAME variable to be set by the user. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Add a patch to move the single quotes for image name scripts/Makefile.lib | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 68d0134bdbf9..1a965fe68e01 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -487,14 +487,14 @@ UIMAGE_OPTS-y ?= UIMAGE_TYPE ?= kernel UIMAGE_LOADADDR ?= arch_must_set_this UIMAGE_ENTRYADDR ?= $(UIMAGE_LOADADDR) -UIMAGE_NAME ?= 'Linux-$(KERNELRELEASE)' +UIMAGE_NAME ?= Linux-$(KERNELRELEASE) quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(BASH) $(MKIMAGE) -A $(UIMAGE_ARCH) -O linux \ -C $(UIMAGE_COMPRESSION) $(UIMAGE_OPTS-y) \ -T $(UIMAGE_TYPE) \ -a $(UIMAGE_LOADADDR) -e $(UIMAGE_ENTRYADDR) \ - -n $(UIMAGE_NAME) -d $< $@ + -n '$(UIMAGE_NAME)' -d $< $@ # XZ # --------------------------------------------------------------------------- From patchwork Sat Nov 11 00:28:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 164039 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp1470615vqs; Fri, 10 Nov 2023 16:31:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnSOSViBNl14yrzfRGrZT8vGiEiUZm4h7IKrnNCQQMAkvmqMrIEh4aVLzBGnQNCb82FLi8 X-Received: by 2002:a9d:6d11:0:b0:6d3:1d04:55f with SMTP id o17-20020a9d6d11000000b006d31d04055fmr830393otp.8.1699662715305; Fri, 10 Nov 2023 16:31:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699662715; cv=none; d=google.com; s=arc-20160816; b=r4WTUpeIRruL779MxmFjxsCspAZHBQ0bmgGjuI0w80yeTaiwQDvkG0vnUpf77rRGW1 hIE7bbqwIEKJbGCdreptCxAXzQmSyJHTGpteR53f2ntfQN4Wr8M+jGzWQaJd0oIckE9q wnXaz4cRQrApic5ut0B4kuuA5NKAvwQgzYMYeiv95rZHvgh3Z6Ipx9s/DQSEsgFWChSC lMMSdqxt8AMZQd3otTs/FefUaRHwrujPpsA9RcEQyzgj+32fE3kHSW9E2dYuZD9DcBgx ddiGJYYF+KKT4SSZREM9tvVmo4snOZnbQtPY2zQ9uW5OuEHjZtiPzGH2m2TV2vdW6PQv XSog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=P74lj3H9s1SB/HLRWB5sTm4MijoXiYyy8vj6I4JQBFg=; fh=zwaITau8IU0ZWX9GOVZL+cKAAose/b7BX54Wv8PG0ww=; b=YCtVV3rtdNWDxt9nsFYh8hEPR4627NNxE+XwOmuK9Ta4j1JflGz/4qjAdL3vrHyL7E 2+QwNiXK/MzoUXle8elz3buYyMvOd7YVm3WQs3xKb16nvb78o1w3jn/+UNUxhCqFaQxa 6yLTMElRqWzxGz6/SKOIaw+WqQFG99u0rC/KBAYU+pyZ/ERFKf48MFlWYRYJGsdS0Aod 6FBdrJszethN7otYjXaM9iwoFSfdV8g/PCJJ/eoSJIa7/XBZFHSZBMEov6cinx9piXCh PSQKJwzSP3IVxjdi50mPWr30jYgskXStSWcEXfZ0zZOt+49uQ1T9w5qqrS+GNgK2LsPN nKpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OadXyV7l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id by35-20020a056a0205a300b00578da80ac3dsi744105pgb.80.2023.11.10.16.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 16:31:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OadXyV7l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id A66EC807D68F; Fri, 10 Nov 2023 16:30:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbjKKA3p (ORCPT + 29 others); Fri, 10 Nov 2023 19:29:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345003AbjKKA3m (ORCPT ); Fri, 10 Nov 2023 19:29:42 -0500 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92939448C for ; Fri, 10 Nov 2023 16:29:38 -0800 (PST) Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-66d264e67d8so15154976d6.1 for ; Fri, 10 Nov 2023 16:29:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699662577; x=1700267377; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P74lj3H9s1SB/HLRWB5sTm4MijoXiYyy8vj6I4JQBFg=; b=OadXyV7leR3zS4kYrCuyuPQo86N9Rpj0TimKxU8xl+QyCbnOftfEFfBpipM1TTWA1L zMySQDh8hd93NFZW7RqJroW69S+69eL6K8W5T8p5LwgBM6ajbHGQbC5R+JgxuVe91JHT hYD58qr54SxR+oeCydHkfQxVykDwkEr5ANR+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699662577; x=1700267377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P74lj3H9s1SB/HLRWB5sTm4MijoXiYyy8vj6I4JQBFg=; b=u5V/+TxeSm08b9tAILTPum4V/pdfhdTem3plBnWkXK2z2B85Pk92K7gWXbNdner13t Cxsm5uAU23u7VEi7PBjY6qwcfzeORXf4rhcLTHjxv9ugm467LSpzcraK1S6nJ8Se3Gr5 ZbjBjyH1CbQWY5XSm2MuvAuw6u2gNZ2fvZtYGgMkUibcbf1WyglGNVm8NFY+MMVVefRu zxQqinLBaiIlTk/CHwI7XG4H3wbrUt+JevfmuIr3V/mbF9jVFZHxl6V+RhzusjEIJMGV FZCaeipI9uxmw1ccqyNJdXPOOp2yySPHeC/Z4+1uV5r9ppLlriYdKt/TMl4QkP8PL4av BaLA== X-Gm-Message-State: AOJu0YyTmbi+sPodK14/xde7oWDbzVTp3GIfQqz27x7IULHhkQQqXxOm iJenSadiBDEv/sfrCiK/dPikLQ== X-Received: by 2002:a0c:bf0e:0:b0:66d:59da:d225 with SMTP id m14-20020a0cbf0e000000b0066d59dad225mr611665qvi.15.1699662577569; Fri, 10 Nov 2023 16:29:37 -0800 (PST) Received: from kea.bld.corp.google.com ([2620:15c:183:200:5104:5a27:f95d:21d1]) by smtp.gmail.com with ESMTPSA id l16-20020a056214029000b00677adcfd261sm55898qvv.89.2023.11.10.16.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 16:29:36 -0800 (PST) From: Simon Glass To: linux-arm-kernel@lists.infradead.org Cc: lkml , Tom Rini , Masahiro Yamada , U-Boot Mailing List , Simon Glass , Catalin Marinas , Nathan Chancellor , Nick Desaulniers , Nick Terrell , Nicolas Schier , Will Deacon , linux-kbuild@vger.kernel.org Subject: [PATCH v5 3/3] arm64: boot: Support Flat Image Tree Date: Fri, 10 Nov 2023 17:28:02 -0700 Message-ID: <20231111002851.1293891-4-sjg@chromium.org> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231111002851.1293891-1-sjg@chromium.org> References: <20231111002851.1293891-1-sjg@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_PDS_OTHER_BAD_TLD, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 10 Nov 2023 16:30:13 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782225531438854943 X-GMAIL-MSGID: 1782225531438854943 Add a script which produces a Flat Image Tree (FIT), a single file containing the built kernel and associated devicetree files. Compression defaults to gzip which gives a good balance of size and performance. The files compress from about 86MB to 24MB using this approach. The FIT can be used by bootloaders which support it, such as U-Boot and Linuxboot. It permits automatic selection of the correct devicetree, matching the compatible string of the running board with the closest compatible string in the FIT. There is no need for filenames or other workarounds. Add a 'make image.fit' build target for arm64, as well. The FIT can be examined using 'dumpimage -l'. This features requires pylibfdt (use 'pip install libfdt'). It also requires compression utilities for the algorithm being used. Supported compression options are the same as the Image.xxx files. For now there is no way to change the compression other than by editing the rule for $(obj)/image.fit While FIT supports a ramdisk / initrd, no attempt is made to support this here, since it must be built separately from the Linux build. Signed-off-by: Simon Glass --- Changes in v5: - Correct compression rule which was broken in v4 Changes in v4: - Use single quotes for UIMAGE_NAME Changes in v3: - Drop temporary file image.itk - Drop patch 'Use double quotes for image name' - Drop double quotes in use of UIMAGE_NAME - Drop unnecessary CONFIG_EFI_ZBOOT condition for help - Avoid hard-coding "arm64" for the DT architecture Changes in v2: - Drop patch previously applied - Add .gitignore file - Move fit rule to Makefile.lib using an intermediate file - Drop dependency on CONFIG_EFI_ZBOOT - Pick up .dtb files separately from the kernel - Correct pylint too-many-args warning for write_kernel() - Include the kernel image in the file count - Add a pointer to the FIT spec and mention of its wide industry usage - Mention the kernel version in the FIT description MAINTAINERS | 7 + arch/arm64/Makefile | 3 +- arch/arm64/boot/.gitignore | 1 + arch/arm64/boot/Makefile | 6 +- scripts/Makefile.lib | 13 ++ scripts/make_fit.py | 289 +++++++++++++++++++++++++++++++++++++ 6 files changed, 317 insertions(+), 2 deletions(-) create mode 100755 scripts/make_fit.py diff --git a/MAINTAINERS b/MAINTAINERS index c934244acc31..b7588504b74c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1575,6 +1575,13 @@ F: Documentation/process/maintainer-soc*.rst F: arch/arm/boot/dts/Makefile F: arch/arm64/boot/dts/Makefile +ARM64 FIT SUPPORT +M: Simon Glass +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) +S: Maintained +F: arch/arm64/boot/Makefile +F: scripts/make_fit.py + ARM ARCHITECTED TIMER DRIVER M: Mark Rutland M: Marc Zyngier diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index cd9bca2358d2..c377cf4c6dcf 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -150,7 +150,7 @@ libs-$(CONFIG_EFI_STUB) += $(objtree)/drivers/firmware/efi/libstub/lib.a # Default target when executing plain make boot := arch/arm64/boot -BOOT_TARGETS := Image.gz vmlinuz.efi +BOOT_TARGETS := Image.gz vmlinuz.efi image.fit PHONY += $(BOOT_TARGETS) @@ -218,6 +218,7 @@ virtconfig: define archhelp echo '* Image.gz - Compressed kernel image (arch/$(ARCH)/boot/Image.gz)' echo ' Image - Uncompressed kernel image (arch/$(ARCH)/boot/Image)' + echo ' image.fit - Flat Image Tree (arch/$(ARCH)/boot/image.fit)' echo ' install - Install uncompressed kernel' echo ' zinstall - Install compressed kernel' echo ' Install using (your) ~/bin/installkernel or' diff --git a/arch/arm64/boot/.gitignore b/arch/arm64/boot/.gitignore index af5dc61f8b43..abaae9de1bdd 100644 --- a/arch/arm64/boot/.gitignore +++ b/arch/arm64/boot/.gitignore @@ -2,3 +2,4 @@ Image Image.gz vmlinuz* +image.fit diff --git a/arch/arm64/boot/Makefile b/arch/arm64/boot/Makefile index 1761f5972443..8d591fda078f 100644 --- a/arch/arm64/boot/Makefile +++ b/arch/arm64/boot/Makefile @@ -16,7 +16,8 @@ OBJCOPYFLAGS_Image :=-O binary -R .note -R .note.gnu.build-id -R .comment -S -targets := Image Image.bz2 Image.gz Image.lz4 Image.lzma Image.lzo Image.zst +targets := Image Image.bz2 Image.gz Image.lz4 Image.lzma Image.lzo \ + Image.zst image.fit $(obj)/Image: vmlinux FORCE $(call if_changed,objcopy) @@ -39,6 +40,9 @@ $(obj)/Image.lzo: $(obj)/Image FORCE $(obj)/Image.zst: $(obj)/Image FORCE $(call if_changed,zstd) +$(obj)/image.fit: $(obj)/Image FORCE + $(call cmd,fit,gzip) + EFI_ZBOOT_PAYLOAD := Image EFI_ZBOOT_BFD_TARGET := elf64-littleaarch64 EFI_ZBOOT_MACH_TYPE := ARM64 diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 1a965fe68e01..ecd8cd358f3e 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -496,6 +496,19 @@ quiet_cmd_uimage = UIMAGE $@ -a $(UIMAGE_LOADADDR) -e $(UIMAGE_ENTRYADDR) \ -n '$(UIMAGE_NAME)' -d $< $@ +# Flat Image Tree (FIT) +# This allows for packaging of a kernel and all devicetrees files, using +# compression. +# --------------------------------------------------------------------------- + +MAKE_FIT := $(srctree)/scripts/make_fit.py + +quiet_cmd_fit = FIT $@ + cmd_fit = $(MAKE_FIT) -f $@ --arch $(UIMAGE_ARCH) --os linux \ + --name '$(UIMAGE_NAME)' \ + --compress $(UIMAGE_COMPRESSION) -k $< \ + $(dir $<)/dts + # XZ # --------------------------------------------------------------------------- # Use xzkern to compress the kernel image and xzmisc to compress other things. diff --git a/scripts/make_fit.py b/scripts/make_fit.py new file mode 100755 index 000000000000..e1059825de9c --- /dev/null +++ b/scripts/make_fit.py @@ -0,0 +1,289 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0+ +# +# Copyright 2023 Google LLC +# Written by Simon Glass +# + +"""Build a FIT containing a lot of devicetree files + +Usage: + make_fit.py -A arm64 -n 'Linux-6.6' -O linux + -f arch/arm64/boot/image.fit -k /tmp/kern/arch/arm64/boot/image.itk + /tmp/kern/arch/arm64/boot/dts/ -E -c gzip + +Creates a FIT containing the supplied kernel and a directory containing the +devicetree files. + +Use -E to generate an external FIT (where the data is placed after the +FIT data structure). This allows parsing of the data without loading +the entire FIT. + +Use -c to compress the data, using bzip2, gzip, lz4, lzma, lzo and +zstd + +The resulting FIT can be booted by bootloaders which support FIT, such +as U-Boot, Linuxboot, Tianocore, etc. + +Note that this tool does not yet support adding a ramdisk / initrd. +""" + +import argparse +import collections +import os +import subprocess +import sys +import tempfile +import time + +import libfdt + + +# Tool extension and the name of the command-line tools +CompTool = collections.namedtuple('CompTool', 'ext,tools') + +COMP_TOOLS = { + 'bzip2': CompTool('.bz2', 'bzip2'), + 'gzip': CompTool('.gz', 'pigz,gzip'), + 'lz4': CompTool('.lz4', 'lz4'), + 'lzma': CompTool('.lzma', 'lzma'), + 'lzo': CompTool('.lzo', 'lzop'), + 'zstd': CompTool('.zstd', 'zstd'), +} + +def parse_args(): + """Parse the program ArgumentParser + + Returns: + Namespace object containing the arguments + """ + epilog = 'Build a FIT from a directory tree containing .dtb files' + parser = argparse.ArgumentParser(epilog=epilog) + parser.add_argument('-A', '--arch', type=str, required=True, + help='Specifies the architecture') + parser.add_argument('-c', '--compress', type=str, default='none', + help='Specifies the compression') + parser.add_argument('-E', '--external', action='store_true', + help='Convert the FIT to use external data') + parser.add_argument('-n', '--name', type=str, required=True, + help='Specifies the name') + parser.add_argument('-O', '--os', type=str, required=True, + help='Specifies the operating system') + parser.add_argument('-f', '--fit', type=str, required=True, + help='Specifies the output file (.fit)') + parser.add_argument('-k', '--kernel', type=str, required=True, + help='Specifies the (uncompressed) kernel input file (.itk)') + parser.add_argument('srcdir', type=str, nargs='*', + help='Specifies the directory tree that contains .dtb files') + + return parser.parse_args() + +def setup_fit(fsw, name): + """Make a start on writing the FIT + + Outputs the root properties and the 'images' node + + Args: + fsw (libfdt.FdtSw): Object to use for writing + name (str): Name of kernel image + """ + fsw.INC_SIZE = 65536 + fsw.finish_reservemap() + fsw.begin_node('') + fsw.property_string('description', f'{name} with devicetree set') + fsw.property_u32('#address-cells', 1) + + fsw.property_u32('timestamp', int(time.time())) + fsw.begin_node('images') + + +def write_kernel(fsw, data, args): + """Write out the kernel image + + Writes a kernel node along with the required properties + + Args: + fsw (libfdt.FdtSw): Object to use for writing + data (bytes): Data to write (possibly compressed) + args (Namespace): Contains necessary strings: + arch: FIT architecture, e.g. 'arm64' + fit_os: Operating Systems, e.g. 'linux' + name: Name of OS, e.g. 'Linux-6.6.0-rc7' + compress: Compression algorithm to use, e.g. 'gzip' + """ + with fsw.add_node('kernel'): + fsw.property_string('description', args.name) + fsw.property_string('type', 'kernel_noload') + fsw.property_string('arch', args.arch) + fsw.property_string('os', args.os) + fsw.property_string('compression', args.compress) + fsw.property('data', data) + fsw.property_u32('load', 0) + fsw.property_u32('entry', 0) + + +def finish_fit(fsw, entries): + """Finish the FIT ready for use + + Writes the /configurations node and subnodes + + Args: + fsw (libfdt.FdtSw): Object to use for writing + entries (list of tuple): List of configurations: + str: Description of model + str: Compatible stringlist + """ + fsw.end_node() + seq = 0 + with fsw.add_node('configurations'): + for model, compat in entries: + seq += 1 + with fsw.add_node(f'conf-{seq}'): + fsw.property('compatible', bytes(compat)) + fsw.property_string('description', model) + fsw.property_string('fdt', f'fdt-{seq}') + fsw.property_string('kernel', 'kernel') + fsw.end_node() + + +def compress_data(inf, compress): + """Compress data using a selected algorithm + + Args: + inf (IOBase): Filename containing the data to compress + compress (str): Compression algorithm, e.g. 'gzip' + + Return: + bytes: Compressed data + """ + if compress == 'none': + return inf.read() + + comp = COMP_TOOLS.get(compress) + if not comp: + raise ValueError(f"Unknown compression algorithm '{compress}'") + + with tempfile.NamedTemporaryFile() as comp_fname: + with open(comp_fname.name, 'wb') as outf: + done = False + for tool in comp.tools.split(','): + try: + subprocess.call([tool, '-c'], stdin=inf, stdout=outf) + done = True + break + except FileNotFoundError: + pass + if not done: + raise ValueError(f'Missing tool(s): {comp.tools}\n') + with open(comp_fname.name, 'rb') as compf: + comp_data = compf.read() + return comp_data + + +def output_dtb(fsw, seq, fname, arch, compress): + """Write out a single devicetree to the FIT + + Args: + fsw (libfdt.FdtSw): Object to use for writing + seq (int): Sequence number (1 for first) + fmame (str): Filename containing the DTB + arch: FIT architecture, e.g. 'arm64' + compress (str): Compressed algorithm, e.g. 'gzip' + + Returns: + tuple: + str: Model name + bytes: Compatible stringlist + """ + with fsw.add_node(f'fdt-{seq}'): + # Get the compatible / model information + with open(fname, 'rb') as inf: + data = inf.read() + fdt = libfdt.FdtRo(data) + model = fdt.getprop(0, 'model').as_str() + compat = fdt.getprop(0, 'compatible') + + fsw.property_string('description', model) + fsw.property_string('type', 'flat_dt') + fsw.property_string('arch', arch) + fsw.property_string('compression', compress) + fsw.property('compatible', bytes(compat)) + + with open(fname, 'rb') as inf: + compressed = compress_data(inf, compress) + fsw.property('data', compressed) + return model, compat + + +def build_fit(args): + """Build the FIT from the provided files and arguments + + Args: + args (Namespace): Program arguments + + Returns: + tuple: + bytes: FIT data + int: Number of configurations generated + size: Total uncompressed size of data + """ + fsw = libfdt.FdtSw() + setup_fit(fsw, args.name) + seq = 0 + size = 0 + entries = [] + + # Handle the kernel + with open(args.kernel, 'rb') as inf: + comp_data = compress_data(inf, args.compress) + size += os.path.getsize(args.kernel) + write_kernel(fsw, comp_data, args) + + for path in args.srcdir: + # Handle devicetree files + if os.path.isdir(path): + for dirpath, _, fnames in os.walk(path): + for fname in fnames: + if os.path.splitext(fname)[1] != '.dtb': + continue + pathname = os.path.join(dirpath, fname) + seq += 1 + size += os.path.getsize(pathname) + model, compat = output_dtb(fsw, seq, pathname, + args.arch, args.compress) + entries.append([model, compat]) + + finish_fit(fsw, entries) + + # Include the kernel itself in the returned file count + return fsw.as_fdt().as_bytearray(), seq + 1, size + + +def run_make_fit(): + """Run the tool's main logic""" + args = parse_args() + + out_data, count, size = build_fit(args) + with open(args.fit, 'wb') as outf: + outf.write(out_data) + + ext_fit_size = None + if args.external: + mkimage = os.environ.get('MKIMAGE', 'mkimage') + subprocess.check_call([mkimage, '-E', '-F', args.fit], + stdout=subprocess.DEVNULL) + + with open(args.fit, 'rb') as inf: + data = inf.read() + ext_fit = libfdt.FdtRo(data) + ext_fit_size = ext_fit.totalsize() + + comp_size = len(out_data) + print(f'FIT size {comp_size:#x}/{comp_size / 1024 / 1024:.1f} MB', end='') + if ext_fit_size: + print(f', header {ext_fit_size:#x}/{ext_fit_size / 1024:.1f} KB', end='') + print(f', {count} files, uncompressed {size / 1024 / 1024:.1f} MB') + + +if __name__ == "__main__": + sys.exit(run_make_fit())