From patchwork Wed Nov 8 11:27:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 162986 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp845835vqo; Wed, 8 Nov 2023 03:28:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7rhvAtYSegFVHQlECGkIzRkKVwI2sfSoEMIxDg/HMzc3v0mPSQb+q16KlO3ylo/OpdPaw X-Received: by 2002:a05:6358:60c9:b0:168:dc03:5b90 with SMTP id i9-20020a05635860c900b00168dc035b90mr1256591rwi.23.1699442892099; Wed, 08 Nov 2023 03:28:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699442892; cv=none; d=google.com; s=arc-20160816; b=E/4+UTLLx2AdkfTk+nsGZcBsU3pFU3fuekiFAgRYP0UMEyf8kRqscJ5gd179s6z9/O ygrFkPmGtQ6IIHjI3FLxpy7L/jt4w2XL6KMGfRVYL3ULk0qLm3RKr2lbCUp4bgu4zs3N LkFgV9ZypV0sggD/Kw3TYIhEpJTrgZnJbxN3qhiBIG7APw61jSyRR16z1wIpBqM8sO7O 1F1Q64ITEtPhsQVmk8jjjyaw9JxKaCii+q3L7iSYxJsUCLJd94FiqQKm8Ai0lnZDbSj3 cykA95V3nxdh4x2oDU7XvJzDlvGVinjw437s1S5UvytyYzetHqg+qk5h1Tzp6SXmei7Z 7LLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=sAgQG4nXVs7CtDhoDiRwDYSCvQfcAn68yaBA8fWqKZg=; fh=g/0b7r8jCWOEP8jiTCKxjmVRm1mB037wJnPKyZOXFXQ=; b=LNj9tk54XfzGfPdwRquH++nHM2SX/PrSrYUPF2fTbhI8Nb8rQhOgerfGP9lsM9bzAW MtgvBxvrUxeFw2K322jATp5xcuvKGIgPdhY+l1QSbq+8iIpK+QLoPBlxLg/aMTrqM15I 37W4EPzD84nosjMPh1QoBwNh7TyEaFXWvBM72O229+JtK1IbhILUrVygndv3QsDlmrro MzAWOpwjWSLBWSRUkZITlYKB9Zu5D6HuFfyfeqw2LIbv5XA5aNHXCiGCjNA/tw1vS6us 5ae6RNVBaAKODE+kbEayuYIaac/3m58YRAQruP9qTsEVrvRLVbzkvkBpNbYc9jKVmld7 Uvew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=D+Xaz5WZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id cl15-20020a056a02098f00b00565fb7714a5si5362669pgb.800.2023.11.08.03.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 03:28:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=D+Xaz5WZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 1967781906A0; Wed, 8 Nov 2023 03:28:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344193AbjKHL1v (ORCPT + 32 others); Wed, 8 Nov 2023 06:27:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230027AbjKHL1t (ORCPT ); Wed, 8 Nov 2023 06:27:49 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F05D3125 for ; Wed, 8 Nov 2023 03:27:46 -0800 (PST) Received: from [127.0.1.1] (91-158-149-209.elisa-laajakaista.fi [91.158.149.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 066549CE; Wed, 8 Nov 2023 12:27:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699442843; bh=ESi3QXvdrPJPsDVjF/DwgziokaGysmi+TxRwxWKYcvA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=D+Xaz5WZpjygggABWtHRATjCGOIKaQlvpFkhDqm8UQ/lbiLixV1lWqaUrQ3y1aZcD Jyo6c/d7WReV95RelMYO5vcT1DbMN5vvZDzKOogCoRlobJdnJW6EmzneU1OErfDD7u gbOLAhBnfj8Og4eoQgj1taV9iFR1iNEg7Ya7YePk= From: Tomi Valkeinen Date: Wed, 08 Nov 2023 13:27:22 +0200 Subject: [PATCH v2 1/2] drm/bridge: tc358767: Add format negotiation hooks for DPI/DSI to (e)DP MIME-Version: 1.0 Message-Id: <20231108-tc358767-v2-1-25c5f70a2159@ideasonboard.com> References: <20231108-tc358767-v2-0-25c5f70a2159@ideasonboard.com> In-Reply-To: <20231108-tc358767-v2-0-25c5f70a2159@ideasonboard.com> To: Aradhya Bhatia , Jan Kiszka , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomi Valkeinen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=2590; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=gkFUqK8asRdZuuVJEG+fN5qn9GJatIx4noljnC3chp4=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBlS3CuLgqoikq+hWg6V5khUb5Ojwo90U8sA01A1 iUh/4KfgdmJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZUtwrgAKCRD6PaqMvJYe 9aLoD/9meoqcfs9iA+kgzrfNwUKIHwGaT13TI34RTVIXqGuvbpwrmJ8Bviv0blv6QS2XMi9Aa3g swB2CrD9C82RLglU2rftNoAeKoirQwGhbv7eH2SWhbyCRy4MWayGwsjJrMs6N2Vq8BU73aqdhnY a6z3Adm+5MLE4kPwcsNR2K2g/RuNcWxlGrGrz+Brvzo34UHmBK2GYc4XEODtZUM40ZKzc7NBalR RqSWHISfOoWyuSduu5Wn12HSNE+3ppqgDXcrEc7bAgbBqC29oOJfyVwJYJW5d6rKcgWmlFvOeZq wgmYvJb7Y46HgIBynQ20WJyF3k3GotL+H4IIgQ8BTy8E0ob8/qk6ffjVDe6GVGdkHC0DECeZLX9 JX7uIUAuKYn0GCeYi4TnsG6Ikv7/GjhQq0itedvfh8TeyH5ZVpCUQwd/5+R8H1/A6T0xo4ivNHr ti7Qmc7JisZEeaFNRPFa8+WmVBGdEONJHKZP+BygbuqtJxjh5GlFRM39WvYJ56wgcE8HTf33w6v D6GtRZ2EQ0gipcbYyP4mtb+azT56sap9pV4LNZkNA8aWVBReOhSEA+cxXJc/Q8vm9gwFssLliIe WbA/azbMHmpnnnxrb9zSdMcWSXX0My56F6t/kT/+wzHNgQZK+ofW8MFyBLI6OpwDEmsdxvgtzOL ZZTiKd6y0n44TCQ== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 08 Nov 2023 03:28:07 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781995030021988051 X-GMAIL-MSGID: 1781995030021988051 From: Aradhya Bhatia With new connector model, tc358767 will not create the connector, when DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will rely on format negotiation to setup the encoder format. Add the missing bus format negotiation hooks in the drm_bridge_funcs to complete DRM_BRIDGE_ATTACH_NO_CONNECTOR support. Output format, for DPI/DSI to DP, is selected to MEDIA_BUS_FMT_RGB888_1X24 as default, keeping in mind what the older model used to support. Reported-by: Jan Kiszka Closes: https://lore.kernel.org/all/24282420-b4dd-45b3-bb1c-fc37fe4a8205@siemens.com/ Signed-off-by: Aradhya Bhatia Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index ef2e373606ba..89a0d804270a 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1726,6 +1726,7 @@ static void tc_edp_bridge_detach(struct drm_bridge *bridge) } #define MAX_INPUT_SEL_FORMATS 1 +#define MAX_OUTPUT_SEL_FORMATS 1 static u32 * tc_dpi_atomic_get_input_bus_fmts(struct drm_bridge *bridge, @@ -1751,6 +1752,28 @@ tc_dpi_atomic_get_input_bus_fmts(struct drm_bridge *bridge, return input_fmts; } +static u32 * +tc_edp_atomic_get_output_bus_fmts(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state, + unsigned int *num_output_fmts) +{ + u32 *output_fmts; + + *num_output_fmts = 0; + + output_fmts = kcalloc(MAX_OUTPUT_SEL_FORMATS, sizeof(*output_fmts), + GFP_KERNEL); + if (!output_fmts) + return NULL; + + output_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24; + *num_output_fmts = 1; + + return output_fmts; +} + static const struct drm_bridge_funcs tc_dpi_bridge_funcs = { .attach = tc_dpi_bridge_attach, .mode_valid = tc_dpi_mode_valid, @@ -1777,6 +1800,8 @@ static const struct drm_bridge_funcs tc_edp_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_get_input_bus_fmts = drm_atomic_helper_bridge_propagate_bus_fmt, + .atomic_get_output_bus_fmts = tc_edp_atomic_get_output_bus_fmts, }; static bool tc_readable_reg(struct device *dev, unsigned int reg) From patchwork Wed Nov 8 11:27:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 162985 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp845769vqo; Wed, 8 Nov 2023 03:28:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHml/J5EidsFXIocRVT87zlN/ezmrfZx5S9bWvQo1TTSGdi1MfcCtSdxYoX+E8TN8HlXy3C X-Received: by 2002:a05:6870:a711:b0:1e9:faca:bd1d with SMTP id g17-20020a056870a71100b001e9facabd1dmr1742553oam.24.1699442883751; Wed, 08 Nov 2023 03:28:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699442883; cv=none; d=google.com; s=arc-20160816; b=lfL/luS3O0S2adDtrX5Ry9/P1iLFEPD24907UevW+jplIHePAdW65zluQ1GsVqDZcA Lg7+P0YmDSUTdn/4qKRBg09Lk+hfJ8Rf1jUKoSPWqfKl20gKSAb+HYUp8zTNi5pyU/Cc cMF5yInyYmDeYe5jF+Sqt4K3ll8/9Y5mWUMEhYmn9RN9rggNsu8lZ7o9BuCJcwnXbR3g QAaN7iurXEzlOeUYJOpUqyxihB1xqKxVD3/ZCj9znVitTDZRDQLeid4170BL106fE3sx ckS1sZ/PcJV4JjQohzE9GQ+e1QxkK/Yq5HOn70LuIgP3+24VqLmbLy+wUurPJ09L0Doy 2S5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=Gier46EGotxsmevBLkk9Zdbzfpu1F5dt7Vn2ycoFAoU=; fh=g/0b7r8jCWOEP8jiTCKxjmVRm1mB037wJnPKyZOXFXQ=; b=R6B46U/3kEe2FL7zuS/h0aFU4YQ43XiaHEmjHlCbE0C7/X/UEbKsGR9ISyr763mN2a xOe+PT5aj91l6LPZZxQaZQMjyM3v9fIbRZ2+xYlOUy8G8IB+pPuthGDdfqIwHxiKlxPS W7nso8p8YTNJNlZjL2Hai1324NXuhpPxQFlz35ico0R47pNw0tjkfU1s0UC5uO57bPSF qjmKII/uxNx/CHJBikJGoqSJw9b/G48ab1YuRXmvUB4YNPXLLqjxd1CyCkfPTdYVsQGK GcbtxyrdpzunHCNIAN8IjZQRrpCP6H9kgKFPoZ8a0wuT4TepPiGR+T2CgOhIPgq/aZ3G qgqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=WHwrw3nO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id q17-20020a635c11000000b005b8615bd40dsi4244679pgb.813.2023.11.08.03.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 03:28:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=WHwrw3nO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 9DAA083AF89A; Wed, 8 Nov 2023 03:28:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344504AbjKHL14 (ORCPT + 32 others); Wed, 8 Nov 2023 06:27:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344181AbjKHL1u (ORCPT ); Wed, 8 Nov 2023 06:27:50 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABE05B0 for ; Wed, 8 Nov 2023 03:27:48 -0800 (PST) Received: from [127.0.1.1] (91-158-149-209.elisa-laajakaista.fi [91.158.149.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AFCFDA7; Wed, 8 Nov 2023 12:27:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699442845; bh=mQO4GFGB4ba5qpGWZ6Fm76wXqwKxUxVQPMjL2WqOXyA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=WHwrw3nOJnLpSJTwZHvOt5bFptrKIc0ff0+v2jN37yEjfaFK7czp9W26Oy0AqIiiy k3xlt7v9LaJq6EThQ910XDcD2O5iSm57hYbtxD4cvFMTu+lycCiq8FD5BtDqAWvDrP 18WJxs/gLAv5jVrwm0gBmTppeRJZuUA2hrfQBBfs= From: Tomi Valkeinen Date: Wed, 08 Nov 2023 13:27:23 +0200 Subject: [PATCH v2 2/2] drm/bridge: tc358767: Fix link properties discovery MIME-Version: 1.0 Message-Id: <20231108-tc358767-v2-2-25c5f70a2159@ideasonboard.com> References: <20231108-tc358767-v2-0-25c5f70a2159@ideasonboard.com> In-Reply-To: <20231108-tc358767-v2-0-25c5f70a2159@ideasonboard.com> To: Aradhya Bhatia , Jan Kiszka , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomi Valkeinen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1817; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=mQO4GFGB4ba5qpGWZ6Fm76wXqwKxUxVQPMjL2WqOXyA=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBlS3CuZWM8600gBdH+ZsezO3CEMRcf/01hK8FHa PDT+ZTGEcOJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZUtwrgAKCRD6PaqMvJYe 9c6+EACkvo71voe39DODCsi/bTQ53yDdT71mickMljFgFF/0VKeFfUEL+Mepca05KQEiOxwz08h dxi0IoDMmVVRCyOhOfIBeZc3FjBGG+d4essAbVPsfJFYfiz0rofQ++h92LPy+vJB0yEfbut7Jnf /aPwEmhMnariHmygDW7pFRRG3PXVvAqmgiu0U2EQnj56m42H73AVPZdWznl0Xn+Dvh2vBLHZKy/ PHmVUjOoG/y5U498zN2KXFykvuTyOuArRF5QmR/9C2jADP1RXRMvBpi4gWdLJCYlNl8nP5MM+Cj 8mI33BcbY94FYDrqA3CYeUJ7p2SZ6ubJ6dNala0tPcTY+D2Kzyj5ytYuY5PF8Bnptti0w/Sg8Er w0CeSrFQi3sCzTsRW43++blOTSz7bBCZMYgtLyQwid0ynIq6FYhszBJT/2b1mKPQbKZRRcC8yoa RsHJK/Lu9YxVq5cq6cImpkazwIVdTaGGeGn45bGLVHYewDOKC5UQixSfu5CVAM25b79geTN4ASu ocmYzDgUoRnMJQeBfk/fi34T914hMzV9tW2yjRh1c3/gMIIemr6NJcofogoG7zhijM/yJqRjFUh wZF4wTXO4+lvyc3GLLirh0VdZ0pLe+kaeOSIJLcIyElDf8E8dQHKlyF6r856BcIpuovHEZ9TvI8 XzM22NNfYcT+/ZQ== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 08 Nov 2023 03:28:02 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781995021131506605 X-GMAIL-MSGID: 1781995021131506605 When a display controller driver uses DRM_BRIDGE_ATTACH_NO_CONNECTOR, tc358767 will behave properly and skip the creation of the connector. However, tc_get_display_props(), which is used to find out about the DP monitor and link, is only called from two places: .atomic_enable() and tc_connector_get_modes(). The latter is only used when tc358767 creates its own connector, i.e. when DRM_BRIDGE_ATTACH_NO_CONNECTOR is _not_ set. Thus, the driver never finds out the link properties before get_edid() is called. With num_lanes of 0 and link_rate of 0 there are not many valid modes... Fix this by adding tc_get_display_props() call at the beginning of get_edid(), so that we have up to date information before looking at the modes. Reported-by: Jan Kiszka Closes: https://lore.kernel.org/all/24282420-b4dd-45b3-bb1c-fc37fe4a8205@siemens.com/ Fixes: de5e6c027ae6 ("drm/bridge: tc358767: add drm_panel_bridge support") Reviewed-by: Aradhya Bhatia Tested-by: Jan Kiszka Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 89a0d804270a..5aafbdf423c6 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1579,6 +1579,13 @@ static struct edid *tc_get_edid(struct drm_bridge *bridge, struct drm_connector *connector) { struct tc_data *tc = bridge_to_tc(bridge); + int ret; + + ret = tc_get_display_props(tc); + if (ret < 0) { + dev_err(tc->dev, "failed to read display props: %d\n", ret); + return 0; + } return drm_get_edid(connector, &tc->aux.ddc); }