From patchwork Wed Nov 8 11:15:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Pieralisi X-Patchwork-Id: 162954 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp840402vqo; Wed, 8 Nov 2023 03:16:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGW4tpp44d7kkMCtsquuldQomditvEOAAA6BKONNL/i2LrcfdpGvvRndhqeWqtwFI7g1XNU X-Received: by 2002:a05:6a20:54a8:b0:136:faec:a7dc with SMTP id i40-20020a056a2054a800b00136faeca7dcmr1932344pzk.11.1699442217898; Wed, 08 Nov 2023 03:16:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699442217; cv=none; d=google.com; s=arc-20160816; b=fd5yR6CUdTc+z+DpVZkYWifO20cX62EuiOQrr54oIhPa4UbeHDWM5SxATl8O+dikUM 6wf1nf8Y8ikmqaFeXqMRNsPknKyHfThRXJicZWNN0wUHtE6zzRbhbTKDjbaDf/iC7w00 v6iOdNcrsQnZaapct7S7HQHH0Y6kZlgngzHHep8ahqDLbo0x7wLTD+qjkcedVo1CvwFh FMfDpkQqwycWmjN868usA7P7vcrTvCB0RLovMsKucxgpbSp+xBsJ1pCtS9tgEZf6AlN8 ccG50PHJGkWRDnOjpZDmYBLtQyz09LnY+mt/eKqC3b4zzs8rpY75oBnXSoIKPVAIanap sASQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/yIytjpzgDkiMYSMDlyB0ty6yRTVssXhoFYfPA1ICzo=; fh=BxC8ebr1UyPff4CWgKZO67/EQM9upoTYzVHEsddi4Jc=; b=Xt63g30JrbsemUqJAZjiKFw3ShHDmwVo7NWYccceCCzSokrIELnuSryMLrayyTov0q RRqExr2B5WzddsE7lBNCFu2a2Q/BVJQdVxnOhd2uvF39jNJzd/GdDp5h6pKTlLySISoj 5QyZhasKmLb+q8gok2vrtFDcmLX+RiSqTY8Kd4PbOHJyxNRuRTWTJc4POV8jd4Tppu8v zeBdEoQYOlqLd4CMmrvPvssr05bHtspCgx2t5/HQJNxLjyYbB7/+MVq8DisWwqnxfc7O hiyInBsoplULinCVsgbnSu1JWMGf/qrMY9i/u9F/FwSkFir5zCG6a8L12pA1S92mvOHm DHpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KELedhSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id f22-20020a056a00229600b006bd0842622asi13116522pfe.239.2023.11.08.03.16.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 03:16:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KELedhSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2907080984A0; Wed, 8 Nov 2023 03:16:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344389AbjKHLP6 (ORCPT + 32 others); Wed, 8 Nov 2023 06:15:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234092AbjKHLP4 (ORCPT ); Wed, 8 Nov 2023 06:15:56 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D632119B3 for ; Wed, 8 Nov 2023 03:15:54 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E732C433C8; Wed, 8 Nov 2023 11:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699442154; bh=9vSG7HGCOMlTVvwxD3z5KGQGOs/uBAQpqQz6PsNzUOc=; h=From:To:Cc:Subject:Date:From; b=KELedhSb1ggZIE5lSHcxdyePAcQohLzvKDPj1AfkXtcO+iEvN41Z56Tsiie86P1s6 YXyTaRL/8dV2BNl/ECqEPUvQuXNVv90Oaffelbsp/MMJFDv2TJw2uL4vuXzUCKtnNo 7iSoAGbC73dffDoE7zOD0YFbad5D9uvgackPTs0iUrq/MWEevnRdILKBspDQufTUdN gVFJRNCIJcFtbWtSOOY01/IicBipWofNuij+tzQ46LGKap1imtzYD7SB3+G1hLGfGT WcM3z8ZVg9x9n3CJ42bPf34mShn8O67Ur64PvLG4jvfPoBPBGclczSM35acpyU+owq 9sl7FFTTDWS2w== From: Lorenzo Pieralisi To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Sudeep Holla Subject: [PATCH] firmware: arm_ffa: Fix ffa_notification_info_get() IDs handling Date: Wed, 8 Nov 2023 12:15:49 +0100 Message-Id: <20231108111549.155974-1-lpieralisi@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 08 Nov 2023 03:16:08 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781994322852371859 X-GMAIL-MSGID: 1781994322852371859 To parse the retrieved ID lists appropriately in ffa_notification_info_get() the ids_processed variable should not be pre-incremented - we are dropping an identifier at the beginning of the list. Fix it by using the post-increment operator to increment the number of processed IDs. Fixes: 3522be48d82b ("firmware: arm_ffa: Implement the NOTIFICATION_INFO_GET interface") Signed-off-by: Lorenzo Pieralisi Cc: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 07b72c679247..ccf91a795c3d 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -782,7 +782,7 @@ static void ffa_notification_info_get(void) if (ids_processed >= max_ids - 1) break; - part_id = packed_id_list[++ids_processed]; + part_id = packed_id_list[ids_processed++]; if (!ids_count[list]) { /* Global Notification */ __do_sched_recv_cb(part_id, 0, false); @@ -794,7 +794,7 @@ static void ffa_notification_info_get(void) if (ids_processed >= max_ids - 1) break; - vcpu_id = packed_id_list[++ids_processed]; + vcpu_id = packed_id_list[ids_processed++]; __do_sched_recv_cb(part_id, vcpu_id, true); }