From patchwork Wed Nov 8 10:43:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162930 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825360vqo; Wed, 8 Nov 2023 02:46:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IErApRCaVe09OMLmJjjFUo3wXH38MWjSccO8AGla5u2rjyYfkdBNhHr2jtngxBPsDDyP+18 X-Received: by 2002:a05:6870:12d5:b0:1ea:4dc8:a17 with SMTP id 21-20020a05687012d500b001ea4dc80a17mr1272120oam.28.1699440365780; Wed, 08 Nov 2023 02:46:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440365; cv=none; d=google.com; s=arc-20160816; b=rMqMbD2mDRJSfppSZtUD0EPOIp4e2MrT3byAL+gjP27BsBkpKEm+dNqWporC8q3+5s WJwMYiHtgQ4X4S/FLI1AxAryVBHFfcYbyOINWsrWghu4YYt/I7i/F0tl/wtJYB70wQRm +uydzdhH6OsbjzM4jzsYyb1EVWxhjE71HorO10/B8JUcxmh5FCRW5oNDjtm3Qri2s5K7 5SiMQl1Sy5WysBaYZk/tHs+Gs5E+QwDmRm7Fhs3OhnsA/n4FpWK3+ikh+BVBMSSkkk/8 TWBbhM7XiYgNAl4PoxEgMtL6o2dbzA3BAajIkwyrvpFIw+qT1YdRGVa8HeUK8YhhWhni qAPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yAjfTJh92uvbCJqXeCi670gcjaUuY+h2OqROwS33rLc=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=PVQH0cruTWTUtHNh6PnPgZKadoDA+SMSGH1dY3nAai3CDi4eOEHr7VNBjh0DzFLgsy OEkSmzG5Uc5IEeK+BgiN2uMarUZ5zsa7wSVsM8e5fVdn8157LACUGSmnqvAWbRPoX0XN jNIsjYPG0kgmQ4YDZ3D9X/xCjlK96En7kIAngNlkLOmtyzIlOF7VI25NgxRQ6Rjo/A9U U3wP+yy37X9Ki6q/AxPTWSRN7BfH023BPvg2xTBmRmnG/uhwtYi2xfnLrwQmIv/IJn67 r5o4UIp9jN/0jc3UvSO7F+QzvSF03ynCVEwD7TP+ANEjOLWOolicdKjbqBJskLYKKnWj ammQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hY5KIDh5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id 22-20020a631856000000b005b9b68add85si4172166pgy.254.2023.11.08.02.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:46:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hY5KIDh5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C73558263E9C; Wed, 8 Nov 2023 02:44:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344473AbjKHKoM (ORCPT + 32 others); Wed, 8 Nov 2023 05:44:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344370AbjKHKoC (ORCPT ); Wed, 8 Nov 2023 05:44:02 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CBF41BD4 for ; Wed, 8 Nov 2023 02:44:00 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4083f61322fso48635165e9.1 for ; Wed, 08 Nov 2023 02:44:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440239; x=1700045039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yAjfTJh92uvbCJqXeCi670gcjaUuY+h2OqROwS33rLc=; b=hY5KIDh5hsZxVwhLfTKBUVrVz5npia1F21b068Tw9AAURGCX1u2TucQihDQyEphwKq 6vowusYI3F+q704E+HkI2qSiF/C7Ky6UDmQ3G4BsFMN5YxySiQLixsz2Oa3LMqP0H5tl kDNboMWeFGBl6YPByRE/aNR7U2s6Fsz3SVxb/r7ZRugVlhUHjEcmTynBagwLFvMnjofc 5hFMHeOMRNnbIDcuMMEI4iB/y2DyynOl72Eku3KNTht8vXj36o2akDp49SCYe8jp0kfi 24kG+NIhCsuaVDRZtNI8lo3UQAypL72itK0eqJc0UTpUXEfJPLTKsTH9/dIC0uYlMDmX DPTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440239; x=1700045039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yAjfTJh92uvbCJqXeCi670gcjaUuY+h2OqROwS33rLc=; b=g/NCvmxZ1WRtfoSOH3/NmxWRORgu7GHZ1+nx9W7Pv0GSWcUxBPmMJ/0UF4EY6tmDex WzZsttohfmgUemQ30AIapxxizigkRUsq02tt1vFi9jfKCkauVh6KP0BFh1I4gnQr6W+t IXYqvv43kIL068lP79G0wsqc9oBkW4QEHbkwFGKUuEqIWz02uiaRRiV8GPPVKXhDgKx/ DcG7+HaubNJ7ZZC+y563yDTlYqQfTDNcCgKk+qdlZWp5YLeRJHhI9mQUfsu/0qZaRPlV rDdihvhj/+Y3xSpJswNb3Kpsxicabw766Tus0WHHmAqIuQJSF4EmiLEUeq9lxxwcbAO4 FlDA== X-Gm-Message-State: AOJu0YwSQJtbGZcXgi0dAhBaX2M3Bz6uMtMsrjEW/upCFGN3Ufgf9P7c /pAnzvMWMdOZUBvuyfVK3JtqRA== X-Received: by 2002:a05:600c:3104:b0:406:3fda:962c with SMTP id g4-20020a05600c310400b004063fda962cmr1471144wmo.31.1699440238661; Wed, 08 Nov 2023 02:43:58 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:43:58 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 01/17] dt-bindings: hwinfo: samsung,exynos-chipid: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:27 +0100 Message-Id: <20231108104343.24192-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:44:54 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992380891426569 X-GMAIL-MSGID: 1781992380891426569 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../bindings/hwinfo/samsung,exynos-chipid.yaml | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml index 95cbdcb56efe..45f3d468db7c 100644 --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml @@ -11,9 +11,20 @@ maintainers: properties: compatible: - enum: - - samsung,exynos4210-chipid - - samsung,exynos850-chipid + oneOf: + - enum: + - samsung,exynos4210-chipid + - samsung,exynos850-chipid + - items: + - enum: + - samsung,exynos5433-chipid + - samsung,exynos7-chipid + - const: samsung,exynos4210-chipid + - items: + - enum: + - samsung,exynos7885-chipid + - samsung,exynosautov9-chipid + - const: samsung,exynos850-chipid reg: maxItems: 1 From patchwork Wed Nov 8 10:43:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162929 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp824686vqo; Wed, 8 Nov 2023 02:44:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHs7DO12j0IB68vShrVAuTi3vsKwLjtPVYnTVe2zuDKUk0hlxob20patKflbHLyXN1gvH/P X-Received: by 2002:a9d:7c97:0:b0:6d3:2920:a5bf with SMTP id q23-20020a9d7c97000000b006d32920a5bfmr1666704otn.17.1699440261184; Wed, 08 Nov 2023 02:44:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440261; cv=none; d=google.com; s=arc-20160816; b=iKA0ebeoOGX/7X1RjH+cF0Tj/Cz8XinNEdJml7E0iHn8mz4ZyY6Ucv6tM3BssamGKG 2+nn0vBBRnzgQCQNYXfZdBT1Yv+iRG7juZaX/MdaJpxo69+LPOuI3GbH+1qkq9qtvIAG S4MaUkDYstBx0N55yuV+N+VqrqnL8DnVsSAFgM3Nni5nuXbWGMklWZOQLSYbnExFz19r g5tq82QO+TveT7w5xl+VgoJMhFoRAh+3wrY5VoLRvg90gp7nSNec38xx7E5P/ftDCdg2 OY/S+++xzzmNcODAy4n2lOebxVWGd6blnNlrd+cvno+sqg9xHkT3wKJKuLVDwXdubhP0 YRtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1RgzV0IV23WRll6q2E++ToH69k3tzXfaVshdvzq8RwE=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=glm+7wRQeNf0tFw6QiglaBDz6GEp++9HOuAC4cAKdfAJGEVVF9TzicZS0ysNHC8qGy +n5nGxZGNheYOajzicN3LFHQYmDpoxNPqi90hIl0HH2eeTP83tAhE9Wx342J+S7fli0H WFg63FyEO60pTbi2vlUTx51DdUKs6cCLL+Jq8oUMjBrrQTAB9GZSh1dzQSNAF89SVhPn JvbjW41Wdc6inXE4SAfWAKY2BfZg1bwN0lccFaXi0xk3tjF8wAqhCzr+Es6nT3uAbItr sz4rak/nJ7bqZxcLwZwKqU4//Nn3BPzC9FrWcAIMw7Ui6dZjY6WPN7GqxHYy/b07SUoi 4dhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gzxIIeQg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id m17-20020a656a11000000b005bcfc4fffe4si4712997pgu.187.2023.11.08.02.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gzxIIeQg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 67C27832828A; Wed, 8 Nov 2023 02:44:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344412AbjKHKoR (ORCPT + 32 others); Wed, 8 Nov 2023 05:44:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344409AbjKHKoL (ORCPT ); Wed, 8 Nov 2023 05:44:11 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FC111BEE for ; Wed, 8 Nov 2023 02:44:04 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40806e4106dso3791745e9.1 for ; Wed, 08 Nov 2023 02:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440243; x=1700045043; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1RgzV0IV23WRll6q2E++ToH69k3tzXfaVshdvzq8RwE=; b=gzxIIeQg7kmIq+J/1qyYsd7C2Y0mjzTiwTc/iUmljKVSG3mAPxaI0vNNugUzZ1UmNR spAQTZFsp8gAF4B73ad/DFwPjF1XcrSS1cNEz20ht5Wu1+mN4OCsYmJfoyPQXJxA1i3n IypCSAisty5f78tqwBTFKrM9tMUneNSo1ekX4TckvN0Tff2+CvxvFGsRKF21vmXkhneg xCltLXBvdQ5mLSHjPgKRq/czJaUAMvfqb/XkYQ5WVGdIv8RH/7T0obJ+LquApKptyTSF l7IQ5pKKaP5FQzbXO9+76ZKtknu/Zu425iLODdffCCXqdZxnefTofVazXpsYz7P27MV6 HOaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440243; x=1700045043; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1RgzV0IV23WRll6q2E++ToH69k3tzXfaVshdvzq8RwE=; b=gbrON4n3zcbWQdMtj5z8PHRmXEkrbOK9Xxyf4VoUcJeCCtrCRIXLBxtL/V/llhTyGd duXEmk06wJzqR6jjIbd+Hd0HOO98b0dFB2GItUhWIcWW0QujD1B/pJNK1kdB6Y3q1zZh yhBo9voYfGJU8hcHQ6xKORNtQ31vXVIwpBtkW/WjOapqc+Vxn1IMFR+NJHL1+OBxXzv/ tO+6v32Mwv29QwIpStQQaPnZhqFpzsQ5/qo19zDAoPKdjmnZyjULtLBqnARjpBNXe2Ob ZGC0eaFbevlPV4rv46jiA4FJ5KRolX86aEmLtL+vyW25qWWmz3FLQoCmVyC6M9XFZ+NS MI5A== X-Gm-Message-State: AOJu0Yxk5kZlQMGtECeuTPrX0iDVqr6oAvaWpP+TCIlKM3o3qktKuxq3 F0HEvfQCDTAGmq39UJQxLLtneA== X-Received: by 2002:a05:600c:474a:b0:405:3924:3cad with SMTP id w10-20020a05600c474a00b0040539243cadmr1830807wmo.15.1699440242620; Wed, 08 Nov 2023 02:44:02 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:02 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 02/17] dt-bindings: i2c: exynos5: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:28 +0100 Message-Id: <20231108104343.24192-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:44:20 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992271740693554 X-GMAIL-MSGID: 1781992271740693554 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Wolfram Sang Acked-by: Rob Herring --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++++++++- .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml index 3e52a0db6c41..c1f5d2cb7709 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml @@ -25,7 +25,15 @@ properties: - samsung,exynos5250-hsi2c # Exynos5250 and Exynos5420 - samsung,exynos5260-hsi2c # Exynos5260 - samsung,exynos7-hsi2c # Exynos7 - - samsung,exynosautov9-hsi2c # ExynosAutoV9 and Exynos850 + - samsung,exynosautov9-hsi2c + - items: + - enum: + - samsung,exynos5433-hsi2c + - const: samsung,exynos7-hsi2c + - items: + - enum: + - samsung,exynos850-hsi2c + - const: samsung,exynosautov9-hsi2c - const: samsung,exynos5-hsi2c # Exynos5250 and Exynos5420 deprecated: true diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml index a6836904a4f8..5b7ab69546c4 100644 --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml @@ -155,7 +155,7 @@ examples: }; hsi2c_0: i2c@13820000 { - compatible = "samsung,exynosautov9-hsi2c"; + compatible = "samsung,exynos850-hsi2c", "samsung,exynosautov9-hsi2c"; reg = <0x13820000 0xc0>; interrupts = ; #address-cells = <1>; From patchwork Wed Nov 8 10:43:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162931 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825493vqo; Wed, 8 Nov 2023 02:46:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IEJORsc9jdph+H0bECNkwAZvQFkv3ySGhGOHC86Ppc4fPXTmNaL7eiTFzJQvA1Tp7583n9F X-Received: by 2002:a05:6830:1daf:b0:6d3:12be:804d with SMTP id z15-20020a0568301daf00b006d312be804dmr1602449oti.20.1699440389748; Wed, 08 Nov 2023 02:46:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440389; cv=none; d=google.com; s=arc-20160816; b=ll1pf/voY4u3tgqbk+vYgBK7nRem72FHtEkT8XIlJ9Te9aWJ+o0JzUSESEAi35BBQV gqoSfyHDERsis1llaz8LbW92sec/BO+h4vveWTcepJkZ5jOnvAfF1nzGeoS4E/5F/wRK ZKNqcrXQgpCKFMZvLBEibHGZXC/EokR/lLZnnRJt7BuatIZ6HBGDFOMIJZWU8xJc+Zex x2cv5Tq9wyFZfflXutO3K7OiSpo/OOP1i/VkbPFgNCgn9aqa2/ksKJ5VhFWKqZKt3vqO C1j+y1kTDrg4SC3cI61UJRlxP6LIhoREFuyFWS4gwu0Whl/B+JLMVCKQXY9j/nAretes lAig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rrZs4emLFc9OjGPQr8NhVrDcx8agcy43Q5wHxC/jdF8=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=PUsj64zhxhxbz4Y/k6556sVxoswt8w2/5Plha8Vpw2x91V+4mluV8twKylNnxaWHAp /s13HSqzaFmq8zDSaLUFUHgRG0zVgGP1eYStSBMRB10n3S3GmzRbBp6HWWIy4ChLINHy wXFTJ8H7Eypo4eeZcZF4zTwknkpo07zbDcH8Cs36/QCIWz5gYgf+wKHP9lui8/TxXA69 MV83ImkVZvWzUg/4U0s1fTEQhSb+91X/smpAdTvos0UF77IgiT32GpgDk63EjEIPAi/f DungekCRLlEQ8ly4P6/PCjEtr7DT+aA391SkrogzVtJ3n8zduiO/O2jeTfuAU8H3t2wI j7WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EOetgq+E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id w27-20020a63161b000000b005bd85b5a76csi4061320pgl.274.2023.11.08.02.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:46:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EOetgq+E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 58550808AB98; Wed, 8 Nov 2023 02:45:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344541AbjKHKoa (ORCPT + 32 others); Wed, 8 Nov 2023 05:44:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344484AbjKHKoN (ORCPT ); Wed, 8 Nov 2023 05:44:13 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FCC41FCB for ; Wed, 8 Nov 2023 02:44:08 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2c6ef6c1ec2so82458061fa.2 for ; Wed, 08 Nov 2023 02:44:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440246; x=1700045046; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rrZs4emLFc9OjGPQr8NhVrDcx8agcy43Q5wHxC/jdF8=; b=EOetgq+EAIJ05W+ev4Wve0IkHGcFdIgWzLuewJbfEdOGqJjFEFe8kcgNE0SuvRUuaQ dO/nz8qBrD/EzIaTI59GRsQJdwxl5RvMzWrWOpHF4Z78GkC6qPhNXbCvl/D/YVY7Y3IC 8Eibq8xaXG7jcEEz5Ry2H13xyrJC8IjBaxTxbS6+0oS7l15n8Xp92jSMOrmktjluwXRp o/oRde/0wfDPvjSaVmFeDqrxIlb5wtt8SWBJ55/7nDv8DF7YwxXhvuPvo8ItTGdaWPxJ NvJGHqUqwz8unWRDPSNe+2tT6fONv1FsSyN5tVyOnoh13ULf8z1LNIjCObfDuAliGtSI P8zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440246; x=1700045046; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rrZs4emLFc9OjGPQr8NhVrDcx8agcy43Q5wHxC/jdF8=; b=DdF/UaPbFTIVtGsSVhLOHnoptU+E6gIxF0zZQxjl9YueiS7O4c8VOGOOMPWO87HG92 S8pLhNo4LMZQPdAw3FD9NPnf5os135f1+zTmHfR7HrOodqLzpU9jm0G2RKF/gA/nPYu0 gw7aiO/Ot0Dy8JRcFAshLrMgSdZXwCO4+hg/fbAS25vyIaPezQQV5fX0qWlwbZRiWCi+ ehs63hfmwhW2ppC0fVsFyUsw0s3bgpSYGb0pbo4E7TQ40UXD74wRt/0LMKYZ6zRn3Xzg JEjOQTNJQ6UIe3n/3UdBMQvNdnI/0vvGcrY9JOMOzYc6LmcesxpIGfBlfP7oay0tVudh +Z/g== X-Gm-Message-State: AOJu0YxOAOzhARYiDPoSEzm2HfKq5mUp51n1CjTUBz6qGfjrHIiT2bpM Dp6FE7oXZszsafGbPUjbNi+MQw== X-Received: by 2002:a05:651c:19ab:b0:2b6:fa3f:9230 with SMTP id bx43-20020a05651c19ab00b002b6fa3f9230mr1578553ljb.46.1699440246534; Wed, 08 Nov 2023 02:44:06 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:06 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 03/17] dt-bindings: i2c: samsung,s3c2410-i2c: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:29 +0100 Message-Id: <20231108104343.24192-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:45:59 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992406009394496 X-GMAIL-MSGID: 1781992406009394496 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Wolfram Sang Reviewed-by: Linus Walleij Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../bindings/i2c/samsung,s3c2410-i2c.yaml | 22 ++++++++++++------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml index b204e35e4f8d..1303502cf265 100644 --- a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml @@ -11,14 +11,20 @@ maintainers: properties: compatible: - enum: - - samsung,s3c2410-i2c - - samsung,s3c2440-i2c - # For s3c2440-like I2C used inside HDMIPHY block found on several SoCs: - - samsung,s3c2440-hdmiphy-i2c - # For s3c2440-like I2C used as a host to SATA PHY controller on an - # internal bus: - - samsung,exynos5-sata-phy-i2c + oneOf: + - enum: + - samsung,s3c2410-i2c + - samsung,s3c2440-i2c + # For s3c2440-like I2C used inside HDMIPHY block found on several SoCs: + - samsung,s3c2440-hdmiphy-i2c + # For s3c2440-like I2C used as a host to SATA PHY controller on an + # internal bus: + - samsung,exynos5-sata-phy-i2c + - items: + - enum: + - samsung,exynos7885-i2c + - samsung,exynos850-i2c + - const: samsung,s3c2440-i2c '#address-cells': const: 1 From patchwork Wed Nov 8 10:43:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162932 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825830vqo; Wed, 8 Nov 2023 02:47:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IFK9E3dJgc61PM96sl3ku2Co6lUxryamays2zDht9zy24WLHKWEw33sDQvNEvE9vUFmeypq X-Received: by 2002:a05:6e02:2168:b0:359:53a4:b221 with SMTP id s8-20020a056e02216800b0035953a4b221mr1636847ilv.22.1699440438627; Wed, 08 Nov 2023 02:47:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440438; cv=none; d=google.com; s=arc-20160816; b=Gqk0j1OuGeQjfLPvoTHG2j5hm1XGMFSuc1vQwc/0s/ku2SqbOiQlHHDu8AUEy15HcL Nviy7mkJ2LwlYzcDRo3J273ag2bLxeTQ82Ap5DxOvXyfbLZ2PFCeFfjBoIMxr3bynRxx I6+JjJ6v4ry6XDevxTGcIJkVPxxOt3yHny0XhjX7HHmctDaNm/tfqLvhVhr6DBRD1Zjm fOHUUnpX8Z1xPZkTp5Xag8VP2Gsq5WIFOH2NH+VoMxB1QyQi1zrKZLjcI7kBHnE27BA9 RWafGMkIWVLqUlfTXsY3SrajHuBVeTSCmllkcfd55GYojxZD7lfqPHr/arUI9ko2KDMd XG+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XAqMvg09lZkovg+Zu0r4p30xWSnUqCaJm0pKp8M4YOY=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=ViontoLf3xcpFsZgBZY45tTiRwLU9Obf4ylRq4ImzJMTqhoKTmUB+oTp/eDmmu8jB6 BDJGlxy7hvGa3glEL0BxPhWDaqC/eDG9CCCbd3kpEY1UT+0HXqfAfQ37DiFcISA3ffx6 lrl0ktJJ2onmv8ulqPgnywMUFBiQY2VbD2lTOgUMeZIbrUfQQqQADks+FF0azz3QiNJR eRRsT0hSg4trdp02yg/kzBgtfIYVdxGrH1h7JHUGVAVOR+YOLBY6rS7OmkrNlSF/6Qpv i7wXSzG/552i1mSNs2NvhUmdZ8bneoYcDjg7SwoXfIAbx7qHJZxDArPSJ5mcvw0zHK8j 5tFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zvcmuWcd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id f20-20020a656294000000b0055e607f1e99si3958117pgv.882.2023.11.08.02.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:47:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zvcmuWcd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 56F1880A915E; Wed, 8 Nov 2023 02:45:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344506AbjKHKof (ORCPT + 32 others); Wed, 8 Nov 2023 05:44:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344507AbjKHKoO (ORCPT ); Wed, 8 Nov 2023 05:44:14 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2F751BE9 for ; Wed, 8 Nov 2023 02:44:11 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4084de32db5so57279055e9.0 for ; Wed, 08 Nov 2023 02:44:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440250; x=1700045050; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XAqMvg09lZkovg+Zu0r4p30xWSnUqCaJm0pKp8M4YOY=; b=zvcmuWcd0sa/D/sHSiwIDHuZap1L5e0XOksAP8VqOUKNDOrEhMaOQ20DOc+VkG4pYo Sf9kxNuezGAO7krgeyrBM5Rec/kEcA7Aeqbf4KJiH4ScLnhFT28BBT+6970pkcIkuyju FvNoV3pIcVxx9pmMSmD2+yoB6dT+GryPm1M0ph9CbSVGSJoZx8hWjB3hZwo/rQTUBnWV N2jK8AWQOHh2z4DiWb+lXSuzb7RTmu8d1+BHoeEJxL2WFwZAL2xU439e51BcKtbrmNKz edvIx8/TlDrTOSXDmPx3P4x1pQewGeGCgeHuwKFBm/pvIo+FIR1ByI7n7ZypyR3WxLBm RScA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440250; x=1700045050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XAqMvg09lZkovg+Zu0r4p30xWSnUqCaJm0pKp8M4YOY=; b=vAYKCR65fZiWFY2gR+BE9TAvJhH0WPk3WTELqJQDB8hQB2KCQqysxz+p7ol5sMJWl0 rbGgstRJrIiWhColOrHA5aSL+TG4j2bIjHVgxXgVy5rvpHzx+sjN22KSwdjPxkO69ONb DUI6MPdJFuBkwt6fV7tw9yoIagkk+94gvNpq/v2VncUeDY8/WWLwCdCFtdOUT242VI4v Wwh+crVoikt2C3Q/r88nkFXsEV1viJYbMfxO/Iy4lAkwQLg7f0jVl4k9V0YQnAxhqRFS MR20EjwEqibQaGdVq+hAALsf+muNyTjjXyxqlueAWylhX7DadoJQeg6riP3TqoouT+0I gWKQ== X-Gm-Message-State: AOJu0Yy8ozD3vQ0mnei/eDX2Rd2R7UCA9phJSO5aWr8XF7/WeDUPqcin XHxphLatlPQahJsadnACtoaKGg== X-Received: by 2002:a05:600c:a49:b0:409:5d7d:b26d with SMTP id c9-20020a05600c0a4900b004095d7db26dmr1253167wmq.15.1699440250466; Wed, 08 Nov 2023 02:44:10 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:09 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 04/17] dt-bindings: mmc: samsung,exynos-dw-mshc: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:30 +0100 Message-Id: <20231108104343.24192-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:45:41 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992457075173410 X-GMAIL-MSGID: 1781992457075173410 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. While re-indenting the first enum, put also axis,artpec8-dw-mshc in alphabetical order. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring Reviewed-by: Alim Akhtar Acked-by: Ulf Hansson --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../bindings/mmc/samsung,exynos-dw-mshc.yaml | 25 ++++++++++++------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml index 6ee78a38bd74..5fe65795f796 100644 --- a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml +++ b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml @@ -14,15 +14,22 @@ maintainers: properties: compatible: - enum: - - samsung,exynos4210-dw-mshc - - samsung,exynos4412-dw-mshc - - samsung,exynos5250-dw-mshc - - samsung,exynos5420-dw-mshc - - samsung,exynos5420-dw-mshc-smu - - samsung,exynos7-dw-mshc - - samsung,exynos7-dw-mshc-smu - - axis,artpec8-dw-mshc + oneOf: + - enum: + - axis,artpec8-dw-mshc + - samsung,exynos4210-dw-mshc + - samsung,exynos4412-dw-mshc + - samsung,exynos5250-dw-mshc + - samsung,exynos5420-dw-mshc + - samsung,exynos5420-dw-mshc-smu + - samsung,exynos7-dw-mshc + - samsung,exynos7-dw-mshc-smu + - items: + - enum: + - samsung,exynos5433-dw-mshc-smu + - samsung,exynos7885-dw-mshc-smu + - samsung,exynos850-dw-mshc-smu + - const: samsung,exynos7-dw-mshc-smu reg: maxItems: 1 From patchwork Wed Nov 8 10:43:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162934 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825846vqo; Wed, 8 Nov 2023 02:47:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbpHmj5X7rfBDgcNwmHXwm7TT1H7F84m7zzXmog6ibIaf+tojplTGTAbV+hT7cmEUcIqHK X-Received: by 2002:a05:6a00:2d99:b0:690:c75e:25c8 with SMTP id fb25-20020a056a002d9900b00690c75e25c8mr1358525pfb.7.1699440439837; Wed, 08 Nov 2023 02:47:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440439; cv=none; d=google.com; s=arc-20160816; b=jucnS2zIqjxoOEBw0RS5RPvzPlxQ8JK1kUiSFnLN3jw/PjDUVlvg3n8wDlZTNZZIwC 0lung4mjkwgmxeE5foanP3xlJ8ZGC0EzrjiWTlRi8T1znQwScVjwC5YS7P9Xh/o6K/xI 6MMppaHdzY+mZ6p4y6Bf4HN2L07JCA+MuWMR8Dp46xf7kzTAwuSk2FH+vvh8d6EjkG1Z 5n+eT9vtdixtjSSQG+h2rujQQtUBPF/yOmk/k4lyPFt1DtZ9TK9NOGaNQy1Hia+nnW2c s4kqn2OZt9REwBb7iVRDgunc4AoRjgB+k/81NuHR30aNoek5q42xNPbcJspD51MyPkMw 2/ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jaIBx0Az35AgmK0hmQ6KD07E3PCcuw+SeUDmsLqHS7Q=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=A9nH+UPMDhm/ktaFJxmbDJ710hrOupzYTBUx9QvAJmM7I2lCTBJ5LsE7dhyI2exTSz je637XeYG8V3v/hi8u4LI+hFyvgd7uYJ+ZtmazzUrF0ArrQCphfa+ISrVZ6ysUI6xDso Uc69Ppz99Cm9FAc94q0t2CyorsnXFvShSUS2ioyAUCxItniMIGM3emBovIynOlA5Q9fP zS6/HjxqARmyB46Ko/xdHphy0Kjk7Iuezv43AdwFEy9KjoLxXWvBQDTV4IQwwqAEV8Ri gtIQ4sf28noe1B67SL2FrE/RaCB5SPM03MXOHlewfv8+/3RicwTuPRkKibkSEVe9cNHz Ycjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C86cKyLV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id by11-20020a056a00400b00b006c346de97b0si12930819pfb.336.2023.11.08.02.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:47:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C86cKyLV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id E1DD480F6490; Wed, 8 Nov 2023 02:45:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235670AbjKHKoy (ORCPT + 32 others); Wed, 8 Nov 2023 05:44:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344488AbjKHKo3 (ORCPT ); Wed, 8 Nov 2023 05:44:29 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE9401FD8 for ; Wed, 8 Nov 2023 02:44:15 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40837ebba42so42240205e9.0 for ; Wed, 08 Nov 2023 02:44:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440254; x=1700045054; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jaIBx0Az35AgmK0hmQ6KD07E3PCcuw+SeUDmsLqHS7Q=; b=C86cKyLVHMSNiuARVDdTsIhu1bikbR/K1axeSIn64CBcsOV6oZ9hWoWYAsdIiPpkS+ Z0DLTluUmrh1z+pMUaBkjq7hyFpay3hOY0VPQ/18fdo325HM9C2w9Gwy7HSKLt4m4pTo qF2nZ7uzCWxOMQ2biHutk5630xWet8r9pfJbIxQu+bpsqt4o5f9HmoKh7rlJLqVzRDuC NeITvbCKWryfQwiptv3HSRi7QBxdfpqSqzFuLCUKdAUCnY0TP/EPL89G8f41PpP6GVKo khymXT1hegSPib2gx0eij2q5kBEyKssjAKQeuJvGUD+yNNy26SL74sCuizOzeMtOdkPV NCtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440254; x=1700045054; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jaIBx0Az35AgmK0hmQ6KD07E3PCcuw+SeUDmsLqHS7Q=; b=TNIiUlj3VZHSC7kPXY0+WTr8MEwsj5B1rixLayHN+lVvERGyPXETfyWZtqaCiFQ1tB omtv/5Yc1c37J4BDbdFRW3O8TNAJjelIpzReUEFMNdoogk8EH5tRQty2D1wB57sXEp26 rv90i9/oUmSd+cVFmIidxePgAiPVY3kVWyKbdWfNczSyQ48VO+xuEovyFg4XlO3CEypO MdR/4QWcG2dQNL+6JuoK0wZFCwM35ihe5Nuk1s6ItAxD3E2zHNP+0HJDxGIeQygnZ7QX YrqAkkNvMY7xHUqThCiiXdjzxPJJq7FBDOSgEKtwn7OuwdUCQMWbvH4o9mxYl1RcxIvG gmOA== X-Gm-Message-State: AOJu0YypzG+jhhaqtFR2mcFsL9fyA8ULmHyLQBWVeV1BNwPPe0YYhLwl GDuvmQKhYE8BUA86dKU/8se7Rw== X-Received: by 2002:a05:600c:4f11:b0:406:5344:4212 with SMTP id l17-20020a05600c4f1100b0040653444212mr1447121wmq.41.1699440254278; Wed, 08 Nov 2023 02:44:14 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:13 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 05/17] dt-bindings: pinctrl: samsung: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:31 +0100 Message-Id: <20231108104343.24192-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:45:56 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992459124322646 X-GMAIL-MSGID: 1781992459124322646 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring Reviewed-by: Alim Akhtar Reviewed-by: Linus Walleij --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../samsung,pinctrl-wakeup-interrupt.yaml | 24 ++++++++++++------- .../bindings/pinctrl/samsung,pinctrl.yaml | 3 ++- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml index 1de91a51234d..1c07af24d6cf 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml @@ -28,15 +28,21 @@ description: | properties: compatible: - enum: - - samsung,s3c2410-wakeup-eint - - samsung,s3c2412-wakeup-eint - - samsung,s3c64xx-wakeup-eint - - samsung,s5pv210-wakeup-eint - - samsung,exynos4210-wakeup-eint - - samsung,exynos7-wakeup-eint - - samsung,exynos850-wakeup-eint - - samsung,exynosautov9-wakeup-eint + oneOf: + - enum: + - samsung,s3c2410-wakeup-eint + - samsung,s3c2412-wakeup-eint + - samsung,s3c64xx-wakeup-eint + - samsung,s5pv210-wakeup-eint + - samsung,exynos4210-wakeup-eint + - samsung,exynos7-wakeup-eint + - samsung,exynos850-wakeup-eint + - samsung,exynosautov9-wakeup-eint + - items: + - enum: + - samsung,exynos5433-wakeup-eint + - samsung,exynos7885-wakeup-eint + - const: samsung,exynos7-wakeup-eint interrupts: description: diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml index 26614621774a..7509dc36af93 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml @@ -313,7 +313,8 @@ examples: pinctrl-0 = <&initial_alive>; wakeup-interrupt-controller { - compatible = "samsung,exynos7-wakeup-eint"; + compatible = "samsung,exynos5433-wakeup-eint", + "samsung,exynos7-wakeup-eint"; interrupts = ; }; From patchwork Wed Nov 8 10:43:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162940 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp826414vqo; Wed, 8 Nov 2023 02:48:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5EoWCoqZ465Tk+9NlnSqcr2ZQgm07wKlttWGg9rb0w1Qb2VaKWQ2FjKH3cJKO1wqjor7m X-Received: by 2002:a17:902:e751:b0:1cc:630d:8a5e with SMTP id p17-20020a170902e75100b001cc630d8a5emr1990498plf.48.1699440501716; Wed, 08 Nov 2023 02:48:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440501; cv=none; d=google.com; s=arc-20160816; b=s5blBcT1X7c+oQrnLwclssixNse6ETOhDhWzCSPmXt0rbNLY0GHz0KnwaygQ5wpOED 6kv6bm+Y3vNyPm4VZrZ2qkJPY8ZbbwxuFHidahSAQS6RreCeD//8cRQZH6q9isHdjB88 v2CgcC47Qb65DfdLtlx4uSQItZMhOYf3lat8oizXe8j8uLBBO1xPwW0OSfEPJd36irEk b+Wat7y7qwIsNs+t59ZxmP2lIEdUwD8nppg1s7/n3hRHIMYuv4K/c4uCOctc4+q6FHqy 508Il0NXZHiFQrpofOlQi+9/Pi2xd/mQDG7cc1XFzXvDPikMjMqzt69pWf57mefadxls y7kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TGrUPXldQQyi7i1y6HTuSgGxtg81Z3Wiq2G+ebaMhpQ=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=nWuKUj3xI9QdlwDypnKHYvO7y2q6rHjdgzH9VhDD5TRSYqw7FWYg8eL1SdhUY+EFPT W8M6+wq+G0MQz8pZIzZ1r3pgSbo6AHNWwxX9v+++reRQZtciyp5ZBNf7B0/du9iqkJEU XluY1FOaEO/3b90ik0lJk0ap6pxc6Uffexs6pDQwnViTsykzdAqxxxRR95ynU5Fp5elN 1dQexwuOVgGlFvM87VpMAzySpyZva52bktp2cTfP/TVrWjC7JKDw49BGFnRCVcEI+3me /jC6FER+SzHd4dSppOrgV5i7f7kSB6aDL32Bo7kih7aJPxpp5BC7MXN2O0pM5UerhMHh pmvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RRyZ2Dsu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id c17-20020a170902d49100b001c5cf1c30cfsi2042827plg.435.2023.11.08.02.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:48:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RRyZ2Dsu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id F015680698DE; Wed, 8 Nov 2023 02:47:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344404AbjKHKpI (ORCPT + 32 others); Wed, 8 Nov 2023 05:45:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344584AbjKHKoo (ORCPT ); Wed, 8 Nov 2023 05:44:44 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E421D1FF5 for ; Wed, 8 Nov 2023 02:44:19 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40859c466efso48582375e9.3 for ; Wed, 08 Nov 2023 02:44:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440258; x=1700045058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TGrUPXldQQyi7i1y6HTuSgGxtg81Z3Wiq2G+ebaMhpQ=; b=RRyZ2DsumWDob59sxIhP4NZ0+PB9uqb9zZOUEOANQYdG++ZFy2VRMKtljHlKQz2N/b FWyNXAM90moRZUT9eT6+Uv5TbS7CPe9q7c3KOcLjxxzOBrfyWbaAqMDtmXsDpoRHWolZ nNHIs3XfkQeqER0jUAusgARPrNPvSZ/cIxQT0M4y9KHtLyq8xxD2j4XSRCPRHVhLgkDT fUZhaESpUcxCaH3amqo7JEmuqdlsvW/u71otvwXtUgpq/xDNfHn69aF7IovJ39IZgWy+ /UUa+J1L1aoAxKISj9Ttf0SEkrQTTFoRgxfETPWH1CVy5Tys9WnF6BKIBEH3NY2qfdRo IwiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440258; x=1700045058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TGrUPXldQQyi7i1y6HTuSgGxtg81Z3Wiq2G+ebaMhpQ=; b=xDg1v/VUYAil3Vz4dNf8e6+0Zg8nGH3WqAq1GszqPiHu2L8mHg86xxD5aL+TeCkXfL a5TSeCvGJRWdtR6qRLXKqqTEGOzSm4HDuZYVovmw9ABM21buo67V5J8qImiklnjdCu9g oBeIWz37Q4HV+y2lgMiwZsrgOqUOo7kCbP223pvgxVr/Tko/UTjQ+YbxtSvPZy4iCrAZ TnflBJxPu7EFUrg89mEx6To5WZREy5SRk9qMsa9kUM/e7j+VjVSNtL2rXTrGytPMQ0Od YCt/xa5wfhoCeBHEk9VYQ42MCf+7F2PpmKf3uGDCRgEsSFHm/T55s35jNngU32267oEz uB0Q== X-Gm-Message-State: AOJu0YwhOgk0SQb2WSES53krwRtLV1SJ6KfuQwWI5zp+s27PUAf2MyGX hY3svpEe1u3/heSoDFMy8eXBVw== X-Received: by 2002:a05:600c:3553:b0:406:c6de:2bea with SMTP id i19-20020a05600c355300b00406c6de2beamr1367091wmq.17.1699440257975; Wed, 08 Nov 2023 02:44:17 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:17 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 06/17] dt-bindings: rtc: s3c-rtc: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:32 +0100 Message-Id: <20231108104343.24192-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:47:56 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992523337435117 X-GMAIL-MSGID: 1781992523337435117 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Alexandre Belloni Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml index d51b236939bf..bf4e11d6dffb 100644 --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml @@ -17,6 +17,11 @@ properties: - samsung,s3c2416-rtc - samsung,s3c2443-rtc - samsung,s3c6410-rtc + - items: + - enum: + - samsung,exynos7-rtc + - samsung,exynos850-rtc + - const: samsung,s3c6410-rtc - const: samsung,exynos3250-rtc deprecated: true From patchwork Wed Nov 8 10:43:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162935 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825852vqo; Wed, 8 Nov 2023 02:47:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2b4rZd86hcAdOsk9kuC/cFRGQcy/knk8MV0nCHyVk4t3PXd5uoiiGd0TqBT86bH9X4ucE X-Received: by 2002:a17:902:e890:b0:1cc:5c49:6af8 with SMTP id w16-20020a170902e89000b001cc5c496af8mr2469579plg.25.1699440440762; Wed, 08 Nov 2023 02:47:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440440; cv=none; d=google.com; s=arc-20160816; b=Qrq35zbX45nrvJwcRwDtGgKjMKRpbmf1AmuIYqlCjpA4qgWrTXHTeKr5J3P6m/XSLf EB+khsNvQXRGSmpP40K9K+Md7hM2ysUyyuTZqsnaEdOwXX9ZwqL1fYIQN3XPG5d/bHPY IjHPw+YLjFI9xct+dEUByQyRaPSGYoSCNyhZ2o/sncMHKbbgqw5B26Fgz2wfvXs9e495 ue1AirJeA8tOtZ4uyDSL+Cacsajw3LgnhkZRUvF9vT+9uRlSlyWo+Tkbdjsrp4H7ebt2 f7KpGPWCcPN4mrqn3gMu7bXJARzqaW3XspzILTBvrqkpMlv+0YkA2IS/XFSj/V++9pwm coQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=932+POzuiCpVd1FMO8emES7304xq1CZHsFhbsNym7D8=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=l2kFF9e+m7K3XzV8UtjAtR5GyRKBGkmVLZwdKmh/B+8v2y2v+ppHxC3GIeiAEzaukI EUze3wNn2OqbMfv2n9zu4hG22TbpaqU90oexYpw3KDX39oL0OzqCTbJ58xW1oJ4aLCSJ +t2EjA2b5y8CVPg8f/KODc4JFtCTkCywKIbtKT0RS9tmQpraPB+hwyPqkvKVL0ETFBCU 0O81sYgJGRlJRYIIdczzTJHl6qq1p+vaHDtWXBw3i0x/15fXTSDhK73GsfBbOYAKCM6h 52QSDSCnTuaJ7SXgAvyfizkL+2LdQcqehHYYvi6MTUT0juZjh4DFgW2W+gHB70hFIQFB M5jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EhaNtd0b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id j18-20020a170902da9200b001c88e81a54asi2109215plx.325.2023.11.08.02.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:47:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EhaNtd0b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 0C42E80278E2; Wed, 8 Nov 2023 02:46:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344629AbjKHKpY (ORCPT + 32 others); Wed, 8 Nov 2023 05:45:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235597AbjKHKow (ORCPT ); Wed, 8 Nov 2023 05:44:52 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AD4B2128 for ; Wed, 8 Nov 2023 02:44:23 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c501bd6ff1so94533631fa.3 for ; Wed, 08 Nov 2023 02:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440262; x=1700045062; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=932+POzuiCpVd1FMO8emES7304xq1CZHsFhbsNym7D8=; b=EhaNtd0bfrAm6px/3RYUsAwCR4nSvu+SAtQY7zQxmXwMSDX3RxmwPOJxfDWG+rHUtq ZR0WGiK5hakg8RqL7b1HXhHvryvlQrjQMmdE7HM9F3hx4jjJpMHfuuD7wbjN4OxPv1JW VBxOYeByEVZOUu+DLYfGVEwqXx/Wvx9rEo1SEXNC3xQUlGZfnwfWhI0AsoZJUraZrt0Q Q3zTvDhpnSP9qeC27LQ7+8HgM+LBMMjoDpLH7xCbf7x6+NZmboPp5VC6ilUHP7VDlr9h bFTWvu7Jh07B5vQBaZ5YrDrLU3OX2QfVKO/K0jOm+uMx3qscz7WuCgoFRGyqWsR/oNyf K6lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440262; x=1700045062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=932+POzuiCpVd1FMO8emES7304xq1CZHsFhbsNym7D8=; b=Nkne3UWY7I/2VxLxHeijWBBSXKynUZmwBXW5PJ7Lionl/o6qqKkXGJDogGZyiJrsr0 /GQzCZDD+AgoVtiFv96jDJehukyEgXW4SMqTpkTYWg2aqAu/HPGHtsAMZS7M50VPDsfz aoL+LD11FnCVq3C25+CIogNy8uZgACiRn88w3gPheeEN2R6JNocFxSzmjjsk8nCjLtV9 bU0JD37Wrh0nUmaKnXu25P0py97hGuET23kW233xmylWEOUSYJxob1eQcPHkiuHyxHWO DOcapQws9OERUYx+j+uHVKp222oMnf3cIlaDT7GxTXbJKehm2pXYs6h5kwU9F1GgxZRS BRkg== X-Gm-Message-State: AOJu0Yx+at0Fuc3Cswa5q8gVqzxm4dP3tnF7ADNk75wDCGvZ7qu+I4JI dRX73V8BdnyE78DLhHoY0eWNxw== X-Received: by 2002:a05:651c:504:b0:2c5:14e3:f1b8 with SMTP id o4-20020a05651c050400b002c514e3f1b8mr1507701ljp.7.1699440261813; Wed, 08 Nov 2023 02:44:21 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:21 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 07/17] dt-bindings: serial: samsung: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:33 +0100 Message-Id: <20231108104343.24192-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:46:12 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992459168940197 X-GMAIL-MSGID: 1781992459168940197 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Re-shuffle also the entries in compatibles, so the one-compatible-enum is the first. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../devicetree/bindings/serial/samsung_uart.yaml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml index ac60ab1e35e3..0d0215b23ab7 100644 --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml @@ -18,9 +18,6 @@ description: |+ properties: compatible: oneOf: - - items: - - const: samsung,exynosautov9-uart - - const: samsung,exynos850-uart - enum: - apple,s5l-uart - axis,artpec8-uart @@ -29,6 +26,17 @@ properties: - samsung,exynos4210-uart - samsung,exynos5433-uart - samsung,exynos850-uart + - items: + - enum: + - samsung,exynos7-uart + - const: samsung,exynos4210-uart + - items: + - enum: + - samsung,exynos7885-uart + - const: samsung,exynos5433-uart + - items: + - const: samsung,exynosautov9-uart + - const: samsung,exynos850-uart reg: maxItems: 1 From patchwork Wed Nov 8 10:43:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162933 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825833vqo; Wed, 8 Nov 2023 02:47:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyo0Yu+DlgipxCAYUia9Wxt7RRHEKY1MdL/gs3SHCPFpwBM7v+0E13l00rZim7z9AwIWQ3 X-Received: by 2002:a17:90b:4f82:b0:281:b6e:22cd with SMTP id qe2-20020a17090b4f8200b002810b6e22cdmr1195655pjb.20.1699440438996; Wed, 08 Nov 2023 02:47:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440438; cv=none; d=google.com; s=arc-20160816; b=ZijVOThfx0Puhci2g4WG6jK3L+UxsFN8omjZU2UnEZ45QuUSj8bivJXgZQvOg6c67E ZvllOy1YQYJ7RfD1djMI/cwbvFxdSJ9dnKLlkdWm/h8ShBMjWpSlIxOVDQOwVTy0dWLE FG6MDIpvOZ0qjAAJccLcQWNntf8oJPBqheHd5wWfetWYq1TQc9jumbf8InsQLWSaZUV9 sIqwqFsUlp+za7ZvZ7u/WX87h9xfb7U100q7Xv0Wy01xtsSTkM0pL4W+GGo7P1kAbf9/ SJ9M50/JU7wtmM0QPDu/RV0muBIgvhCAU5e9ipNEDyYmwYZVONKyUvOVa4P0bFhCLtug SICQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PV5diolHzkDYNZO8WufyA3F1OzLH/Kn/j0r7E3RxmpI=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=SsSTdSQwez0TZISNd0kDTg3psL2wlzPyYAZnnCb7lWs1fFaNeECmY/nmrIO0WTDjos Wh1yabz3eAd4kk5K1GhHvzILx1nIdEfpBYQIHlBAvZWN8b4s14WbX1Xi3S5BndIqtkVj lf+R/vvmJuLHWxo6+dIGuOgK+qbT+CF3Pn/SdPLDwIIrrn7LAnA8eu1xDjSX3UHWVgh7 F/U7TbBBVr58kL/blGtqr4WqS1U8t5C7j1Y0VNIeCVzsGcShuwUIaXVy3HTMzHi8wIcU UNlXBvHp90mA+WhfDm9t9CPdzvC1o6kwfr2LxTJLYui250GeFe/FL9+vwGoyI1uMgFF8 xfMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="q/fFqIm1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id x12-20020a17090a8a8c00b002810ae70420si1928320pjn.121.2023.11.08.02.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:47:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="q/fFqIm1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id E77A88024616; Wed, 8 Nov 2023 02:46:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344668AbjKHKpk (ORCPT + 32 others); Wed, 8 Nov 2023 05:45:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344457AbjKHKpE (ORCPT ); Wed, 8 Nov 2023 05:45:04 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F35B2590 for ; Wed, 8 Nov 2023 02:44:27 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4084de32db5so57281325e9.0 for ; Wed, 08 Nov 2023 02:44:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440265; x=1700045065; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PV5diolHzkDYNZO8WufyA3F1OzLH/Kn/j0r7E3RxmpI=; b=q/fFqIm1pNWVw9RWz0hbxrB8zEjHFyWAKjlSgQkEKbcncTumbpZOBQQjgsLCqeB9c2 TYScirxbqaQUEk4FyO/Ks0dAaRAy5TzlbXdoDJ6IVa331XbRyxRhp1Ovm+r+FMq1G9Ij zf5nwCYKSu+EZmS+Rs2A56cUEvdpopnia26x/aEuSm8Pn0rFXM0GhRyR1JwR4DEOl5g1 elzgD1tNrCv99tR7Y1/YCOAOSO/0h9PrS6g25YzPImrF2kvQQ9XDXuVWrdb0s5+PvSHf 7kNC+eNgqcm8ctHaQ64i5dbvCyYRsi92XdRVJN5zfjoEPYQnjyOS0wTZ2Sn3n40Rd0AQ MvOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440265; x=1700045065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PV5diolHzkDYNZO8WufyA3F1OzLH/Kn/j0r7E3RxmpI=; b=l2HvgmLYR0xQTLMjMjLI8ZFuuqD/2uMb0pfKqHF4PlfTac8t4amd48+v6gvDpIlatU u8d/L+d0MvlK9bLAiH28cHqYcIR2z+ynBs37agI0JivXRPhG3wihNbAcCtMLzogWSj9M ERk9cxl2EOJ8Cj2jMGFN11eX/kU4w+kkkYQL7NFn5g21+9BYynKpQzctPOISEHvM27eU xm25GXz4HSs8zN7JVUOEd/ho9HlJL9Adtu31Zu5HGQ6nh0zjza82sv0+XkRAeTtDBW/H mBLfzWZit8kQmMAnHgluRBXbXAUbxNc4CseBz/V8SdfoCVyE0jAhKvBYteyGfkiGMEC3 3tdQ== X-Gm-Message-State: AOJu0YykbNf61oQTvb7ANj1HrxS/ww3BYoGYnF0/sD4wcKpYufpOcUSF xa/Wtc190teCGvabmKeyql2o7A== X-Received: by 2002:a05:600c:1f8f:b0:406:81e9:ad0c with SMTP id je15-20020a05600c1f8f00b0040681e9ad0cmr1347385wmb.41.1699440265563; Wed, 08 Nov 2023 02:44:25 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:25 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 08/17] dt-bindings: samsung: exynos-pmu: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:34 +0100 Message-Id: <20231108104343.24192-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:46:04 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992457801621836 X-GMAIL-MSGID: 1781992457801621836 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../devicetree/bindings/soc/samsung/exynos-pmu.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml index e1d716df5dfa..6492e92586d9 100644 --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml @@ -48,6 +48,12 @@ properties: - samsung,exynos850-pmu - samsung-s5pv210-pmu - const: syscon + - items: + - enum: + - samsung,exynos7885-pmu + - samsung,exynosautov9-pmu + - const: samsung,exynos7-pmu + - const: syscon - items: - enum: - samsung,exynos3250-pmu From patchwork Wed Nov 8 10:43:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162945 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp826673vqo; Wed, 8 Nov 2023 02:49:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiXMxo0UiT/c+Fwz3SwpDyEz2qhRJ9Infq+yTW7HIJAYeyYLK82STOzStJ6aRmZkN3hk83 X-Received: by 2002:a9d:6c58:0:b0:6b8:6785:ed0b with SMTP id g24-20020a9d6c58000000b006b86785ed0bmr1616127otq.30.1699440548395; Wed, 08 Nov 2023 02:49:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440548; cv=none; d=google.com; s=arc-20160816; b=lmO9yxg2VfqBgWQ+h9NKnY+eZ80fdtot/xKldjW66i+qGpDMBmk08u5po1kVvPDM2z vu01uBfsNLaZHxYKXyRJqpl34SvT8Df8UnT6YG1cvSqWq1EJAi0zfzeyQDWPS0yaied1 bcvIbYaYOoN67umlUvXISDEvQ75xKfg75ontPSTKpoV5zBPgNxfcnfCPTt9UlEA4TOQA aM0/qpM7vTsLWTPtAbNjbNEjwm5JqZiokEd1aK9VPymXJrWcBKGJplJNi0NTURt8u3Zw pLAxUXN7yBLZA3HWgkpoHpjg1nnIeHUunOa53Tg9ZlDNmLtDa8+HVvwxmUcH3Wco0FPt +C1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KctpUSdWE/54mxPRyNTPmujVIdTxIZHiWXcrFdF3THY=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=bGKzNIFFP02/HpHO3Yz6en2ffzfVlTuTtjoevoQEE3JPszCuGGPNw9eEjzYiH7LJgW 4TeMyBniI6D+7gtB1r19JE4pMZS0nThacb0fxrebs/PgKpW4zskZfUMYZXv8ifNH33ag d1p1txYLaG2LyZGOPz6lkWp48jtKPudnOQJIPhGzLUgk+yFUhfpNu7nRRBOAaOOJra9L vJdzvF+/KnHOnJbPiE9Ivx0h/GCGbBoULJsh3dwcB5f/mit25Bv4/ku1pRQv5+u3seig K2y1ldVldTCOw2A26UkvzU2Axwv8OPx8Nr5nT+5Hyf247cGJN48FDcjTxz4ar5j468rZ f+nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ccDWKSse; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id h19-20020a056a00219300b006b6424d826asi12998515pfi.16.2023.11.08.02.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:49:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ccDWKSse; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 0D842805FD65; Wed, 8 Nov 2023 02:48:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344677AbjKHKpt (ORCPT + 32 others); Wed, 8 Nov 2023 05:45:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344609AbjKHKpI (ORCPT ); Wed, 8 Nov 2023 05:45:08 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D31C81BE9 for ; Wed, 8 Nov 2023 02:44:30 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4079ed65582so49889595e9.1 for ; Wed, 08 Nov 2023 02:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440269; x=1700045069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KctpUSdWE/54mxPRyNTPmujVIdTxIZHiWXcrFdF3THY=; b=ccDWKSsepNdzxAZzpSRff3RpSbOw2z7uL893OeJIi7hJ1ZtgFqkPD1eMgHxVpIxjm4 Noy93WRG3BA7xhDgXSwydj/LTBimwrM9Z5KdMzfKde2gJm+f/8N12qUzUyzoqwxYoTjw 1u3LISa3YXeAvdfRzCwXljWUz5vFttcCMBvWb3db1lx3gIxkS6TDDeEd8W5ycCPxzbRs DmdnHiUd936F1RArK0GGITNyj5tlFLQtEXSf4KWn4mnbJRAFnW3dUfFTs0vz+A0ktqsv h0u69rLe1JhcFsMcgJJVmLZq8aS6j+0Opvf+dkgwFGiIvLPEn9CIePWpZ3+0IHaocrSa 6yog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440269; x=1700045069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KctpUSdWE/54mxPRyNTPmujVIdTxIZHiWXcrFdF3THY=; b=lBrEWr4CowpOE/R8Z4yz99cO3FUi1gaGpYb5wS+eyeTkrW4Q9bx0VZEPUd0K3YUPPS LZXbmWX8L7H1yDicxwptYZo/xAO623yX5eKnNgMNo6fR3cTzRzst3iQZeK7WYxeDscuz kasknw9vwjJkY1+pAE4U5xnGQ0YAwjGI7HKlsqatw7hv1jz6dIeD0xkDDewwoiDre6Mk 2zgqlMqbVb7N+xN8fvdjKmdcMhN9THh86vRCLPZW4UWvWHuumC0Tb5zntkP8DkdimWFS X528nbKP/0WbE6+YLgp20u2B+hPFUSEAPzrFhGY4HOMMx/zHmFIspDn3hc6x1bkRp92a pQZQ== X-Gm-Message-State: AOJu0YxTs9SuIltDw4EfWW9QNEDR6ji4Z66vioAzPQd7anD6gdTyVbs1 vUsBGl7qz6xkQuChOUBC/C6jyw== X-Received: by 2002:a05:600c:1c82:b0:406:53aa:7a5f with SMTP id k2-20020a05600c1c8200b0040653aa7a5fmr1423336wms.10.1699440269098; Wed, 08 Nov 2023 02:44:29 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:28 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 09/17] dt-bindings: gpu: arm,mali-midgard: add specific compatibles for existing Exynos SoC Date: Wed, 8 Nov 2023 11:43:35 +0100 Message-Id: <20231108104343.24192-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:48:53 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992572536884313 X-GMAIL-MSGID: 1781992572536884313 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml index ca02baba5526..0801da33a385 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml @@ -40,6 +40,11 @@ properties: - rockchip,rk3288-mali - samsung,exynos5433-mali - const: arm,mali-t760 + - items: + - enum: + - samsung,exynos7-mali + - const: samsung,exynos5433-mali + - const: arm,mali-t760 - items: - enum: - rockchip,rk3399-mali From patchwork Wed Nov 8 10:43:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162936 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825895vqo; Wed, 8 Nov 2023 02:47:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IER6eK4vgqvvO7xYS6mkCMYQeZx47jaY6h42quYKnFo0m7Q7TqtSdkYVF6vMfKwexrZiMxz X-Received: by 2002:a05:6808:124c:b0:3b2:e2d1:34d2 with SMTP id o12-20020a056808124c00b003b2e2d134d2mr1897875oiv.47.1699440446866; Wed, 08 Nov 2023 02:47:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440446; cv=none; d=google.com; s=arc-20160816; b=gh5+jLfJ2GRbkyB4hbQiH+0NyVJICh3nIwvDkM4VV7AmK3I1iurmd85v6sJe5BKeux 9F5fS6LXRpB2AaqhPHHykXOKDn/ICHTQlRpplhgMHbHb6nxz6grmvG5wqowY7XYXveSD gjFsgJHmMM51xPHB4zBbVD2oMzKYotKptvaXinUo/hhZCFpQw1ZkpgC0WYi/TBVZudB1 5ZXkY//nmMJj8JBXSPQtBuRSvkR3yzOUS9XFsy2fKT7vuBID8vu6mhqfcGNDlqo2IKWs xfV6O+V1r/x2vQ2uGINRq0nxZgT2C3HN77E+CoTeLFWxYJcr9BMru5mwfXp3rK/Fdj60 +S5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tkEvXWcKUOWY7MDhsApmZqSz9A9BrLzom2ZllyUYJqs=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=ZynBhUQ8hUJucTLWoFk3ig4meLEZe8O6wsE/gKKZ68Zv3DC2q+Iz6CNKhucEixeGG4 DFY1OamOCE8x1zvBpGZMU4uBmT2alJAmieGOub+gH3usg/qef1roLBXKuCbq+JusL62e J9rUEc9t1j4GrqCUMcPmSWEHbBm5bvg9v7T8xNg75+oPJ/YNeQD58M1sF1CUC1zwFvao yTIYCYC3Rskj13gchEMCDotoFvEZxUT11TLmveDL0Z+7ZQCbxdlXG+/ZRMkhdV0q1RKt 7eifsSyWS5yT1DMldE9hXjvktybkjWu1kSGmrJR6sA811HdZSgZSWuhnKJCT1TcA7PRo nzVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CmtpJmVl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id bo10-20020a056a02038a00b005b9022ddeaasi4693226pgb.516.2023.11.08.02.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:47:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CmtpJmVl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 53914817C3DB; Wed, 8 Nov 2023 02:46:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344679AbjKHKqB (ORCPT + 32 others); Wed, 8 Nov 2023 05:46:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235664AbjKHKpV (ORCPT ); Wed, 8 Nov 2023 05:45:21 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87FBB25BA for ; Wed, 8 Nov 2023 02:44:34 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4079ed65582so49890135e9.1 for ; Wed, 08 Nov 2023 02:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440273; x=1700045073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tkEvXWcKUOWY7MDhsApmZqSz9A9BrLzom2ZllyUYJqs=; b=CmtpJmVlCM4syMknWUpWHAKoK/hAaKOC7nKz1YdbPATq3QoV5ZniZtdasH9YXba1d3 Oidzw9HrSEldko3wgSnvsglDZmh/S1DyfTYwMI6nJvXs/63+iBbSI8rg3FvcOfqUeaZX JIf1rA84zGmA9G/OwOoboCT/BBFUKfxnqHt6fdux5mtz3yIzNyKcCzlTJZYqPCagBEeF ifRDedM4yOl20AUWk/bM1L28QOVVQMkpfyK+PvASkpWnKTClenEnkZhrwD2P5l7mUpPF QyzRxHYmIKmbwpQopmL1SHTzW84630oij9Enqbkhkb0HVzG+NANHwgLJ26/EkiCBSbMd BfxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440273; x=1700045073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tkEvXWcKUOWY7MDhsApmZqSz9A9BrLzom2ZllyUYJqs=; b=CrVD6y+pZMdzfxz8APBSj7nRmX362yxRSXmksIB+XFdYM9Vy50t9aTfr+LohN/peK0 jtJImlA/M7t8Ng1ruUXB5UmGUVltd3oqQhySkIqUPMnB7V0M0wvirw/UUeHx0aL5FZzK tID8T53UWvwOJLnk53nNQ7gfz8zMbH9/EQCG0rqV0L6vqkMLmcLiB6RuhZ5nIc14XpNe ATWj6AbQde+GsCRuGJh3KPX0mPZE0nTjnRrKjVxf5vF3hRZXZy+MiSLTWi24VH15alys CTg+BC8FJyi6cCetpNHopLyeu5jtA02JvlxB4J58N24J9WHEej3W+TImhOyBroxgMVQL yVvQ== X-Gm-Message-State: AOJu0Yw73DIo1mzp8utr4X3ovUD9HIL0f3aJAX6eBQKjVpTcUlAAxE/0 2tZmwOhIsIAk3Fwyufpjc8BAjA== X-Received: by 2002:a05:600c:4fcd:b0:407:8e85:89ad with SMTP id o13-20020a05600c4fcd00b004078e8589admr1286513wmq.14.1699440272758; Wed, 08 Nov 2023 02:44:32 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:32 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:36 +0100 Message-Id: <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:46:35 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992465937271190 X-GMAIL-MSGID: 1781992465937271190 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring Reviewed-by: Alim Akhtar Acked-by: Jonathan Cameron --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml index 582d0a03b814..4e40f6bed5db 100644 --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml @@ -11,18 +11,23 @@ maintainers: properties: compatible: - enum: - - samsung,exynos-adc-v1 # Exynos5250 - - samsung,exynos-adc-v2 - - samsung,exynos3250-adc - - samsung,exynos4212-adc # Exynos4212 and Exynos4412 - - samsung,exynos7-adc - - samsung,s3c2410-adc - - samsung,s3c2416-adc - - samsung,s3c2440-adc - - samsung,s3c2443-adc - - samsung,s3c6410-adc - - samsung,s5pv210-adc + oneOf: + - enum: + - samsung,exynos-adc-v1 # Exynos5250 + - samsung,exynos-adc-v2 + - samsung,exynos3250-adc + - samsung,exynos4212-adc # Exynos4212 and Exynos4412 + - samsung,exynos7-adc + - samsung,s3c2410-adc + - samsung,s3c2416-adc + - samsung,s3c2440-adc + - samsung,s3c2443-adc + - samsung,s3c6410-adc + - samsung,s5pv210-adc + - items: + - enum: + - samsung,exynos5433-adc + - const: samsung,exynos7-adc reg: maxItems: 1 From patchwork Wed Nov 8 10:43:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162938 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825922vqo; Wed, 8 Nov 2023 02:47:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDbFhlBKD27jdQeih1pvRFYSC/fYGb5No1ypw43fZ+aDjr3N1+du8BjOdbRhxxK8HW1M+N X-Received: by 2002:a17:90b:4a0a:b0:280:2935:af23 with SMTP id kk10-20020a17090b4a0a00b002802935af23mr1398744pjb.5.1699440450355; Wed, 08 Nov 2023 02:47:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440450; cv=none; d=google.com; s=arc-20160816; b=xVLXVcVIswfwiFRCFjr8QLuNL4Y7xrvWdnN37KoykHzds7UkalUEKeEZUZCHpAlare M0cR6JWDVTmYhBs4NYvlNYVHd5wZMOH4Vl5I5DPDfald0uIW1BIUluWzGfzpSw9Z4yEo +p3eiL1/9DGTS9BYMKy08mD4Fsv3gtm/2muyS7Jr4CjUqWBUr4EZ68lncBO3VCtFrqLp rtUn7oI196xRutG0pwGI2wkOozbgUEED9AKdmsjqUB39oZmVVMTCs7djll+6c5gHYw4C FZ0GXhTIN8qmsWkzxNia5yZ4RD79YQuKs19mVYNWsjKCTouC891eSJa9iZg4aBdNdqAv XUiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fGiEI+OsEJo1M0u1Cd6qitBsDMBm2mmYId37rcw3fhE=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=BpV1lG1kwXXnxSJe0s6Pi9v2QhQgJfSNnMwcjO6Ihsmc1MUJkesK8ZNNr0LW026zt4 qkv1/kYYYPtg3wJG1N47scChqHIIm8DbIrgpy2WOcswVaeU8TKlPILuKUnwh+wPP36s7 IeyLvQ8tenz+QpEgSsXbkGN63T5Fd6MSbgn+O0iEZ1qyh3ythGWJAK7YHNNYQDA8NUXM nOTz+f8wBD9kiyuh6qvAXKGoqi418M2ElllRg88sujGgQQmUWdTLkVRcCWbQTyS8HsvT jFuzMCB4iaKqKPfSv7Kfw+lBcq8ZQuTdnOdRe8mpb/epa1cdu0/EbVyIMRj3ckrgrtav zdzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Psapt02Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id o12-20020a17090ac70c00b0027d4f7298e2si1913048pjt.65.2023.11.08.02.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:47:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Psapt02Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id BC5308246E1D; Wed, 8 Nov 2023 02:46:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344707AbjKHKqU (ORCPT + 32 others); Wed, 8 Nov 2023 05:46:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344410AbjKHKpg (ORCPT ); Wed, 8 Nov 2023 05:45:36 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0722269D for ; Wed, 8 Nov 2023 02:44:37 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-32da4ffd7e5so380772f8f.0 for ; Wed, 08 Nov 2023 02:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440276; x=1700045076; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fGiEI+OsEJo1M0u1Cd6qitBsDMBm2mmYId37rcw3fhE=; b=Psapt02ZaVLYsotjjTD3flBAqRFY0KEBdrfcegaOovtOOXrzFO+KY8ERw1j9pOotqA FiqBSylaG1c3YrVAhmtRcDO/jNV3aDi8brvU053zkAUutA6JjFmXbNKOLhmJZdNHF0hp a0uzHxZjXSywAjad6U0RSLJIvuI4FXbiN5OYGVrfnkXGyqTvfOhEhUKZPcUhDxCor82q Vq9L+XnHYKeZwAZeTBnM9oI3wqfLhn/ER/0Cias06jSUMDSJcsdvDWOwJeuRMgr80wDh WH3QP2IkbtlJhcjB8sxFZVSfJbIt2vIcPkPWjtelwWizbj7igEJgYCAxAYKEMgS5ZuKy cXvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440276; x=1700045076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fGiEI+OsEJo1M0u1Cd6qitBsDMBm2mmYId37rcw3fhE=; b=Vajzc3yeZpeN+99Hdqui1J4AKiihcIeImImD6ATQdvfgWkjNt5Oe1Qsh6MEp/qiDfX mV7fBaGV05dcDmNR26DT/nv0qrw2Wvgo2TjdpNwIVQNX4vdbTKl5u3+Gkvm+4MYnKgu0 ijtR+tYPyoI6qdRA7aCxWbr67euqixjH9caxHp6yJRu9xZ7GZfzqmhTClgGjvdPmIgco d/WNtKGPF2cgqeg4meZADEserQx21lajxc63S2QGEq7n4/URrpX6zzDO2pJTfYP6ewGP 7pazhS47U+GPzwU3v0WOMIJhNylNPKdowLohSlOZQ50xc9RgAeZs8z2nHMwU1E6Ivcid 09AQ== X-Gm-Message-State: AOJu0YzB2xvOp4x1UfWbhQlq6Nl/LPVNFET0G7PHrymV3UxbGWl5ItC4 DOTEbzEdZNDDPnyEs+DDUF5RKQ== X-Received: by 2002:adf:fd09:0:b0:32f:7beb:d009 with SMTP id e9-20020adffd09000000b0032f7bebd009mr1610826wrr.17.1699440276267; Wed, 08 Nov 2023 02:44:36 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:35 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:37 +0100 Message-Id: <20231108104343.24192-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:46:51 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992469419320777 X-GMAIL-MSGID: 1781992469419320777 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Mark Brown Acked-by: Lee Jones Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../mfd/samsung,exynos5433-lpass.yaml | 2 +- .../bindings/sound/samsung-i2s.yaml | 19 ++++++++++++------- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml index b97b06848729..f154103f32cc 100644 --- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml @@ -85,7 +85,7 @@ examples: }; i2s@11440000 { - compatible = "samsung,exynos7-i2s"; + compatible = "samsung,exynos5433-i2s", "samsung,exynos7-i2s"; reg = <0x11440000 0x100>; dmas = <&adma 0>, <&adma 2>; dma-names = "tx", "rx"; diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml index 30b3b6e9824b..f45f73b5056d 100644 --- a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml @@ -44,13 +44,18 @@ properties: frequencies supported by Exynos7 I2S and 7.1 channel TDM support for playback and capture TDM (Time division multiplexing) to allow transfer of multiple channel audio data on single data line. - enum: - - samsung,s3c6410-i2s - - samsung,s5pv210-i2s - - samsung,exynos5420-i2s - - samsung,exynos7-i2s - - samsung,exynos7-i2s1 - - tesla,fsd-i2s + oneOf: + - enum: + - samsung,s3c6410-i2s + - samsung,s5pv210-i2s + - samsung,exynos5420-i2s + - samsung,exynos7-i2s + - samsung,exynos7-i2s1 + - tesla,fsd-i2s + - items: + - enum: + - samsung,exynos5433-i2s + - const: samsung,exynos7-i2s '#address-cells': const: 1 From patchwork Wed Nov 8 10:43:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162937 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825899vqo; Wed, 8 Nov 2023 02:47:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGvcYx4sGqKApQ6avwZ1SLafUv2yALgt0EeeXw5ey1B/sG9h+zNSF+jfDu3H5Gk3EWU9Wmd X-Received: by 2002:a17:902:d2c8:b0:1cc:42c0:661c with SMTP id n8-20020a170902d2c800b001cc42c0661cmr1967581plc.19.1699440447391; Wed, 08 Nov 2023 02:47:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440447; cv=none; d=google.com; s=arc-20160816; b=LvVrO/Kt9nq9Krwla1t63Dtnn9ggZXobsAW44hnayZjeu+zxrtOjExxeTQyGExw2Hh JdoNR79lwf+NcwRBogz9JjzRKrk6cjZFv6bmuaEUfMWNH2ZuiBpEjAuRll4Xi6mN1pMv BvSBh9L8mPmMIfVUcDXaNE5TLH+QH5HvI7mpG/ANoKdyDqkIOXgelqWu29iLIAkf58id SZhb1sD+feov8jeGVqtRYU01eXJhJ5SYS8ieBCvYOAbXV7icszUC5m+5Qf45xWdLU5pN HfQzwL33k41QLlta/pcJ68okrC006uiUgUO3IyvGcc4hmmu5fJvNTbyeERlnhJ+51wj2 vwPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eLncO1ADQq/KYbPV1LBS+813XGTk7ajEpj3gEwbCXmE=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=03F3xRiVH18GDXcl/YziYLoDpGgWj6gdaSizv+kdzSJJeOp+7mQRPZ7L4ktqD3I7Y0 0l/zagn0eM5nC5/VyR2zkAabDkMr+2gA0NXo/PPIYfaYqdxuthNaFWrSbsS1i338nuyU DMSKPvikN6sj0TWu9gQo/ZnphyTtd/omlQV+as+cysivH9yLDR6YsTr174VMjTQPsQ5F G3KZRA5+9tSkLrY9evhB3E4KvmQBOKJcsVx5Uy4d1Sa0a+VFmt1x2v72TUtDI6iN7l/E maFXVDVnILdw03LgjGutG5iHW46CT9f4HXW6CVH8dP8YSLhwU7tpvK+WtzMFu4jV9LTK hWKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EiBfrUd2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id i8-20020a17090332c800b001c1e1fe16c7si2144241plr.236.2023.11.08.02.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:47:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EiBfrUd2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 3C52C8301531; Wed, 8 Nov 2023 02:47:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344571AbjKHKqf (ORCPT + 32 others); Wed, 8 Nov 2023 05:46:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344540AbjKHKpq (ORCPT ); Wed, 8 Nov 2023 05:45:46 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93F24270B for ; Wed, 8 Nov 2023 02:44:41 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c50ec238aeso92615661fa.0 for ; Wed, 08 Nov 2023 02:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440279; x=1700045079; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eLncO1ADQq/KYbPV1LBS+813XGTk7ajEpj3gEwbCXmE=; b=EiBfrUd21IZaF6eVcNL0xmIRkJV/sq/4Lk/RDXWk8gxc6LaEnnRaILWx4D6Mh7cDYX +rPBtBlRUyO55Wvf0FMD6MoSbRbOrt0pt2s45bbP/FUB76Rkr8TIr8LvI7MyIyh4sAaq 0NE+K7lYYKEkfkRhO4XlzfVysjV/ycJFX+kFHpfmLfGHzcsPn3jOxPE/G+EOA1m0HuAD smsYSIiVd1pytAVCL4HIjHbDRPSt+lSewvLNear494xDmhYR+RoMXzOgD0oZdVtQ+5Ig W1o22vZWGd0+LsgBtJOjGCo12Ho0UhGNHxGWoPMe90E2PJ4GbErAPlpC4m0veTMsJNXt btMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440279; x=1700045079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLncO1ADQq/KYbPV1LBS+813XGTk7ajEpj3gEwbCXmE=; b=ovSUmK1MJQJuO4ehKaAbPn8PQvz/ywPDzrWK7fjme0SBj6dmUNBeop4qMQiIZyCmJg ZTQqp1EpMw5pMpWWF+qdkJhbu/9b+TQo12FBy3/Zv38FCceEaKp4FMdS/YADSSCip9eI Deb6WgJUZFAW9bdV3mY2/DNrGVq0KwN9CvFyX8UAHxJE8hOoimEhw89Go8nX4sdBbl4d Z/843FwLMdwOYuuEyMQXJH+BEiRJDAiW7ZYhJrOyXbg/EG9/dKBFxXx6v5J8lZcH4WIf vRIOxNpvs5JL0DIGX6HdNUSlx6lbMh8kQ2M5dY6QLlr1uXm2NIYXKzQWcaHtdlDc/KCg KU/g== X-Gm-Message-State: AOJu0Yw+ZVhrEoGltgfYKG8QIby7gQvqS42oWkrWMH8janf7xWmYnN6R LGprb0LSQ9wleKqdlFmEBGxCZw== X-Received: by 2002:a2e:81a:0:b0:2c5:7afd:75a1 with SMTP id 26-20020a2e081a000000b002c57afd75a1mr1229802lji.44.1699440279685; Wed, 08 Nov 2023 02:44:39 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:39 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:38 +0100 Message-Id: <20231108104343.24192-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:47:15 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992466638688715 X-GMAIL-MSGID: 1781992466638688715 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Uwe Kleine-König Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml index 2162f661ed5a..89a3875cb50a 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml @@ -29,6 +29,8 @@ properties: - samsung,exynos4210-pwm # 32-bit, Exynos - items: - enum: + - samsung,exynos5433-pwm + - samsung,exynos7-pwm - samsung,exynosautov9-pwm - const: samsung,exynos4210-pwm From patchwork Wed Nov 8 10:43:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162939 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp826244vqo; Wed, 8 Nov 2023 02:48:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGd99pvqMZXntOJTu2ZsJrx4YPoRoeBrDr6mLQBIcd5KV7EoRwLZ14RlVpTBDhUadAGE79T X-Received: by 2002:a05:6a20:e611:b0:14d:5580:8ff0 with SMTP id my17-20020a056a20e61100b0014d55808ff0mr1395746pzb.25.1699440487081; Wed, 08 Nov 2023 02:48:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440487; cv=none; d=google.com; s=arc-20160816; b=QqixRXV41kMqIBBZFcN65Qa6o4bsukkk7nDLlWs4rEG2ag+vkfwKq8fH+BVTfnDzML MlU7Akeutknkhc7vMdaOioM3w78Xrbh6WNC/5fAPxRxSRkIFOrQNwyoRgZoEciA0rvtf F0nsxWjJJ/2hOsXeqAt0H69fSCIKpg0mXsdljOaxVwDV3nQ0G2f4+7chqEpJ3BiL2/BO qjDTLlBu2OxqzGwjuhBXMTjq/KjykWcZkGUDGmWHsy5HfGKhp3rl/VmwdLt8ME7T5WMM zLNGEvh3EijuhWm44pEcfXcCm9+VHr9oDMzroriXxUUlejyP9Ycas7hY+X3n8G2TuN8t 9l3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7XOwiwLlGWwzo1fcvarNrGntQNCjtIurlLTEmeobqNc=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=fSSSE3POinyj8J2kLAZwZX06VX/tztKNU5cuxf2hESyCQNaZxdwAUCMPnkuNM1w8+v EIJ9p4mjWtDDTPngb13lPKpWgW86z2AtxeXh6ENogatYRV+CWN7/s0kb5Fvqp+Az/Pbc CVIuVcPHeFwsLuSAnfKXk9bhC0wVapVmlFt0rzuqGkGuOfbViEFa0h35G6tC2Pl0WuaA GUL5SMxdGK63Ln0uxyXKnVGaN95aa+jfSeZcR4jeu5pOYUnSgu1ZWHHYXk88ppxK1nzS PWYtNfNvbYjed/oA9ka4frv6OcxYYs6/T6yHsIX0OcEDGz8ejYWEAO5HCHRTHY8CX83d 1k7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lgNZh7eF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id n3-20020a056a0007c300b006bf1f9bb921si11863931pfu.120.2023.11.08.02.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:48:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lgNZh7eF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 13965806AFC6; Wed, 8 Nov 2023 02:47:56 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344643AbjKHKq6 (ORCPT + 32 others); Wed, 8 Nov 2023 05:46:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344593AbjKHKqM (ORCPT ); Wed, 8 Nov 2023 05:46:12 -0500 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 711182D47 for ; Wed, 8 Nov 2023 02:44:45 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c5056059e0so96291511fa.3 for ; Wed, 08 Nov 2023 02:44:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440284; x=1700045084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7XOwiwLlGWwzo1fcvarNrGntQNCjtIurlLTEmeobqNc=; b=lgNZh7eF1oYI+7b9o6FGSGvMUlXLvDONG0cRJ2HEICmIWSoDV+LOKLI7rkoENSlhsq kst2PwV/8A1u7aKY7n/5hmEqzs3auvjdZBaJ3mf81XwYmAnh00/eDmhAxudDjv4CPlf9 Ok6fHo6Xh7GZUK2xJ2yqHrUdJ5+R2bcdQrTETGdYxnHpN3eBxTqSl94zIlRj3Llt2MoM VIKpznou1Mi6hpU8eZEkvqn2Ql3a+pkb8NPxZuxf/eDly41Gioc+sBYX54xoAh8iXAHm UDE/1llaIbUgTgNiq0kABZYw5US87oyvoYhQSPZGUdm/Du1VCbmkEdFsI/Nyv0MGppel 40TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440284; x=1700045084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7XOwiwLlGWwzo1fcvarNrGntQNCjtIurlLTEmeobqNc=; b=YsDrHSBO9jzIC+qaNfeuYW4fTnaNUzrJLAXOCn30Qq23Ruec+NziBKP12x66TmQ6eh UpB0GFuUXBk7qeM1w0FyDfKBh3HTfxDYRMMXUDSOxprwJPWK2MVnqEJUnY4OkfIV6weF iPVfAShs0S12FscjztXh9YONHqSiKC4sAXN9H4cQAFD7lTerfnDjuWgdEMCe1nZjEcJN l4/L9FqfkfY7ne6AJQkigUszgErVdLNP5gMg9mJ9Oj5vYOeSGhAEJO6D7WV7gvWVnGYQ ruIcL3/rUubAy4QqbhNhJIt4lSU+616B5HH+agJVMeHZ2o9XN9RpLLGLeT6QBP46H/jQ aYow== X-Gm-Message-State: AOJu0YwxfBNpUWtIGgGq80yD+AZXakaLFW1p4Utcxja13xYa5ZFxe5Sc +iBspVqIHa+R8yIU6PHIyn2AgA== X-Received: by 2002:a2e:9545:0:b0:2c5:b583:f167 with SMTP id t5-20020a2e9545000000b002c5b583f167mr1212517ljh.34.1699440283774; Wed, 08 Nov 2023 02:44:43 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:43 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 13/17] arm64: dts: exynos5433: add specific compatibles to several blocks Date: Wed, 8 Nov 2023 11:43:39 +0100 Message-Id: <20231108104343.24192-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:47:56 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992508113362744 X-GMAIL-MSGID: 1781992508113362744 Exynos5433 reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to Exynos5433 in front of all old-SoC-like compatibles. This will also help reviews of new code using existing DTS as template. No functional impact on Linux drivers behavior. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 60 ++++++++++++++-------- 1 file changed, 39 insertions(+), 21 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 91ae0462a706..7fbbec04bff0 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -361,7 +361,8 @@ soc: soc@0 { ranges = <0x0 0x0 0x0 0x18000000>; chipid@10000000 { - compatible = "samsung,exynos4210-chipid"; + compatible = "samsung,exynos5433-chipid", + "samsung,exynos4210-chipid"; reg = <0x10000000 0x100>; }; @@ -850,7 +851,8 @@ pinctrl_alive: pinctrl@10580000 { reg = <0x10580000 0x1a20>, <0x11090000 0x100>; wakeup-interrupt-controller { - compatible = "samsung,exynos7-wakeup-eint"; + compatible = "samsung,exynos5433-wakeup-eint", + "samsung,exynos7-wakeup-eint"; interrupts = ; }; }; @@ -1546,7 +1548,7 @@ spi_4: spi@14d00000 { }; adc: adc@14d10000 { - compatible = "samsung,exynos7-adc"; + compatible = "samsung,exynos5433-adc", "samsung,exynos7-adc"; reg = <0x14d10000 0x100>; interrupts = ; clock-names = "adc"; @@ -1556,7 +1558,7 @@ adc: adc@14d10000 { }; i2s1: i2s@14d60000 { - compatible = "samsung,exynos7-i2s"; + compatible = "samsung,exynos5433-i2s", "samsung,exynos7-i2s"; reg = <0x14d60000 0x100>; dmas = <&pdma0 31>, <&pdma0 30>; dma-names = "tx", "rx"; @@ -1571,7 +1573,7 @@ i2s1: i2s@14d60000 { }; pwm: pwm@14dd0000 { - compatible = "samsung,exynos4210-pwm"; + compatible = "samsung,exynos5433-pwm", "samsung,exynos4210-pwm"; reg = <0x14dd0000 0x100>; interrupts = , , @@ -1586,7 +1588,8 @@ pwm: pwm@14dd0000 { }; hsi2c_0: i2c@14e40000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14e40000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1599,7 +1602,8 @@ hsi2c_0: i2c@14e40000 { }; hsi2c_1: i2c@14e50000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14e50000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1612,7 +1616,8 @@ hsi2c_1: i2c@14e50000 { }; hsi2c_2: i2c@14e60000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14e60000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1625,7 +1630,8 @@ hsi2c_2: i2c@14e60000 { }; hsi2c_3: i2c@14e70000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14e70000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1638,7 +1644,8 @@ hsi2c_3: i2c@14e70000 { }; hsi2c_4: i2c@14ec0000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14ec0000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1651,7 +1658,8 @@ hsi2c_4: i2c@14ec0000 { }; hsi2c_5: i2c@14ed0000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14ed0000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1664,7 +1672,8 @@ hsi2c_5: i2c@14ed0000 { }; hsi2c_6: i2c@14ee0000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14ee0000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1677,7 +1686,8 @@ hsi2c_6: i2c@14ee0000 { }; hsi2c_7: i2c@14ef0000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14ef0000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1690,7 +1700,8 @@ hsi2c_7: i2c@14ef0000 { }; hsi2c_8: i2c@14d90000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14d90000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1703,7 +1714,8 @@ hsi2c_8: i2c@14d90000 { }; hsi2c_9: i2c@14da0000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14da0000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1716,7 +1728,8 @@ hsi2c_9: i2c@14da0000 { }; hsi2c_10: i2c@14de0000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14de0000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1729,7 +1742,8 @@ hsi2c_10: i2c@14de0000 { }; hsi2c_11: i2c@14df0000 { - compatible = "samsung,exynos7-hsi2c"; + compatible = "samsung,exynos5433-hsi2c", + "samsung,exynos7-hsi2c"; reg = <0x14df0000 0x1000>; interrupts = ; #address-cells = <1>; @@ -1820,7 +1834,8 @@ usbhost_dwc3: usb@0 { }; mshc_0: mmc@15540000 { - compatible = "samsung,exynos7-dw-mshc-smu"; + compatible = "samsung,exynos5433-dw-mshc-smu", + "samsung,exynos7-dw-mshc-smu"; interrupts = ; #address-cells = <1>; #size-cells = <0>; @@ -1833,7 +1848,8 @@ mshc_0: mmc@15540000 { }; mshc_1: mmc@15550000 { - compatible = "samsung,exynos7-dw-mshc-smu"; + compatible = "samsung,exynos5433-dw-mshc-smu", + "samsung,exynos7-dw-mshc-smu"; interrupts = ; #address-cells = <1>; #size-cells = <0>; @@ -1846,7 +1862,8 @@ mshc_1: mmc@15550000 { }; mshc_2: mmc@15560000 { - compatible = "samsung,exynos7-dw-mshc-smu"; + compatible = "samsung,exynos5433-dw-mshc-smu", + "samsung,exynos7-dw-mshc-smu"; interrupts = ; #address-cells = <1>; #size-cells = <0>; @@ -1897,7 +1914,8 @@ adma: dma-controller@11420000 { }; i2s0: i2s@11440000 { - compatible = "samsung,exynos7-i2s"; + compatible = "samsung,exynos5433-i2s", + "samsung,exynos7-i2s"; reg = <0x11440000 0x100>; dmas = <&adma 0>, <&adma 2>; dma-names = "tx", "rx"; From patchwork Wed Nov 8 10:43:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162944 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp826625vqo; Wed, 8 Nov 2023 02:49:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IGr41onlI0Q74lgE6tJE4ah+1t2ZCTnmBcmnNCEEBocBvurtMEBaWti7BYVkgqnmksXfGf+ X-Received: by 2002:a05:6808:2983:b0:3a8:43d5:878b with SMTP id ex3-20020a056808298300b003a843d5878bmr1488832oib.2.1699440541150; Wed, 08 Nov 2023 02:49:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440541; cv=none; d=google.com; s=arc-20160816; b=sf2wPOiTCCAph3/FijEtKHJ+s5ylLsJnJ5bBh/dzpvSmhtEN9M048ngZkHZuvdTLTV VLKW3F+u9ZzXPS56F1b+GDBt9Ot+DQXEcNWLxyu7GYrQwewda8k9d96KZVfC+uj+2GPi 7vtTk9XEJPYwGZR08bKVLhMX8n3Zrd9bIMVaYHi0VCP6qM6Uq8NLwhPLCYF/H+uY68pP 6di+ADLvqF6EeJ1luwmh3OxnyTPooaitXWE8oBta+TPAbsO+z6YSatZpvVjj623j/lMz Ea/xVgYfmkPbouS45bJITFoRcqvBhA90j5wT+zDMcRcl8pXJFhayj8RG0AqqRDGXF7N3 4Muw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Maq2+L1Y42eLIp6jLOTQKPo6JnaiX6HnytDKQ9hLP3M=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=igd2tiDuHGVCU5sd5T4MfE+Z8pKO3z53vkTIr+nleTzpv1jCYPFaqSQeB3WCTYwJN7 T0mC5CJ+WWJ5rXi13mE9tu7WJXSXv0fyTwbbcqn7iK5XeyZD+rR5ql7sr6PgkhJbeB4T 7nJdty5zRyB7tOWOpoqU5zj3Ch2YZeE3+DMmw0P12bqUszxhVPsEQyNaz8BgX1eMLALQ RVVE5vfJnpKtlIUB3GneGeoJa4U3oeIVfpkzIfNxdZKzCwvRvuGTVfCwSnPEZsgahmtX OOA1tFXP8OiikRrYnIvIdsksp9i5JqMo7ZoN47VcmlNaQB8NNkXG+OSlvSRxW6LZ5vOr QMPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g9XQA9rz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id a13-20020a056a000c8d00b006c35f7d1ecfsi13381395pfv.122.2023.11.08.02.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:49:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g9XQA9rz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 09E0481C50B9; Wed, 8 Nov 2023 02:48:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344422AbjKHKrC (ORCPT + 32 others); Wed, 8 Nov 2023 05:47:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344652AbjKHKqS (ORCPT ); Wed, 8 Nov 2023 05:46:18 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F002E2D50 for ; Wed, 8 Nov 2023 02:44:48 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40839807e82so3849255e9.0 for ; Wed, 08 Nov 2023 02:44:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440287; x=1700045087; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Maq2+L1Y42eLIp6jLOTQKPo6JnaiX6HnytDKQ9hLP3M=; b=g9XQA9rzym40Y/5WeB9duG4RMsqs9UF/7dkpw3q5vzWlYDbrqOKsj9eBBgqYyAFYZi gyR1mPsCVJC1UhOmdpSEBIwUTqGldBj2wlsn25TiVkBvkGsyJbWBI4alYtlRe3N03U8R xD8L9Sl5lRB5gr1m/LNfDOzTvZzoy0ijBYGn9a+al1dxR1xfOGbd+DQVtyBFX4hUd89Q rhOavNd5h0MuYO3vKFNxWyhiF5ubb5a+XMOwcBmzUHmGxlg0cZwOX4gUIw0kHDcGAw4/ N03ZZE9IOmnxtEi6Z4pdVfq3MjBRBO1xwVCmrfUxU/h4lGFfjEYaTS1HxNeIHIUmcOzN Zkuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440287; x=1700045087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Maq2+L1Y42eLIp6jLOTQKPo6JnaiX6HnytDKQ9hLP3M=; b=dfMXdB4zm4PgbQxnjvQCsRy70okpxh4aREtQxFANkqyGSYLC+AB9YX7Qx/diwDLylP /mcYoiAWhcJkLUX2d5QF6TWG+YAnf8X338s5f5JY7/CHwmOxs7bHpp7SIKAlKPmLy9Q3 Bs7hOnPStW2Zm9509ghcfzLI+0OQ6mhC3j0nwmwDiEOvNwarKe2e6+FU8mHDV9hMiaEw PAiWKpLLvSYEB2Yv6XidRb136aHFjkzo/vfXctIkwMsjJsjyOccu113wTCLVeRq/G+dv cSBzITOg329mSqTinSdNski8a0lYFKSOE+9yb+gbcWyNZjJ1alOqa+dyTHawApXXreB+ /I0A== X-Gm-Message-State: AOJu0YwEElgS3o0sqqW86rkpW0FTrgCyu4hS3LuSQdfGx1LqHQfCpN/p Yu5LpFP3N92IjMAQ1ZzAK+p3BA== X-Received: by 2002:a05:600c:4512:b0:406:44fc:65c9 with SMTP id t18-20020a05600c451200b0040644fc65c9mr1775482wmo.8.1699440287419; Wed, 08 Nov 2023 02:44:47 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:46 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 14/17] arm64: dts: exynos7: add specific compatibles to several blocks Date: Wed, 8 Nov 2023 11:43:40 +0100 Message-Id: <20231108104343.24192-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:48:40 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992564485097913 X-GMAIL-MSGID: 1781992564485097913 Exynos7 reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to Exynos7 in front of all old-SoC-like compatibles. This will also help reviews of new code using existing DTS as template. No functional impact on Linux drivers behavior. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar --- arch/arm64/boot/dts/exynos/exynos7.dtsi | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index 6ed80ddf3369..9cb6bd61262e 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -128,7 +128,8 @@ soc: soc@0 { ranges = <0 0 0 0x18000000>; chipid@10000000 { - compatible = "samsung,exynos4210-chipid"; + compatible = "samsung,exynos7-chipid", + "samsung,exynos4210-chipid"; reg = <0x10000000 0x100>; }; @@ -279,7 +280,7 @@ clock_fsys1: clock-controller@156e0000 { }; serial_0: serial@13630000 { - compatible = "samsung,exynos4210-uart"; + compatible = "samsung,exynos7-uart", "samsung,exynos4210-uart"; reg = <0x13630000 0x100>; interrupts = ; clocks = <&clock_peric0 PCLK_UART0>, @@ -289,7 +290,7 @@ serial_0: serial@13630000 { }; serial_1: serial@14c20000 { - compatible = "samsung,exynos4210-uart"; + compatible = "samsung,exynos7-uart", "samsung,exynos4210-uart"; reg = <0x14c20000 0x100>; interrupts = ; clocks = <&clock_peric1 PCLK_UART1>, @@ -299,7 +300,7 @@ serial_1: serial@14c20000 { }; serial_2: serial@14c30000 { - compatible = "samsung,exynos4210-uart"; + compatible = "samsung,exynos7-uart", "samsung,exynos4210-uart"; reg = <0x14c30000 0x100>; interrupts = ; clocks = <&clock_peric1 PCLK_UART2>, @@ -309,7 +310,7 @@ serial_2: serial@14c30000 { }; serial_3: serial@14c40000 { - compatible = "samsung,exynos4210-uart"; + compatible = "samsung,exynos7-uart", "samsung,exynos4210-uart"; reg = <0x14c40000 0x100>; interrupts = ; clocks = <&clock_peric1 PCLK_UART3>, @@ -539,7 +540,7 @@ pmu_system_controller: system-controller@105c0000 { }; rtc: rtc@10590000 { - compatible = "samsung,s3c6410-rtc"; + compatible = "samsung,exynos7-rtc", "samsung,s3c6410-rtc"; reg = <0x10590000 0x100>; interrupts = , ; @@ -559,7 +560,8 @@ watchdog: watchdog@101d0000 { }; gpu: gpu@14ac0000 { - compatible = "samsung,exynos5433-mali", "arm,mali-t760"; + compatible = "samsung,exynos7-mali", + "samsung,exynos5433-mali", "arm,mali-t760"; reg = <0x14ac0000 0x5000>; interrupts = , , @@ -619,7 +621,7 @@ adc: adc@13620000 { }; pwm: pwm@136c0000 { - compatible = "samsung,exynos4210-pwm"; + compatible = "samsung,exynos7-pwm", "samsung,exynos4210-pwm"; reg = <0x136c0000 0x100>; interrupts = , , From patchwork Wed Nov 8 10:43:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162942 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp826578vqo; Wed, 8 Nov 2023 02:48:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEQ2J7eaxHCoPDoUn2SENemYDTtERO8YVAlLMe1JfM3yBfiLDFQRktUmSAPzzds5QB/inH X-Received: by 2002:a05:6358:7f06:b0:168:e898:fb7d with SMTP id p6-20020a0563587f0600b00168e898fb7dmr1072545rwn.28.1699440529973; Wed, 08 Nov 2023 02:48:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440529; cv=none; d=google.com; s=arc-20160816; b=A6wzt9Ts/ubQzA4UEvMnPuYiA5uNPDQhKxv1xNOW8bMDCMSoJQUBnj4P4aM9Ql0cNv l2mBmcSiELPHQtqis8bbz/9XWw85M4co4/i7859PR4loC0fAOyrmJR3GQy6zJf5cXWA+ XNm9YlqBeHCDJMuUCuU4Jgjw7sW52/HNaVAG0cp15+2WskLAYQb8I8oCZJqx+odw0Rjn sWv8mvVHN0txxy0G7zVrWFxmsbOboNA16oomQRXzCdVl3BQMzynwkXOefE4VSA2xCEcl rF6KaweU3x2yYRn3VyruBVoBVAhVzzFszUeySdkSuy59w7tDQ6qyqsI/Jbx8IY3DKVOG HJoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lIuqvMhs71eYXo16i4dI05JAYajmCjaEEymf+9xK3uE=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=N4MZvIEQRl+osx80x9zPXaRg8XBzxgL9cdJkRYbcPnM0PG5Wlm5KZN6HVOpCfoAfyF WUYyW5DqM2d0y20m+j3yfsUeuS2LfWdGxCy1oH0mZh4hVzNs0HEAkevIdRo5kcHVSCq+ AYaPZ9L0+98gHX7DK4PQqiBK59MbGqrSoMFHaEJ2nJykpVs6Sh/EY/ZQiz9y5AkjEvqo 8NPT/29cvytJLT6VTkZYbVZsCUFeIWK7KSTLIS344mRa7lOs421qBS01kUWuR9BQZ4Z7 JE4DVkhDuPAq9s34kohmKEu9pEdHto8+/YsyhGB8wSKFj366hkE5EVytupmuqi9CQeVI bpQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rADoHBqy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id y191-20020a638ac8000000b005bdbd8e9f5esi3909113pgd.65.2023.11.08.02.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:48:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rADoHBqy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2AE718067B96; Wed, 8 Nov 2023 02:48:45 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344722AbjKHKrd (ORCPT + 32 others); Wed, 8 Nov 2023 05:47:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344551AbjKHKqd (ORCPT ); Wed, 8 Nov 2023 05:46:33 -0500 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F300C2D63 for ; Wed, 8 Nov 2023 02:44:52 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2c501bd6ff1so94540731fa.3 for ; Wed, 08 Nov 2023 02:44:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440291; x=1700045091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lIuqvMhs71eYXo16i4dI05JAYajmCjaEEymf+9xK3uE=; b=rADoHBqy9B2NFpmm2AD4YnRymXXK9o5+c3/zb16DXCRz8m9rJpetZ0kOl5HTryzP3W Qq7xXOsipMKDhz6yeI8JSrSgCZGQvBJ8zqpsCt1k7PLeNZ72VxlaGYGanHXhNJt3UecG 68kx/i4PfwmrljAHhoC7qNvjmXB2OgrR3kbzP/eyDvVZBHg818XZNPOTvGFJ6E+IKUb4 +QSF3f53HPdanFosHDv3LaYmIdHPcnLARj4nHi+z1oaUzZ/q8vw4hlBMSuwswvZ/b2Z0 37+qIy8lw6nCBi2kQNqn9xplqKoK6Qz5AJC/CvypQ5mjEqnj8+RPsOWF4e5heOHS3pML +cqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440291; x=1700045091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lIuqvMhs71eYXo16i4dI05JAYajmCjaEEymf+9xK3uE=; b=Sm1ZawjqCC/knymEnVWKu5ozeRkqDOzKLl/2Q9UmzGnGayW8u8G7VqZBQ7xzRnGMNn jCnA/WJxlL+3DFqcsXYudJMwailIIkHysRXxQXAOnEUQrhXp5w5DiCYOswHMjWeRFmbu /NLL3IwZxuKwPGD89QZ+WdbbRrG+X5b75m+rlt+P538mdzSGg/J85UCLXSaQ6SYpaH98 26OjliczSSO5lYObZ2LLClL335oTGfB99GCVsmeHEeLQH253mHFa+rX+D/w72UNjg/b7 0m1NEVFAqspoAqM9LiyR9LBGgue/AFvXwFSGHlK4qHhkH+UcSw5GxwYwsrqVd3lJv0ho pcAg== X-Gm-Message-State: AOJu0Yyf0itYgmP2jvqaY0MUjIFGeVbt/G8fkihlAHMHBPdqivtu9IPv 5I14gu0I4/SKqHBhouonVEL1cQ== X-Received: by 2002:a2e:bb01:0:b0:2b6:a804:4cc with SMTP id v1-20020a2ebb01000000b002b6a80404ccmr995286lje.53.1699440291307; Wed, 08 Nov 2023 02:44:51 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:50 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 15/17] arm64: dts: exynos7885: add specific compatibles to several blocks Date: Wed, 8 Nov 2023 11:43:41 +0100 Message-Id: <20231108104343.24192-16-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:48:45 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992553163743424 X-GMAIL-MSGID: 1781992553163743424 Exynos7885 reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to Exynos7885 in front of all old-SoC-like compatibles. This will also help reviews of new code using existing DTS as template. No functional impact on Linux drivers behavior. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar --- arch/arm64/boot/dts/exynos/exynos7885.dtsi | 45 ++++++++++++++-------- 1 file changed, 30 insertions(+), 15 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos7885.dtsi b/arch/arm64/boot/dts/exynos/exynos7885.dtsi index d69fc2392bd0..008228fb319a 100644 --- a/arch/arm64/boot/dts/exynos/exynos7885.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7885.dtsi @@ -172,7 +172,8 @@ soc: soc@0 { ranges = <0x0 0x0 0x0 0x20000000>; chipid@10000000 { - compatible = "samsung,exynos850-chipid"; + compatible = "samsung,exynos7885-chipid", + "samsung,exynos850-chipid"; reg = <0x10000000 0x24>; }; @@ -264,7 +265,8 @@ pinctrl_alive: pinctrl@11cb0000 { reg = <0x11cb0000 0x1000>; wakeup-interrupt-controller { - compatible = "samsung,exynos7-wakeup-eint"; + compatible = "samsung,exynos7885-wakeup-eint", + "samsung,exynos7-wakeup-eint"; interrupt-parent = <&gic>; interrupts = ; }; @@ -289,12 +291,14 @@ pinctrl_dispaud: pinctrl@148f0000 { }; pmu_system_controller: system-controller@11c80000 { - compatible = "samsung,exynos7-pmu", "syscon"; + compatible = "samsung,exynos7885-pmu", + "samsung,exynos7-pmu", "syscon"; reg = <0x11c80000 0x10000>; }; mmc_0: mmc@13500000 { - compatible = "samsung,exynos7-dw-mshc-smu"; + compatible = "samsung,exynos7885-dw-mshc-smu", + "samsung,exynos7-dw-mshc-smu"; reg = <0x13500000 0x2000>; interrupts = ; #address-cells = <1>; @@ -307,7 +311,8 @@ mmc_0: mmc@13500000 { }; serial_0: serial@13800000 { - compatible = "samsung,exynos5433-uart"; + compatible = "samsung,exynos7885-uart", + "samsung,exynos5433-uart"; reg = <0x13800000 0x100>; interrupts = ; pinctrl-names = "default"; @@ -320,7 +325,8 @@ serial_0: serial@13800000 { }; serial_1: serial@13810000 { - compatible = "samsung,exynos5433-uart"; + compatible = "samsung,exynos7885-uart", + "samsung,exynos5433-uart"; reg = <0x13810000 0x100>; interrupts = ; pinctrl-names = "default"; @@ -333,7 +339,8 @@ serial_1: serial@13810000 { }; serial_2: serial@13820000 { - compatible = "samsung,exynos5433-uart"; + compatible = "samsung,exynos7885-uart", + "samsung,exynos5433-uart"; reg = <0x13820000 0x100>; interrupts = ; pinctrl-names = "default"; @@ -346,7 +353,8 @@ serial_2: serial@13820000 { }; i2c_0: i2c@13830000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos7885-i2c", + "samsung,s3c2440-i2c"; reg = <0x13830000 0x100>; interrupts = ; #address-cells = <1>; @@ -359,7 +367,8 @@ i2c_0: i2c@13830000 { }; i2c_1: i2c@13840000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos7885-i2c", + "samsung,s3c2440-i2c"; reg = <0x13840000 0x100>; interrupts = ; #address-cells = <1>; @@ -372,7 +381,8 @@ i2c_1: i2c@13840000 { }; i2c_2: i2c@13850000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos7885-i2c", + "samsung,s3c2440-i2c"; reg = <0x13850000 0x100>; interrupts = ; #address-cells = <1>; @@ -385,7 +395,8 @@ i2c_2: i2c@13850000 { }; i2c_3: i2c@13860000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos7885-i2c", + "samsung,s3c2440-i2c"; reg = <0x13860000 0x100>; interrupts = ; #address-cells = <1>; @@ -398,7 +409,8 @@ i2c_3: i2c@13860000 { }; i2c_4: i2c@13870000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos7885-i2c", + "samsung,s3c2440-i2c"; reg = <0x13870000 0x100>; interrupts = ; #address-cells = <1>; @@ -411,7 +423,8 @@ i2c_4: i2c@13870000 { }; i2c_5: i2c@13880000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos7885-i2c", + "samsung,s3c2440-i2c"; reg = <0x13880000 0x100>; interrupts = ; #address-cells = <1>; @@ -424,7 +437,8 @@ i2c_5: i2c@13880000 { }; i2c_6: i2c@13890000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos7885-i2c", + "samsung,s3c2440-i2c"; reg = <0x13890000 0x100>; interrupts = ; #address-cells = <1>; @@ -437,7 +451,8 @@ i2c_6: i2c@13890000 { }; i2c_7: i2c@11cd0000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos7885-i2c", + "samsung,s3c2440-i2c"; reg = <0x11cd0000 0x100>; interrupts = ; #address-cells = <1>; From patchwork Wed Nov 8 10:43:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162943 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp826601vqo; Wed, 8 Nov 2023 02:48:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXYJnfiONat0OrA3NqZOA7r32KhcIOm3enN3qNBQHzg4pc6/dZs/qIAOGot7bewfzu33NI X-Received: by 2002:a17:902:d5cd:b0:1cc:59a1:79c6 with SMTP id g13-20020a170902d5cd00b001cc59a179c6mr1503214plh.18.1699440536190; Wed, 08 Nov 2023 02:48:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440536; cv=none; d=google.com; s=arc-20160816; b=Fv1koeWTAlRnRB2NMj7SZpDd+AAFeLYh/MVJLMq8ii6MYX+iHEHuUdoRU64UPuZvAO Wlu2dPB6UwyzFNFSoYK+4J0jhs26wi8ZP2tCbpJzwsGKaUPk5nuAsSNDCvDFyT6ZvuBw rKFxIPVDkwBHREaJenBBEypzWR5Lj0gZjWtFgFA76Fy5axqsrWuHej5xvcFTBPfzGexc 4Siux5ZqkrcBQJqfVq86Z61NcROrfNOfjUmdD57X7YFhOv8LHLY3brlOQvj7eSLdvISO 0rGplXtNYzDL3oYF/dzGH9e1TRspYERlx8OdFDzWRHeM7RBL99GV0InziOPQO5H3kn3c VaJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OiAO0adnMyNF0SV0wXdB73+0Srf6bBOK8Pyx7Wvcg2U=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=womgcPdCJMv6N6ugu9lMXg93iCjH568vYDYk27s9REM7Sgk+i0d9edr97eqjbEeM3X Sr3W4i/40Yp94rQ2v4i27v5vW8BY496Bf29Y0EPWUvYxfVad7E7+EkDA45QPiDu68i3s 2MOpXaV4zMd4yq5uFq8F+lmZ5Zsob9hexGF4o5N9Gf938TImXvcx94mrqfgGgDERXgo1 MctVU0VoB+kmsYiU0IzX4BlGX3GbNjBah0RoktM3oljiFLF+FBXWCJ5sWWjYmFvw42RE utTh3wQC+562Id86wJCXd6zXkH315338A93G8lbGWVFl7IAdPN/7hE9eimsA8u9I0uIt nFWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y0oFPVgA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id z13-20020a170902d54d00b001c32fe6cdf9si2293059plf.386.2023.11.08.02.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:48:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y0oFPVgA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 7DB1B8067AF3; Wed, 8 Nov 2023 02:48:53 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344621AbjKHKru (ORCPT + 32 others); Wed, 8 Nov 2023 05:47:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344673AbjKHKqw (ORCPT ); Wed, 8 Nov 2023 05:46:52 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCFE02D7B for ; Wed, 8 Nov 2023 02:44:56 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40838915cecso49177985e9.2 for ; Wed, 08 Nov 2023 02:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440295; x=1700045095; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OiAO0adnMyNF0SV0wXdB73+0Srf6bBOK8Pyx7Wvcg2U=; b=y0oFPVgAkbxHaAB1H7XF/QyrTxLpStfUN9vHee+oQAr63Y1WKDUP5UH+WJg76AeLu6 piTgwWF3IuL7S4ui2js9VqDPGcT0lc1OsVaec1zRo+5JXV4g2RUVxO7iWHb7v0k6yh6Z /K2s+uJmeTYM/bQnS1QDPrAkPGJ7+vCMUjCyQzIy5k2NEOorc2X+oQ4hy2Nkk047NBGo Z/DQIyRobDVXjY6W7SpUFety9odU832+XP1X3gI+9QpfvPLTpN7BoZtMbhzt30lPquMe UQTxFyzjcFKnB4O6WxC1lOZlEu0sj5UuTr3OPUkmM8IC1DgbXeyREVGoI331OzXwF6oU eMSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440295; x=1700045095; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OiAO0adnMyNF0SV0wXdB73+0Srf6bBOK8Pyx7Wvcg2U=; b=NEkbL+IhRGy+ja8fQ+s45ve1/eOixxiGDABvUhLRnhdAzYYNvadV/g1iEqfDFWBsm7 AmBUrxBb0s2zOH+ERBpOMqVdIKebYbtPs2iT6AJu7sZJbHUb3gRAHqgi1FiZw87Yypxs 1NhDRWxdSDsAra0kaamvQ7IqOd7cv/NMZrvyK7kbN4ZdnEvAvTInR3UN6auaqycgpYIM CUkpvyT0p2gWtqkH6LYqtsBwhMB/8OFkwtjOT0uJK3EFP1ayHK7yunLuX66lW0c5uqqa d8Z/ZnWu11xGlh9reRkkvFxE28HCbXNF8n7s6H6Uz5XSd/SZSPGqdgLHpxIeYeV2byWx WcSg== X-Gm-Message-State: AOJu0Ywcfcaa1s5CaSMKCgdV65XjTDrFdOocaP1eLtZzCKmGVKtWwEXv TLDxOUTT+b0AQ0M5zl3kGlEE1Q== X-Received: by 2002:a05:600c:46d1:b0:405:49aa:d578 with SMTP id q17-20020a05600c46d100b0040549aad578mr1455335wmo.37.1699440295256; Wed, 08 Nov 2023 02:44:55 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:54 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 16/17] arm64: dts: exynos850: add specific compatibles to several blocks Date: Wed, 8 Nov 2023 11:43:42 +0100 Message-Id: <20231108104343.24192-17-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:48:53 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992560044160802 X-GMAIL-MSGID: 1781992560044160802 Exynos850 reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to Exynos850 in front of all old-SoC-like compatibles. This will also help reviews of new code using existing DTS as template. No functional impact on Linux drivers behavior. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar Reviewed-by: Sam Protsenko --- arch/arm64/boot/dts/exynos/exynos850.dtsi | 34 +++++++++++++---------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi index 53104e65b9c6..df5ea43ebcad 100644 --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi @@ -396,7 +396,7 @@ pinctrl_aud: pinctrl@14a60000 { }; rtc: rtc@11a30000 { - compatible = "samsung,s3c6410-rtc"; + compatible = "samsung,exynos850-rtc", "samsung,s3c6410-rtc"; reg = <0x11a30000 0x100>; interrupts = , ; @@ -406,7 +406,8 @@ rtc: rtc@11a30000 { }; mmc_0: mmc@12100000 { - compatible = "samsung,exynos7-dw-mshc-smu"; + compatible = "samsung,exynos850-dw-mshc-smu", + "samsung,exynos7-dw-mshc-smu"; reg = <0x12100000 0x2000>; interrupts = ; #address-cells = <1>; @@ -419,7 +420,7 @@ mmc_0: mmc@12100000 { }; i2c_0: i2c@13830000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c"; reg = <0x13830000 0x100>; interrupts = ; #address-cells = <1>; @@ -432,7 +433,7 @@ i2c_0: i2c@13830000 { }; i2c_1: i2c@13840000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c"; reg = <0x13840000 0x100>; interrupts = ; #address-cells = <1>; @@ -445,7 +446,7 @@ i2c_1: i2c@13840000 { }; i2c_2: i2c@13850000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c"; reg = <0x13850000 0x100>; interrupts = ; #address-cells = <1>; @@ -458,7 +459,7 @@ i2c_2: i2c@13850000 { }; i2c_3: i2c@13860000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c"; reg = <0x13860000 0x100>; interrupts = ; #address-cells = <1>; @@ -471,7 +472,7 @@ i2c_3: i2c@13860000 { }; i2c_4: i2c@13870000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c"; reg = <0x13870000 0x100>; interrupts = ; #address-cells = <1>; @@ -485,7 +486,7 @@ i2c_4: i2c@13870000 { /* I2C_5 (also called CAM_PMIC_I2C in TRM) */ i2c_5: i2c@13880000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c"; reg = <0x13880000 0x100>; interrupts = ; #address-cells = <1>; @@ -499,7 +500,7 @@ i2c_5: i2c@13880000 { /* I2C_6 (also called MOTOR_I2C in TRM) */ i2c_6: i2c@13890000 { - compatible = "samsung,s3c2440-i2c"; + compatible = "samsung,exynos850-i2c", "samsung,s3c2440-i2c"; reg = <0x13890000 0x100>; interrupts = ; #address-cells = <1>; @@ -640,7 +641,8 @@ usi_hsi2c_0: usi@138a00c0 { status = "disabled"; hsi2c_0: i2c@138a0000 { - compatible = "samsung,exynosautov9-hsi2c"; + compatible = "samsung,exynos850-hsi2c", + "samsung,exynosautov9-hsi2c"; reg = <0x138a0000 0xc0>; interrupts = ; #address-cells = <1>; @@ -668,7 +670,8 @@ usi_hsi2c_1: usi@138b00c0 { status = "disabled"; hsi2c_1: i2c@138b0000 { - compatible = "samsung,exynosautov9-hsi2c"; + compatible = "samsung,exynos850-hsi2c", + "samsung,exynosautov9-hsi2c"; reg = <0x138b0000 0xc0>; interrupts = ; #address-cells = <1>; @@ -696,7 +699,8 @@ usi_hsi2c_2: usi@138c00c0 { status = "disabled"; hsi2c_2: i2c@138c0000 { - compatible = "samsung,exynosautov9-hsi2c"; + compatible = "samsung,exynos850-hsi2c", + "samsung,exynosautov9-hsi2c"; reg = <0x138c0000 0xc0>; interrupts = ; #address-cells = <1>; @@ -738,7 +742,8 @@ usi_cmgp0: usi@11d000c0 { status = "disabled"; hsi2c_3: i2c@11d00000 { - compatible = "samsung,exynosautov9-hsi2c"; + compatible = "samsung,exynos850-hsi2c", + "samsung,exynosautov9-hsi2c"; reg = <0x11d00000 0xc0>; interrupts = ; #address-cells = <1>; @@ -778,7 +783,8 @@ usi_cmgp1: usi@11d200c0 { status = "disabled"; hsi2c_4: i2c@11d20000 { - compatible = "samsung,exynosautov9-hsi2c"; + compatible = "samsung,exynos850-hsi2c", + "samsung,exynosautov9-hsi2c"; reg = <0x11d20000 0xc0>; interrupts = ; #address-cells = <1>; From patchwork Wed Nov 8 10:43:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162941 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp826484vqo; Wed, 8 Nov 2023 02:48:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7IxMQXjNx+t2IsHzamEyBINoOpYyxw1BSEIP8BOVSpaNWxpjmwGfb8Z89ppbIDDsCIbbE X-Received: by 2002:a05:6871:8d8e:b0:1d7:fe1:e294 with SMTP id tv14-20020a0568718d8e00b001d70fe1e294mr1122222oab.34.1699440513863; Wed, 08 Nov 2023 02:48:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440513; cv=none; d=google.com; s=arc-20160816; b=VR0mDlf6HkN+Rz6nlWPASpRG+hnra48pBQMlUyDWBSd9TCNm1MPUgeNjv0rCrzvNmh feA9k2jkLOr90zsNfxVYNG2MRPekIQbA9upGzrJPOyVdqGFP7bomC1Ch2m5kV6ZChyYl h9dt0mTwrNgYAGKy5Ej9tb0s3tr7w+ve6WRKVS8yV/yk5hw1dijAlJCqTloQnBMM/Vxg IsQxbub7Yhuw+L0zlMk2KJHXANDGgk6Kwk4UGLkzaEijgtS5I0bqeRrW46u1A2reucJc C8L6XvlsMtwIi2B1VPJC99+XQlTs5HXR/ihBzfF+xR5/dy8bZHrdKlUGHLShTYSOT2sy TU4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YQ+G5s8RPHyPJsrBFGNZYZXOAO3f3klrHmjNTSjaK6I=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=KKtEoyRmQpMr9WtYUnwfhTYFK/oqXQG80MtyVyHWL48kk+YVfomnlDvzT5Vgo99mDZ GKhH8BVXo397EvFSovZA7+KXi6MMOzDdVbAcfMTP1ZFUHi+JkZefasruDybPKjtReFMh 9FWiau0+HhGMZCucbkaCnYVJ/ysibBXP7TbV71OV8xEihtzF2bFyBscH+nTnmD/PYpu3 g6LDPVQu9YAUKl0tP8yBCLKzL+YkjvDv7TG+oRrGhecaGfEGyds9YDRPaiUz5Z7P1NXn 0fDpUnPFZR9j2Zt85n3y7Noebx0wnbfYF3LPIl10bdSkz+Ep+LD7JDUcZgPyDEuYPBk8 uv3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W2x3r7qu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id bg26-20020a056a02011a00b005b96cbfacdesi4276329pgb.196.2023.11.08.02.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:48:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W2x3r7qu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6463F8024B3A; Wed, 8 Nov 2023 02:48:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344402AbjKHKsI (ORCPT + 32 others); Wed, 8 Nov 2023 05:48:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344655AbjKHKrD (ORCPT ); Wed, 8 Nov 2023 05:47:03 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 517A830EE for ; Wed, 8 Nov 2023 02:45:00 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-408002b5b9fso49506255e9.3 for ; Wed, 08 Nov 2023 02:45:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440299; x=1700045099; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YQ+G5s8RPHyPJsrBFGNZYZXOAO3f3klrHmjNTSjaK6I=; b=W2x3r7qu6kvAoa6YNUPIxT0E6KPjTAYklsVnKTofKbvAg98XR3knJImbMSgo8hvKwD 8LPnlco7wqZc3KdQicPsuekNV4vgonbicgUT/H53JS0/P/QvrNlvG1eSi2OePM7I5hBi K0CXhuHss8MvHXmw+sfOkMh3fetSIT7KhOE1xg10HLX1eKVCxy5o01+PWijCDAsNkCCh t9awT+KNIKzM6znauX5Pccw990RIB6oZWUMb4DZb1vFwumRUWWCM0QtHALYoYeI0gZBZ e3Z0tjmeqCngooyJFnIvo8IW24JaVkqJVRV34uVnhTkFDRByRlLirP6uwwJcpumE/8k1 ydQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440299; x=1700045099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YQ+G5s8RPHyPJsrBFGNZYZXOAO3f3klrHmjNTSjaK6I=; b=FUAc6Rd0fX/CE91hyki5Gd1LYbXkegE53jn3leP50dVJgVjOtvgxtzbDsRg+K2uCvO 9aZPVcx8MTzz6TYEKvSF/19eJ53JIdCS6VHOiCoBE9lV1q9IZssbmplQJA9H0yO+2Of/ qmSjOsCeDUcaZ678PIGcvlH5JAwVbSwC358Cg7QdggSkwz+/MXV6wZZ81gZX4ZG2LKff KPc6QuOtWPuBJltjiqVGYXSUUAPq+Coifa5/15dcTc9vqBIbn6nKTZZ8TMd5N5J532cj dblhiWblk9NsuYkn/nsQ50zKzEQVhT0XeafaM+/azRHjexT6siK+ASQ8g0m5LB54CphR r81g== X-Gm-Message-State: AOJu0YxzA+dudl7uG0KgbaJ1pQsToTpIftRN65i6C3o+X2fD+nCW7XjG kyA0HL8MlbYrdbz1UaBxOijuaw== X-Received: by 2002:a05:600c:3b15:b0:405:95ae:4a94 with SMTP id m21-20020a05600c3b1500b0040595ae4a94mr1341542wms.5.1699440298865; Wed, 08 Nov 2023 02:44:58 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:58 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 17/17] arm64: dts: exynosautov9: add specific compatibles to several blocks Date: Wed, 8 Nov 2023 11:43:43 +0100 Message-Id: <20231108104343.24192-18-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:48:30 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992535932655436 X-GMAIL-MSGID: 1781992535932655436 ExynosAutov9 reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to ExynosAutov9 in front of all old-SoC-like compatibles. This will also help reviews of new code using existing DTS as template. No functional impact on Linux drivers behavior. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar --- arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi index b228cd7e351e..417aa56a81f6 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi @@ -166,7 +166,8 @@ soc: soc@0 { ranges = <0x0 0x0 0x0 0x20000000>; chipid@10000000 { - compatible = "samsung,exynos850-chipid"; + compatible = "samsung,exynosautov9-chipid", + "samsung,exynos850-chipid"; reg = <0x10000000 0x24>; }; @@ -349,7 +350,8 @@ pinctrl_peric1: pinctrl@10830000 { }; pmu_system_controller: system-controller@10460000 { - compatible = "samsung,exynos7-pmu", "syscon"; + compatible = "samsung,exynosautov9-pmu", + "samsung,exynos7-pmu", "syscon"; reg = <0x10460000 0x10000>; reboot: syscon-reboot {