From patchwork Mon Nov 6 17:03:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jambor X-Patchwork-Id: 162091 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2797290vqu; Mon, 6 Nov 2023 09:03:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IHA0FPPJCZWBMDiFpjkTW6sHB/yoa/4Ht/EfP2eUOQyOL0NWRN8pE5WW/T2pkj/OkvXFTLv X-Received: by 2002:a67:c284:0:b0:45d:9ddb:2a85 with SMTP id k4-20020a67c284000000b0045d9ddb2a85mr8057565vsj.15.1699290218789; Mon, 06 Nov 2023 09:03:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1699290218; cv=pass; d=google.com; s=arc-20160816; b=kxzcN+XrQwBkAqURrJOO2FfI9a4XJV2+hE8BYnhEy8cNHwwg5VkLco8TAyOZ5QLWA8 qmijj1sRXfzPHI83Y6LPGdjJBOK2ExrxbeRFCgjYHTa5B4yHPPveyKkeOEM5siAcAQHe 6KsXrHC83hKk2AaEZyz2nBEUkk4l706oxagAtgueFuQuSztPmX0sQL3sgYr3oRmbF3HN him5bEegSm79+a4Xt2s3UbbxqGsDzHGYb9Lnb42aOulgrlYI9iukd8n3hZQCIEgU/n71 kELYil3pZdkXspLuiNOPmTLxh0fWBbftoTW5B/TeNQcKeE5H8Fg5DF9GZLUgFr3x+f0h InQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:date:user-agent :references:in-reply-to:subject:cc:to:from:dkim-signature :dkim-signature:arc-filter:dmarc-filter:delivered-to:message-id; bh=6LktqMbEWsdjvcLe0pUYr6IIZhT/2XcNxIRgJrgmRj4=; fh=blkIyxs20HsyM11yLucY9QEyFQLC4aCOcAWQbd7Hr9Y=; b=inue7qr8jmMEtPcFGIYTC+DS7RnWzgpnXzmHA8F0KacdIxJbShIH05BDda34ffGKLP Tf5E11+OnqcgSkE+eBnlw3UJ2SQLWlZgE0fsK2YkypJXCdu0X9TLMkQ5d9lusg8XduLI dJzvDH95ORqRz0v6eqACQPl/E0LNAAMLFH1WA0az8/BWYpQFgbmimk6FxwCy/ii1RDnu usZqs4gKop0vU3m/y6aSB/u+o0RlNZKOs73YR6FNCPIgKveCVfyJuORPR3YzPVibUqcL gCf7s1LImFexi5vXD3IVppaZMzuIX9vWP05pCsVZVkMvYNFwSzAmNaSq1PBykrz4svoF Ct/g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="H0d3/OAm"; dkim=neutral (no key) header.i=@suse.cz header.b=Gxb0Tei5; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id z10-20020a67ec4a000000b0044d460cc461si793693vso.157.2023.11.06.09.03.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 09:03:37 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="H0d3/OAm"; dkim=neutral (no key) header.i=@suse.cz header.b=Gxb0Tei5; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Message-ID: <65491c69.670a0220.24aca.643bSMTPIN_ADDED_BROKEN@mx.google.com> X-Google-Original-Message-ID: Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 76F393857B93 for ; Mon, 6 Nov 2023 17:03:34 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 6F6583858C66 for ; Mon, 6 Nov 2023 17:03:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F6583858C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F6583858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699290189; cv=none; b=LXmxOEBSy3LNc3TPdjM+pmgeLdK1zfE5XNQLnY68I1cKQNfIpek9fEtyI4U/3XauJq9WD7SuiV73bJua3yjAqPHIbb2HjCIDyzcycvbFQVXftuc0/dYwGOgpKEIEmFklYWe9eQW38odMCc+LExwS70x4HYTPqawPehoVPSLP2BM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699290189; c=relaxed/simple; bh=rSveP4e9/bDW8QEGGOIUzBX3LCIjpbkpDPCwTDvUOGs=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=QdCZ+E/lXRvJ7yjiu39gwNd7oLmevvg8lqoICeWNG67DVcIwBxAIGa+biD3aFo4CAWkz1tYpxRqt4+PCdU1/k7An+BfzXK8ugcpsj+SBpM1tPXxp6lHNZ2Oix3EISoLkTg2018pysVeEvHeFaGYZCfO7XaKNMnNa7JqYwD/JMOU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 90994200DC; Mon, 6 Nov 2023 17:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1699290186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6LktqMbEWsdjvcLe0pUYr6IIZhT/2XcNxIRgJrgmRj4=; b=H0d3/OAmRx1t+up8p+DorLBtXK83Tsx/Lt3QHWnMZKZFNQmse8yruCWxX5jP7Ipe7h8EtG 54ZsjxTFlrsT0n5yt5fBPH3BdV/h/9AjygpbHf7LXQ6SJES/lrOxLIfx17Gx04zdqWdKgx 3l4/E0y94RVB2MtmbgzHxERj7f2BNpA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1699290186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6LktqMbEWsdjvcLe0pUYr6IIZhT/2XcNxIRgJrgmRj4=; b=Gxb0Tei5xDpQwVH5FKELWSEuvwjbvGql86bydR8lbpFfNowWz4HYNwoKg9v1AHCbV20h9C zMIh5nWERagWqxAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7E565138F3; Mon, 6 Nov 2023 17:03:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2byyHkocSWUrWAAAMHmgww (envelope-from ); Mon, 06 Nov 2023 17:03:06 +0000 From: Martin Jambor To: Robin Dapp , gcc-patches Cc: jeffreyalaw Subject: [PATCH] Fix configure script comments(!?!) (Was: Re: [PATCH] genemit: Split insn-emit.cc into ten files) In-Reply-To: References: User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/29.1 (x86_64-suse-linux-gnu) Date: Mon, 06 Nov 2023 18:03:05 +0100 MIME-Version: 1.0 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, INVALID_MSGID, KAM_ASCII_DIVIDERS, PLING_QUERY, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781834939301744623 X-GMAIL-MSGID: 1781834939301744623 Hello, On Thu, Oct 12 2023, Robin Dapp wrote: > [...] > gcc/ChangeLog: > > PR bootstrap/84402 > PR target/111600 > > * Makefile.in: Handle split insn-emit.cc. > * configure: Regenerate. > * configure.ac: Add --with-insnemit-partitions. > * genemit.cc (output_peephole2_scratches): Print to file instead > of stdout. > (print_code): Ditto. > (gen_rtx_scratch): Ditto. > (gen_exp): Ditto. > (gen_emit_seq): Ditto. > (emit_c_code): Ditto. > (gen_insn): Ditto. > (gen_expand): Ditto. > (gen_split): Ditto. > (output_add_clobbers): Ditto. > (output_added_clobbers_hard_reg_p): Ditto. > (print_overload_arguments): Ditto. > (print_overload_test): Ditto. > (handle_overloaded_code_for): Ditto. > (handle_overloaded_gen): Ditto. > (print_header): New function. > (handle_arg): New function. > (main): Split output into 10 files. > * gensupport.cc (count_patterns): New function. > * gensupport.h (count_patterns): Define. > * read-md.cc (md_reader::print_md_ptr_loc): Add file argument. > * read-md.h (class md_reader): Change definition. Following this commit, our buildbot script which checks that configure scripts where re-generated correctly is unhappy because it insists comments are wrong, it wants to them to be like this: ------------------------------------------------------------ ------------------------------------------------------------ I'm not sure what that means, whether a wrong version of autoconf/automake was used (though when I accidentally tried that, it has always complained loudly) or if some environment difference can cause this. Perhaps I should change the script not to care about commits though that won't happen soon (or perhaps I should drop the checks completely) but would people be OK with me checking in the patch above (with appropriate ChangeLog) to silence buildbot for a while again? Thanks, Martin diff --git a/gcc/configure b/gcc/configure index 4d0357cbc28..0d818ae6850 100755 --- a/gcc/configure +++ b/gcc/configure @@ -20000,7 +20000,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 19995 "configure" +#line 20003 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -20106,7 +20106,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 20101 "configure" +#line 20109 "configure" #include "confdefs.h" #if HAVE_DLFCN_H