From patchwork Mon Nov 6 12:13:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 161985 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2611425vqu; Mon, 6 Nov 2023 04:13:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IGahPf/Vs66ggNRHa/htAK0tCv/i/OfRmhLO93FAue61+3K1UUaaNU+YNWJiYc/MbK8bnHN X-Received: by 2002:a05:620a:f0e:b0:77a:7e91:45e7 with SMTP id v14-20020a05620a0f0e00b0077a7e9145e7mr6509030qkl.34.1699272832945; Mon, 06 Nov 2023 04:13:52 -0800 (PST) ARC-Seal: i=3; a=rsa-sha256; t=1699272832; cv=pass; d=google.com; s=arc-20160816; b=SzT95lAhGsoMlUMZfSruc2L64NUWlIVuZMkdNX1NtPNVCC7ED7ya7eksD/7vndoqow wMSY0OAf5wCgJPsPGMQiBE255k9KnTfjluIkwdeOj3EbPp4rBhRFAF+08lgbuhJmp1er 5/qjbXB4etB92t3s+yZvRXwnkwtG50Y8l2HrLv9eevPdwuZgI3l/Mi2piJgWDi7Drfqg hN2X9OEtuVQLfgcuBsLXV6mlMpNdlvkLsYWq+s+a2Nthx4Vqzz0PCowCe5rU550aRRr/ ahSAYJbpdnjL6ARYAeT0Kl/ec6Zna4s12yyV83ziR2mE+GqnzBHQl4PNiqfaLs0Q8ilJ OWEg== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:date:message-id:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=RgbMrbFO9idS6HHuTYg3EyHmoIJ9MqEYa+WrCr8jdvs=; fh=8WW8/k0o0G2vlJiZAQKLzwZ5FShsw2CjyMds4OH6804=; b=X9rWRlZ61DCoMdvdsAKl7nxzeR/H25TBWnQ8p9CdJVXEPeZFWTpdJ7zWFAa/9Ydm+L pWijOFkmVuuZ7Brz8SyuVqhgmNI5op+yscesLDrU6umo5caUrUXjvEWC8+qzGWOmVlxG Ztt85amwzad8DM+rWva70+NylIgT+L4tZZzriiphCGDDWWmzpsm0TLYo7fdwyky1IOJO 6z5IMWCt/cDJmyNIy8ll8wro3cXySPA1rqlrn9uMOPkXNZ1rUuDDFOpaCRLlrO2NGk+D 4FqDTKAHWdKAvnOjVNqt1o1dT4ZgZ1LxjpOu6vrMZ7ZMQ1pZhiMjYd/tOTZYVFQVY3Oi /MAw== ARC-Authentication-Results: i=3; mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b="Lt7WMO/Q"; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id bp33-20020a05620a45a100b0077890e5b1acsi5649852qkb.527.2023.11.06.04.13.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 04:13:52 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b="Lt7WMO/Q"; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AFCA63857730 for ; Mon, 6 Nov 2023 12:13:52 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2071.outbound.protection.outlook.com [40.107.8.71]) by sourceware.org (Postfix) with ESMTPS id 69353385773F for ; Mon, 6 Nov 2023 12:13:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69353385773F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 69353385773F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.8.71 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699272827; cv=pass; b=MMi8w+ifT3XI+u00BRJXnnK2I5Ssw5JWRCu+5W1sY7wUXnMc/119WUQMl7gIiaNDW2BjcqwEFOR8XgJtFOFq/gMYAs5tXXIZtxk6Vvqs0G/0tAT5mxv4VSt4uXaIeWez0xdlYgB37yhDasmdLZhrl82kDbx5xTdeD2QNv1RignM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699272827; c=relaxed/simple; bh=O19reJSYyfNwWXHCxebuMADsmpOziDB08Cb0k9VlOnE=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=CyOCrsLLSQLSOcnu8ZqKsUb3m01sm3P1gaA2gv8WNRShYx8+twlzdC9Z5OP6xUGP/ScbXCVNPAjikCy9HOaX+vglZ9phl/JjiSbfQ2Vvtg58NnHu7ogJLsm+rbw5NFSQYkz3/v2hfdHn+loSD9YlMiO63RRbRx926y9b3HGFni8= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RlLIzq7o+jikOCIwMCkNcXWdsbJSzr6ajCx/Y6Aiuevh0/ZaSc0el7deNcwExBIe37cLHZbeB5um0Ug/sxZlTWcw3DxgVWaKbgJQBdyibORlPEGeBUrq3JfMGGZk1j2Smh2iLOzCuulhesD4Uw44/W/I28G1CJwxUJonalaL56WMIJTek80UqZJkO5vRqTMQv4RT55Yanodt+7bZOOQyoBJz8g679mUmmhDUW3ejZOblUk0qs1z03j44pXU58FI683Ff1dU6hOIepMwZF9jmTQ3FcyU8oy8eSVgqExz2QM1djFMpeLSWbPx2P9GsQA28mGTiXuM+MhBr//Wld2jiJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RgbMrbFO9idS6HHuTYg3EyHmoIJ9MqEYa+WrCr8jdvs=; b=XjMUDt3J257pn6C61pa9RWWnGhvnP4StASEUUFXbUYAMajZxJFLDTsDeFYysETp0KnU3tjPo3l1G2KHa0MIPpwPbVc5+5S4B+DNL2HChdwlphCmIOHYxh+cv2ftAlGLvY8UlJonFNbB4hYKZt6/uEd0qUcy8CODzGsHEwTI+YPZCqxjsj6+jvtsFayTJLe2Ax359ttYfeuFfyg70ZWf3oVwHc3Z2c+CWTU2KovFXDXa9bvL8S89Q0AbYlcl30fnMDV/GJSqax9RwlMokcVZ9cY2/a6dm2bwW7cUOTPP81j0H0v1t18e6EeEtDZUeQJUk06hogL2xvYMNUDRXukd29g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RgbMrbFO9idS6HHuTYg3EyHmoIJ9MqEYa+WrCr8jdvs=; b=Lt7WMO/QnHZcqr70KuzootTj8wYNFZtsFqTQuez7sTUVEuM4U5W2fLEVe9P1i1RFbpJgjasqmS0fSfi8+ImE3MDXoMVdKhcnYWxBf2/EBoEsLQ77ZQ4sUyIQ5bP9zSCAeuqC1gyeOlon/aMDvhZETKO1PqCeSliU97aYmeLKIAbQ5BKx7BeoF/xMdGZOI//SC84nVviD35PYulHbnVx1jNi99M6pW8XiAWrh+VnlpZIzi+OHT7s7ovTq3DZmpdDMnRN4/b47jy3xJtoMHsTcP197+g78febtQ+cnD7YrLj/ky0M8z53QdK24sI3Y1EJ3O1rpz1iCn2yIjjVcyL1+Iw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAWPR04MB10008.eurprd04.prod.outlook.com (2603:10a6:102:38b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.15; Mon, 6 Nov 2023 12:13:43 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.6977.016; Mon, 6 Nov 2023 12:13:43 +0000 Message-ID: <35582f50-382d-5be1-ce93-764c4708fdc0@suse.com> Date: Mon, 6 Nov 2023 13:13:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: [PATCH 1/2] x86-64: extend expected-size check in check_qword_reg() Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" References: <361cebf7-0af4-9a19-23af-fb4498ff47ad@suse.com> In-Reply-To: <361cebf7-0af4-9a19-23af-fb4498ff47ad@suse.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAWPR04MB10008:EE_ X-MS-Office365-Filtering-Correlation-Id: 95f3846d-cc53-4aea-d746-08dbdec1d1c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hLWIer8tuAMJsfMaUFUPgjltzpXLT2iFs4y/xWPYLZRk5XrdmgGFmuDpJDlrOdA8qxeaMtaNg6lAn7teiPTMQucIBKEqjDvlryHH2k9YqILSy0qvTcHr+IRlGuhF45TUvTY4fvtjnhnSTfIkmMrNCM37XwCnAt/UzDeZW3fyJpQDdSdTOJ4Jky/DMDOhLXW503HWb6DNUlt7wUlEKbR5g44OgrEWF/ZDhCUrywaCaNetZfUrc3FYmWgX34d8ziVeWQUYqrh+JY+rLvnmyDPDVJKXncz7SmMHDwf39/kxskGXzyGIDglAUQQlsz/BNP/cn9rB3pFb1nogsZzeTxiMoJkozpxDot8neBAZcKdE54WYFVUplSlLEONByNoTKWLdicg8Nx3ck+5bP0WW0L5I6wDDE/3jnrUuZyxcWMdFi7gkDwexV+fjJgzl5rD5FfX/O7eCRWk4RZLgHhHkW214ztJb5KOau+flz+dpZ64NpgGMZAVo8PSeRzka1gm7G/aMf1dti7Ky7dtkh9qDZsn5UqWWc4MhgdtlE7JDimkDujn8dzkHAStD3z8V5tMejJZqydwyX4LgoSAoRnlaZDHzXbXmvl1c3i7ssW5L/84AYcPOkz6gKWL6XB7F7oqVf2IQNcgsUALY+syrBq8SniOqIA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(39860400002)(136003)(376002)(366004)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(31686004)(66946007)(478600001)(6506007)(41300700001)(26005)(36756003)(38100700002)(6512007)(66476007)(2906002)(2616005)(6486002)(31696002)(86362001)(4326008)(66556008)(316002)(8676002)(6916009)(5660300002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?pQNxFSO6/Rsxb7lEjFQIa0Q8jbq8?= =?utf-8?q?hfe/T1Ihpii2MIwLo8HRIGtXLCytXanDv6JeHQSvr8WiGiAivGHoydiq0VmZhA+pC?= =?utf-8?q?gPhP97DzgGL8b4a0XommP89eVlqHLYuunu7VF/g/X/mmE/XCrMPP9kIkOQrOT3zQa?= =?utf-8?q?h5TajSPGr7hxG4NJMh/X/WIG1Y6MH/PnVDnTH+q3L/t6c/TRq24PonMBMWWheKPxV?= =?utf-8?q?Uz8BWMICuynki7dWkVbSliaYLoc1iyapREXxwWeIg0o2mOcgeS8uTBogzkGSYmuQX?= =?utf-8?q?PA5M3ISj02Ebqy7OgB0g2jBA0kAVlPN4IgsVQ4hDfgkbmp/vUJGN0qtTofSBm7Y60?= =?utf-8?q?Aep5uA2j+kq6jNg+V+HASne/4XjPpWPckZTEBAMfcUNSUUMwzNjm9aoTHPND75sEY?= =?utf-8?q?0xbewJUj59ZvLOwF9dSJYOVrPrQ4HE42O9/6HDx275ZC5RQz8UacI1s6zVKXCSzLt?= =?utf-8?q?xUMEqamva1lPQpiELEKnqjp/J94RrX8gh7UBh7bn051eQBgOkEOTnEdY9ANb4UUFh?= =?utf-8?q?JoOY1RGbH3KwOy/KamkcI+okhHTs9bHr8FWVPK69J0c8hTv5Tv4fbkk+Hsn1h9j2r?= =?utf-8?q?GWXOKiu1LwAXRHIcwZIlogW+/cyJ8tz8Abtso7Szme1j+0MVJDpflBQT40KG6TM7A?= =?utf-8?q?3HGLZcd+7Hae+XcJftqEawTqJOB45KETSuOkXXtcd52SZVqRXIpHNYZG7bJ4UO1pR?= =?utf-8?q?uweJgB9+zyDP1BYVnsOXuIkSSIMVJTbgB+Y8iFfaOqTjj29/abTsLlSnrkfwoTC++?= =?utf-8?q?oyXHOEKSzYlxYi8FGwEEEE0LNqGfkisiqxNxnJvIOZtB2GZxzQ8/eLu7dNHWerF7P?= =?utf-8?q?UD6a66xOG63CCRySPaE5kW8U/WTgju2qfi1vbd/su7pxiknBUG+931g5WNPttqBNt?= =?utf-8?q?L0TSCozNmZUH78lpltRy9/5HdpwbeAQeoHJzSVkckzXQ5PNgaevkgcoHwe7kBnnMx?= =?utf-8?q?iop36OKD/cp+XOP0fa2XyCsL5Abu5aHFEcyAVPJgmlqXkVfiJDjVX+Tqx9uWj/MLz?= =?utf-8?q?afHV4l9AnfR0GqkgmfAtqsMK0nHVKSc4Q7JjTu1cnT8aeGtA7SuL7WxGrQ6B74X/9?= =?utf-8?q?rhA0pgBlYB3qH58VL9FTB+8q1CmWXJ8tvBUo8E7gTRm1npDr1cMxtNUa/uTtSOAFm?= =?utf-8?q?FmYsFuQtoipX/hEKlk9ygvyoHKsMvPSgcOf19rd7NCJEMaVmYqmwiSzGmZtvZbE/v?= =?utf-8?q?2vHNvPGem82micU2LTnd6Kc4Pxcj5C+LdwTR/tCptWlUQlcSptAHO3xZ+kr0jIqH5?= =?utf-8?q?Z4kM2TEuup5NK3MfP+ev3Eho8qwEq19ZHbXb/dIFjS+eoCA0+bAiqMtPeeHZrWYtl?= =?utf-8?q?JYS97iWc6LS/9Ct1Z3/ipbIelQufkfZ0VWUrW+88grmAMWEikkegxDydqPOIWi0mN?= =?utf-8?q?hbQPy1PNvhKUleQ+2cBAEaOVtZF/1t9VrIxZ4zS6hsRa7z7URcTTsnvEEbDs8Cy9f?= =?utf-8?q?gAYaNVUGWUFSs8nUIfdG/WcFs3uybCFxRL8bFxplP6ygUkTTQYvty5wpkHVYkcbvF?= =?utf-8?q?NJcf73jQScSG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95f3846d-cc53-4aea-d746-08dbdec1d1c0 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 12:13:43.3384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UvfvBtHM5vuJHQ04jEFCMkMav8m+QfJE7uF+fCoY6sIGjocVsYdBTdhM8fIi5FP3Sx7MqEVjoQD//LANCMeUCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB10008 X-Spam-Status: No, score=-3026.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781816709719949241 X-GMAIL-MSGID: 1781816709719949241 Due to a missing check "crc32q %al, %rax" was wrongly translated to the encoding of "crc32q %rax, %rax", rather than being rejected as invalid. (The mnemonic suffix describes the source operand, not the destination one.) Note that check_{word,long}_reg() do not (currently) appear to require similar amending, as there are no insn templates permitting an L or W suffix and having an operand which allows for Reg8 and Reg64, but neither Reg16 nor Reg32. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -8160,7 +8160,8 @@ check_qword_reg (void) && (i.tm.operand_types[op].bitfield.class == Reg || i.tm.operand_types[op].bitfield.instance == Accum) && (i.tm.operand_types[op].bitfield.word - || i.tm.operand_types[op].bitfield.dword)) + || i.tm.operand_types[op].bitfield.dword + || i.tm.operand_types[op].bitfield.qword)) { as_bad (_("`%s%s' not allowed with `%s%c'"), register_prefix, --- a/gas/testsuite/gas/i386/x86-64-inval-crc32.l +++ b/gas/testsuite/gas/i386/x86-64-inval-crc32.l @@ -15,8 +15,8 @@ .*:19: Error: .* .*:20: Error: .* .*:21: Error: .* -.*:24: Error: .* -.*:25: Error: .* +.*:22: Error: .* +.*:23: Error: .* .*:26: Error: .* .*:27: Error: .* .*:28: Error: .* @@ -26,6 +26,8 @@ .*:32: Error: .* .*:33: Error: .* .*:34: Error: .* +.*:35: Error: .* +.*:36: Error: .* GAS LISTING .* @@ -52,20 +54,22 @@ GAS LISTING .* [ ]*17[ ]+crc32 %eax, %rax [ ]*18[ ]+crc32l %rax, %eax [ ]*19[ ]+crc32l %eax, %rax -[ ]*20[ ]+crc32q %eax, %rax -[ ]*21[ ]+crc32q %rax, %eax -[ ]*22[ ]+ -[ ]*23[ ]+\.intel_syntax noprefix -[ ]*24[ ]+crc32 al,byte ptr \[rsi\] -[ ]*25[ ]+crc32 ax, word ptr \[rsi\] -[ ]*26[ ]+crc32 rax,word ptr \[rsi\] -[ ]*27[ ]+crc32 rax,dword ptr \[rsi\] -[ ]*28[ ]+crc32 al,\[rsi\] -[ ]*29[ ]+crc32 ax,\[rsi\] -[ ]*30[ ]+crc32 eax,\[rsi\] -[ ]*31[ ]+crc32 rax,\[rsi\] -[ ]*32[ ]+crc32 al,al -[ ]*33[ ]+crc32 ax, ax -[ ]*34[ ]+crc32 rax,eax -[ ]*35[ ]* +[ ]*[0-9]+[ ]+crc32q %al, %rax +[ ]*[0-9]+[ ]+crc32q %ax, %rax +[ ]*[0-9]+[ ]+crc32q %eax, %rax +[ ]*[0-9]+[ ]+crc32q %rax, %eax +[ ]*[0-9]+[ ]+ +[ ]*[0-9]+[ ]+\.intel_syntax noprefix +[ ]*[0-9]+[ ]+crc32 al,byte ptr \[rsi\] +[ ]*[0-9]+[ ]+crc32 ax, word ptr \[rsi\] +[ ]*[0-9]+[ ]+crc32 rax,word ptr \[rsi\] +[ ]*[0-9]+[ ]+crc32 rax,dword ptr \[rsi\] +[ ]*[0-9]+[ ]+crc32 al,\[rsi\] +[ ]*[0-9]+[ ]+crc32 ax,\[rsi\] +[ ]*[0-9]+[ ]+crc32 eax,\[rsi\] +[ ]*[0-9]+[ ]+crc32 rax,\[rsi\] +[ ]*[0-9]+[ ]+crc32 al,al +[ ]*[0-9]+[ ]+crc32 ax, ax +[ ]*[0-9]+[ ]+crc32 rax,eax +[ ]*[0-9]+[ ]* #pass --- a/gas/testsuite/gas/i386/x86-64-inval-crc32.s +++ b/gas/testsuite/gas/i386/x86-64-inval-crc32.s @@ -17,6 +17,8 @@ crc32 %rax, %eax crc32 %eax, %rax crc32l %rax, %eax crc32l %eax, %rax +crc32q %al, %rax +crc32q %ax, %rax crc32q %eax, %rax crc32q %rax, %eax From patchwork Mon Nov 6 12:14:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 161986 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2611745vqu; Mon, 6 Nov 2023 04:14:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNZ1osvz28t389rGATva40xaGKJX8i3ev1oko+W0wgR+XoJT4h8WB5fGeJyjDQoPXvXYcV X-Received: by 2002:a67:e1ca:0:b0:45d:a0ad:9502 with SMTP id p10-20020a67e1ca000000b0045da0ad9502mr5272145vsl.3.1699272869639; Mon, 06 Nov 2023 04:14:29 -0800 (PST) ARC-Seal: i=3; a=rsa-sha256; t=1699272869; cv=pass; d=google.com; s=arc-20160816; b=jjfFhthaJrnrylDVwVWlLSRpm0yQpPux3/ydPmsiY19vrD3xDNt8aS0giJzxwb8CC1 U69kmJFq9euzkTyMNXg3RLWsqUIBlvOP8DWNPgtpgpyvcEs87ASkiAickcAAl9Wq48EI hivgvyR4BrBbszOkxX4yQyiE5IlmQPtWGU6cEkwUcIDl2n8A8cYwI1piLTWE9a3vWtJ+ UB+Aq32rkaHflQ5qB583o09XzpnV7RYg/fuAfAiYGsO8vmlFbTUyfCIGunNRijiqFvHq l6agBAHNUStee8JzTg4vY+uR0gQThzmNIdjrvpRni1YKFic6UTFb6c1coK4RG0MWCZDo w4nw== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:date:message-id:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=xo+GO6uxBVvqQfnwAvfeZDkHPcP8OWpnxyKZWjSEjqA=; fh=8WW8/k0o0G2vlJiZAQKLzwZ5FShsw2CjyMds4OH6804=; b=D7mV6xAmFA1+EYY54pnH5UOc5qkDwnSr8a3+GUF3FtNVzpsMiz5y5G1xhzMnyMj649 dLPGTtAkmhO/NFF9WUC7HOsog3StxrhXdxIC6P9of1zM8dMbVJvpd9y2x7vAAuruNj+h T9F1IJvBuhemFcX9y/imN7vmeOEK/KW3TV7B9ys26hUk2kQ0HprVOozYKxYZDuA7x+wE yGxfb8c09xJdfCnNy3vIjjq2+9llvh0UV6I/0OM5m6YyCx/WWLFQyimWY7Gaa1DSSgfO XoHndIyX3+z46MvAa/DNYaQBuOOMXaIqTSZ3Dj3Kxq0bcg90dkCLrZMmYJv/LzNllkBR YHOQ== ARC-Authentication-Results: i=3; mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=HIhBI5g9; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id d9-20020a05622a15c900b004197105b96csi5500953qty.191.2023.11.06.04.14.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 04:14:29 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=HIhBI5g9; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 76464385DC3D for ; Mon, 6 Nov 2023 12:14:20 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2080.outbound.protection.outlook.com [40.107.8.80]) by sourceware.org (Postfix) with ESMTPS id D0C7A3857029 for ; Mon, 6 Nov 2023 12:14:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0C7A3857029 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D0C7A3857029 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.8.80 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699272856; cv=pass; b=ufI2d3wweWqnQgiEuWEfyA0lGRLh5PMBNZOISIiiEgL1YHLvwMUsxeVeioromP10aqgpZJNyKU19yikeWGfZzWOVY0/M3v4TTPg9BQyCci84iQQRSokmIuDbWYYuKz2Yu2Hg0CILd8XgjLMGxP8ujzoeWVvNq027uD2PFX5fQhg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699272856; c=relaxed/simple; bh=sgsvTod5ZO4z60mbshKb/DrvEDbGSuo/jcAhxmIIc3M=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=AbF7dZGtfw9c1u2GCc1wqeC3lwNQDvDRFcOMitEMIm28der8lYB5VfyTp7itlgTFAF0w6MdMyTpopu2MI4QZkPAh0aZ2QVqv8PcXXTxeKFFDiFknA1qJaR8ywmBqe3XWvIzgioSGVNcupBNPXdzxt1JLuUA9EIxOzYucB9EfXHE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m5y5rkqo8PFhkanyQlZXkAwMisDuH8z7rg0okGuRZi//ZfScuAJR1rkcRpglqXHcSjn+4XtaUEl/YNEkDRSHpnprhlnw9cx9V6oQ8p7XLDiQIwAiITbvZs6o6iRMR2fuq5dzgN+q2v6kRk1douRMK0Fbp4QbSA2BbbvNkCsWoAKMQoXKwVMW1JRlHiEPMsIq/pcHzrjzACMS/l5Je4zrj3bXmEL1MdVDqXHzyXww8osfhyNnKuJvdnupzoNvKr8qUwEe+29WgCQXRLueKphL5cLVrfxKe/G7seUVqybOC12YC2gFOjFnpc0+ZjJnKZUypw1QYAMl6drgSiKb73eq3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xo+GO6uxBVvqQfnwAvfeZDkHPcP8OWpnxyKZWjSEjqA=; b=XOKeeMEvEueqOEdopygwNPvqkxj9Hevn3ma+ea49wkN3o5lndkOzfaM+pP5rEbzJBjfkhIIo6tp0X1LaJJBXzp97Mu6LjPTarsy388J77p8nVM7J5ybjHAVW92KxqnUGSM5izO9S4Dcefpe1Cgy9286/Up9DbOxmhK+8Un+FGb1Ts2+OfaYbEneWZj7257LvgfDL6a5g3YPyOwTTYolpylxaAbu0eZ96eDoWeldPOLX9pSowaNs4IAwjvwU2O39H58k2sP8g0xkEcgclwyY0QF5V2uUJjeKgpJRlUApv5Q4+YPuH+73nJyidb1l4ZDp+VmlrZB87zIpdkcZ8KFbWoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xo+GO6uxBVvqQfnwAvfeZDkHPcP8OWpnxyKZWjSEjqA=; b=HIhBI5g9O/xWRQKWQfwwD/BYMQ7RkhrQbpIfbs4Cm3XqKwH3f0gzX1W0uCX4tKjdpWTkrBJCEper9cjvCKhZn+ys11KWzgHUVTcHw8y/nmAkB8BFRa94Rum1IwKlGkZVVtGWCVDRR9Fcdy1ZTdB5plb/plmgmHlKgqVG+SdEaKKsNiNrNi7VX1M+ApJ4u14aSIVln50CKdjMKpkeVkBk7mV29DJbZF+b7qYrPu/68ulszyqwtY4m1zUTdz6fYIfLJB+1qCnZBhgiFA3AowZUqNQFMKYNi2FR0vpSC8c6FhO+FJa2DNZ2MEnA4v7uD5JMPj0AM4Ara5BXtI81vI1myA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAWPR04MB10008.eurprd04.prod.outlook.com (2603:10a6:102:38b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.15; Mon, 6 Nov 2023 12:14:12 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.6977.016; Mon, 6 Nov 2023 12:14:12 +0000 Message-ID: <270043e8-7c64-6551-e32d-9695db3c255b@suse.com> Date: Mon, 6 Nov 2023 13:14:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: [PATCH 2/2] x86: fold conditionals in check_long_reg() Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" References: <361cebf7-0af4-9a19-23af-fb4498ff47ad@suse.com> In-Reply-To: <361cebf7-0af4-9a19-23af-fb4498ff47ad@suse.com> X-ClientProxiedBy: FR0P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAWPR04MB10008:EE_ X-MS-Office365-Filtering-Correlation-Id: c4ce6a72-1ac4-49dd-ee28-08dbdec1e31a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TI4ewTwSnor5jTHOLxz3iLeh40qnzetm14Bk0xU0pe8ez/W0efCMk/muKYEzS1jWkjRS2B1I0NYVufvUMj7J2S/+Ri2wZ9MkIwcG92mSuEjjBMW+ftyjsF+2N5mmXk/4UBR3BnjW3DU0lDw0uA0dcWXR9YiU0Jj8jwj4vrQQYw0ZU2U/ATyCIYgYW9dUC2ml8r4P5O65qXoF5r29RYdERMYNXiCCWkazYhjS+DJD11phzifNSghOHGV7tbS8wY4r0NwXTBVjaAC/6+YvPl9PAEZgBIz4UZ30Nf0BTWmgSZzZLugtcGMCd2boYv6QluXLGMlqU3XEpMpDn38vLyBbz340QTfC9YpHVD3wANeYBlmfb3o0fNHbMHQQkvrFhpQ/9g+vPBPwQdvGABK0z8onCosvuwKgNxofHveqLlEX5qvkDaH1DKLBbqhKTLRQnrj69fs2R5Ivn4oUpHFSKRWFBteha+hTT+PpSB6h87LaVbHq6wZ1jN8gkLNRgb52QfnRKtVa2XV33ZreanDa+GiKed8JBfNPTTgRWISI+DChOrEAr3OLZzGlMHqUp2YkuBFx8rjlXuUrBiOkS7wp+Z2WeUNPx+V37VGojcYxKVVnEJJGJyBL+fQ1Gfr4FZKMMZy76zJOlWMtZXPKO0uPp6AjCgkjj/KIWE4YuNZe0Q7tYbd/ecW2hfpIrdCdP5HRxHEq X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(39860400002)(136003)(376002)(366004)(230922051799003)(230173577357003)(230273577357003)(451199024)(64100799003)(1800799009)(186009)(31686004)(66946007)(478600001)(6506007)(41300700001)(26005)(36756003)(38100700002)(6512007)(66476007)(2906002)(2616005)(6486002)(83380400001)(31696002)(86362001)(4326008)(66556008)(316002)(8676002)(6916009)(5660300002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?zy163pLAdFyTjw6vdKWz0gnOYlzG?= =?utf-8?q?iHPNIqNBAoB1D4WtEUPjE0zNN1LeFQ47iaA8PCJK7vjesHSgn7zoZDrULgvp0nJQz?= =?utf-8?q?z/PriIbFyjtvN/a/zGwxFmxRo5+x0ThTZQflB4bbgAornEDWC+0pzxRluq7zOeM6q?= =?utf-8?q?Ad3UYGRTM3zLRqDbIn1JvWxYexsRhId/RtnAhAvkHb4HsGLh9SIq+ZnKiSml+Fki8?= =?utf-8?q?wDuVEqO6Vhu2T4wFk/qDbvqCPbGFrY0xhElBM8EEFOuUJXo8lSeKz+Rrbdl1T3pSh?= =?utf-8?q?YFNKgvExi++Vh8Y+CSfLi9eNWZNLVZ0WaKkpdEMAO4+m/j6h+iPoL4QiR+gweLIhw?= =?utf-8?q?v8irEnbWoDNw2IwCNkLeLdqYmcbuKbLN7gObhmfVnYUj8WvnaD/gLEtnnTv1kHMLY?= =?utf-8?q?WWdwS+ivwxreBpABibIW3r+vClIpO8AKnbB5as56/4L5MQf1qImmtQopV87p6ru8m?= =?utf-8?q?y4isl2pYdGuHpUz0+Ipyk+rhqssDM26XFSkt9J6j3etCkG+G1hmx/847XMu2ztf9J?= =?utf-8?q?8GiDs1o4ZjXAhjXMEMFLSJp3QNyCEU/f7hDBxKGrwIUcZ6tXQ2LlxfnTDsbhkcYRR?= =?utf-8?q?vZGMhlRGKjz1/+UBQ5MLIubwLrgWZ4KL2ciRIL48tbd0m4noqlrImaNEYI/4ynZsH?= =?utf-8?q?lpFaZaGxWCKWRkbyiLGYDtA8xVH5FtkFcr9IRRwUqr6Avpu6LEBlIrkHuU40IINOt?= =?utf-8?q?oOoN21E6le0yd1evBsW54yfViWdfF6I1UHLntnUqToICVbV4dT09gZtIBPY8v+xhb?= =?utf-8?q?r31+AF5cj0h7CNj9UMshscle4VNn3o3HLyKbMnlDjuiWjVdrXMQVqBkCqlwgEonaz?= =?utf-8?q?lTT5k4WrLV36EL/1/nRMJ0LxuUNxWNHwBMKSyaOApk4SwrFn+G3mRIhhc2vgSJtPl?= =?utf-8?q?0RVp+BQSmckzjbg1nW7FTy4lR86/ZtPmeYoNgag2ExzdCbj1i5Gy0xfddKCJnrW5U?= =?utf-8?q?WsF+Eoeq5YBNyr4oP0oxH4PIX9twT45J+lx+uciu9TqcVJXwj5EZBfD8X+NGWhlYW?= =?utf-8?q?7i/21YliwhjbN83ZW4/8CqCZrP6csCXhxWT9C+mNsR3AlzYb0nRKcyFRHgTiHHygm?= =?utf-8?q?VkFMSIjW3AKwsFsa5Bnaz4FNU1Stt7/boehKUMRVwkRkIfuv4ZyoGZqPDnt9ZVDu5?= =?utf-8?q?mgnhAfjs9NNa7eizdS6Ibli0Y0Ct21K2PumT8FlaevjmVeqO+b8JhOPrdBW9wlf9E?= =?utf-8?q?ygfBEN+gQjKBDIWHu0dZQKoRf7JJ/fcSSm2oRrk4xM+j9OLoxaAyfScyWfrwMBiI5?= =?utf-8?q?2jtl+zuYmuvokqQDxChTNbYhIiawFFepyCJkQObDfDGK/8M9R0rDYORoSh7Ilv8Ky?= =?utf-8?q?z3Bn1CgZJHrhQaIaRVhoZOrHMZ/9ejZF08CvMq3Q7yny8mYJjqt0DK3r5nxVV94So?= =?utf-8?q?0rqQqkYapQB2AoOO0uaScThJ9KSTBNz/w0r4Nw+szmbm9UD1wATqnpIQZAVEByaUC?= =?utf-8?q?QCwN5oAisNcrb8ED+jMT//4brOHl93LDw6uhlhVFeBowjhJeTUB0j5pLbQkrvHxVq?= =?utf-8?q?+pGWVDnyqCvY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4ce6a72-1ac4-49dd-ee28-08dbdec1e31a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 12:14:12.4305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 85Z4Bpz4wit0BLIPnawMXqrWHON79w+i1WgRL+wS9zbq9m2EmDaHJtDYhDGNOrczS5/U0iFfT9E5kDyS4po4YA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB10008 X-Spam-Status: No, score=-3026.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781816748521642558 X-GMAIL-MSGID: 1781816748521642558 Simplify the code follow ing what check_{,q}word_reg() already do. This the also eliminates a stale comment talking about a warning when an error is raised. While there, correct a similarly stale comment in check_qword_reg() while there. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -8121,8 +8121,10 @@ check_long_reg (void) i.suffix); return 0; } - /* Error if the e prefix on a general reg is missing. */ - else if (i.types[op].bitfield.word + /* Error if the e prefix on a general reg is missing, or if the r + prefix on a general reg is present. */ + else if ((i.types[op].bitfield.word + || i.types[op].bitfield.qword) && (i.tm.operand_types[op].bitfield.class == Reg || i.tm.operand_types[op].bitfield.instance == Accum) && i.tm.operand_types[op].bitfield.dword) @@ -8132,16 +8134,6 @@ check_long_reg (void) i.suffix); return 0; } - /* Warn if the r prefix on a general reg is present. */ - else if (i.types[op].bitfield.qword - && (i.tm.operand_types[op].bitfield.class == Reg - || i.tm.operand_types[op].bitfield.instance == Accum) - && i.tm.operand_types[op].bitfield.dword) - { - as_bad (_("incorrect register `%s%s' used with `%c' suffix"), - register_prefix, i.op[op].regs->reg_name, i.suffix); - return 0; - } return 1; } @@ -8170,7 +8162,7 @@ check_qword_reg (void) i.suffix); return 0; } - /* Warn if the r prefix on a general reg is missing. */ + /* Error if the r prefix on a general reg is missing. */ else if ((i.types[op].bitfield.word || i.types[op].bitfield.dword) && (i.tm.operand_types[op].bitfield.class == Reg