From patchwork Sun Nov 5 14:48:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Sakamoto X-Patchwork-Id: 161646 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2162783vqu; Sun, 5 Nov 2023 07:01:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEXetXYFCs00HNe4wSdcUPgvSF2CowrGHEuLx1UMygXx1IGD+0C/kyhvoPMRWSqH5rubkL4 X-Received: by 2002:a05:6830:4106:b0:6bc:b26a:8939 with SMTP id w6-20020a056830410600b006bcb26a8939mr4955697ott.2.1699196492543; Sun, 05 Nov 2023 07:01:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699196492; cv=none; d=google.com; s=arc-20160816; b=q0MYEnu3sh4VE9F8VVYhGXMgWj/nilREGGviXwYdWebkyIFf2WaxNaDN8VTqtvJpDZ vtmF/qtEtC5NKQOssz/W+z8cpW+vpQ/X5sXBE7nTD/aHpv3aLJSCxFzCZwFs4p3w8cR3 iS2S+C7uJN4XBS5853GZlZC+aIx38AptK/k+oT8FTJKxdLoIjUbXH9jcgVfvftmPB9qy 2L3atrKLmnJ7MGhweSv+l2KdItYvmKulp3G8J9KdU4rNsgLBOhWbPUpCk60qJO1SEvab em+iXKN/9Fb7/xcSBm8I8c37z+7ZJ2d5Al+m7zEbaMxMAahocHkIpKlW9dw4KdUnvGvx sssA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version :mail-followup-to:message-id:subject:cc:to:from:date:feedback-id :dkim-signature:dkim-signature; bh=4MjQo55h4To9DLao6GrOz2Dpb9CF/KX7SNVATC19L+4=; fh=X/K9fo3OhTvDrVVIvfKUfsT76Iel+RlAA2+AG+903tQ=; b=012rBE2bWHoWPcg1jqvuHg76g6YUQMP47Hx/stLYO5LK6CX23hJppH0WA+Wy8BsJhg AL+yTe2GL91r909Hq1bUevKcoXIBcbisZ+2+tmVricMQ00UoNt4lE1bNbJtV+QSSkFxE Nk4ifu/GdmnG0rcZXlhBra1nlzIedQq75RegvT5jH2ga6frdh2FjDDFm8ZikCY36rljv JlYyCRdtzCRr7VYyeekJU4zV9MFWFmO9mmwYsqBAcagpGvAmSj4JkPx/SxKVTxUVPsh2 PXt8S7EEsb2iytgfQ2TTGpiTlwDcoXAyjOGmBYoE4X1W4CXwGenUMJaYZoby1M9KlbTW hx/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm3 header.b="Qj7toek/"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=c4Y2yPHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id u10-20020a9d4d8a000000b006ce2aaf0b4esi2506980otk.58.2023.11.05.07.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 07:01:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm3 header.b="Qj7toek/"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=c4Y2yPHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C01AB80859A7; Sun, 5 Nov 2023 07:01:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229562AbjKEOtG (ORCPT + 34 others); Sun, 5 Nov 2023 09:49:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbjKEOtD (ORCPT ); Sun, 5 Nov 2023 09:49:03 -0500 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09E3EC6 for ; Sun, 5 Nov 2023 06:49:00 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id C848032007CF; Sun, 5 Nov 2023 09:48:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 05 Nov 2023 09:48:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1699195737; x=1699282137; bh=4MjQo55h4T o9DLao6GrOz2Dpb9CF/KX7SNVATC19L+4=; b=Qj7toek/tEW0e1NeYcUvUT77iB C8h/DGj+ODoUs4xP5a6mlRh4jc9jTO2t1IHUPa5uSlM6dAJHHjjL14sX+5dUmuz5 cd3RmJYb5FgJs0GBa0q0mEMTWSe7wtsrF5ypyGjBtTBcxWeZP4qDXcCbVVUa0DwG 11ChG7mi+8HolQUBDSTkHCsy7I9Yr8XuXYbluwPiGaYyzBO5tLBfIShh4ZxfF3RY X7sg7EQLz/WpdZIRZLJwOa4HhQ7M3kfnV3D5mHEeur9h6Qzq3oRGE08sDPShkVJ/ NYIfAmE3sn2Tv960+kwc8xcMZbRdFOjV4T/FkPGKUrvgMgsntEIBT6cvX+YA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699195737; x=1699282137; bh=4MjQo55h4To9DLao6GrOz2Dpb9CF/KX7SNV ATC19L+4=; b=c4Y2yPHv1F3JPYY2mGVUZhmusxg1Ne1dPuqVVZsu3HyVDjT/0Sj R5aq8caZUk27bIbmOigFWh/TEuQ7WKucjsAw/oM/C6M4wZRbE91oAdT8zVNI/BlF /d1SRKtul0SDWDyIjGBw6PTP1C02vZaZksB1VN1U32ycPuyxBgd5XxoSCnksTOQc x83Oj737MKToMBwlyWDWrS1PdY0bPj4BPV2Nnb9JU541upGm2VaNa1F9HBuVOVdQ BmQoVKlM4cIwhvok6zcdIb3sMAg5iORg5UNhgqw5juVvYNA8RwoS4mrIg0XQ/F5c r9HUWYrLxjXkPGotOR7UbrO7TDQi8vylYoQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduvddgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfggtggusehttdertd dttddvnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpedugeehgeefvd elueekjedvtdehtedtledtjeehtdeigfefueffffehgfetvddukeenucffohhmrghinhep shhushgvrdgtohhmpdhkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrghkrghmohgttghh ihdrjhhp X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 Nov 2023 09:48:56 -0500 (EST) Date: Sun, 5 Nov 2023 23:48:52 +0900 From: Takashi Sakamoto To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org Subject: [GIT PULL] firewire updates for 6.7 Message-ID: <20231105144852.GA165906@workstation.local> Mail-Followup-To: Takashi Sakamoto , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 05 Nov 2023 07:01:24 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781736661285299463 X-GMAIL-MSGID: 1781736661285299463 Hi Linus, This is the pull request from FireWire subsystem. It contains a slight change in core function itself. I'm glad if you accept it to your tree. Allow me to report a regression of PCI driver for 1394 OHCI hardware in kernel 6.5 or later. When probing the hardware with following combination of chips on Linux system running on AMD Ryzen machines, the system unexpectedly reboots. * Asmedia ASM1083 (PCI bridge) * VIA VT6306/6307/6308 (1394 OHCI controller) The issue has been reported by users from OpenSUSE (https://bugzilla.suse.com/show_bug.cgi?id=1215436) and Fedora (https://bugzilla.kernel.org/show_bug.cgi?id=217994), and I can reproduce it on my local machine. The superficial cause of issue is accesses to Isochronous Cycle Timer register in OHCI control register space during the PCI device probing. However, the exact mechanism triggering the reboot is currently unclear, as the system does not provide any useful output. In my experience, this issue does not occur on Intel machine, AMD Sempron 145 machine, or with different 1394 OHCI hardware from other vendors such as Texas Instruments. While it's possible that there may be code issues within the PCI device driver, I think that specific hardware quirks exist in the combination of the Ryzen machines, the PCI bridge, and the 1394 OHCI controller, since I can see another issue of cache-coherence over DMA memory mapping in Ryzen machine with VT6315. Anyway I'm still under investigation and wish to find any workaround as soon. ---------------------------------------------------------------- The following changes since commit ffc253263a1375a65fa6c9f62a893e9767fbebfa: Linux 6.6 (2023-10-29 16:31:08 -1000) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git tags/firewire-updates-6.7 for you to fetch changes up to c12d7aa7ffa4c61443241fbc1ee405acf4aa17de: firewire: Annotate struct fw_node with __counted_by (2023-11-05 21:15:17 +0900) ---------------------------------------------------------------- firewire updates for 6.7 The pull request includes a slight change for flexible length of array in core function. Kees Cook provides a patch to annotate the array embedded in fw_node structure referring to structure member for the length of array. The annotation would be defined by future extension of C compilers, and used for access bound-check at run-time enabled by UBSAN and FORTIFY_SOURCE. ---------------------------------------------------------------- Kees Cook (1): firewire: Annotate struct fw_node with __counted_by drivers/firewire/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Regards Takashi Sakamoto