From patchwork Sat Nov 4 08:33:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 161557 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp1552556vqu; Sat, 4 Nov 2023 02:38:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSo4W9YuWBiwMLq32xIQwOoX/rXOpLTLyPoB3lKbeffMZUqj71TKu41iMDgM6xfTdXxgkG X-Received: by 2002:a05:620a:3d91:b0:765:3ca0:3708 with SMTP id ts17-20020a05620a3d9100b007653ca03708mr19484003qkn.75.1699090681971; Sat, 04 Nov 2023 02:38:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1699090681; cv=pass; d=google.com; s=arc-20160816; b=fAbjfRQ08TjotquNampPLIBUOOwHyeHUJi51Yq28t30F+l+5YReDrXgKB+edBJp+j9 L2FCPhSIFwDLS7rrU1R9ySrp7CQdVIkI7SjRzQ2NA5FQtYHktko+ijycUG2klI692L3P U4C1DGolOLpasPv5BRviiEU/sAqgEVYHA9eFos37NQho4lxyGZ1+prwo5lG+cjk4lsCJ e12qLVZ1OpNaMSZ9Ya2GXGoLuDQmVsUVp1P1D6NSirW0TsaUA1qw9muFg7OAaEEGHas5 LNF/sQzhBmsowK4L18BdAh5jKVyvcufsIIXvb7f9/3sSPtVN/kb6J+E0OiWDx9qp616f 4QyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=lNSure/Tc+1RlTcJv+eYJK3beLLodOI4QitSXOlj80Y=; fh=sJ+2/4g29YdyXkoRrFZSpsL2zxijepB7X/1rB0LDDh8=; b=YzYzKUj5OmjodFq/H5WQgoPUe22ex6oOnoOUbAFIeI2TPHbTjSgrEEt3BTCCJ3keZj ysKwacragcNI4aUxluWHG7jHDOF5lz0tlrXLcNhvHl7SOOWmnp3JGTc6NjjIPDCajmz5 vcgF49iLG4bX5bG4GEDNOeTtjC0xU1g1/jU3i5s3HUaACWDhJFClrV8c0ubcUwVYVN0j YcwDiG8UfbOJEz1s1S5RsZ5XSqZwLV18Ueaa1zbybS7EffB/wRJCdHRWyZ6m75rFCyl2 B1oCenVBLJAZ3mxVgspqb7rH3gNvk8ZL8blhyrErorCLEqI3sa+6oxSW4ZgBFlGQvuFW Kmaw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MRtNFnu+; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id v8-20020a05620a440800b007757acf4889si2845806qkp.1.2023.11.04.02.38.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Nov 2023 02:38:01 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MRtNFnu+; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C3C13857017 for ; Sat, 4 Nov 2023 08:34:23 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AF8B43858D32 for ; Sat, 4 Nov 2023 08:33:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF8B43858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AF8B43858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699086837; cv=none; b=lFytgX4wqOgFtDBuXDVgazX5UFTSk3zlUNRmod9L8zXZg+etLTZnvCNlRWUEML1kJJoBuGTP7HLtxtGxgio5MBnjRxL1wjmk1KtuhzlshykltvzYSCuj/ukxjz7nlNIMT1coasvToqalO2LyuHibLE1gpakz/wbsdskOmR4kk1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699086837; c=relaxed/simple; bh=JY1CK/fMMA3X3Kd/2HTbYYrAlS0PXz+7IgRq95O8dIo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iqwwObEIFzp4VLFCAXM014ksNlkCXA/j6aV0S4UnwPRkLtOCZEbXBwOeW3RdP4MV2OQGvxXLpjz/q6xhny1ORQyKEKUr/BeiJnadkTkzSJwrBhpoZMlGsoJ652i6mIlSa4efOdfo7jE0g230ThgWqbUdEXUjLBwf6/zFwOGv2Pc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699086831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lNSure/Tc+1RlTcJv+eYJK3beLLodOI4QitSXOlj80Y=; b=MRtNFnu+WRirV2c/zLt+Aacqros525Xorw31pQQk0DKG2VXzpBsuFNk24uwyN/iRuXg35V o9xJ7SyeRnd4I0CCad5PmbU/0PtSSG5EqDo33C8M5Kc6MJEOje0NIgVeIuibEaHz0SW430 Heb9Y2a8nOFRIBQhOv8vmtVQW5awYLw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-382-ApaWXFbuP8mN9RQrhKr0kw-1; Sat, 04 Nov 2023 04:33:48 -0400 X-MC-Unique: ApaWXFbuP8mN9RQrhKr0kw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4696F185A781; Sat, 4 Nov 2023 08:33:48 +0000 (UTC) Received: from localhost (unknown [10.42.28.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 120272166B26; Sat, 4 Nov 2023 08:33:47 +0000 (UTC) From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Replace "_N" in examples of naming conventions Date: Sat, 4 Nov 2023 08:33:03 +0000 Message-ID: <20231104083347.3015361-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781625711188135879 X-GMAIL-MSGID: 1781625711188135879 Pushed to trunk. -- >8 -- The name "_N" is listed as a reserved name on Solaris, so we shouldn't use it as an example of our naming conventions. libstdc++-v3/ChangeLog: * doc/xml/manual/appendix_contributing.xml: Replace example that uses a BADNAME. * doc/html/manual/source_code_style.html: Regenerate. --- libstdc++-v3/doc/html/manual/source_code_style.html | 4 ++-- libstdc++-v3/doc/xml/manual/appendix_contributing.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libstdc++-v3/doc/xml/manual/appendix_contributing.xml b/libstdc++-v3/doc/xml/manual/appendix_contributing.xml index 197c7d9fb40..a9196493adc 100644 --- a/libstdc++-v3/doc/xml/manual/appendix_contributing.xml +++ b/libstdc++-v3/doc/xml/manual/appendix_contributing.xml @@ -887,7 +887,7 @@ indicate a place that may require attention for multi-thread safety. Type names and template formal-argument names: _[A-Z][^_].* - Examples: _Helper _CharT _N + Examples: _Helper _CharT _Nm Member data and function names: _M_.* @@ -899,7 +899,7 @@ indicate a place that may require attention for multi-thread safety. Don't use names in the same scope that differ only in the prefix, e.g. _S_top and _M_top. See BADNAMES for a list of forbidden names. - (The most tempting of these seem to be and "_T" and "__sz".) + (The most tempting of these seem to be and "_T" and "_N".) Names must never have "__" internally; it would confuse name unmanglers on some targets. Also, never use "__[0-9]", same reason.