From patchwork Fri Nov 3 19:53:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 161443 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp1307445vqu; Fri, 3 Nov 2023 13:56:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEgGqTwrd1cmR0XNjFs3Bf5Bo0+t/33Xkja+ausW/oWbefefNbJ4OxEsgzwTNZePo8C7tg X-Received: by 2002:aa7:cf0a:0:b0:540:1824:b8d0 with SMTP id a10-20020aa7cf0a000000b005401824b8d0mr17580254edy.3.1699044993054; Fri, 03 Nov 2023 13:56:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699044993; cv=none; d=google.com; s=arc-20160816; b=e+nFMlJB9z+nuqont6A3EfVcrQ5wycOQHOTeaqfqtXAMYgWCrjNdddQWtmiFrTYSoo LKGKDpeIKYVWXlUeE9WsPFJT4ANNzaOOrRKSUnQyuh153a/T6KVV0ejJ/SiAAExkiukz naNasQOpQy6TIO/9wvoRdI5faGz64FxVuq0Iq1gX1VyQY0CI6fc9X+pxF0dzcIY9EX09 BD5s2MgP5CWpiY0JvYR85ucJlnnE/Jtnon8NzS/EVfH+HUg0HQuUpocp3RZup64Ok0uW bGtFZQetJ9NnwC4urTdMnZACBF/W5NxTYoLvek6Ip5z3F5IiNBqZH9Mrh8dACORLixnv Nj6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1me2CMdrf1upczPoXQDcBdEbAu6CUD8o+3lDid/MT8U=; fh=SvhOHfehUV8tt+/DHSWfRHpXzQQzyN3k16tgFjiVtw0=; b=EAOupxo/m56T99mXIULk6LeXxAg/qZnYGrc92M+LPTJV1vaSIdZswTE7TjfPJYknpg SRIZcwe+MQom/4v0hWAGUBVbk5CIioL9F0ZX3bvg7HGHLabYxGdF1Zl8afWXeJmdqUP+ sqIS8rR7/ZXgNJHccLMLwRIOrGFo/zfF8IxM44omIBm7ynCu4/K7TOwB4/2a6U9IpKrS Yy8kn6zZgUHTP7y8lZ4uke7m9u9q4YIM4bwVRDo8PlMsyIj0jExhvpZd5uvxwGRe0WAY 0SJ2lpbdmL0aPtdiQyBKnTJbUtTIP3XJXOv2Kiqgrd7hTyUOQzuzb7cO3E2/jaUzfErv IxjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lZFvyC88; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id d28-20020a50cd5c000000b00542def27bb9si1351916edj.238.2023.11.03.13.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 13:56:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lZFvyC88; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 67DE58312FB3; Fri, 3 Nov 2023 13:56:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230076AbjKCUz6 (ORCPT + 35 others); Fri, 3 Nov 2023 16:55:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234477AbjKCTxU (ORCPT ); Fri, 3 Nov 2023 15:53:20 -0400 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE7EDD4E; Fri, 3 Nov 2023 12:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699041198; x=1730577198; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=eUuuyUtQ+5betVlsnj9MIgKiK2+aM4+nMSQ8mwzd6Uk=; b=lZFvyC883EjBfQLF5PjSpJENPYHWPQCcvP1e5dyGvpzGxDj+WSFsdOJY Gu4nhdI+CqlYri2Vo2kZ5mX84YgPOPPbjRIdDsWCpUxBY/qSBtdROg65+ iHz/a3qALjcVOQEjEyia2yyKp+MApfUOc+zZf8IJIkK00iNW2KAS+aJKH H7M5Uu9OAK4oDJ0ky1AKxC3cihsNvmSB83Ym3TXqlimP8d7NkzsNbozcf dh3JPzpGXpY3XHviZoRs756vBYrJj4budD5wnhzVPOXrX2sNOraIBFIMJ ybIERmqSKZtbt7SEQRFck4yV34s4OqyhN9SIEByHA7GPuHFE7W740W7jK A==; X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="1962960" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="1962960" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 12:53:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="761719315" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="761719315" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 03 Nov 2023 12:53:14 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B1E775E2; Fri, 3 Nov 2023 21:53:13 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Linus Walleij , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 1/4] leds: trigger: gpio: Replace custom code for gpiod_get_optional() Date: Fri, 3 Nov 2023 21:53:07 +0200 Message-Id: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 03 Nov 2023 13:56:00 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781577802647148067 X-GMAIL-MSGID: 1781577802647148067 gpiod_get_optional() and currently used fwnode_gpiod_get_index() are both wrappers against the same engine internally. Since we have a pointer to struct device there is no reason to use fwnode type of GPIO call. So, replace the current fwnode call by respective gpiod ones. Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij --- drivers/leds/trigger/ledtrig-gpio.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/leds/trigger/ledtrig-gpio.c b/drivers/leds/trigger/ledtrig-gpio.c index 9b7fe5dd5208..d91ae7fde3cf 100644 --- a/drivers/leds/trigger/ledtrig-gpio.c +++ b/drivers/leds/trigger/ledtrig-gpio.c @@ -89,10 +89,7 @@ static int gpio_trig_activate(struct led_classdev *led) * The generic property "trigger-sources" is followed, * and we hope that this is a GPIO. */ - gpio_data->gpiod = fwnode_gpiod_get_index(dev->fwnode, - "trigger-sources", - 0, GPIOD_IN, - "led-trigger"); + gpio_data->gpiod = gpiod_get_optional(dev, "trigger-sources", GPIOD_IN); if (IS_ERR(gpio_data->gpiod)) { ret = PTR_ERR(gpio_data->gpiod); kfree(gpio_data); @@ -104,6 +101,8 @@ static int gpio_trig_activate(struct led_classdev *led) return -EINVAL; } + gpiod_set_consumer_name(gpio_data->gpiod, "led-trigger"); + gpio_data->led = led; led_set_trigger_data(led, gpio_data); From patchwork Fri Nov 3 19:53:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 161423 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp1283789vqu; Fri, 3 Nov 2023 13:03:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5ofolnvK1g3tMqOBZWNLsN25eROJhSLxOAnYDVP7X3NjfFt2fzi2tSrigQ/SL5osQ1SAn X-Received: by 2002:a9d:7d0c:0:b0:6b7:52ce:ff38 with SMTP id v12-20020a9d7d0c000000b006b752ceff38mr21683894otn.16.1699041825344; Fri, 03 Nov 2023 13:03:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699041825; cv=none; d=google.com; s=arc-20160816; b=FSh/jDX+LTGbiLk0NUUmxkxJHxqGhQxjIdpV65e+3nXGA9ZBl0P3g5f15og+axO2DD bNHIgLYrKmz49Co6JE0yrJJ4ZCnMvOVIwBXfLkovBLReN5uuNzSMloDBh0fFgp0hGgaA yApemfxW0HVhg1F2qZuSDAtdBhrN5/cYLWd5TR65WAL0zk6i6PtTFhNxha0OOTRjjygZ /6aq3TKjxvg0FKvHL8ykqgFEOvzv3aOen6IGG0BrwL+erGiI9YewfoR8OdzY5NfHeauj QTpZxSmCpXaTdzSXGVCSkE1qoYpCKP5xvuoIh7SHrr16Ps2SDbhsamsK8gzvlOIk8tJ9 aqeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qIFVGXdCLffn9mcTJTwcAJyWj7qYuhrQ17QQu5kprxs=; fh=SvhOHfehUV8tt+/DHSWfRHpXzQQzyN3k16tgFjiVtw0=; b=P7FNh3vnKjSz779UM8Krj/P0jqqz3XxTca5s7/7L5HzRKktFl1Gs87RmY5TphsIGay W7MeiRTISOBg7jONDzhvKPa1cAyfnSTbnNSPiacKBFckWMzFTII+Pp1l3/zeu2Y4Dtb+ cMjxBHcVAIh3GLknWWTWhgAJ/4zz9zBhNIlqxQcnmezjAC1FcnwG8UTWDfJWYT3tBfqP T86KVS4yU5DQJXLEnW0KpyjRF1cvkPGrEFM32uYr+SKs/nNFCpFmMvU2gtu3Z5JJxmOx Zw1TZSXDjkCLcdIsmXKOr1fBpPghT75e2KrO4dW25Gqo+cAX//HqLnGfShpnm1Q2aMag Ul6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="UNnN/AiP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id e24-20020a9d6e18000000b006b750ede542si909290otr.85.2023.11.03.13.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 13:03:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="UNnN/AiP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 86E1083DB94F; Fri, 3 Nov 2023 13:03:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378140AbjKCUDk (ORCPT + 35 others); Fri, 3 Nov 2023 16:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjKCUDg (ORCPT ); Fri, 3 Nov 2023 16:03:36 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8448DD53; Fri, 3 Nov 2023 13:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699041813; x=1730577813; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Nsq+DlizAAeSWWNzWMj45TaDhpGuvaTz6ItsP0chKHM=; b=UNnN/AiPim/QbC6K9V3TJSTv/fHdm3MgCDdkEQmgxzoBoDgES3ZGEAKz qPM3qgJxCR3OYErmgVuvZQNnzwZQuvtdp69stzuyMOJ2Ni2BfQcbhBiIW rq3Vs7zDixiHxZDTdSo4bwajL8jHl7SjcANnEKWXRRhtn1IzIG+XJjNw3 AndQPAbH1G143BI7KvZuDHHul7h9FnNkHGbvcPYhYHAGBwqWuigIJbOlM HulBxIzA6YKUiEqVaZ1GsBllI5ZXYch+gJ0X/gVCOw5kuc0abQyl7heHp 4SKM1jjb+7o/pCt2eN2wsINNi9rOoBTDS92Df4wx4pYPLfarmZHlVx688 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="1894389" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="1894389" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 13:03:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="832126756" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="832126756" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 03 Nov 2023 13:03:27 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id C26B82A6; Fri, 3 Nov 2023 21:53:13 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Linus Walleij , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 2/4] leds: trigger: gpio: Convert to use kstrtox() Date: Fri, 3 Nov 2023 21:53:08 +0200 Message-Id: <20231103195310.948327-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> References: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 03 Nov 2023 13:03:44 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781574481353388579 X-GMAIL-MSGID: 1781574481353388579 sscanf() is a heavy one and moreover requires additional boundary checks. Convert driver to use kstrtou8() in gpio_trig_inverted_store(). Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij --- drivers/leds/trigger/ledtrig-gpio.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/leds/trigger/ledtrig-gpio.c b/drivers/leds/trigger/ledtrig-gpio.c index d91ae7fde3cf..8a30f9228186 100644 --- a/drivers/leds/trigger/ledtrig-gpio.c +++ b/drivers/leds/trigger/ledtrig-gpio.c @@ -53,14 +53,12 @@ static ssize_t gpio_trig_brightness_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t n) { struct gpio_trig_data *gpio_data = led_trigger_get_drvdata(dev); - unsigned desired_brightness; + u8 desired_brightness; int ret; - ret = sscanf(buf, "%u", &desired_brightness); - if (ret < 1 || desired_brightness > 255) { - dev_err(dev, "invalid value\n"); - return -EINVAL; - } + ret = kstrtou8(buf, 10, &desired_brightness); + if (ret) + return ret; gpio_data->desired_brightness = desired_brightness; From patchwork Fri Nov 3 19:53:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 161444 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp1307632vqu; Fri, 3 Nov 2023 13:57:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtQ6Nv3LOBxERmk0WZRnlHCks2EMUmuT3i/A7S6kBiynsFhuA2TppV11gx5mw4XVNXTFIJ X-Received: by 2002:a17:907:6d03:b0:9be:e79e:c75f with SMTP id sa3-20020a1709076d0300b009bee79ec75fmr7426733ejc.18.1699045022159; Fri, 03 Nov 2023 13:57:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699045022; cv=none; d=google.com; s=arc-20160816; b=Hd0a/IfJyKr7HQDJ08XnZOtTeY6nk6BGDNXsS5vpuewAX59J/pUlPeJ1w96DuD/963 tkym0sHZ3o3gJXCixIMxi3Emv5AKScAcBcbXlnUUS1AjpeQk0uYRyzgV23hR0NmiXqDM ux1rcpvAwMgNCcEy+ROh22O+yaMfvxzYRv6QDSVun6Aep+9sxvTgjIoVDEvTg+RCPdv9 SFd+uOKPPG8BSLUlOGxEZij5kSz5eJ9zk4ghMbx+8fi/4dsSoYAuASZ2xCxfgDCVa2V2 3maQTxyvJ38mDjPSCaaZ3jJPgqyiO7l0aZMYLKbmVY//vXImAa7TVR20qpeqWPWgbLk3 0mWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OSZahsTgfzl8Q6s5PW8cn8oqc4FB83gwlvt7erLVdV4=; fh=SvhOHfehUV8tt+/DHSWfRHpXzQQzyN3k16tgFjiVtw0=; b=uU+mq2bGAcAK/kzU2uuRyfuz2JM8S9jwi8QXwTaTEfVUDA+pl+r+NLbxl8/HFZqQWQ 6n5Cn/nk4Oihkcn5C+RVqOq3twadZISqotnQuGqi+rowqR8yuxfKiS2Oo2v+SSyKrbRg KeoEiOFuv1cqPPSk3RBTGFqEG11WYz6nEP0XWJ83YK4eosz8pjb/d/fT8jQ49kYoPPbv PLpzTlxUWd2/NS0YVR6tFQEIBIXTGsQwDcUQCmFm0zehSzV8aKYdp1OiREYGDp0Ism6J dSmOz5UmzYd5bwobVedynzPiwhjyHv1kSR7olU/JiIwXgGTazcddRYcaU+oqJ3z8ozL/ kQww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=j7XwkUNJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id nb36-20020a1709071ca400b0098678728b52si1360638ejc.123.2023.11.03.13.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 13:57:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=j7XwkUNJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id EEEC68315564; Fri, 3 Nov 2023 13:56:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230332AbjKCU4A (ORCPT + 35 others); Fri, 3 Nov 2023 16:56:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378183AbjKCTxT (ORCPT ); Fri, 3 Nov 2023 15:53:19 -0400 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D0551BC; Fri, 3 Nov 2023 12:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699041197; x=1730577197; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=M2LYr3uiwRiw2hfh8eZTwB7i1h0z6rfdmlPTebmD3d0=; b=j7XwkUNJ9/9TsLf520/+Oq7tI0HVVk7sYI7K0eruNZwAHHTp5APL7stF ZVXqMFPr5J9hxpl56MZqOTuz7X8rVz02qvb7q+JwGhbazGD8vjv9j0Tgm BZkbTz6vSK1Q5goHNQWEjetBUCNSR147I8aNDCVlDiOsFgUYGSOZhDPTD M3CO2M/HdpYagw0KrFQxAF+UPwueJuYHdDSWEzmEqTPyTYYbQ8GrO38Iq bBPMNXOwGsfLszNJ195wjaFfGZqCewALS3ov//dt99aBXUDXqW2AJdZqT cXizvIKbCfllAC9U5mKGTWNUVwu1Bc1FhAAwkGk8g0rCK6aW+JzUdtaEp g==; X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="1962964" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="1962964" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 12:53:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="761719316" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="761719316" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 03 Nov 2023 12:53:14 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id D66EC5E8; Fri, 3 Nov 2023 21:53:13 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Linus Walleij , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 3/4] leds: trigger: gpio: Use sysfs_emit() to instead of s*printf() Date: Fri, 3 Nov 2023 21:53:09 +0200 Message-Id: <20231103195310.948327-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> References: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 03 Nov 2023 13:56:06 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781577833069855947 X-GMAIL-MSGID: 1781577833069855947 Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij --- drivers/leds/trigger/ledtrig-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/trigger/ledtrig-gpio.c b/drivers/leds/trigger/ledtrig-gpio.c index 8a30f9228186..8824be19881f 100644 --- a/drivers/leds/trigger/ledtrig-gpio.c +++ b/drivers/leds/trigger/ledtrig-gpio.c @@ -46,7 +46,7 @@ static ssize_t gpio_trig_brightness_show(struct device *dev, { struct gpio_trig_data *gpio_data = led_trigger_get_drvdata(dev); - return sprintf(buf, "%u\n", gpio_data->desired_brightness); + return sysfs_emit(buf, "%u\n", gpio_data->desired_brightness); } static ssize_t gpio_trig_brightness_store(struct device *dev, From patchwork Fri Nov 3 19:53:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 161424 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp1283980vqu; Fri, 3 Nov 2023 13:04:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/zktOFkmenufmwm0Mh6AD1a2L0csxU81vtiJ/gs/jYECZbpx12oqVyf+IY6zm1P7HGyLC X-Received: by 2002:a54:4114:0:b0:3a7:4e0c:faa9 with SMTP id l20-20020a544114000000b003a74e0cfaa9mr24063915oic.29.1699041846740; Fri, 03 Nov 2023 13:04:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699041846; cv=none; d=google.com; s=arc-20160816; b=ptjPehfupbNQl80PdKoPUostQ4zxOhO8Z2UzjuNOYkVOWZmADy1iJQ3I4GOi/0nKAz BE2JuufDwYArIwoczsrnk64N3mXK5heayKEZZRqfiHOTvpd2a8reG6ALY2Op2fOPTZ3H z7ooSRopoty4uGjuIg0P7OAq+5tCW/rFuzjhrwYw56+7rKQ3Zvucs4RCteM/MFbuU+0P la6I/FhC8uYtIKd0VF6N1C5IAERg1B5a87OTOL/nbMXKHuDoTI6q6KolI4P14dpkX6sG bTrpc2gndZkfmgxAgT+T91GR4gfxZMipaIf6kqIWctyI0ZvZ77h82SdgoP3t6EepnufE I22Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=z78kKeQXgFS/Os5AyLn1GXC6t5R/jRvIxwXveLt6lXA=; fh=SvhOHfehUV8tt+/DHSWfRHpXzQQzyN3k16tgFjiVtw0=; b=ux6RH6GjB9SewXKia02Ol3uStaI+zoTQRoQe+MPlcfkH27fbegHp/lLKdURIts1tQJ kGKQFp02Vf52wXwbSbLqKq5zG9WNLd8UIlykGl/v1atOd5OwkUFb1BSUcBsCdkeF7S3g alcqg/4N4ca4UXFV61ZkTbfHglPth4HTKds5o+vef9+LJNU/ntZwoSK79uW1Jcr+eW5A yUVdpdcV3ayh6modvsJlRe6YbOhV3zZVfMnZoSV2lAYxvXRiEHpdzM8o0Z+FHeC/c39A WQa3g+P4lAOomzXqGzesM3lUf6KT86eCRpdYqa+1abCK/rKaMpqNY2niaxASh/ZKFNpK WrtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ka5Ntg+C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id d20-20020a056a0010d400b00690c23d353asi2152283pfu.217.2023.11.03.13.04.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 13:04:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ka5Ntg+C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id CFFD582222B7; Fri, 3 Nov 2023 13:04:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229868AbjKCUDe (ORCPT + 35 others); Fri, 3 Nov 2023 16:03:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjKCUDd (ORCPT ); Fri, 3 Nov 2023 16:03:33 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BB1AD53; Fri, 3 Nov 2023 13:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699041809; x=1730577809; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IHEKAZwFkfBPaWXKiUvpj74KxQIC1qIeU1pZ07Sbhuk=; b=ka5Ntg+C7w4STO2qIpzuQFROo4DFF88qtg3GH56S9UtrlFwmoQPoxKLQ pzMD6vgeXBG7cbFntiBgtu2tOxS08LdLaEYXcu+G4NI0wUZdFmUdpCI44 MfkgsoqTGXCGEnyUVEVdUbzRj3chiMb3Gi4O/MaSIcuXIpCj2a65gMOH9 5s5NKgCxtkjnKzWdDGszJFlk+KHMhm85ftX0B6it+/hoIKYuuiDG4dq9s YRr0pcAMa6/F3+FRDassWoPl2S8jbK/MJ4XbrdD84DABk5dBTVfjz9G4z iRV6qlAkQg5X8tKfo4hUZWvuhNaiVUJggtHhtJi/fHXzJyAqmixmvFwWW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="420130012" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="420130012" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 13:03:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="905446864" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="905446864" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 03 Nov 2023 13:03:27 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id E5BE05E5; Fri, 3 Nov 2023 21:53:13 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Linus Walleij , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 4/4] leds: trigger: gpio: Convert to DEVICE_ATTR_RW() Date: Fri, 3 Nov 2023 21:53:10 +0200 Message-Id: <20231103195310.948327-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> References: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 03 Nov 2023 13:04:03 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781574503473167175 X-GMAIL-MSGID: 1781574503473167175 Instead of custom wrapper, use DEVICE_ATTR_RW() directly. Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij --- drivers/leds/trigger/ledtrig-gpio.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/leds/trigger/ledtrig-gpio.c b/drivers/leds/trigger/ledtrig-gpio.c index 8824be19881f..7f6a2352b0ac 100644 --- a/drivers/leds/trigger/ledtrig-gpio.c +++ b/drivers/leds/trigger/ledtrig-gpio.c @@ -41,7 +41,7 @@ static irqreturn_t gpio_trig_irq(int irq, void *_led) return IRQ_HANDLED; } -static ssize_t gpio_trig_brightness_show(struct device *dev, +static ssize_t desired_brightness_show(struct device *dev, struct device_attribute *attr, char *buf) { struct gpio_trig_data *gpio_data = led_trigger_get_drvdata(dev); @@ -49,7 +49,7 @@ static ssize_t gpio_trig_brightness_show(struct device *dev, return sysfs_emit(buf, "%u\n", gpio_data->desired_brightness); } -static ssize_t gpio_trig_brightness_store(struct device *dev, +static ssize_t desired_brightness_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t n) { struct gpio_trig_data *gpio_data = led_trigger_get_drvdata(dev); @@ -64,8 +64,7 @@ static ssize_t gpio_trig_brightness_store(struct device *dev, return n; } -static DEVICE_ATTR(desired_brightness, 0644, gpio_trig_brightness_show, - gpio_trig_brightness_store); +static DEVICE_ATTR_RW(desired_brightness); static struct attribute *gpio_trig_attrs[] = { &dev_attr_desired_brightness.attr,