From patchwork Tue Nov 8 16:40:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 17120 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2822028wru; Tue, 8 Nov 2022 08:45:12 -0800 (PST) X-Google-Smtp-Source: AMsMyM7x6dNoIQgwO3Y2t+ds163g2rw6SZyQqpnysCz3QTUL5HeTrsmjvYElZjXBR5AfZrvpM+1X X-Received: by 2002:a65:408b:0:b0:42a:55fb:60b0 with SMTP id t11-20020a65408b000000b0042a55fb60b0mr48805593pgp.431.1667925912362; Tue, 08 Nov 2022 08:45:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667925912; cv=none; d=google.com; s=arc-20160816; b=uMwprNrm/U7t7D1c2mg/6faFXQtXxjdyKG1O5UrJ53HR4BZXcs3ZDvzvLTDg/oW3D/ utB0pLoXLf+97N9PCkhS/yyWRSUOhdzOEB3NquKDMEwZMCrmoqErJ8i0NGO9kXGK27ZC DcdN05NimpWtM/vbZ2yfxNfHmFEgecJsVTXpS9rdIjSIi00TIi4YuhkKUBZAlod7b96R qchh9fSxTY9huKLvT2y0Bi8xq8s0kxwqgDjkNajw5k9LOoe/owQ+aROoQWDIDvXBpJZa vetwLze5VYNqJiPlgr750olaAPXc+kkNuGDyzLYmpvg9+IeHSBMsoxMa3i9w4CB5BKQt 6cjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=ivutUeWTK0CJ+o2CPgbrzrLMV+QgEolJCzL+6vUdD4Q=; b=Hr34T3l2Lgs81mVroKt6V8EIjNQIWcgS3RrYkmPlL3S6oJ4xl3coWRX+OaIyx2bQtm bo16lkh0nWMs+SdiU17XxD+V1+rFJfvW6a3+k7P/t9NGYcL1cpL1x6HwP9NyuLMeqcIL +OPEQn5UjpD4hLwQjb3dCE+LmL6ukeZD2h/VEL6CNXleAV2Wt8qkjcfTrblo1GlHAE/D m2s7naxOPO3Co21bAIcGHeA+Yv002f6sm5cyyow+f9jS74bZFp4xxsl8zZD0SddFp+zV ueXlVZTezB7hsbBRXg3q2Zz/JtodE4k+VBWK71nE6zOUAyeD92Uput+VCemYu/6okVmA KMQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=LLmilqOV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d9-20020a056a0010c900b00545c1d801d7si14475295pfu.364.2022.11.08.08.44.58; Tue, 08 Nov 2022 08:45:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=LLmilqOV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234117AbiKHQlC (ORCPT + 99 others); Tue, 8 Nov 2022 11:41:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234113AbiKHQk5 (ORCPT ); Tue, 8 Nov 2022 11:40:57 -0500 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A5F15654F for ; Tue, 8 Nov 2022 08:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667925651; bh=CX4oVKOrNdWOYtI9l2Y8+gBL/Y2CygsM47mBXzHKVKk=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=LLmilqOVqSFjWQeZUtJL9FcHWRGc4W76AJi7epIzUlkLx7nzwgfuMVH03rpgES3mp p2tljHDxIIT719Y9vQwYfyN8EyTn6uKM6Ia8b4cQYbVk3Y/MJbybS7OxICM3B4C8Oz VCdXnNnDA7/9F3k43+9+tRDR7un4GzLUTpQyjbEg= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via ip-206.mailobj.net [213.182.55.206] Tue, 8 Nov 2022 17:40:51 +0100 (CET) X-EA-Auth: EBQJzWEPGipJKFk91Zwiw38B3lm6GFO64bf+XrchdANOJCIC39lqpN0LE/7+13kgEhyD96yseuwjMuE66CmAqd2BQ1vFsr0V Date: Tue, 8 Nov 2022 22:10:46 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/1] staging: rtl8192u: remove redundant macro definitions Message-ID: <17f69a042e215c484931a0327fdf7775eea5f918.1667925039.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748947081462163361?= X-GMAIL-MSGID: =?utf-8?q?1748947081462163361?= Several ieee80211_* symbol names are extended with _rsl tag using macros. This is done to avoid a conflict when a similar symbol is already in use in another part of kernel and may lead to conflicts. However, most of these base symbol names are not found to being used anywhere in the code and hence are not useful today. These symbols are not used outside of the module and hence can be safely removed. The code continues to use the original symbol names. Suggested-by: Greg Kroah-Hartman Signed-off-by: Deepak R Varma --- Changes in v4: 1. Resubmit patch set with the remaining only patch. Update patch subject, version and patch sequence number to avoid confusion. Suggested by gregkh@linuxfoundation.org. Changes in v3: 1. The patch caused a build failure due to EXPORT_SYMBOL conflict across modules. Retain macro defines for ieee80211_wake_queue and ieee80211_stop_queue to avoid EXPORT_SYMBOL conflict caused by similar function names from net/mac80211 module. Correction and resubmission asked by gregkh@linuxfoundation.org Changes in v2: 1. Review other similar macro defines and clean those up as well. Suggested by gregkh@linuxfoundation.org 2. Revise patch log to explain impact of the patch Suggested by julia.lawall@inria.fr .../staging/rtl8192u/ieee80211/ieee80211.h | 61 ------------------- 1 file changed, 61 deletions(-) -- 2.34.1 diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h index 00c07455cbb3..c5c43d2fb93e 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h @@ -223,71 +223,10 @@ struct cb_desc { #define MAX_IE_LEN 0xff // added for kernel conflict -#define ieee80211_crypt_deinit_entries ieee80211_crypt_deinit_entries_rsl -#define ieee80211_crypt_deinit_handler ieee80211_crypt_deinit_handler_rsl -#define ieee80211_crypt_delayed_deinit ieee80211_crypt_delayed_deinit_rsl -#define ieee80211_register_crypto_ops ieee80211_register_crypto_ops_rsl -#define ieee80211_unregister_crypto_ops ieee80211_unregister_crypto_ops_rsl -#define ieee80211_get_crypto_ops ieee80211_get_crypto_ops_rsl - -#define ieee80211_ccmp_null ieee80211_ccmp_null_rsl - -#define free_ieee80211 free_ieee80211_rsl -#define alloc_ieee80211 alloc_ieee80211_rsl - -#define ieee80211_rx ieee80211_rx_rsl -#define ieee80211_rx_mgt ieee80211_rx_mgt_rsl - -#define ieee80211_get_beacon ieee80211_get_beacon_rsl #define ieee80211_wake_queue ieee80211_wake_queue_rsl #define ieee80211_stop_queue ieee80211_stop_queue_rsl -#define ieee80211_reset_queue ieee80211_reset_queue_rsl -#define ieee80211_softmac_stop_protocol ieee80211_softmac_stop_protocol_rsl -#define ieee80211_softmac_start_protocol ieee80211_softmac_start_protocol_rsl -#define ieee80211_is_shortslot ieee80211_is_shortslot_rsl -#define ieee80211_is_54g ieee80211_is_54g_rsl -#define ieee80211_wpa_supplicant_ioctl ieee80211_wpa_supplicant_ioctl_rsl -#define ieee80211_ps_tx_ack ieee80211_ps_tx_ack_rsl -#define ieee80211_softmac_xmit ieee80211_softmac_xmit_rsl -#define ieee80211_stop_send_beacons ieee80211_stop_send_beacons_rsl #define notify_wx_assoc_event notify_wx_assoc_event_rsl #define SendDisassociation SendDisassociation_rsl -#define ieee80211_disassociate ieee80211_disassociate_rsl -#define ieee80211_start_send_beacons ieee80211_start_send_beacons_rsl -#define ieee80211_stop_scan ieee80211_stop_scan_rsl -#define ieee80211_send_probe_requests ieee80211_send_probe_requests_rsl -#define ieee80211_softmac_scan_syncro ieee80211_softmac_scan_syncro_rsl -#define ieee80211_start_scan_syncro ieee80211_start_scan_syncro_rsl - -#define ieee80211_wx_get_essid ieee80211_wx_get_essid_rsl -#define ieee80211_wx_set_essid ieee80211_wx_set_essid_rsl -#define ieee80211_wx_set_rate ieee80211_wx_set_rate_rsl -#define ieee80211_wx_get_rate ieee80211_wx_get_rate_rsl -#define ieee80211_wx_set_wap ieee80211_wx_set_wap_rsl -#define ieee80211_wx_get_wap ieee80211_wx_get_wap_rsl -#define ieee80211_wx_set_mode ieee80211_wx_set_mode_rsl -#define ieee80211_wx_get_mode ieee80211_wx_get_mode_rsl -#define ieee80211_wx_set_scan ieee80211_wx_set_scan_rsl -#define ieee80211_wx_get_freq ieee80211_wx_get_freq_rsl -#define ieee80211_wx_set_freq ieee80211_wx_set_freq_rsl -#define ieee80211_wx_set_rawtx ieee80211_wx_set_rawtx_rsl -#define ieee80211_wx_get_name ieee80211_wx_get_name_rsl -#define ieee80211_wx_set_power ieee80211_wx_set_power_rsl -#define ieee80211_wx_get_power ieee80211_wx_get_power_rsl -#define ieee80211_wlan_frequencies ieee80211_wlan_frequencies_rsl -#define ieee80211_wx_set_rts ieee80211_wx_set_rts_rsl -#define ieee80211_wx_get_rts ieee80211_wx_get_rts_rsl - -#define ieee80211_txb_free ieee80211_txb_free_rsl - -#define ieee80211_wx_set_gen_ie ieee80211_wx_set_gen_ie_rsl -#define ieee80211_wx_get_scan ieee80211_wx_get_scan_rsl -#define ieee80211_wx_set_encode ieee80211_wx_set_encode_rsl -#define ieee80211_wx_get_encode ieee80211_wx_get_encode_rsl -#define ieee80211_wx_set_mlme ieee80211_wx_set_mlme_rsl -#define ieee80211_wx_set_auth ieee80211_wx_set_auth_rsl -#define ieee80211_wx_set_encode_ext ieee80211_wx_set_encode_ext_rsl -#define ieee80211_wx_get_encode_ext ieee80211_wx_get_encode_ext_rsl struct ieee_param {