From patchwork Tue Oct 31 02:02:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Su Hui X-Patchwork-Id: 159919 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp2623954vqb; Mon, 30 Oct 2023 19:02:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjuX9tmHHLu8h9yD1SPRIqPgyPy0TegxwFf4SUpaiC/qmuG3rRGVR6ivHvwPWjZvbF1Qgi X-Received: by 2002:a17:903:41cb:b0:1cc:51ee:5faf with SMTP id u11-20020a17090341cb00b001cc51ee5fafmr1986463ple.7.1698717758868; Mon, 30 Oct 2023 19:02:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698717758; cv=none; d=google.com; s=arc-20160816; b=UECCWyVWsRo2DquE9GuDt+5cAJn8Sg+l/g2zOTIucSLR6FY24r8uPgNijZNKKz+W8y UPXn/dPgVrvlMADrEQJEfKfP1Nys6pcL/ny8xDzPVuBtJFCsvtc2TN3aE6W+HiEwSwfN x+2y9M8Mq+4L6cosHXVvi8uAf4wpjFn2rzjXL+rL9fIlK4fFsn7G6oUhKAiJeeRsHOcm /tbcdeq2jrFJfDjjp+WudeaLwFgd/xGK3Vo2i6R9CtAn+gsb4X8ddMWPmTkkxAjArteN pSNeWjr0qp5Wys0Ba/aQppV2GpzeAecbOp4LrCNvw2irPVZLGWTdCiSuE9LqE+caLY69 kZHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=2e05wAQucDDa9mWwKjjIa07jWp6VWRiSAAZ9s3v00zY=; fh=8UaxSWDhEUo/pS6gbKd+WAgNfGX+wttHxT2zfgMR+tM=; b=c7QfC03vUkx/NXYLcrAYeDI6lCwl8EQwVkPOHeQk1WFYTBbUd8eKVG7H4wOvAsFaXn P4A9AgmQpquBaQGFUPEPehQt1zb6sZjcfYa9KRLgoM0AxIEFvDkDn9LPgtsahpihtNwd z/ka9bMw5hLCun9D56DoQpCar0qP4hZ0UcJh1mX90xOsl0oMFQT7/2pTb61fG9sjryyr ud1U8WRsgpZcygxdRs/o/Z64PlHEEgjmGJ6okJ7NjylNCSgzhv9Qhn5vYopev8S8gtBO W991QKmnmYvQLD0ebvANWCLABXlwu37D6OFoChX2TjJvnnoNMQVbgi+031l8r5NEf1pG 1M7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id k1-20020a170902c40100b001cc385b457asi271529plk.284.2023.10.30.19.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 19:02:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 98D1F8042A92; Mon, 30 Oct 2023 19:02:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230336AbjJaCCY (ORCPT + 33 others); Mon, 30 Oct 2023 22:02:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbjJaCCW (ORCPT ); Mon, 30 Oct 2023 22:02:22 -0400 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 3059CFC; Mon, 30 Oct 2023 19:02:18 -0700 (PDT) Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id 6E688602A9D36; Tue, 31 Oct 2023 10:02:13 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: mturquette@baylibre.com, sboyd@kernel.org Cc: Su Hui , mike.looijmans@topic.nl, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] clk: si5341: fix an error code problem in si5341_output_clk_set_rate Date: Tue, 31 Oct 2023 10:02:00 +0800 Message-Id: <20231031020159.587686-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 30 Oct 2023 19:02:34 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781234672463194620 X-GMAIL-MSGID: 1781234672463194620 regmap_bulk_write() return zero or negative error code, return 'err' rather than '0'. Fixes: 3044a860fd09 ("clk: Add Si5341/Si5340 driver") Signed-off-by: Su Hui Acked-By: Mike Looijmans --- drivers/clk/clk-si5341.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c index 9599857842c7..9b1cc5a83b5b 100644 --- a/drivers/clk/clk-si5341.c +++ b/drivers/clk/clk-si5341.c @@ -898,7 +898,7 @@ static int si5341_output_clk_set_rate(struct clk_hw *hw, unsigned long rate, err = regmap_bulk_write(output->data->regmap, SI5341_OUT_R_REG(output), r, 3); - return 0; + return err; } static int si5341_output_reparent(struct clk_si5341_output *output, u8 index)