From patchwork Mon Oct 30 05:23:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 159477 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp1995637vqb; Sun, 29 Oct 2023 22:24:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEOL0FecPpvFeF79LSSsfpm994mwUKPhlrAjImgyzg62Shl5Fd6WS3YAOuzUDOzaEdYwuRP X-Received: by 2002:a05:6a20:2307:b0:17b:4f43:afd1 with SMTP id n7-20020a056a20230700b0017b4f43afd1mr5414097pzc.58.1698643460856; Sun, 29 Oct 2023 22:24:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698643460; cv=none; d=google.com; s=arc-20160816; b=GZ2cjm77bPRsZmjPNPGS6aOVYJIWiuFvf+ytDvowe79ebCLGSU6rlBKvZqw5f5NYL4 Scx1gPjOyAeOpwztRFFXYyJvih+5+DSAQ845U/7a5sMEBygR1FegCir5td0lCLz4kckj BosCuVzOXHOPSxAzK1Q5C+WdS83LLpYTCWp9WC1LTGXKRatTlolhT74ouEwRMKlrxFTS BgaWSFqSrpYP+BItEbMS7JYjy5m2XxQ+BSjx16akRqyogrtVENu6YI5bm9gaC6t5pi1v Q7TbvHRoF5UgFTmTF0yjAlLNbSL8eHaAdsePakQ3sv6AEnYf7WU8Mhttb3rAW+ASYTut CmlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=9+a7BC6UJtWqe3uLYYNaXR+EPpx3wfaWGb5tXSIqBf8=; fh=AZiTILNvZVUWrq7+Pivc+8oqCIaN1OIDMW3ey06c+3Q=; b=JyZv/UsAFaBwWmiD96CVIf4crx5OohAGyvvOXWNt2OTPA98D+NZea6NE7EEazCjhJV 24+7XLice0GHFdp2cvw9XsAYx1lY0ZDXDfw++HGmEAQXBs09xr5K3whXasi/HAQXPiM6 tRXq5P18FiGS+ZfLETLt2HtUZMC/I6KZAExKbbiwAMZJRBvWFNOm4wNNDVf5Qqm3BVqo rbS/KnGsj7vzGNMG8O0G2bSOChXcAD/XJ2fY1arEJig9FSEquVcbGjxu4H/PloePolhq NuUxqlS8+PckgjDwkzXPnTnG9/PnsmFYaQ/QijTikolLTvy5bfqgN07iGnRU6vtyHzOv 5U/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id f18-20020a170902ce9200b001c4749ee72csi4571051plg.503.2023.10.29.22.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Oct 2023 22:24:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id D3F148062087; Sun, 29 Oct 2023 22:24:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229923AbjJ3FYD (ORCPT + 31 others); Mon, 30 Oct 2023 01:24:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjJ3FYB (ORCPT ); Mon, 30 Oct 2023 01:24:01 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B08890; Sun, 29 Oct 2023 22:23:58 -0700 (PDT) Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id 0746380EE; Mon, 30 Oct 2023 05:23:55 +0000 (UTC) From: Tony Lindgren To: Peter Ujfalusi , Jarkko Nikula , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Andreas Kemnade , alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: ti: omap-mcbsp: Fix runtime PM underflow warnings Date: Mon, 30 Oct 2023 07:23:38 +0200 Message-ID: <20231030052340.13415-1-tony@atomide.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 29 Oct 2023 22:24:18 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781156765677070065 X-GMAIL-MSGID: 1781156765677070065 We need to check for an active device as otherwise we get warnings for some mcbsp instances for "Runtime PM usage count underflow!". Reported-by: Andreas Kemnade Signed-off-by: Tony Lindgren --- sound/soc/ti/omap-mcbsp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/ti/omap-mcbsp.c b/sound/soc/ti/omap-mcbsp.c --- a/sound/soc/ti/omap-mcbsp.c +++ b/sound/soc/ti/omap-mcbsp.c @@ -74,14 +74,16 @@ static int omap2_mcbsp_set_clks_src(struct omap_mcbsp *mcbsp, u8 fck_src_id) return 0; } - pm_runtime_put_sync(mcbsp->dev); + if (mcbsp->active) + pm_runtime_put_sync(mcbsp->dev); r = clk_set_parent(mcbsp->fclk, fck_src); if (r) dev_err(mcbsp->dev, "CLKS: could not clk_set_parent() to %s\n", src); - pm_runtime_get_sync(mcbsp->dev); + if (mcbsp->active) + pm_runtime_get_sync(mcbsp->dev); clk_put(fck_src);