From patchwork Tue Nov 8 06:42:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomas Marek X-Patchwork-Id: 16887 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2526717wru; Mon, 7 Nov 2022 22:50:55 -0800 (PST) X-Google-Smtp-Source: AMsMyM5Q5yOsPYo0fpUnUqk7pH5PzLwRmyMgBTvXJJX/VYEbQVgCNVKHLDY8kGCjeFSTC1eOVIFJ X-Received: by 2002:a17:906:81c6:b0:7ae:7b1:df60 with SMTP id e6-20020a17090681c600b007ae07b1df60mr30121712ejx.87.1667890255099; Mon, 07 Nov 2022 22:50:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667890255; cv=none; d=google.com; s=arc-20160816; b=AEYfkZySTcQldC+PQVqUgMMaWC9GftCLedh+M/mvK8q7aQzUddf42e7RZUgIQ/5JDM 92yvpXMTSfRhk5MvBwOrZRcy1yLkCf86kCgVRb0iGUbYuTXGHhAzmI1QAA5pZrVzfM3E kZGJRlEyfD+tMy50fEOXnaIFToSlCtqM+j+7ZS81HwNa1c2Lip/7yG5dYepxsmSLrt9p vYAT7JdPB2zf/hnHM4zA/me0ij3Nik6xuidbqo7bBn3WOuQwoRTw+PNZbHh223gOWzP+ gqbXOlWRh7E7jaKmY0RioRPgyBTsRcrdGSaDfL+sEn75z/kkUWHWX2yCVg+VvjesnVH2 VtJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=cZap3Bl4WjpJer4YXahm/BwiRDpzjo0K7prZZ/zyzYc=; b=aMMi/pp9YdwZcVai/kp6vdJJB1QWo9tu0X/OZC4a1tfgv9oo8kr2SCldWwx3qLNfSc puqHgZc3t6Zqli9JZeiTSj60thUOl70D2H67usQ3TVdkaMb+BOd/xjPNkBKO+NhjmjXG nKZLGJZDB21SfCZGA/as+cMjJ1/ID3f+FbAHbo9geLdGVxHiHgB4SMpntbNk5PkBpCan D0XHTk9OpGb1YIL6Gdb4y84/qvw9v6K8esE0pJTrQY0H/9smF7fxJcEXYXHXEL3HuR/Z NTVkcbBK5l53o+6RfmfoVxHOhPP91ZCdEr4WJc7FciP/dWC0cEf48sE04xLwgOVGw7kY uuaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@elrest.cz header.s=rampa2-202208 header.b=vqNnAkr6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=elrest.cz Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oq19-20020a170906cc9300b0078772382b35si8903275ejb.91.2022.11.07.22.50.31; Mon, 07 Nov 2022 22:50:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@elrest.cz header.s=rampa2-202208 header.b=vqNnAkr6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=elrest.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233216AbiKHGnK (ORCPT + 99 others); Tue, 8 Nov 2022 01:43:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233499AbiKHGnF (ORCPT ); Tue, 8 Nov 2022 01:43:05 -0500 Received: from smtp.cesky-hosting.cz (smtp.cesky-hosting.cz [IPv6:2a00:1ed0:2:0:1:5bef:c8ee:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25C3A27CED; Mon, 7 Nov 2022 22:42:56 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at smtp.cesky-hosting.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=elrest.cz; s=rampa2-202208; t=1667889774; bh=V9/jJPJ9a+5GSM47PiAdHLQKBlIKHvofJMorNo6oRy0=; h=From:To:Cc:Subject:Date:From; b=vqNnAkr6B/J3zlhwmAFZMQz1PCVkrCGqIn/7icCoiGTrjKwWpJ1Sna3UGkFrRJdFQ Eg42cjIgpqbnRiYebkdn9z/ADFOa1RNXWIusvZRo0Rg1yAIfPrgrmhztrL/kOj1nmn 6e+i17SjVA7tGeNSu3vpqz7CS5ldXeoqo2aNWez4qfCi5Rq9TO/a1YHMsvs7nP9R5z 5hzD0WRJIj7+gVBUG2tAwx555r/JXWuf88bff9QV8hZqem0Jfe/BOz6APXHQkEkt6l hFbcF7MGlfKXHfPKLDEms75Kg9T0kH8PhGprNaoM5oOhKoJxi7onw2T28ObzbkxxO2 wASwghYQgo5qA== Received: from localhost.localdomain (unknown [5.181.92.50]) (Authenticated sender: tomas.marek@elrest.cz) by smtp.cesky-hosting.cz (Postfix) with ESMTPSA id 2882078B; Tue, 8 Nov 2022 07:42:50 +0100 (CET) From: Tomas Marek To: mpm@selenic.com, herbert@gondor.apana.org.au Cc: mcoquelin.stm32@gmail.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, alexandre.torgue@foss.st.com Subject: [PATCH] hwrng: stm32 - rename readl return value Date: Tue, 8 Nov 2022 07:42:40 +0100 Message-Id: <20221108064240.30878-1-tomas.marek@elrest.cz> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748909692218740747?= X-GMAIL-MSGID: =?utf-8?q?1748909692218740747?= Use a more meaningful name for the readl return value variable. Link: https://lore.kernel.org/all/Y1J3QwynPFIlfrIv@loth.rohan.me.apana.org.au/ Signed-off-by: Tomas Marek --- drivers/char/hw_random/stm32-rng.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c index 366edda4848b..a6731cf0627a 100644 --- a/drivers/char/hw_random/stm32-rng.c +++ b/drivers/char/hw_random/stm32-rng.c @@ -49,13 +49,13 @@ static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool wait) /* Manage timeout which is based on timer and take */ /* care of initial delay time when enabling rng */ if (!sr && wait) { - int ret; + int err; - ret = readl_relaxed_poll_timeout_atomic(priv->base + err = readl_relaxed_poll_timeout_atomic(priv->base + RNG_SR, sr, sr, 10, 50000); - if (ret) + if (err) dev_err((struct device *)priv->rng.priv, "%s: timeout %x!\n", __func__, sr); }