From patchwork Mon Oct 23 19:50:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucas Karpinski X-Patchwork-Id: 157084 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1517581vqx; Mon, 23 Oct 2023 12:51:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHz7l5c8cWfU/2QWPdRKcxUcjSSLahLSMHkDz00UYH/KdlEFYR2KefCiawe42zUpeVgvS4e X-Received: by 2002:a05:6a21:3e07:b0:15d:b243:6131 with SMTP id bk7-20020a056a213e0700b0015db2436131mr524617pzc.44.1698090705384; Mon, 23 Oct 2023 12:51:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698090705; cv=none; d=google.com; s=arc-20160816; b=Anm/mRxvY2m4xZHiS6RWKX1wMvkc+WZRXcZRntjxJG7+UxKY5a56x19dW3bO9pC5sJ GQol7IT9ObyQke55qvlL7qP6rBXh3xRMJAJDtVwLLeWElDeOYEsxBve/yCl0Eq1xg+Mx LMXclauscGdQP2ByB0hE2X0GzYw0RvPSBFcbvHeRMWWIkoq2OeIulUd9gaSCEmdcezGW z4cs9Pe0UFlfzH536fOd4vooJdJPHufoOme33KeFULbtrNSlr92/5GWHVllaoXqZE1Yy EOR89CmoLdRuYlEFytbY1k0Yj4HFgoaLPnEw13dQA9wdyb3/OX6yKzVwGfo78ahUq6SO 48Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=BZb3Bi9C2CsxxaJsgQZxAvcW9+sG5uBGA13Qc4GB1N8=; fh=qwWQ5TZtzVwhPoNI/LUbvH7isGEdeMFyasRsdv5N8WY=; b=bdmultyIT9C5RR0mCg/bG1OwulFYxWRYbh4QticcZ12mRX3p+bv3IgzxUNxMQl8PMy yCg92ozTxfIirGftn460dkt6VdDR3AMaZ8ocMJUfO2//ZB4FvM70jB67uVXrXcOtrrxi /tixTijhxmFyqFNzilpv2lql+bcouvIKja1d+mVPPt5wncp2l5lx7mSGxhjAOG8lLzTX hGDDh4t23ys9oSFeEB2+zhl8MMNrATgGD5NrTYK7R90FAZ1Qh7dTFkK9ebfHW7z+5BwO Yuf21OE86uyQinQ4Jb1r3KqIllita0MvRNfXI/09LosuplzpB6ZyvGDd3lNwX3x4Il55 badA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LbjR1RQK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id d18-20020a637352000000b005b87be63da6si6213436pgn.488.2023.10.23.12.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 12:51:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LbjR1RQK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0D4D080621E0; Mon, 23 Oct 2023 12:51:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229829AbjJWTvd (ORCPT + 27 others); Mon, 23 Oct 2023 15:51:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229900AbjJWTv1 (ORCPT ); Mon, 23 Oct 2023 15:51:27 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12E0AB4 for ; Mon, 23 Oct 2023 12:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698090637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=BZb3Bi9C2CsxxaJsgQZxAvcW9+sG5uBGA13Qc4GB1N8=; b=LbjR1RQKm06wxVwtUJDuK1UtnS6RiaP3vsyYQeiZJ7BVCxwhwAmM2Wu8DmBMOHut6m6iWD Gvsf80mgkhNKA8z9uMvz3gjxLBq4j7Ydd1kSY9DlVe0abHgTEcBvZATh31QO80BBLWj2dX iFnGA9FqNPDF5d6X9tOfDu32B+JaVHg= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-191-Eua95rmQOKqKtfnOmOYvQA-1; Mon, 23 Oct 2023 15:50:35 -0400 X-MC-Unique: Eua95rmQOKqKtfnOmOYvQA-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-774382db0a5so408620685a.2 for ; Mon, 23 Oct 2023 12:50:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698090635; x=1698695435; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BZb3Bi9C2CsxxaJsgQZxAvcW9+sG5uBGA13Qc4GB1N8=; b=mT5EzhvzdGHb8qjS1DTCl0OG0gJmlGKGKNKWBks+aeLkG8kdZ2K6p5v7vo9OUlkUIs b9r0O4meAyZqRJDzLtcZ77YEpSemUGet9PC5pTy0Xn0bjtCaSFUynvlXy1yRmWNLdYoJ YCprWI8Gd1+HMyQ7Yxh/WP2/nFZQcw8RlXIjsB5acrhg0j7+GZE7A8XBPwfN5hP4OP81 Yyf0yZxbJZGLGlQBn70fsaXTxDyzKY3ufFFP+vZhXlvC/SU9fe1PGTaztaMXIrwFpYOG lJG09d0uEuKBVjyzaYWmysCwBk1REQ1dksPgu3hHSIxTWYhesrZg47QZz5B1HujiPnXq I98A== X-Gm-Message-State: AOJu0YwEtRh6OdNeV+lglMu0BXZJj3O+C/XBRRGEZWra0XLq3CbbCKhu G2AJdHW42SaHeyfiYBqz8WuiGkjoWLGaKzuAKQxeo2RE9yjqnQDMPC2F9wjl/w8v3RTxv3XvEEG D1be2hJWccuEe73U/VRC/tM1h X-Received: by 2002:a05:620a:3189:b0:778:8fa5:41b7 with SMTP id bi9-20020a05620a318900b007788fa541b7mr10578540qkb.53.1698090635281; Mon, 23 Oct 2023 12:50:35 -0700 (PDT) X-Received: by 2002:a05:620a:3189:b0:778:8fa5:41b7 with SMTP id bi9-20020a05620a318900b007788fa541b7mr10578524qkb.53.1698090635030; Mon, 23 Oct 2023 12:50:35 -0700 (PDT) Received: from fedora ([142.181.225.135]) by smtp.gmail.com with ESMTPSA id s13-20020ae9f70d000000b007756c0853a5sm2921616qkg.58.2023.10.23.12.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 12:50:34 -0700 (PDT) Date: Mon, 23 Oct 2023 15:50:33 -0400 From: Lucas Karpinski To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests/net: give more time to udpgro nat tests Message-ID: MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20231006 X-Spam-Status: No, score=0.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 23 Oct 2023 12:51:43 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780577159322528613 X-GMAIL-MSGID: 1780577159322528613 In some conditions, background processes in udpgro don't have enough time to set up the sockets. When foreground processes start, this results in the bad GRO lookup test freezing or reporting that it received 0 gro segments. To fix this, increase the time given to background processes to complete the startup before foreground processes start. This is the same issue and the same fix as posted by Adrien Therry. Link: https://lore.kernel.org/all/20221101184809.50013-1-athierry@redhat.com/ Signed-off-by: Lucas Karpinski --- tools/testing/selftests/net/udpgro.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/udpgro.sh b/tools/testing/selftests/net/udpgro.sh index 0c743752669a..4ccbcb2390ad 100755 --- a/tools/testing/selftests/net/udpgro.sh +++ b/tools/testing/selftests/net/udpgro.sh @@ -97,7 +97,8 @@ run_one_nat() { echo "ok" || \ echo "failed"& - sleep 0.1 + # Hack: let bg programs complete the startup + sleep 0.2 ./udpgso_bench_tx ${tx_args} ret=$? kill -INT $pid