From patchwork Thu Aug 25 15:01:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 762 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:ecc5:0:0:0:0:0 with SMTP id s5csp281777wro; Thu, 25 Aug 2022 08:02:43 -0700 (PDT) X-Google-Smtp-Source: AA6agR5BGvQvnQiuJlKNGQHK6XKLlNf07Ml4XS7Ff3pMXizFQUIyxXoesxuQ1WzjI36sje3G//QY X-Received: by 2002:a17:907:e8b:b0:73d:9c6b:1804 with SMTP id ho11-20020a1709070e8b00b0073d9c6b1804mr2752995ejc.553.1661439763409; Thu, 25 Aug 2022 08:02:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661439763; cv=none; d=google.com; s=arc-20160816; b=GHvu7C6fIItoXRF8Iq5CemYS1aTglHrJ/cbQ87bylDz7RdsXttIOgBrypu1tmEkpIQ KVpRmldtBuR+m8LBWyhHKPSl2MOwUFmq9oi3qs14MNVNZZC3wVYir+NrbgothXgU5tqS DIxacQUjK0heW8dCQJym0icqBvf8JA9BeQuGUklmRPUnZPGfvoPDIzRG1pjpS9j/wz6M jTRxPzJ+F408q4hDfkgVW56/yENpAIQj9krzgdMBh2/sePezm/EDZGuaIyN32KsulzGr RPPsPRmtmPR56v/G4E9BHTt6v6yjAAs0ryuVsBY2MvDxA+39b9ZZ6siHWGZM+GvXzEh+ A5uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=JnPrq0Ail2bbOjTtxZH6ygU+evVulUUCDFeYGSvuxw4=; b=ZsTaHg7dF5Wy/s793G6v552XeTCFF+8kYrHj13YJPkfiOQwQ6ofg6J4ZS8/poY5Pgq 5UiZBtPIt1r6fIdhQScyLvJAHiN0RmyXcwuAeS3T8zWVRyX9JFKnt0V76uSdFNivBJLj H9y5nb8Pa6hgozdY00NHZBjUE6XyhBUDbd5GIpicnH7PyJzHd4tAgoMYsaMINh+Q/pW4 Rf6CPPIdxr3vJ4lu8EALFwVuiWgq1EtHXWCRG6aen3MdktzB9irgb7wt+BNMFtYtFZxJ DM3zdIaUH1KI0uXSyd5D3acMkx5KWoFmjiDwNEt+SvBDG51z4zkF7U5wPhJC6mEaQRDO YCaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=YptT8f6h; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id z22-20020a05640235d600b0043b59c69ac9si6011803edc.65.2022.08.25.08.02.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:02:43 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=YptT8f6h; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 24EA2385C401 for ; Thu, 25 Aug 2022 15:02:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24EA2385C401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1661439762; bh=JnPrq0Ail2bbOjTtxZH6ygU+evVulUUCDFeYGSvuxw4=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YptT8f6hV8PzPfTxMySmo+LDR282WDwxV/0X8NIcxrXtw4O9h1lhxJzUjp7bUIi7C jYYTxjzIepIxAz2oSSYBuOfcovme9S99A3RaxV0fbYmOnTx1FZ8wCX6IWu6+Eu1DlH dHV9ySRWGwTkVV0fa6ajTigEvG8PHmgDyoZrCJQA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id E44283858C2F for ; Thu, 25 Aug 2022 15:01:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E44283858C2F Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D026520C6C for ; Thu, 25 Aug 2022 15:01:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BC5F313A8E for ; Thu, 25 Aug 2022 15:01:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 06G7LOKOB2OwWwAAMHmgww (envelope-from ) for ; Thu, 25 Aug 2022 15:01:54 +0000 Date: Thu, 25 Aug 2022 17:01:54 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Improve uninit_analysis::collect_phi_def_edges MIME-Version: 1.0 Message-Id: <20220825150154.BC5F313A8E@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1742145861259039882?= X-GMAIL-MSGID: =?utf-8?q?1742145861259039882?= This avoids expanding an edge to those of a PHI def if it is not may-undefined, reducing the number of compute_control_dep_chain calls. Bootstrap and regtest in progress on x86_64-unknown-linux-gnu. * gimple-predicate-analysis.cc (uninit_analysis::collect_phi_def_edges): Only expand a PHI def edge when it is possibly undefined. --- gcc/gimple-predicate-analysis.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc index 079e06009fd..0d973a9e25a 100644 --- a/gcc/gimple-predicate-analysis.cc +++ b/gcc/gimple-predicate-analysis.cc @@ -605,11 +605,7 @@ uninit_analysis::collect_phi_def_edges (gphi *phi, basic_block cd_root, { gimple *def = SSA_NAME_DEF_STMT (opnd); - if (gimple_code (def) == GIMPLE_PHI - && dominated_by_p (CDI_DOMINATORS, gimple_bb (def), cd_root)) - collect_phi_def_edges (as_a (def), cd_root, edges, - visited); - else if (!m_eval (opnd)) + if (!m_eval (opnd)) { if (dump_file && (dump_flags & TDF_DETAILS)) { @@ -622,6 +618,10 @@ uninit_analysis::collect_phi_def_edges (gphi *phi, basic_block cd_root, } edges->safe_push (opnd_edge); } + else if (gimple_code (def) == GIMPLE_PHI + && dominated_by_p (CDI_DOMINATORS, gimple_bb (def), cd_root)) + collect_phi_def_edges (as_a (def), cd_root, edges, + visited); } else {