From patchwork Mon Oct 23 16:05:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 156963 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1397226vqx; Mon, 23 Oct 2023 09:06:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtSP9h8PqJ3hmj7e6wI34OT//YdX8upDq03e5UzgaeakroUnDO1qHwN4Ii5YhVYCIdAjkb X-Received: by 2002:a05:6a00:84f:b0:6bd:b3b9:649f with SMTP id q15-20020a056a00084f00b006bdb3b9649fmr11424559pfk.7.1698077192357; Mon, 23 Oct 2023 09:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698077192; cv=none; d=google.com; s=arc-20160816; b=AAeBGacTQF9bUclyqqp3p14jZjErPSinTSM0yI0QniSgMdHOF5yLO88wrww32rzDwz AeAxzm+RkZrlDJ+cuK+SCUrDBcJRZAvXAkWxVHG68gRe08F2g16scLQb2MYfI6CTmYVE 7i/rYP0lOL+L++lUl4oDkmifuAI8824mLlJ19uyHEimHtW+EPpwtOoTlUIut/oLbVTcQ njpY5uXuryq1nTm/0HEs2MXtECPnPHdIXnmYZ18JSE7/h53QOkhGK2ppvv+2tK6KZs00 djQZkGmrrF2cNpckLiHUlFX+fOOthnKsjpuqBXRGdJoG8T0clgHDL4rAZMN+jBMsWVqb eMdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=s5SCwWfOIQ6220GajhkiboNtdSuvP3xvmLo5FVgY9x4=; fh=PU2XAJLNWGeVyB4Y7WsAvzTXOGVtgVL6qGs3oEaf7AE=; b=q/getfJUjWNPpDsICGsM3LQfs1Z5Is+/RMmRqDclX4gyeZw4C3kTRMxn+2QgCgN6Ey R1kzFcHEyk2NbB+GI3MkEq5P4oVGBhkE73hd1UZlljImJ2MsT4ZpI4d5BVAJbsGYQdlM 9id4XGCS8kolffl3XBwnzqhs+iNedz1V/rpDcSVol01vKJeHKaD5xZu3fXgu7/ozgHji gnqHAHEv5wsPICQHphsqE5uE9ixiya6yoLU+9svTcEH5LR7zCQEyvQetes38bOxE5LIz R8DAgwo6gV2IVjIUitcm1jsqEqUdqSFnssAlKNCPyvg6WWBRKrxKdDaYl6MwgI0W/nn4 aRNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YOvXabiO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id g6-20020a636b06000000b00578a98c0687si7038281pgc.99.2023.10.23.09.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 09:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YOvXabiO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7C86D8092DA8; Mon, 23 Oct 2023 09:06:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229512AbjJWQFt (ORCPT + 27 others); Mon, 23 Oct 2023 12:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230519AbjJWQFr (ORCPT ); Mon, 23 Oct 2023 12:05:47 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F78510A; Mon, 23 Oct 2023 09:05:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D854C433C8; Mon, 23 Oct 2023 16:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698077145; bh=rC/hNZ7Bswy153IHNZJNcZBlr9hop+G6Sg6aUKxjdIg=; h=From:To:Cc:Subject:Date:From; b=YOvXabiOgl0nH2oPF9hfgJhkEJP+UUFp0h9KGCfx88oPj6u6WfzTBffoVLAWwFkUQ /r6lXvTN2pi/mjokglO3uUrDRNCuIxaAkmOL1L4egSVv0boGU9kmN/e0BVksgEngpK rj3xv41RK+MXX1QUkSdbNjV3b1Wq88e+qakIoWJFdGNEk5behSD1BBk6txm7dcEIqm xa45GHtj1Umi4uRUAfmXpyQV/udasf+RYsglGut5t9DB7D+FRfFCE9FpkjG6Mk+lTi RnF3PYmo5ccnkN7Ua77vb+Rx16ZTpNsFNgyCASyd3HjN4BAAhiVPVC2uJEV6QjfNpJ KbCskka5IO7Yg== From: Arnd Bergmann To: Martin Tuma , Mauro Carvalho Chehab , Hans Verkuil Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] media: pci: mgb4: add COMMON_CLK dependency Date: Mon, 23 Oct 2023 18:05:31 +0200 Message-Id: <20231023160539.1537355-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 09:06:06 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780562990370898783 X-GMAIL-MSGID: 1780562990370898783 From: Arnd Bergmann This driver fails to build when HAVE_CLK and COMMON_CLK are disabled: x86_64-linux-ld: vmlinux.o: in function `mgb4_remove': mgb4_core.c:(.text+0x1915e8c): undefined reference to `clkdev_drop' x86_64-linux-ld: mgb4_core.c:(.text+0x1915e98): undefined reference to `clk_hw_unregister' Add a Kconfig dependency to enforce a clean build. Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver") Signed-off-by: Arnd Bergmann Reviewed-by: Martin Tůma --- drivers/media/pci/mgb4/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/mgb4/Kconfig b/drivers/media/pci/mgb4/Kconfig index 13fad15a434c..f2a05a1c8ffa 100644 --- a/drivers/media/pci/mgb4/Kconfig +++ b/drivers/media/pci/mgb4/Kconfig @@ -2,6 +2,7 @@ config VIDEO_MGB4 tristate "Digiteq Automotive MGB4 support" depends on VIDEO_DEV && PCI && I2C && DMADEVICES && SPI && MTD && IIO + depends on COMMON_CLK select VIDEOBUF2_DMA_SG select IIO_BUFFER select IIO_TRIGGERED_BUFFER From patchwork Mon Oct 23 16:05:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 156962 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1397224vqx; Mon, 23 Oct 2023 09:06:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxNEu8hiIcXtAwGgE9Q90B5+HmahHNiwWf0r6BtwT9ELdAL7PTUf9RVUoRRBv31Pc+BjxC X-Received: by 2002:aa7:900b:0:b0:692:6417:728a with SMTP id m11-20020aa7900b000000b006926417728amr15782400pfo.14.1698077192458; Mon, 23 Oct 2023 09:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698077192; cv=none; d=google.com; s=arc-20160816; b=araqyjiHjyrrD5JQMlnEmHu662gx+zFJSVUdojTtZHdeoVhFy1hxF9bG0XxwWOU+YS 9HPH8ug5yA5u1SRYNcqqYw3U2A3GYbkKKDoOdUXOeD5fpXMiHfnRVltzIdLx5G2HRdPH 7aOoheRSvJtE1ey890+OH6qGb2bhJd45CyU6WyoQXgukjBaqCd8adV/Q4v99q76SX6Ws rpYdplR0PfmI5FW7SkC08UKjGQQE2LiKPk3dwKz6Q668TyVPcnCqvT4Vb1M0MJ1osDDb 1NuSVvE9NCXEw3TUbx9p4VRG4drf7O4QL2GeecP7wzQ2YCTOw+PjcVO8bvMB239rJRVM SlpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Bz87jYUzLh+FX65i0DPntoGJ5vgU1vVglGkHGZGfs3k=; fh=PU2XAJLNWGeVyB4Y7WsAvzTXOGVtgVL6qGs3oEaf7AE=; b=SHNjrD6INrwvlhPoa/rQ9cvWh2jOXR2JzcZVfBFTCbIivM3HQ4fxeo9vI0PmbHd0Yj KLplSvMqdg4PzWh+XcFTA8sQ4DIsF3onWvoFwbJGg89xZRNqe2UU77/kNkZpVB2l/ArV Bw9szujU50qh+ygM70JkWtr5geNh8GW5eKKQYJBIyeKShjtGGPUSek5JuzrslDBf7dOh dNph0BH/90/gev+MnthgSCq6cociuqN+3nBXZPO79SPMkT2T8cfNMlgUs73JJQ7HZDi3 tIXEWwn2qZ2gEaZz3FxczBY2WTkGgLf66auTVRfD5DeuXo/2rXrGVkHOCNCCvTHJA1Q4 Zj/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CDIxQ4aX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id d17-20020a637351000000b0058986c3dc2fsi6441220pgn.117.2023.10.23.09.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 09:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CDIxQ4aX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B96B580657E2; Mon, 23 Oct 2023 09:06:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232185AbjJWQF6 (ORCPT + 27 others); Mon, 23 Oct 2023 12:05:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232454AbjJWQFy (ORCPT ); Mon, 23 Oct 2023 12:05:54 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1585910D; Mon, 23 Oct 2023 09:05:53 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41DB4C433C8; Mon, 23 Oct 2023 16:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698077152; bh=rsdBpDp3RXcMnY1Y8bJLNbH0IoXz+q0JDXqgZCh8R3o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CDIxQ4aXY28mYhgeBoKUkAaWIKehUEhKwHGVdlqPlHjBx8ZACUP0ilYGo5EUNmauI 7oArSePao6D3uH3ld0IL84YcNO1B4VWzszoiT0pPsKsdNEfgyvYAEu0P5npvOGyAuw 6DmfRN9QEH1FUMkbYAuybaOozq0EliKV3SSODPhDBePi21UoncKecE8nsTyKXW8uMv hOtykMbEFxhkg95hTh6w1O7R5MWHz2JyPCMn1UnfZcUApeqBl1CiYwTPR2dkSEvy+d +J31ChpnJOBzoexxVqNKx3pzpSvvRlnivjAOQJ7pwlCo/Qre9OKpyk9tNyTUkMloB3 d4pjfvyLsgxYA== From: Arnd Bergmann To: Martin Tuma , Mauro Carvalho Chehab , Hans Verkuil Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] media: pci: mgb4: remove bogus 'select' statements Date: Mon, 23 Oct 2023 18:05:32 +0200 Message-Id: <20231023160539.1537355-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231023160539.1537355-1-arnd@kernel.org> References: <20231023160539.1537355-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 09:06:08 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780562989894512674 X-GMAIL-MSGID: 1780562989894512674 From: Arnd Bergmann As this is just a regular device driver, it has no business force-enabling other drivers in the system, it should be entirely independent of the implementation of the spi-nor layer or the specific DMA engine. The IIO symbols that are selected here are library modules that are legitimately used. Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver") Signed-off-by: Arnd Bergmann --- drivers/media/pci/mgb4/Kconfig | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/media/pci/mgb4/Kconfig b/drivers/media/pci/mgb4/Kconfig index f2a05a1c8ffa..b90347c7f19b 100644 --- a/drivers/media/pci/mgb4/Kconfig +++ b/drivers/media/pci/mgb4/Kconfig @@ -6,10 +6,6 @@ config VIDEO_MGB4 select VIDEOBUF2_DMA_SG select IIO_BUFFER select IIO_TRIGGERED_BUFFER - select I2C_XILINX - select SPI_XILINX - select MTD_SPI_NOR - select XILINX_XDMA help This is a video4linux driver for Digiteq Automotive MGB4 grabber cards.