From patchwork Mon Oct 23 13:58:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 156892 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1314468vqx; Mon, 23 Oct 2023 06:58:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+D/A9CTt3fBRCHX80IS1OroDvnAQpElNF5tt/dAEtnf3PHKRWJs/8yTdmvGYPqr2sN4N7 X-Received: by 2002:a05:6a00:99e:b0:6be:265:1bf5 with SMTP id u30-20020a056a00099e00b006be02651bf5mr8051179pfg.24.1698069524928; Mon, 23 Oct 2023 06:58:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698069524; cv=none; d=google.com; s=arc-20160816; b=RKSbZ4yZgQb4nNKIPHt2z8ZvYjlWMPddykDR+Rutg73Rz3kYoKQFHlvQ0lnMemREqm Y1zgxy2RBvsrxGvIv1RxRMKsA0dG0nl17vILEcVx5r9SRE1IU6RSP8S9SD7XjzQsWdOy bmtbLo/QrxAqgXkXprkfObfCH2Kx4mavk/yisx9I+X+CAdGKRuVgcT4/SCpERfY+JaJR 5MdsJKMWpWvPy6/UwQBaxJ2lkuVHUnaS2VrI2T0kP1fl1bNR5o5DvkTqh4FUr5B9l3JC 9pShuHupjcPzYQTHH1m9FX5/PLwypk4yJDSFWPYbm7lqut8Nfgh83bNtyS6hOwXS73qH 1Rxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TUDrbA7z4Yp0QmwWdKitAt1oZzrzXyIRbjMblpzWv7M=; fh=CU+qFPfH66g0YmpS6aJP4wI78gd80Nbl4tWLeZcOQoA=; b=N6dBmI+BZC//Oi3Is5zuBNoTcrtOwpX3wBJKssufMKcXUk+UQO4gff0jBxyTHe9Z8o kBsM26SAg1HfxuHuyW5KoGm6CahXFUSvZ5hdWVlaf9KlpIV89fIcN/nHOVLSuaYsparS sMjnDMVkfWEOBBVG3Mthv3paoJM/XhHT96Wvq9N5bXHGdgnZcBQsZTUJbFaaaav4WLjJ njOwqryd2ZPLph5glJbnsIjS7X5FmOO0eRYYKmNKi6KGxr0BtcPiS9IknoA1G9s4YQH5 YOBkPo6oKJ227JDJMumVG6GDZb3zPUCwhW7o5TXc/FJLmqPRrk0uzhgy7STz4M1kiUHX Okpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=IRhFfryp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id y63-20020a638a42000000b005aad9763d8bsi6310845pgd.422.2023.10.23.06.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 06:58:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=IRhFfryp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id E84388062BB6; Mon, 23 Oct 2023 06:58:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230465AbjJWN6e (ORCPT + 27 others); Mon, 23 Oct 2023 09:58:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230427AbjJWN6d (ORCPT ); Mon, 23 Oct 2023 09:58:33 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E997103; Mon, 23 Oct 2023 06:58:31 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2c5210a1515so50303421fa.0; Mon, 23 Oct 2023 06:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698069509; x=1698674309; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TUDrbA7z4Yp0QmwWdKitAt1oZzrzXyIRbjMblpzWv7M=; b=IRhFfrypKU/9/J53PrS8feiYQA3RT4F4YNkr5pMuh8paex7gVCCJ7IyMxH6eXl0B2A Z8LSQjzyCIiLqssj+UWe5ScEuh5oE0pl7wPMzi2Sg93LrkxXQjAVyUHgs69Izr6L1yat HwgAyDgfygL48hQUjT9rLiswjJk/6hGjGc+VuuUdsr8fQJB54rs0jdyD1txKobFdcLVj D/++hDlF/1MDdKhvvhM4BIksw0Khek+QVHly5HRPJ0KqmufWXGWxMUTh32eiClWB51jt xm5ESSs5Z4uHXh79UmaDXl1uYF0W+DkXDqnO+YQNRamkhQ3ThwpkLjrqmM/ARH6Hmu9Q ALPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698069509; x=1698674309; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TUDrbA7z4Yp0QmwWdKitAt1oZzrzXyIRbjMblpzWv7M=; b=Exl5ijBB51ZO3oRU7Wh2iZZkQl+yJid7jrOF2O/Fc0RYtiZviJvby2nZhU6bbkDZya U1Kk0Y/4QcxVTp44vK/LdG7sTQX6KLc3YJ3TA9cqHiS77y9C8eN8FBttduemmZEDDh2z 69F6VQ9cQPHfkj9HxFVxvKJG7iiO7iZozNRLlREy/9U6NsNMHMK014FvfgG+Bn+Ud3Xb PMNFn+ekos3WcRigjw3uicq30VbaJE5vfG8TUhzwCupYm680bbSEu2RYV/m967E7rkG8 CFbParldH0ZpdCBmm9TF57h/HLhhou94LOx3wUuScnnSVN4kwWY7inSegpkzRMLagPTf Qgeg== X-Gm-Message-State: AOJu0Yw20mKikhaxHIY3pmHSndglIseoIS56nzRZo4iTA1orHZezqMTs D1DRDw9C37WrVAY3d3kugaw= X-Received: by 2002:a2e:9b87:0:b0:2c0:3186:8efa with SMTP id z7-20020a2e9b87000000b002c031868efamr6612649lji.11.1698069509129; Mon, 23 Oct 2023 06:58:29 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id p15-20020a05600c1d8f00b00402d34ea099sm14316895wms.29.2023.10.23.06.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 06:58:28 -0700 (PDT) From: Colin Ian King To: Andre Werner , Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: HS3001: remove redundant store on division Date: Mon, 23 Oct 2023 14:58:28 +0100 Message-Id: <20231023135828.667297-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 23 Oct 2023 06:58:43 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780554949838013421 X-GMAIL-MSGID: 1780554949838013421 Currently the local variable hum is being divided by a constant and the results is being re-assigned back to hum before the value is being returned to the caller. The assignment to hum is redundant and can be removed. Cleans up clang scan build warning: drivers/hwmon/hs3001.c:65:9: warning: Although the value stored to 'hum' is used in the enclosing expression, the value is never actually read from 'hum' [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/hwmon/hs3001.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/hs3001.c b/drivers/hwmon/hs3001.c index ac574e46d069..01ea9a3062bc 100644 --- a/drivers/hwmon/hs3001.c +++ b/drivers/hwmon/hs3001.c @@ -62,7 +62,7 @@ static u32 hs3001_extract_humidity(u16 raw) { u32 hum = (raw & HS3001_MASK_HUMIDITY_0X3FFF) * HS3001_FIXPOINT_ARITH * 100; - return hum /= (1 << 14) - 1; + return hum / (1 << 14) - 1; } static int hs3001_data_fetch_command(struct i2c_client *client,