From patchwork Fri Oct 20 10:44:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steven Price X-Patchwork-Id: 155996 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp964029vqb; Fri, 20 Oct 2023 03:46:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcJaKGa93W8U4EdSZcIz5vRZGH7v/mdQ6rIWOre/iCHy9Pl19vj2llX35cWPFNInTTg4DI X-Received: by 2002:a05:6830:1e69:b0:6cd:942:25c5 with SMTP id m9-20020a0568301e6900b006cd094225c5mr1479796otr.22.1697798800070; Fri, 20 Oct 2023 03:46:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697798800; cv=none; d=google.com; s=arc-20160816; b=IexWYJBKv7yHzMlCnCmv3zk4yp+nwnU/YQmjG+zQBzuVSMItdxCTsACrri4/9puliV H3uB08Qh/jkX82cKAooVTAif1XkFqOdbDLrVPIzE9Q+IxjSwkBB8/ojmYOAtznLzPkrd ayPBV4RauORHm9646pROWS+9pf+ONpWO3SNALGB5sk9htm/04Jm+ZgFruL4EuKjXR/na vJg0l4j9MkaiE4mCvbiwzVCk9vuK5M1jpWrUmX4/ynIgydODfzJrWl07KxYdcbyccw4b CqvajECfuSWafpWQNoRUNC5TWwgCiXc4r3yr07yr9Yy3rtTS0uctoABDYiYhAqOMBq4t ItsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=OmSHY2sqQ3fzdkjohBWCkoloDorACCoo1uvNlgfYJxU=; fh=qu0d9QoE7nTizpodKaDk97THYkZX6zRDZn1j+RYMd+4=; b=0Zh9rwp+N2Opc9L2ZApKeP7MyZ5E6XABS4MTyNC54mCb2IwaTvWAV6CTIUOiONgDhp jbayR2sI7XQOmJebWhpLAZs7ErzSbxNpx8x1MqdxSId2ONRCFWpuiq9sTLI9VhtjHBCf MkFd7c2OAQTWp8GWpAXeZplRmYBqlQa+DCWEboPtvRQuLwWvlnXNh0MJXIYlJFAE4fNe A5RgQM6YQFfKoefyvyVjGnD9yppWcKXRhMVgXk5dQDJBx5FiITpgTTURz83QCZwVchUP UxCPu8VRqUAxR4NuzX3R5uolcnRt2Fk7P43FiwLioDePCXQZhWWLkL9XSU5mNo1uu8Ae HIHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id k205-20020a6284d6000000b006be2f4171b6si1617528pfd.151.2023.10.20.03.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 03:46:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 346178092D86; Fri, 20 Oct 2023 03:46:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377109AbjJTKpu (ORCPT + 25 others); Fri, 20 Oct 2023 06:45:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377184AbjJTKpb (ORCPT ); Fri, 20 Oct 2023 06:45:31 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 610921BF9 for ; Fri, 20 Oct 2023 03:44:35 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8D792F4; Fri, 20 Oct 2023 03:45:15 -0700 (PDT) Received: from e122027.cambridge.arm.com (e122027.cambridge.arm.com [10.1.34.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 390923F5A1; Fri, 20 Oct 2023 03:44:33 -0700 (PDT) From: Steven Price To: Boris Brezillon , Rob Herring Cc: Steven Price , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?utf-8?q?Adri=C3=A1n_Larumbe?= , Dan Carpenter Subject: [PATCH] drm/panfrost: Remove incorrect IS_ERR() check Date: Fri, 20 Oct 2023 11:44:05 +0100 Message-Id: <20231020104405.53992-1-steven.price@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 20 Oct 2023 03:46:17 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780271074898728793 X-GMAIL-MSGID: 1780271074898728793 sg_page_iter_page() doesn't return an error code, so the IS_ERR() check is wrong and the error path will never be executed. This also allows simplifying the code to remove the local variable 'page'. CC: Adrián Larumbe Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/376713ff-9a4f-4ea3-b097-fb5efb685d95@moroto.mountain Signed-off-by: Steven Price Reviewed-by: Adrián Larumbe Tested-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_dump.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_dump.c b/drivers/gpu/drm/panfrost/panfrost_dump.c index e7942ac449c6..47751302f1bc 100644 --- a/drivers/gpu/drm/panfrost/panfrost_dump.c +++ b/drivers/gpu/drm/panfrost/panfrost_dump.c @@ -220,16 +220,8 @@ void panfrost_core_dump(struct panfrost_job *job) iter.hdr->bomap.data[0] = bomap - bomap_start; - for_each_sgtable_page(bo->base.sgt, &page_iter, 0) { - struct page *page = sg_page_iter_page(&page_iter); - - if (!IS_ERR(page)) { - *bomap++ = page_to_phys(page); - } else { - dev_err(pfdev->dev, "Panfrost Dump: wrong page\n"); - *bomap++ = 0; - } - } + for_each_sgtable_page(bo->base.sgt, &page_iter, 0) + *bomap++ = page_to_phys(sg_page_iter_page(&page_iter)); iter.hdr->bomap.iova = mapping->mmnode.start << PAGE_SHIFT;