From patchwork Thu Oct 19 13:51:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 155571 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp397028vqb; Thu, 19 Oct 2023 06:52:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGJQ1leZB6kMWO6htfQHWq5fUwZMS9mabc51Oj36oWwTwSLxpU4h+8pcjsTU+3L8ih2UCG X-Received: by 2002:a05:6a20:8f26:b0:15e:b763:2422 with SMTP id b38-20020a056a208f2600b0015eb7632422mr3091310pzk.9.1697723523294; Thu, 19 Oct 2023 06:52:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697723523; cv=none; d=google.com; s=arc-20160816; b=bEPgXkLBCYG7IkZjMC6geYKyuuae/nsW0w71YsxxHkdCmTT934YzLRhUHFQXQFo+uV /BdfDCcllV53SXsL/4thP/asEd1MmiTW/NmgQo8TszV5bN4fSLmOjH1B+QftzT6lQCis RwE+CfKYiG/7LW1bxYhlZq51iTp2JHEZdj9jCuC69wnqnwR0M2zMzqJ2F8+3mCwNxUt8 5tyhkNa8IZfYV6WJShcGnDuy+5lnU3ZlPNYxERuTvG/oQZD08AMiH3wnP0PEH1xuvUxR 6ssTSz6hBSvC4aLQdpGENnQmWthfMSN17mkSw/aWB4Fmae8BtzYk6OWPOHTbLAaPEO/1 RdKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:ui-outboundreport:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=0cTO0LjibRlHCOqnOvdZr1w+0K/pyS7AOknUdHQ6zVQ=; fh=U4qNHu9JFslKfu5J/2k0+Md+ER+Pu7Haju2kMuMO3dQ=; b=YTAsTNeq3ZvPIOPLsMcUEDPkIkiC4URL9YdTDDaL0HaAvSz/V7wz1lYrsrP2ebPLt9 xN613SB04EIjonjSDHQKEu5cTn4P4THnfEu0dp6VT8U6YIu79SjSPq1FuPX5pO24EMNX 3JZSeBXm/XMe4bLFby6UpbNUI6CFVl+eY5zg36AbSlmIA9Ixzruf+lm3byUee/eGLk3M BMY/Tx2ok66oewFvs+MVnAIfxXfLJyF6mEOI3xFj8f+BdHf8UkigRwzKHxTe40ReAGAr kHV0bE2/NzfhcpdGvG6G/kvLHGPBcGp8eHcvJsEaxLC4umneQ8ysUMmJ2TON5bRFjEqw IFgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=TpAgjHZN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id bw18-20020a056a02049200b005a019d60ffbsi4937830pgb.78.2023.10.19.06.52.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 06:52:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=TpAgjHZN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 9C150822D14D; Thu, 19 Oct 2023 06:52:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345725AbjJSNv4 (ORCPT + 25 others); Thu, 19 Oct 2023 09:51:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345774AbjJSNvz (ORCPT ); Thu, 19 Oct 2023 09:51:55 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7929B9B; Thu, 19 Oct 2023 06:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1697723485; x=1698328285; i=w_armin@gmx.de; bh=AxltyYmFHaymahO+4+pGheB+ct+TZ7Uc/Q3HcmAQ28w=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=TpAgjHZNerr30oSXW9odupHfYqOyzpcTTylA5GZdPCoQxg723mOm/enu/+NbzYpz 7Iq7OtCWCk9w4K8XPUuxB2YY2D4xJlZ6E8zugUt8sNfubK6z99YMqu/krMuVDho/h 14b9Mn84oCbwdd6nPWW1RhEH+/tlAk/a2xC6WLPrjLATPVXw9t7ych08O+I9GhW/l pe2geY7+8lHgYJXkF2WldbFf1oLS0y0M3Srh8orjQfcGq+xtFhWQ1PeB5DzjvUNRZ bczhgrsO/vHRuuHMSpAG3Q1rN03Z/WIkWR5oiWky7WIImSJW0HP9mH4Sn4XSYM/nQ TiD31H/SdrcuBysQQA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MdvmY-1rUSPS20ZS-00b3j5; Thu, 19 Oct 2023 15:51:24 +0200 From: Armin Wolf To: naveenkrishna.chatradhi@amd.com, carlos.bilbao@amd.com Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, markgross@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86/amd/hsmp: Fix iomem handling Date: Thu, 19 Oct 2023 15:51:22 +0200 Message-Id: <20231019135122.21774-1-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:YSzIdPZ1K/kTuZ6D+lnJIC7iviBFVYhoLVUKouTZNBO4YXyhq/o 0BerRQS13EMJ1MqKY5ZGjTSXhZxvCbCp8q9qEw2NT2G3xFB3gOI3puxHGKZQ4FITX0giT+p WUNfRrlQfbn+1oVxJ8f9Q84HDnUm/YlA4XLuYiNdU+DVh0xuvW64l0ZzXhRY8bHyj37OqOV 27JgN3kVCo5vtIay69wow== UI-OutboundReport: notjunk:1;M01:P0:QxefclDEr/8=;EXIQQAbNvfU7ZWdsarCUokZIjbp OCtv9V4HEvbcs2Q00/0G87U1lDZk5cyeE+JvSWFxPbqiL+WxJHz6//QaoJVJPQlboihEu75vh D9WdnFKtMyo9ZLAC/vjzvQySryUUghxQARkQm+m0MhIh3CJXixPeN+W3Uznjc3WJMxVtpunxX l7XweQZ009hi3HyEaZ4kysOAgUwllJxZRl/SDCwzYjfqtI0/eoC8oi2KfOX94Y2oeoyEdIzeL EKZCgPbhYYz02wPsFm0lfSPwjoNy6+WX0y51SWa4KHEBrwQv2Vomk0Eoi4rYtctXE2fbIuQ8g 3FV6f8MImJmVddHeoU+Rbyl1KrWI/J5eOo8A9Bo32AHHjUmZq9Nzse3UCiRa0Ozf0HbN1wmH6 U22LUvduqTLK0aoWchSn7kicLgdTrNkBoc++pWcz5Yq7VCTS4l84DDvztqub9E0lsYsbCK5pA tO7cgkmnSwWVh10+0arQokVXds163KNv0kAjpPRODlGL9XY6HQASI80GkOplbrnzLyEE2k88O fT+4tVvUSfMVW4dQ7XIqtFu87P+Ao11rKKK//ek28O6PG62rGgnGYEusCZgYuEZUYacvcuLCz Apdb81V8LfwFHijvLprqoy6pvtPLLf+QgmTUsWwS64IAebKqEAceHuTvkKw1VjeVNj9tJnGfd Aoy3IlOnHkD5AePePRN94NkfXG38PsR301M+yW+jnqAykJVI/4BRcfpn6c7T281A09qyS6+6m SR4gGJ5GzqnvrSviLiAYdeVq2SIRn01WHjH+0k/LDduYFHLYPsh2jjTjA4QJdYrfeCVw+P+RF Uf X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 19 Oct 2023 06:52:02 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780192141196459374 X-GMAIL-MSGID: 1780192141196459374 Since the metrics table is marked as io memory, use memcpy_fromio() when copying its contents. Compile-tested only. Fixes: 5150542b8ec5 ("platform/x86/amd/hsmp: add support for metrics tbl") Signed-off-by: Armin Wolf --- drivers/platform/x86/amd/hsmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.39.2 diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c index b056a5c8654a..b55d80e29139 100644 --- a/drivers/platform/x86/amd/hsmp.c +++ b/drivers/platform/x86/amd/hsmp.c @@ -362,7 +362,7 @@ static ssize_t hsmp_metric_tbl_read(struct file *filp, struct kobject *kobj, ret = hsmp_send_message(&msg); if (ret) return ret; - memcpy(buf, sock->metric_tbl_addr, bin_attr->size); + memcpy_fromio(buf, sock->metric_tbl_addr, bin_attr->size); return bin_attr->size; }