From patchwork Wed Oct 18 06:51:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhiguo Niu X-Patchwork-Id: 154714 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4606650vqb; Tue, 17 Oct 2023 23:53:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyxzC3FdPzRwAqSOw7v6Huox0pqQY1fq4RYX1LVd87hf4OuZfQ/ujmUBydKj7pnt9V8GXr X-Received: by 2002:a17:90b:3b81:b0:27d:2261:73e4 with SMTP id pc1-20020a17090b3b8100b0027d226173e4mr4764403pjb.2.1697611986871; Tue, 17 Oct 2023 23:53:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697611986; cv=none; d=google.com; s=arc-20160816; b=TuU814SzmnMNxr0xt9c1Fg8N8CV2kiO5FI3ZxJgr0QFE3JRm2nMvgoyK1Nk/1e+Gk5 T88KHncCafZ8sd+s+bFuzh2ZvkQ1rIMVcUcvkbv8Pck85FZrUtbV6gROWfbh8Knp4JIy eBp1f1gINXMeF8gGePpnDrXdKjKwgXTd2u6bP8uU4vLS/f6v7qa0ZqR7rq2mQwf8yRoj T81NaWNfIjvf9c+Y7/q6AHeXT661X1g/kxAAjwaNPKapLXggzwGU8pSOQJzNCM159Cy0 4EoKnsxOGcIYqP1m+nEvZnF0ziQ7Jjr3aIxJshGQFwyiJvkxhjMAi/yoPBpeCbpVmh3+ NF1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=iYzQhZWJn/nbGVXJffvQm1RZ6jrHzfVteFolX83VpOQ=; fh=jjDTLTkAaPK3cTutO2P9ZECZUYkGOS1dcBtirQV26To=; b=ZMOwvzP4faO/D2mwBuL26yi/Ft0poeH3Y+gOPcjNXXsaxWlq4a7bUYu4IkhSIeV9q9 ufm/AHo5wjkWL/bT+zVQ2b/ci12JI6M0CfehdSCs4Xx0YuZT2sj+2j0CsIb8poTEh+De lxH0fIEwis1/XU0SPlNogNpxDUZZopvNGGNrke8BJAikPDeTILwNH03BavvHXtdTGAFr difFmiepW8b1kTpEHfGmVF44J5LazBu2Z1Cgb5jBCBbjVmvxMWtGEQSf1YM+iQlQ7U25 uzvjh5C8dZosQWTBfSt4PqunYoxAiD7BYqc+ljRgxEPvNdWcBL1GTskGhqvAEKQuZeQP M/vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id pg1-20020a17090b1e0100b00277e0d7163asi990961pjb.32.2023.10.17.23.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 23:53:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D6E9180293E6; Tue, 17 Oct 2023 23:53:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229736AbjJRGww (ORCPT + 23 others); Wed, 18 Oct 2023 02:52:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbjJRGwv (ORCPT ); Wed, 18 Oct 2023 02:52:51 -0400 Received: from SHSQR01.spreadtrum.com (mx1.unisoc.com [222.66.158.135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7496B0 for ; Tue, 17 Oct 2023 23:52:48 -0700 (PDT) Received: from dlp.unisoc.com ([10.29.3.86]) by SHSQR01.spreadtrum.com with ESMTP id 39I6q22d003506; Wed, 18 Oct 2023 14:52:02 +0800 (+08) (envelope-from Zhiguo.Niu@unisoc.com) Received: from SHDLP.spreadtrum.com (bjmbx01.spreadtrum.com [10.0.64.7]) by dlp.unisoc.com (SkyGuard) with ESMTPS id 4S9LyD6mfQz2KFmlh; Wed, 18 Oct 2023 14:47:48 +0800 (CST) Received: from bj08434pcu.spreadtrum.com (10.0.73.87) by BJMBX01.spreadtrum.com (10.0.64.7) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Wed, 18 Oct 2023 14:51:59 +0800 From: Zhiguo Niu To: , CC: , , , Subject: [PATCH] f2fs: fix error handling of __get_node_page Date: Wed, 18 Oct 2023 14:51:02 +0800 Message-ID: <1697611862-25239-1-git-send-email-zhiguo.niu@unisoc.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Originating-IP: [10.0.73.87] X-ClientProxiedBy: SHCAS03.spreadtrum.com (10.0.1.207) To BJMBX01.spreadtrum.com (10.0.64.7) X-MAIL: SHSQR01.spreadtrum.com 39I6q22d003506 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 17 Oct 2023 23:53:04 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780075186783267660 X-GMAIL-MSGID: 1780075186783267660 Use f2fs_handle_error to record inconsistent node block error and return -EFSCORRUPTED instead of -EINVAL. Signed-off-by: Zhiguo Niu --- fs/f2fs/node.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 248764b..ed963c56 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1467,7 +1467,8 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid, ofs_of_node(page), cpver_of_node(page), next_blkaddr_of_node(page)); set_sbi_flag(sbi, SBI_NEED_FSCK); - err = -EINVAL; + f2fs_handle_error(sbi, ERROR_INCONSISTENT_FOOTER); + err = -EFSCORRUPTED; out_err: ClearPageUptodate(page); out_put_err: