From patchwork Mon Nov 7 11:28:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladislav Khmelevsky X-Patchwork-Id: 16379 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1989916wru; Mon, 7 Nov 2022 03:28:41 -0800 (PST) X-Google-Smtp-Source: AMsMyM4WuCcGbVl8mnS5hwhkDGXhvQJSxmjC/mfsriXK9BhSsqXFDtKXpFLxqIn8yHvULKCUsiK6 X-Received: by 2002:a05:6402:5c9:b0:446:fb0:56bb with SMTP id n9-20020a05640205c900b004460fb056bbmr50955271edx.173.1667820521578; Mon, 07 Nov 2022 03:28:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667820521; cv=none; d=google.com; s=arc-20160816; b=wKJveLPYDVW/Vs0ZZX4WAyO0/E9wcZMjLhKEp8lV7KSGJcrBUUwEjweleoG8zkTrkq p/fAtbW1cz4d7Hw9Nag6cFJvq1lL6+HwW5YFAwdOpoMj5FzUdeThyZlHS2bvVr8fc6MU KyVbd4g6VurYrrMS2oMYb+7qCN8OOlbGGWgUT8+DJWvrd5HDOti0m+/frOBPvqMBkRs6 oCwByR2zbXj69kdl5ONAabQsOZJK9ido2pEZZQI2NzQDcnIhS/6Z4KzYq5up25QEIHbW A4huuugljrKRrqlZvPcKmsinJNlQaAAiasxkZ77hWnSoyMSwTHwg16aLvahlUOy+FBxZ 5PPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=GPZtpUNpYPY5ic59E/cs959Cav3dH6nk87NLa0dOKIc=; b=a9SQ7PAxO1ztKOBzjt7VZYGfxr6wQX88PBUgilKvS4pG6xbyhuWUd9YK6DUMMx3LVa SZbSSAmYrazy3UQZRcdRQ7dp6QW+fZi8JCjr81ZMruLsppLt/a3opFiZYa+ay+jzGeQl +0Lnt87FFI94rD1GpPBLNAX7dob+eNxdaWkJFYdozQoGpMOBqeQHlHn3LCElQR8qU3eb 1qE0WwMDDk8BYsF9YH4YQ2e0PDAVn7/QahJtyQxh7NAPt+jtaSL5qWz5UWx12KS8LKxI TOoCrZ24EIYT/Zs7nHuwU80+MIaRHtQ4u4FlxgOkDIiudR9IV2hnjFAfrhPmTO9mMrdy 1rjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=t1+KbhyD; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id d19-20020aa7d693000000b0046154884604si8696573edr.482.2022.11.07.03.28.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 03:28:41 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=t1+KbhyD; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 963593858413 for ; Mon, 7 Nov 2022 11:28:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 963593858413 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667820520; bh=GPZtpUNpYPY5ic59E/cs959Cav3dH6nk87NLa0dOKIc=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=t1+KbhyDLvCI2Wa422SFfZ6ou8HqAL9hqefB2voXknhYBTOJT6kkrNNrLJO6bt4tF dqzppp3517aUj3g1v4dbWH0oLb0NNGHF5DNNPo8RyFU1cleNon9bTPOGOLcWnxARVF dtWciq3maJm/gv52CGtQJSnH6uYnRBK+MjvQuQV8= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from forward107j.mail.yandex.net (forward107j.mail.yandex.net [5.45.198.252]) by sourceware.org (Postfix) with ESMTPS id DC4603858C1F for ; Mon, 7 Nov 2022 11:28:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC4603858C1F Received: from sas2-e7f6fb703652.qloud-c.yandex.net (sas2-e7f6fb703652.qloud-c.yandex.net [IPv6:2a02:6b8:c14:4fa6:0:640:e7f6:fb70]) by forward107j.mail.yandex.net (Yandex) with ESMTP id 1BC0A889077 for ; Mon, 7 Nov 2022 14:28:30 +0300 (MSK) Received: by sas2-e7f6fb703652.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id aRm5EiQlFK-SSgaZ9mg; Mon, 07 Nov 2022 14:28:29 +0300 X-Yandex-Fwd: 1 To: binutils@sourceware.org Cc: Vladislav Khmelevsky Subject: [PATCH] gold/aarch64: Fix adrp distance check Date: Mon, 7 Nov 2022 15:28:05 +0400 Message-Id: <20221107112805.3332619-1-och95@yandex.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Vladislav Khmelevsky via Binutils From: Vladislav Khmelevsky Reply-To: Vladislav Khmelevsky Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748836571232430267?= X-GMAIL-MSGID: =?utf-8?q?1748836571232430267?= The offset between destination and location is a signed number, currently the offset is treated as unsigned number, thus mathematical shift of a negative value is performed incorrectly. --- gold/aarch64.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gold/aarch64.cc b/gold/aarch64.cc index d2b0747ffdc..514fad96789 100644 --- a/gold/aarch64.cc +++ b/gold/aarch64.cc @@ -1182,7 +1182,8 @@ class Reloc_stub : public Stub_base aarch64_valid_for_adrp_p(AArch64_address location, AArch64_address dest) { typedef AArch64_relocate_functions Reloc; - int64_t adrp_imm = (Reloc::Page(dest) - Reloc::Page(location)) >> 12; + int64_t adrp_imm = Reloc::Page (dest) - Reloc::Page (location); + adrp_imm = adrp_imm < 0 ? ~(~adrp_imm >> 12) : adrp_imm >> 12; return adrp_imm >= MIN_ADRP_IMM && adrp_imm <= MAX_ADRP_IMM; }