From patchwork Tue Oct 17 12:19:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 154233 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4092049vqb; Tue, 17 Oct 2023 05:19:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHz19SqChm3DiuTSAmdBXS97sxQ8GDVxvWVNQM3Gt7K3EOIu4xdIg6Ra21vbKnrWsaHDAzd X-Received: by 2002:a05:6a20:4288:b0:171:737:df97 with SMTP id o8-20020a056a20428800b001710737df97mr2333429pzj.2.1697545187009; Tue, 17 Oct 2023 05:19:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697545186; cv=none; d=google.com; s=arc-20160816; b=twuL3nXKpmnwssNN7MLU5YlaQEo3Xpri2Payf3IZX6i+nhQeE52ZMZAvHIqk6sI7fn kvj1YSD0aM53+BkZ27kwIQ/7o934LNOaC9W//BJhGkhGTmo3dRWRRBekA6ZHosdUMRUN 1FosMg5LCvyRa0NthgYAJ9bqa4UiXnX2YlDlleWuB0byBgvI4YV0YIm14Z7ky75mt/K6 tuxvD9Dtv7A+nHBZtn/mTFFf9velF7jIA+KTgGqs1UFDNPq/1Y52PJQNxPnV4SvEIgPp xjfhR7DF0d1u7e3sy4eL/EH4FLZuZIQJhmP3wSvTUeQebRUx7DZKFNeVlsBs5WzGB7Z5 OBgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fIov9ctyrrTQw68OEwJk0QgoMj9+pbXQx9auQm7YPYg=; fh=ScE4zaNLaTX7FxS3YO2Y0+Bvh7jTdqGwqIL2ve5J2pI=; b=gVVpAQFAJEH2ZLeIe3ONRGFl3MIljCjB09V3Oa7xses+9vNSQxtxkcKCMND1kbQUEm AMgaYHLAZegs9iQKo+dK6M9ZH3l2WmqBiTkRGG5MF8HiWs/xT6Kd0R+fCTt/cwgkWG9N NJ3garY6gXiQtJmUYA9tg4nPpClPUAzjwIpSNCW3joG2Cgbi+l/MGVTpcUyS/h7xdgoB kLmj8rBoDwhyejFuTZgvj+O0/QcpODXzfCC9OxNogBkaP7BCXDEa+dxF0DHRiznMMP0b thRsHs5BFDmA/C9RDTU/wttXWFAklsUVDseFD9U3bjTrgHs2JUoamRaQIISm8C6XMRyS LvXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=e5axE8Pu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id z15-20020a170903018f00b001c746b986e2si268783plg.346.2023.10.17.05.19.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 05:19:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=e5axE8Pu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 69B6E801C1A4; Tue, 17 Oct 2023 05:19:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234360AbjJQMTm (ORCPT + 19 others); Tue, 17 Oct 2023 08:19:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235186AbjJQMTa (ORCPT ); Tue, 17 Oct 2023 08:19:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A0E3865; Tue, 17 Oct 2023 05:19:15 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 958DBC433C7; Tue, 17 Oct 2023 12:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697545155; bh=nGQYsoxqCkQ0YYtiYb1sIwFgNYda2Lk6AkqvILuiiAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e5axE8Pul/yenI/J6sA0VNYiyRKQqzkRIlEytcBQPSg9NMWVX/2V6EPzoq+BZIUZF S3DBwH1b8DuDz6u2UBExSIBDhPKHRGuePjcUUFzPG6w+Tm2tB3Tx3sZIAFTmdWgi/R A84riQ1fDmzKpKYSbrVAEze2MyTjqIn5FITBqU3wzfHBngBcUcZ7VEzl7wf1wNvsae hgK5A5ay1/kb0ysqyrKn0YFghJJ2rVHXhRL8yJyzWQX8U9Woz4ElUa9Pt7yZiiztG/ Wa2qvjJaex8ghV4cCLYH+zQhawt6ZRAsWXGLhIbNlAJIJWhRGopGqLlpo2+HM8K+pr SB2YZni0fCPxA== From: Frederic Weisbecker To: LKML Cc: "Paul E. McKenney" , Boqun Feng , Joel Fernandes , Josh Triplett , Mathieu Desnoyers , Neeraj Upadhyay , Steven Rostedt , Uladzislau Rezki , rcu , Guenter Roeck , Frederic Weisbecker Subject: [PATCH 1/3] rcu-tasks: Add printk()s to localize boot-time self-test hang Date: Tue, 17 Oct 2023 14:19:03 +0200 Message-Id: <20231017121905.1156166-2-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231017121905.1156166-1-frederic@kernel.org> References: <20231017121905.1156166-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 17 Oct 2023 05:19:46 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780005142290058760 X-GMAIL-MSGID: 1780005142290058760 From: "Paul E. McKenney" Currently, rcu_tasks_initiate_self_tests() prints a message and then initiates self tests on up to three different RCU Tasks flavors. If one of the flavors has a grace-period hang, it is not easy to work out which of the three hung. This commit therefore prints a message prior to each individual test. Reported-by: Guenter Roeck Signed-off-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker --- kernel/rcu/tasks.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index 8d65f7d576a3..83049a893de5 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -1979,20 +1979,22 @@ static void test_rcu_tasks_callback(struct rcu_head *rhp) static void rcu_tasks_initiate_self_tests(void) { - pr_info("Running RCU-tasks wait API self tests\n"); #ifdef CONFIG_TASKS_RCU + pr_info("Running RCU Tasks wait API self tests\n"); tests[0].runstart = jiffies; synchronize_rcu_tasks(); call_rcu_tasks(&tests[0].rh, test_rcu_tasks_callback); #endif #ifdef CONFIG_TASKS_RUDE_RCU + pr_info("Running RCU Tasks Rude wait API self tests\n"); tests[1].runstart = jiffies; synchronize_rcu_tasks_rude(); call_rcu_tasks_rude(&tests[1].rh, test_rcu_tasks_callback); #endif #ifdef CONFIG_TASKS_TRACE_RCU + pr_info("Running RCU Tasks Trace wait API self tests\n"); tests[2].runstart = jiffies; synchronize_rcu_tasks_trace(); call_rcu_tasks_trace(&tests[2].rh, test_rcu_tasks_callback); From patchwork Tue Oct 17 12:19:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 154234 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4092082vqb; Tue, 17 Oct 2023 05:19:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNkCIlx5oJQe1Bf7Z5MI/rL4+MuuQ1DEvoh7ASh7Uhzgg4D2xq6Sokll7JVyrZIgaq8UBv X-Received: by 2002:a17:903:340c:b0:1ca:1ce1:bfac with SMTP id ke12-20020a170903340c00b001ca1ce1bfacmr2062748plb.1.1697545191182; Tue, 17 Oct 2023 05:19:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697545191; cv=none; d=google.com; s=arc-20160816; b=QwIYUJ5goCQnByu53TFPcwbPgN+h3CETL5jBGEO7Rex3oGCFulYs2PQNAIMICEUEmM PHgqW87gRmBJ0otUOtus0OyJn54xv6o+W+65m22kBINMdZsTirYEwCb1hg9PZlsMNdwp 6STeFX9CBuyelFsxbhGU3awrNXRF9rY44X2cJBMi8YB0NP4wTurGvSiK0XprGl4hREcR 7NqS/lVGSpTK9o3V/CV9UBlti7vxwFdz7ydXLREzNrynt1rVAKNdcuHvJf9bEf+5FREM 8h9kOOJbXs65qGfYRdPyyr80FeBj88a+0KR28YEBCRBDEEZNdW7gyEMdRx5OM5YEJ+dW 1AlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5220byjYiS9sIkEdrurHlSWwJR0Y4aZbZTrxatThIv4=; fh=lu4ND71kuCJoIq12QTO73nSs+Y7WmfMYUMyi8q/LiXw=; b=NGcv/nkQNN94rJNtk5akpfGbjCnm7nud0TUNPAzZnF7+DfXamtxMTcJI49dZtDYKbn hF2Ut5GJkYtCVE3Hzo36sFuz39Yda7xScdQ5/TwToGHWYmqnNCPSdheaIQzQ5F8CJoEn 3jPWUFLbAAa6rJR2kmI/+KCtqv7fu3wylJzwBCGDRQWh3QPsY3YKzwVzdM+WtYPyV0Qj jWczUIUUgMXnT2WvtXZkw/NwbEYbD2Ng3xX3mK5QSlYVZ8yN1OzSpglWGbjFQHO2c0l7 e8v60Dh9wJxsHwLfcBAAYcYcy6EOXJPr+9btX3Ft9VkUXGOMjh8E9xxYLOu+isP06tho yK3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TTiYxOGU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id c12-20020a170903234c00b001bbad1883d5si1824628plh.293.2023.10.17.05.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 05:19:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TTiYxOGU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 3395A801C09F; Tue, 17 Oct 2023 05:19:50 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343584AbjJQMTr (ORCPT + 19 others); Tue, 17 Oct 2023 08:19:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234808AbjJQMTb (ORCPT ); Tue, 17 Oct 2023 08:19:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7262C3C0B; Tue, 17 Oct 2023 05:19:18 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FC6BC433CA; Tue, 17 Oct 2023 12:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697545157; bh=h9+pFFk6S6/pR3kzOkCCUyr4lY/4hLmqaxjAdWypwXw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TTiYxOGUpdxl6LnEq0oYQHVVWNtIIFS0BNm10v346xnZCDzUSzpWjskcFRF5HpDUq g4xKUIiR3l0nyHMboEFtRZ+B20T+xF9aWoculjjsXgoRAqq1eC8gYcWqRsFcNqhUxt 50INoQ5wOe/MgwIFM7Eo7xDC4/fvVuLlth7fpn5ba9cyxyj81Jn0VP5HyNGAriH09O 3tc5q+YuSqUcduYHj2CkebBIkkXy5VKVyKP78mwK0XG4oWtN3GBLiye8mtWt5Hfrj8 ENxImfz+yapBpyjn9qAyUyAwCcYER8UnzkcGd4ay8H9fa35EGO+SoABpltdsL15QSQ onIIgMpDKFTpg== From: Frederic Weisbecker To: LKML Cc: "Paul E. McKenney" , Boqun Feng , Joel Fernandes , Josh Triplett , Mathieu Desnoyers , Neeraj Upadhyay , Steven Rostedt , Uladzislau Rezki , rcu , Linus Torvalds , Frederic Weisbecker Subject: [PATCH 2/3] rcu-tasks: Pull sampling of ->percpu_dequeue_lim out of loop Date: Tue, 17 Oct 2023 14:19:04 +0200 Message-Id: <20231017121905.1156166-3-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231017121905.1156166-1-frederic@kernel.org> References: <20231017121905.1156166-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 17 Oct 2023 05:19:50 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780005146640498828 X-GMAIL-MSGID: 1780005146640498828 From: "Paul E. McKenney" The rcu_tasks_need_gpcb() samples ->percpu_dequeue_lim as part of the condition clause of a "for" loop, which is a bit confusing. This commit therefore hoists this sampling out of the loop, using the result loaded in the condition clause. So why does this work in the face of a concurrent switch from single-CPU queueing to per-CPU queueing? o The call_rcu_tasks_generic() that makes the change has already enqueued its callback, which means that all of the other CPU's callback queues are empty. o For the call_rcu_tasks_generic() that first notices the switch to per-CPU queues, the smp_store_release() used to update ->percpu_enqueue_lim pairs with the raw_spin_trylock_rcu_node()'s full barrier that is between the READ_ONCE(rtp->percpu_enqueue_shift) and the rcu_segcblist_enqueue() that enqueues the callback. o Because this CPU's queue is empty (unless it happens to be the original single queue, in which case there is no need for synchronization), this call_rcu_tasks_generic() will do an irq_work_queue() to schedule a handler for the needed rcuwait_wake_up() call. This call will be ordered after the first call_rcu_tasks_generic() function's change to ->percpu_dequeue_lim. o This rcuwait_wake_up() will either happen before or after the set_current_state() in rcuwait_wait_event(). If it happens before, the "condition" argument's call to rcu_tasks_need_gpcb() will be ordered after the original change, and all callbacks on all CPUs will be visible. Otherwise, if it happens after, then the grace-period kthread's state will be set back to running, which will result in a later call to rcuwait_wait_event() and thus to rcu_tasks_need_gpcb(), which will again see the change. So it all works out. Suggested-by: Linus Torvalds Signed-off-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker --- kernel/rcu/tasks.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index 83049a893de5..94bb5abdbb37 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -432,6 +432,7 @@ static void rcu_barrier_tasks_generic(struct rcu_tasks *rtp) static int rcu_tasks_need_gpcb(struct rcu_tasks *rtp) { int cpu; + int dequeue_limit; unsigned long flags; bool gpdone = poll_state_synchronize_rcu(rtp->percpu_dequeue_gpseq); long n; @@ -439,7 +440,8 @@ static int rcu_tasks_need_gpcb(struct rcu_tasks *rtp) long ncbsnz = 0; int needgpcb = 0; - for (cpu = 0; cpu < smp_load_acquire(&rtp->percpu_dequeue_lim); cpu++) { + dequeue_limit = smp_load_acquire(&rtp->percpu_dequeue_lim); + for (cpu = 0; cpu < dequeue_limit; cpu++) { struct rcu_tasks_percpu *rtpcp = per_cpu_ptr(rtp->rtpcpu, cpu); /* Advance and accelerate any new callbacks. */ From patchwork Tue Oct 17 12:19:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 154236 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4092554vqb; Tue, 17 Oct 2023 05:20:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEf4p+LzorTjk4kO9ZV4PboNHoljmO+0MFV4ZdH6GUwqkXJEo79OTioQJ3C2JfYGVz1yEex X-Received: by 2002:a05:6359:5e20:b0:166:d93e:339 with SMTP id pw32-20020a0563595e2000b00166d93e0339mr2010578rwb.0.1697545239353; Tue, 17 Oct 2023 05:20:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697545239; cv=none; d=google.com; s=arc-20160816; b=rEPAV7a3C4KnKgjOIBV/em7xARwokFb4LzOe2pqEBL6G8DE2HDDFGt2ltWJb4REKJa DxVjA/zuQDP6+kiyWlSvgc4qRA1RLHJPCRkdI/eNwGQ5C8EB1ukqJDmSVAV68gn0DM/r el7M4rXppd1gO4+W7OpDCXSOc9GXU7qYkcZXqHuiN6cm91uxkiVd0n8Hw12or+Y/mtwU pyEsmPfgW0HyqTtuaLzAL5AWa42NSIRpal7rQEA/PBkN4XmLMbl1//IT+D5mQHQN89+E RxJ+u/uEoVYWaAKu2ywxngW7HqiZCFbkFe4D9jTTSt3lshsu/okhI1o0in1lUySxjASa Q2zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1PVYSxZ08wYtwG6Snz7g0lKp9vnzVZ4vKL9I22XLJfg=; fh=dpQA+RSpya2MDQzJyu7/B30Rc7zKbosQ5fBkmcZ1zQ4=; b=srE18u6KO8FfFSyn9pmATLzs/BpKzqzshGS4LGZARgw0Qt9bVUFTOeQMnFaBNSU0uJ 35OMpM9qZeO26MFLWuQG7XA7/+8fO03fHSxURmkiZrhe1G8VPTPfNKybwir0GfgodXJR Vx1jMaFoaPr2LoCmlfXnjWIi+IBQD3jhGRTbf1UuvaxOo61bRkwtCcpvovO2GGedD3UL S0tc6px51MMmPE/mivU4B57ulZd4RyPnMnuzGpzNzrtNr2grm8uWwZa9AovMPiPGcFGv GjRc5tNuXpbitZvslC6KX5J2o3+MCmm3wh/Mv2EjtnZ6FYlwLSadeGGK1gc2nhSO3FAa 0hhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GR0jSiaU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id h11-20020a65480b000000b0059b79bf220csi1480424pgs.662.2023.10.17.05.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 05:20:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GR0jSiaU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id D828C8080E0C; Tue, 17 Oct 2023 05:20:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343656AbjJQMTt (ORCPT + 19 others); Tue, 17 Oct 2023 08:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235015AbjJQMTd (ORCPT ); Tue, 17 Oct 2023 08:19:33 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 382B010CE; Tue, 17 Oct 2023 05:19:21 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CF5FC433CC; Tue, 17 Oct 2023 12:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697545160; bh=KRYagrNjJg3nrUhLUUzrvcOlwM6Y8bhCaiTkgIqmUKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GR0jSiaU65B9zcMl5Gj8T4xNpbN7aNO4dWavSGJkMDC6fRmb8S1tg8JBiGtCFU26g FLz3f8MDGV0c3MtL8yibbz6CdqWFykTTSqwAhpADqJ91kwZC10zIRg5INYxWQxlGwL Z8bBltYzYdT3d2Rj2bb2tO/SKaaONdE8DwwQihGmiFt3h3B1Y9IDtSPvS4RoLeX7Ly lQoIhVvBqS1hwf8v2Vyv5XBBLHbcjYb+DRdRs6H+AF6/Al463OlG3yxFvrtwbrRuc2 KDDwSBIf/DuA4LDoEjr9Vk7xZVpCws44O5eW/D6tnGiwvr7SC+vskkJuc3tDQUSRT1 PzOc0PJ0EhzWA== From: Frederic Weisbecker To: LKML Cc: Jiapeng Chong , Boqun Feng , Joel Fernandes , Josh Triplett , Mathieu Desnoyers , Neeraj Upadhyay , "Paul E . McKenney" , Steven Rostedt , Uladzislau Rezki , rcu , Abaci Robot , Frederic Weisbecker Subject: [PATCH 3/3] rcu-tasks: Make rcu_tasks_lazy_ms static Date: Tue, 17 Oct 2023 14:19:05 +0200 Message-Id: <20231017121905.1156166-4-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231017121905.1156166-1-frederic@kernel.org> References: <20231017121905.1156166-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 17 Oct 2023 05:20:09 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780005196903858903 X-GMAIL-MSGID: 1780005196903858903 From: Jiapeng Chong The rcu_tasks_lazy_ms variable is not used outside the file tasks.h, so this commit marks it static. kernel/rcu/tasks.h:1085:5: warning: symbol 'rcu_tasks_lazy_ms' was not declared. Should it be static? Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6086 Signed-off-by: Jiapeng Chong Reviewed-by: Joel Fernandes (Google) Signed-off-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker --- kernel/rcu/tasks.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index 94bb5abdbb37..018f03f20629 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -1086,7 +1086,7 @@ void rcu_barrier_tasks(void) } EXPORT_SYMBOL_GPL(rcu_barrier_tasks); -int rcu_tasks_lazy_ms = -1; +static int rcu_tasks_lazy_ms = -1; module_param(rcu_tasks_lazy_ms, int, 0444); static int __init rcu_spawn_tasks_kthread(void)