From patchwork Tue Oct 17 08:00:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 153956 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3968845vqb; Tue, 17 Oct 2023 01:01:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQeznUJPwk4cJGy6k+IQt/TkeU9q/tUAsp5RBnMuVaS66KE8qWzikPno2g+4YdLJN3Cje6 X-Received: by 2002:a05:6830:6a9b:b0:6b8:7653:dd66 with SMTP id da27-20020a0568306a9b00b006b87653dd66mr1655034otb.0.1697529660634; Tue, 17 Oct 2023 01:01:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697529660; cv=none; d=google.com; s=arc-20160816; b=rkqQKbQb1hXznif+jEdYd47pXQjw8QhYF/7PaiT7MPLgE02iZ8o7WT8sb6ccj9+CYS xOUIoaXr9leoFQp8k4zL1NPB2H+Y2Ib1XGbE58TfgX60XmJj23IrYjzwRDfe21gFSzB9 dqpzm07isD04I6y3rZNtTmp57rtYlUtAbMlkCGeSCNraSNQngCMY6XNEQTKfmB+RxuAf HE5A5BLWWgqZyyqShIsiSwj9U+Iwd890pwn5NbZ8xhNFWUYfrFCckHQO3pIObVHX9ohd 493fcg45THuVQMB6SXWoy4XoT8o1NDOCZqvLzcD6Y0y9OyCYghoBZqobReCXacupRb58 62ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=nBYtQLiZ5RB4OSac9xrnHTxrEXkSr1E/izR9K8kO0uY=; fh=zb7Jf0ADGeg9EQlRrFGFP9vYlcx/wKRq1pefmNbeWo0=; b=QGJwk71dCcNN0AmCRtr/ozEGZlUuYg72P2vQHYqxvxxpNEneMqcb4fQiRFIlwPI0KE 9ST0+MiUqH8CBE1YnMZ+2xz2LRxBAG6M8iOwOkJ8LS0XHAWg/HFZyiGuu6xjPwLJYW2M lpclxGNif2e4jsTitNAnv2t+Ddx0WVN6VEGQSfKCdZlk2l3aH4tpLUZ1pFkqh45U5yLO lqv0oTrhmL99AYCQT9FccH99hGWl+IZ8llrjCWVq9c7DfUJk5J4VAiPBZ7dxExCDWimK Z1xFRq3xBZBq0tlIXtseQtf+3hVhMuWj69Arp7dcuEH7sdXVK/P4ZmKABepe7C6dErSp bEVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=ZB6l7pES; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id w17-20020a056a0014d100b006b6cc63a79csi1137244pfu.330.2023.10.17.01.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 01:01:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=ZB6l7pES; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7E30980310F5; Tue, 17 Oct 2023 01:00:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234723AbjJQIAl (ORCPT + 19 others); Tue, 17 Oct 2023 04:00:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234758AbjJQIAf (ORCPT ); Tue, 17 Oct 2023 04:00:35 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A2C9FF for ; Tue, 17 Oct 2023 01:00:28 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-53db3811d8fso11152041a12.1 for ; Tue, 17 Oct 2023 01:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1697529627; x=1698134427; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=nBYtQLiZ5RB4OSac9xrnHTxrEXkSr1E/izR9K8kO0uY=; b=ZB6l7pESFKFD8Ixh/gcGKrj8uAwJAIZMcJzlXYJLGa8h4/e8djQ3df5YAFFy2co7ly M1cQE30YqWZWFRNYXwpudlZjvxtsnXvLUc19HJcXwUPhtEEGz4D716kuNr+RD7q6FN1k VE0hxU8TF9uAYLnTK0pi23e6LqyEXy9hRyxx+5hKfhdGd5Npb6iIsKBPXAGZN2KwTFIh VhF4B4nFeR/tF2pIoXJseqcZNihDS2xK2KoKS1do9Ta95/i2r4Y+ASRrmu+gApojjFju Kg0j280Xs2q8G21jp9TXECrcAqKp9+ZWmrVuAfQxp+cR+7fRopSsE58PKEV85EZ7DnMI nbmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697529627; x=1698134427; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nBYtQLiZ5RB4OSac9xrnHTxrEXkSr1E/izR9K8kO0uY=; b=Vrhk/MkCmgR2+3Wb/CspBOafrNcI5gNdelefEMFpZ0kyZXF4e2O1jrGFYQIH03ru95 8wFp5mVw78XNWpGhopPC/Ur7olW+vK7NkOKGEk1GqCilsQF2TQOZnngkI4Pdvxzwd0i3 FYZ9OMWnqDrvJfXl9fwftdFXv+QJb4wf+CBbvGWCgVptLCWfGmrJVxUobwtlcmgvxLFs H7xL8Pr8DbNXIH8g4CnRzjxUvEEHMbt2iL/okzdIMKAktNMSXmUvWXR0Fk/yn3csxETO xU1esdjUjAPzbppVgVE0FMCe28hpMqraRYtK/c8bVH9eejslK6Lvf2MJBi+w6nHTfadf 9FlQ== X-Gm-Message-State: AOJu0YwhBhkpePoFRy/M/eoHa6geGLi77qOi/MbP3h7IQljTDkkUBdUz KSu/i9sQrAeSNukiRwahcS8KDN9bkGzlHJHExM0Mdw== X-Received: by 2002:a50:9996:0:b0:523:2e23:a0bf with SMTP id m22-20020a509996000000b005232e23a0bfmr1035714edb.11.1697529626646; Tue, 17 Oct 2023 01:00:26 -0700 (PDT) Received: from otso.luca.vpn.lucaweiss.eu (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id s23-20020a508d17000000b00536031525e5sm718625eds.91.2023.10.17.01.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 01:00:26 -0700 (PDT) From: Luca Weiss Date: Tue, 17 Oct 2023 10:00:23 +0200 Subject: [PATCH v2] soc: qcom: pmic_glink_altmode: Print return value on error MIME-Version: 1.0 Message-Id: <20231017-glink-altmode-ret-v2-1-921aa7cfc381@fairphone.com> X-B4-Tracking: v=1; b=H4sIABY/LmUC/32NQQ6CMBBFr0Jm7RiGWgmuuIdhUWCgE6ElLSEaw t2tHMDle8l/f4fIQTjCI9sh8CZRvEtQXDLorHEjo/SJocgLRTkpHCdxLzTTOvueMfCKqiLie0d sWg1ptwQe5H02n01iK3H14XNebPSz/2obIWFZVjfSqjRKt/VgJCzWO752fobmOI4vpeV2U7YAA AA= To: Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 17 Oct 2023 01:00:58 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779988861557100469 X-GMAIL-MSGID: 1779988861557100469 It can be useful to know with which return value for example the typec_retimer_set call failed, so include this info in the dev_err prints. Signed-off-by: Luca Weiss --- Changes in v2: - Add ret to print in more prints, not just typec_retimer_set (Bjorn) - Link to v1: https://lore.kernel.org/r/20231013-glink-altmode-ret-v1-1-77941537a35b@fairphone.com --- drivers/soc/qcom/pmic_glink_altmode.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) --- base-commit: e3b18f7200f45d66f7141136c25554ac1e82009b change-id: 20231013-glink-altmode-ret-3911e6c1eab5 Best regards, diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c index 9569d999391d..0a75bfac5e02 100644 --- a/drivers/soc/qcom/pmic_glink_altmode.c +++ b/drivers/soc/qcom/pmic_glink_altmode.c @@ -160,7 +160,7 @@ static void pmic_glink_altmode_enable_dp(struct pmic_glink_altmode *altmode, ret = typec_mux_set(port->typec_mux, &port->state); if (ret) - dev_err(altmode->dev, "failed to switch mux to DP\n"); + dev_err(altmode->dev, "failed to switch mux to DP: %d\n", ret); port->retimer_state.alt = &port->dp_alt; port->retimer_state.data = &dp_data; @@ -168,7 +168,7 @@ static void pmic_glink_altmode_enable_dp(struct pmic_glink_altmode *altmode, ret = typec_retimer_set(port->typec_retimer, &port->retimer_state); if (ret) - dev_err(altmode->dev, "failed to setup retimer to DP\n"); + dev_err(altmode->dev, "failed to setup retimer to DP: %d\n", ret); } static void pmic_glink_altmode_enable_usb(struct pmic_glink_altmode *altmode, @@ -182,7 +182,7 @@ static void pmic_glink_altmode_enable_usb(struct pmic_glink_altmode *altmode, ret = typec_mux_set(port->typec_mux, &port->state); if (ret) - dev_err(altmode->dev, "failed to switch mux to USB\n"); + dev_err(altmode->dev, "failed to switch mux to USB: %d\n", ret); port->retimer_state.alt = NULL; port->retimer_state.data = NULL; @@ -190,7 +190,7 @@ static void pmic_glink_altmode_enable_usb(struct pmic_glink_altmode *altmode, ret = typec_retimer_set(port->typec_retimer, &port->retimer_state); if (ret) - dev_err(altmode->dev, "failed to setup retimer to USB\n"); + dev_err(altmode->dev, "failed to setup retimer to USB: %d\n", ret); } static void pmic_glink_altmode_safe(struct pmic_glink_altmode *altmode, @@ -204,7 +204,7 @@ static void pmic_glink_altmode_safe(struct pmic_glink_altmode *altmode, ret = typec_mux_set(port->typec_mux, &port->state); if (ret) - dev_err(altmode->dev, "failed to switch mux to safe mode\n"); + dev_err(altmode->dev, "failed to switch mux to safe mode: %d\n", ret); port->retimer_state.alt = NULL; port->retimer_state.data = NULL; @@ -212,7 +212,7 @@ static void pmic_glink_altmode_safe(struct pmic_glink_altmode *altmode, ret = typec_retimer_set(port->typec_retimer, &port->retimer_state); if (ret) - dev_err(altmode->dev, "failed to setup retimer to USB\n"); + dev_err(altmode->dev, "failed to setup retimer to USB: %d\n", ret); } static void pmic_glink_altmode_worker(struct work_struct *work) @@ -397,7 +397,7 @@ static void pmic_glink_altmode_enable_worker(struct work_struct *work) ret = pmic_glink_altmode_request(altmode, ALTMODE_PAN_EN, 0); if (ret) - dev_err(altmode->dev, "failed to request altmode notifications\n"); + dev_err(altmode->dev, "failed to request altmode notifications: %d\n", ret); } static void pmic_glink_altmode_pdr_notify(void *priv, int state)