From patchwork Mon Oct 16 16:10:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 153525 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3568454vqb; Mon, 16 Oct 2023 09:11:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLlxiwFoXSLjy0QKTTwqXTvgz25ITMNi/y5UETVY2Yx7Y3/C/3T1ZRdOowtuCw+Pg22SDd X-Received: by 2002:a05:6870:450b:b0:1ea:6883:99ff with SMTP id e11-20020a056870450b00b001ea688399ffmr1657019oao.5.1697472678939; Mon, 16 Oct 2023 09:11:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697472678; cv=none; d=google.com; s=arc-20160816; b=QEoKL3fOTfOEuJZdIcgojZeAvh9NblpbyzUtSqykpewyjemvsi7oh4/9EDWKRrHWOb 8xgaFAvFUZDXCG1msgy2NYQqoA6Rqa55Fn/FOM17F5jfMxRwsowtNnL54gqhXcxbm2/f qLUc96lbHO6SsTpz/1p6BI540VI6eyghYRViS8+C/8GmfQvDcSwUHjORmOE55sOqmbdY sE0gfKYTi1OjNLadSiqgpSIG/XiWvk4USxwn5+XqXeogqG8YvdXWStesDHeLxvUOZImC 5Q3Bq9hTuv/9nom6KTkP21uiEB4uWdPBMbowufsKixkdr9AlTJpiwHa0LTjWV3V66FOS +D9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=B/oz0uODugJGDz2wuzGYNvP+VRKjoNuxnRKjcNeKNdc=; fh=tUAC4oQq3UuKajr6ZMoB53sspoioCuMU4y0NrDbDhac=; b=QAm9JqkfpYNH2kmLfFTG+zgs7t1QH6O+xCM+yfknMgOwCjTSS0KxobZWQrgf1APcl5 SsfGLSRZjxBFnthfR6M12Mf8a71gU0gb1RtBMNOuZfdt3IKMdwK+UOtEamd2t5B6lp22 9wSPveOlDZ1ylqP4zx5+BFYBG8qM5ZmCzXxa9ksgpm9HVBWrSHo9jRTHWSvxlmCswPy6 ucPJdd1AAx1Q1ggeUw6ote9YSLZE0SVvnBXsYth1K0vGwfzlXGM/b7onDAPHqKqpt78N 844M9DZS3rJ0QdIUyiEi0ML4WA17VaYDy4sYiNTBmkE/V3lsVdTaGn6Z+wJKPx+8iMSv RZrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cUW8pk80; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id j63-20020a638042000000b005aaf48ab88csi7914996pgd.197.2023.10.16.09.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:11:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cUW8pk80; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id BAEBE8023AC8; Mon, 16 Oct 2023 09:10:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232816AbjJPQKP (ORCPT + 18 others); Mon, 16 Oct 2023 12:10:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjJPQKO (ORCPT ); Mon, 16 Oct 2023 12:10:14 -0400 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89C2BAB; Mon, 16 Oct 2023 09:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697472612; x=1729008612; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=yOQZfIm040lvmUe2O+DKvT56T78+nm6brIphWp/oItE=; b=cUW8pk80y+3RVyF2reTjUK0cZQ/eEVQZx9bpLrGm4HCPjQq4ACx9QHyx 1u1GXvX7FqRpRnO1cVkZ9ieaUW5KnOdK+ymVRROhfFPBgVIfvRXRpcKEl lhzo5K2D6fHgh8U/JafKsydheZr86jKw0/eAEAIn83bbTBarrc7T+qRro JsB1vS1VvbhojUHkLs9p5FmSwMxBaYDXhrUs1lSFMDCOTtQooWNgSAHV6 ZUg24PvcsgJrdWO0JY5IwWOJRf3cpsp0HnFEPxrkP+T9ZSJD7160sTLwB KWrWECe2OERkRYSBh31xGEoFClDeo8yjt7GmM1kDg3wTuI0hDMeQTsSMG w==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="4175721" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="4175721" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 09:10:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="1087124866" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="1087124866" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 16 Oct 2023 09:10:09 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id EA49781C; Mon, 16 Oct 2023 19:10:08 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 1/6] leds: gpio: Keep driver firmware interface agnostic Date: Mon, 16 Oct 2023 19:10:00 +0300 Message-Id: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 16 Oct 2023 09:10:28 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779929111373676452 X-GMAIL-MSGID: 1779929111373676452 The of.h is used as a proxy to mod_devicetable, replace former by latter. The commit 2d6180147e92 ("leds: gpio: Configure per-LED pin control") added yet another unneeded OF APIs. Replace with direct use of fwnode. Altogether this makes driver agnostic to the firmware interface in use. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index a6597f0f3eb4..debadb48ceda 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -11,8 +11,8 @@ #include #include #include +#include #include -#include #include #include #include @@ -129,8 +129,8 @@ static int create_gpio_led(const struct gpio_led *template, ret = PTR_ERR(pinctrl); if (ret != -ENODEV) { dev_warn(led_dat->cdev.dev, - "Failed to select %pOF pinctrl: %d\n", - to_of_node(fwnode), ret); + "Failed to select %pfw pinctrl: %d\n", + fwnode, ret); } else { /* pinctrl-%d not present, not an error */ ret = 0; From patchwork Mon Oct 16 16:10:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 153523 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3568218vqb; Mon, 16 Oct 2023 09:11:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExCEukB+mu+DZLNw3mMFwHIExJOEEcKWWT5+6rDuRLReCwCEUFVXvyCc538DL6YBzm579+ X-Received: by 2002:a05:6a20:4407:b0:133:6e3d:68cd with SMTP id ce7-20020a056a20440700b001336e3d68cdmr47010891pzb.3.1697472661753; Mon, 16 Oct 2023 09:11:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697472661; cv=none; d=google.com; s=arc-20160816; b=T5gINGszV9Gb0iqQm24kl+kkqEY4M/BTrnj1c7E5ODMIHtl13D+WigW5vnI6i16cKC Aiv0senyBVf3XEIzXpVVqQj+q6DILQ7ui065Zi2AoBKPgUSqkgV27dnAqkTowE3SAWae p4Y7tTQjv3XaYTpnwLV69FvHWXn5cZxIfBk46nUan64IknxvZHWcP0JC9Ks4qnjQ5H24 jUyifLkGQqgc5+2klDC3sd8V/F5vM/pL9IwgKo5HQmbXLPfaeTs/DztJxmrQqzeKjCE+ UFKHWBdaxiYcDvbWRhiPF7G7MEWqCYk1y/So9v0qc8nh2z4UhC+f2eI2O4wGKN3R/nRe GHLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fgaesPHR/7WchPNA9VUk7GRgmHi6eB1eaB+rHpWbNAg=; fh=tUAC4oQq3UuKajr6ZMoB53sspoioCuMU4y0NrDbDhac=; b=XwSS8wdwWejHbkyMwG9PYyTFc13gIuSrrurdoVVUKzVTbgQuWg9qF4OVQYWLAC9+Kl cgyF6lQ2zGNU6h/koYaES1rYMzhmsREsz5Wmr8sWVSAwdcgg5jyStKLguyD+8I/6s71u teQk8Xe33Jo1JkdJjwjGKRPNoHKz8F+T+822YJwmewVTeGpXEDCZH4W7QcONazuKCAOP zoZzTFw/wi68t0JA4R0nw00CyDDmVLflDGHd0vEg4DmMnsnPvf9YWIkpcCsTEPzzR0g+ gO1CLkIT6gLSQ2EOCfwYbdOQb8eLVH+7DieuwQesHSACF1DFPNkD6crfN+xMVPoEciRR JjZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W6o2Y3Wa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id a17-20020a170902ee9100b001b8ba81d04dsi10675791pld.395.2023.10.16.09.11.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:11:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W6o2Y3Wa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B96B080B1207; Mon, 16 Oct 2023 09:10:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233799AbjJPQKo (ORCPT + 18 others); Mon, 16 Oct 2023 12:10:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233746AbjJPQKd (ORCPT ); Mon, 16 Oct 2023 12:10:33 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 360C0F2; Mon, 16 Oct 2023 09:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697472631; x=1729008631; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cvuQMHb9LmDrcSq69UbNf/WifWB3BY+q2NCKjOo91RU=; b=W6o2Y3WaRlIsFT6xoLxifGUMMYeyxfKpJa4G3qLa9mSLWzmIJKhliTLR DXjkkv2kCRGL3GVo27lNzxQ/DUdpzYV6T5kvqWMTcWX5/a+DKz68rbihZ CEMyUn0+AmWTe3kxlARJ17mnsQRyWVhayftDVYkkmKoYG7vobw9iFWRNZ Jli2hy/O/PVdADyPjR4kQf4axnm8Pet4CkwyCzrcLvllqTtqs1UqJRSUm HUgHGYvl1I7aZnhKxgI7qRwOcVd8yrCDX7YwMYoqCpMZ4nDjpb419aZZL DVfazt2N05Gw8OhlFpIBbWtrz/cUexMVsDCHBCKzmWV19s83hOH29WdVy Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="7132785" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="7132785" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 09:10:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="785123038" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="785123038" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 16 Oct 2023 09:10:10 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0A927385; Mon, 16 Oct 2023 19:10:08 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 2/6] leds: gpio: Utilise PTR_ERR_OR_ZERO() Date: Mon, 16 Oct 2023 19:10:01 +0300 Message-Id: <20231016161005.1471768-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> References: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 16 Oct 2023 09:10:59 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779929093756335137 X-GMAIL-MSGID: 1779929093756335137 Avoid a boilerplate code by using PTR_ERR_OR_ZERO() in create_gpio_led(). Signed-off-by: Andy Shevchenko --- drivers/leds/leds-gpio.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index debadb48ceda..4071cb9eefec 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -125,16 +125,13 @@ static int create_gpio_led(const struct gpio_led *template, return ret; pinctrl = devm_pinctrl_get_select_default(led_dat->cdev.dev); - if (IS_ERR(pinctrl)) { - ret = PTR_ERR(pinctrl); - if (ret != -ENODEV) { - dev_warn(led_dat->cdev.dev, - "Failed to select %pfw pinctrl: %d\n", - fwnode, ret); - } else { - /* pinctrl-%d not present, not an error */ - ret = 0; - } + ret = PTR_ERR_OR_ZERO(pinctrl); + /* pinctrl-%d not present, not an error */ + if (ret == -ENODEV) + ret = 0; + if (ret) { + dev_warn(led_dat->cdev.dev, "Failed to select %pfw pinctrl: %d\n", + fwnode, ret); } return ret; From patchwork Mon Oct 16 16:10:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 153522 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3568055vqb; Mon, 16 Oct 2023 09:10:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbPFkOlSGpliAFvmDdA/gnk62u+OkZid22HPogGA6VacPh6PT4UZTR3o4dG9z5itNYACuJ X-Received: by 2002:a05:6a00:3ab:b0:68f:c309:9736 with SMTP id y43-20020a056a0003ab00b0068fc3099736mr36999871pfs.3.1697472643524; Mon, 16 Oct 2023 09:10:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697472643; cv=none; d=google.com; s=arc-20160816; b=XgPZPQMuAYdXkmKnqve0Tp3bxYsaNIoq031Q4dtuIFVXeFhP6OQ0/26oqz8RuM0J65 8aRNNYlM8Lf9Zyfv2aa6lCi/gQo62q8Fiwe5SVUEacA+bHZVL8mFSwOn5NpqQw4S4VFj 8pjxHj6CJxqKMm7gC6fRidyaJeQCWoO89gDuR1/AHfIqwSG3YCZsTOMw7zwIKiobYaT2 FF5Sfx7M1d0FNzWxuuoQv+rd30PRY/1l8cwK2rG8UE3NwbSdtB0tzRBFk7a+c0RwrDzC MIG179W1Sxoht/3UpmHrgS6S9L7BuMO6MxPoAoocrZ++BwTXn3cRMznMP55nHWzqACWQ Yfgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CDR1a7xt6ZJYPRWWiq0CblEP4joA3afoPGYLYgeKJis=; fh=tUAC4oQq3UuKajr6ZMoB53sspoioCuMU4y0NrDbDhac=; b=WOMUnMCisp0v9ud0ja6dot4ZA5n+8bpq4Phun8uRfhqCoCXwWqqa429T2MUjH7cwmu eljirofdW94ghSPtDblXpDYiJ9rQEOjpNlgbApi0gF3rTDSJ8AQnryyno808Pc026+Gg vSOT0qmHmCXE8/zlT70JTqZwFoHzpD6Q/tsAMetpSX9EWp7E4te8bxf6KBFLb50XHKOw nI56zakbCZYPFpyDJxzsxCtjm67BxqlwRFyw5X2o2qbc4J5Up9LChvgJ8NZkLWMiYtsw ad4LpspEIw3fJYbDBvzAKNuB/x6NT0KKFD3p+ht1Cjsip4fK5FntGWjKUoiXUe0a11hR OJ8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W3XBeBwP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id o27-20020a637e5b000000b005b7d9aace98si1401292pgn.109.2023.10.16.09.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:10:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W3XBeBwP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 43E848041C26; Mon, 16 Oct 2023 09:10:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233592AbjJPQKT (ORCPT + 18 others); Mon, 16 Oct 2023 12:10:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjJPQKQ (ORCPT ); Mon, 16 Oct 2023 12:10:16 -0400 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7482AE6; Mon, 16 Oct 2023 09:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697472613; x=1729008613; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=r8k8DrgrN+0Ylm+kKwsZKCjBoAC5iHc0h68Upva4lbg=; b=W3XBeBwP0RCbyD6FFJ4ceCkk822Bpj/04V+aN8hVF/zFR15tlSy5va8j Mm/SGAmt6uMwlOZWm9ROhZ7kmwjp7hQEp4ks6RnzS1EsIRQUKmCWEG80v nDrCG6t2w2qDXrjJvKQ6Mq7B9EE9FC9ZLFqsKZSAZcMQqTlNTAJjmVssc ffL3WMxdibM+w+pvIOnDFiAepyghe4R171MYYrAbwugZxiA1tl1BskwK6 iA+NnfrgGu976NKCUJbecXFsw0/+GMsrySpTQXKcz9L9HM0gjJszxMNua yLU9yZkPu1b/c9Zy0ZCz5d/AEaI8CQ4klq1WeanQIwKWgmUa8ZrgFpX59 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="4175724" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="4175724" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 09:10:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="1087124867" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="1087124867" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 16 Oct 2023 09:10:09 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 164EF85E; Mon, 16 Oct 2023 19:10:09 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 3/6] leds: gpio: Refactor code to use devm_gpiod_get_index_optional() Date: Mon, 16 Oct 2023 19:10:02 +0300 Message-Id: <20231016161005.1471768-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> References: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 16 Oct 2023 09:10:41 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779929074426997769 X-GMAIL-MSGID: 1779929074426997769 Instead of checking for the specific error codes, replace devm_gpiod_get_index() with devm_gpiod_get_index_optional(). In this case we just return all errors to the caller and simply check for NULL in case if legacy GPIO is being used. As the result the code is easier to read and maintain. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-gpio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 4071cb9eefec..7c9c6a93dfd7 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -218,13 +218,13 @@ static struct gpio_desc *gpio_led_get_gpiod(struct device *dev, int idx, * device, this will hit the board file, if any and get * the GPIO from there. */ - gpiod = devm_gpiod_get_index(dev, NULL, idx, GPIOD_OUT_LOW); - if (!IS_ERR(gpiod)) { + gpiod = devm_gpiod_get_index_optional(dev, NULL, idx, GPIOD_OUT_LOW); + if (IS_ERR(gpiod)) + return gpiod; + if (gpiod) { gpiod_set_consumer_name(gpiod, template->name); return gpiod; } - if (PTR_ERR(gpiod) != -ENOENT) - return gpiod; /* * This is the legacy code path for platform code that From patchwork Mon Oct 16 16:10:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 153524 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3568344vqb; Mon, 16 Oct 2023 09:11:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBvwQPWR0L96zDNK7/5DztwXf+4yWLsRhvO3gh/T6CuKzJx1g5shR+gcFx4YX0wG3dntDI X-Received: by 2002:a05:6871:8a18:b0:1e9:bb3a:9a32 with SMTP id tl24-20020a0568718a1800b001e9bb3a9a32mr10937838oab.0.1697472670415; Mon, 16 Oct 2023 09:11:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697472670; cv=none; d=google.com; s=arc-20160816; b=XK8Pnxex9TsSwJ8C6Dts162mcHEOOhEmSdmoGA2E36o8Gpuk0Odk1qXkXUz0qeOT2r jDcadhJUAHsC9+VAQ9U3/hcWKfyzrzk5Ix7ZRRriDZ+iANTqG57MZHICYQVhVu0E0863 3aeA2+xkFim+F4DTBj15USfXfqEraToBJjygONCHEs/EmwR7RsuWO6gW/EFLQsPqvzos rLq2q4gB1CG9y0uzlB2ojhS52bgBtT16fbSwVeuFSVIBOnM2b24JbvDGzbxiX5L+/gOA ij9kH+qd8wT/DG+lPOwU6KYfSSOQ7v8wJrUP6FnbMLXj26HO/5plajN1kszjFl/CHBec c+QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rqOOVsAirktxkKKJznLTHNl0T9SRt3OeaDHjnOFENc8=; fh=tUAC4oQq3UuKajr6ZMoB53sspoioCuMU4y0NrDbDhac=; b=iblIC7CQbxI4T51qLiNWXCVl/ZDl/UOFXXDIsamq0xqzfBVJ/Di2xiyCAh2M90gd0D /3rilfy5N5vF6ho1SbJeOsmgOdmvHXk/1dT3tBnHkcdY5OfJ3qcWEk6PhW9s48L83qW8 1LAnLsR6YDD1e6d9Hho/fRAORkdXRomjPPaefDfDhusIWD0YEBdmfpDcP/QjQaMC7lQm A9UZ0dHh9uXQVV/o2NRIdcwSepVDGL15cXiXdHHSPrethCs6Sly1SUf/Gc+hQveH8608 4V5CoBcgkIDF25wPLEWuXuvQFa+6d6De55OH6ydP9KnGisgtWFyvmh3GsTBCnCzt8FH/ ZERw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jQBJ2hwo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id u22-20020a63ef16000000b00585a4fc83fbsi10577088pgh.255.2023.10.16.09.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:11:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jQBJ2hwo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D380880309C3; Mon, 16 Oct 2023 09:10:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233750AbjJPQKg (ORCPT + 18 others); Mon, 16 Oct 2023 12:10:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233708AbjJPQKb (ORCPT ); Mon, 16 Oct 2023 12:10:31 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F44AFA; Mon, 16 Oct 2023 09:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697472629; x=1729008629; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=F25NQtPqRcWKTHovw7qS8Bdu+1VMkD5tR6I2DEWwAqs=; b=jQBJ2hwoROkx8FvePD8cc/B7D1l+VXlme1DFt/iGGBKcva08wcvm21sU 7OYV/1S2/wGFX3XV9lxfb+C23cQxCnQJMxX4Q31yYAph+X1TjxkHA39nf MhW6QMxPoM0JhPDi+k1gEDt1HdE/tThYJgG2Hm3fFb0n6+oC5aUPfLpVX HQsbdkID3+lHJDbZ13+zFpZ0zKzm7zRZXDYi6Pc8TulGgSmE3zYn+bj1B mhEGhydFuGMQCg5gmqjK/LYLpzGn4QEghdGhU353lPhh44hvcjOU1H0rx RzPaPqZdSZ0cGp5L/0AzMAgRsOIKSc/nY8mz+9i04oPYkRJRDJEBisRmL Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="7132780" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="7132780" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 09:10:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="785123039" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="785123039" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 16 Oct 2023 09:10:10 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2FDCE988; Mon, 16 Oct 2023 19:10:09 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 4/6] leds: gpio: Move temporary variable for struct device to gpio_led_probe() Date: Mon, 16 Oct 2023 19:10:03 +0300 Message-Id: <20231016161005.1471768-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> References: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 16 Oct 2023 09:10:42 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779929102726339468 X-GMAIL-MSGID: 1779929102726339468 Use temporary variable for struct device in gpio_led_probe() in order to make code neater. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-gpio.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 7c9c6a93dfd7..fd3f90f95fa2 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -142,9 +142,8 @@ struct gpio_leds_priv { struct gpio_led_data leds[] __counted_by(num_leds); }; -static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev) +static struct gpio_leds_priv *gpio_leds_create(struct device *dev) { - struct device *dev = &pdev->dev; struct fwnode_handle *child; struct gpio_leds_priv *priv; int count, ret; @@ -253,13 +252,13 @@ static struct gpio_desc *gpio_led_get_gpiod(struct device *dev, int idx, static int gpio_led_probe(struct platform_device *pdev) { - struct gpio_led_platform_data *pdata = dev_get_platdata(&pdev->dev); + struct device *dev = &pdev->dev; + struct gpio_led_platform_data *pdata = dev_get_platdata(dev); struct gpio_leds_priv *priv; int i, ret = 0; if (pdata && pdata->num_leds) { - priv = devm_kzalloc(&pdev->dev, struct_size(priv, leds, pdata->num_leds), - GFP_KERNEL); + priv = devm_kzalloc(dev, struct_size(priv, leds, pdata->num_leds), GFP_KERNEL); if (!priv) return -ENOMEM; @@ -272,22 +271,20 @@ static int gpio_led_probe(struct platform_device *pdev) led_dat->gpiod = template->gpiod; else led_dat->gpiod = - gpio_led_get_gpiod(&pdev->dev, - i, template); + gpio_led_get_gpiod(dev, i, template); if (IS_ERR(led_dat->gpiod)) { - dev_info(&pdev->dev, "Skipping unavailable LED gpio %d (%s)\n", + dev_info(dev, "Skipping unavailable LED gpio %d (%s)\n", template->gpio, template->name); continue; } - ret = create_gpio_led(template, led_dat, - &pdev->dev, NULL, + ret = create_gpio_led(template, led_dat, dev, NULL, pdata->gpio_blink_set); if (ret < 0) return ret; } } else { - priv = gpio_leds_create(pdev); + priv = gpio_leds_create(dev); if (IS_ERR(priv)) return PTR_ERR(priv); } From patchwork Mon Oct 16 16:10:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 153526 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3568493vqb; Mon, 16 Oct 2023 09:11:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZmn5+A+5PKwr14sD4nnsSlP8OoEtVyI7CnNqcHcMgZ6OIRF+iBFDwIsisusNoYecqYF1g X-Received: by 2002:a05:6870:ab13:b0:1e9:9f9b:eb7a with SMTP id gu19-20020a056870ab1300b001e99f9beb7amr15130170oab.4.1697472682881; Mon, 16 Oct 2023 09:11:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697472682; cv=none; d=google.com; s=arc-20160816; b=himpU9S+CA+sCWuuR3icQjBErxdknEylV5ycM2z+i3JKPpJa114VJGvsyvyvgDO9ce 74DY6ZGNUH5g7AGYEUZaBotKi4CxsS27rK7LYvp5iwF7fmtzz9GevspTzL17rXmylMaw 7JKnN8zopDokSdjOYu7xvapq4KtABpYH5H2pbNVJ9nhKoUrZsEZRhhpJFrV8Gl2mUahs Rh/cKEWUBQ5i2Nz5sCGJyV9ZYTruiUsRiKPl6Xpw1kjVXvOSjBJKavtFhnVOiwDkISjk EMQ2Fu7ReGghMIXnZlBXDU/3SGGWh3+QB9nxyC48DQUBD2pvWBgSJqEM+JJUt7ZfBhdX glLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LU7WfR01LO969aOUKAeYir58Lkl8yZMKqu9q5Tdg8Jw=; fh=tUAC4oQq3UuKajr6ZMoB53sspoioCuMU4y0NrDbDhac=; b=UZwPV8l1ywDFhYgr2M7jP3d8oRL+6/Irby2qgzLViU1Nb4kYilF/9frK2gsCetmBT0 65vytGkrTwdKIx7ZV8zduSEgkftDBzsVnXPgxOsxkuZz+2bcnSvZ4B3/mrgF9EoG9we3 6uDLXGPyHlZ5FpLiBVhzil+8XRpzG4Bt9iuV8M5ZHzvFiCdk317tDJQzpyC3iUGoU6e6 QuSoL9nly5Ls92YyziHs9XzJgQbM59fTNun1Cj4Eo5nLd1bEvqGZXW4UqjZiCdi5UfHC ZdmJPuXMNNRySs69x2RAY5X0IvAOd9pvRNpdsoguGcZXjMfY1GwKtxKYYCVKgNYBoChS 6oeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JhGn1Lyf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id a185-20020a6390c2000000b005af21fd2c7dsi6856842pge.412.2023.10.16.09.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:11:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JhGn1Lyf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 6BB4F80239F0; Mon, 16 Oct 2023 09:10:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233869AbjJPQKl (ORCPT + 18 others); Mon, 16 Oct 2023 12:10:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233737AbjJPQKd (ORCPT ); Mon, 16 Oct 2023 12:10:33 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BE46FF; Mon, 16 Oct 2023 09:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697472632; x=1729008632; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CCalplfZS+ACuqT2hqG7Ibb2XR+tCJlozM7ZHTv3bHw=; b=JhGn1LyfunZ/wca0dwSmDDen57X1DmjedFlLs7cOs/Gd+MFh0QZnjGXO D+wvGqdNr6FHpCGj8w2d8Yh4B2pERtWdxPMwRRZU0lv4dbMdCXu36T7jc YJacfUCM7xLYuDFo++im30hfm4umwxA8AK+Qd75tul90Hhel5eZt51Xzg C1piMhyBQxpk9I6JsZVmVYlT7jQiJoh7d1DA+AOohiNmbKetWIwe/hfdn xp3Ge7XRZk4U/3PV2nDt0927Syz/vsodZ7tTzMNu1PugEUQ8DBVEN5l9K G06srvU/FjFHyLHTkQN4+JX63JuQyfCmxFzcRSh/ShIEaFBkhd6q1a3AC A==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="7132787" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="7132787" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 09:10:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="785123040" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="785123040" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 16 Oct 2023 09:10:10 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 36C5995B; Mon, 16 Oct 2023 19:10:09 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 5/6] leds: gpio: Remove unneeded assignment Date: Mon, 16 Oct 2023 19:10:04 +0300 Message-Id: <20231016161005.1471768-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> References: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 16 Oct 2023 09:10:53 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779929115773953100 X-GMAIL-MSGID: 1779929115773953100 The initial ret is not used anywhere, drop the unneeded assignment. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index fd3f90f95fa2..d6e8298ffb3e 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -255,7 +255,7 @@ static int gpio_led_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct gpio_led_platform_data *pdata = dev_get_platdata(dev); struct gpio_leds_priv *priv; - int i, ret = 0; + int i, ret; if (pdata && pdata->num_leds) { priv = devm_kzalloc(dev, struct_size(priv, leds, pdata->num_leds), GFP_KERNEL); From patchwork Mon Oct 16 16:10:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 153527 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3568880vqb; Mon, 16 Oct 2023 09:11:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyaoiC9Iv4OpRPXVR38FmBoBLXRrS3gRJft6cu51o8Yay7ovMYwVharPXYdZAQDZvA1gl1 X-Received: by 2002:a92:dacc:0:b0:34f:b824:5844 with SMTP id o12-20020a92dacc000000b0034fb8245844mr33013725ilq.3.1697472714921; Mon, 16 Oct 2023 09:11:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697472714; cv=none; d=google.com; s=arc-20160816; b=sVpLKgbIIeHFNvMrhor70ZNqm5o1K+FRMd8nzX9H9snr3jSiUQ+v/3QSWZBhiEuAUQ ZAhbTHi/O29ny1KDTPHqJgRID6oBgCunzeEubSXC9TRwgrCB1zRNDjArGb0byy8Q92x/ IfCALL+Baun0h6S+cunz4II4yNfNJ69ELvkOzGS7qPbHc49kPlp3AQo9sHnqvX9LoGwu qRzRs8C0jgUn3aGZkoKK5GHAqUfIEUt2+KbmJ97XiCIxL8s8SfhzYam3Y6r0Zc0FceaX 7YjAWlkARwN/Vjl1p16M84QMmcguSB8fPugIpfUM9LwyUY/3G5gHSH2vOgcbr9ae8nQ5 HPKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hSmNLOk1PopqU/gM7xaFHc3A4LS1NNDNZHf+785AecI=; fh=tUAC4oQq3UuKajr6ZMoB53sspoioCuMU4y0NrDbDhac=; b=K5BlFadLTkjmZiNB5BewVTF6RdzDY/vYLmOY0r/IetP5d3ComfGAESa+kYnODOSxpc hcwaaf1AoFe+oA3H3Cr0OGS/tponYjjVT6XylBRxvQO1QIGpcYr4XLcB+4RN6AeAq5LK dtKgq5Y1BDMfLjDkOCLRuBA3RBZH2ZzIvcxTwADqj8YHl6V/wZQ6Mcqr9rAem6NjdmH7 5F4dohn7ASTr7A4yDJhWO1/07vDgmT4qXpAE+2zQWuPtaiT5DJOswwDBhJP49jCFMHMZ DM1AMnk+7CY1aAWADW1DiBQYJAzzGqoZD1qRWboGNCfAfjbzlsmPFPfxGlP9X0H5a8Cp yvqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cVj697Gd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id o7-20020a056a0015c700b0068a6f6d9f7dsi149644pfu.57.2023.10.16.09.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:11:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cVj697Gd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 1712B809BE55; Mon, 16 Oct 2023 09:11:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233943AbjJPQLT (ORCPT + 18 others); Mon, 16 Oct 2023 12:11:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234026AbjJPQLF (ORCPT ); Mon, 16 Oct 2023 12:11:05 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C78AD56; Mon, 16 Oct 2023 09:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697472658; x=1729008658; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YUkxCSHEq/3rOrfuT0Fg4DI7Hj9/49mwADVgWbNCxXM=; b=cVj697GdHtSBBYSmilaMSM9/h6D4j+erxXqGAXQmtopyenkoDo2pzX9/ J+0HhVJ1anSDYgaqvoz2/98mKksvXyzpIcjs9GHt+zeaUgBHcAXRjleI7 DsIpUMu1TRka2M7uAUAAFk7cwE65ty1cNRGRrx1xZ1WM0InPlWiFzpaKM 1xQI+abtg4UAy54tdOrjPEb5BavkyLojTzArkqwrvVidp2HYSEhtIedTF JcL50o5lhO38Q7BL+SGKHVSyMF3cVBtmwJ2+S31YKVMY/AJeBW8o2oGA9 K0vdnlyuQlnkRQYEJZaiysr9GPZlao5/Vaaq4hF13Q0oq1903IUCVGoYQ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="384440997" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="384440997" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 09:10:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="790856636" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="790856636" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 16 Oct 2023 09:10:13 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 48A5EA46; Mon, 16 Oct 2023 19:10:09 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 6/6] leds: gpio: Update headers Date: Mon, 16 Oct 2023 19:10:05 +0300 Message-Id: <20231016161005.1471768-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> References: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 16 Oct 2023 09:11:46 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779929149474153870 X-GMAIL-MSGID: 1779929149474153870 Include headers which we are direct users of, no need to have proxies. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-gpio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index d6e8298ffb3e..710c319ad312 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -6,17 +6,21 @@ * Raphael Assenat * Copyright (C) 2008 Freescale Semiconductor, Inc. */ +#include +#include #include #include #include -#include #include #include #include +#include #include #include #include #include +#include + #include "leds.h" struct gpio_led_data {