From patchwork Tue Oct 10 21:35:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anjali Kulkarni X-Patchwork-Id: 150979 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp149535vqb; Tue, 10 Oct 2023 14:36:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGugfIZrL7UAXEP2nlPx1u1wmZl/9jj8x4T1JJTYRqRwiL5X4DFvdXQgW6cOevIJiqHsgxv X-Received: by 2002:a05:6a20:431e:b0:13d:fff1:c672 with SMTP id h30-20020a056a20431e00b0013dfff1c672mr22409349pzk.4.1696973776695; Tue, 10 Oct 2023 14:36:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696973776; cv=none; d=google.com; s=arc-20160816; b=SaSzlh/hsswZf4ymBAVPePZK/A0o9OoHk3+MafeZ4QcJbd7U4aLSUh9qkrudMnvTwU JWD+IilezMgOeH2fk1lgTT0j6A41assFJab5gqhSPuSTUEM6f/0jyNF84ezM15gJGoeQ ttQc1klphUVnphr5h0A84K1vZdM8hgsOd5l2oXs7H/0lcR4mYzApHznRl9+MJ0sec5KW KgfjhDEwok8ArghMWXXbZErVKkY8Gd97PiONNIKeeAmztV4+SDiXzB91+TCYtDfe2/Dm z7wLNIevVA4q2vV/OWj79ylbpfCltunvpa2E/06UZ9vjvpMuKjVq1sgLqTWixImQVFWz n3cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=dICtayujaDLXxBVyN4pCkVIs4d2R84yHSjMED1WJ9Yk=; fh=wtHsPkwm51EVBMiuRCXC3c/87q1/1vrds+p2Dsdv0PY=; b=wSfxSTzVQUeQgJSXVXmeqXAcBK0H4meGaY1pP6YLucWM+mqoX4PBgnTq6Yxg8OSpc6 6mBoS9vt+vM8HItVn1ocbZdguBfsdqlKcENaE6gtZMLXoFRLcAQuoVZaS5BxSPUbUwC5 wEIZlSsK3I5v9Prz9M40fTHP2ygU3AXCrxXZRrfE3wpnqgT8p6kSZ9slCHiOM/1VYWf2 8FUab3ZGkcJvOs4QQULQIYOa+h59TqgeWazOXyn7vfQTX4wAfb4WpCqE7dp4i6TL0/vU CNwfWxeyUVHm9JhM1nEMN/Uy+ORRAwViPmHWKVTfyo1371S32K2pHCQd5sz4OkE467lq sT0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=cL5d3HTU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id d2-20020a633602000000b00578a6aaae10si1440282pga.86.2023.10.10.14.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 14:36:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=cL5d3HTU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 76F898026C21; Tue, 10 Oct 2023 14:36:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344099AbjJJVgB (ORCPT + 19 others); Tue, 10 Oct 2023 17:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343936AbjJJVgA (ORCPT ); Tue, 10 Oct 2023 17:36:00 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A014294; Tue, 10 Oct 2023 14:35:58 -0700 (PDT) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39AJiDtW025689; Tue, 10 Oct 2023 21:35:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2023-03-30; bh=dICtayujaDLXxBVyN4pCkVIs4d2R84yHSjMED1WJ9Yk=; b=cL5d3HTU5aUQabgA7jlvyhz1NmTyr3h4gUoGq5lcNIB+gU/+gcN+eglkyEY5Mqh+oUCz 8rgOITE+FxRdOiLErAAzjBTgguhljVUNx9AISK/R8MMKNXivI5nJ3EZM9IC16b3hhGE+ bZ1dO5cH9bW4cbeEv8Sgpa1xfueR/+EQsuurgX5TxCKqLCmwCvmPLg5TUE9sdcNIN0zs kZnP7G77ECeZT4erwzc3MUtCYNdFFR30ad/Jw24rqhU8N3rWPNNBRtO8tmytHkMkXZyY Cu5bQ/Np2/hv8EKqI8ZxIimDaUv3q5bfrW3jUy7KGVWZg7SoapBN0TbVuNDhszGJ6lBB YQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tmh89uvms-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Oct 2023 21:35:51 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39AKGrDu016249; Tue, 10 Oct 2023 21:35:50 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3tjws7hxhv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Oct 2023 21:35:50 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 39ALZoqA036182; Tue, 10 Oct 2023 21:35:50 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3tjws7hxhd-1; Tue, 10 Oct 2023 21:35:50 +0000 From: Anjali Kulkarni To: linux-kernel@vger.kernel.org Cc: davem@davemloft.net, Liam.Howlett@oracle.com, netdev@vger.kernel.org, oliver.sang@intel.com, kuba@kernel.org, anjali.k.kulkarni@oracle.com Subject: [PATCH v1] Bug fix for issue found by kernel test robot Date: Tue, 10 Oct 2023 14:35:49 -0700 Message-ID: <20231010213549.3662003-1-anjali.k.kulkarni@oracle.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-10_17,2023-10-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310100167 X-Proofpoint-GUID: Z8fvfdgWeJ36H0ZF6NyiWuTcW8dUc4VO X-Proofpoint-ORIG-GUID: Z8fvfdgWeJ36H0ZF6NyiWuTcW8dUc4VO X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 10 Oct 2023 14:36:14 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779405974885624017 X-GMAIL-MSGID: 1779405974885624017 cn_netlink_send_mult() should be called with filter & filter_data only for EXIT case. For all other events, filter & filter_data should be NULL. Signed-off-by: Anjali Kulkarni --- drivers/connector/cn_proc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c index 05d562e9c8b1..01e17f18d187 100644 --- a/drivers/connector/cn_proc.c +++ b/drivers/connector/cn_proc.c @@ -104,13 +104,13 @@ static inline void send_msg(struct cn_msg *msg) if (filter_data[0] == PROC_EVENT_EXIT) { filter_data[1] = ((struct proc_event *)msg->data)->event_data.exit.exit_code; + cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT, + cn_filter, (void *)filter_data); } else { - filter_data[1] = 0; + cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT, + NULL, NULL); } - cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT, - cn_filter, (void *)filter_data); - local_unlock(&local_event.lock); }