From patchwork Tue Oct 10 12:49:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alisa-Dariana Roman X-Patchwork-Id: 150753 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp172285vqb; Tue, 10 Oct 2023 05:50:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZ2iFjiihPmiQOMgVujIM97eUYAZODBT65edL5gNpcY4s2Fo/yC0sAgVkcUFxnPjHubfu4 X-Received: by 2002:a92:cd8f:0:b0:34d:f390:4882 with SMTP id r15-20020a92cd8f000000b0034df3904882mr23886700ilb.29.1696942240100; Tue, 10 Oct 2023 05:50:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696942240; cv=none; d=google.com; s=arc-20160816; b=Su4sedNtAe5lJ5YP9/uN1DLml6l5iWu8a0T+ry4CgyRK42I1926hT4qvSiURCA3vr/ nk7iWM6k/i5CuCpnnZRFMLlb3zAh5OfQxN+BBzGdcSDWAE2PgqAecahfRWL9xLMbs82Z z2X8YpR2544sM62Ig6Y6NVc+GzH9SNBMUMeMtZOUv44DXER7CYkMf2NvbHD+KkZeICgt /hVjp8cDzBhWYioZ+eM6fpd/FqIU6uED4lqskhl7V0KrLber3qq1JMdFFBcU0GD23P4H Uavt701jKcFFN3ou/rjj7gGqk4JdptHfLEBtgAG+VX3wDI6rwZ/CEK+jIFqRihoRl+xb hFrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=8suyV6sP7GoitIkAdNCXlUthdUiktEklkTsQndWCoo4=; fh=BUJlbtVCGzcvSzdsTEb7Eh+xds4QjC/IPLEZG4QGcfo=; b=lvNBtA9WXK1Z6nA3Ye8wZnDQvgZ7GWUNfblGzluGnZWHeGxnDexhKEouMF36huN8N7 ar9cIl4o+Lds5XB9MaN9nYvsjUxKdpEGPFcUan3oSO/boi2qJfHDNrwGSTyyWQ+VfcAT sMqwYqztl6p8eh/4Xqg5v0ZqWxtkHLx9flep3FalCLuuFUdimnePR3eQR9kXlQ1aPic8 Nh+XkTgtyzOErO5QJJ/8lnW5JMNWsFfOauhjvFD3rFTS/D6huF21AeS5fzC7IKY+5ocV UigXRjpbY+k3kGTkreE/Uo0Jd+VLXtN5Jmv5FDxWhWWNGOzaQYJRWCkky9wGRnVqekLf iMFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20230601 header.b=D9Rq9MmL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id a21-20020a63e855000000b005784ab1c4afsi12247083pgk.736.2023.10.10.05.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 05:50:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20230601 header.b=D9Rq9MmL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 552E3801B83E; Tue, 10 Oct 2023 05:50:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230220AbjJJMtp (ORCPT + 20 others); Tue, 10 Oct 2023 08:49:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232008AbjJJMtn (ORCPT ); Tue, 10 Oct 2023 08:49:43 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54F55CA; Tue, 10 Oct 2023 05:49:41 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5344d996bedso9974804a12.3; Tue, 10 Oct 2023 05:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696942180; x=1697546980; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8suyV6sP7GoitIkAdNCXlUthdUiktEklkTsQndWCoo4=; b=D9Rq9MmLhxJhe4SOtCRmYdd2P7hqMoclRZHoyiZEOXs5tdlEAW9vKAw+6LbxRzpovU FwBO+bp2XFs18u6y0RYnUSh0+n2jzsfIG7s2yCsw7MLvWRp/S4iHavKUmWiBqNO3yIHb SBZFI5ThUn65JfATyYZrb3qRHYJftHP4JMwvY+efL8Ji7NEmcL6VLnlJn4sWAeIbnQzr bul3pZ+H+y3BiVAm+bP04uoN1Z1PYxF3sHtIB+RL+G9YiaJcdrryIaKhOmqbl6lvouTK 84Pw6Cp2ss0DqvMHYkWHqwg4x8t54j82iYsRzaw6fSDlye8jkolS0zXkR6qN9iY3zpkx nk2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696942180; x=1697546980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8suyV6sP7GoitIkAdNCXlUthdUiktEklkTsQndWCoo4=; b=Na6JOJQUgV4aRWg+Libdr6SNInUFZlZrzsZxYoUx4foX/45Z2dXkdKnqYOn6FA4YUu K/JvPiFswaoC3+tg07UbBheh48lathoo/Ph/5TaUyKSd/R+sZeRGGBXxcLwWxmcIkCZk 4nLUc8OExEra2HP7YHtnP4Jodrukg3S0GkKnlCIIA3b6YGPeybDCWmjk+KhmkXq3IrVO BlYhpAs2eW6HnIX4alyVtcZOQcTVlbVYP4VUX/Cd9OHtFkYQls+B0ibvp4EZPFUCYZz4 6l70IWcsj5W4G4X2/8vxmhX7H/YHrGTRNJH9lWnUIP6S4yqnjtQ7/F2L3rVWECvBd0SX Xp5w== X-Gm-Message-State: AOJu0Ywsv0Sr1S9wwJkcJjPow+51h5yGuXur03Y69uPOS608mNGKulMM XrUffhsx5Yt55OpGyo/bdgA= X-Received: by 2002:a05:6402:c4f:b0:53b:b110:1bd4 with SMTP id cs15-20020a0564020c4f00b0053bb1101bd4mr6386093edb.6.1696942179656; Tue, 10 Oct 2023 05:49:39 -0700 (PDT) Received: from spiri.. ([5.14.139.113]) by smtp.gmail.com with ESMTPSA id f26-20020a056402005a00b00530bc7cf377sm7629476edu.12.2023.10.10.05.49.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 05:49:39 -0700 (PDT) From: alisadariana@gmail.com Cc: Alisa-Dariana Roman , Alexandru Tachici , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/3] iio: adc: ad7192: Organize chip info Date: Tue, 10 Oct 2023 15:49:24 +0300 Message-Id: <20231010124927.143343-2-alisadariana@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231010124927.143343-1-alisadariana@gmail.com> References: <20231010124927.143343-1-alisadariana@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=3.3 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 10 Oct 2023 05:50:08 -0700 (PDT) X-Spam-Level: *** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779372906152496548 X-GMAIL-MSGID: 1779372906152496548 From: Alisa-Dariana Roman Move all chip specific data into chip_info structure. Signed-off-by: Alisa-Dariana Roman --- drivers/iio/adc/ad7192.c | 45 ++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 27 deletions(-) diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index e0be394ccb34..d72a190c5109 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -171,6 +171,9 @@ enum { struct ad7192_chip_info { unsigned int chip_id; const char *name; + const struct iio_chan_spec *channels; + u8 num_channels; + const struct iio_info *info; }; struct ad7192_state { @@ -964,39 +967,33 @@ static const struct ad7192_chip_info ad7192_chip_info_tbl[] = { [ID_AD7190] = { .chip_id = CHIPID_AD7190, .name = "ad7190", + .channels = ad7192_channels, + .num_channels = ARRAY_SIZE(ad7192_channels), + .info = &ad7192_info, }, [ID_AD7192] = { .chip_id = CHIPID_AD7192, .name = "ad7192", + .channels = ad7192_channels, + .num_channels = ARRAY_SIZE(ad7192_channels), + .info = &ad7192_info, }, [ID_AD7193] = { .chip_id = CHIPID_AD7193, .name = "ad7193", + .channels = ad7193_channels, + .num_channels = ARRAY_SIZE(ad7193_channels), + .info = &ad7192_info, }, [ID_AD7195] = { .chip_id = CHIPID_AD7195, .name = "ad7195", + .channels = ad7192_channels, + .num_channels = ARRAY_SIZE(ad7192_channels), + .info = &ad7195_info, }, }; -static int ad7192_channels_config(struct iio_dev *indio_dev) -{ - struct ad7192_state *st = iio_priv(indio_dev); - - switch (st->chip_info->chip_id) { - case CHIPID_AD7193: - indio_dev->channels = ad7193_channels; - indio_dev->num_channels = ARRAY_SIZE(ad7193_channels); - break; - default: - indio_dev->channels = ad7192_channels; - indio_dev->num_channels = ARRAY_SIZE(ad7192_channels); - break; - } - - return 0; -} - static void ad7192_reg_disable(void *reg) { regulator_disable(reg); @@ -1051,15 +1048,9 @@ static int ad7192_probe(struct spi_device *spi) st->chip_info = (void *)spi_get_device_id(spi)->driver_data; indio_dev->name = st->chip_info->name; indio_dev->modes = INDIO_DIRECT_MODE; - - ret = ad7192_channels_config(indio_dev); - if (ret < 0) - return ret; - - if (st->chip_info->chip_id == CHIPID_AD7195) - indio_dev->info = &ad7195_info; - else - indio_dev->info = &ad7192_info; + indio_dev->channels = st->chip_info->channels; + indio_dev->num_channels = st->chip_info->num_channels; + indio_dev->info = st->chip_info->info; ret = ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info); if (ret) From patchwork Tue Oct 10 12:49:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alisa-Dariana Roman X-Patchwork-Id: 150754 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp172396vqb; Tue, 10 Oct 2023 05:50:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFciMlLM2kE0ndC2Hrx5vSJrGTDT8a/MHLMoDP5nXXiXxSCGp+hilIAXHZvuZCgFG8VVnU9 X-Received: by 2002:a17:90a:c7c7:b0:274:751a:3f3 with SMTP id gf7-20020a17090ac7c700b00274751a03f3mr21165142pjb.7.1696942254909; Tue, 10 Oct 2023 05:50:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696942254; cv=none; d=google.com; s=arc-20160816; b=aMM6b+cCRTJeaZCUcZQxjqOgrww0EJOBT3CRW9NQbUz/G1lJimefm7gACIWEsJGQiV oTdu9qLdgM8Wi858gyMDOWWsRHcgxeiMgIzCK1Z4KclY3paHhtBWstK2A3vC8qVGviP6 JQWyD3tWq6u7h9eyNOHDi/DfDoCzAc3NUpaMrFaTZHBOqI7rahbl87jNcZKXBV+Ygqbn du01eOBQjWG7cqL8EYw9afPRNQSSJtsbFITnCpYJGHo9eB+HYKZo/PK8Hmqrk5SDCWwk N+FRHOaSU1P+MKxkl60yc1fYGQuE2Q2Ogln6bq/ER31LRDZTMgZTGBFCRLmo5cuPUocu gHtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=zpyGzsJqUZOdlNhUzdO0XHC5n7dKd8p4LRJo7y5zFRo=; fh=xFhSPHmTnhgoOeC8pQAxFHg58H3M3s9acDkisPDPvtU=; b=kZMe3NvSKt2CT3AFKI7nVXsXYupfD1YB8UiSGYmW42R1/mvVgt8AgkJsNjUgBnm8/J jMeEQQO5IAaBymNUNSRgbQx8xP8WkPFDkm0ErH7GFgvR0EaBnnGUwTlOvLaqgS+zNA2t 75nK0Z8TY7QoNy2F6w3nlp5XEr1vXiLV6YAUOSxx7m2GsS+RKxmE+VndWVn2Osl2JXkK gw2joyzEhg3E35vPhmWCDksk9jpv88xy3t2czdqudlPrNH0HZw3tytQkfYQOFzxwvstY dPoFcJkkRdjrSO7JQinqRowPryFucV3xP873OXUBTEgr+0h+PJRZ4yT8MLGotrNq2y8m PaLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20230601 header.b=MFsqCqzB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id pc13-20020a17090b3b8d00b002774cdc919csi14452603pjb.176.2023.10.10.05.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 05:50:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20230601 header.b=MFsqCqzB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id C91A18083A96; Tue, 10 Oct 2023 05:50:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232083AbjJJMtw (ORCPT + 20 others); Tue, 10 Oct 2023 08:49:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232047AbjJJMtr (ORCPT ); Tue, 10 Oct 2023 08:49:47 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B60D4C4; Tue, 10 Oct 2023 05:49:44 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-53b8f8c6b1fso4859072a12.0; Tue, 10 Oct 2023 05:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696942183; x=1697546983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zpyGzsJqUZOdlNhUzdO0XHC5n7dKd8p4LRJo7y5zFRo=; b=MFsqCqzBwtbPYkZzimJkkeelASqdtkzchD5ExD1ibdNERTvEPuSUn+FPECCnny1ipw I08tty6E7rONJqMnQdToCqhmgmbtfYJB68+aA3UnDEB8HO9/2/Meptj9oxj9LOyOT2zA MpxQCqleVZaGZhR44IFLfJVO0Y0KpUmgyMqRmaeHe0ydhjSjl9IrHMHjvmaLJpn+K0Cl ymV9VFLdJVtNShUlFx74e7vdsQLxN1tYSZX+oysda1+dxnW7ZRakjodlTxJQ76n+HT5J QP2AKz6CsWkAbLhXltVFuoJ9gHh/slaqD75vpYoKr7oCI83mJPe76IcADuhg2o+tY+VV 46aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696942183; x=1697546983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zpyGzsJqUZOdlNhUzdO0XHC5n7dKd8p4LRJo7y5zFRo=; b=LpXEmzkjiMbS2+5tU3snaGSDmDhi98Kyz33C0cwwoRcQsNejLnKkagK2Z+96x3XpEU bW6iujbVAJzmQfFTZ8ebkkpp1uv6SA01+Fx2jm6YjZ60QKqYiNfdLAkifyMnrMD5ox7W H8CAbcqGMr3aGNaH35ie/BzueTI7jZAZiX+Oc21D3jwhTxk8AxZt6oETREeWjoXTqIta 300j4TrartMUl0iEWvPX8Dv26SZI7SSuTXP/K8BmdrN+8zGHTuujGP9ZXakNGTuML/wu Gzb+C+lTmMnomS4Xw6Bx94obq/WmfUV/zAzWIOMDc6X4ieYWh7OFl15tOMS+pNeuGvaS zw+Q== X-Gm-Message-State: AOJu0Yx3Ct/77HfoEPTPKWh1SUEjiCcxNiCDmrX61T6SdM8wwUHGGcLw V0XjamGS+Z9rbR+d1sXNSUg= X-Received: by 2002:a50:ee91:0:b0:51e:53eb:88a3 with SMTP id f17-20020a50ee91000000b0051e53eb88a3mr15020100edr.25.1696942182843; Tue, 10 Oct 2023 05:49:42 -0700 (PDT) Received: from spiri.. ([5.14.139.113]) by smtp.gmail.com with ESMTPSA id f26-20020a056402005a00b00530bc7cf377sm7629476edu.12.2023.10.10.05.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 05:49:42 -0700 (PDT) From: alisadariana@gmail.com Cc: Alisa-Dariana Roman , Lars-Peter Clausen , Michael Hennerich , Alexandru Tachici , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/3] iio: adc: ad7192: Remove unused member Date: Tue, 10 Oct 2023 15:49:25 +0300 Message-Id: <20231010124927.143343-3-alisadariana@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231010124927.143343-1-alisadariana@gmail.com> References: <20231010124927.143343-1-alisadariana@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=3.3 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 10 Oct 2023 05:50:11 -0700 (PDT) X-Spam-Level: *** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779372921936688779 X-GMAIL-MSGID: 1779372921936688779 From: Alisa-Dariana Roman Remove extend_name from channel macro since it is not used anywhere. Signed-off-by: Alisa-Dariana Roman --- drivers/iio/adc/ad7192.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index d72a190c5109..fe47ef43b3d7 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -895,8 +895,8 @@ static const struct iio_info ad7195_info = { .update_scan_mode = ad7192_update_scan_mode, }; -#define __AD719x_CHANNEL(_si, _channel1, _channel2, _address, _extend_name, \ - _type, _mask_type_av, _ext_info) \ +#define __AD719x_CHANNEL(_si, _channel1, _channel2, _address, _type, \ + _mask_type_av, _ext_info) \ { \ .type = (_type), \ .differential = ((_channel2) == -1 ? 0 : 1), \ @@ -904,7 +904,6 @@ static const struct iio_info ad7195_info = { .channel = (_channel1), \ .channel2 = (_channel2), \ .address = (_address), \ - .extend_name = (_extend_name), \ .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ BIT(IIO_CHAN_INFO_OFFSET), \ .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \ @@ -922,16 +921,15 @@ static const struct iio_info ad7195_info = { } #define AD719x_DIFF_CHANNEL(_si, _channel1, _channel2, _address) \ - __AD719x_CHANNEL(_si, _channel1, _channel2, _address, NULL, \ - IIO_VOLTAGE, BIT(IIO_CHAN_INFO_SCALE), \ - ad7192_calibsys_ext_info) + __AD719x_CHANNEL(_si, _channel1, _channel2, _address, IIO_VOLTAGE, \ + BIT(IIO_CHAN_INFO_SCALE), ad7192_calibsys_ext_info) #define AD719x_CHANNEL(_si, _channel1, _address) \ - __AD719x_CHANNEL(_si, _channel1, -1, _address, NULL, IIO_VOLTAGE, \ + __AD719x_CHANNEL(_si, _channel1, -1, _address, IIO_VOLTAGE, \ BIT(IIO_CHAN_INFO_SCALE), ad7192_calibsys_ext_info) #define AD719x_TEMP_CHANNEL(_si, _address) \ - __AD719x_CHANNEL(_si, 0, -1, _address, NULL, IIO_TEMP, 0, NULL) + __AD719x_CHANNEL(_si, 0, -1, _address, IIO_TEMP, 0, NULL) static const struct iio_chan_spec ad7192_channels[] = { AD719x_DIFF_CHANNEL(0, 1, 2, AD7192_CH_AIN1P_AIN2M), From patchwork Tue Oct 10 12:49:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alisa-Dariana Roman X-Patchwork-Id: 150752 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp172149vqb; Tue, 10 Oct 2023 05:50:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGarwSDdOWirDzN0VLKg3gq/0nx4cGdNkNueskO+pXhHjABNXDpWVMqm8YEojtfLI0Y22T X-Received: by 2002:a17:902:c24c:b0:1c3:ea2a:9058 with SMTP id 12-20020a170902c24c00b001c3ea2a9058mr14042134plg.65.1696942224055; Tue, 10 Oct 2023 05:50:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696942224; cv=none; d=google.com; s=arc-20160816; b=geqqlOsCLx+rVMkbYqqaWBDvYztnGVpglcqxzKIaLdRB1zoSUaKO0MSs69Rgt6nZVW 1zMe/c6m4B9GI4T6AUkhSTuetwlpzujJrUccjS45FX4CpeFE28a+2qiG3dDmB0iJQ/eR C4m2Ol9+pLjYVazSeKO0+cKQRvAE5KOztuvMPvQ139dJ8W8i0eaz8bK8QQ+Yrs8aced6 9kHCd6xNORHEm6xLw8Tvmizncwyo+RGeP0Nr3x094LfK5pBTGcBSSMlXzS4KtnYxuD/j qWXOUrKUhrGHPIhTlEII6iXrkQowjtvMEBKTVGoM5wtTnULc8ZjT4L13ZVY2JvnRdyYd 6HfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=msy7jv8g0SLNU2c8sB4y8hw1WS5I1nkPJ94zB1gQH70=; fh=BUJlbtVCGzcvSzdsTEb7Eh+xds4QjC/IPLEZG4QGcfo=; b=kMl0UIJVnn7ieRB0DweGyrke3rgIucX/kxd9i3hnyi41Zrll7l6rAcF0Q19Wc/Lo9K J2yhRni5bRjWAi/h97AMgpl3rySX1/mdSyT9cUEHQFT9PRknUNa9+vJ0sxlmkS60ZvE0 outH5tPxFWystp/Lafepev2t0OXDitWTxyub1hiAA3GhwdASRwe+nUcUyqkHYA3ayFOc ZhW12L9fWpzsFiovHHsI3em0JwguyQpeJ1+lNxq2dldBD2SY0lgOwL9gSS7iTkqE6b1J FqY6eb5CM2O1xNAR9+EfPM8lN40eMOXGEnspYIDbEh9D3dKU93gSZW+9trAylxCm+KJr VvZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20230601 header.b=SrkxS6ev; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id ik15-20020a170902ab0f00b001c9af7debb2si1801367plb.525.2023.10.10.05.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 05:50:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20230601 header.b=SrkxS6ev; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 540E9817ABF1; Tue, 10 Oct 2023 05:50:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231959AbjJJMt5 (ORCPT + 20 others); Tue, 10 Oct 2023 08:49:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232077AbjJJMtv (ORCPT ); Tue, 10 Oct 2023 08:49:51 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12A5BDB; Tue, 10 Oct 2023 05:49:47 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-53d9b94731aso835012a12.1; Tue, 10 Oct 2023 05:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696942185; x=1697546985; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=msy7jv8g0SLNU2c8sB4y8hw1WS5I1nkPJ94zB1gQH70=; b=SrkxS6evptDFFJzSFWZFpxT1YPVBfPPyyzA/3mlwrP9esJAz8n5OLYo08JpYMsK4/o kYPMHTTz1tvbq7YIrJ0+IYAwtpUKz5eh8csWbkitaJLOokto/Y62qLRZRkxZQVdo62/K 90aElQOP08jgt8+gI+quJJAo8+lSuP6ynOCWgv0y29nnxq1sgwEFSpnVwxwQv/4SCtRj N4rEWN0ts/t00Ut6fV8ldo8E29GT/2iQ7yMDIUear1vJjXt5s0CmbHdtcEhHHEAZLBRa ywB4xZljnFDf7wuAOlgFPYWZfIQAcI1MiT1+ugeVqSU5C8Cel/x90CYd3iDWbd4qAHBc X3Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696942185; x=1697546985; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=msy7jv8g0SLNU2c8sB4y8hw1WS5I1nkPJ94zB1gQH70=; b=tNR5g+OYXV+Yr30SWEXnCCqXIDdEXpAlyrLt/HLoAR6/UZ9TyDB1GJcGEto77aQFTG nWnVlaZOwRRt7KEaRsVX9kNocWQ0DCSRhJgs2F9jHa+yTnLwKyMeD9Y2vsfnI7AAPsPM BqP7BfW66W0f5FWHihtAJ9tS/Dl9WiWKQfKZd0GqifrGahMfSF0DTpvSuFOxs1FMs6Zs N/E4Wt+2J6ujpoeNQqm+crVfpX0w1lB/E62YJHCdIyVh3LeoHIpLkzVWhIiMJLRSSINh OAFfaooWEwG+qEmr1WxHZvuIXd6ZB9+TmUJxo2m4kMtzcfq3z8V1wXdVJeQyJmNh9ETc JUdw== X-Gm-Message-State: AOJu0Yw56w/1qzg2J8f2WPHSYl4mwMHjMlQcguTh5pCuQt8+w/Nk5Nl3 SsUhW/j/5Gt2JcLquVwRNNY= X-Received: by 2002:aa7:cfda:0:b0:522:ae79:3ee8 with SMTP id r26-20020aa7cfda000000b00522ae793ee8mr15865968edy.5.1696942185420; Tue, 10 Oct 2023 05:49:45 -0700 (PDT) Received: from spiri.. ([5.14.139.113]) by smtp.gmail.com with ESMTPSA id f26-20020a056402005a00b00530bc7cf377sm7629476edu.12.2023.10.10.05.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 05:49:45 -0700 (PDT) From: alisadariana@gmail.com Cc: Alisa-Dariana Roman , Alexandru Tachici , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 3/3] iio: adc: ad7192: Add fast settling support Date: Tue, 10 Oct 2023 15:49:26 +0300 Message-Id: <20231010124927.143343-4-alisadariana@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231010124927.143343-1-alisadariana@gmail.com> References: <20231010124927.143343-1-alisadariana@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=3.3 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 10 Oct 2023 05:50:06 -0700 (PDT) X-Spam-Level: *** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779372889782344709 X-GMAIL-MSGID: 1779372889782344709 From: Alisa-Dariana Roman Add fast settling mode support for AD7193. Add two new device specific attributes: oversampling_ratio and oversampling_ratio_available. For AD7193 the user can set the average factor by writing to oversampling_ratio. The possible values are exposed when reading oversampling_ratio_available. Signed-off-by: Alisa-Dariana Roman --- drivers/iio/adc/ad7192.c | 107 +++++++++++++++++++++++++++++---------- 1 file changed, 81 insertions(+), 26 deletions(-) diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index fe47ef43b3d7..954093ee0fbd 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -60,6 +60,8 @@ #define AD7192_MODE_SEL_MASK GENMASK(23, 21) /* Operation Mode Select Mask */ #define AD7192_MODE_STA_MASK BIT(20) /* Status Register transmission Mask */ #define AD7192_MODE_CLKSRC_MASK GENMASK(19, 18) /* Clock Source Select Mask */ +#define AD7192_MODE_AVG_MASK GENMASK(17, 16) + /* Fast Settling Filter Average Select Mask (AD7193 only) */ #define AD7192_MODE_SINC3 BIT(15) /* SINC3 Filter Select */ #define AD7192_MODE_ENPAR BIT(13) /* Parity Enable */ #define AD7192_MODE_CLKDIV BIT(12) /* Clock divide by 2 (AD7190/2 only)*/ @@ -185,6 +187,7 @@ struct ad7192_state { u32 mode; u32 conf; u32 scale_avail[8][2]; + u32 oversampling_ratio_avail[4]; u8 gpocon; u8 clock_sel; struct mutex lock; /* protect sensor state */ @@ -462,6 +465,11 @@ static int ad7192_setup(struct iio_dev *indio_dev, struct device_node *np) st->scale_avail[i][0] = scale_uv; } + st->oversampling_ratio_avail[0] = 1; + st->oversampling_ratio_avail[1] = 2; + st->oversampling_ratio_avail[2] = 8; + st->oversampling_ratio_avail[3] = 16; + return 0; } @@ -531,15 +539,21 @@ static ssize_t ad7192_set(struct device *dev, return ret ? ret : len; } -static int ad7192_compute_f_order(bool sinc3_en, bool chop_en) +static int ad7192_compute_f_order(struct ad7192_state *st, bool sinc3_en, bool chop_en) { - if (!chop_en) + u8 avg_factor_selected, oversampling_ratio; + + avg_factor_selected = FIELD_GET(AD7192_MODE_AVG_MASK, st->mode); + + if (!avg_factor_selected && !chop_en) return 1; + oversampling_ratio = st->oversampling_ratio_avail[avg_factor_selected]; + if (sinc3_en) - return AD7192_SYNC3_FILTER; + return AD7192_SYNC3_FILTER + oversampling_ratio - 1; - return AD7192_SYNC4_FILTER; + return AD7192_SYNC4_FILTER + oversampling_ratio - 1; } static int ad7192_get_f_order(struct ad7192_state *st) @@ -549,13 +563,13 @@ static int ad7192_get_f_order(struct ad7192_state *st) sinc3_en = FIELD_GET(AD7192_MODE_SINC3, st->mode); chop_en = FIELD_GET(AD7192_CONF_CHOP, st->conf); - return ad7192_compute_f_order(sinc3_en, chop_en); + return ad7192_compute_f_order(st, sinc3_en, chop_en); } static int ad7192_compute_f_adc(struct ad7192_state *st, bool sinc3_en, bool chop_en) { - unsigned int f_order = ad7192_compute_f_order(sinc3_en, chop_en); + unsigned int f_order = ad7192_compute_f_order(st, sinc3_en, chop_en); return DIV_ROUND_CLOSEST(st->fclk, f_order * FIELD_GET(AD7192_MODE_RATE_MASK, st->mode)); @@ -753,6 +767,9 @@ static int ad7192_read_raw(struct iio_dev *indio_dev, *val = ad7192_get_3db_filter_freq(st); *val2 = 1000; return IIO_VAL_FRACTIONAL; + case IIO_CHAN_INFO_OVERSAMPLING_RATIO: + *val = st->oversampling_ratio_avail[FIELD_GET(AD7192_MODE_AVG_MASK, st->mode)]; + return IIO_VAL_INT; } return -EINVAL; @@ -810,6 +827,23 @@ static int ad7192_write_raw(struct iio_dev *indio_dev, case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY: ret = ad7192_set_3db_filter_freq(st, val, val2 / 1000); break; + case IIO_CHAN_INFO_OVERSAMPLING_RATIO: + ret = -EINVAL; + mutex_lock(&st->lock); + for (i = 0; i < ARRAY_SIZE(st->oversampling_ratio_avail); i++) + if (val == st->oversampling_ratio_avail[i]) { + ret = 0; + tmp = st->mode; + st->mode &= ~AD7192_MODE_AVG_MASK; + st->mode |= FIELD_PREP(AD7192_MODE_AVG_MASK, i); + if (tmp == st->mode) + break; + ad_sd_write_reg(&st->sd, AD7192_REG_MODE, + 3, st->mode); + break; + } + mutex_unlock(&st->lock); + break; default: ret = -EINVAL; } @@ -830,6 +864,8 @@ static int ad7192_write_raw_get_fmt(struct iio_dev *indio_dev, return IIO_VAL_INT; case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY: return IIO_VAL_INT_PLUS_MICRO; + case IIO_CHAN_INFO_OVERSAMPLING_RATIO: + return IIO_VAL_INT; default: return -EINVAL; } @@ -849,6 +885,12 @@ static int ad7192_read_avail(struct iio_dev *indio_dev, /* Values are stored in a 2D matrix */ *length = ARRAY_SIZE(st->scale_avail) * 2; + return IIO_AVAIL_LIST; + case IIO_CHAN_INFO_OVERSAMPLING_RATIO: + *vals = (int *)st->oversampling_ratio_avail; + *type = IIO_VAL_INT; + *length = ARRAY_SIZE(st->oversampling_ratio_avail); + return IIO_AVAIL_LIST; } @@ -896,7 +938,7 @@ static const struct iio_info ad7195_info = { }; #define __AD719x_CHANNEL(_si, _channel1, _channel2, _address, _type, \ - _mask_type_av, _ext_info) \ + _mask_all, _mask_type_av, _mask_all_av, _ext_info) \ { \ .type = (_type), \ .differential = ((_channel2) == -1 ? 0 : 1), \ @@ -908,8 +950,10 @@ static const struct iio_info ad7195_info = { BIT(IIO_CHAN_INFO_OFFSET), \ .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \ .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ) | \ - BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY), \ + BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \ + (_mask_all), \ .info_mask_shared_by_type_available = (_mask_type_av), \ + .info_mask_shared_by_all_available = (_mask_all_av), \ .ext_info = (_ext_info), \ .scan_index = (_si), \ .scan_type = { \ @@ -921,15 +965,26 @@ static const struct iio_info ad7195_info = { } #define AD719x_DIFF_CHANNEL(_si, _channel1, _channel2, _address) \ - __AD719x_CHANNEL(_si, _channel1, _channel2, _address, IIO_VOLTAGE, \ - BIT(IIO_CHAN_INFO_SCALE), ad7192_calibsys_ext_info) + __AD719x_CHANNEL(_si, _channel1, _channel2, _address, IIO_VOLTAGE, 0, \ + BIT(IIO_CHAN_INFO_SCALE), 0, ad7192_calibsys_ext_info) #define AD719x_CHANNEL(_si, _channel1, _address) \ - __AD719x_CHANNEL(_si, _channel1, -1, _address, IIO_VOLTAGE, \ - BIT(IIO_CHAN_INFO_SCALE), ad7192_calibsys_ext_info) + __AD719x_CHANNEL(_si, _channel1, -1, _address, IIO_VOLTAGE, 0, \ + BIT(IIO_CHAN_INFO_SCALE), 0, ad7192_calibsys_ext_info) #define AD719x_TEMP_CHANNEL(_si, _address) \ - __AD719x_CHANNEL(_si, 0, -1, _address, IIO_TEMP, 0, NULL) + __AD719x_CHANNEL(_si, 0, -1, _address, IIO_TEMP, 0, 0, 0, NULL) + +#define AD7193_DIFF_CHANNEL(_si, _channel1, _channel2, _address) \ + __AD719x_CHANNEL(_si, _channel1, _channel2, _address, \ + IIO_VOLTAGE, \ + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \ + BIT(IIO_CHAN_INFO_SCALE), \ + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \ + ad7192_calibsys_ext_info) + +#define AD7193_CHANNEL(_si, _channel1, _address) \ + AD7193_DIFF_CHANNEL(_si, _channel1, -1, _address) static const struct iio_chan_spec ad7192_channels[] = { AD719x_DIFF_CHANNEL(0, 1, 2, AD7192_CH_AIN1P_AIN2M), @@ -944,20 +999,20 @@ static const struct iio_chan_spec ad7192_channels[] = { }; static const struct iio_chan_spec ad7193_channels[] = { - AD719x_DIFF_CHANNEL(0, 1, 2, AD7193_CH_AIN1P_AIN2M), - AD719x_DIFF_CHANNEL(1, 3, 4, AD7193_CH_AIN3P_AIN4M), - AD719x_DIFF_CHANNEL(2, 5, 6, AD7193_CH_AIN5P_AIN6M), - AD719x_DIFF_CHANNEL(3, 7, 8, AD7193_CH_AIN7P_AIN8M), + AD7193_DIFF_CHANNEL(0, 1, 2, AD7193_CH_AIN1P_AIN2M), + AD7193_DIFF_CHANNEL(1, 3, 4, AD7193_CH_AIN3P_AIN4M), + AD7193_DIFF_CHANNEL(2, 5, 6, AD7193_CH_AIN5P_AIN6M), + AD7193_DIFF_CHANNEL(3, 7, 8, AD7193_CH_AIN7P_AIN8M), AD719x_TEMP_CHANNEL(4, AD7193_CH_TEMP), - AD719x_DIFF_CHANNEL(5, 2, 2, AD7193_CH_AIN2P_AIN2M), - AD719x_CHANNEL(6, 1, AD7193_CH_AIN1), - AD719x_CHANNEL(7, 2, AD7193_CH_AIN2), - AD719x_CHANNEL(8, 3, AD7193_CH_AIN3), - AD719x_CHANNEL(9, 4, AD7193_CH_AIN4), - AD719x_CHANNEL(10, 5, AD7193_CH_AIN5), - AD719x_CHANNEL(11, 6, AD7193_CH_AIN6), - AD719x_CHANNEL(12, 7, AD7193_CH_AIN7), - AD719x_CHANNEL(13, 8, AD7193_CH_AIN8), + AD7193_DIFF_CHANNEL(5, 2, 2, AD7193_CH_AIN2P_AIN2M), + AD7193_CHANNEL(6, 1, AD7193_CH_AIN1), + AD7193_CHANNEL(7, 2, AD7193_CH_AIN2), + AD7193_CHANNEL(8, 3, AD7193_CH_AIN3), + AD7193_CHANNEL(9, 4, AD7193_CH_AIN4), + AD7193_CHANNEL(10, 5, AD7193_CH_AIN5), + AD7193_CHANNEL(11, 6, AD7193_CH_AIN6), + AD7193_CHANNEL(12, 7, AD7193_CH_AIN7), + AD7193_CHANNEL(13, 8, AD7193_CH_AIN8), IIO_CHAN_SOFT_TIMESTAMP(14), };