From patchwork Tue Oct 10 12:19:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 150731 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp155711vqb; Tue, 10 Oct 2023 05:22:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFn1C4bWkAzRs0DPuzGenfoUwgHG0kG2XX+pgUarPH7Ft5nxkcGq+L7eJKOXBvTuIS/51MU X-Received: by 2002:a17:906:538f:b0:9a1:fa4e:ca83 with SMTP id g15-20020a170906538f00b009a1fa4eca83mr17491910ejo.65.1696940552860; Tue, 10 Oct 2023 05:22:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696940552; cv=none; d=google.com; s=arc-20160816; b=vCrjoX/mGjrYkWL2v03L/la4ukwalDseeawN3zt6tiRQnzW5PFLvkEX0bQFZOpqMlU 1tSp34f6niGkXDi1/iIUwM64uAB8MSKm/GfYwgZemZYHWbHeYMl3rNqduuke3wws+npn jK/karGQYWvYWi4ykbob1Woy3otDu45oTk173nHof9UC8SOZFKUCUg2BzH2qf2Qx+sq2 lpg+76DwT/CywH/W7spkZV3iOyV1SO/2+LxKIvOqGaYiM1GH+Giqbq8zUKLR4GYjP0t7 snFw+uywkauBLxH+Z7sB+bKTXeDnGsE2xfsgSrxbnNuncueRgrm2VWErS3M3HiGz5los Nuuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :user-agent:subject:to:from:date:dkim-signature:dkim-signature :dmarc-filter:delivered-to; bh=Qq5jsC4JzE5etCQu4fGquu4TKzvo0C1x6qgFunpz4j8=; fh=hPrbWPhweUx4V0GV9uXJqbyAzg2ABmTz7kczrAQqMmM=; b=eJav52cpgX/6WZatzGBhEOETtF59aZUZBYLot0lwaJh7gxbZj1wLRtLqX+6j/OIV22 vGof5sEQDtQp2MuJEBOVrGFLAgSdOs9Ofr1sU6S6mN1/XK06WjtwvJk3QEczKkfsjOTD qtG0W31tvn6HTT74JXfyiiezUV2jmEWgCUoXtCVjENdWfCl13KA6rsz/aHg4KiA6ckKK vWkAW52xZathF18wOTajRw6ttX4Pw/tCcV6xDrOJ7lBCXAh8tip+5GXOFS/55nuZYq22 HgKbSFjyjgAzNy8hyuFUh/Oc167ms7By+htdJiZXFGSojWpoPo+OKBj8pfhC970pWnEs I6Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=hRPX20na; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=ZTNm8bR+; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id qq16-20020a17090720d000b009b3eb00c658si5580100ejb.59.2023.10.10.05.22.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 05:22:32 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=hRPX20na; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=ZTNm8bR+; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 551323882004 for ; Tue, 10 Oct 2023 12:19:47 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 955013858D35 for ; Tue, 10 Oct 2023 12:19:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 955013858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id B05642184E for ; Tue, 10 Oct 2023 12:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696940358; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=Qq5jsC4JzE5etCQu4fGquu4TKzvo0C1x6qgFunpz4j8=; b=hRPX20naqn96OjsM+ozmyR2ZCoSUxLRNT42pj7JhovZGhDv1l4OrP8L6t6SonMBwfMIhSl 9MrtLHZ9fAGRbT2vrbK19lt6YQJMXYDEaNzrIa/hRf9K/FXbS7kNvis+AEvHoyHuJ/F438 qqu7UyOc4mtA07ljG1xSaLNq3O3HGZ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696940358; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=Qq5jsC4JzE5etCQu4fGquu4TKzvo0C1x6qgFunpz4j8=; b=ZTNm8bR+j3UFU+PXCNMk9PCjGo4og697iwv84s/hNqnhbB9Zf+DfW2s0d4WY0h0jKceEEI 55tjEMWaWpLsklDg== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 839742C437 for ; Tue, 10 Oct 2023 12:19:18 +0000 (UTC) Date: Tue, 10 Oct 2023 12:19:18 +0000 (UTC) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/111751 - support 1024 bit vector constant reinterpretation User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20231010121947.551323882004@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779371137298229053 X-GMAIL-MSGID: 1779371137298229053 The following ups the limit in fold_view_convert_expr to handle 1024bit vectors as used by GCN and RVV. It also robustifies the handling in visit_reference_op_load to properly give up when constants cannot be re-interpreted. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/111751 * fold-const.cc (fold_view_convert_expr): Up the buffer size to 128 bytes. * tree-ssa-scccvn.cc (visit_reference_op_load): Special case constants, giving up when re-interpretation to the target type fails. --- gcc/fold-const.cc | 4 ++-- gcc/tree-ssa-sccvn.cc | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gcc/fold-const.cc b/gcc/fold-const.cc index 4f8561509ff..82299bb7f1d 100644 --- a/gcc/fold-const.cc +++ b/gcc/fold-const.cc @@ -9266,8 +9266,8 @@ fold_view_convert_vector_encoding (tree type, tree expr) static tree fold_view_convert_expr (tree type, tree expr) { - /* We support up to 512-bit values (for V8DFmode). */ - unsigned char buffer[64]; + /* We support up to 1024-bit values (for GCN/RISC-V V128QImode). */ + unsigned char buffer[128]; int len; /* Check that the host and target are sane. */ diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc index ce8ae8c6753..0b2c10dcc1a 100644 --- a/gcc/tree-ssa-sccvn.cc +++ b/gcc/tree-ssa-sccvn.cc @@ -5751,6 +5751,8 @@ visit_reference_op_load (tree lhs, tree op, gimple *stmt) && maybe_lt (GET_MODE_PRECISION (TYPE_MODE (TREE_TYPE (result))), GET_MODE_PRECISION (TYPE_MODE (TREE_TYPE (op))))) result = NULL_TREE; + else if (CONSTANT_CLASS_P (result)) + result = const_unop (VIEW_CONVERT_EXPR, TREE_TYPE (op), result); else { /* We will be setting the value number of lhs to the value number