From patchwork Mon Oct 9 21:13:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 150334 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp2124558vqo; Mon, 9 Oct 2023 14:14:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+M1x0fw8W/XZmbmXer2Bzja6HOSUgWHWRkTHJqWP4yW9AEUQoC9+GdBUZMGg5uFa8dlGn X-Received: by 2002:a05:6808:202a:b0:3af:9848:db19 with SMTP id q42-20020a056808202a00b003af9848db19mr21689005oiw.10.1696886094002; Mon, 09 Oct 2023 14:14:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696886093; cv=none; d=google.com; s=arc-20160816; b=ffP0/ftbZn9JlXITHn+FqOnsRQ6uS2905CJHb42C31BVOaGcERuGJzDsr13PyNUleG x/Vusz7cJW/zR7mYfRNmi/yINMVa14fpbtM1xHZieMcWPvpAjuWaowpzfc81NKZk75tX 7dJA0nxE8Z7FRnBR/NohIhJVNW1+DLAfZapx8PItKBt0hvZJhhFw76f7CT/8pyWdIzbt NfLUtF/Eu1oFeRrpSjLCuFDqKja0AXZ8D9JszBSKYj8FHp7w5IWe0mAnm2yIZ7BNjpHW KJTuPQ3lhOxxGuexwQXmkRvE5bMq0Z2dHCr3MrvfBxS/ljBwfkmHr45+l3Xwrc5Ie0jT sFnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yeu2Yqk+1W7JwaGj7n+VfzHpUfLi9VX9pa9cQ1fxjWY=; fh=7EeIR8NUPPGD3N88M96BYTMLNfS3mAYntn6p+zm8Als=; b=zPO50jpxLzURU+++klFTHutCDx7atY2C2KiRhqBh87NC6McUYKWr5jmKdaJ2bQRr0s /nBnNXI9mQzqaqc5CtO6gONUbPPJzjppMr8fHYHB6FNF7N06++FQRkRp/5i9O+ycOZvS jUR4U3nC66aPJi4bwzxIU33z8xflU7RSOOiNhZ4ba/tzZ/1Yg6Sc3QQ2dMAFmYuNNdCp jPMP3jQK9dEsTRjji8t2crT67EpQQwDynaunOtHA3HMcHv7t1fpepJgZhCY4SaHKDVKf NjelwUQwTrVTcKukGHzaAs5mQPAHNVana8WGx1Fo3VbnoABYNL4VyzgdK2Fa4xbXDRss JRXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TVSZcFjR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id z125-20020a633383000000b005855f67e48csi98582pgz.697.2023.10.09.14.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 14:14:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TVSZcFjR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 3A6FC81E3BA7; Mon, 9 Oct 2023 14:14:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378645AbjJIVOO (ORCPT + 19 others); Mon, 9 Oct 2023 17:14:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378151AbjJIVOM (ORCPT ); Mon, 9 Oct 2023 17:14:12 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BD5A92; Mon, 9 Oct 2023 14:14:10 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62E11C433C9; Mon, 9 Oct 2023 21:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696886050; bh=ap+N4R7Wc3zrVcWCqueifWjRY3gKqtLPPObPANvaRsk=; h=From:To:Cc:Subject:Date:From; b=TVSZcFjRyC7NOrF9so6qHNBtuo+KIMrX90xu8b0s84vESKo1rjdBKTP5arrqgz4dU vczOV3E0se5gfXpwDbWENgDdv2gyIykl4ipD6b5oW5mZrwoUw+UHdowlMhnPNfznlq goKjV9SX1G3g1SpdbUFQdGP8e3ZCCEF4onWxTx3x9quk3pMQ3QSBWSk8YMg4TOO3Af FY7n8xJQJcSZb8aHSPX1fAUBxczb/xH6oLOFdxs2C29TikoQ2nIoN95nDlJGoau2io MoCA05Y1aABlgrGECtgnbeupVBbR2BCORCXChMYO4/nb+UBP4Sd3HfCrlsLhSDlbwp Wk0FkMr0ACigg== Received: (nullmailer pid 3245212 invoked by uid 1000); Mon, 09 Oct 2023 21:14:07 -0000 From: Rob Herring To: Hugues Fruchet , Mauro Carvalho Chehab , Maxime Coquelin , Alexandre Torgue Cc: linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: stm32-dcmi: Drop unnecessary of_match_device() call Date: Mon, 9 Oct 2023 16:13:32 -0500 Message-ID: <20231009211356.3242037-2-robh@kernel.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 09 Oct 2023 14:14:41 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779314032728783410 X-GMAIL-MSGID: 1779314032728783410 If probe is reached, we've already matched the device and in the case of DT matching, the struct device_node pointer will be set. Therefore, there is no need to call of_match_device() in probe. Signed-off-by: Rob Herring Acked-by: Alain Volmat --- drivers/media/platform/st/stm32/stm32-dcmi.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c index 8cb4fdcae137..48140fdf40bb 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmi.c +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c @@ -20,7 +20,6 @@ #include #include #include -#include #include #include #include @@ -1890,7 +1889,6 @@ static int dcmi_graph_init(struct stm32_dcmi *dcmi) static int dcmi_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; - const struct of_device_id *match = NULL; struct v4l2_fwnode_endpoint ep = { .bus_type = 0 }; struct stm32_dcmi *dcmi; struct vb2_queue *q; @@ -1899,12 +1897,6 @@ static int dcmi_probe(struct platform_device *pdev) struct clk *mclk; int ret = 0; - match = of_match_device(of_match_ptr(stm32_dcmi_of_match), &pdev->dev); - if (!match) { - dev_err(&pdev->dev, "Could not find a match in devicetree\n"); - return -ENODEV; - } - dcmi = devm_kzalloc(&pdev->dev, sizeof(struct stm32_dcmi), GFP_KERNEL); if (!dcmi) return -ENOMEM;