From patchwork Mon Oct 9 12:29:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 150041 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1832899vqo; Mon, 9 Oct 2023 05:31:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeoHniFUCSphakuWbLuMVg7h7+5B+xy9uZAackfmLbgv56yfzB98NPSgDkDuHK2I+FcNl+ X-Received: by 2002:a17:90b:3a8c:b0:268:3d4:24bb with SMTP id om12-20020a17090b3a8c00b0026803d424bbmr14488751pjb.1.1696854665423; Mon, 09 Oct 2023 05:31:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696854665; cv=none; d=google.com; s=arc-20160816; b=Hk621A1J+dDODfwva4NZEMenoQXmETKveb/pxzq+QEcGgqM3A0h1diO8fWVqg5Q+Vc u9isVSDsrShTgG3Ijk6SzVhDZ4btCbqaKfFRs6MC2QqRbSwqCaguSZsWiMeeVwftVgSQ NqbxO5teR8V9o7SuebFXib4MX+eHIxgNwNNvkftUcoz/Kk28Pp8CMcVMh97xxm7sdt+2 H4DuvgfpgblFUBRx5Gzotf1IKO3YhPRgF7x7YtMTWURzmJzv/GH3+kLc/atv88sCVYWT txEa9IECOOnX3L8phQBSLJjCXpfiXMjplAFmqwFE+WfY9wI3GmLQ8DosPM0wiw5ONjeX Zf0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=BIFOTLwgFf0FxaK/QbeXOF0TQu5Vo6hgzhc06FG0EXE=; fh=LWlv3U+xZ3+vQt4tlJRIlKl5VzN7iFjjE/bzRmlxKDA=; b=ACt16RoGL8NTdXC+7GtsQhFHEqQ4pLCD0juoV1cw9Qdw4yGuaOxBADIHkDXallCbFJ rR6vnvwdQKv1joKjfQXJdi2Xn659M8G1mdHZ2rhkIM0Hg6AP8Pnfgw5FXA2RPcXZjsJR 7zmsjiDS8bStpBxkE7Yh4mHe9Wp0Z8YBYblmkSFbtfbaXsxAt4Qm6Mg8SBqsEm++Yjhc OtC6ck0isefLMRzhcB4GEu4DFxEJNNqrKh0/A4fFuGhsHVvFRKo5Drj2Q3BTfNYXId+V nOW/iFbO9KquxZTjQsq06dQRWv6KnHQNfELP7DBl65i/qPzTM7Tp8dMQ1HJ9/9tYHI6x gYhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=dRAm4q2j; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id w67-20020a636246000000b005898db9d676si6874589pgb.260.2023.10.09.05.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:31:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=dRAm4q2j; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id AD0AF80AA306; Mon, 9 Oct 2023 05:30:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376484AbjJIMaU (ORCPT + 18 others); Mon, 9 Oct 2023 08:30:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346551AbjJIM3y (ORCPT ); Mon, 9 Oct 2023 08:29:54 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63CBFD6; Mon, 9 Oct 2023 05:29:51 -0700 (PDT) Date: Mon, 09 Oct 2023 12:29:49 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1696854590; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BIFOTLwgFf0FxaK/QbeXOF0TQu5Vo6hgzhc06FG0EXE=; b=dRAm4q2jAhIh2eJ1YJ5K3w8NyKY/CwZeZPup/FYR80gEnDTZn6T2jgxvpsYQMc7Tq4R3TY YRajbahj7W7pgbITocwBfm9DHRsKmgMueViQJxVKwqKdI+ZdKYAZ0PUF7bFMLfhUEmezEr efu/S9YqPddd8dU9/gjoEPYTo9u5FLJFFJORP6zLQrkCDJfND65weaC5LWrgQ8PWqkOJ/W aernaYbBgvadSMPi1Yzs8pwEE5mZH4LqO2nsDm8ueGscXI7jPofIZocT2sbTM1pWyqqn3C PpEie0VJIAtSg5ltJc9Oano0cpEws00NUSwgWarl5PGe2hoMK3TqUwoXHzoh4g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1696854590; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BIFOTLwgFf0FxaK/QbeXOF0TQu5Vo6hgzhc06FG0EXE=; b=PGBmfs4Bv0Q74K6SCeZCXPIMe01KzoXWpWAd0hTBiMDKMB+6vnAQAxhBS2G5L4elHSmCZF natTIiW2JT8KiHCQ== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/microcode] x86/microcode: Clean up mc_cpu_down_prep() Cc: Thomas Gleixner , "Borislav Petkov (AMD)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20231002115903.028651784@linutronix.de> References: <20231002115903.028651784@linutronix.de> MIME-Version: 1.0 Message-ID: <169685458938.3135.206662791860103089.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 09 Oct 2023 05:30:47 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778667764290204326 X-GMAIL-MSGID: 1779281077893870498 The following commit has been merged into the x86/microcode branch of tip: Commit-ID: 75d0be07daa201cd283e00d09eb27b30c0b0261e Gitweb: https://git.kernel.org/tip/75d0be07daa201cd283e00d09eb27b30c0b0261e Author: Thomas Gleixner AuthorDate: Mon, 02 Oct 2023 13:59:55 +02:00 Committer: Borislav Petkov (AMD) CommitterDate: Fri, 06 Oct 2023 15:12:23 +02:00 x86/microcode: Clean up mc_cpu_down_prep() This function has nothing to do with suspend. It's a hotplug callback. Remove the bogus comment. Drop the pointless debug printk. The hotplug core provides tracepoints which track the invocation of those callbacks. Signed-off-by: Thomas Gleixner Signed-off-by: Borislav Petkov (AMD) Link: https://lore.kernel.org/r/20231002115903.028651784@linutronix.de --- arch/x86/kernel/cpu/microcode/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c index 17b7578..0038126 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -536,16 +536,10 @@ static int mc_cpu_online(unsigned int cpu) static int mc_cpu_down_prep(unsigned int cpu) { - struct device *dev; - - dev = get_cpu_device(cpu); + struct device *dev = get_cpu_device(cpu); microcode_fini_cpu(cpu); - - /* Suspend is in progress, only remove the interface */ sysfs_remove_group(&dev->kobj, &mc_attr_group); - pr_debug("%s: CPU%d\n", __func__, cpu); - return 0; }