From patchwork Sun Oct 8 14:02:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 149747 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1381179vqo; Sun, 8 Oct 2023 07:02:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGgfVdjLylAGTdaWLJcVFgBhLOCJ4gvS+g1afe8GXRiErnHhwTAv5CA6w7iI6K2au1TGkZ0 X-Received: by 2002:a17:902:e886:b0:1c5:f7e2:c5e0 with SMTP id w6-20020a170902e88600b001c5f7e2c5e0mr12636488plg.51.1696773766130; Sun, 08 Oct 2023 07:02:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696773766; cv=none; d=google.com; s=arc-20160816; b=Aa0+50wLkYVYCS+RUY6HQ6VzhO09sXrFTAGrA70mx/JLM2E8qiiOGjoIYrineOfU2A Rh75TUrgrrStSym/fFE0E4cY6QYY1+Y1xWt38Iw+kPF0PiO2bFva4UBkQtz5fNA75d2s vFzHf5IQre0N/gHDpgfV1mhsjt+dRPcZb8E51m7iu+vzaGoA5kUWyp9DV7gql/XcTSGW 1xe28V+zCwPyHhhOQGOSbS3exnM0N+TZk2xE8CXkMMO0QmnWofQG3kUWHHlwlZAyrC5X DAZzJlpmk46mx8HP9nOBtaJAHn4PACe+JEj7RqcnMBTMym99osYSq2pzRpusMqDv2hU3 mqKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=figW6V5IxO3BN+Q3ev6fcFUCPxrFf784LSxaFnVtQh0=; fh=/zs+QicmxVoupH3c4ehk7sNZeCoQjf2frZS7UKZj/q8=; b=SzEmtYA3PFR1Gn87cw78uof82AZF381Ad1ZvaDJ/vy2ss3YmBvqpnuO8bsHoUig9Z7 /In6mbCKOy4qjuJ/cAWU9Anzwk8rC/hiKA+Zs4MCLBMhVxVa49aP80xSSu41Jv8HpTcX jk9boz8JvFX8zNyjRoeEFe8KxWhiYrXJegbgBDlgJtx2wdlhnotH+PVFYfXidAh7oHXC 9lk/AW7p3/Y1PjIlOslmbFBi8fTlMM28BPaJXDRGsXS7O9Z7qDBTEn+BR1kIyCeMnlUp w7Y2aUERNsI+j8E5p7t+Uob9UPfht44OiyoZLfwaEBo18fxykt20Pt3F3A4v8PwF6E9o A5vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hXUnR+z5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id a2-20020a170902ecc200b001c62cfff798si8533480plh.372.2023.10.08.07.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 07:02:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hXUnR+z5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C4C5C8080EF6; Sun, 8 Oct 2023 07:02:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344840AbjJHOCg (ORCPT + 18 others); Sun, 8 Oct 2023 10:02:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344833AbjJHOCe (ORCPT ); Sun, 8 Oct 2023 10:02:34 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5DE599 for ; Sun, 8 Oct 2023 07:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=figW6V5IxO3BN+Q3ev6fcFUCPxrFf784LSxaFnVtQh0=; b=hXUnR+z5iXugz8qJvJ6sO3rUMU UeLlJjoEa0+ezplb8/cgbEVxY6c+TS+Ai6cz4h1cNpXUOjJ2NNk0+fESqqPVLe006JtsNF1dg9AWP lfutHgYn+Rr3H3OV6fBEyxhXzfDxxeL2zgzbmdUfZYwuqximXP/PGjdZ5ZJuTU96ZKEpkvGyEqFmQ mvguTtscESZ/a9E5tY4/P5VCh5iGSeGKbZ+B7qI0KVb7ITD423v0aCqdOJlBU9LWEEKDMwwODYFvX pSo3X24IOb3FGnnQ3C/UYbPt9vwhLl7P8g3gGK1oESwLkdV5LQWVfoEDfyZwhCNn/NRckVnppBE84 TvF5BEJA==; Received: from [50.53.46.231] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qpUMZ-008vP6-2d; Sun, 08 Oct 2023 14:02:31 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Dave Airlie , Danilo Krummrich , Karol Herbst , Lyude Paul , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, Bragatheswaran Manickavel Subject: [PATCH v2] drm/nouveau: exec: fix ioctl kernel-doc warning Date: Sun, 8 Oct 2023 07:02:31 -0700 Message-ID: <20231008140231.17921-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 08 Oct 2023 07:02:43 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779196248524413815 X-GMAIL-MSGID: 1779196248524413815 kernel-doc emits a warning: include/uapi/drm/nouveau_drm.h:49: warning: Cannot understand * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX on line 49 - I thought it was a doc line We don't have a way to document a macro value via kernel-doc, so change the "/**" kernel-doc marker to a C comment and format the comment more like a kernel-doc comment for consistency. Fixes: d59e75eef52d ("drm/nouveau: exec: report max pushs through getparam") Signed-off-by: Randy Dunlap Cc: Dave Airlie Cc: Danilo Krummrich Cc: Karol Herbst Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Cc: Bragatheswaran Manickavel Reviewed-by: Lyude Paul --- v2: update commit text; somehow I sent a version of the patch before adding the full text. v1: https://lore.kernel.org/lkml/20231007005518.32015-1-rdunlap@infradead.org/ include/uapi/drm/nouveau_drm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/include/uapi/drm/nouveau_drm.h b/include/uapi/drm/nouveau_drm.h --- a/include/uapi/drm/nouveau_drm.h +++ b/include/uapi/drm/nouveau_drm.h @@ -45,8 +45,8 @@ extern "C" { #define NOUVEAU_GETPARAM_HAS_BO_USAGE 15 #define NOUVEAU_GETPARAM_HAS_PAGEFLIP 16 -/** - * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX +/* + * NOUVEAU_GETPARAM_EXEC_PUSH_MAX - query max pushes through getparam * * Query the maximum amount of IBs that can be pushed through a single * &drm_nouveau_exec structure and hence a single &DRM_IOCTL_NOUVEAU_EXEC