From patchwork Wed Aug 24 09:44:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 697 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:ecc5:0:0:0:0:0 with SMTP id s5csp1335197wro; Wed, 24 Aug 2022 02:45:42 -0700 (PDT) X-Google-Smtp-Source: AA6agR4tutM6lB3GzIk2aELpwDdrsdEk3bZzWVx2q3k8ZDkYcII3HcE/BhEy25q8gKatvLrvpV6b X-Received: by 2002:a05:6402:4313:b0:446:ffc0:50b5 with SMTP id m19-20020a056402431300b00446ffc050b5mr6768896edc.153.1661334341823; Wed, 24 Aug 2022 02:45:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661334341; cv=none; d=google.com; s=arc-20160816; b=TqYAB52fOKX1UFwFuZLIoAy1iEBmq/aWetovuZ6wQQnmF2GQ0xyfsifFpneIVZgPEw yL0ko1oBzuoZiZEjN+A78tnHZGdwSSONGAQ6wBS9sBCVZpa1uD1OHxjalInZ1gwjWH53 OFsa4RO+qN1PiseGsQu/XS5u+dGQZ87xkjtMoECtPOcMbWwVRjYaAADSkj1cWq3FUQgi OMUsXg1zByqS/X/FR64kxHcSPnGXG678u0fFpjhEMDr1oKw/g8y54ezIEqfyXpexehnY SBpJzXXPUekPpXK32emOs7lAQ3LG9wny+/U0oP48fIOGW3YPXaARb1HqS6IiL/8XQ7RM AnUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=BGh5z5vbWyrzCjJepnKLMAaKA/+vlf2CsRczXvrpkso=; b=ZDGKmk/9jDs0UU8zXHiy2760fy1ny51gMUg1JipNXPzaCA23vyGPNaAAxTlUoPJsvD LtNXWghQ+S/QxVBql8fxlXPSbCiQiwyA5w2KzZeCMief/vuK8F7tcOn68POoxBW51ctB PCUkYX0NrgJ8qClVmLi0Q+uf966XtSLMfqHUtivq8Bod6xseEKQAaaMop46Y6YWB1kV1 II4pfZ+EDzuhlazanL4phJVKojq/6YXGQhbyC6doY/M3XyHQl2VBUF+u7UCo7/LZ15Ol CkPWKFfAEoJa1v+l2KPx5VuQPL2HKtv9RSkIPqx4JEC8QlyCSKI3x/3TID1V4Jw5K4ZR ZT7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Bxv1IIWR; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id l21-20020a1709065a9500b0073d567769a9si1439364ejq.437.2022.08.24.02.45.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 02:45:41 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Bxv1IIWR; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56EF83858029 for ; Wed, 24 Aug 2022 09:45:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56EF83858029 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1661334340; bh=BGh5z5vbWyrzCjJepnKLMAaKA/+vlf2CsRczXvrpkso=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Bxv1IIWRVikk4KQy5KM9rcq8RrsUuWy2TyOgxlotVsHftP7P6AJB5kgXhF5Lt5Gce 9i94mI+OEUvEGtaN/QeNZO3ocNU0+FB/DBlbsMi09BQ/fa8+3Zkb7qYS8hQwstM3zE /7Y+rwXLEbulWE+AittaYT+QYiuuK5c7AcDepljA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 1CCA93858CDB for ; Wed, 24 Aug 2022 09:44:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1CCA93858CDB Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 05A9434086 for ; Wed, 24 Aug 2022 09:44:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E5BC913AC0 for ; Wed, 24 Aug 2022 09:44:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EwHSNhXzBWMvCQAAMHmgww (envelope-from ) for ; Wed, 24 Aug 2022 09:44:53 +0000 Date: Wed, 24 Aug 2022 11:44:53 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Some more predicate analysis TLC MIME-Version: 1.0 Message-Id: <20220824094453.E5BC913AC0@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1742035318973169194?= X-GMAIL-MSGID: =?utf-8?q?1742035318973169194?= This limits the simple control dep also to the cd_root plus avoids filling the lazily computed PHI def predicate in the early out path which would leave it not simplified and normalized if it were re-used. It also avoids computing the use predicates when the post-dominance early out doesn't need it. It also syncs predicate::use_cannot_happen with init_from_phi_def, adding the missing PHI edge to the computed chains (the simple control dep code already adds it). Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. * gimple-predicate-analysis.cc (predicate::use_cannot_happen): Do simple_control_dep_chain only up to cd_root, add the PHI operand edge to the chains like init_from_phi_def does. (predicate::is_use_guarded): Speedup early out, avoid half-way initializing the PHI def predicate. --- gcc/gimple-predicate-analysis.cc | 31 ++++++++++++------------------- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc index ea81daacd4f..f7170a8d068 100644 --- a/gcc/gimple-predicate-analysis.cc +++ b/gcc/gimple-predicate-analysis.cc @@ -1322,10 +1322,15 @@ predicate::use_cannot_happen (gphi *phi, unsigned opnds) /* If compute_control_dep_chain bailed out due to limits build a partial sparse path using dominators. Collect only edges whose predicates are always true when reaching E. */ - simple_control_dep_chain (dep_chains[0], - ENTRY_BLOCK_PTR_FOR_FN (cfun), e); + simple_control_dep_chain (dep_chains[0], cd_root, e); num_chains++; } + /* Update the chains with the phi operand edge. */ + else if (EDGE_COUNT (e->src->succs) > 1) + { + for (unsigned j = 0; j < num_chains; j++) + dep_chains[j].safe_push (e); + } if (DEBUG_PREDICATE_ANALYZER && dump_file) { @@ -1916,24 +1921,14 @@ predicate::is_use_guarded (gimple *use_stmt, basic_block use_bb, /* The basic block where the PHI is defined. */ basic_block def_bb = gimple_bb (phi); + if (dominated_by_p (CDI_POST_DOMINATORS, def_bb, use_bb)) + /* The use is not guarded. */ + return false; + /* Try to build the predicate expression under which the PHI flows into its use. This will be empty if the PHI is defined and used in the same bb. */ predicate use_preds (def_bb, use_bb, m_eval); - - if (dominated_by_p (CDI_POST_DOMINATORS, def_bb, use_bb)) - { - if (is_empty ()) - { - /* Lazily initialize *THIS from the PHI and build its use - expression. */ - init_from_phi_def (phi); - } - - /* The use is not guarded. */ - return false; - } - if (use_preds.is_empty ()) return false; @@ -1955,9 +1950,7 @@ predicate::is_use_guarded (gimple *use_stmt, basic_block use_bb, { /* Lazily initialize *THIS from PHI. */ if (!init_from_phi_def (phi)) - { - return false; - } + return false; simplify (phi); normalize (phi);