From patchwork Fri Oct 6 21:44:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 149429 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp610635vqo; Fri, 6 Oct 2023 14:44:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBL5EaIz73NcFP5HUDQ+GeI4WNzTjMp8Ca5thJSltelXhCXSjgrpdGByWULcgkkuuvmAuQ X-Received: by 2002:a05:6a20:948a:b0:15d:7af9:5642 with SMTP id hs10-20020a056a20948a00b0015d7af95642mr7553610pzb.28.1696628685522; Fri, 06 Oct 2023 14:44:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696628685; cv=none; d=google.com; s=arc-20160816; b=fRhdjiEZXholYgJ5y//0sWWs0T3Yg3geD0QKb2X/81bQKpaBxW0o3vdJJ96R7RIan2 GpvZqICUJ/pyAiD71ERbSn1hYOPS9jm1T2B/b6dPwX/ru6Stqcsz854FXQAlRnZ9kBrA cCLFI898hlG9ZXQStI+gXHeplF5o1f2UT72UzKRxvc2qVN1NyNzc6eQxGowJPXqLKaLC oA6T/gYY/fbRN92JNVIDp5G0+0j4T1csPDptnYSNNe2XKkiVyP1SuMM+Lc+AfkhQ9m2a 2FcU3Bb240Qk02Z3Si13ayj664izewkptzcO9CzsXXavykzx3WsrdfxZWtQC8AvISFJt Wayg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=p1aMnFE49hKYwlE8RNUS1am9LWidrky/xBoVi2bsNhU=; fh=SR7JT9FZ7q3/8YciIPthdNHJP1XYHmla3OnfGIx0+NM=; b=bPwBwQVHRLGa/x3FIpVEnVoZ36f26KFzOpaLN0rJW90pQiJ+RcH9l1mkWgbxzK8hVO EScvKPYKc7cIL9Fa6OvIKUuzAy10DqTf6F1WyAd8zgG5mm6Y2SsdFtqXHl2S7dqLFVvs 6acTiapCb82oyuR8R1ECEP2mZqiI/FOZYIcC4HrthZtKvsfNeljKkLxBE5ZedVZcffv2 leLgWtEAa7QH572dDMNyfl/vIahTlAMMH4uMhrQyP7AqfnGPQln0X69rSKIBSZ4oEfru mVWEAS57p2CIqo9FykDydQ/FliLLxSfAWlR+Q6FO16zZrWNi+sShI7cDne/c8Ek1c6/M jxcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RZ2kN0AU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id k14-20020a056a00168e00b0069343bdd500si2271497pfc.319.2023.10.06.14.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 14:44:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RZ2kN0AU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 858F08364E30; Fri, 6 Oct 2023 14:44:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233755AbjJFVof (ORCPT + 18 others); Fri, 6 Oct 2023 17:44:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233759AbjJFVod (ORCPT ); Fri, 6 Oct 2023 17:44:33 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BABFDB for ; Fri, 6 Oct 2023 14:44:32 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46C59C433C7; Fri, 6 Oct 2023 21:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696628671; bh=UOwYY4Wdrq3qaLX+ulY/AMB64MrwJnjkGbdwZBFe+cQ=; h=From:To:Cc:Subject:Date:From; b=RZ2kN0AUd6/zzh5L2ZWT9+G1ByFse8EGnk93FT1xyuGuiUcVJJWFmjvQFwkPYMQ6b /8f3y6OOtmXkQEvO7Ri5xTxH8PPRgYf7E2b/e7LbHLMFaW+ZrGXb6qf89dDwun0xme ffrUtPzoJFVo9RxkfSOh6OllDq75uTrQP3JoI7opI/gF4UX9I0kg/1rzzygKEKZYc9 Ui8PF6gzqjI007PHyR7lGS9DzJVw3bhPRxicyKau98Ktc4pMUcUF+bxFAtMdkFiH8q JNjkO7Z9gykrEMCPLncN+aK03GKG6NkfxHjGy7QBktiwhP7znvGMAeIOUMFhHgG351 E/zesisGisnDw== Received: (nullmailer pid 339633 invoked by uid 1000); Fri, 06 Oct 2023 21:44:30 -0000 From: Rob Herring To: Chas Williams <3chas3@gmail.com> Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] atm: fore200e: Drop unnecessary of_match_device() Date: Fri, 6 Oct 2023 16:44:21 -0500 Message-Id: <20231006214421.339445-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 06 Oct 2023 14:44:43 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779044120373498874 X-GMAIL-MSGID: 1779044120373498874 It is not necessary to call of_match_device() in probe. If we made it to probe, then we've already successfully matched. Signed-off-by: Rob Herring Reviewed-by: Simon Horman --- drivers/atm/fore200e.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c index fb2be3574c26..50d8ce20ae5b 100644 --- a/drivers/atm/fore200e.c +++ b/drivers/atm/fore200e.c @@ -36,7 +36,7 @@ #ifdef CONFIG_SBUS #include -#include +#include #include #include #include @@ -2520,18 +2520,12 @@ static int fore200e_init(struct fore200e *fore200e, struct device *parent) } #ifdef CONFIG_SBUS -static const struct of_device_id fore200e_sba_match[]; static int fore200e_sba_probe(struct platform_device *op) { - const struct of_device_id *match; struct fore200e *fore200e; static int index = 0; int err; - match = of_match_device(fore200e_sba_match, &op->dev); - if (!match) - return -EINVAL; - fore200e = kzalloc(sizeof(struct fore200e), GFP_KERNEL); if (!fore200e) return -ENOMEM;