From patchwork Fri Oct 6 17:49:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 149368 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp498721vqo; Fri, 6 Oct 2023 10:51:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLHh3NWaWdJPVaywepb/9pDz2eoXrj2r+UWx7yWncOaxR3lduRm+oTD9F75wbDZ3IZW+gb X-Received: by 2002:a17:907:7603:b0:9ae:381a:6c55 with SMTP id jx3-20020a170907760300b009ae381a6c55mr8247803ejc.15.1696614677741; Fri, 06 Oct 2023 10:51:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696614677; cv=none; d=google.com; s=arc-20160816; b=G6GsYgRstsQZ0PVf/fU0HlK5a96IDE/aGZpuJUFmxoVDkSnuwZ4wg7mEeNtnEd4dqS vCmpL07jmIk3dke2Fr0gmqYkx/gL9ykP6ARDDRcIH2+QR5p18t3BQDT+tzoeo25kByaV ppm6Tl7RHLP9PFnvXo6IJ2nvS2GHMaa0WlaWSdcb2VMvm6H8VeCm4pMYfzXIJbZQH6kZ lrupJYDSQofZd5JNR8mih8vd2NsFXHyqtekGOhNbAyZo1J6TCFclX6IOMwA6gRKp5/pG bf/WW62Ia9S+X46hh+uACH2v4Qn3eIBoJ+IqKX6HklusWCSbJEam6RNIjQr1OlS7t9EW wxKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=8ak6jqcpofyqHT0N73SDWl60RnV8tdeyXtZCfUvKSnY=; fh=NLxAvL/bDfPg4AGOtxqvQlND8vazkZrNzKLY8+LAbBY=; b=jgp5+5hiZ7qXQEO4cM4IsWAha8cI42JBmeIWnTIE0nSXPawJdz/GoHZqvFPIYdw/8n nA6ohKQcVdsefv6JV+oitFNS3Ls/hQI+3N2oELp0UIBcjrnNEZg8blF8EYmShOW3CwLo spcfoZ5WUVWzbTHBQcZEl9kS1sHCZXYLkB3vAnrxIVcoG7sG3/9GSCVoOAl4iiYEIncA 6dd8kwgfaosDbF469+4WTCGGtjLpGY4nhB8Fzxfdx3gADYvhmnFrKg9JS8FbESvnbDxd yrgtOREpD1i8DJDXZcscwhBiD7Y98jx77oXsn1E2Gt/3EJMtISFJkquYcyqcclh15uTV 5hSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=d7OpXiWU; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id g21-20020a170906595500b00988da9cd05csi1719230ejr.23.2023.10.06.10.51.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 10:51:17 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=d7OpXiWU; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D7F273857020 for ; Fri, 6 Oct 2023 17:50:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7F273857020 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696614652; bh=8ak6jqcpofyqHT0N73SDWl60RnV8tdeyXtZCfUvKSnY=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=d7OpXiWUmWWwxyhS2OM+aq5ncX0hLJ0PPgmboGFauv3XRYbk/B6Otf7NthyN0Oj2z mzwt0nqZiAnKXJ9u1ImFdczRiftM2pt+sjtpr8OaJn0wi5WvZRTsHkvrGae2gNT9H0 ktPrM2Eq4ZxwVjW55a9xHdtN4wrpG/Ev/Ynkie6E= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id C63643858426 for ; Fri, 6 Oct 2023 17:49:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C63643858426 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D98521F8A4 for ; Fri, 6 Oct 2023 17:49:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A984113A2E for ; Fri, 6 Oct 2023 17:49:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aCoOKLRIIGXwQAAAMHmgww (envelope-from ) for ; Fri, 06 Oct 2023 17:49:40 +0000 To: binutils@sourceware.org Subject: [PATCH 1/2] [gdb/symtab] Add name_of_main and language_of_main to the DWARF index Date: Fri, 6 Oct 2023 19:49:41 +0200 Message-Id: <20231006174942.27361-2-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20231006174942.27361-1-tdevries@suse.de> References: <20231006174942.27361-1-tdevries@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Binutils From: Tom de Vries Reply-To: Tom de Vries Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779029345171059224 X-GMAIL-MSGID: 1779029432128091542 From: Matheus Branco Borella This patch adds a new section to the DWARF index containing the name and the language of the main function symbol, gathered from `cooked_index::get_main`, if available. Currently, for lack of a better name, this section is called the "shortcut table". The way this name is both saved and applied upon an index being loaded in mirrors how it is done in `cooked_index_functions`, more specifically, the full name of the main function symbol is saved and `set_objfile_main_name` is used to apply it after it is loaded. The main use case for this patch is in improving startup times when dealing with large binaries. Currently, when an index is used, GDB has to expand symtabs until it finds out what the language of the main function symbol is. For some large executables, this may take a considerable amount of time to complete, slowing down startup. This patch bypasses that operation by having both the name and language of the main function symbol be provided ahead of time by the index. In my testing (a binary with about 1.8GB worth of DWARF data) this change brings startup time down from about 34 seconds to about 1.5 seconds. When testing the patch with target board cc-with-gdb-index, test-case gdb.fortran/nested-funcs-2.exp starts failing, but this is due to a pre-existing issue, filed as PR symtab/30946. Tested on x86_64-linux, with target board unix and cc-with-gdb-index. PR symtab/24549 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24549 --- gdb/NEWS | 3 +++ gdb/doc/gdb.texinfo | 23 ++++++++++++++-- gdb/dwarf2/index-write.c | 54 +++++++++++++++++++++++++++++++------ gdb/dwarf2/read-gdb-index.c | 54 ++++++++++++++++++++++++++++++++++++- gdb/dwarf2/read.c | 13 +++++++-- gdb/dwarf2/read.h | 12 +++++++++ 6 files changed, 146 insertions(+), 13 deletions(-) diff --git a/gdb/NEWS b/gdb/NEWS index 2f6378f9c7a..20f36d278bd 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -21,6 +21,9 @@ styling according to the spec. See https://no-color.org/. Styling can be re-enabled with "set style enabled on". +* GDB index now contains information about the main function. This speeds up + startup when it is being used for some large binaries. + * The AArch64 'org.gnu.gdb.aarch64.pauth' Pointer Authentication feature string has been deprecated in favor of the 'org.gnu.gdb.aarch64.pauth_v2' feature string. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 4932e49b758..db1a82ec838 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -49663,13 +49663,14 @@ unless otherwise noted: @enumerate @item -The version number, currently 8. Versions 1, 2 and 3 are obsolete. +The version number, currently 9. Versions 1, 2 and 3 are obsolete. Version 4 uses a different hashing function from versions 5 and 6. Version 6 includes symbols for inlined functions, whereas versions 4 and 5 do not. Version 7 adds attributes to the CU indices in the symbol table. Version 8 specifies that symbols from DWARF type units (@samp{DW_TAG_type_unit}) refer to the type unit's symbol table and not the -compilation unit (@samp{DW_TAG_comp_unit}) using the type. +compilation unit (@samp{DW_TAG_comp_unit}) using the type. Version 9 adds +the name and the language of the main function to the index. @value{GDBN} will only read version 4, 5, or 6 indices by specifying @code{set use-deprecated-index-sections on}. @@ -49690,6 +49691,9 @@ The offset, from the start of the file, of the address area. @item The offset, from the start of the file, of the symbol table. +@item +The offset, from the start of the file, of the shortcut table. + @item The offset, from the start of the file, of the constant pool. @end enumerate @@ -49766,6 +49770,21 @@ don't currently have a simple description of the canonicalization algorithm; if you intend to create new index sections, you must read the code. +@item The shortcut table +This is a data structure with the following fields: + +@table @asis +@item Language of main +An @code{offset_type} value indicating the language of the main function as a +@code{DW_LANG_} constant. This value will be zero if main function information +is not present. + +@item Name of main +An @code{offset_type} value indicating the offset of the main function's name +in the constant pool. This value must be ignored if the value for the language +of main is zero. +@end table + @item The constant pool. This is simply a bunch of bytes. It is organized so that alignment is correct: CU vectors are stored first, followed by diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c index 3acff266ab3..6ea4217fb22 100644 --- a/gdb/dwarf2/index-write.c +++ b/gdb/dwarf2/index-write.c @@ -1079,14 +1079,15 @@ write_gdbindex_1 (FILE *out_file, const data_buf &types_cu_list, const data_buf &addr_vec, const data_buf &symtab_vec, - const data_buf &constant_pool) + const data_buf &constant_pool, + const data_buf &shortcuts) { data_buf contents; - const offset_type size_of_header = 6 * sizeof (offset_type); + const offset_type size_of_header = 7 * sizeof (offset_type); uint64_t total_len = size_of_header; /* The version number. */ - contents.append_offset (8); + contents.append_offset (9); /* The offset of the CU list from the start of the file. */ contents.append_offset (total_len); @@ -1104,6 +1105,10 @@ write_gdbindex_1 (FILE *out_file, contents.append_offset (total_len); total_len += symtab_vec.size (); + /* The offset of the shortcut table from the start of the file. */ + contents.append_offset (total_len); + total_len += shortcuts.size (); + /* The offset of the constant pool from the start of the file. */ contents.append_offset (total_len); total_len += constant_pool.size (); @@ -1125,6 +1130,7 @@ write_gdbindex_1 (FILE *out_file, types_cu_list.file_write (out_file); addr_vec.file_write (out_file); symtab_vec.file_write (out_file); + shortcuts.file_write (out_file); constant_pool.file_write (out_file); assert_file_size (out_file, total_len); @@ -1187,6 +1193,34 @@ write_cooked_index (cooked_index *table, } } +/* Write shortcut information. */ + +static void +write_shortcuts_table (cooked_index *table, data_buf& shortcuts, + data_buf& cpool) +{ + const auto main_info = table->get_main (); + size_t main_name_offset = 0; + dwarf_source_language dw_lang = (dwarf_source_language)0; + + if (main_info != nullptr) + { + dw_lang = main_info->per_cu->dw_lang; + + if (dw_lang != 0) + { + auto_obstack obstack; + const auto main_name = main_info->full_name (&obstack, true); + + main_name_offset = cpool.size (); + cpool.append_cstr0 (main_name); + } + } + + shortcuts.append_uint (4, BFD_ENDIAN_LITTLE, dw_lang); + shortcuts.append_offset (main_name_offset); +} + /* Write contents of a .gdb_index section for OBJFILE into OUT_FILE. If OBJFILE has an associated dwz file, write contents of a .gdb_index section for that dwz file into DWZ_OUT_FILE. If OBJFILE does not have an @@ -1263,11 +1297,14 @@ write_gdbindex (dwarf2_per_bfd *per_bfd, cooked_index *table, write_hash_table (&symtab, symtab_vec, constant_pool); + data_buf shortcuts; + write_shortcuts_table (table, shortcuts, constant_pool); + write_gdbindex_1(out_file, objfile_cu_list, types_cu_list, addr_vec, - symtab_vec, constant_pool); + symtab_vec, constant_pool, shortcuts); if (dwz_out_file != NULL) - write_gdbindex_1 (dwz_out_file, dwz_cu_list, {}, {}, {}, {}); + write_gdbindex_1 (dwz_out_file, dwz_cu_list, {}, {}, {}, {}, {}); else gdb_assert (dwz_cu_list.empty ()); } @@ -1573,8 +1610,9 @@ gdb_index () pretend_data_buf addr_vec; pretend_data_buf symtab_vec; pretend_data_buf constant_pool; + pretend_data_buf short_cuts; - const size_t size_of_header = 6 * sizeof (offset_type); + const size_t size_of_header = 7 * sizeof (offset_type); /* Test that an overly large index will throw an error. */ symtab_vec.set_pretend_size (~(offset_type)0 - size_of_header); @@ -1584,7 +1622,7 @@ gdb_index () try { write_gdbindex_1 (nullptr, cu_list, types_cu_list, addr_vec, - symtab_vec, constant_pool); + symtab_vec, constant_pool, short_cuts); } catch (const gdb_exception_error &e) { @@ -1604,7 +1642,7 @@ gdb_index () try { write_gdbindex_1 (nullptr, cu_list, types_cu_list, addr_vec, - symtab_vec, constant_pool); + symtab_vec, constant_pool, short_cuts); } catch (const gdb_exception_error &e) { diff --git a/gdb/dwarf2/read-gdb-index.c b/gdb/dwarf2/read-gdb-index.c index 9bfc5302b0e..b96eaa96e23 100644 --- a/gdb/dwarf2/read-gdb-index.c +++ b/gdb/dwarf2/read-gdb-index.c @@ -88,6 +88,9 @@ struct mapped_gdb_index final : public mapped_index_base /* A pointer to the constant pool. */ gdb::array_view constant_pool; + /* The shortcut table data. */ + gdb::array_view shortcut_table; + /* Return the index into the constant pool of the name of the IDXth symbol in the symbol table. */ offset_type symbol_name_index (offset_type idx) const @@ -583,7 +586,7 @@ to use the section anyway."), /* Indexes with higher version than the one supported by GDB may be no longer backward compatible. */ - if (version > 8) + if (version > 9) return 0; map->version = version; @@ -610,6 +613,16 @@ to use the section anyway."), symbol_table_end)); ++i; + + if (version >= 9) + { + const gdb_byte *shortcut_table = addr + metadata[i]; + const gdb_byte *shortcut_table_end = addr + metadata[i + 1]; + map->shortcut_table + = gdb::array_view (shortcut_table, shortcut_table_end); + ++i; + } + map->constant_pool = buffer.slice (metadata[i]); if (map->constant_pool.empty () && !map->symbol_table.empty ()) @@ -758,6 +771,43 @@ create_addrmap_from_gdb_index (dwarf2_per_objfile *per_objfile, = new (&per_bfd->obstack) addrmap_fixed (&per_bfd->obstack, &mutable_map); } +/* Sets the name and language of the main function from the shortcut table. */ + +static void +set_main_name_from_gdb_index (dwarf2_per_objfile *per_objfile, + mapped_gdb_index *index) +{ + const auto expected_size = 4 + sizeof (offset_type); + if (index->shortcut_table.size () < expected_size) + /* The data in the section is not present, is corrupted or is in a version + * we don't know about. Regardless, we can't make use of it. */ + return; + + auto ptr = index->shortcut_table.data (); + const auto dw_lang = extract_unsigned_integer (ptr, 4, BFD_ENDIAN_LITTLE); + if (dw_lang >= DW_LANG_hi_user) + { + complaint (_(".gdb_index shortcut table has invalid main language %u"), + (unsigned) dw_lang); + return; + } + if (dw_lang == 0) + { + /* Don't bother if the language for the main symbol was not known or if + * there was no main symbol at all when the index was built. */ + return; + } + ptr += 4; + + const auto lang = dwarf_lang_to_enum_language (dw_lang); + const auto name_offset = extract_unsigned_integer (ptr, + sizeof (offset_type), + BFD_ENDIAN_LITTLE); + const auto name = (const char*) (index->constant_pool.data () + name_offset); + + set_objfile_main_name (per_objfile->objfile, name, (enum language) lang); +} + /* See read-gdb-index.h. */ int @@ -843,6 +893,8 @@ dwarf2_read_gdb_index create_addrmap_from_gdb_index (per_objfile, map.get ()); + set_main_name_from_gdb_index (per_objfile, map.get ()); + per_bfd->index_table = std::move (map); per_bfd->quick_file_names_table = create_quick_file_names_table (per_bfd->all_units.size ()); diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 5bbc8e24cf9..d4aec19d31d 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -17796,7 +17796,9 @@ leb128_size (const gdb_byte *buf) } } -static enum language +/* Converts DWARF language names to GDB language names. */ + +enum language dwarf_lang_to_enum_language (unsigned int lang) { enum language language; @@ -21725,6 +21727,7 @@ prepare_one_comp_unit (struct dwarf2_cu *cu, struct die_info *comp_unit_die, /* Set the language we're debugging. */ attr = dwarf2_attr (comp_unit_die, DW_AT_language, cu); enum language lang; + dwarf_source_language dw_lang = (dwarf_source_language)0; if (cu->producer != nullptr && strstr (cu->producer, "IBM XL C for OpenCL") != NULL) { @@ -21733,18 +21736,24 @@ prepare_one_comp_unit (struct dwarf2_cu *cu, struct die_info *comp_unit_die, language detection we fall back to the DW_AT_producer string. */ lang = language_opencl; + dw_lang = DW_LANG_OpenCL; } else if (cu->producer != nullptr && strstr (cu->producer, "GNU Go ") != NULL) { /* Similar hack for Go. */ lang = language_go; + dw_lang = DW_LANG_Go; } else if (attr != nullptr) - lang = dwarf_lang_to_enum_language (attr->constant_value (0)); + { + lang = dwarf_lang_to_enum_language (attr->constant_value (0)); + dw_lang = (dwarf_source_language)attr->constant_value (0); + } else lang = pretend_language; + cu->per_cu->dw_lang = dw_lang; cu->language_defn = language_def (lang); switch (comp_unit_die->tag) diff --git a/gdb/dwarf2/read.h b/gdb/dwarf2/read.h index 9dfc435e861..1d9432c5c11 100644 --- a/gdb/dwarf2/read.h +++ b/gdb/dwarf2/read.h @@ -245,6 +245,14 @@ struct dwarf2_per_cu_data functions above. */ std::vector *imported_symtabs = nullptr; + /* The original DW_LANG_* value of the CU, as provided to us by + * DW_AT_language. It is interesting to keep this value around in cases where + * we can't use the values from the language enum, as the mapping to them is + * lossy, and, while that is usually fine, things like the index have an + * understandable bias towards not exposing internal GDB structures to the + * outside world, and so prefer to use DWARF constants in their stead. */ + dwarf_source_language dw_lang; + /* Return true of IMPORTED_SYMTABS is empty or not yet allocated. */ bool imported_symtabs_empty () const { @@ -764,6 +772,10 @@ struct dwarf2_per_objfile std::unique_ptr> m_dwarf2_cus; }; +/* Converts DWARF language names to GDB language names. */ + +enum language dwarf_lang_to_enum_language (unsigned int lang); + /* Get the dwarf2_per_objfile associated to OBJFILE. */ dwarf2_per_objfile *get_dwarf2_per_objfile (struct objfile *objfile); From patchwork Fri Oct 6 17:49:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 149367 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp498096vqo; Fri, 6 Oct 2023 10:49:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdoMdEXlwP6cGj5nZqC7d6391QXn2xAqqT8P229Dh35eorwhMMjGa6+6J/sFLSF4CdztTq X-Received: by 2002:a05:6402:35ca:b0:52e:3ce8:e333 with SMTP id z10-20020a05640235ca00b0052e3ce8e333mr4391263edc.18.1696614596424; Fri, 06 Oct 2023 10:49:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696614596; cv=none; d=google.com; s=arc-20160816; b=XyYDUt5rp7vSLGMXcky/gDNijz6aRrW9CTHTsCyhL4dQkN5osnDfC33pEPGxvn+XaX KCrX04mHATfS1C19oBcoksJdhyblWyxEqkejPXakrsd0kXdME97clOtFH3Sptdvay0Hb 9Hki3DuL92pCze9FO0uAqfZGhTQAU7uOajVCNARwqwMGiuKRYqmTOJy2g+Oesgy6P0Rm DYJhsqCUmQb0hWDpmmiUfeoZ5KUgw2QIx2yH+//+Yd1YobBcYuQMeV060eHtsJpuyPV5 0zkadoSreRvCSraFOovH4Zx2BrhIiipmFcdeP4TnOhtfOv5IVL6NGcgtdtZhJVsliz18 57gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=6GsDfSO6PVBr9oDPqntTZ2QLpuztqfELgGZf2E9iZso=; fh=NLxAvL/bDfPg4AGOtxqvQlND8vazkZrNzKLY8+LAbBY=; b=Qx+uKLCmw2pDc9mzYxPNRmUIqLV/vZ79+3Zb9mokyFWQcSmEGSir9leu1UQ23ogn21 wdYDo/BSeXtJLB5hDSmNQxyzzW1V9HxiUTx/7KFicQO8hfMaNbhiSdjx1xdg6AdnLPha ZUmTjYDPmnt4VfNdLJYir3prg04cEbobLnlZ4agEeJCLN6VB7Qd7PqJUxGpw8PazD40m Y8wJQojstGh8l8sLv6s2VugKwmr8jUFtN6eR2dAe7jIo/9pj7+xtaLQiqvbFQrU8HJv+ L7kKk9L/v0L9IYduj6FJ67TwNHgIUmffIi/9fsa6fUkBD3fe6nn+jBOd+7Vbyzdk4Rdk VMCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=e3nYGQ5v; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id l14-20020a056402028e00b0053317c1d986si1747547edv.222.2023.10.06.10.49.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 10:49:56 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=e3nYGQ5v; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B7AFA3856DC2 for ; Fri, 6 Oct 2023 17:49:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7AFA3856DC2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696614591; bh=6GsDfSO6PVBr9oDPqntTZ2QLpuztqfELgGZf2E9iZso=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=e3nYGQ5vmQw4avhXyWvsibep1Jz9oaZRyL3yo4ANsic9m17oazukSfCz88ZN2tFyC M0cBa/t0T2ex936/7TXXQGaw85SYcNzamewEly+LyUuHZtV3LEZL6mvyswtlSLaGq0 yOfML+V8lRKxvD8TItLyFKV58Cpk//V46K8fsHS0= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id C9EB3385828E for ; Fri, 6 Oct 2023 17:49:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9EB3385828E Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F2A8F21880 for ; Fri, 6 Oct 2023 17:49:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DEA3213A7A for ; Fri, 6 Oct 2023 17:49:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6FEsNbRIIGXwQAAAMHmgww (envelope-from ) for ; Fri, 06 Oct 2023 17:49:40 +0000 To: binutils@sourceware.org Subject: [PATCH 2/2] [readelf] Handle .gdb_index section version 9 Date: Fri, 6 Oct 2023 19:49:42 +0200 Message-Id: <20231006174942.27361-3-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20231006174942.27361-1-tdevries@suse.de> References: <20231006174942.27361-1-tdevries@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Binutils From: Tom de Vries Reply-To: Tom de Vries Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779029347221487600 X-GMAIL-MSGID: 1779029347221487600 Add the abilitity to print a v9 .gdb_index section. The v9 section contains an extra table, which is printed as follows: ... Shortcut table: Language of main: Fortran 95 Name of main: contains_keyword ... [ For the example, I used the exec of gdb test-case gdb.fortran/nested-funcs-2-exp when running the test-case with target board cc-with-gdb-index. ] Tested on x86_64-linux. --- binutils/dwarf.c | 176 ++++++++++++++++++++++++++++++----------------- 1 file changed, 113 insertions(+), 63 deletions(-) diff --git a/binutils/dwarf.c b/binutils/dwarf.c index 7a350cae50b..6adc37c9169 100644 --- a/binutils/dwarf.c +++ b/binutils/dwarf.c @@ -2342,6 +2342,72 @@ display_discr_list (unsigned long form, printf (")(unsigned)"); } +static void +display_lang (uint64_t uvalue) +{ + switch (uvalue) + { + /* Ordered by the numeric value of these constants. */ + case DW_LANG_C89: printf ("ANSI C"); break; + case DW_LANG_C: printf ("non-ANSI C"); break; + case DW_LANG_Ada83: printf ("Ada"); break; + case DW_LANG_C_plus_plus: printf ("C++"); break; + case DW_LANG_Cobol74: printf ("Cobol 74"); break; + case DW_LANG_Cobol85: printf ("Cobol 85"); break; + case DW_LANG_Fortran77: printf ("FORTRAN 77"); break; + case DW_LANG_Fortran90: printf ("Fortran 90"); break; + case DW_LANG_Pascal83: printf ("ANSI Pascal"); break; + case DW_LANG_Modula2: printf ("Modula 2"); break; + + /* DWARF 2.1 values. */ + case DW_LANG_Java: printf ("Java"); break; + case DW_LANG_C99: printf ("ANSI C99"); break; + case DW_LANG_Ada95: printf ("ADA 95"); break; + case DW_LANG_Fortran95: printf ("Fortran 95"); break; + + /* DWARF 3 values. */ + case DW_LANG_PLI: printf ("PLI"); break; + case DW_LANG_ObjC: printf ("Objective C"); break; + case DW_LANG_ObjC_plus_plus: printf ("Objective C++"); break; + case DW_LANG_UPC: printf ("Unified Parallel C"); break; + case DW_LANG_D: printf ("D"); break; + + /* DWARF 4 values. */ + case DW_LANG_Python: printf ("Python"); break; + + /* DWARF 5 values. */ + case DW_LANG_OpenCL: printf ("OpenCL"); break; + case DW_LANG_Go: printf ("Go"); break; + case DW_LANG_Modula3: printf ("Modula 3"); break; + case DW_LANG_Haskell: printf ("Haskell"); break; + case DW_LANG_C_plus_plus_03: printf ("C++03"); break; + case DW_LANG_C_plus_plus_11: printf ("C++11"); break; + case DW_LANG_OCaml: printf ("OCaml"); break; + case DW_LANG_Rust: printf ("Rust"); break; + case DW_LANG_C11: printf ("C11"); break; + case DW_LANG_Swift: printf ("Swift"); break; + case DW_LANG_Julia: printf ("Julia"); break; + case DW_LANG_Dylan: printf ("Dylan"); break; + case DW_LANG_C_plus_plus_14: printf ("C++14"); break; + case DW_LANG_Fortran03: printf ("Fortran 03"); break; + case DW_LANG_Fortran08: printf ("Fortran 08"); break; + case DW_LANG_RenderScript: printf ("RenderScript"); break; + + /* MIPS extension. */ + case DW_LANG_Mips_Assembler: printf ("MIPS assembler"); break; + + /* UPC extension. */ + case DW_LANG_Upc: printf ("Unified Parallel C"); break; + + default: + if (uvalue >= DW_LANG_lo_user && uvalue <= DW_LANG_hi_user) + printf (_("implementation defined: %#" PRIx64 ""), uvalue); + else + printf (_("unknown: %#" PRIx64 ""), uvalue); + break; + } +} + static unsigned char * read_and_display_attr_value (unsigned long attribute, unsigned long form, @@ -3110,61 +3176,9 @@ read_and_display_attr_value (unsigned long attribute, break; case DW_AT_language: - printf ("\t"); - switch (uvalue) - { - /* Ordered by the numeric value of these constants. */ - case DW_LANG_C89: printf ("(ANSI C)"); break; - case DW_LANG_C: printf ("(non-ANSI C)"); break; - case DW_LANG_Ada83: printf ("(Ada)"); break; - case DW_LANG_C_plus_plus: printf ("(C++)"); break; - case DW_LANG_Cobol74: printf ("(Cobol 74)"); break; - case DW_LANG_Cobol85: printf ("(Cobol 85)"); break; - case DW_LANG_Fortran77: printf ("(FORTRAN 77)"); break; - case DW_LANG_Fortran90: printf ("(Fortran 90)"); break; - case DW_LANG_Pascal83: printf ("(ANSI Pascal)"); break; - case DW_LANG_Modula2: printf ("(Modula 2)"); break; - /* DWARF 2.1 values. */ - case DW_LANG_Java: printf ("(Java)"); break; - case DW_LANG_C99: printf ("(ANSI C99)"); break; - case DW_LANG_Ada95: printf ("(ADA 95)"); break; - case DW_LANG_Fortran95: printf ("(Fortran 95)"); break; - /* DWARF 3 values. */ - case DW_LANG_PLI: printf ("(PLI)"); break; - case DW_LANG_ObjC: printf ("(Objective C)"); break; - case DW_LANG_ObjC_plus_plus: printf ("(Objective C++)"); break; - case DW_LANG_UPC: printf ("(Unified Parallel C)"); break; - case DW_LANG_D: printf ("(D)"); break; - /* DWARF 4 values. */ - case DW_LANG_Python: printf ("(Python)"); break; - /* DWARF 5 values. */ - case DW_LANG_OpenCL: printf ("(OpenCL)"); break; - case DW_LANG_Go: printf ("(Go)"); break; - case DW_LANG_Modula3: printf ("(Modula 3)"); break; - case DW_LANG_Haskell: printf ("(Haskell)"); break; - case DW_LANG_C_plus_plus_03: printf ("(C++03)"); break; - case DW_LANG_C_plus_plus_11: printf ("(C++11)"); break; - case DW_LANG_OCaml: printf ("(OCaml)"); break; - case DW_LANG_Rust: printf ("(Rust)"); break; - case DW_LANG_C11: printf ("(C11)"); break; - case DW_LANG_Swift: printf ("(Swift)"); break; - case DW_LANG_Julia: printf ("(Julia)"); break; - case DW_LANG_Dylan: printf ("(Dylan)"); break; - case DW_LANG_C_plus_plus_14: printf ("(C++14)"); break; - case DW_LANG_Fortran03: printf ("(Fortran 03)"); break; - case DW_LANG_Fortran08: printf ("(Fortran 08)"); break; - case DW_LANG_RenderScript: printf ("(RenderScript)"); break; - /* MIPS extension. */ - case DW_LANG_Mips_Assembler: printf ("(MIPS assembler)"); break; - /* UPC extension. */ - case DW_LANG_Upc: printf ("(Unified Parallel C)"); break; - default: - if (uvalue >= DW_LANG_lo_user && uvalue <= DW_LANG_hi_user) - printf (_("(implementation defined: %#" PRIx64 ")"), uvalue); - else - printf (_("(unknown: %#" PRIx64 ")"), uvalue); - break; - } + printf ("\t("); + display_lang (uvalue); + printf (")"); break; case DW_AT_encoding: @@ -10738,29 +10752,31 @@ display_gdb_index (struct dwarf_section *section, unsigned char *start = section->start; uint32_t version; uint32_t cu_list_offset, tu_list_offset; - uint32_t address_table_offset, symbol_table_offset, constant_pool_offset; + uint32_t address_table_offset, symbol_table_offset, constant_pool_offset, + shortcut_table_offset; unsigned int cu_list_elements, tu_list_elements; unsigned int address_table_elements, symbol_table_slots; unsigned char *cu_list, *tu_list; - unsigned char *address_table, *symbol_table, *constant_pool; + unsigned char *address_table, *symbol_table, *shortcut_table, *constant_pool; unsigned int i; /* The documentation for the format of this file is in gdb/dwarf2read.c. */ introduce (section, false); - if (section->size < 6 * sizeof (uint32_t)) + version = section->size < 4 ? 0 : byte_get_little_endian (start, 4); + size_t header_size = (version < 9 ? 6 : 7) * sizeof (uint32_t); + if (section->size < header_size) { warn (_("Truncated header in the %s section.\n"), section->name); return 0; } - version = byte_get_little_endian (start, 4); printf (_("Version %lu\n"), (unsigned long) version); /* Prior versions are obsolete, and future versions may not be backwards compatible. */ - if (version < 3 || version > 8) + if (version < 3 || version > 9) { warn (_("Unsupported version %lu.\n"), (unsigned long) version); return 0; @@ -10782,17 +10798,23 @@ display_gdb_index (struct dwarf_section *section, tu_list_offset = byte_get_little_endian (start + 8, 4); address_table_offset = byte_get_little_endian (start + 12, 4); symbol_table_offset = byte_get_little_endian (start + 16, 4); - constant_pool_offset = byte_get_little_endian (start + 20, 4); + shortcut_table_offset = byte_get_little_endian (start + 20, 4); + if (version < 9) + constant_pool_offset = shortcut_table_offset; + else + constant_pool_offset = byte_get_little_endian (start + 24, 4); if (cu_list_offset > section->size || tu_list_offset > section->size || address_table_offset > section->size || symbol_table_offset > section->size + || shortcut_table_offset > section->size || constant_pool_offset > section->size || tu_list_offset < cu_list_offset || address_table_offset < tu_list_offset || symbol_table_offset < address_table_offset - || constant_pool_offset < symbol_table_offset) + || shortcut_table_offset < symbol_table_offset + || constant_pool_offset < shortcut_table_offset) { warn (_("Corrupt header in the %s section.\n"), section->name); return 0; @@ -10801,12 +10823,13 @@ display_gdb_index (struct dwarf_section *section, cu_list_elements = (tu_list_offset - cu_list_offset) / 16; tu_list_elements = (address_table_offset - tu_list_offset) / 24; address_table_elements = (symbol_table_offset - address_table_offset) / 20; - symbol_table_slots = (constant_pool_offset - symbol_table_offset) / 8; + symbol_table_slots = (shortcut_table_offset - symbol_table_offset) / 8; cu_list = start + cu_list_offset; tu_list = start + tu_list_offset; address_table = start + address_table_offset; symbol_table = start + symbol_table_offset; + shortcut_table = start + shortcut_table_offset; constant_pool = start + constant_pool_offset; printf (_("\nCU table:\n")); @@ -10918,6 +10941,33 @@ display_gdb_index (struct dwarf_section *section, } } + if (version > 9) + { + printf (_("\nShortcut table:\n")); + + if (shortcut_table_offset + 8 > constant_pool_offset) + { + warn (_("Corrupt shortcut table in the %s section.\n"), section->name); + return 0; + } + + uint32_t lang = byte_get_little_endian (shortcut_table, 4); + printf (_("Language of main: ")); + display_lang (lang); + printf ("\n"); + + uint32_t name_offset = byte_get_little_endian (shortcut_table + 4, 4); + printf (_("Name of main: ")); + if (name_offset >= section->size - constant_pool_offset) + { + printf (_("\n"), name_offset); + warn (_("Corrupt name offset of 0x%x found for name of main\n"), + name_offset); + } + else + printf ("%s\n", constant_pool + name_offset); + } + return 1; }