From patchwork Fri Oct 6 09:04:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Korotkov X-Patchwork-Id: 149156 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp183511vqo; Fri, 6 Oct 2023 02:06:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGC8FVteUuQ25pECjukR2eXPr6uesa4G2k3eaUG6Gm2pxa2+YVtIJwnoraxaT389UeFRr5b X-Received: by 2002:a05:6830:d6:b0:6be:fc8b:40fc with SMTP id x22-20020a05683000d600b006befc8b40fcmr7509183oto.36.1696583177813; Fri, 06 Oct 2023 02:06:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696583177; cv=none; d=google.com; s=arc-20160816; b=dQnULov1kRQzpi3b6rU4HuLMSW+wWKWXqZnHB2CRz7bpwec5kVQhmgu0Bo+jQ5UoOo nPCmn/eFiQn8DbSPv6zPkj0XUsR2UHcyGk6rmFiedBbSaGB1Jb76jErwv8xu4SnBU8/X 0Fbc13RipYtckIcaSa3qeod+7iNXfSuf4bK6AlbytM1Emv+AwgvGUy1WAm1FpW0nnsRf pEc1qxbtagJRSvP7BdhHCK5xDagiqAhdZgt66heh5rKbvaXiJumz83qTnJxxdFoPZ20f PHo8WyPW78hj+9nTvxPwbfjDe3cjR/3xinCAs35G0Vj5B2sc6zRId8N94HTPLW0RUGyD 0OYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=K4HOKOpHHPlHT6d0maywPvHxqU0NRGC5LpozW09vLNA=; fh=i1JuiXSmFPXBoAYamkKSWOqYisYyu8GXNGB8HtLeAcE=; b=OCDYRqyIht4t4n6/DkIWjB/2leI50RIm0D3ysHeFcyKvYXbS8D45CsPF0jQViawBDg av9WRxZpt/deZ2K98cZNBPZ750LV4DehQ4XrNetUPon6KbyFnhgzdYMVah+8eCe8Qcd1 HJzZ499tIk//N+xb1PHadGcTvInWzSfCDHH9e+vM4Sa/3rWlvH7BkJAhia1T4lov08eT arApBXQV+D4uUWLaTWGQA6Z4bW5ar42p4bbnlAAQapATXH3MDmeKttjW9pEsG6EGf5re M7n4xOsrpdCgKaIKlDgow9wokFJpZP83muOAkX5jB1aGpAGFxLr1ZNLqtSy031QWbe0V 8D+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=eoAlB5AE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id 204-20020a6300d5000000b00573fc6a17dbsi3195064pga.435.2023.10.06.02.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 02:06:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=eoAlB5AE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 86B2282E15BB; Fri, 6 Oct 2023 02:06:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231361AbjJFJGB (ORCPT + 18 others); Fri, 6 Oct 2023 05:06:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231215AbjJFJF7 (ORCPT ); Fri, 6 Oct 2023 05:05:59 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50B5683; Fri, 6 Oct 2023 02:05:58 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9b29186e20aso328541166b.2; Fri, 06 Oct 2023 02:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696583157; x=1697187957; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=K4HOKOpHHPlHT6d0maywPvHxqU0NRGC5LpozW09vLNA=; b=eoAlB5AEPTIAp458718A2eTT6rq+NhLuK7B/w/JYo2F84yhZETyrDATwtxETxi2ADO RtHtXZhrCsFS873GNWludaqOC7Ya0WYZInO2HEAUimJW72qW87/L9+HqaLMSUbF0B0hB QgovWZQCYmZ7NvkL9jaPRfwBREGh4tl5LGCo3DZMgnzmroqW9sFizis5R9bsOI/6+1+p oeooJ2GPx0yNUi+DNK6JglC6vayeMbQzb5a9jJPR9qUw8llNOEShk02KTr3e5Q5peTCy rsjtmCyEQBf+n8m9we9kVvk6XsOoHfGVHs4PPGwWeLpCZUAJH52dYCeUxrhKSeGCcFX0 QUTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696583157; x=1697187957; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K4HOKOpHHPlHT6d0maywPvHxqU0NRGC5LpozW09vLNA=; b=IfZNJ1Yf7byLChVVfzLjwjvmZrgfURoXifi+unO+XyMN3MegunztPVJP8q95wD+MFS S2Ekd/pKJe/pZZS0V8d/eAZ0sj5o5VEUI9L/8h+9F3CTZyA9oBbsF7Z9chEoTlKKfSDt BHj5uFP+NDvK/xUVBe/JE39CZnYBnVFlUiKeIkpB7b6Jg3J08qTgW7HdGO9oYwaxEk8Z ZLerE9AScVR9GvsZoqEAVfdjH5Mrx6sgDtAdWX2pw9E30qNPHhWcni/ILvdh1wWkiwoo TA48iX6ZGwzayuglYSGc8OlQ5B1hJY7cHNzrB9MgsjpgKdFwKTWH8v3InywtJ4XqMQF5 OKTw== X-Gm-Message-State: AOJu0Yz1VYwugyU713e4RpT15IVsCg5EkQ7ZoWLiYEA+1GqF1wPD0tgm /XZQ+gwqbnHkgZkLwhgH9HANNT13h3a9hdHrlXg= X-Received: by 2002:a17:907:78d1:b0:9b3:264:446 with SMTP id kv17-20020a17090778d100b009b302640446mr6986948ejc.0.1696583156474; Fri, 06 Oct 2023 02:05:56 -0700 (PDT) Received: from mkorotkov.rasu.local ([212.22.67.162]) by smtp.gmail.com with ESMTPSA id o6-20020a17090611c600b009ad875d12d7sm2509128eja.210.2023.10.06.02.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 02:05:56 -0700 (PDT) From: Maxim Korotkov To: Alessandro Zummo Cc: Maxim Korotkov , Alexandre Belloni , Shanker Donthineni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] rtc: efi: fixed typo in efi_procfs() Date: Fri, 6 Oct 2023 12:04:44 +0300 Message-Id: <20231006090444.306729-1-korotkov.maxim.s@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 06 Oct 2023 02:06:15 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778996402385842056 X-GMAIL-MSGID: 1778996402385842056 After the first check of the value of the "eft" variable it does not change, it is obvious that a copy-paste error was made here and the value of variable "alm" should be checked here. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 101ca8d05913 ("rtc: efi: Enable SET/GET WAKEUP services as optional") Signed-off-by: Maxim Korotkov --- drivers/rtc/rtc-efi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-efi.c b/drivers/rtc/rtc-efi.c index dc6b0f4a54e2..fa8bf82df948 100644 --- a/drivers/rtc/rtc-efi.c +++ b/drivers/rtc/rtc-efi.c @@ -227,7 +227,7 @@ static int efi_procfs(struct device *dev, struct seq_file *seq) enabled == 1 ? "yes" : "no", pending == 1 ? "yes" : "no"); - if (eft.timezone == EFI_UNSPECIFIED_TIMEZONE) + if (alm.timezone == EFI_UNSPECIFIED_TIMEZONE) seq_puts(seq, "Timezone\t: unspecified\n"); else /* XXX fixme: convert to string? */