From patchwork Thu Oct 5 13:17:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 148705 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2016:b0:403:3b70:6f57 with SMTP id fe22csp321235vqb; Thu, 5 Oct 2023 07:06:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1RK1udambTMgfxWFyWbsmr41BuzvymhDzFy2X2iDAyKFvDVjEdDUA1A6/pZDi/jVcGXhn X-Received: by 2002:a05:6a21:778b:b0:159:fe1d:2f09 with SMTP id bd11-20020a056a21778b00b00159fe1d2f09mr5964150pzc.6.1696514774928; Thu, 05 Oct 2023 07:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696514774; cv=none; d=google.com; s=arc-20160816; b=dx3cweT49r08P4qkQ6NY2+qzkz0dZIoc1M+nruQhxymqKy2iqfzl54bVcK0AKeMS+q 6oVF3MGvgzUJMX1rkqD6ohcmq2UUYBlUcLtsUwOYIygCvBsXMQh6NwQuBUwoOM3IyT1/ HBKZULjEMiAcdnIRKVoFyxFFfMf1tHeYZccaNSA7DLOFPSSezQvb7iNk+zJlKZ9PzKnq smvfuoQr8imD63NmIv/28GYwQVnA7csP9d592Qtko0T8eDCn+VpGmbutC3fPoBQo/Cin I0cc6dOYQjeHj7UxLHGl9vefNrEycHDrN5wzIdoZ75Ig551r7TE+FJLzEwh+i1OVi2ff nVXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WXlipJ5qHf8e9WzUIEs4uK8a+42CDw8ODZV/LpXLiL4=; fh=jaeMwWutqI8GzTNe6uK8144Nt4dk4/H7Lxb1J/kscxw=; b=PAp/A/rOGrjNNKEWamJyjn2L8fBiJAHGNVSi+zCgAb/48XShG4y7sywVzO+ti1xW7K d3ucULDFoxZq7HX3Uc7VUs+/I3dvZtnzGKkmCE1b+Zg0Dtvjp15vuO1npvORUARRjY89 3JRKBDo3gvaRhvdWhsQy18qgWBnGsv5x6L/ZrJyInan5S9ll4v0hWdo25I31FK/C+4o2 f5fzDSxVjlH/SD5gA4RnvBpfELYjTh1cMmpdv0SbLHPPzEgKzFboSsQGzkP90kPTi0sF dBt6NSbRPxvQCbTOEzW3EaOAqMb5oJ5hddm68UyyjCb+EROM1X0QBWBf1ypnHG46Low8 qQNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=IF0b2Sja; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id i188-20020a639dc5000000b0057768a32896si1497140pgd.365.2023.10.05.07.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 07:06:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=IF0b2Sja; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id AFF59826C4CB; Thu, 5 Oct 2023 07:06:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231721AbjJEOFy (ORCPT + 19 others); Thu, 5 Oct 2023 10:05:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231844AbjJEOEM (ORCPT ); Thu, 5 Oct 2023 10:04:12 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83ACD2755A; Thu, 5 Oct 2023 06:17:23 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-325e9cd483eso958992f8f.2; Thu, 05 Oct 2023 06:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696511842; x=1697116642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WXlipJ5qHf8e9WzUIEs4uK8a+42CDw8ODZV/LpXLiL4=; b=IF0b2SjaMzzCsgWmVj3AtXcx2CMEUysJkfnEGYEfOJ+tKcJXkmveIeTvgdDIRSGKUJ 0CiGMGwgNCD96lkQSKf7b8bO2Us2VxnxjXiw7DtPCbRTrsgaiCax4zj7Q0kO5XHZFmhF JVPyivfwS4APQDYQADCif43xa9o8Xzj/BN0oG7ZKGBL8Zq0yoj92T55Y4cBizoP0kHIU NK4t0SP/o1Cx2iI3WOlrLJzSMtUefStGZUwMFImQvRKyXzox/wRrVOVNw9CKW60yTMAr xzLyzxg+dOoY7pEUujO//wtZcK/ViQfSm7V3mnxvG15GxrdNimRsz3m3NI2ce9jNvsmy 8jcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696511842; x=1697116642; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WXlipJ5qHf8e9WzUIEs4uK8a+42CDw8ODZV/LpXLiL4=; b=V49zuU2fAqwFHawcTrlml9mKIm/y+3xjxy+3F+kFENks2LrorfR2g77EkOLPKqxcYS E/NaCgPbZ0ts8uGc2obe3Yqvc3p7OeXfjV/mrYmNobPKfiHXo31wf4uNwaCpi11pTkU/ 2TrXL0SoEtSnpk2EbskEbV3wjM8+Y+ZFuWGFlAAGVDRfuJv+VI+/itUvhXpXdIc/Xovo GVKM6BmgKkutZwyne2LLQF3poeOVNMhoYGSLJC9ttNAxvA5v1DmZyUS+CoG+lQ4sX+TQ dGzDH9Z/jzD/H/UoVezvJjqBjpj0Dh2tqS8Fbl7sbaj4LjDdNakg11gT6UmYSKjx5lUu b/LA== X-Gm-Message-State: AOJu0YwbArR5SoPpy2EVnO/eJK13hKPKavsNccRtKcsm8nuEXrserar3 jI3vVtFhiObZ6G0IkzKqSibVjraDvjo= X-Received: by 2002:a5d:4a05:0:b0:31f:a277:4cde with SMTP id m5-20020a5d4a05000000b0031fa2774cdemr5183667wrq.43.1696511841724; Thu, 05 Oct 2023 06:17:21 -0700 (PDT) Received: from amir-ThinkPad-T480.lan ([5.29.249.86]) by smtp.gmail.com with ESMTPSA id c3-20020adfed83000000b003250aec5e97sm1799762wro.4.2023.10.05.06.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 06:17:21 -0700 (PDT) From: Amir Goldstein To: Linus Torvalds Cc: Miklos Szeredi , Christian Brauner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: [GIT PULL] overlayfs fixes for 6.6-rc5 Date: Thu, 5 Oct 2023 16:17:17 +0300 Message-Id: <20231005131717.1311531-1-amir73il@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 07:06:06 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778924676489660201 X-GMAIL-MSGID: 1778924676489660201 Hi Linus, Please pull overlayfs fixes for 6.6-rc5. This branch has been sitting in linux-next for a couple of days and it has gone through the usual overlayfs test routines. The branch merges cleanly with master branch of the moment. Thanks, Amir. ---------------------------------------------------------------- The following changes since commit 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa: Linux 6.6-rc4 (2023-10-01 14:15:13 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/overlayfs/vfs.git ovl-fixes-6.6-rc5 for you to fetch changes up to c7242a45cb8cad5b6cd840fd4661315b45b1e841: ovl: fix NULL pointer defer when encoding non-decodable lower fid (2023-10-03 09:24:11 +0300) ---------------------------------------------------------------- overlayfs fixes for 6.6-rc5: - Fix for file reference leak regression from v6.6-rc2 - Fix for NULL pointer deref regression from v6.6-rc1 - Fixes for RCU-walk race regressions from v6.5: Two of the fixes were taken from Al's RCU pathwalk race fixes series with his concent [1]. Note that unlike most of Al's series, these two patches are not about racing with ->kill_sb() and they are also very recent regressions from v6.5, so I think it's worth getting them into v6.5.y. There is also a fix for an RCU pathwalk race with ->kill_sb(), which may have been solved in vfs generic code as you suggested, but it also rids overlayfs from a nasty hack, so I think it's worth anyway. [1] https://lore.kernel.org/linux-fsdevel/20231003204749.GA800259@ZenIV/ ---------------------------------------------------------------- Al Viro (2): ovl: move freeing ovl_entry past rcu delay ovl: fetch inode once in ovl_dentry_revalidate_common() Amir Goldstein (3): ovl: fix file reference leak when submitting aio ovl: make use of ->layers safe in rcu pathwalk ovl: fix NULL pointer defer when encoding non-decodable lower fid fs/overlayfs/export.c | 2 +- fs/overlayfs/file.c | 2 -- fs/overlayfs/ovl_entry.h | 10 +--------- fs/overlayfs/params.c | 17 +++++++++-------- fs/overlayfs/super.c | 27 +++++++++++++++++---------- 5 files changed, 28 insertions(+), 30 deletions(-)