From patchwork Thu Oct 5 11:43:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Zissulescu Ianculescu X-Patchwork-Id: 148678 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2016:b0:403:3b70:6f57 with SMTP id fe22csp232610vqb; Thu, 5 Oct 2023 04:45:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEIaA+hykG/5NxgjxLUFY3o+3ONcUstljwha+Vj2G1/f1ZW2v41qNjNuLp7wNNQ/6zZ6R1c X-Received: by 2002:a05:6402:134d:b0:525:6661:dc90 with SMTP id y13-20020a056402134d00b005256661dc90mr4238653edw.25.1696506310453; Thu, 05 Oct 2023 04:45:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696506310; cv=none; d=google.com; s=arc-20160816; b=0HddDNCqa+ubyLGKjNk2JelxuiInp7538zTume0wIQUgdgTv2Vcedc8sayDbrQsx4i AtBNBv6L+DDIOaBFYyugQCQS5M0kuvI7USSKGs/j4U72cXl73zX57CpnrQcxMmb216WS oYppB7OyOAupgfeTQaxuZaSxy8Z9mSdCeA54e3bwC9V6Sp1YUVc6yIa7oY5AaUUIcDSM le3wniHP49VTGeVN4UwiyPUv4HZhJiHwvLBf/m8wY6tsWLq57UnevyqDTm1RgzpGmU3G K7PXvh3yTdYF2YIrHVekrgRIm0sNB/sIzCJ7JtJL6MyuhUbvlj+ruk+H4rraU8uBsUnj NYYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :dmarc-filter:delivered-to; bh=v55KZV7kaxv6aZm/MFTzUrc6Z2HnpKw3I0mCK5PjvAc=; fh=7jtO1LQ2AGfJSFta5OEKAjdQtDhhgJZg7nT12/P8gFI=; b=xU7sLQbgCTMJVxIXstkKaSrTX61l6tkXdAIy1csmEL2+wOw0D42U39zhk9StRQFfUc 0ksNQMG+hEN6UxzMnYV4hR3tMdtYTRSnOLLGmcV99/RaZjjj6nzaGGjDi8DBCKZRaOj7 EDRW1q4+XYUh2QUAC0G0SkGgT6h2Q7LfXLF5U2xaJHSuRKszEOLT5/ZCX2/p8ub3pY6R /3Lo+i8ygrBHudJ/LzxIP0p97/lV11yPd3hhixoQuDW/VmR049RwEEc4IpG13l/Vx2o1 8qWuEg067OCglcOpoe/ovsaaqE3xZGChBXJRI6Exe2WxGLW1sD/Q6ygLEFzA432P94sE qgbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=XdYKpGqJ; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id y21-20020aa7c255000000b00530a038a026si663205edo.156.2023.10.05.04.45.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:45:10 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=XdYKpGqJ; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 33292385DC13 for ; Thu, 5 Oct 2023 11:44:19 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id AFD233857C43 for ; Thu, 5 Oct 2023 11:43:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFD233857C43 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-323168869daso883034f8f.2 for ; Thu, 05 Oct 2023 04:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696506229; x=1697111029; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=v55KZV7kaxv6aZm/MFTzUrc6Z2HnpKw3I0mCK5PjvAc=; b=XdYKpGqJ8Q9vbvCEDxJxb6d2yyfX5JiyLfINPS0IChhpVJ6jbi3feC9xZlaoVz+iyM sAOVhPy1IBoSi0EqlNnEnuQRJGMFWvunblzHOiG2JdGLWdqXXele2f1BTsYxH7V6tWi7 Ph+dlGqIIx3xDgUvb7ofdGVx//zIUreWNS95AHPg/SVqma644J9hQwRRgI5QrJfRYDI1 LejUSUfz2q2IfssT4ij9cy2KXlnz8MK6PuXjpAyUUxJkSae4MH/MWUcIrKGOEWg5lfet bLgouwU7vuK7Tad02gnKDp5yuLLlbAnuAHPALlzqT7reRQt52csOxXfDDCm4ys9BxSpZ aAdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696506229; x=1697111029; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v55KZV7kaxv6aZm/MFTzUrc6Z2HnpKw3I0mCK5PjvAc=; b=XpCnDu3SimLppLN121GeWNErRBRqbmai9CmsK3+d8cCWEFZcopzZIL4mCGzF4Z01uT G/afwilHloc7X+CfIE/cnbaInDqdVGazSAhuzXrDBo6qR5j0Ve/EolWWUxrI/u4qDbxt Q+G1WEksU+A2CP18ww8/Vt+qN0D5VphwYD6TOYPaxSyvvtyTPAMgTpc360LkFqsfC4ZC YR7Z0kDWJcaoSk+XDcIeOPZ4uTweVuG7kaKNDqEdplI1nUxFjTZjbAZGHlJipttbrMYm IS5dwg+kXoIMu+7TVaSiilX4hpGO7CWm1YDVT8g0xHkJ2rOlwwJyhNZ+zBAbF3kykjHL zGIA== X-Gm-Message-State: AOJu0YzrEjjlf6d0wnGCbrasIYxCg11V71mKePfFyJDMRZl4F1967fsU isWpywm5tH3clOhzAxghS9BDedeomZQ= X-Received: by 2002:adf:f703:0:b0:317:ddd3:1aed with SMTP id r3-20020adff703000000b00317ddd31aedmr4323247wrp.68.1696506228598; Thu, 05 Oct 2023 04:43:48 -0700 (PDT) Received: from fatty.nomansland ([193.187.151.25]) by smtp.gmail.com with ESMTPSA id f22-20020a5d58f6000000b0031423a8f4f7sm1605821wrd.56.2023.10.05.04.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:43:48 -0700 (PDT) From: Claudiu Zissulescu To: gcc-patches@gcc.gnu.org Cc: fbedard@synopsys.com Subject: [committed 1/5] arc: Remove unused/incomplete alignment assembly annotation. Date: Thu, 5 Oct 2023 14:43:41 +0300 Message-Id: <20231005114345.1707504-1-claziss@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SCC_5_SHORT_WORD_LINES, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778915801174081831 X-GMAIL-MSGID: 1778915801174081831 Removes '&' print operant punct character, disable -mannotate-align option and clean up the port. gcc/ * config/arc/arc-protos.h (arc_clear_unalign): Remove. (arc_toggle_unalign): Likewise. * config/arc/arc.cc (machine_function) Remove unalign. (arc_init): Remove `&` punct character. (arc_print_operand): Remove `&` related functions. (arc_verify_short): Update function's number of parameters. (output_short_suffix): Update function. (arc_short_long): Likewise. (arc_clear_unalign): Remove. (arc_toggle_unalign): Likewise. * config/arc/arc.h (ASM_OUTPUT_CASE_END): Remove. (ASM_OUTPUT_ALIGN): Update. * config/arc/arc.md: Remove all `%&` references. * config/arc/arc.opt (mannotate-align): Ignore option. * doc/invoke.texi (mannotate-align): Update description. Signed-off-by: Claudiu Zissulescu --- gcc/config/arc/arc-protos.h | 2 - gcc/config/arc/arc.cc | 33 ++-------- gcc/config/arc/arc.h | 16 ----- gcc/config/arc/arc.md | 125 ++++++++++++++++++------------------ gcc/config/arc/arc.opt | 4 +- gcc/doc/invoke.texi | 3 +- 6 files changed, 70 insertions(+), 113 deletions(-) diff --git a/gcc/config/arc/arc-protos.h b/gcc/config/arc/arc-protos.h index 5ce92ba261f..0e89ac7ae33 100644 --- a/gcc/config/arc/arc-protos.h +++ b/gcc/config/arc/arc-protos.h @@ -83,8 +83,6 @@ extern void arc_expand_prologue (void); extern void arc_expand_epilogue (int); extern void arc_init_expanders (void); extern int arc_check_millicode (rtx op, int offset, int load_p); -extern void arc_clear_unalign (void); -extern void arc_toggle_unalign (void); extern void split_subsi (rtx *); extern void arc_split_move (rtx *); extern const char *arc_short_long (rtx_insn *insn, const char *, const char *); diff --git a/gcc/config/arc/arc.cc b/gcc/config/arc/arc.cc index 2a59618ab6a..5e597d1bfeb 100644 --- a/gcc/config/arc/arc.cc +++ b/gcc/config/arc/arc.cc @@ -423,8 +423,6 @@ typedef struct GTY (()) machine_function { unsigned int fn_type; struct arc_frame_info frame_info; - /* To keep track of unalignment caused by short insns. */ - int unalign; struct arc_ccfsm ccfsm_current; /* Map from uid to ccfsm state during branch shortening. */ rtx ccfsm_current_insn; @@ -1133,7 +1131,6 @@ arc_init (void) arc_punct_chars['?'] = 1; arc_punct_chars['!'] = 1; arc_punct_chars['^'] = 1; - arc_punct_chars['&'] = 1; arc_punct_chars['+'] = 1; arc_punct_chars['_'] = 1; } @@ -5011,10 +5008,7 @@ arc_print_operand (FILE *file, rtx x, int code) return; } break; - case '&': - if (TARGET_ANNOTATE_ALIGN) - fprintf (file, "; unalign: %d", cfun->machine->unalign); - return; + case '+': if (TARGET_V2) fputs ("m", file); @@ -5682,7 +5676,7 @@ arc_ccfsm_cond_exec_p (void) If CHECK_ATTR is greater than 0, check the iscompact attribute first. */ static int -arc_verify_short (rtx_insn *insn, int, int check_attr) +arc_verify_short (rtx_insn *insn, int check_attr) { enum attr_iscompact iscompact; @@ -5697,8 +5691,7 @@ arc_verify_short (rtx_insn *insn, int, int check_attr) } /* When outputting an instruction (alternative) that can potentially be short, - output the short suffix if the insn is in fact short, and update - cfun->machine->unalign accordingly. */ + output the short suffix if the insn is in fact short. */ static void output_short_suffix (FILE *file) @@ -5707,10 +5700,9 @@ output_short_suffix (FILE *file) if (!insn) return; - if (arc_verify_short (insn, cfun->machine->unalign, 1)) + if (arc_verify_short (insn, 1)) { fprintf (file, "_s"); - cfun->machine->unalign ^= 2; } /* Restore recog_operand. */ extract_insn_cached (insn); @@ -10056,21 +10048,6 @@ arc_check_millicode (rtx op, int offset, int load_p) return 1; } -/* Accessor functions for cfun->machine->unalign. */ - -void -arc_clear_unalign (void) -{ - if (cfun) - cfun->machine->unalign = 0; -} - -void -arc_toggle_unalign (void) -{ - cfun->machine->unalign ^= 2; -} - /* Operands 0..2 are the operands of a subsi which uses a 12 bit constant in operand 1, but which would require a LIMM because of operand mismatch. @@ -10309,7 +10286,7 @@ arc_split_move (rtx *operands) const char * arc_short_long (rtx_insn *insn, const char *s_tmpl, const char *l_tmpl) { - int is_short = arc_verify_short (insn, cfun->machine->unalign, -1); + int is_short = arc_verify_short (insn, -1); extract_constrain_insn_cached (insn); return is_short ? s_tmpl : l_tmpl; diff --git a/gcc/config/arc/arc.h b/gcc/config/arc/arc.h index 8daae41ff5b..5877389a10d 100644 --- a/gcc/config/arc/arc.h +++ b/gcc/config/arc/arc.h @@ -1312,20 +1312,6 @@ do { \ /* Defined to also emit an .align in elfos.h. We don't want that. */ #undef ASM_OUTPUT_CASE_LABEL -/* ADDR_DIFF_VECs are in the text section and thus can affect the - current alignment. */ -#define ASM_OUTPUT_CASE_END(FILE, NUM, JUMPTABLE) \ - do \ - { \ - if (GET_CODE (PATTERN (JUMPTABLE)) == ADDR_DIFF_VEC \ - && ((GET_MODE_SIZE (as_a \ - (GET_MODE (PATTERN (JUMPTABLE)))) \ - * XVECLEN (PATTERN (JUMPTABLE), 1) + 1) \ - & 2)) \ - arc_toggle_unalign (); \ - } \ - while (0) - #define JUMP_ALIGN(LABEL) (arc_size_opt_level < 2 ? 2 : 0) #define LABEL_ALIGN_AFTER_BARRIER(LABEL) \ (JUMP_ALIGN(LABEL) \ @@ -1346,8 +1332,6 @@ do { \ #define ASM_OUTPUT_ALIGN(FILE,LOG) \ do { \ if ((LOG) != 0) fprintf (FILE, "\t.align %d\n", 1 << (LOG)); \ - if ((LOG) > 1) \ - arc_clear_unalign (); \ } while (0) /* ASM_OUTPUT_ALIGNED_DECL_LOCAL (STREAM, DECL, NAME, SIZE, ALIGNMENT) diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md index 9d5c65944fd..2a3ff05b66b 100644 --- a/gcc/config/arc/arc.md +++ b/gcc/config/arc/arc.md @@ -712,19 +712,19 @@ (define_insn "*movqi_insn" || (satisfies_constraint_Cm3 (operands[1]) && memory_operand (operands[0], QImode))" "@ - mov%? %0,%1%& - mov%? %0,%1%& - mov%? %0,%1%& - mov%? %0,%1%& - mov%? %0,%1%& mov%? %0,%1 mov%? %0,%1 mov%? %0,%1 mov%? %0,%1 mov%? %0,%1 - ldb%? %0,%1%& - stb%? %1,%0%& - ldb%? %0,%1%& + mov%? %0,%1 + mov%? %0,%1 + mov%? %0,%1 + mov%? %0,%1 + mov%? %0,%1 + ldb%? %0,%1 + stb%? %1,%0 + ldb%? %0,%1 xldb%U1 %0,%1 ldb%U1%V1 %0,%1 xstb%U0 %1,%0 @@ -756,19 +756,19 @@ (define_insn "*movhi_insn" || (satisfies_constraint_Cm3 (operands[1]) && memory_operand (operands[0], HImode))" "@ - mov%? %0,%1%& - mov%? %0,%1%& - mov%? %0,%1%& - mov%? %0,%1%& - mov%? %0,%1%& mov%? %0,%1 mov%? %0,%1 mov%? %0,%1 - mov%? %0,%1%& mov%? %0,%1 mov%? %0,%1 - ld%_%? %0,%1%& - st%_%? %1,%0%& + mov%? %0,%1 + mov%? %0,%1 + mov%? %0,%1 + mov%? %0,%1 + mov%? %0,%1 + mov%? %0,%1 + ld%_%? %0,%1 + st%_%? %1,%0 xld%_%U1 %0,%1 ld%_%U1%V1 %0,%1 xst%_%U0 %1,%0 @@ -822,15 +822,15 @@ (define_insn_and_split "*movsi_insn" ; 0 1 2 3 4 5 6 7 8 9 10 11 mov%?\\t%0,%j1 ;14 ld%?\\t%0,%1 ;15 st%?\\t%1,%0 ;16 - * return arc_short_long (insn, \"push%?\\t%1%&\", \"st%U0\\t%1,%0%&\"); - * return arc_short_long (insn, \"pop%?\\t%0%&\", \"ld%U1\\t%0,%1%&\"); + * return arc_short_long (insn, \"push%?\\t%1\", \"st%U0\\t%1,%0\"); + * return arc_short_long (insn, \"pop%?\\t%0\", \"ld%U1\\t%0,%1\"); ld%?\\t%0,%1 ;19 xld%U1\\t%0,%1 ;20 ld%?\\t%0,%1 ;21 ld%?\\t%0,%1 ;22 ld%U1%V1\\t%0,%1 ;23 xst%U0\\t%1,%0 ;24 - st%?\\t%1,%0%& ;25 + st%?\\t%1,%0 ;25 st%U0%V0\\t%1,%0 ;26 st%U0%V0\\t%1,%0 ;37 st%U0%V0\\t%1,%0 ;28" @@ -1034,9 +1034,9 @@ (define_insn "*tst" case 1: return \"btst%? %1,%z2\"; case 4: - return \"bmsk%?.f 0,%1,%Z2%&\"; + return \"bmsk%?.f 0,%1,%Z2\"; case 5: - return \"bclr%?.f 0,%1,%M2%&\"; + return \"bclr%?.f 0,%1,%M2\"; case 6: return \"asr.f 0,%1,%p2\"; default: @@ -1960,7 +1960,7 @@ (define_insn "*extendhisi2_i" "@ sex%_%?\\t%0,%1 sex%_\\t%0,%1 - ldh%?.x\\t%0,%1%& + ldh%?.x\\t%0,%1 ld%_.x%U1%V1\\t%0,%1 ld%_.x%U1%V1\\t%0,%1" [(set_attr "type" "unary,unary,load,load,load") @@ -1988,7 +1988,7 @@ (define_insn "abssi2" [(set (match_operand:SI 0 "dest_reg_operand" "=q,w,w") (abs:SI (match_operand:SI 1 "nonmemory_operand" "q,cL,Cal")))] "" - "abs%? %0,%1%&" + "abs%? %0,%1" [(set_attr "type" "two_cycle_core") (set_attr "length" "*,4,8") (set_attr "iscompact" "true,false,false")]) @@ -2286,7 +2286,7 @@ (define_insn "mul64" (sign_extend:DI (match_operand:SI 0 "register_operand" "%q, c,c, c")) (sign_extend:DI (match_operand:SI 1 "nonmemory_operand" "q,cL,L,C32"))))] "TARGET_MUL64_SET" - "mul64%? \t0, %0, %1%&" + "mul64%? \t0, %0, %1" [(set_attr "length" "*,4,4,8") (set_attr "iscompact" "maybe,false,false,false") (set_attr "type" "multi,multi,multi,multi") @@ -2321,7 +2321,7 @@ (define_insn "mulu64" (zero_extend:DI (match_operand:SI 0 "register_operand" "%c,c,c")) (zero_extend:DI (match_operand:SI 1 "nonmemory_operand" "cL,L,C32"))))] "TARGET_MUL64_SET" - "mulu64%? \t0, %0, %1%&" + "mulu64%? \t0, %0, %1" [(set_attr "length" "4,4,8") (set_attr "iscompact" "false") (set_attr "type" "umulti") @@ -2902,8 +2902,8 @@ (define_insn_and_split "subsi3_insn" "register_operand (operands[1], SImode) || register_operand (operands[2], SImode)" "@ - sub%?\\t%0,%1,%2%& - sub%?\\t%0,%1,%2%& + sub%?\\t%0,%1,%2 + sub%?\\t%0,%1,%2 sub%?\\t%0,%1,%2 rsub%?\\t%0,%2,%1 sub\\t%0,%1,%2 @@ -3211,26 +3211,26 @@ (define_insn "andsi3_i" ;0 1 2 3 4 5 switch (which_alternative) { case 0: case 5: case 10: case 11: case 16: case 17: case 18: - return "and%? %0,%1,%2%&"; + return "and%? %0,%1,%2"; case 1: case 6: - return "and%? %0,%2,%1%&"; + return "and%? %0,%2,%1"; case 2: - return "bmsk%? %0,%1,%Z2%&"; + return "bmsk%? %0,%1,%Z2"; case 7: case 12: if (satisfies_constraint_C2p (operands[2])) { operands[2] = GEN_INT ((~INTVAL (operands[2]))); - return "bmskn%? %0,%1,%Z2%&"; + return "bmskn%? %0,%1,%Z2"; } else { - return "bmsk%? %0,%1,%Z2%&"; + return "bmsk%? %0,%1,%Z2"; } case 3: case 8: case 13: - return "bclr%? %0,%1,%M2%&"; + return "bclr%? %0,%1,%M2"; case 4: return (INTVAL (operands[2]) == 0xff - ? "extb%? %0,%1%&" : "ext%_%? %0,%1%&"); + ? "extb%? %0,%1" : "ext%_%? %0,%1"); case 9: case 14: return \"bic%? %0,%1,%n2-1\"; case 15: return "movb.cl %0,%1,%p2,%p2,%x2"; @@ -3288,7 +3288,7 @@ (define_insn "*bicsi3_insn" (match_operand:SI 2 "nonmemory_operand" "0,0,0,0,r,r,Cal")))] "" "@ - bic%?\\t%0, %2, %1%& ;;constraint 0 + bic%?\\t%0, %2, %1 ;;constraint 0 bic%?\\t%0,%2,%1 ;;constraint 1 bic\\t%0,%2,%1 ;;constraint 2, FIXME: will it ever get generated ??? bic%?\\t%0,%2,%1 ;;constraint 3, FIXME: will it ever get generated ??? @@ -3343,9 +3343,9 @@ (define_insn "xorsi3" switch (which_alternative) { case 0: case 2: case 5: case 6: case 8: case 9: case 10: - return \"xor%?\\t%0,%1,%2%&\"; + return \"xor%?\\t%0,%1,%2\"; case 1: case 3: - return \"xor%?\\t%0,%2,%1%&\"; + return \"xor%?\\t%0,%2,%1\"; case 4: case 7: return \"bxor%?\\t%0,%1,%z2\"; default: @@ -3362,7 +3362,7 @@ (define_insn "negsi2" [(set (match_operand:SI 0 "dest_reg_operand" "=q,q,r,r") (neg:SI (match_operand:SI 1 "register_operand" "0,q,0,r")))] "" - "neg%?\\t%0,%1%&" + "neg%?\\t%0,%1" [(set_attr "type" "unary") (set_attr "iscompact" "maybe,true,false,false") (set_attr "predicable" "no,no,yes,no")]) @@ -3371,7 +3371,7 @@ (define_insn "one_cmplsi2" [(set (match_operand:SI 0 "dest_reg_operand" "=q,w") (not:SI (match_operand:SI 1 "register_operand" "q,c")))] "" - "not%? %0,%1%&" + "not%? %0,%1" [(set_attr "type" "unary,unary") (set_attr "iscompact" "true,false")]) @@ -3455,7 +3455,7 @@ (define_insn "*lshrsi3_insn" && (register_operand (operands[1], SImode) || register_operand (operands[2], SImode))" "*return (which_alternative <= 1 && !arc_ccfsm_cond_exec_p () - ? \"lsr%?\\t%0,%1%&\" : \"lsr%?\\t%0,%1,%2%&\");" + ? \"lsr%?\\t%0,%1\" : \"lsr%?\\t%0,%1,%2\");" [(set_attr "type" "shift") (set_attr "iscompact" "maybe,maybe,maybe,false,false,false") (set_attr "predicable" "no,no,no,yes,no,no") @@ -3676,7 +3676,7 @@ (define_insn "cmpsi_cc_insn_mixed" (compare:CC (match_operand:SI 0 "register_operand" "q, q, h, c, c, q,c") (match_operand:SI 1 "nonmemory_operand" "cO,hO,Cm1,cI,cL,Cal,Cal")))] "" - "cmp%? %0,%B1%&" + "cmp%? %0,%B1" [(set_attr "type" "compare") (set_attr "iscompact" "true,true,true,false,false,true_limm,false") (set_attr "predicable" "no,no,no,no,yes,no,yes") @@ -3689,7 +3689,7 @@ (define_insn "*cmpsi_cc_zn_insn" (compare:CC_ZN (match_operand:SI 0 "register_operand" "q,c") (const_int 0)))] "" - "tst%? %0,%0%&" + "tst%? %0,%0" [(set_attr "type" "compare,compare") (set_attr "iscompact" "true,false") (set_attr "predicable" "no,yes") @@ -3718,7 +3718,7 @@ (define_insn "*cmpsi_cc_z_insn" (match_operand:SI 1 "p2_immediate_operand" "O,n")))] "" "@ - cmp%? %0,%1%& + cmp%? %0,%1 bxor.f 0,%0,%z1" [(set_attr "type" "compare,compare") (set_attr "iscompact" "true,false") @@ -3730,7 +3730,7 @@ (define_insn "*cmpsi_cc_c_insn" (compare:CC_C (match_operand:SI 0 "register_operand" "q, q, h, c, q, c") (match_operand:SI 1 "nonmemory_operand" "cO,hO,Cm1,cI,Cal,Cal")))] "" - "cmp%? %0,%1%&" + "cmp%? %0,%1" [(set_attr "type" "compare") (set_attr "iscompact" "true,true,true,false,true_limm,false") (set_attr "cond" "set") @@ -3934,7 +3934,7 @@ (define_insn "*branch_insn" { arc_ccfsm_record_condition (operands[1], false, insn, 0); if (get_attr_length (insn) == 2) - return \"b%d1%? %^%l0%&\"; + return \"b%d1%? %^%l0\"; else return \"b%d1%# %^%l0\"; } @@ -4026,7 +4026,7 @@ (define_expand "jump" (define_insn "jump_i" [(set (pc) (label_ref (match_operand 0 "" "")))] "!TARGET_LONG_CALLS_SET || !CROSSING_JUMP_P (insn)" - "b%!%* %^%l0%&" + "b%!%* %^%l0" [(set_attr "type" "uncond_branch") (set (attr "iscompact") (if_then_else (match_test "get_attr_length (insn) == 2") @@ -4055,11 +4055,11 @@ (define_insn "indirect_jump" [(set (pc) (match_operand:SI 0 "nonmemory_operand" "L,I,Cal,q,r"))] "" "@ - j%!%* %0%& - j%!%* %0%& - j%!%* %0%& - j%!%* [%0]%& - j%!%* [%0]%&" + j%!%* %0 + j%!%* %0 + j%!%* %0 + j%!%* [%0] + j%!%* [%0]" [(set_attr "type" "jump") (set_attr "iscompact" "false,false,false,maybe,false") (set_attr "cond" "canuse,canuse_limm,canuse,canuse,canuse")]) @@ -4144,14 +4144,14 @@ (define_insn "casesi_load" switch (GET_MODE (diff_vec)) { case E_SImode: - return \"ld.as\\t%0,[%1,%2]%&\"; + return \"ld.as\\t%0,[%1,%2]\"; case E_HImode: if (ADDR_DIFF_VEC_FLAGS (diff_vec).offset_unsigned) return \"ld%_.as\\t%0,[%1,%2]\"; return \"ld%_.x.as\\t%0,[%1,%2]\"; case E_QImode: if (ADDR_DIFF_VEC_FLAGS (diff_vec).offset_unsigned) - return \"ldb%?\\t%0,[%1,%2]%&\"; + return \"ldb%?\\t%0,[%1,%2]\"; return \"ldb.x\\t%0,[%1,%2]\"; default: gcc_unreachable (); @@ -4187,7 +4187,7 @@ (define_insn "casesi_jump" [(set (pc) (match_operand:SI 0 "register_operand" "Cal,q,c")) (use (label_ref (match_operand 1 "" "")))] "" - "j%!%* [%0]%&" + "j%!%* [%0]" [(set_attr "type" "jump") (set_attr "iscompact" "false,maybe,false") (set_attr "cond" "canuse")]) @@ -4223,7 +4223,7 @@ (define_insn "*call_i" (clobber (reg:SI 31))] "" "@ - jl%!%* [%0]%& + jl%!%* [%0] jl%!%* [%0] jli_s %J0 sjli %J0 @@ -4267,7 +4267,7 @@ (define_insn "*call_value_i" (clobber (reg:SI 31))] "" "@ - jl%!%* [%1]%& + jl%!%* [%1] jl%!%* [%1] jli_s %J1 sjli %J1 @@ -4786,7 +4786,6 @@ (define_insn "trap_s" { if (which_alternative == 0) { - arc_toggle_unalign (); return \"trap_s %0\"; } @@ -4991,13 +4990,13 @@ (define_insn "cbranchsi4_scratch" "* switch (get_attr_length (insn)) { - case 2: return \"br%d0%? %1, %2, %^%l3%&\"; + case 2: return \"br%d0%? %1, %2, %^%l3\"; case 4: return \"br%d0%* %1, %B2, %^%l3\"; case 8: if (!brcc_nolimm_operator (operands[0], VOIDmode)) return \"br%d0%* %1, %B2, %^%l3\"; /* FALLTHRU */ case 6: case 10: - case 12:return \"cmp%? %1, %B2\\n\\tb%d0%* %^%l3%& ;br%d0 out of range\"; + case 12:return \"cmp%? %1, %B2\\n\\tb%d0%* %^%l3 ;br%d0 out of range\"; default: fprintf (stderr, \"unexpected length %d\\n\", get_attr_length (insn)); fflush (stderr); gcc_unreachable (); } " @@ -5260,7 +5259,7 @@ (define_insn "abssf2" [(set (match_operand:SF 0 "dest_reg_operand" "=q,r,r") (abs:SF (match_operand:SF 1 "register_operand" "0,0,r")))] "" - "bclr%?\\t%0,%1,31%&" + "bclr%?\\t%0,%1,31" [(set_attr "type" "unary") (set_attr "iscompact" "maybe,false,false") (set_attr "length" "2,4,4") @@ -6074,7 +6073,7 @@ (define_insn "ashlsi3_cnt1" (ashift:SI (match_operand:SI 1 "register_operand" "q,c") (const_int 1)))] "" - "asl%? %0,%1%&" + "asl%? %0,%1" [(set_attr "type" "unary") (set_attr "iscompact" "maybe,false") (set_attr "length" "*,4") @@ -6107,7 +6106,7 @@ (define_insn "lshrsi3_cnt1" (lshiftrt:SI (match_operand:SI 1 "register_operand" "q,c") (const_int 1)))] "" - "lsr%? %0,%1%&" + "lsr%? %0,%1" [(set_attr "type" "unary") (set_attr "iscompact" "maybe,false") (set_attr "predicable" "no,no")]) @@ -6117,7 +6116,7 @@ (define_insn "ashrsi3_cnt1" (ashiftrt:SI (match_operand:SI 1 "register_operand" "q,c") (const_int 1)))] "" - "asr%? %0,%1%&" + "asr%? %0,%1" [(set_attr "type" "unary") (set_attr "iscompact" "maybe,false") (set_attr "predicable" "no,no")]) diff --git a/gcc/config/arc/arc.opt b/gcc/config/arc/arc.opt index 4af901f2619..6542ce67837 100644 --- a/gcc/config/arc/arc.opt +++ b/gcc/config/arc/arc.opt @@ -300,8 +300,8 @@ Target Var(TARGET_MEDIUM_CALLS) Init(TARGET_MMEDIUM_CALLS_DEFAULT) Don't use less than 25 bit addressing range for calls. mannotate-align -Target Var(TARGET_ANNOTATE_ALIGN) -Explain what alignment considerations lead to the decision to make an insn short or long. +Target Ignore +Does nothing. Preserved for backward compatibility. malign-call Target Ignore diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 4085fc90907..23083467d47 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -21582,8 +21582,7 @@ Annotate assembler instructions with estimated addresses. @opindex mannotate-align @item -mannotate-align -Explain what alignment considerations lead to the decision to make an -instruction short or long. +Does nothing. Preserved for backward compatibility. @end table From patchwork Thu Oct 5 11:43:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Zissulescu Ianculescu X-Patchwork-Id: 148679 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2016:b0:403:3b70:6f57 with SMTP id fe22csp232880vqb; Thu, 5 Oct 2023 04:45:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMTf0njtHFrAcuMKWdnfNK6gxbi02VChMe10x+YM8ommNrpiU8S62JhI9IgLWgXwbPpqkt X-Received: by 2002:aa7:d907:0:b0:533:d1cd:62c5 with SMTP id a7-20020aa7d907000000b00533d1cd62c5mr3985041edr.17.1696506335647; Thu, 05 Oct 2023 04:45:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696506335; cv=none; d=google.com; s=arc-20160816; b=fnluMoJ5oCrA1JnBwKZ+uoIPZcZAH5WijygRsRnTDYxTzmT25pzXZ3gS6YUmK+jFXU LjvJRmqo03XRRXSYIJATLWoT3ky6fo6ZyvgVJySCDl+0t9SUf8Q6MI6dn7SLx5rL/UQ9 ekSeOneC68jfECd1g0wAquHIZeGkEMZJt7d+PY0hm9iUt9J98Aa1SPVD0e9Wxy7aCtkL UYOyj3NOgGnqEoJqfa7D9KM5pCbDYwDPOfYre7S69+g+drDPQItkCsKll8+3hylzjvGz QWmrzhKhk0K7yYWKeqA1LUIi3VyFDNlsUvxQ9zJLZLKUWb0e1WFNmItK5UxmAZNnZeDY 6Inw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dmarc-filter:delivered-to; bh=qalG2iL+PAJvfxQfDknQdfIA7E5I2P8VWwcssncbj+4=; fh=7jtO1LQ2AGfJSFta5OEKAjdQtDhhgJZg7nT12/P8gFI=; b=maWjUj1V00ML4AH/O5tBK9y6BYQZBt0JAiu0VToox3AR6ScL0dpX2bY27DPG4HjeUa 7aKjDKSbOgxcO3Q71pqZYSP00lnfC4terdhCoYZWk4X5svcft34B948WoEqwXrgSzQGD 0/TgdrhRR+2SIAvMnceRHBMLa1ypn2m+5UGJZr9LV6luGQOVk1TuqpgNQN3B9KeDOtRd HLPOBVcAfE0j2UhbBR6mFNJpZQQuc2iWFHT6erRKywQjnFul2j8ERODYdmiM2VKxvvO0 6M5+Jbilk1f22H5Bd6UtpcjWfpWvxrtqMBEVeR5pAorwMnkM/UfOFezAP6WtokmmlSYL RGuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="dxcVkP4/"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id r7-20020aa7d147000000b00536751c859csi641281edo.170.2023.10.05.04.45.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:45:35 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="dxcVkP4/"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 603033831E31 for ; Thu, 5 Oct 2023 11:44:27 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 8A3063856961 for ; Thu, 5 Oct 2023 11:43:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A3063856961 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4056ce55e7eso7397655e9.2 for ; Thu, 05 Oct 2023 04:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696506230; x=1697111030; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qalG2iL+PAJvfxQfDknQdfIA7E5I2P8VWwcssncbj+4=; b=dxcVkP4/162cdNzT8o2zmTSqujumK7hQQATKx6R84LMM2EhcrgAwGuGd54RBDXzgmx WCyLhKQxz49SrMWUx6R6Cth50Eb2LznVybZ8WTQfIJGWNdJ6M7ae7SBL2G/w8jn2J4mS 03nK5Ql61i2/iuAhtX3LzFu0AcytMdllnZbybahxMkvh/u1pMPsbRB6ZABUDN/Vdqg3o nnWJImAi45ikYiONakIbxpIirqX5tpdQGsJpeXgZbfDGwO77Y6gddubkOFS+DEZOZ0Z1 JuVmfVZ2co9VBhGQLSI189NwfAzQwNmRycuZkDSfIHXr65SjbZBdeJKFmw0VWN17edF+ lUBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696506230; x=1697111030; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qalG2iL+PAJvfxQfDknQdfIA7E5I2P8VWwcssncbj+4=; b=YqdO1pTlNulU57nv7Tu1d2OPynQDjB44m3beT5jIfUyewrHQYwxrg30DQlyFXMivdI Ujazlb2rp5DuCa+rjNSSY9yg47z83+9Zz6u71bF1Hn9n6w3m5jK4wupErVXnBfrfX3DM Te5VvoBUtPw0Qn7sPHNBB7yXiTJI9Y0Ocn3rvzAwTOELBneoegLqFdPlGi6Ao7Nfd5xY Mklrt+/8kwcL7EX8QSYNrAkqPeMkOEmquY2ONkE435UAnC9AGatuAWzs0a51Rm7GnYNK xo6uh0ehjWHcVDMQFQSLrbGSeS3HtoQ7m/SFy5MBbGI+YfNrjV8f4qHMSpWyIS1eebQe 7jPw== X-Gm-Message-State: AOJu0YztvzCdY8T+/PfjPBc5Aid3t4iauyVVbOATuUnmt7nQURyEtoqF h/oMZWkIwyIZ5/GxvfcwHH2Cj2oc9Io= X-Received: by 2002:a5d:6302:0:b0:323:3ab5:990c with SMTP id i2-20020a5d6302000000b003233ab5990cmr4368266wru.44.1696506229436; Thu, 05 Oct 2023 04:43:49 -0700 (PDT) Received: from fatty.nomansland ([193.187.151.25]) by smtp.gmail.com with ESMTPSA id f22-20020a5d58f6000000b0031423a8f4f7sm1605821wrd.56.2023.10.05.04.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:43:48 -0700 (PDT) From: Claudiu Zissulescu To: gcc-patches@gcc.gnu.org Cc: fbedard@synopsys.com Subject: [committed 2/5] arc: Update/remove ARC specific tests Date: Thu, 5 Oct 2023 14:43:42 +0300 Message-Id: <20231005114345.1707504-2-claziss@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231005114345.1707504-1-claziss@gmail.com> References: <20231005114345.1707504-1-claziss@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778915827461902482 X-GMAIL-MSGID: 1778915827461902482 Update tests and remove old mtune-* tests. gcc/testsuite * gcc.target/arc/add_n-combine.c: Recognize add2 instruction. * gcc.target/arc/firq-4.c: FP register is a temp reg. Update test. * gcc.target/arc/firq-6.c: Likewise. * gcc.target/arc/mtune-ARC600.c: Remove test. * gcc.target/arc/mtune-ARC601.c: Likewise. * gcc.target/arc/mtune-ARC700-xmac: Likewise. * gcc.target/arc/mtune-ARC700.c: Likewise. * gcc.target/arc/mtune-ARC725D.c: Likewise. * gcc.target/arc/mtune-ARC750D.c: Likewise. * gcc.target/arc/uncached-7.c: Set it to XFAIL. Signed-off-by: Claudiu Zissulescu --- gcc/testsuite/gcc.target/arc/add_n-combine.c | 2 +- gcc/testsuite/gcc.target/arc/firq-4.c | 1 - gcc/testsuite/gcc.target/arc/firq-6.c | 1 - gcc/testsuite/gcc.target/arc/mtune-ARC600.c | 4 ---- gcc/testsuite/gcc.target/arc/mtune-ARC601.c | 4 ---- gcc/testsuite/gcc.target/arc/mtune-ARC700-xmac | 4 ---- gcc/testsuite/gcc.target/arc/mtune-ARC700.c | 4 ---- gcc/testsuite/gcc.target/arc/mtune-ARC725D.c | 4 ---- gcc/testsuite/gcc.target/arc/mtune-ARC750D.c | 4 ---- gcc/testsuite/gcc.target/arc/uncached-7.c | 2 +- 10 files changed, 2 insertions(+), 28 deletions(-) delete mode 100644 gcc/testsuite/gcc.target/arc/mtune-ARC600.c delete mode 100644 gcc/testsuite/gcc.target/arc/mtune-ARC601.c delete mode 100644 gcc/testsuite/gcc.target/arc/mtune-ARC700-xmac delete mode 100644 gcc/testsuite/gcc.target/arc/mtune-ARC700.c delete mode 100644 gcc/testsuite/gcc.target/arc/mtune-ARC725D.c delete mode 100644 gcc/testsuite/gcc.target/arc/mtune-ARC750D.c diff --git a/gcc/testsuite/gcc.target/arc/add_n-combine.c b/gcc/testsuite/gcc.target/arc/add_n-combine.c index 84e261ece8f..fd311b3839c 100644 --- a/gcc/testsuite/gcc.target/arc/add_n-combine.c +++ b/gcc/testsuite/gcc.target/arc/add_n-combine.c @@ -46,5 +46,5 @@ void f() { } /* { dg-final { scan-assembler "@at1\\+1" } } */ -/* { dg-final { scan-assembler "@at2\\+2" } } */ +/* { dg-final { scan-assembler "add2" } } */ /* { dg-final { scan-assembler "add3" } } */ diff --git a/gcc/testsuite/gcc.target/arc/firq-4.c b/gcc/testsuite/gcc.target/arc/firq-4.c index 969ee796f03..cd939bf8ca3 100644 --- a/gcc/testsuite/gcc.target/arc/firq-4.c +++ b/gcc/testsuite/gcc.target/arc/firq-4.c @@ -28,4 +28,3 @@ handler1 (void) /* { dg-final { scan-assembler-not "fp,\\\[sp" } } */ /* { dg-final { scan-assembler-not "push.*fp" } } */ -/* { dg-final { scan-assembler "mov_s.*fp,sp" } } */ diff --git a/gcc/testsuite/gcc.target/arc/firq-6.c b/gcc/testsuite/gcc.target/arc/firq-6.c index 9421200d630..df04e46dd31 100644 --- a/gcc/testsuite/gcc.target/arc/firq-6.c +++ b/gcc/testsuite/gcc.target/arc/firq-6.c @@ -18,4 +18,3 @@ handler1 (void) "r25", "fp"); } /* { dg-final { scan-assembler-not "(s|l)(t|d)d.*r\[0-9\]+,\\\[sp,\[0-9\]+\\\]" } } */ -/* { dg-final { scan-assembler "mov_s.*fp,sp" } } */ diff --git a/gcc/testsuite/gcc.target/arc/mtune-ARC600.c b/gcc/testsuite/gcc.target/arc/mtune-ARC600.c deleted file mode 100644 index a483d1435ca..00000000000 --- a/gcc/testsuite/gcc.target/arc/mtune-ARC600.c +++ /dev/null @@ -1,4 +0,0 @@ -/* { dg-do compile } */ -/* { dg-options "-mtune=ARC600" } */ - -/* { dg-final { scan-assembler ".cpu ARC700" } } */ diff --git a/gcc/testsuite/gcc.target/arc/mtune-ARC601.c b/gcc/testsuite/gcc.target/arc/mtune-ARC601.c deleted file mode 100644 index ed57bd7092d..00000000000 --- a/gcc/testsuite/gcc.target/arc/mtune-ARC601.c +++ /dev/null @@ -1,4 +0,0 @@ -/* { dg-do compile } */ -/* { dg-options "-mtune=ARC601" } */ - -/* { dg-final { scan-assembler ".cpu ARC700" } } */ diff --git a/gcc/testsuite/gcc.target/arc/mtune-ARC700-xmac b/gcc/testsuite/gcc.target/arc/mtune-ARC700-xmac deleted file mode 100644 index 2f1e137be4d..00000000000 --- a/gcc/testsuite/gcc.target/arc/mtune-ARC700-xmac +++ /dev/null @@ -1,4 +0,0 @@ -/* { dg-do compile } */ -/* { dg-options "-mtune=ARC700-xmac" } */ - -/* { dg-final { scan-assembler ".cpu ARC700" } } */ diff --git a/gcc/testsuite/gcc.target/arc/mtune-ARC700.c b/gcc/testsuite/gcc.target/arc/mtune-ARC700.c deleted file mode 100644 index 851ea7305e0..00000000000 --- a/gcc/testsuite/gcc.target/arc/mtune-ARC700.c +++ /dev/null @@ -1,4 +0,0 @@ -/* { dg-do compile } */ -/* { dg-options "-mtune=ARC700" } */ - -/* { dg-final { scan-assembler ".cpu ARC700" } } */ diff --git a/gcc/testsuite/gcc.target/arc/mtune-ARC725D.c b/gcc/testsuite/gcc.target/arc/mtune-ARC725D.c deleted file mode 100644 index e2aa4846291..00000000000 --- a/gcc/testsuite/gcc.target/arc/mtune-ARC725D.c +++ /dev/null @@ -1,4 +0,0 @@ -/* { dg-do compile } */ -/* { dg-options "-mtune=ARC725D" } */ - -/* { dg-final { scan-assembler ".cpu ARC700" } } */ diff --git a/gcc/testsuite/gcc.target/arc/mtune-ARC750D.c b/gcc/testsuite/gcc.target/arc/mtune-ARC750D.c deleted file mode 100644 index 20923300ee1..00000000000 --- a/gcc/testsuite/gcc.target/arc/mtune-ARC750D.c +++ /dev/null @@ -1,4 +0,0 @@ -/* { dg-do compile } */ -/* { dg-options "-mtune=ARC750D" } */ - -/* { dg-final { scan-assembler ".cpu ARC700" } } */ diff --git a/gcc/testsuite/gcc.target/arc/uncached-7.c b/gcc/testsuite/gcc.target/arc/uncached-7.c index 4001b8bd821..23e5fe23b04 100644 --- a/gcc/testsuite/gcc.target/arc/uncached-7.c +++ b/gcc/testsuite/gcc.target/arc/uncached-7.c @@ -8,4 +8,4 @@ void s_acc(void) s[10] = 15; } -/* { dg-final { scan-assembler-times "st\.di" 1 } } */ +/* { dg-final { scan-assembler-times "st\.di" 1 { xfail *-*-* } } } */ From patchwork Thu Oct 5 11:43:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Zissulescu Ianculescu X-Patchwork-Id: 148680 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2016:b0:403:3b70:6f57 with SMTP id fe22csp233363vqb; Thu, 5 Oct 2023 04:46:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZGKYlLmoadOLSo2Cb778yDRSMM0zaUNRtCHYcrFLr/QqNedtQVBc3EXIV2/w6+YKQ9yyw X-Received: by 2002:a17:906:4e:b0:9a2:16e2:353 with SMTP id 14-20020a170906004e00b009a216e20353mr4810789ejg.6.1696506396233; Thu, 05 Oct 2023 04:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696506396; cv=none; d=google.com; s=arc-20160816; b=ln/YMs4oa9HYa641SWG7J0kzOoordRaqvTqN7oCyiGaNYEsVm6xmbD0tKVhscVFCVs YABpZwsLEQoN7nMzHTVteDIUyKQhKoUQ4YsOWu6ct7DTDZVuj0Jiec5i6iI2vZKLkPMd O3ANoSwoaRT6BDk5oD4g8TiGK8K2owHFD7Dl/UlZbD+V0FWkOrGunyWPvY2SXYoeqB4u CNi/1tOW6qIjZUnJCMiUrZHjxG9ROcJVQ6YbAftVxEkYtygrcDMkpOVxoUnMrewbecjU X6V8PaWEhtWTfEodFQkf0Khc9DLFCDOqeBV0rj5HywsSYFDWcu9VEaODtfh7gEtPu2je PiTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dmarc-filter:delivered-to; bh=wM26u+83rDCFdwQcrxtiuLNgIz3WsZYNZuklZ1PUYEU=; fh=7jtO1LQ2AGfJSFta5OEKAjdQtDhhgJZg7nT12/P8gFI=; b=0XTcoWM77dpfP1I/97YWFQEuT8ALDBbOeGhVYc2bovxVMAqmpCpIa7slx8Q+2tr4Tl Snvs9qOdSVQr2CdA+u/Q3Ra0XH06cyQr1UDnQ2zv+gPiaWWDWpAq7Rh4URqYSLtTN4+i z3vPBG5oKlqvJQkvaENG4H9QS1ZgIma95uuOeVwgQGT7NkqAHe1B6X78ZCvH1YYEHvIC u1awxTmRMVypAR2+z4XWSj7sgPdiu6fd5UrrlHVgmKbdtGQxHJc7DIWfG7uMR03vQCQY VNmoj+3hjXLovbPz9femnemtBuzOK6R7oRP653K0Lk4mI26RVJoTM9ZnkCE5Ni3DOWZw s8Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=QMQjNaee; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id f23-20020a170906085700b0099cc030dc66si636939ejd.19.2023.10.05.04.46.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:46:36 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=QMQjNaee; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3052438313BC for ; Thu, 5 Oct 2023 11:44:50 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id CAF73385B513 for ; Thu, 5 Oct 2023 11:43:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAF73385B513 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-32167a4adaaso823116f8f.1 for ; Thu, 05 Oct 2023 04:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696506230; x=1697111030; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wM26u+83rDCFdwQcrxtiuLNgIz3WsZYNZuklZ1PUYEU=; b=QMQjNaeeJDviVMU/Oty1undQ37b2oL8jsmeavdUOjJczQEfdZFRjfoKe81brutbqkO /WeHNp7l2q3Y2zz+jdkeZiFMhG0PmLEyIEfwzZGm4ceiYm0YVRta3g24OMB2KVAxHZ2T ceTyJwGlcWeWF7oPyXAnMBvtyfX0tSzd1/KV/l4LrWyzv+OFUDN0refzycDw+Jy9BQkM y4gQW8ZWpR/4YFk5m57rSkpcAhILNsNf3Z2imGSd8lJZCFU3lefXMB6CJu5sSLMNwsPB tvTKeg2Fqt17Lq9wK25h5zFsAC2sn0aAZanV3NJ4Dy6Oih5n/7EriXRWpQoHEJEyGX4r y4Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696506230; x=1697111030; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wM26u+83rDCFdwQcrxtiuLNgIz3WsZYNZuklZ1PUYEU=; b=SEXy6OezxupxGkQ6C5FD9bEiGyC7hfmvcBBrEcbc8k18j4pH/upbWTHQ0nbr/sI/Tl 2TWpDjnULa3HXzIcIvm0lkUuWyWqCRZEHTYqxpe5OQ9hQIswIKvPiUpVLD/9gbXFj71U jtNaixKbslSen1jdnZ9ghKkCB5QRB1Uw4UWWK5MINoFCSK1KdLv8BvRmBx1X8TvEdN6d Wtxsh8uwFBTjnnh4m/BUD95MVFmPTnc6mu70IHbDhR9DQisoQXyGaaQ56mKKUEvttsd7 W2DuE98o8rT15iZrG0943gn6HogngoEGOYDAZGjNrexUY5iHDgZTxFiFRuqNLotUieSc s3/Q== X-Gm-Message-State: AOJu0YyQHQIKbuSrsaMK+k6uI9BTHaug+2ubexcdKzVqBooJ8PYg2BOY 3eJmvpuVsGMUt7wyTyiA3zEZWKAc4hQ= X-Received: by 2002:a05:6000:1b07:b0:321:6450:62ea with SMTP id f7-20020a0560001b0700b00321645062eamr4783817wrz.36.1696506230179; Thu, 05 Oct 2023 04:43:50 -0700 (PDT) Received: from fatty.nomansland ([193.187.151.25]) by smtp.gmail.com with ESMTPSA id f22-20020a5d58f6000000b0031423a8f4f7sm1605821wrd.56.2023.10.05.04.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:43:49 -0700 (PDT) From: Claudiu Zissulescu To: gcc-patches@gcc.gnu.org Cc: fbedard@synopsys.com Subject: [committed 3/5] arc: Remove '^' print punct character Date: Thu, 5 Oct 2023 14:43:43 +0300 Message-Id: <20231005114345.1707504-3-claziss@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231005114345.1707504-1-claziss@gmail.com> References: <20231005114345.1707504-1-claziss@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778915891285603378 X-GMAIL-MSGID: 1778915891285603378 The '^' was used to print '@' character in the ouput assembly. This is not anylonger required by the ARC binutils. Remove it. gcc/ * config/arc/arc.cc (arc_init): Remove '^' punct char. (arc_print_operand): Remove related code. * config/arc/arc.md: Update patterns which uses '%&'. gcc/testsuite/ * gcc.target/arc/loop-3.c: Update test. Signed-off-by: Claudiu Zissulescu --- gcc/config/arc/arc.cc | 9 --------- gcc/config/arc/arc.md | 18 +++++++++--------- gcc/testsuite/gcc.target/arc/loop-3.c | 2 +- 3 files changed, 10 insertions(+), 19 deletions(-) diff --git a/gcc/config/arc/arc.cc b/gcc/config/arc/arc.cc index 5e597d1bfeb..a1428eb41c3 100644 --- a/gcc/config/arc/arc.cc +++ b/gcc/config/arc/arc.cc @@ -1130,7 +1130,6 @@ arc_init (void) arc_punct_chars['*'] = 1; arc_punct_chars['?'] = 1; arc_punct_chars['!'] = 1; - arc_punct_chars['^'] = 1; arc_punct_chars['+'] = 1; arc_punct_chars['_'] = 1; } @@ -4529,7 +4528,6 @@ static int output_sdata = 0; 'V': cache bypass indicator for volatile 'P' 'F' - '^' 'O': Operator 'o': original symbol - no @ prepending. */ @@ -4953,14 +4951,7 @@ arc_print_operand (FILE *file, rtx x, int code) case 'F': fputs (reg_names[REGNO (x)]+1, file); return; - case '^': - /* This punctuation character is needed because label references are - printed in the output template using %l. This is a front end - character, and when we want to emit a '@' before it, we have to use - this '^'. */ - fputc('@',file); - return; case 'O': /* Output an operator. */ switch (GET_CODE (x)) diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md index 2a3ff05b66b..945cc4042d1 100644 --- a/gcc/config/arc/arc.md +++ b/gcc/config/arc/arc.md @@ -3934,9 +3934,9 @@ (define_insn "*branch_insn" { arc_ccfsm_record_condition (operands[1], false, insn, 0); if (get_attr_length (insn) == 2) - return \"b%d1%? %^%l0\"; + return \"b%d1%?\\t%l0\"; else - return \"b%d1%# %^%l0\"; + return \"b%d1%#\\t%l0\"; } }" [(set_attr "type" "branch") @@ -3984,9 +3984,9 @@ (define_insn "*rev_branch_insn" { arc_ccfsm_record_condition (operands[1], true, insn, 0); if (get_attr_length (insn) == 2) - return \"b%D1%? %^%l0\"; + return \"b%D1%?\\t%l0\"; else - return \"b%D1%# %^%l0\"; + return \"b%D1%#\\t%l0\"; } }" [(set_attr "type" "branch") @@ -4026,7 +4026,7 @@ (define_expand "jump" (define_insn "jump_i" [(set (pc) (label_ref (match_operand 0 "" "")))] "!TARGET_LONG_CALLS_SET || !CROSSING_JUMP_P (insn)" - "b%!%* %^%l0" + "b%!%*\\t%l0" [(set_attr "type" "uncond_branch") (set (attr "iscompact") (if_then_else (match_test "get_attr_length (insn) == 2") @@ -4990,13 +4990,13 @@ (define_insn "cbranchsi4_scratch" "* switch (get_attr_length (insn)) { - case 2: return \"br%d0%? %1, %2, %^%l3\"; - case 4: return \"br%d0%* %1, %B2, %^%l3\"; + case 2: return \"br%d0%?\\t%1,%2,%l3\"; + case 4: return \"br%d0%*\\t%1,%B2,%l3\"; case 8: if (!brcc_nolimm_operator (operands[0], VOIDmode)) - return \"br%d0%* %1, %B2, %^%l3\"; + return \"br%d0%*\\t%1,%B2,%l3\"; /* FALLTHRU */ case 6: case 10: - case 12:return \"cmp%? %1, %B2\\n\\tb%d0%* %^%l3 ;br%d0 out of range\"; + case 12:return \"cmp%? %1, %B2\\n\\tb%d0%*\\t%l3 ;br%d0 out of range\"; default: fprintf (stderr, \"unexpected length %d\\n\", get_attr_length (insn)); fflush (stderr); gcc_unreachable (); } " diff --git a/gcc/testsuite/gcc.target/arc/loop-3.c b/gcc/testsuite/gcc.target/arc/loop-3.c index 7f55e2f43fa..ae0d6110f18 100644 --- a/gcc/testsuite/gcc.target/arc/loop-3.c +++ b/gcc/testsuite/gcc.target/arc/loop-3.c @@ -23,5 +23,5 @@ void fn1(void) } } -/* { dg-final { scan-assembler "bne.*@.L2" } } */ +/* { dg-final { scan-assembler "bne.*\\.L2" } } */ /* { dg-final { scan-assembler-not "add.eq" } } */ From patchwork Thu Oct 5 11:43:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Zissulescu Ianculescu X-Patchwork-Id: 148682 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2016:b0:403:3b70:6f57 with SMTP id fe22csp234489vqb; Thu, 5 Oct 2023 04:48:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGV/LiyJqls+lUCFIpc+XJLLhDfhBLL9Zta28+o5wpr8mr8UnboUP5c4/v7a59HDw6DG3wR X-Received: by 2002:a50:ef06:0:b0:52f:a44e:601d with SMTP id m6-20020a50ef06000000b0052fa44e601dmr4197551eds.9.1696506506542; Thu, 05 Oct 2023 04:48:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696506506; cv=none; d=google.com; s=arc-20160816; b=HebcSx6sqUAjv4jrpJr9H/KSKzLjMAQ+JJQGDzEpFo8UZqR56yIWrU7XdQn/XtdFun MZQL9a8yuT8ZQ5viZ5oRlqM1tnN1vpACldoV8AOEuVzxBOrokc9eSpbNpqIblazPUu9V nsj125jFT7dDIMJmZK2dt/gLja2UW3RRX6rjaIe6BwWACw5RCGO3iS2NvJywnLZGc9m9 v0f1xAWwc6AE4YemFJl9sExMDKBPgO/DLpxYjzyJDMl8YCzavi+InuVult3H6/029zPs zMwyKndFLoRqjOmoP70bG3dhHJGOP6obBc1XBogPHvn6Ufbn2ztGB9WoMDh7MMLk7saM F8Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dmarc-filter:delivered-to; bh=74Hx8M/MoFkrb9Z44mwDjx+uMU1n3zuHAd3oOq5R0oE=; fh=7jtO1LQ2AGfJSFta5OEKAjdQtDhhgJZg7nT12/P8gFI=; b=xaDfqZXfU5BSC8apCcGrcefNEE3/qlrKxiE9l0ICqhnBm0nv8GbqUzMWZxbNBHz64K akJ5cLjSIivAKDMt/Sn20ibtpxtiIJnb+XryMG5HYN09iT22/Pkn1DnaB1C231GsTnEQ brQkWYFWgih17w1M9N/MbzVyJweiloJN92/UzueNTNc4ZbzYmyLndjV+I/r6JtAwytXK loI3i7wvrggDYLM4Aq+4BUNdX9BuzjrDyJ9mBexL4QuxNFPwiy+zEmzYH81RxPRONoub 2iAh/v0cfzNUQt5TNxa3NvTUt+gYtpOXp8/1o5y1Gh7pHnUTmX1p9teWROzCWMFAu/fv zP8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D+u9egL2; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id o7-20020a056402038700b005378c7bca5asi639605edv.142.2023.10.05.04.48.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:48:26 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D+u9egL2; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B7CF4382EBD6 for ; Thu, 5 Oct 2023 11:45:39 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 6F5F23856951 for ; Thu, 5 Oct 2023 11:43:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F5F23856951 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-32799639a2aso882035f8f.3 for ; Thu, 05 Oct 2023 04:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696506232; x=1697111032; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=74Hx8M/MoFkrb9Z44mwDjx+uMU1n3zuHAd3oOq5R0oE=; b=D+u9egL26Bb8qtmMSC0AAs6YXiXRYrSoZ0zilhWGeP6NYJ1ike8pNKZMXnUzOGKa7U 8RitpNcNGvGbXOAQB/eR2m82xvJK6cxPGRwRTg2BQHUu2ddofLX5khxjyu5HG9rUbeTG XBUhWLDhiT8pwqOkv//jDmjlL/aUrRt/027nXjXjYA8AKsR7lS5/mlMFqt9iJkgUPVaU Usx57f1+rYc4gPzRXrBPern1xm7NUWTAoGweRHkKD0ekEgfmvY3YSNnpbO9NBDPJY9Io ooczx8Mmx13Bhc/4p8wcssoon1F86Zt0BN2/JfhWiELsVKqEwR43vYY37AcXIpzamOrs b51Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696506232; x=1697111032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=74Hx8M/MoFkrb9Z44mwDjx+uMU1n3zuHAd3oOq5R0oE=; b=nifrlnXn/vJB07qLa7/hhPzpP9aWtSyBDyES2vb/g0p40rc672rovuj8n8lEamV1gX CAKdCenCRQKa1nncnNMqWwpulZBWrqbdYP75mQ1s8uJpo//BsEhNWugmWSgyK+f1rL3y +QPfL/0TjAkM0Em6C8QfVzxEjT+zGID8/tgbrWoB9a4/VxgLHmTCpWJbBxwhXWVRH9+x Iia8Ub4igAga8gq1lQNEPDsAbJ93u0Nh4SCbKfUvnr6Bm7Mu9iXARA3y3NLJwodD5d0/ +UiL6dpRQVmf0K6RGoOhkCaT5tJeyO1YxeyEfUOiLGwrOKLNyTaCDE+PiDkWo5Q5m3KE U5mQ== X-Gm-Message-State: AOJu0YxyithYIRWJMAfiSamZEn3K1q4EG18MFyOydtNcmZ4e3LcC5ObG Oc2TDx/OQVDoNoUsITYBaxntu0JX+O0= X-Received: by 2002:a5d:6091:0:b0:317:5747:b955 with SMTP id w17-20020a5d6091000000b003175747b955mr4085474wrt.17.1696506231203; Thu, 05 Oct 2023 04:43:51 -0700 (PDT) Received: from fatty.nomansland ([193.187.151.25]) by smtp.gmail.com with ESMTPSA id f22-20020a5d58f6000000b0031423a8f4f7sm1605821wrd.56.2023.10.05.04.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:43:50 -0700 (PDT) From: Claudiu Zissulescu To: gcc-patches@gcc.gnu.org Cc: fbedard@synopsys.com Subject: [committed 4/5] arc: Remove obsolete ccfsm instruction predication mechanism Date: Thu, 5 Oct 2023 14:43:44 +0300 Message-Id: <20231005114345.1707504-4-claziss@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231005114345.1707504-1-claziss@gmail.com> References: <20231005114345.1707504-1-claziss@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778916006368011853 X-GMAIL-MSGID: 1778916006368011853 Remove old ccfsm responsible for conditional execution support in ARC. This machinery is not needed as the current gcc conditional execution support is mature. gcc/ * config/arc/arc-passes.def: Remove arc_ifcvt pass. * config/arc/arc-protos.h (arc_ccfsm_branch_deleted_p): Remove. (arc_ccfsm_record_branch_deleted): Likewise. (arc_ccfsm_cond_exec_p): Likewise. (arc_ccfsm): Likewise. (arc_ccfsm_record_condition): Likewise. (make_pass_arc_ifcvt): Likewise. * config/arc/arc.cc (arc_ccfsm): Remove. (arc_ccfsm_current): Likewise. (ARC_CCFSM_BRANCH_DELETED_P): Likewise. (ARC_CCFSM_RECORD_BRANCH_DELETED): Likewise. (ARC_CCFSM_COND_EXEC_P): Likewise. (CCFSM_ISCOMPACT): Likewise. (CCFSM_DBR_ISCOMPACT): Likewise. (machine_function): Remove ccfsm related fields. (arc_ifcvt): Remove pass. (arc_print_operand): Remove `#` punct operand and other ccfsm related code. (arc_ccfsm_advance): Remove. (arc_ccfsm_at_label): Likewise. (arc_ccfsm_record_condition): Likewise. (arc_ccfsm_post_advance): Likewise. (arc_ccfsm_branch_deleted_p): Likewise. (arc_ccfsm_record_branch_deleted): Likewise. (arc_ccfsm_cond_exec_p): Likewise. (arc_get_ccfsm_cond): Likewise. (arc_final_prescan_insn): Remove ccfsm references. (arc_internal_label): Likewise. (arc_reorg): Likewise. (arc_output_libcall): Likewise. * config/arc/arc.md: Remove ccfsm references and update related instruction patterns. Signed-off-by: Claudiu Zissulescu --- gcc/config/arc/arc-passes.def | 6 - gcc/config/arc/arc-protos.h | 7 - gcc/config/arc/arc.cc | 830 +--------------------------------- gcc/config/arc/arc.md | 118 +---- 4 files changed, 41 insertions(+), 920 deletions(-) diff --git a/gcc/config/arc/arc-passes.def b/gcc/config/arc/arc-passes.def index 0cb5d56a6d4..3f9222a8099 100644 --- a/gcc/config/arc/arc-passes.def +++ b/gcc/config/arc/arc-passes.def @@ -17,12 +17,6 @@ along with GCC; see the file COPYING3. If not see . */ -/* First target dependent ARC if-conversion pass. */ -INSERT_PASS_AFTER (pass_delay_slots, 1, pass_arc_ifcvt); - -/* Second target dependent ARC if-conversion pass. */ -INSERT_PASS_BEFORE (pass_shorten_branches, 1, pass_arc_ifcvt); - /* Find annulled delay insns and convert them to use the appropriate predicate. This allows branch shortening to size up these instructions properly. */ diff --git a/gcc/config/arc/arc-protos.h b/gcc/config/arc/arc-protos.h index 0e89ac7ae33..026ea99c9c6 100644 --- a/gcc/config/arc/arc-protos.h +++ b/gcc/config/arc/arc-protos.h @@ -52,8 +52,6 @@ extern bool arc_can_use_return_insn (void); extern bool arc_split_move_p (rtx *); #endif /* RTX_CODE */ -extern bool arc_ccfsm_branch_deleted_p (void); -extern void arc_ccfsm_record_branch_deleted (void); void arc_asm_output_aligned_decl_local (FILE *, tree, const char *, unsigned HOST_WIDE_INT, @@ -67,7 +65,6 @@ extern bool arc_raw_symbolic_reference_mentioned_p (rtx, bool); extern bool arc_is_longcall_p (rtx); extern bool arc_is_shortcall_p (rtx); extern bool valid_brcc_with_delay_p (rtx *); -extern bool arc_ccfsm_cond_exec_p (void); extern rtx disi_highpart (rtx); extern int arc_adjust_insn_length (rtx_insn *, int, bool); extern int arc_corereg_hazard (rtx, rtx); @@ -76,9 +73,6 @@ extern int arc_write_ext_corereg (rtx); extern rtx gen_acc1 (void); extern rtx gen_acc2 (void); extern bool arc_branch_size_unknown_p (void); -struct arc_ccfsm; -extern void arc_ccfsm_record_condition (rtx, bool, rtx_insn *, - struct arc_ccfsm *); extern void arc_expand_prologue (void); extern void arc_expand_epilogue (int); extern void arc_init_expanders (void); @@ -104,5 +98,4 @@ extern bool arc_is_jli_call_p (rtx); extern void arc_file_end (void); extern bool arc_is_secure_call_p (rtx); -rtl_opt_pass * make_pass_arc_ifcvt (gcc::context *ctxt); rtl_opt_pass * make_pass_arc_predicate_delay_insns (gcc::context *ctxt); diff --git a/gcc/config/arc/arc.cc b/gcc/config/arc/arc.cc index a1428eb41c3..ecc681cff61 100644 --- a/gcc/config/arc/arc.cc +++ b/gcc/config/arc/arc.cc @@ -101,16 +101,6 @@ HARD_REG_SET overrideregs; /* Array of valid operand punctuation characters. */ char arc_punct_chars[256]; -/* State used by arc_ccfsm_advance to implement conditional execution. */ -struct GTY (()) arc_ccfsm -{ - int state; - int cc; - rtx cond; - rtx_insn *target_insn; - int target_label; -}; - /* Status of the IRQ_CTRL_AUX register. */ typedef struct irq_ctrl_saved_t { @@ -143,36 +133,6 @@ static irq_ctrl_saved_t irq_ctrl_saved; /* Number of registers in second bank for FIRQ support. */ static int rgf_banked_register_count; -#define arc_ccfsm_current cfun->machine->ccfsm_current - -#define ARC_CCFSM_BRANCH_DELETED_P(STATE) \ - ((STATE)->state == 1 || (STATE)->state == 2) - -/* Indicate we're conditionalizing insns now. */ -#define ARC_CCFSM_RECORD_BRANCH_DELETED(STATE) \ - ((STATE)->state += 2) - -#define ARC_CCFSM_COND_EXEC_P(STATE) \ - ((STATE)->state == 3 || (STATE)->state == 4 || (STATE)->state == 5 \ - || current_insn_predicate) - -/* Check if INSN has a 16 bit opcode considering struct arc_ccfsm *STATE. */ -#define CCFSM_ISCOMPACT(INSN,STATE) \ - (ARC_CCFSM_COND_EXEC_P (STATE) \ - ? (get_attr_iscompact (INSN) == ISCOMPACT_TRUE \ - || get_attr_iscompact (INSN) == ISCOMPACT_TRUE_LIMM) \ - : get_attr_iscompact (INSN) != ISCOMPACT_FALSE) - -/* Likewise, but also consider that INSN might be in a delay slot of JUMP. */ -#define CCFSM_DBR_ISCOMPACT(INSN,JUMP,STATE) \ - ((ARC_CCFSM_COND_EXEC_P (STATE) \ - || (JUMP_P (JUMP) \ - && INSN_ANNULLED_BRANCH_P (JUMP) \ - && (TARGET_AT_DBR_CONDEXEC || INSN_FROM_TARGET_P (INSN)))) \ - ? (get_attr_iscompact (INSN) == ISCOMPACT_TRUE \ - || get_attr_iscompact (INSN) == ISCOMPACT_TRUE_LIMM) \ - : get_attr_iscompact (INSN) != ISCOMPACT_FALSE) - /* Start enter/leave register range. */ #define ENTER_LEAVE_START_REG 13 @@ -218,11 +178,6 @@ static int rgf_banked_register_count; /* ARC600 MULHI register. */ #define AUX_MULHI 0x12 -/* A nop is needed between a 4 byte insn that sets the condition codes and - a branch that uses them (the same isn't true for an 8 byte insn that sets - the condition codes). Set by arc_ccfsm_advance. Used by - arc_print_operand. */ - static int get_arc_condition_code (rtx); static tree arc_handle_interrupt_attribute (tree *, tree, tree, int, bool *); @@ -423,9 +378,6 @@ typedef struct GTY (()) machine_function { unsigned int fn_type; struct arc_frame_info frame_info; - struct arc_ccfsm ccfsm_current; - /* Map from uid to ccfsm state during branch shortening. */ - rtx ccfsm_current_insn; char arc_reorg_started; char prescan_initialized; } machine_function; @@ -962,53 +914,6 @@ arc_secondary_reload_conv (rtx reg, rtx mem, rtx scratch, bool store_p) return; } -static unsigned arc_ifcvt (void); - -namespace { - -const pass_data pass_data_arc_ifcvt = -{ - RTL_PASS, - "arc_ifcvt", /* name */ - OPTGROUP_NONE, /* optinfo_flags */ - TV_IFCVT2, /* tv_id */ - 0, /* properties_required */ - 0, /* properties_provided */ - 0, /* properties_destroyed */ - 0, /* todo_flags_start */ - TODO_df_finish /* todo_flags_finish */ -}; - -class pass_arc_ifcvt : public rtl_opt_pass -{ - public: - pass_arc_ifcvt (gcc::context *ctxt) - : rtl_opt_pass (pass_data_arc_ifcvt, ctxt) - {} - - /* opt_pass methods: */ - opt_pass * clone () - { - return new pass_arc_ifcvt (m_ctxt); - } - virtual unsigned int execute (function *) - { - return arc_ifcvt (); - } - virtual bool gate (function *) - { - return (optimize > 1 && !TARGET_NO_COND_EXEC); - } -}; - -} // anon namespace - -rtl_opt_pass * -make_pass_arc_ifcvt (gcc::context *ctxt) -{ - return new pass_arc_ifcvt (ctxt); -} - static unsigned arc_predicate_delay_insns (void); namespace { @@ -1126,7 +1031,6 @@ arc_init (void) /* Initialize array for PRINT_OPERAND_PUNCT_VALID_P. */ memset (arc_punct_chars, 0, sizeof (arc_punct_chars)); - arc_punct_chars['#'] = 1; arc_punct_chars['*'] = 1; arc_punct_chars['?'] = 1; arc_punct_chars['!'] = 1; @@ -4510,11 +4414,8 @@ static int output_sdata = 0; 'S': Scalled immediate, to be used in pair with 's'. 'N': Negative immediate, to be used in pair with 's'. 'x': size of bit field - '#': condbranch delay slot suffix '*': jump delay slot suffix '?' : nonjump-insn suffix for conditional execution or short instruction - '!' : jump / call suffix for conditional execution or short instruction - '`': fold constant inside unary o-perator, re-recognize, and emit. 'd' 'D' 'R': Second word @@ -4640,48 +4541,26 @@ arc_print_operand (FILE *file, rtx x, int code) output_operand_lossage ("invalid operand to %%s code"); return; - case '#' : - /* Conditional branches depending on condition codes. - Note that this is only for branches that were known to depend on - condition codes before delay slot scheduling; - out-of-range brcc / bbit expansions should use '*'. - This distinction is important because of the different - allowable delay slot insns and the output of the delay suffix - for TARGET_AT_DBR_COND_EXEC. */ case '*' : /* Unconditional branches / branches not depending on condition codes. This could also be a CALL_INSN. Output the appropriate delay slot suffix. */ if (final_sequence && final_sequence->len () != 1) { - rtx_insn *jump = final_sequence->insn (0); rtx_insn *delay = final_sequence->insn (1); /* For TARGET_PAD_RETURN we might have grabbed the delay insn. */ if (delay->deleted ()) return; - if (JUMP_P (jump) && INSN_ANNULLED_BRANCH_P (jump)) - fputs (INSN_FROM_TARGET_P (delay) ? ".d" - : TARGET_AT_DBR_CONDEXEC && code == '#' ? ".d" - : get_attr_type (jump) == TYPE_RETURN && code == '#' ? "" - : ".nd", - file); - else - fputs (".d", file); + fputs (".d", file); } return; + case '?' : /* with leading "." */ case '!' : /* without leading "." */ - /* This insn can be conditionally executed. See if the ccfsm machinery - says it should be conditionalized. - If it shouldn't, we'll check the compact attribute if this insn - has a short variant, which may be used depending on code size and - alignment considerations. */ if (current_insn_predicate) - arc_ccfsm_current.cc - = get_arc_condition_code (current_insn_predicate); - if (ARC_CCFSM_COND_EXEC_P (&arc_ccfsm_current)) { + int cc = get_arc_condition_code (current_insn_predicate); /* Is this insn in a delay slot sequence? */ if (!final_sequence || XVECLEN (final_sequence, 0) < 2 || current_insn_predicate @@ -4691,19 +4570,16 @@ arc_print_operand (FILE *file, rtx x, int code) /* This insn isn't in a delay slot sequence, or conditionalized independently of its position in a delay slot. */ fprintf (file, "%s%s", - code == '?' ? "." : "", - arc_condition_codes[arc_ccfsm_current.cc]); + code == '?' ? "." : "", arc_condition_codes[cc]); /* If this is a jump, there are still short variants. However, only beq_s / bne_s have the same offset range as b_s, and the only short conditional returns are jeq_s and jne_s. */ if (code == '!' - && (arc_ccfsm_current.cc == ARC_CC_EQ - || arc_ccfsm_current.cc == ARC_CC_NE - || 0 /* FIXME: check if branch in 7 bit range. */)) + && (cc == ARC_CC_EQ || cc == ARC_CC_NE)) output_short_suffix (file); } else if (code == '!') /* Jump with delay slot. */ - fputs (arc_condition_codes[arc_ccfsm_current.cc], file); + fputs (arc_condition_codes[cc], file); else /* An Instruction in a delay slot of a jump or call. */ { rtx jump = XVECEXP (final_sequence, 0, 0); @@ -4716,27 +4592,24 @@ arc_print_operand (FILE *file, rtx x, int code) if (INSN_FROM_TARGET_P (insn)) fprintf (file, "%s%s", code == '?' ? "." : "", - arc_condition_codes[ARC_INVERSE_CONDITION_CODE (arc_ccfsm_current.cc)]); + arc_condition_codes[ARC_INVERSE_CONDITION_CODE (cc)]); else fprintf (file, "%s%s", code == '?' ? "." : "", - arc_condition_codes[arc_ccfsm_current.cc]); - if (arc_ccfsm_current.state == 5) - arc_ccfsm_current.state = 0; + arc_condition_codes[cc]); } else - /* This insn is executed for either path, so don't - conditionalize it at all. */ - output_short_suffix (file); - + { + /* This insn is executed for either path, so don't + conditionalize it at all. */ + output_short_suffix (file); + } } } else output_short_suffix (file); return; - case'`': - /* FIXME: fold constant inside unary operator, re-recognize, and emit. */ - gcc_unreachable (); + case 'd' : fputs (arc_condition_codes[get_arc_condition_code (x)], file); return; @@ -5170,498 +5043,6 @@ arc_print_operand_address (FILE *file , rtx addr) } } -/* Conditional execution support. - - This is based on the ARM port but for now is much simpler. - - A finite state machine takes care of noticing whether or not instructions - can be conditionally executed, and thus decrease execution time and code - size by deleting branch instructions. The fsm is controlled by - arc_ccfsm_advance (called by arc_final_prescan_insn), and controls the - actions of PRINT_OPERAND. The patterns in the .md file for the branch - insns also have a hand in this. */ -/* The way we leave dealing with non-anulled or annull-false delay slot - insns to the consumer is awkward. */ - -/* The state of the fsm controlling condition codes are: - 0: normal, do nothing special - 1: don't output this insn - 2: don't output this insn - 3: make insns conditional - 4: make insns conditional - 5: make insn conditional (only for outputting anulled delay slot insns) - - special value for cfun->machine->uid_ccfsm_state: - 6: return with but one insn before it since function start / call - - State transitions (state->state by whom, under what condition): - 0 -> 1 arc_ccfsm_advance, if insn is a conditional branch skipping over - some instructions. - 0 -> 2 arc_ccfsm_advance, if insn is a conditional branch followed - by zero or more non-jump insns and an unconditional branch with - the same target label as the condbranch. - 1 -> 3 branch patterns, after having not output the conditional branch - 2 -> 4 branch patterns, after having not output the conditional branch - 0 -> 5 branch patterns, for anulled delay slot insn. - 3 -> 0 ASM_OUTPUT_INTERNAL_LABEL, if the `target' label is reached - (the target label has CODE_LABEL_NUMBER equal to - arc_ccfsm_target_label). - 4 -> 0 arc_ccfsm_advance, if `target' unconditional branch is reached - 3 -> 1 arc_ccfsm_advance, finding an 'else' jump skipping over some insns. - 5 -> 0 when outputting the delay slot insn - - If the jump clobbers the conditions then we use states 2 and 4. - - A similar thing can be done with conditional return insns. - - We also handle separating branches from sets of the condition code. - This is done here because knowledge of the ccfsm state is required, - we may not be outputting the branch. */ - -/* arc_final_prescan_insn calls arc_ccfsm_advance to adjust arc_ccfsm_current, - before letting final output INSN. */ - -static void -arc_ccfsm_advance (rtx_insn *insn, struct arc_ccfsm *state) -{ - /* BODY will hold the body of INSN. */ - rtx body; - - /* This will be 1 if trying to repeat the trick (ie: do the `else' part of - an if/then/else), and things need to be reversed. */ - int reverse = 0; - - /* If we start with a return insn, we only succeed if we find another one. */ - int seeking_return = 0; - - /* START_INSN will hold the insn from where we start looking. This is the - first insn after the following code_label if REVERSE is true. */ - rtx_insn *start_insn = insn; - - /* Type of the jump_insn. Brcc insns don't affect ccfsm changes, - since they don't rely on a cmp preceding the. */ - enum attr_type jump_insn_type; - - /* Allow -mdebug-ccfsm to turn this off so we can see how well it does. - We can't do this in macro FINAL_PRESCAN_INSN because its called from - final_scan_insn which has `optimize' as a local. */ - if (optimize < 2 || TARGET_NO_COND_EXEC) - return; - - /* Ignore notes and labels. */ - if (!INSN_P (insn)) - return; - body = PATTERN (insn); - /* If in state 4, check if the target branch is reached, in order to - change back to state 0. */ - if (state->state == 4) - { - if (insn == state->target_insn) - { - state->target_insn = NULL; - state->state = 0; - } - return; - } - - /* If in state 3, it is possible to repeat the trick, if this insn is an - unconditional branch to a label, and immediately following this branch - is the previous target label which is only used once, and the label this - branch jumps to is not too far off. Or in other words "we've done the - `then' part, see if we can do the `else' part." */ - if (state->state == 3) - { - if (simplejump_p (insn)) - { - start_insn = next_nonnote_insn (start_insn); - if (GET_CODE (start_insn) == BARRIER) - { - /* ??? Isn't this always a barrier? */ - start_insn = next_nonnote_insn (start_insn); - } - if (GET_CODE (start_insn) == CODE_LABEL - && CODE_LABEL_NUMBER (start_insn) == state->target_label - && LABEL_NUSES (start_insn) == 1) - reverse = TRUE; - else - return; - } - else if (GET_CODE (body) == SIMPLE_RETURN) - { - start_insn = next_nonnote_insn (start_insn); - if (GET_CODE (start_insn) == BARRIER) - start_insn = next_nonnote_insn (start_insn); - if (GET_CODE (start_insn) == CODE_LABEL - && CODE_LABEL_NUMBER (start_insn) == state->target_label - && LABEL_NUSES (start_insn) == 1) - { - reverse = TRUE; - seeking_return = 1; - } - else - return; - } - else - return; - } - - if (GET_CODE (insn) != JUMP_INSN - || GET_CODE (PATTERN (insn)) == ADDR_VEC - || GET_CODE (PATTERN (insn)) == ADDR_DIFF_VEC) - return; - - /* We can't predicate BRCC or loop ends. - Also, when generating PIC code, and considering a medium range call, - we can't predicate the call. */ - jump_insn_type = get_attr_type (insn); - if (jump_insn_type == TYPE_BRCC - || jump_insn_type == TYPE_BRCC_NO_DELAY_SLOT - || jump_insn_type == TYPE_LOOP_END - || (jump_insn_type == TYPE_CALL && !get_attr_predicable (insn))) - return; - - /* This jump might be paralleled with a clobber of the condition codes, - the jump should always come first. */ - if (GET_CODE (body) == PARALLEL && XVECLEN (body, 0) > 0) - body = XVECEXP (body, 0, 0); - - if (reverse - || (GET_CODE (body) == SET && GET_CODE (SET_DEST (body)) == PC - && GET_CODE (SET_SRC (body)) == IF_THEN_ELSE)) - { - int insns_skipped = 0, fail = FALSE, succeed = FALSE; - /* Flag which part of the IF_THEN_ELSE is the LABEL_REF. */ - int then_not_else = TRUE; - /* Nonzero if next insn must be the target label. */ - int next_must_be_target_label_p; - rtx_insn *this_insn = start_insn; - rtx label = 0; - - /* Register the insn jumped to. */ - if (reverse) - { - if (!seeking_return) - label = XEXP (SET_SRC (body), 0); - } - else if (GET_CODE (XEXP (SET_SRC (body), 1)) == LABEL_REF) - label = XEXP (XEXP (SET_SRC (body), 1), 0); - else if (GET_CODE (XEXP (SET_SRC (body), 2)) == LABEL_REF) - { - label = XEXP (XEXP (SET_SRC (body), 2), 0); - then_not_else = FALSE; - } - else if (GET_CODE (XEXP (SET_SRC (body), 1)) == SIMPLE_RETURN) - seeking_return = 1; - else if (GET_CODE (XEXP (SET_SRC (body), 2)) == SIMPLE_RETURN) - { - seeking_return = 1; - then_not_else = FALSE; - } - else - gcc_unreachable (); - - /* If this is a non-annulled branch with a delay slot, there is - no need to conditionalize the delay slot. */ - if ((GET_CODE (PATTERN (NEXT_INSN (PREV_INSN (insn)))) == SEQUENCE) - && state->state == 0 && !INSN_ANNULLED_BRANCH_P (insn)) - { - this_insn = NEXT_INSN (this_insn); - } - /* See how many insns this branch skips, and what kind of insns. If all - insns are okay, and the label or unconditional branch to the same - label is not too far away, succeed. */ - for (insns_skipped = 0, next_must_be_target_label_p = FALSE; - !fail && !succeed && insns_skipped < MAX_INSNS_SKIPPED; - insns_skipped++) - { - rtx scanbody; - - this_insn = next_nonnote_insn (this_insn); - if (!this_insn) - break; - - if (next_must_be_target_label_p) - { - if (GET_CODE (this_insn) == BARRIER) - continue; - if (GET_CODE (this_insn) == CODE_LABEL - && this_insn == label) - { - state->state = 1; - succeed = TRUE; - } - else - fail = TRUE; - break; - } - - switch (GET_CODE (this_insn)) - { - case CODE_LABEL: - /* Succeed if it is the target label, otherwise fail since - control falls in from somewhere else. */ - if (this_insn == label) - { - state->state = 1; - succeed = TRUE; - } - else - fail = TRUE; - break; - - case BARRIER: - /* Succeed if the following insn is the target label. - Otherwise fail. - If return insns are used then the last insn in a function - will be a barrier. */ - next_must_be_target_label_p = TRUE; - break; - - case CALL_INSN: - /* Can handle a call insn if there are no insns after it. - IE: The next "insn" is the target label. We don't have to - worry about delay slots as such insns are SEQUENCE's inside - INSN's. ??? It is possible to handle such insns though. */ - if (get_attr_cond (this_insn) == COND_CANUSE) - next_must_be_target_label_p = TRUE; - else - fail = TRUE; - break; - - case JUMP_INSN: - scanbody = PATTERN (this_insn); - - /* If this is an unconditional branch to the same label, succeed. - If it is to another label, do nothing. If it is conditional, - fail. */ - /* ??? Probably, the test for the SET and the PC are - unnecessary. */ - - if (GET_CODE (scanbody) == SET - && GET_CODE (SET_DEST (scanbody)) == PC) - { - if (GET_CODE (SET_SRC (scanbody)) == LABEL_REF - && XEXP (SET_SRC (scanbody), 0) == label && !reverse) - { - state->state = 2; - succeed = TRUE; - } - else if (GET_CODE (SET_SRC (scanbody)) == IF_THEN_ELSE) - fail = TRUE; - else if (get_attr_cond (this_insn) != COND_CANUSE) - fail = TRUE; - } - else if (GET_CODE (scanbody) == SIMPLE_RETURN - && seeking_return) - { - state->state = 2; - succeed = TRUE; - } - else if (GET_CODE (scanbody) == PARALLEL) - { - if (get_attr_cond (this_insn) != COND_CANUSE) - fail = TRUE; - } - break; - - case INSN: - scanbody = PATTERN (this_insn); - - /* We can only do this with insns that can use the condition - codes (and don't set them). */ - if (GET_CODE (scanbody) == SET - || GET_CODE (scanbody) == PARALLEL) - { - if (get_attr_cond (this_insn) != COND_CANUSE) - fail = TRUE; - } - /* We can't handle other insns like sequences. */ - else - fail = TRUE; - break; - - default: - break; - } - } - - if (succeed) - { - if ((!seeking_return) && (state->state == 1 || reverse)) - state->target_label = CODE_LABEL_NUMBER (label); - else if (seeking_return || state->state == 2) - { - while (this_insn && GET_CODE (PATTERN (this_insn)) == USE) - { - this_insn = next_nonnote_insn (this_insn); - - gcc_assert (!this_insn || - (GET_CODE (this_insn) != BARRIER - && GET_CODE (this_insn) != CODE_LABEL)); - } - if (!this_insn) - { - /* Oh dear! we ran off the end, give up. */ - extract_insn_cached (insn); - state->state = 0; - state->target_insn = NULL; - return; - } - state->target_insn = this_insn; - } - else - gcc_unreachable (); - - /* If REVERSE is true, ARM_CURRENT_CC needs to be inverted from - what it was. */ - if (!reverse) - { - state->cond = XEXP (SET_SRC (body), 0); - state->cc = get_arc_condition_code (XEXP (SET_SRC (body), 0)); - } - - if (reverse || then_not_else) - state->cc = ARC_INVERSE_CONDITION_CODE (state->cc); - } - - /* Restore recog_operand. Getting the attributes of other insns can - destroy this array, but final.cc assumes that it remains intact - across this call; since the insn has been recognized already we - call insn_extract direct. */ - extract_insn_cached (insn); - } -} - -/* Record that we are currently outputting label NUM with prefix PREFIX. - It it's the label we're looking for, reset the ccfsm machinery. - - Called from ASM_OUTPUT_INTERNAL_LABEL. */ - -static void -arc_ccfsm_at_label (const char *prefix, int num, struct arc_ccfsm *state) -{ - if (state->state == 3 && state->target_label == num - && !strcmp (prefix, "L")) - { - state->state = 0; - state->target_insn = NULL; - } -} - -/* We are considering a conditional branch with the condition COND. - Check if we want to conditionalize a delay slot insn, and if so modify - the ccfsm state accordingly. - REVERSE says branch will branch when the condition is false. */ -void -arc_ccfsm_record_condition (rtx cond, bool reverse, rtx_insn *jump, - struct arc_ccfsm *state) -{ - rtx_insn *seq_insn = NEXT_INSN (PREV_INSN (jump)); - if (!state) - state = &arc_ccfsm_current; - - gcc_assert (state->state == 0); - if (seq_insn != jump) - { - rtx insn = XVECEXP (PATTERN (seq_insn), 0, 1); - - if (!as_a (insn)->deleted () - && INSN_ANNULLED_BRANCH_P (jump) - && (TARGET_AT_DBR_CONDEXEC || INSN_FROM_TARGET_P (insn))) - { - state->cond = cond; - state->cc = get_arc_condition_code (cond); - if (!reverse) - arc_ccfsm_current.cc - = ARC_INVERSE_CONDITION_CODE (state->cc); - rtx pat = PATTERN (insn); - if (GET_CODE (pat) == COND_EXEC) - gcc_assert ((INSN_FROM_TARGET_P (insn) - ? ARC_INVERSE_CONDITION_CODE (state->cc) : state->cc) - == get_arc_condition_code (XEXP (pat, 0))); - else - state->state = 5; - } - } -} - -/* Update *STATE as we would when we emit INSN. */ - -static void -arc_ccfsm_post_advance (rtx_insn *insn, struct arc_ccfsm *state) -{ - enum attr_type type; - - if (LABEL_P (insn)) - arc_ccfsm_at_label ("L", CODE_LABEL_NUMBER (insn), state); - else if (JUMP_P (insn) - && GET_CODE (PATTERN (insn)) != ADDR_VEC - && GET_CODE (PATTERN (insn)) != ADDR_DIFF_VEC - && ((type = get_attr_type (insn)) == TYPE_BRANCH - || ((type == TYPE_UNCOND_BRANCH - || type == TYPE_RETURN) - && ARC_CCFSM_BRANCH_DELETED_P (state)))) - { - if (ARC_CCFSM_BRANCH_DELETED_P (state)) - ARC_CCFSM_RECORD_BRANCH_DELETED (state); - else - { - rtx src = SET_SRC (PATTERN (insn)); - arc_ccfsm_record_condition (XEXP (src, 0), XEXP (src, 1) == pc_rtx, - insn, state); - } - } - else if (arc_ccfsm_current.state == 5) - arc_ccfsm_current.state = 0; -} - -/* Return true if the current insn, which is a conditional branch, is to be - deleted. */ - -bool -arc_ccfsm_branch_deleted_p (void) -{ - return ARC_CCFSM_BRANCH_DELETED_P (&arc_ccfsm_current); -} - -/* Record a branch isn't output because subsequent insns can be - conditionalized. */ - -void -arc_ccfsm_record_branch_deleted (void) -{ - ARC_CCFSM_RECORD_BRANCH_DELETED (&arc_ccfsm_current); -} - -/* During insn output, indicate if the current insn is predicated. */ - -bool -arc_ccfsm_cond_exec_p (void) -{ - return (cfun->machine->prescan_initialized - && ARC_CCFSM_COND_EXEC_P (&arc_ccfsm_current)); -} - -/* When deciding if an insn should be output short, we want to know something - about the following insns: - - if another insn follows which we know we can output as a short insn - before an alignment-sensitive point, we can output this insn short: - the decision about the eventual alignment can be postponed. - - if a to-be-aligned label comes next, we should output this insn such - as to get / preserve 4-byte alignment. - - if a likely branch without delay slot insn, or a call with an immediately - following short insn comes next, we should out output this insn such as to - get / preserve 2 mod 4 unalignment. - - do the same for a not completely unlikely branch with a short insn - following before any other branch / label. - - in order to decide if we are actually looking at a branch, we need to - call arc_ccfsm_advance. - - in order to decide if we are looking at a short insn, we should know - if it is conditionalized. To a first order of approximation this is - the case if the state from arc_ccfsm_advance from before this insn - indicates the insn is conditionalized. However, a further refinement - could be to not conditionalize an insn if the destination register(s) - is/are dead in the non-executed case. */ /* Return non-zero if INSN should be output as a short insn. UNALIGN is zero if the current insn is aligned to a 4-byte-boundary, two otherwise. If CHECK_ATTR is greater than 0, check the iscompact attribute first. */ @@ -5707,14 +5088,6 @@ arc_final_prescan_insn (rtx_insn *insn, rtx *opvec ATTRIBUTE_UNUSED, { if (TARGET_DUMPISIZE) fprintf (asm_out_file, "\n; at %04x\n", INSN_ADDRESSES (INSN_UID (insn))); - - if (!cfun->machine->prescan_initialized) - { - /* Clear lingering state from branch shortening. */ - memset (&arc_ccfsm_current, 0, sizeof arc_ccfsm_current); - cfun->machine->prescan_initialized = 1; - } - arc_ccfsm_advance (insn, &arc_ccfsm_current); } /* Given FROM and TO register numbers, say whether this elimination is allowed. @@ -5847,8 +5220,6 @@ arc_encode_section_info (tree decl, rtx rtl, int first) static void arc_internal_label (FILE *stream, const char *prefix, unsigned long labelno) { - if (cfun) - arc_ccfsm_at_label (prefix, labelno, &arc_ccfsm_current); default_internal_label (stream, prefix, labelno); } @@ -8527,17 +7898,7 @@ arc_reorg (void) jli_call_scan (); pad_return (); -/* FIXME: should anticipate ccfsm action, generate special patterns for - to-be-deleted branches that have no delay slot and have at least the - length of the size increase forced on other insns that are conditionalized. - This can also have an insn_list inside that enumerates insns which are - not actually conditionalized because the destinations are dead in the - not-execute case. - Could also tag branches that we want to be unaligned if they get no delay - slot, or even ones that we don't want to do delay slot sheduling for - because we can unalign them. - - However, there are cases when conditional execution is only possible after +/* There are cases when conditional execution is only possible after delay slot scheduling: - If a delay slot is filled with a nocond/set insn from above, the previous @@ -8566,22 +7927,8 @@ arc_reorg (void) init_insn_lengths(); changed = 0; - if (optimize > 1 && !TARGET_NO_COND_EXEC) - { - arc_ifcvt (); - unsigned int flags = pass_data_arc_ifcvt.todo_flags_finish; - df_finish_pass ((flags & TODO_df_verify) != 0); - - if (dump_file) - { - fprintf (dump_file, ";; After if conversion:\n\n"); - print_rtl (dump_file, get_insns ()); - } - } - /* Call shorten_branches to calculate the insn lengths. */ shorten_branches (get_insns()); - cfun->machine->ccfsm_current_insn = NULL_RTX; if (!INSN_ADDRESSES_SET_P()) fatal_error (input_location, @@ -9450,8 +8797,7 @@ arc_output_libcall (const char *fname) static char buf[64]; gcc_assert (len < sizeof buf - 35); - if (TARGET_LONG_CALLS_SET - || (TARGET_MEDIUM_CALLS && arc_ccfsm_cond_exec_p ())) + if (TARGET_LONG_CALLS_SET) { if (flag_pic) sprintf (buf, "add r12,pcl,@%s@pcl\n\tjl%%!%%* [r12]", fname); @@ -9551,31 +8897,6 @@ arc_adjust_insn_length (rtx_insn *insn, int len, bool) return len; } -/* Return a copy of COND from *STATEP, inverted if that is indicated by the - CC field of *STATEP. */ - -static rtx -arc_get_ccfsm_cond (struct arc_ccfsm *statep, bool reverse) -{ - rtx cond = statep->cond; - int raw_cc = get_arc_condition_code (cond); - if (reverse) - raw_cc = ARC_INVERSE_CONDITION_CODE (raw_cc); - - if (statep->cc == raw_cc) - return copy_rtx (cond); - - gcc_assert (ARC_INVERSE_CONDITION_CODE (raw_cc) == statep->cc); - - machine_mode ccm = GET_MODE (XEXP (cond, 0)); - enum rtx_code code = reverse_condition (GET_CODE (cond)); - if (code == UNKNOWN || ccm == CC_FP_GTmode || ccm == CC_FP_GEmode) - code = reverse_condition_maybe_unordered (GET_CODE (cond)); - - return gen_rtx_fmt_ee (code, GET_MODE (cond), - copy_rtx (XEXP (cond, 0)), copy_rtx (XEXP (cond, 1))); -} - /* Return version of PAT conditionalized with COND, which is part of INSN. ANNULLED indicates if INSN is an annulled delay-slot insn. Register further changes if necessary. */ @@ -9620,125 +8941,6 @@ conditionalize_nonjump (rtx pat, rtx cond, rtx insn, bool annulled) return pat; } -/* Use the ccfsm machinery to do if conversion. */ - -static unsigned -arc_ifcvt (void) -{ - struct arc_ccfsm *statep = &cfun->machine->ccfsm_current; - - memset (statep, 0, sizeof *statep); - for (rtx_insn *insn = get_insns (); insn; insn = next_insn (insn)) - { - arc_ccfsm_advance (insn, statep); - - switch (statep->state) - { - case 0: - break; - case 1: case 2: - { - /* Deleted branch. */ - arc_ccfsm_post_advance (insn, statep); - gcc_assert (!IN_RANGE (statep->state, 1, 2)); - rtx_insn *seq = NEXT_INSN (PREV_INSN (insn)); - if (GET_CODE (PATTERN (seq)) == SEQUENCE) - { - rtx slot = XVECEXP (PATTERN (seq), 0, 1); - rtx pat = PATTERN (slot); - if (INSN_ANNULLED_BRANCH_P (insn)) - { - rtx cond - = arc_get_ccfsm_cond (statep, INSN_FROM_TARGET_P (slot)); - pat = gen_rtx_COND_EXEC (VOIDmode, cond, pat); - } - if (!validate_change (seq, &PATTERN (seq), pat, 0)) - gcc_unreachable (); - PUT_CODE (slot, NOTE); - NOTE_KIND (slot) = NOTE_INSN_DELETED; - } - else - { - set_insn_deleted (insn); - } - continue; - } - case 3: - if (LABEL_P (insn) - && statep->target_label == CODE_LABEL_NUMBER (insn)) - { - arc_ccfsm_post_advance (insn, statep); - if (--LABEL_NUSES (insn) == 0) - delete_insn (insn); - continue; - } - /* Fall through. */ - case 4: case 5: - if (!NONDEBUG_INSN_P (insn)) - break; - - /* Conditionalized insn. */ - - rtx_insn *prev, *pprev; - rtx *patp, pat, cond; - bool annulled; annulled = false; - - /* If this is a delay slot insn in a non-annulled branch, - don't conditionalize it. N.B., this should be fine for - conditional return too. However, don't do this for - unconditional branches, as these would be encountered when - processing an 'else' part. */ - prev = PREV_INSN (insn); - pprev = PREV_INSN (prev); - if (pprev && NEXT_INSN (NEXT_INSN (pprev)) == NEXT_INSN (insn) - && JUMP_P (prev) && get_attr_cond (prev) == COND_USE) - { - if (!INSN_ANNULLED_BRANCH_P (prev)) - break; - annulled = true; - } - - patp = &PATTERN (insn); - pat = *patp; - cond = arc_get_ccfsm_cond (statep, INSN_FROM_TARGET_P (insn)); - if (NONJUMP_INSN_P (insn) || CALL_P (insn)) - { - /* ??? don't conditionalize if all side effects are dead - in the not-execute case. */ - - pat = conditionalize_nonjump (pat, cond, insn, annulled); - } - else if (simplejump_p (insn)) - { - patp = &SET_SRC (pat); - pat = gen_rtx_IF_THEN_ELSE (VOIDmode, cond, *patp, pc_rtx); - } - else if (JUMP_P (insn) && ANY_RETURN_P (PATTERN (insn))) - { - pat = gen_rtx_IF_THEN_ELSE (VOIDmode, cond, pat, pc_rtx); - pat = gen_rtx_SET (pc_rtx, pat); - } - else - gcc_unreachable (); - validate_change (insn, patp, pat, 1); - if (!apply_change_group ()) - gcc_unreachable (); - if (JUMP_P (insn)) - { - rtx_insn *next = next_nonnote_insn (insn); - if (GET_CODE (next) == BARRIER) - delete_insn (next); - if (statep->state == 3) - continue; - } - break; - default: - gcc_unreachable (); - } - arc_ccfsm_post_advance (insn, statep); - } - return 0; -} /* Find annulled delay insns and convert them to use the appropriate predicate. This allows branch shortening to size up these insns properly. */ diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md index 945cc4042d1..cedb9517bb0 100644 --- a/gcc/config/arc/arc.md +++ b/gcc/config/arc/arc.md @@ -547,16 +547,6 @@ (define_attr "in_sfunc_delay_slot" "false,true" (const_string "false")] (const_string "true"))) -;; Instructions that we can put into a delay slot and conditionalize. -(define_attr "cond_delay_insn" "no,yes" - (cond [(eq_attr "cond" "!canuse") (const_string "no") - (eq_attr "type" "call,branch,uncond_branch,jump,brcc") - (const_string "no") - (match_test "find_reg_note (insn, REG_SAVE_NOTE, GEN_INT (2))") - (const_string "no") - (eq_attr "length" "2,4") (const_string "yes")] - (const_string "no"))) - (define_attr "in_ret_delay_slot" "no,yes" (cond [(eq_attr "in_delay_slot" "false") (const_string "no") @@ -565,19 +555,6 @@ (define_attr "in_ret_delay_slot" "no,yes" (const_string "no")] (const_string "yes"))) -(define_attr "cond_ret_delay_insn" "no,yes" - (cond [(eq_attr "in_ret_delay_slot" "no") (const_string "no") - (eq_attr "cond_delay_insn" "no") (const_string "no")] - (const_string "yes"))) - -(define_attr "annul_ret_delay_insn" "no,yes" - (cond [(eq_attr "cond_ret_delay_insn" "yes") (const_string "yes") - (match_test "TARGET_AT_DBR_CONDEXEC") (const_string "no") - (eq_attr "type" "!call,branch,uncond_branch,jump,brcc,return,sfunc") - (const_string "yes")] - (const_string "no"))) - - ;; Delay slot definition for ARCompact ISA ;; ??? FIXME: ;; When outputting an annul-true insn elegible for cond-exec @@ -590,14 +567,7 @@ (define_delay (eq_attr "type" "call") (eq_attr "in_call_delay_slot" "true") (nil)]) -(define_delay (and (match_test "!TARGET_AT_DBR_CONDEXEC") - (eq_attr "type" "brcc")) - [(eq_attr "in_delay_slot" "true") - (eq_attr "in_delay_slot" "true") - (nil)]) - -(define_delay (and (match_test "TARGET_AT_DBR_CONDEXEC") - (eq_attr "type" "brcc")) +(define_delay (eq_attr "type" "brcc") [(eq_attr "in_delay_slot" "true") (nil) (nil)]) @@ -605,39 +575,26 @@ (define_delay (and (match_test "TARGET_AT_DBR_CONDEXEC") (define_delay (eq_attr "type" "return") [(eq_attr "in_ret_delay_slot" "yes") - (eq_attr "annul_ret_delay_insn" "yes") - (eq_attr "cond_ret_delay_insn" "yes")]) + (nil) + (nil)]) (define_delay (eq_attr "type" "loop_end") [(eq_attr "in_delay_slot" "true") - (eq_attr "in_delay_slot" "true") + (nil) (nil)]) -;; For ARC600, unexposing the delay sloy incurs a penalty also in the -;; non-taken case, so the only meaningful way to have an annull-true +;; The only meaningful way to have an annull-true ;; filled delay slot is to conditionalize the delay slot insn. -(define_delay (and (match_test "TARGET_AT_DBR_CONDEXEC") - (eq_attr "type" "branch,uncond_branch,jump") - (match_test "!optimize_size")) - [(eq_attr "in_delay_slot" "true") - (eq_attr "cond_delay_insn" "yes") - (eq_attr "cond_delay_insn" "yes")]) - -;; For ARC700, anything goes for annulled-true insns, since there is no -;; penalty for the unexposed delay slot when the branch is not taken, -;; however, we must avoid things that have a delay slot themselvese to -;; avoid confusing gcc. -(define_delay (and (match_test "!TARGET_AT_DBR_CONDEXEC") - (eq_attr "type" "branch,uncond_branch,jump") +(define_delay (and (eq_attr "type" "branch,uncond_branch,jump") (match_test "!optimize_size")) [(eq_attr "in_delay_slot" "true") - (eq_attr "type" "!call,branch,uncond_branch,jump,brcc,return,sfunc") - (eq_attr "cond_delay_insn" "yes")]) + (nil) + (nil)]) ;; -mlongcall -fpic sfuncs use r12 to load the function address (define_delay (eq_attr "type" "sfunc") [(eq_attr "in_sfunc_delay_slot" "true") - (eq_attr "in_sfunc_delay_slot" "true") + (nil) (nil)]) ;; ??? need to use a working strategy for canuse_limm: ;; - either canuse_limm is not eligible for delay slots, and has no @@ -3448,18 +3405,22 @@ (define_insn "*ashrsi3_insn" (set_attr "cond" "canuse,nocond,canuse,canuse,nocond,nocond")]) (define_insn "*lshrsi3_insn" - [(set (match_operand:SI 0 "dest_reg_operand" "=q,q, q, r, r, r") - (lshiftrt:SI (match_operand:SI 1 "nonmemory_operand" "!0,q, 0, 0, r,rCal") - (match_operand:SI 2 "nonmemory_operand" "N,N,qM,rL,rL,rCal")))] + [(set (match_operand:SI 0 "dest_reg_operand" "=q, q, r, r, r") + (lshiftrt:SI (match_operand:SI 1 "nonmemory_operand" "q, 0, 0, r,rCal") + (match_operand:SI 2 "nonmemory_operand" "N,qM,rL,rL,rCal")))] "TARGET_BARREL_SHIFTER && (register_operand (operands[1], SImode) || register_operand (operands[2], SImode))" - "*return (which_alternative <= 1 && !arc_ccfsm_cond_exec_p () - ? \"lsr%?\\t%0,%1\" : \"lsr%?\\t%0,%1,%2\");" + "@ + lsr_s\\t%0,%1 + lsr_s\\t%0,%1,%2 + lsr%?\\t%0,%1,%2 + lsr%?\\t%0,%1,%2 + lsr%?\\t%0,%1,%2" [(set_attr "type" "shift") - (set_attr "iscompact" "maybe,maybe,maybe,false,false,false") - (set_attr "predicable" "no,no,no,yes,no,no") - (set_attr "cond" "canuse,nocond,canuse,canuse,nocond,nocond")]) + (set_attr "iscompact" "maybe,maybe,false,false,false") + (set_attr "predicable" "no,no,yes,no,no") + (set_attr "cond" "nocond,canuse,canuse,nocond,nocond")]) (define_insn_and_split "*ashlsi3_nobs" [(set (match_operand:SI 0 "dest_reg_operand") @@ -3925,19 +3886,10 @@ (define_insn "*branch_insn" "" "* { - if (arc_ccfsm_branch_deleted_p ()) - { - arc_ccfsm_record_branch_deleted (); - return \"; branch deleted, next insns conditionalized\"; - } - else - { - arc_ccfsm_record_condition (operands[1], false, insn, 0); if (get_attr_length (insn) == 2) return \"b%d1%?\\t%l0\"; else - return \"b%d1%#\\t%l0\"; - } + return \"b%d1%*\\t%l0\"; }" [(set_attr "type" "branch") (set @@ -3973,22 +3925,7 @@ (define_insn "*rev_branch_insn" (pc) (label_ref (match_operand 0 "" ""))))] "REVERSIBLE_CC_MODE (GET_MODE (XEXP (operands[1], 0)))" - "* -{ - if (arc_ccfsm_branch_deleted_p ()) - { - arc_ccfsm_record_branch_deleted (); - return \"; branch deleted, next insns conditionalized\"; - } - else - { - arc_ccfsm_record_condition (operands[1], true, insn, 0); - if (get_attr_length (insn) == 2) - return \"b%D1%?\\t%l0\"; - else - return \"b%D1%#\\t%l0\"; - } -}" + "b%D1%?\\t%l0" [(set_attr "type" "branch") (set (attr "length") @@ -4946,12 +4883,7 @@ (define_insn "p_return_i" [(reg CC_REG) (const_int 0)]) (simple_return) (pc)))] "reload_completed" -{ - output_asm_insn (\"j%d0%!%#\\t[blink]\", operands); - /* record the condition in case there is a delay insn. */ - arc_ccfsm_record_condition (operands[0], false, insn, 0); - return \"\"; -} + "j%d0%!%*\\t[blink]" [(set_attr "type" "return") (set_attr "cond" "use") (set_attr "iscompact" "maybe" ) @@ -5175,7 +5107,7 @@ (define_insn_and_split "dbnz" (clobber (match_scratch:SI 2 "=X,r"))] "TARGET_DBNZ" "@ - dbnz%#\\t%0,%l1 + dbnz%*\\t%0,%l1 #" "TARGET_DBNZ && reload_completed && memory_operand (operands[0], SImode)" [(set (match_dup 2) (match_dup 0)) From patchwork Thu Oct 5 11:43:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Zissulescu Ianculescu X-Patchwork-Id: 148681 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2016:b0:403:3b70:6f57 with SMTP id fe22csp233397vqb; Thu, 5 Oct 2023 04:46:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBDzi/q0L+jtksbUzcW/J+eCG51d4xBbgMEp9cvJVCFnLR+iBYnHUCcZwzTyza9vn7xPil X-Received: by 2002:a17:907:1dc2:b0:9a6:2a0:6391 with SMTP id og2-20020a1709071dc200b009a602a06391mr4046031ejc.14.1696506401051; Thu, 05 Oct 2023 04:46:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696506401; cv=none; d=google.com; s=arc-20160816; b=SAko2gMwgCSb9GpI9sO0saPaENVOnHn2nskNqhQp2Z97Ze6c6Eh11/GEB9jeRvXG/C i9kfxfXi+qpsqbkhp2y1fFZ7QGXzGLOSmmD+axuK+dWamLcsEeS3tNEy7Q4D6XAoRHmO ADY9uqtY5FM7ViFpE73usTG1QdRnRUXyxhcx8hz03e1b7C+BpmC5543sPiCuopCaAjWF bx3nOL1G31BVK2S3XEm/e+BeBWsZ+fxpYKSBLf7SEv7xZdnRSdCvgZPwas0t82I/pEOF DkYtG5M+RYnhsZgvjH5jZoE+FTX+v4+BizujVhuYuh5iA9R3pOYjKviLVptr2/DVtaxR IAIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dmarc-filter:delivered-to; bh=E8yuH1eccNs4GbLqDOwxdJlt0PKtN4Fjegp18UKqYRE=; fh=7jtO1LQ2AGfJSFta5OEKAjdQtDhhgJZg7nT12/P8gFI=; b=bPi15SugF4xFiFVSCIo1KoAewfSO00teFQ0SELcX2StmjmWI4mnmHHwoHb5g7qqT1c Nv1bYuDpK/y6/xSqRakxpb71/YsPOkWzxwLV6c707hk7tMr03vad/c79uZOXD3Y7TIli kd31uguEgwsLoc0MWlkv6SVPcPX/lXel1sjMSmpF0pkscVPbIlkl8YqZJaGEzC4VZ64f pXj3urHV/V2zePcZrbEJbgt2w5fJnbIdD7PMNlWpNVs7ekhi2bRHNzd2b4ltG90b6Ifg a5pTiTuvlfNSyBwVzzT4BD+aFwJNSPlmDKNpuh+MqipdiIBWjg0vGjHpgjnzlbzKn+h1 742Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RWBaQvN+; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id l8-20020a170906078800b00993d5cdf483si664786ejc.807.2023.10.05.04.46.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:46:41 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RWBaQvN+; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0D47C38618B0 for ; Thu, 5 Oct 2023 11:44:52 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id AD09C385C6D4 for ; Thu, 5 Oct 2023 11:43:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AD09C385C6D4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-323168869daso883070f8f.2 for ; Thu, 05 Oct 2023 04:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696506232; x=1697111032; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E8yuH1eccNs4GbLqDOwxdJlt0PKtN4Fjegp18UKqYRE=; b=RWBaQvN+q6AYH+UNuy77ivDUQZcFXlb/iYnRT2p2aNA7MbYRmhd14cg26cf56uYfUa j4x7/AHTGz2QC1EoMdaS19RV1A1ffjZRPXhG85jAalHw2GQPToNueLRrCUzaQik+X0Bq LvAN9hExUgpgFpGPU4LeDSD8XTSRA20S+YfFauN1gYWhKnMkY54petMPsqsMy9wpoTc/ e9M4iQYELqGyPqk0hbXEjJCiTdm4667PopV8Gp6wy7HjTfAHAq+2AxKaqOYA8XzWYvdz yLcddb+mY70wyQN+wV/POwKLdphuqXshgrRkq6A1SF5g94TKI5Jgq7xRVdZQDj5gb+hB aZcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696506232; x=1697111032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E8yuH1eccNs4GbLqDOwxdJlt0PKtN4Fjegp18UKqYRE=; b=R2IRcpvWnaN87D+ohKAL17KI4ca3gVlf28c/N8XBR7tzFrpPChSoLJEZHCY7pxKKIP YLqYPgNAiqpVhlwv50LKLXSWwZLfUYh43XomdO75MmbiKml91kxnbJP742AZCHpL0JeW SIV3c5w98Qb1bnkIPVnFc6MkkO8NO48qTVbvPWjS5vqkMx0KLmoddJDQ0tS++yNWClxp 8lU6JRdLb4/w+i01Zn3lfRSaFAOOn4quHpBQw4NE6KH4VjGVIwthHCh+cSBcoLpVp791 O//Y2LRmPlaQkw0nuyLOKDR8Mg/cU742m5JdzUVYAI4wYpnL2rDhvAzxOBR7e8nnMa2T nefA== X-Gm-Message-State: AOJu0YxChSDZ5xUwJ66U4BEcbe4J/Nlj98fZ29PQgAYGNbAZQKxdzWRw Bc5nfFmbs0wuoB6A17/I0ef3NE2NfjE= X-Received: by 2002:adf:f443:0:b0:316:f3cf:6f12 with SMTP id f3-20020adff443000000b00316f3cf6f12mr4322975wrp.48.1696506231900; Thu, 05 Oct 2023 04:43:51 -0700 (PDT) Received: from fatty.nomansland ([193.187.151.25]) by smtp.gmail.com with ESMTPSA id f22-20020a5d58f6000000b0031423a8f4f7sm1605821wrd.56.2023.10.05.04.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:43:51 -0700 (PDT) From: Claudiu Zissulescu To: gcc-patches@gcc.gnu.org Cc: fbedard@synopsys.com Subject: [committed 5/5] arc: Update tests predicates when using linux toolchain. Date: Thu, 5 Oct 2023 14:43:45 +0300 Message-Id: <20231005114345.1707504-5-claziss@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231005114345.1707504-1-claziss@gmail.com> References: <20231005114345.1707504-1-claziss@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778915895939059904 X-GMAIL-MSGID: 1778915895939059904 gcc/testsuite: * gcc.target/arc/enter-dw2-1.c: Remove tests when using linux build. * gcc.target/arc/tls-ld.c: Update test. * gcc.target/arc/tls-le.c: Likewise. Signed-off-by: Claudiu Zissulescu --- gcc/testsuite/gcc.target/arc/enter-dw2-1.c | 18 +++++++++--------- gcc/testsuite/gcc.target/arc/tls-ld.c | 3 +-- gcc/testsuite/gcc.target/arc/tls-le.c | 2 +- 3 files changed, 11 insertions(+), 12 deletions(-) diff --git a/gcc/testsuite/gcc.target/arc/enter-dw2-1.c b/gcc/testsuite/gcc.target/arc/enter-dw2-1.c index 25d03562198..653ea7231be 100644 --- a/gcc/testsuite/gcc.target/arc/enter-dw2-1.c +++ b/gcc/testsuite/gcc.target/arc/enter-dw2-1.c @@ -16,13 +16,13 @@ void foo (void) } -/* { dg-final { scan-assembler-times "enter_s" 1 } } */ +/* { dg-final { scan-assembler-times "enter_s" 1 {xfail *-linux-* } } } */ /* { dg-final { scan-assembler-times "\.cfi_def_cfa_offset 32" 1 } } */ -/* { dg-final { scan-assembler-times "\.cfi_offset 31, -32" 1 } } */ -/* { dg-final { scan-assembler-times "\.cfi_offset 13, -28" 1 } } */ -/* { dg-final { scan-assembler-times "\.cfi_offset 14, -24" 1 } } */ -/* { dg-final { scan-assembler-times "\.cfi_offset 15, -20" 1 } } */ -/* { dg-final { scan-assembler-times "\.cfi_offset 16, -16" 1 } } */ -/* { dg-final { scan-assembler-times "\.cfi_offset 17, -12" 1 } } */ -/* { dg-final { scan-assembler-times "\.cfi_offset 18, -8" 1 } } */ -/* { dg-final { scan-assembler-times "\.cfi_offset 19, -4" 1 } } */ +/* { dg-final { scan-assembler-times "\.cfi_offset 31, -32" 1 {xfail *-linux-* } } } */ +/* { dg-final { scan-assembler-times "\.cfi_offset 13, -28" 1 {xfail *-linux-* } } } */ +/* { dg-final { scan-assembler-times "\.cfi_offset 14, -24" 1 {xfail *-linux-* } } } */ +/* { dg-final { scan-assembler-times "\.cfi_offset 15, -20" 1 {xfail *-linux-* } } } */ +/* { dg-final { scan-assembler-times "\.cfi_offset 16, -16" 1 {xfail *-linux-* } } } */ +/* { dg-final { scan-assembler-times "\.cfi_offset 17, -12" 1 {xfail *-linux-* } } } */ +/* { dg-final { scan-assembler-times "\.cfi_offset 18, -8" 1 {xfail *-linux-* } } } */ +/* { dg-final { scan-assembler-times "\.cfi_offset 19, -4" 1 {xfail *-linux-* } } } */ diff --git a/gcc/testsuite/gcc.target/arc/tls-ld.c b/gcc/testsuite/gcc.target/arc/tls-ld.c index 68ab9bf809c..47c71f5d273 100644 --- a/gcc/testsuite/gcc.target/arc/tls-ld.c +++ b/gcc/testsuite/gcc.target/arc/tls-ld.c @@ -13,6 +13,5 @@ int *ae2 (void) return &e2; } -/* { dg-final { scan-assembler "add\\s+r0,pcl,@.tbss@tlsgd" } } */ +/* { dg-final { scan-assembler "add\\s+r0,pcl,@e2@tlsgd" } } */ /* { dg-final { scan-assembler "bl\\s+@__tls_get_addr@plt" } } */ -/* { dg-final { scan-assembler "add_s\\s+r0,r0,@e2@dtpoff" } } */ diff --git a/gcc/testsuite/gcc.target/arc/tls-le.c b/gcc/testsuite/gcc.target/arc/tls-le.c index ae3089b5070..6deca1a133d 100644 --- a/gcc/testsuite/gcc.target/arc/tls-le.c +++ b/gcc/testsuite/gcc.target/arc/tls-le.c @@ -13,4 +13,4 @@ int *ae2 (void) return &e2; } -/* { dg-final { scan-assembler "add r0,r25,@e2@tpoff" } } */ +/* { dg-final { scan-assembler "add\\sr0,r25,@e2@tpoff" } } */