From patchwork Tue Oct 3 00:34:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 147588 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1775442vqb; Mon, 2 Oct 2023 17:34:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzuFrtUmgruvVrZQ7R7VAA4SMR32mt/tpB4+6Fn9v8wQ8Llm9qKTT1nauF6Wm+ZjaPlEnO X-Received: by 2002:a05:6359:5d15:b0:150:8ba9:55 with SMTP id ps21-20020a0563595d1500b001508ba90055mr6766530rwb.8.1696293284603; Mon, 02 Oct 2023 17:34:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696293284; cv=none; d=google.com; s=arc-20160816; b=WhD6qguiFX4z5nu3wRejIjjqHTePieFqxLrohe/r2END/iHoI58fd22dHY4i3XMX93 NdO3yefX12p9Wch3xnwWkzSVWKK3w4bhrJm/fn2ZbpoEpSP8ZfFXUO1MsWA07xLgSPD4 AqZVMiFfwyFRaFEwO50c4jYv8EOBt1sJMTYwcG9hRDVxPhsZYLdF1tDbVE7/62W/jcQS tweZS86W6piPzDLqgvBqqT7GMd+to7acpnmW7hv7b26p3eA35FXhaLlNy6tGI56Gdswp 1q2xKh2+gEf+Jx1JKhiyBJoFnvIIQHSZZfkQmzUm1WsR3lM3nvFaAA/WYFQUgm4YTIte kUzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=46Gu5AeGEBG3UAx8tqJHnnJONEDjYZ4KhZYReyw4USQ=; fh=YJV7s35UDfTu410NGMNaxLgUC83Mipoa1f3x561mYKo=; b=Uxg8qAPs4DTg75Npt/ARcv+sJKJ6Ioes6404eDhONOj1ITB3cOyjS3qWJSousgoIdO 47raLeearcIufSghAqcR/NtxG2+/JCVc2ei2GjozJpnQb6dLzLbkSclXJhvXvmq477O/ H1cZaHJ2qwgGV8MoLqrfXm9hcgmGXUr1fm9Z1sPpEpWmAJBrXm29ioueJeECB3XIiEG1 mD6QpzBfzgERg/pVLcNv5Mq7+mX6JyrM+WsdO9EUc1QDcv+SNqT1H2HgS6gkXhXmwkYU TSuNvMI++0VdjIL/qlfzlLVb402AXB8cbu+awet7svk3aB2d525bmPgMneIuMshwnftV mXug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="isx/OnyS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id w20-20020a63af14000000b005526bd0c526si157077pge.641.2023.10.02.17.34.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:34:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="isx/OnyS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 9B371824694A; Mon, 2 Oct 2023 17:34:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238205AbjJCAeg (ORCPT + 18 others); Mon, 2 Oct 2023 20:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229908AbjJCAef (ORCPT ); Mon, 2 Oct 2023 20:34:35 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E08D7A1 for ; Mon, 2 Oct 2023 17:34:32 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-694ed84c981so261992b3a.3 for ; Mon, 02 Oct 2023 17:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696293272; x=1696898072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=46Gu5AeGEBG3UAx8tqJHnnJONEDjYZ4KhZYReyw4USQ=; b=isx/OnyS4noW4BuudGRYLVM+u086Ph44GReOCp/Y0qQ46Ez+AZ8paNJMArZ3a+nOgF CYwVw6WumUPY2wcdm9OQGxghFjtUY7QyGN+wmyqcPcWRrMJRVmhrR1iALsyBOi7Sr8kK Be1ouFFRcHVQrFmTqXXLFuZHRBKC8lW0L3QX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696293272; x=1696898072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=46Gu5AeGEBG3UAx8tqJHnnJONEDjYZ4KhZYReyw4USQ=; b=MxgAYE95keRtyLBXYdrr5jO8J258oCJR1yc4uAC46jovzKtfvfpdediLpAnNTYfNLh NDU6MQAU140dQaMBp9uQRyA47yCN+pwer4jY2BU9TMvZAFxsxNrICqiVxBqa9f6TWAFE GVFYHL3Moe96lHzLX8kAr9OC58RpdIYVlRGPBfPly4ba7r8OPnB/yLCkL50HVZ/5i5Ou yX/ap3BwlF3GgWiUTj3hTydF5qB8z3tRAR00aOwHLSFmjmsQ0o3BPwFw8FEZlamPG170 OxL6RHEXS8GM9D5p2BCRdnw/YO93ByuZRqtKtVZcQUD78KGRRlbAYHSHvHuItibLoB8F CRjQ== X-Gm-Message-State: AOJu0Yx47hZ9hFvxxM0fB22wyoTuLXqebv3qKWfwAFrNSbLEchWDjiBq b5+9ZqioEzCTyUoYO51V+wWWjQ== X-Received: by 2002:a05:6a20:5655:b0:133:b3a9:90d with SMTP id is21-20020a056a20565500b00133b3a9090dmr9920050pzc.36.1696293272344; Mon, 02 Oct 2023 17:34:32 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:11a:201:f676:8db:8677:aefe]) by smtp.gmail.com with ESMTPSA id bm2-20020a056a00320200b0068a13b0b300sm101368pfb.11.2023.10.02.17.34.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:34:31 -0700 (PDT) From: Stephen Boyd To: Benson Leung , Tzung-Bi Shih Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, Prashant Malani Subject: [PATCH 1/4] platform/chrome: cros_ec_typec: Use semi-colons instead of commas Date: Mon, 2 Oct 2023 17:34:25 -0700 Message-ID: <20231003003429.1378109-2-swboyd@chromium.org> X-Mailer: git-send-email 2.42.0.582.g8ccd20d70d-goog In-Reply-To: <20231003003429.1378109-1-swboyd@chromium.org> References: <20231003003429.1378109-1-swboyd@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 17:34:43 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778692427234365060 X-GMAIL-MSGID: 1778692427234365060 These should be semi-colons so that one statement is per line. Cc: Prashant Malani Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_ec_typec.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index d0b4d3fc40ed..82e7d08b52c7 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -271,9 +271,9 @@ static int cros_typec_register_port_altmodes(struct cros_typec_data *typec, struct typec_altmode *amode; /* All PD capable CrOS devices are assumed to support DP altmode. */ - desc.svid = USB_TYPEC_DP_SID, - desc.mode = USB_TYPEC_DP_MODE, - desc.vdo = DP_PORT_VDO, + desc.svid = USB_TYPEC_DP_SID; + desc.mode = USB_TYPEC_DP_MODE; + desc.vdo = DP_PORT_VDO; amode = typec_port_register_altmode(port->port, &desc); if (IS_ERR(amode)) return PTR_ERR(amode); @@ -287,8 +287,8 @@ static int cros_typec_register_port_altmodes(struct cros_typec_data *typec, * here for now. */ memset(&desc, 0, sizeof(desc)); - desc.svid = USB_TYPEC_TBT_SID, - desc.mode = TYPEC_ANY_MODE, + desc.svid = USB_TYPEC_TBT_SID; + desc.mode = TYPEC_ANY_MODE; amode = typec_port_register_altmode(port->port, &desc); if (IS_ERR(amode)) return PTR_ERR(amode); From patchwork Tue Oct 3 00:34:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 147589 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1775460vqb; Mon, 2 Oct 2023 17:34:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFy1trxRG75UzhfSBiQZ14cWjChYfJk9K/b5Y/SZlkV3aS+KJsH5f5EVWNqgcFg3xDGb4JP X-Received: by 2002:a05:6e02:1c22:b0:351:4b68:ec3d with SMTP id m2-20020a056e021c2200b003514b68ec3dmr15565626ilh.16.1696293286605; Mon, 02 Oct 2023 17:34:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696293286; cv=none; d=google.com; s=arc-20160816; b=bSYN5mC91geJiM4/f8en/WwwRcbSCJ5LatUdincf0V30ZKLr4DaZwCadKmc+9iIybQ s/6o/2Hznc6dPCfs7GcovMuih/D4Yxw9GMjkqy53sB2Aswd1Dfz1HItLoToroZ/nEkBg hj9WARWSf9+5rFJkFyqu6WEf9i7pfPVDxgmN2nweprXqPTwDpsiJGEORPm0PuQJwhQoZ 4DcE4CleaiYDMwqluJzbCVgFyc6+wyM4S+ytUdyb0td+QPQ88F+CNh8A0Fs+5dT8WEhP P2uukLof2wYN+Djsyl20t1Q793PNAdAEiummoKo4wSI7cgTHKmqBJOO/XfGeXZ+QAgAa /RMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Kv8GuqsvKsi/EUYP1j3AWhIWAgjVOKJZXtPzqkrmwyA=; fh=YJV7s35UDfTu410NGMNaxLgUC83Mipoa1f3x561mYKo=; b=gNLnIe6qaMdQa63x/pv3xjomEtTw0GXxBEsw+ocS9VTQa1cjXGW7p2DZCs/MQMPKVE kfIURz9eHdZEMVf7h9KZqEMhcjquay1qGsqs16+ECrCdG0yuJQBWJ7EfXk1StO0Up9LS oByhwgLZ7D/URhmTMQZU9jlXbaTDnXUpUueIXAifVmaWqQpx++EjF3z1DKuy32U5QAZp 1FRgSI7R5nR7TdICHAJUeyoUay9hplzvyKlcqbX0fDPkJXhbfdHcu0et3YKF45x687mQ eWwlMIMmXFiGJ5Zj0zd/CFg/zLRkTFJz1hDzM2pAk38WAZHHbJTM4yT2cb8Dd2N+2Cji qjqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="XQ8y/wTb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id v135-20020a63618d000000b005638dc9751csi200062pgb.0.2023.10.02.17.34.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:34:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="XQ8y/wTb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id CB304824695B; Mon, 2 Oct 2023 17:34:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238636AbjJCAei (ORCPT + 18 others); Mon, 2 Oct 2023 20:34:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbjJCAeg (ORCPT ); Mon, 2 Oct 2023 20:34:36 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF6FAA9 for ; Mon, 2 Oct 2023 17:34:33 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6910ea9cca1so246934b3a.1 for ; Mon, 02 Oct 2023 17:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696293273; x=1696898073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kv8GuqsvKsi/EUYP1j3AWhIWAgjVOKJZXtPzqkrmwyA=; b=XQ8y/wTb0K0shlaXqdpYjnZ03//WneqKJtXbDx7WJwCwflpqSoeplLqpul6Y7xRLlJ l2dvhUklhfHU+BsuQTiPEgOj7WXOF5q5lz3TxbDSLovYzINWyFPp0xbEHACkO/oVtEzo tvbr8pl1gQ14jKfdflhtWbtXzZgO5iV3AO6i4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696293273; x=1696898073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kv8GuqsvKsi/EUYP1j3AWhIWAgjVOKJZXtPzqkrmwyA=; b=Ha1TRKGkZjbEcWX/0lyJ89Rf6/WhKG4BUz0lK9j0uVum3HhCnedBA9fyDBsgm9LozX 71EmedsBXp8kuclI8X4Xf3+23iPfWFHTeLLOuJ3X9wZcSUtwfrV2Hys6cFiHQoAEsJlz 0NF/8PhKWNxXSWg2SnoOILXKeKGy482tPxWPYGN4zNwGMIDKnmMDjkVWMzM7sdhZLaFz NE34oGM0KZktN0lgNV4ue84Kp5uJ87kNsjJcKB5TuGTplyxJiDcedo0GLq9YUrWSmLSH BE1ZXDIKwJGsUiEe7n3qs6HEaskTzoKxsUZsanu9VCvlHRHZEK5Jrbm5QfzFUEno7TCv dAew== X-Gm-Message-State: AOJu0Yy9gOVhlhbc4x4n1yGIUlpfK7ICcQUJvMRvpt1t7kIUn0PD8toW iFH2BC46Vi3k0squoXaKLzNzjg== X-Received: by 2002:a05:6a00:392a:b0:693:42d2:cde0 with SMTP id fh42-20020a056a00392a00b0069342d2cde0mr11023259pfb.22.1696293273499; Mon, 02 Oct 2023 17:34:33 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:11a:201:f676:8db:8677:aefe]) by smtp.gmail.com with ESMTPSA id bm2-20020a056a00320200b0068a13b0b300sm101368pfb.11.2023.10.02.17.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:34:33 -0700 (PDT) From: Stephen Boyd To: Benson Leung , Tzung-Bi Shih Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, Prashant Malani Subject: [PATCH 2/4] platform/chrome: cros_ec_typec: Use dev_err_probe() more Date: Mon, 2 Oct 2023 17:34:26 -0700 Message-ID: <20231003003429.1378109-3-swboyd@chromium.org> X-Mailer: git-send-email 2.42.0.582.g8ccd20d70d-goog In-Reply-To: <20231003003429.1378109-1-swboyd@chromium.org> References: <20231003003429.1378109-1-swboyd@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 17:34:45 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778692429135249426 X-GMAIL-MSGID: 1778692429135249426 There's some debug prints here that can be upgraded to dev_err_probe() so that we don't have to fish out the error messages when a true error happens. If they're simply probe defers then the kernel will keep silent but if they're true errors we'll see the errors in the logs. Cc: Prashant Malani Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_ec_typec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index 82e7d08b52c7..67000e4a8082 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -80,28 +80,28 @@ static int cros_typec_get_switch_handles(struct cros_typec_port *port, port->mux = fwnode_typec_mux_get(fwnode); if (IS_ERR(port->mux)) { ret = PTR_ERR(port->mux); - dev_dbg(dev, "Mux handle not found: %d.\n", ret); + dev_err_probe(dev, ret, "Mux handle not found\n"); goto mux_err; } port->retimer = fwnode_typec_retimer_get(fwnode); if (IS_ERR(port->retimer)) { ret = PTR_ERR(port->retimer); - dev_dbg(dev, "Retimer handle not found: %d.\n", ret); + dev_err_probe(dev, ret, "Retimer handle not found\n"); goto retimer_sw_err; } port->ori_sw = fwnode_typec_switch_get(fwnode); if (IS_ERR(port->ori_sw)) { ret = PTR_ERR(port->ori_sw); - dev_dbg(dev, "Orientation switch handle not found: %d\n", ret); + dev_err_probe(dev, ret, "Orientation switch handle not found\n"); goto ori_sw_err; } port->role_sw = fwnode_usb_role_switch_get(fwnode); if (IS_ERR(port->role_sw)) { ret = PTR_ERR(port->role_sw); - dev_dbg(dev, "USB role switch handle not found: %d\n", ret); + dev_err_probe(dev, ret, "USB role switch handle not found\n"); goto role_sw_err; } From patchwork Tue Oct 3 00:34:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 147590 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1775495vqb; Mon, 2 Oct 2023 17:34:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKsryPWVsOSHCFlpBFCZ38ojS1Y54ziqWwWVpRAOHDhrquxfXrygvcvxM7NI2wpQym2Gbc X-Received: by 2002:a05:6808:118:b0:3a5:a4b4:f93e with SMTP id b24-20020a056808011800b003a5a4b4f93emr12423072oie.7.1696293291205; Mon, 02 Oct 2023 17:34:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696293291; cv=none; d=google.com; s=arc-20160816; b=tQP3Xvd8X6zKfLLBtgHupNW3MRjTupCv5u0D4Klk7vWQ75jkKKiZDzjID+i7Dybpvx y+epseXSO3TGU2ZK+xhmZyk92cRLVpUIR/70utpu1vkLT/yCTssUfDDhwJi3lhaMz9rl 7U5cNDnBLdQyp38Eo8AEyMhFbiAELeAZEoYJ/H/vbakCG7XsRyTvAsyk1lSawEVVpwp6 Y//yFaLVQQkL/Ua0Xg5Xoi4zN54DmuoPw9+qTQJoYCL1vZSwbhKgYmkNiO7Rmx5LVYqB 953ddQW2vA+5OKmJkrjOXQ7VVmadxZGmAgTbPEzJosqwJ4rgUEqXNN+synrMuY6u5hsq XwwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=L5aF3XmMYuXB9m+K+yR4UudzmAD6ahXZqfX5b3PlkQE=; fh=YJV7s35UDfTu410NGMNaxLgUC83Mipoa1f3x561mYKo=; b=m4IoYCorHJqSUS84vvy37NOHVJJ7fDT0MVe68QiTv0/4A922Wn7SDRL5WbCZGY66aV 8hTqBdH8l4qIWEJn6Ui08GHomataQUwIRSom1P056D2ba8FUxFEMMglb0iYwJK+aeK1m nU5qvKSZtBoGE0cLFSsUtWy7HdIQpB1ppkWtCga5vSetzz95ZEhGbf6Rpb4ti+LaQEjz HqFqb2WuEfR1djwBXhvPSiDuQQZRFKbxSFXWQ30gOem0aAecO6ZnZUaS1xIZYt9mWuuo vnrkWWdurXam62NcriOyFbmEOKvnX2+8ZwneTrXcKQGK9cpLhUNLIhF6qq+OItLvFfuw LInA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IytwKypd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id i30-20020a63585e000000b005775a4a2960si159321pgm.261.2023.10.02.17.34.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:34:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IytwKypd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E9D13824697D; Mon, 2 Oct 2023 17:34:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238924AbjJCAeq (ORCPT + 18 others); Mon, 2 Oct 2023 20:34:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229908AbjJCAei (ORCPT ); Mon, 2 Oct 2023 20:34:38 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3740CA1 for ; Mon, 2 Oct 2023 17:34:35 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-694f3444f94so263224b3a.2 for ; Mon, 02 Oct 2023 17:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696293274; x=1696898074; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L5aF3XmMYuXB9m+K+yR4UudzmAD6ahXZqfX5b3PlkQE=; b=IytwKypdFdUkI8XLCrk8w3O0hr8I2t72AyHHEWFlg897Se2Ngtm8B/uJ9S1H3KKh7S HS53rojFm/iBjoscCiBHmnHpAPaF+GYQC/hsLetXemp7Edj2IcnLBCFZaF0XbSnYsL95 Qwd+M4SFEmqf/l06NNu1ftVIRLpu7QUrsu/KE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696293274; x=1696898074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L5aF3XmMYuXB9m+K+yR4UudzmAD6ahXZqfX5b3PlkQE=; b=GaI6auzW7s+kiqXm3XvL00asAJltysRxkh1SrIgD5IoEyTSh9IH2or7t55lhpJoRZt nIZm2M0anU3Qt1/kLCCHDj+SqjPFSSLY90fEQBVAlOMa7g1bIbNjGVaRpPetz0U5g15Y dorJ4RfneIAzOirA5HpJngreINpMZz4SgLBcwRcyMMZCD5XyTkil9v2HotUvHba8bXxR 2YnsGNMpIdlZnMpI7tccGzWLHy8xa6XEe13j/0KgNhJX4dqW1mrVAVswiyYBVEPSyjlE snOqVfRSwz+0IpMkn/muB2baBcrhgF2AE1end0z8nfMeCrDeLELi8v4lD05LabrwEurW 073w== X-Gm-Message-State: AOJu0Yzl/fwItTroZxMRVTr9y8r22OCTr030PtqENENKQO5L5ufZ3qvR pNvg0X4UHt+TELWM5H+6OKGmnw== X-Received: by 2002:a05:6a00:b87:b0:693:3d55:2ba6 with SMTP id g7-20020a056a000b8700b006933d552ba6mr16207301pfj.9.1696293274608; Mon, 02 Oct 2023 17:34:34 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:11a:201:f676:8db:8677:aefe]) by smtp.gmail.com with ESMTPSA id bm2-20020a056a00320200b0068a13b0b300sm101368pfb.11.2023.10.02.17.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:34:34 -0700 (PDT) From: Stephen Boyd To: Benson Leung , Tzung-Bi Shih Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, Prashant Malani Subject: [PATCH 3/4] platform/chrome: cros_typec_vdm: Mark port_amode_ops const Date: Mon, 2 Oct 2023 17:34:27 -0700 Message-ID: <20231003003429.1378109-4-swboyd@chromium.org> X-Mailer: git-send-email 2.42.0.582.g8ccd20d70d-goog In-Reply-To: <20231003003429.1378109-1-swboyd@chromium.org> References: <20231003003429.1378109-1-swboyd@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 17:34:50 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778692434278301064 X-GMAIL-MSGID: 1778692434278301064 Mark this struct of functions const so it moves to RO memory. Cc: Prashant Malani Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_typec_vdm.c | 2 +- drivers/platform/chrome/cros_typec_vdm.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/chrome/cros_typec_vdm.c b/drivers/platform/chrome/cros_typec_vdm.c index 20515ee0a20e..3f632fd35000 100644 --- a/drivers/platform/chrome/cros_typec_vdm.c +++ b/drivers/platform/chrome/cros_typec_vdm.c @@ -142,7 +142,7 @@ static int cros_typec_port_amode_vdm(struct typec_altmode *amode, const u32 hdr, sizeof(req), NULL, 0); } -struct typec_altmode_ops port_amode_ops = { +const struct typec_altmode_ops port_amode_ops = { .enter = cros_typec_port_amode_enter, .vdm = cros_typec_port_amode_vdm, }; diff --git a/drivers/platform/chrome/cros_typec_vdm.h b/drivers/platform/chrome/cros_typec_vdm.h index 95a6a75d32b6..631bd2ce4b00 100644 --- a/drivers/platform/chrome/cros_typec_vdm.h +++ b/drivers/platform/chrome/cros_typec_vdm.h @@ -5,7 +5,7 @@ #include -extern struct typec_altmode_ops port_amode_ops; +extern const struct typec_altmode_ops port_amode_ops; void cros_typec_handle_vdm_attention(struct cros_typec_data *typec, int port_num); void cros_typec_handle_vdm_response(struct cros_typec_data *typec, int port_num); From patchwork Tue Oct 3 00:34:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 147591 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1775525vqb; Mon, 2 Oct 2023 17:34:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELcNhWascfOTWzhzO5JzvxEwCpREgWJd0OrxzXerGnYa7N26JyYziuEFH2ZFIfqUMfzYze X-Received: by 2002:a25:8548:0:b0:d77:fddd:c343 with SMTP id f8-20020a258548000000b00d77fdddc343mr10991589ybn.48.1696293297748; Mon, 02 Oct 2023 17:34:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696293297; cv=none; d=google.com; s=arc-20160816; b=SDfduyOiQQTq4QqwxL1dtd0idzJzHXTBjsPPFGlg1Twb+BBLiH5otp1Oc8Iit+B18R cHqDJ7BXNf6K84r49IzuEptcydnT8r6hgNPfjdDHfAoAc34A4K8lxuNe1XbINlFgk0Me 5u/TOuuphFN8Qkqm3aP9acHhGvdtGgSzUHx75mMZn2AXBacyA4IedgzoBmRNaoW6+eYv gsKWglKbQokfySgk+qoAAQJ6ft4F8IvOPNQv2sKyYAXQYRUzLbsj8ERBWDVg1gCjiZ+u TTBS7Q2wM6gcNVoWN5npE7CxEJse+liOibo+h4OvTT3KsGxWHGK4/dwn1Ujq0UpaTEIJ 2izw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ULFaUXbFksMdiOTX7EFeIrZO1zGruO/Y5COdeG+mbmw=; fh=YJV7s35UDfTu410NGMNaxLgUC83Mipoa1f3x561mYKo=; b=rmKam1SYKxl2W07EAO6SFkImNU/we2UdypCeA4e+qvhFwUmHSHwQG+YURzHoNDLHhT x1zqSbdaTVCikSB7zkFW/nPMoWvfXeNXOyG2xojcvyFTG0mllD9OxiJmsBbPKZPk4bEU FCBUK/shIi7CLpKyv2sBxjG1N770ZhFCvPH+A3DNTTfcdTyTQ2GmmbJ2Ep9XMk8AJCXj y9PDLPDJPhUaX0G3qITaWBFuI0vPNuOYTmU42a7tpZLWNyI9IEEZA8dyYVV1D5ATQlzg 6ufC46iKUQ9Dr0FQTWj+uRVnjhbHQXEeP1qXMRF6WG2+HoZaZftOzp8hVJ+v6WcaNpVs RnqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aCkqFxpo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id m133-20020a633f8b000000b00585a4fc83fbsi166487pga.255.2023.10.02.17.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:34:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aCkqFxpo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D746B8247742; Mon, 2 Oct 2023 17:34:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238919AbjJCAeu (ORCPT + 18 others); Mon, 2 Oct 2023 20:34:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbjJCAek (ORCPT ); Mon, 2 Oct 2023 20:34:40 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E057C6 for ; Mon, 2 Oct 2023 17:34:36 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-692779f583fso279364b3a.0 for ; Mon, 02 Oct 2023 17:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696293276; x=1696898076; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ULFaUXbFksMdiOTX7EFeIrZO1zGruO/Y5COdeG+mbmw=; b=aCkqFxpoJ1W/FvxslnLgbXWH7lmfgtEJ/BY9wVHdupH/enLEg1qCiifjUePo5vCvbs iC2AFdU4y1ufFuKo0J2z1ud5g7HhhA7Y7UodaHOUqI3m8I5osY2FZIL0PVEXkwNByqRH XMhGrOxFxTTZ4ZKwFvkztkQ+QOOIChQwOUTbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696293276; x=1696898076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ULFaUXbFksMdiOTX7EFeIrZO1zGruO/Y5COdeG+mbmw=; b=MRuF+dGONLbGbaaBS204u4ygVeiwglw7iemLpy5wx74utg2NSDKyWVyve9dziX32Wh HEIa9n3bAmfWEPbcn3KLxdvjPKPT+1m4f83Ba9TfA/d3T7FHxSOGqvhecK5pfTxN3bvp 0JTc+goQ97r7TCs9zqDBgiJSX8jEM+stzO8dsijwivvQeOi9Lyv7fB/GKtzoUeANGA5f t2BYykbPXcMHW4BtU+smt5A4c6NFwYyYa5Xf9YnOIFsupt88PP5AESJMVZbWiz43Q3Ux 14daJCr/MqRBCz1JwTIS7espiUzTb9BKT2UNEPf/m91r9xxjn0RgsoHeFdobfnqHrW9X KMzw== X-Gm-Message-State: AOJu0Yyq6wGIEuLJIFMWJzWZnbi/vKsNGgOC+gCegY4VqWG68mKK0NJM U++QKes40usJAuOJNkNQjpXEUAvNUlr8iHJ/IIs= X-Received: by 2002:a05:6a00:1787:b0:68e:2478:d6c9 with SMTP id s7-20020a056a00178700b0068e2478d6c9mr13123617pfg.2.1696293275992; Mon, 02 Oct 2023 17:34:35 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:11a:201:f676:8db:8677:aefe]) by smtp.gmail.com with ESMTPSA id bm2-20020a056a00320200b0068a13b0b300sm101368pfb.11.2023.10.02.17.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:34:35 -0700 (PDT) From: Stephen Boyd To: Benson Leung , Tzung-Bi Shih Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, Prashant Malani Subject: [PATCH 4/4] platform/chrome: cros_ec_proto: Mark outdata as const Date: Mon, 2 Oct 2023 17:34:28 -0700 Message-ID: <20231003003429.1378109-5-swboyd@chromium.org> X-Mailer: git-send-email 2.42.0.582.g8ccd20d70d-goog In-Reply-To: <20231003003429.1378109-1-swboyd@chromium.org> References: <20231003003429.1378109-1-swboyd@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 17:34:57 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778692441292387032 X-GMAIL-MSGID: 1778692441292387032 The 'outdata' is copied to the data buffer in cros_ec_cmd() before being sent over to the EC. Mark the argument as const so that callers can pass const pointers to this function and so that callers know the data won't be modified. Cc: Prashant Malani Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_ec_proto.c | 2 +- include/linux/platform_data/cros_ec_proto.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c index 475a6dd72db6..945b1b15a04c 100644 --- a/drivers/platform/chrome/cros_ec_proto.c +++ b/drivers/platform/chrome/cros_ec_proto.c @@ -1004,7 +1004,7 @@ EXPORT_SYMBOL_GPL(cros_ec_get_sensor_count); int cros_ec_cmd(struct cros_ec_device *ec_dev, unsigned int version, int command, - void *outdata, + const void *outdata, size_t outsize, void *indata, size_t insize) diff --git a/include/linux/platform_data/cros_ec_proto.h b/include/linux/platform_data/cros_ec_proto.h index 4f9f756bc17c..8865e350c12a 100644 --- a/include/linux/platform_data/cros_ec_proto.h +++ b/include/linux/platform_data/cros_ec_proto.h @@ -258,7 +258,7 @@ bool cros_ec_check_features(struct cros_ec_dev *ec, int feature); int cros_ec_get_sensor_count(struct cros_ec_dev *ec); -int cros_ec_cmd(struct cros_ec_device *ec_dev, unsigned int version, int command, void *outdata, +int cros_ec_cmd(struct cros_ec_device *ec_dev, unsigned int version, int command, const void *outdata, size_t outsize, void *indata, size_t insize); /**