From patchwork Fri Sep 29 17:39:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 146758 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp21703vqb; Fri, 29 Sep 2023 13:20:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSBJVxAmmZhylvmf/5ZWMNNRb63QSgbNDV0DWuFsd19qjHcvAU29lTs120+fbq0viMvVyD X-Received: by 2002:a05:6a21:6da3:b0:15a:2c0b:6c73 with SMTP id wl35-20020a056a216da300b0015a2c0b6c73mr6667738pzb.12.1696018857021; Fri, 29 Sep 2023 13:20:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696018857; cv=none; d=google.com; s=arc-20160816; b=wMwba1P+cfKchQv7ujFeY6hWjuoZ/R7IOKP+KTFTXzK2dfxNs24YSWJZ0d1Xelsrtm M6yUkYZ2EeA+CVzcVThpu32kBJffCihyZF0YLiTqrHmxi+1NIFYiR/zsauUGruG+BbRN LPE+HkR48Ae8l3awlHQ052I0a/BuxYPxSG6bqw+i2p51P7uaLCXBCHv3ph5il6Oo86hG s/L/teOd5It6qTaAOW3nA/2awBww6KbbQOuv9i6Seuk9dbhW5WNbnojuAdQJzLQL3UhS EsLrOed0ek9lSMCXpn5tUf2tsqA7vaPhGoyzaeALA5wti1Y7FX8rlglaTIrSKZdexqdP wUAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=uA9XK8E7/6R+QMcu0HmvQ9D0Jr37mtSddcB/J0TCnlo=; fh=pqXxjzc7zV6c0FZ/rb/NmcR4vRIbdxyF35OEhIBQUys=; b=zF+KTD/xlWiJv29iAwfkmTfTQL05gW8xrjLA8ik2jeYSXGxRaG3dSY4b59umvvI7t/ eKFd66fiOYf6r7eQruTlSeAAe27XjWGlg7XE//sTx4NamYsQUWCwgtgQe2rs3YMNBLJL 0kaYHGp6OZ+4gONBHGR/hvzeXBO3FguebA99qZjqm3JpAIvonDzEFNtld22bJOKPsRCr 0czXc6kKQJ8qLnJ3dEJA4a8sf+ag2wVAIyY0fOOZc4gug5ocStxdJAINDHTFTAiOyMuA J6HiG/KLKEVwVHjc46b/BF2v0hbvIdJ4snyFsl5sqL+TKm1qRuyjnZ1cNHwp7qSP063z svIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=mYmvzhSA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id jp10-20020a17090ae44a00b0026b09e2e3eesi489219pjb.47.2023.09.29.13.20.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 13:20:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=mYmvzhSA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 612D18031AE3; Fri, 29 Sep 2023 10:39:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233233AbjI2RjU (ORCPT + 19 others); Fri, 29 Sep 2023 13:39:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232923AbjI2RjS (ORCPT ); Fri, 29 Sep 2023 13:39:18 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77AE4195; Fri, 29 Sep 2023 10:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1696009154; bh=W5xM3Txn9PEOVtEBA1zRK/LCXQhgKhgHvmFCijy64WI=; h=From:Date:Subject:To:Cc:From; b=mYmvzhSAvNPEUX4++pDCcwGZX82vBn8zpTox1N/nKOcaWJ/XNUQFvC64j1Sivcjeb BI5pvqdk0lYwwsuYb/bbSSRhXikXMO4e5tizZwZQdVrh/R2Rd8WH4Yo/TPKlXlfkby MAguxAZx6BCu8u1Ba4gZZu/oWpCTy49cHi+Tw23c= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Fri, 29 Sep 2023 19:39:00 +0200 Subject: [PATCH] power: supply: core: remove opencoded string_lower() MIME-Version: 1.0 Message-Id: <20230929-power_supply-string_lower-v1-1-3141a2634d53@weissschuh.net> X-B4-Tracking: v=1; b=H4sIALMLF2UC/x2MWwqAMAzAriL9duAmKPMqIiJatSBztD4Z3t3pZ wJJAEEmFKiSAIwHCa0ugk4T6OfOTahoiAwmM3lmjVV+PZFb2b1fbiUbk5va5XMq14UebVkiFgZ i7xlHuv533TzPC0m8GyxrAAAA To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Thomas?= =?utf-8?q?_Wei=C3=9Fschuh?= X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1696009154; l=1573; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=W5xM3Txn9PEOVtEBA1zRK/LCXQhgKhgHvmFCijy64WI=; b=iCSDW/uuOBs5cAmRcRWMdP4nKFuq3RlYVhLVRLvmDfOGl9Rz0bJQ0M9WpROsOOdM9w59s+Yl/ MR9NyysF9vhDYmGw5EHd1mBHgtsIwl4a2vgElRfwGyUrNkaa61eTkKS X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, TVD_SUBJ_WIPE_DEBT autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 29 Sep 2023 10:39:23 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778404669384488578 X-GMAIL-MSGID: 1778404669384488578 string_lower from string_helpers.h can be used to modify the string in-place. Use it to get rid of the custom str_to_lower(). Signed-off-by: Thomas Weißschuh --- drivers/power/supply/power_supply_sysfs.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) --- base-commit: 71e58659bfc02e4171345f80b13d6485e9cdf687 change-id: 20230929-power_supply-string_lower-3161f977ee62 Best regards, diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c index d483a81560ab..977611e16373 100644 --- a/drivers/power/supply/power_supply_sysfs.c +++ b/drivers/power/supply/power_supply_sysfs.c @@ -15,6 +15,7 @@ #include #include #include +#include #include "power_supply.h" @@ -398,14 +399,6 @@ static const struct attribute_group *power_supply_attr_groups[] = { NULL, }; -static void str_to_lower(char *str) -{ - while (*str) { - *str = tolower(*str); - str++; - } -} - void power_supply_init_attrs(struct device_type *dev_type) { int i; @@ -420,7 +413,8 @@ void power_supply_init_attrs(struct device_type *dev_type) __func__, i); sprintf(power_supply_attrs[i].attr_name, "_err_%d", i); } else { - str_to_lower(power_supply_attrs[i].attr_name); + string_lower(power_supply_attrs[i].attr_name, + power_supply_attrs[i].attr_name); } attr = &power_supply_attrs[i].dev_attr;